mika kuns
b5464fc533
TryInvokeAsync catches every exception and returns null, which is fine
for read-only calls but hid real HubException reasons behind a generic
"offline" message for the 7 mutating call sites (RestoreDefaultAgents,
UpsertPrimeSchedule, AddDailyNote, CleanupFinishedWorktrees,
ResetAllWorktrees, ForceRemoveWorktree, BuildPlanningIntegrationBranch)
— the same bug class fixed for ApproveReview in e1807fd. Each of the 22
TryInvokeAsync call sites was audited; the 15 read-only ones are left
unchanged (empty/offline is the right display). For the 7 switched to
a direct hub invoke, every caller was checked and, where it had no
catch, one was added so the exception surfaces (StatusMessage,
ShowErrorAsync/CombinedWarning) instead of crashing.
66 lines
2.3 KiB
C#
66 lines
2.3 KiB
C#
using System.IO;
|
|
using ClaudeDo.Localization;
|
|
using ClaudeDo.Ui.Localization;
|
|
using ClaudeDo.Ui.Services;
|
|
using ClaudeDo.Ui.ViewModels.Modals;
|
|
|
|
namespace ClaudeDo.Ui.Tests.ViewModels;
|
|
|
|
public class WorktreesOverviewModalErrorTests
|
|
{
|
|
public WorktreesOverviewModalErrorTests()
|
|
{
|
|
var dir = AppContext.BaseDirectory;
|
|
while (dir is not null && !Directory.Exists(Path.Combine(dir, "src", "ClaudeDo.Localization", "locales")))
|
|
dir = Path.GetDirectoryName(dir);
|
|
Loc.Current = new Localizer(
|
|
LocaleStore.Load(Path.Combine(dir!, "src", "ClaudeDo.Localization", "locales")), "en");
|
|
}
|
|
|
|
private sealed class ThrowingWorker : StubWorkerClient
|
|
{
|
|
public string ExceptionMessage { get; init; } = "worktree is locked by another process";
|
|
public override Task<WorktreeCleanupDto?> CleanupFinishedWorktreesAsync(string? listId = null) =>
|
|
throw new Exception(ExceptionMessage);
|
|
public override Task<ForceRemoveResultDto?> ForceRemoveWorktreeAsync(string taskId) =>
|
|
throw new Exception(ExceptionMessage);
|
|
}
|
|
|
|
private static WorktreesOverviewModalViewModel NewVm(ThrowingWorker worker) =>
|
|
new(worker, () => null!, new MergeCoordinator());
|
|
|
|
[Fact]
|
|
public async Task CleanupFinished_WhenWorkerThrows_ShowsExceptionMessage()
|
|
{
|
|
var worker = new ThrowingWorker();
|
|
var vm = NewVm(worker);
|
|
|
|
await vm.CleanupFinishedCommand.ExecuteAsync(null);
|
|
|
|
Assert.NotNull(vm.StatusMessage);
|
|
Assert.Contains(worker.ExceptionMessage, vm.StatusMessage);
|
|
Assert.False(vm.IsBusy);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ForceRemove_WhenWorkerThrows_ShowsExceptionMessage_AndKeepsRow()
|
|
{
|
|
var worker = new ThrowingWorker();
|
|
var vm = NewVm(worker);
|
|
var row = new WorktreeOverviewRowViewModel
|
|
{
|
|
TaskId = "task-1",
|
|
TaskTitle = "Task 1",
|
|
TaskStatus = ClaudeDo.Data.Models.TaskStatus.Idle,
|
|
State = ClaudeDo.Data.Models.WorktreeState.Active,
|
|
};
|
|
vm.AddRowForTest(row);
|
|
|
|
await vm.ForceRemoveCommand.ExecuteAsync(row);
|
|
|
|
Assert.NotNull(vm.StatusMessage);
|
|
Assert.Contains(worker.ExceptionMessage, vm.StatusMessage);
|
|
Assert.Contains(row, vm.Rows);
|
|
}
|
|
}
|