releases/ClaudeDo
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 3 Wiki Activity

Planning UI followups #6

Open
claude wants to merge 2 commits from feat/planning-ui-followups into main
pull from: feat/planning-ui-followups
merge into: releases:main
Conversation 0 Commits 2 Files Changed 4 +9 -6
claude commented 2026-04-23 17:53:43 +00:00
Owner
Copy Link

Summary

Two non-blocking followups from the Plan C code review.

  • fix(ui): Planned status uses blue badge style - split the single badge planning Border into two (one for IsPlanning, one for IsPlanned) so .badge.planned (blue, #3182CE) is actually reachable. Previously Planned rows rendered with the amber Planning color. Added IsPlanning / IsPlanned computed properties on TaskRowViewModel, raised in OnStatusChanged.
  • refactor(ui): remove unused Instance statics on bool converters - BoolToItalicConverter.Instance and BoolToDraftOpacityConverter.Instance were never referenced (converters are registered via App.axaml resources). Deleted both.

Test plan

  • dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj - 0 errors
  • dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj - 0 errors
  • 8 planning VM tests pass (TaskRowViewModelPlanningTests, TasksIslandPlanningTests)
  • Manual visual verification - seed Status=Planning (amber PLANNING badge), flip to Status=Planned (blue PLANNED badge), add Draft child (indented, italic, faded, grey DRAFT badge, chevron collapses/expands).
## Summary Two non-blocking followups from the Plan C code review. - **fix(ui): Planned status uses blue badge style** - split the single `badge planning` Border into two (one for `IsPlanning`, one for `IsPlanned`) so `.badge.planned` (blue, `#3182CE`) is actually reachable. Previously Planned rows rendered with the amber Planning color. Added `IsPlanning` / `IsPlanned` computed properties on `TaskRowViewModel`, raised in `OnStatusChanged`. - **refactor(ui): remove unused Instance statics on bool converters** - `BoolToItalicConverter.Instance` and `BoolToDraftOpacityConverter.Instance` were never referenced (converters are registered via `App.axaml` resources). Deleted both. ## Test plan - [x] `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj` - 0 errors - [x] `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj` - 0 errors - [x] 8 planning VM tests pass (`TaskRowViewModelPlanningTests`, `TasksIslandPlanningTests`) - [ ] Manual visual verification - seed Status=Planning (amber PLANNING badge), flip to Status=Planned (blue PLANNED badge), add Draft child (indented, italic, faded, grey DRAFT badge, chevron collapses/expands).
claude added 2 commits 2026-04-23 17:53:43 +00:00
fix(ui): Planned status uses blue badge style e7d595244e 
Previously both Planning and Planned rendered the same amber badge because a
single <Border class="badge planning"> was used. Split into two borders gated
by IsPlanning / IsPlanned so Planned picks up the blue badge.planned style.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
refactor(ui): remove unused Instance statics on bool converters 09b52140ce 
App.axaml registers these converters via the resource dictionary; the static
Instance members were never referenced.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This pull request has changes conflicting with the target branch.
  • src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/planning-ui-followups:feat/planning-ui-followups
git checkout feat/planning-ui-followups
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claude
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: releases/ClaudeDo#6
Delete Branch "feat/planning-ui-followups"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?