feat(cleanup): hide and prune stale mailboxes
Mailbox listings grew unbounded as old sessions ended without unregistering. This adds two layers of cleanup, configurable via mailbox.json or `serve` flags: - Lazy filter: list responses (REST /v1/list, MCP list_mailboxes) drop mailboxes idle longer than hideAfterMinutes (default 24h), while always keeping the caller and any sender with messages pending for them. - Background sweep: startServer runs an initial prune on boot and schedules an unref'd interval timer that hard-deletes mailboxes idle longer than deleteAfterMinutes (default 7d) which have no pending messages, and wipes their delivered history.
This commit is contained in:
@@ -2,6 +2,7 @@ import { describe, it, expect, afterEach, beforeEach } from "vitest";
|
||||
import { mkdtempSync, rmSync } from "node:fs";
|
||||
import { tmpdir } from "node:os";
|
||||
import { join } from "node:path";
|
||||
import { DatabaseSync } from "node:sqlite";
|
||||
import { MailboxStore } from "../src/db.js";
|
||||
import { buildServer } from "../src/server.js";
|
||||
import type { FastifyInstance } from "fastify";
|
||||
@@ -16,7 +17,17 @@ beforeEach(async () => {
|
||||
dir = mkdtempSync(join(tmpdir(), "claude-mailbox-srv-"));
|
||||
dbPath = join(dir, "test.db");
|
||||
store = new MailboxStore(dbPath);
|
||||
app = await buildServer({ port: 0, bind: "127.0.0.1", dbPath }, store);
|
||||
app = await buildServer(
|
||||
{
|
||||
port: 0,
|
||||
bind: "127.0.0.1",
|
||||
dbPath,
|
||||
hideAfterMinutes: 0,
|
||||
deleteAfterMinutes: 0,
|
||||
sweepIntervalMinutes: 0,
|
||||
},
|
||||
store,
|
||||
);
|
||||
await app.listen({ host: "127.0.0.1", port: 0 });
|
||||
const addr = app.server.address();
|
||||
if (!addr || typeof addr === "string") throw new Error("no address");
|
||||
@@ -151,6 +162,42 @@ describe("REST surface", () => {
|
||||
expect(missingTo.status).toBe(400);
|
||||
});
|
||||
|
||||
it("/v1/list filters out mailboxes idle beyond hideAfterMinutes", async () => {
|
||||
await app.close();
|
||||
store.close();
|
||||
store = new MailboxStore(dbPath);
|
||||
store.upsertMailbox("recent");
|
||||
store.upsertMailbox("stale");
|
||||
store.close();
|
||||
const handle = new DatabaseSync(dbPath);
|
||||
const past = new Date(Date.now() - 120 * 60_000).toISOString();
|
||||
handle.prepare("UPDATE mailboxes SET last_seen_at = ? WHERE name = ?").run(past, "stale");
|
||||
handle.close();
|
||||
|
||||
store = new MailboxStore(dbPath);
|
||||
app = await buildServer(
|
||||
{
|
||||
port: 0,
|
||||
bind: "127.0.0.1",
|
||||
dbPath,
|
||||
hideAfterMinutes: 60,
|
||||
deleteAfterMinutes: 0,
|
||||
sweepIntervalMinutes: 0,
|
||||
},
|
||||
store,
|
||||
);
|
||||
await app.listen({ host: "127.0.0.1", port: 0 });
|
||||
const addr = app.server.address();
|
||||
if (!addr || typeof addr === "string") throw new Error("no address");
|
||||
baseUrl = `http://127.0.0.1:${addr.port}`;
|
||||
|
||||
const r = await call("GET", "/v1/list");
|
||||
expect(r.status).toBe(200);
|
||||
const names = (r.body as Array<{ name: string }>).map((m) => m.name);
|
||||
expect(names).toContain("recent");
|
||||
expect(names).not.toContain("stale");
|
||||
});
|
||||
|
||||
it("/v1/list and /v1/peek are anonymous", async () => {
|
||||
await call("POST", "/v1/send", {
|
||||
headers: { "X-Mailbox": "alice" },
|
||||
|
||||
Reference in New Issue
Block a user