Data: folder delete keeps its lists (ON DELETE SET NULL), rename patches name/icon without resetting sort order or collapse state. Sidebar: grouping on load, folder badge as the sum of its children, both move routes, and the persisted collapse state. Drops the LoadAsync/AddRowAsync normalization of a dangling folder_id: FK enforcement is on for every connection, so the row it guarded against cannot exist, and ContainerOf already falls back to the top level.
225 lines
7.5 KiB
C#
225 lines
7.5 KiB
C#
using ClaudeDo.Data;
|
|
using ClaudeDo.Data.Models;
|
|
using ClaudeDo.Data.Repositories;
|
|
using ClaudeDo.Localization;
|
|
using ClaudeDo.Ui.Localization;
|
|
using ClaudeDo.Ui.ViewModels.Islands;
|
|
using Microsoft.EntityFrameworkCore;
|
|
|
|
namespace ClaudeDo.Ui.Tests.ViewModels;
|
|
|
|
/// <summary>
|
|
/// Sidebar folders: grouping on load, the folder badge, and the two ways a list changes folder
|
|
/// (dropped onto a row in another container, dropped onto a folder header).
|
|
/// </summary>
|
|
public class ListsIslandFolderTests : IDisposable
|
|
{
|
|
private readonly string _dbPath;
|
|
|
|
public ListsIslandFolderTests()
|
|
{
|
|
_dbPath = Path.Combine(Path.GetTempPath(), $"claudedo_lists_folders_test_{Guid.NewGuid():N}.db");
|
|
using var ctx = NewContext();
|
|
ctx.Database.EnsureCreated();
|
|
|
|
var dir = AppContext.BaseDirectory;
|
|
while (dir is not null && !Directory.Exists(Path.Combine(dir, "src", "ClaudeDo.Localization", "locales")))
|
|
dir = Path.GetDirectoryName(dir);
|
|
Loc.Current = new Localizer(
|
|
LocaleStore.Load(Path.Combine(dir!, "src", "ClaudeDo.Localization", "locales")), "en");
|
|
}
|
|
|
|
public void Dispose()
|
|
{
|
|
foreach (var suffix in new[] { "", "-wal", "-shm" })
|
|
try { File.Delete(_dbPath + suffix); } catch { }
|
|
}
|
|
|
|
private ClaudeDoDbContext NewContext()
|
|
{
|
|
var opts = new DbContextOptionsBuilder<ClaudeDoDbContext>()
|
|
.UseSqlite($"Data Source={_dbPath}")
|
|
.Options;
|
|
return new ClaudeDoDbContext(opts);
|
|
}
|
|
|
|
private sealed class FakeWorker : StubWorkerClient
|
|
{
|
|
public override bool IsConnected => true;
|
|
}
|
|
|
|
private async Task SeedAsync(string? folderId = null, params (string Id, string Name, int Sort)[] lists)
|
|
{
|
|
await using var db = NewContext();
|
|
if (folderId is not null)
|
|
db.ListFolders.Add(new ListFolderEntity { Id = folderId, Name = $"Folder {folderId}", CreatedAt = DateTime.UtcNow });
|
|
foreach (var (id, name, sort) in lists)
|
|
db.Lists.Add(new ListEntity { Id = id, Name = name, SortOrder = sort, CreatedAt = DateTime.UtcNow, FolderId = folderId });
|
|
await db.SaveChangesAsync();
|
|
}
|
|
|
|
private async Task SeedTaskAsync(string listId, int number)
|
|
{
|
|
await using var db = NewContext();
|
|
db.Tasks.Add(new TaskEntity
|
|
{
|
|
Id = Guid.NewGuid().ToString("N"),
|
|
Number = number,
|
|
ListId = listId,
|
|
Title = "T",
|
|
Status = Data.Models.TaskStatus.Idle,
|
|
CreatedAt = DateTime.UtcNow,
|
|
});
|
|
await db.SaveChangesAsync();
|
|
}
|
|
|
|
private ListsIslandViewModel NewVm() => new(new TestDbFactory(NewContext), worker: new FakeWorker());
|
|
|
|
[Fact]
|
|
public async Task LoadAsync_puts_lists_into_their_folder_and_leaves_the_rest_at_the_top_level()
|
|
{
|
|
await SeedAsync("f1", ("inside", "Inside", 0));
|
|
await SeedAsync(null, ("outside", "Outside", 1));
|
|
|
|
var vm = NewVm();
|
|
await vm.LoadAsync();
|
|
|
|
var folder = Assert.Single(vm.Folders);
|
|
Assert.Equal("Inside", Assert.Single(folder.Lists).Name);
|
|
Assert.Equal("Outside", Assert.Single(vm.RootLists).Name);
|
|
// UserLists stays the flat superset — counts and row refreshes work over it.
|
|
Assert.Equal(2, vm.UserLists.Count);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task Folder_count_is_the_sum_of_its_lists()
|
|
{
|
|
await SeedAsync("f1", ("a", "A", 0), ("b", "B", 1));
|
|
await SeedTaskAsync("a", 1);
|
|
await SeedTaskAsync("b", 2);
|
|
await SeedTaskAsync("b", 3);
|
|
|
|
var vm = NewVm();
|
|
await vm.LoadAsync();
|
|
|
|
Assert.Equal(3, Assert.Single(vm.Folders).Count);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task MoveToFolderAsync_moves_a_top_level_list_into_the_folder_and_persists_it()
|
|
{
|
|
await SeedAsync("f1", ("inside", "Inside", 0));
|
|
await SeedAsync(null, ("mover", "Mover", 1));
|
|
|
|
var vm = NewVm();
|
|
await vm.LoadAsync();
|
|
var mover = vm.RootLists.Single(r => r.Id == "user:mover");
|
|
|
|
await vm.MoveToFolderAsync(mover, vm.Folders[0]);
|
|
|
|
Assert.Empty(vm.RootLists);
|
|
Assert.Equal(2, vm.Folders[0].Lists.Count);
|
|
Assert.Equal("f1", mover.FolderId);
|
|
|
|
await using var db = NewContext();
|
|
Assert.Equal("f1", (await db.Lists.AsNoTracking().FirstAsync(l => l.Id == "mover")).FolderId);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task MoveToFolderAsync_with_no_folder_takes_a_list_back_out()
|
|
{
|
|
await SeedAsync("f1", ("inside", "Inside", 0));
|
|
|
|
var vm = NewVm();
|
|
await vm.LoadAsync();
|
|
var row = vm.Folders[0].Lists.Single();
|
|
|
|
await vm.MoveToFolderAsync(row, null);
|
|
|
|
Assert.Empty(vm.Folders[0].Lists);
|
|
Assert.Same(row, Assert.Single(vm.RootLists));
|
|
Assert.Null(row.FolderId);
|
|
|
|
await using var db = NewContext();
|
|
Assert.Null((await db.Lists.AsNoTracking().FirstAsync(l => l.Id == "inside")).FolderId);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ReorderAsync_onto_a_row_in_another_container_also_changes_the_folder()
|
|
{
|
|
await SeedAsync("f1", ("inside", "Inside", 0));
|
|
await SeedAsync(null, ("mover", "Mover", 1));
|
|
|
|
var vm = NewVm();
|
|
await vm.LoadAsync();
|
|
var mover = vm.RootLists.Single();
|
|
var inside = vm.Folders[0].Lists.Single();
|
|
|
|
await vm.ReorderAsync(mover, inside, placeBelow: false);
|
|
|
|
Assert.Empty(vm.RootLists);
|
|
Assert.Equal(["Mover", "Inside"], vm.Folders[0].Lists.Select(l => l.Name));
|
|
Assert.Equal("f1", mover.FolderId);
|
|
|
|
await using var db = NewContext();
|
|
var stored = await db.Lists.AsNoTracking().ToListAsync();
|
|
Assert.Equal("f1", stored.Single(l => l.Id == "mover").FolderId);
|
|
// sort_order is written as one global sequence in sidebar order: folder contents first.
|
|
Assert.Equal(0, stored.Single(l => l.Id == "mover").SortOrder);
|
|
Assert.Equal(1, stored.Single(l => l.Id == "inside").SortOrder);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ReorderAsync_within_a_folder_keeps_the_folder()
|
|
{
|
|
await SeedAsync("f1", ("a", "A", 0), ("b", "B", 1));
|
|
|
|
var vm = NewVm();
|
|
await vm.LoadAsync();
|
|
var a = vm.Folders[0].Lists[0];
|
|
var b = vm.Folders[0].Lists[1];
|
|
|
|
await vm.ReorderAsync(b, a, placeBelow: false);
|
|
|
|
Assert.Equal(["B", "A"], vm.Folders[0].Lists.Select(l => l.Name));
|
|
Assert.All(vm.Folders[0].Lists, l => Assert.Equal("f1", l.FolderId));
|
|
}
|
|
|
|
[Fact]
|
|
public async Task ToggleFolder_flips_and_persists_the_collapse_state()
|
|
{
|
|
await SeedAsync("f1", ("inside", "Inside", 0));
|
|
|
|
var vm = NewVm();
|
|
await vm.LoadAsync();
|
|
var folder = vm.Folders[0];
|
|
Assert.False(folder.IsCollapsed);
|
|
|
|
await vm.ToggleFolderCommand.ExecuteAsync(folder);
|
|
|
|
Assert.True(folder.IsCollapsed);
|
|
await using var db = NewContext();
|
|
Assert.True((await db.ListFolders.AsNoTracking().FirstAsync(f => f.Id == "f1")).IsCollapsed);
|
|
|
|
// And the state survives a reload.
|
|
var reloaded = NewVm();
|
|
await reloaded.LoadAsync();
|
|
Assert.True(reloaded.Folders[0].IsCollapsed);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task RemoveFromFolder_command_is_the_context_menu_route_out()
|
|
{
|
|
await SeedAsync("f1", ("inside", "Inside", 0));
|
|
|
|
var vm = NewVm();
|
|
await vm.LoadAsync();
|
|
var row = vm.Folders[0].Lists.Single();
|
|
|
|
await vm.RemoveFromFolderCommand.ExecuteAsync(row);
|
|
|
|
Assert.Null(row.FolderId);
|
|
Assert.Single(vm.RootLists);
|
|
}
|
|
}
|