Mika Kuns
299c7b749c
update_task_status Idle/Done, WorkerHub.SetTaskStatus, and the UI's Mark Done/Cancelled menu items could all force a Running task's status without going through TaskStateService's guards, leaving its CLI process untracked and its worktree writes silently dropped. Idle now routes through the already-guarded TaskStateService.ResetToIdleAsync instead of the repo's unconditional ResetToManualAsync; Done and SetTaskStatus explicitly reject Running; the context menu disables both entries with a tooltip while running. TaskRunner also now logs a warning whenever a terminal transition (SubmitForChildren/SubmitForReview/Complete/Fail) is rejected instead of silently discarding the run result. DeleteTask's MCP path gets the same friendly foreign-key message WorkerHub.DeleteTask already had for a task with children.
87 lines
2.8 KiB
C#
87 lines
2.8 KiB
C#
using ClaudeDo.Data.Models;
|
|
using ClaudeDo.Data.Repositories;
|
|
using ClaudeDo.Worker.Hub;
|
|
using ClaudeDo.Worker.Tests.Infrastructure;
|
|
using Microsoft.AspNetCore.SignalR;
|
|
using Microsoft.EntityFrameworkCore;
|
|
using Xunit;
|
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
|
|
|
namespace ClaudeDo.Worker.Tests.Hub;
|
|
|
|
public sealed class SetTaskStatusHubTests : IDisposable
|
|
{
|
|
private readonly DbFixture _db = new();
|
|
|
|
public void Dispose() => _db.Dispose();
|
|
|
|
private WorkerHub CreateHub()
|
|
{
|
|
var factory = _db.CreateFactory();
|
|
var built = TaskStateServiceBuilder.Build(factory);
|
|
var broadcaster = new HubBroadcaster(new CapturingHubContext());
|
|
var hub = new WorkerHub(
|
|
null!, null!, null!, null!, broadcaster, factory,
|
|
null!, null!, null!, null!, null!, null!, null!, null!, null!, null!,
|
|
built.State,
|
|
null!, null!,
|
|
null!, new ClaudeDo.Worker.Online.OnlineInboxConfig(), new ClaudeDo.Worker.Online.OnlineTokenStore(),
|
|
new ClaudeDo.Worker.Runner.PendingQuestionRegistry(), null!);
|
|
hub.Clients = new FakeHubCallerClients(new RecordingClientProxy());
|
|
hub.Context = new FakeHubCallerContext();
|
|
return hub;
|
|
}
|
|
|
|
private async Task<string> SeedTaskAsync(TaskStatus status)
|
|
{
|
|
using var ctx = _db.CreateContext();
|
|
var listId = Guid.NewGuid().ToString();
|
|
await new ListRepository(ctx).AddAsync(new ListEntity
|
|
{
|
|
Id = listId, Name = "L", CreatedAt = DateTime.UtcNow,
|
|
});
|
|
|
|
var taskId = Guid.NewGuid().ToString();
|
|
await new TaskRepository(ctx).AddAsync(new TaskEntity
|
|
{
|
|
Id = taskId, ListId = listId, Title = "T",
|
|
Status = status, CreatedAt = DateTime.UtcNow, CommitType = "feat",
|
|
});
|
|
return taskId;
|
|
}
|
|
|
|
[Fact]
|
|
public async Task SetTaskStatus_RunningTask_Throws_AndLeavesStatusUnchanged()
|
|
{
|
|
var taskId = await SeedTaskAsync(TaskStatus.Running);
|
|
var hub = CreateHub();
|
|
|
|
await Assert.ThrowsAsync<HubException>(() => hub.SetTaskStatus(taskId, "Done"));
|
|
|
|
await using var ctx = _db.CreateContext();
|
|
var task = await ctx.Tasks.FindAsync(taskId);
|
|
Assert.Equal(TaskStatus.Running, task!.Status);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task SetTaskStatus_IdleTask_StillSucceeds()
|
|
{
|
|
var taskId = await SeedTaskAsync(TaskStatus.Idle);
|
|
var hub = CreateHub();
|
|
|
|
await hub.SetTaskStatus(taskId, "Cancelled");
|
|
|
|
await using var ctx = _db.CreateContext();
|
|
var task = await ctx.Tasks.FindAsync(taskId);
|
|
Assert.Equal(TaskStatus.Cancelled, task!.Status);
|
|
}
|
|
|
|
[Fact]
|
|
public async Task SetTaskStatus_Missing_Throws()
|
|
{
|
|
var hub = CreateHub();
|
|
|
|
await Assert.ThrowsAsync<HubException>(() => hub.SetTaskStatus("does-not-exist", "Done"));
|
|
}
|
|
}
|