Files
ClaudeDo/tests/ClaudeDo.Ui.Tests/ViewModels/DetailsIslandTaskUpdatedTests.cs
T
mika kuns 8d7ba1e314 test(ui): poll for the debounced skill auto-save instead of a fixed sleep
Task_toggling_a_skill_auto_saves_selection waited a hard 500 ms for a
debounced save. It passed in isolation and in either half of the suite,
but failed in a full run: this batch added three DB-backed UI test
classes whose real SQLite contexts load the thread pool enough that the
timer callback misses the window. Product code is unchanged.

Same assertion, polled with a 5 s deadline - the pattern the newly added
DetailsIsland/TasksIsland tests already use.
2026-08-05 09:43:13 +02:00

128 lines
4.5 KiB
C#

using ClaudeDo.Data;
using ClaudeDo.Data.Models;
using ClaudeDo.Ui.Services;
using ClaudeDo.Ui.ViewModels.Islands;
using Microsoft.EntityFrameworkCore;
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
namespace ClaudeDo.Ui.Tests.ViewModels;
// A status change on the task bound in the detail pane can come from outside the UI (worker run,
// MCP tool, another session) and must refresh the pane's Task without waiting for a list reload.
public class DetailsIslandTaskUpdatedTests : IDisposable
{
private readonly string _dbPath;
public DetailsIslandTaskUpdatedTests()
{
_dbPath = Path.Combine(Path.GetTempPath(), $"claudedo_details_taskupdated_{Guid.NewGuid():N}.db");
using var ctx = NewContext();
ctx.Database.EnsureCreated();
}
public void Dispose()
{
try { File.Delete(_dbPath); } catch { }
try { File.Delete(_dbPath + "-wal"); } catch { }
try { File.Delete(_dbPath + "-shm"); } catch { }
}
private ClaudeDoDbContext NewContext()
{
var opts = new DbContextOptionsBuilder<ClaudeDoDbContext>()
.UseSqlite($"Data Source={_dbPath}")
.Options;
return new ClaudeDoDbContext(opts);
}
private sealed class TestDbFactory : IDbContextFactory<ClaudeDoDbContext>
{
private readonly Func<ClaudeDoDbContext> _create;
public TestDbFactory(Func<ClaudeDoDbContext> create) => _create = create;
public ClaudeDoDbContext CreateDbContext() => _create();
}
private sealed class NullServiceProvider : IServiceProvider
{
public object? GetService(Type serviceType) => null;
}
private sealed class StubNotesApi : ClaudeDo.Ui.Services.Interfaces.INotesApi
{
public Task<List<DailyNoteDto>> ListAsync(DateOnly day) =>
Task.FromResult(new List<DailyNoteDto>());
public Task<DailyNoteDto?> AddAsync(DateOnly day, string text) =>
Task.FromResult<DailyNoteDto?>(null);
public Task UpdateAsync(string id, string text) => Task.CompletedTask;
public Task DeleteAsync(string id) => Task.CompletedTask;
}
private sealed class FakeWorker : StubWorkerClient
{
public override bool IsConnected => true;
}
private async Task SeedTaskAsync(string id, TaskStatus status)
{
await using var db = NewContext();
if (!await db.Lists.AnyAsync(l => l.Id == "L1"))
db.Lists.Add(new ListEntity { Id = "L1", Name = "Work", CreatedAt = DateTime.UtcNow });
db.Tasks.Add(new TaskEntity
{
Id = id, ListId = "L1", Title = "Task", Status = status, CreatedAt = DateTime.UtcNow,
});
await db.SaveChangesAsync();
}
private DetailsIslandViewModel BuildVm(StubWorkerClient worker) =>
new(new TestDbFactory(NewContext), worker, new NullServiceProvider(), new StubNotesApi(),
new ClaudeDo.Ui.Services.MergeCoordinator());
[Fact]
public async Task TaskUpdated_ForBoundTask_RefreshesStatus()
{
await SeedTaskAsync("t-bound-1", TaskStatus.Running);
var worker = new FakeWorker();
var vm = BuildVm(worker);
vm.Bind(new TaskRowViewModel { Id = "t-bound-1", Status = TaskStatus.Running });
await Task.Delay(50);
Assert.Equal(TaskStatus.Running, vm.Task?.Status);
await using (var db = NewContext())
{
(await db.Tasks.FirstAsync(t => t.Id == "t-bound-1")).Status = TaskStatus.WaitingForReview;
await db.SaveChangesAsync();
}
worker.RaiseTaskUpdated("t-bound-1");
var deadline = DateTime.UtcNow.AddSeconds(3);
while (DateTime.UtcNow < deadline && vm.Task?.Status != TaskStatus.WaitingForReview)
await Task.Delay(25);
Assert.Equal(TaskStatus.WaitingForReview, vm.Task?.Status);
}
[Fact]
public async Task TaskUpdated_ForADifferentTask_DoesNotTouchBoundTask()
{
await SeedTaskAsync("t-bound-2", TaskStatus.Running);
await SeedTaskAsync("t-other-2", TaskStatus.Idle);
var worker = new FakeWorker();
var vm = BuildVm(worker);
vm.Bind(new TaskRowViewModel { Id = "t-bound-2", Status = TaskStatus.Running });
await using (var db = NewContext())
{
(await db.Tasks.FirstAsync(t => t.Id == "t-other-2")).Status = TaskStatus.Done;
await db.SaveChangesAsync();
}
worker.RaiseTaskUpdated("t-other-2");
await Task.Delay(150);
Assert.Equal(TaskStatus.Running, vm.Task?.Status);
}
}