Submit for Review is now disabled while a ConPTY pane is starting, has failed to launch, or has already exited, and MissionControlViewModel guards against a rapid double-click racing two SubmitTaskForReviewAsync calls. A failed launch no longer permanently occupies its TaskId dedupe slot -- a Retry button re-fetches the launch spec and restarts the pane in place. CloseConPtySession/Dispose now also unsubscribe SubmitForReviewRequested, matching the other pane event handlers. Also fixes the pre-existing nullable-dereference warning in IslandsShellViewModel.SyncInteractiveSessionChips.
71 lines
3.5 KiB
XML
71 lines
3.5 KiB
XML
<UserControl xmlns="https://github.com/avaloniaui"
|
|
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
|
|
xmlns:vm="using:ClaudeDo.Ui.ViewModels.MissionControl"
|
|
xmlns:views="using:ClaudeDo.Ui.Views"
|
|
xmlns:loc="using:ClaudeDo.Ui.Localization"
|
|
xmlns:conv="using:Avalonia.Data.Converters"
|
|
x:DataType="vm:ConPtyPaneViewModel"
|
|
x:Class="ClaudeDo.Ui.Views.MissionControl.ConPtyPaneView">
|
|
<Border Classes="monitor-pane" BorderThickness="1" CornerRadius="10" ClipToBounds="True">
|
|
<DockPanel LastChildFill="True">
|
|
|
|
<!-- Header: title + close -->
|
|
<Border DockPanel.Dock="Top"
|
|
Background="{DynamicResource Surface2Brush}"
|
|
BorderBrush="{DynamicResource LineBrush}"
|
|
BorderThickness="0,0,0,1" Padding="8,3">
|
|
<Grid ColumnDefinitions="*,Auto,Auto">
|
|
<TextBlock Grid.Column="0" Classes="meta" Text="{Binding DisplayTitle}"
|
|
TextTrimming="CharacterEllipsis"
|
|
ToolTip.Tip="{Binding DisplayTitle}"
|
|
Foreground="{DynamicResource TextDimBrush}"
|
|
VerticalAlignment="Center" Margin="4,0,0,0" />
|
|
<Button Grid.Column="1" Classes="btn" Margin="0,0,6,0"
|
|
IsVisible="{Binding IsTaskBased}"
|
|
Content="{loc:Tr missionControl.submitForReview}"
|
|
ToolTip.Tip="{loc:Tr missionControl.submitForReviewTip}"
|
|
Command="{Binding SubmitForReviewCommand}" />
|
|
<Button Grid.Column="2" Classes="title-ctrl"
|
|
Command="{Binding CloseCommand}"
|
|
ToolTip.Tip="{loc:Tr missionControl.closeSession}">
|
|
<PathIcon Data="{StaticResource Icon.WinClose}" Width="12" Height="12"/>
|
|
</Button>
|
|
</Grid>
|
|
</Border>
|
|
|
|
<!-- Start-failure banner -->
|
|
<Border DockPanel.Dock="Top"
|
|
IsVisible="{Binding Terminal.StartError, Converter={x:Static conv:ObjectConverters.IsNotNull}}"
|
|
Background="{DynamicResource ErrorTintBrush}"
|
|
BorderBrush="{DynamicResource BloodBrush}"
|
|
BorderThickness="0,0,0,1" Padding="12,6">
|
|
<Grid ColumnDefinitions="*,Auto">
|
|
<TextBlock Grid.Column="0" Classes="meta" Text="{Binding Terminal.StartError}"
|
|
Foreground="{DynamicResource BloodBrush}"
|
|
TextWrapping="Wrap" VerticalAlignment="Center" />
|
|
<Button Grid.Column="1" Classes="btn" Margin="12,0,0,0"
|
|
Content="{loc:Tr missionControl.retry}"
|
|
ToolTip.Tip="{loc:Tr missionControl.retryTip}"
|
|
Command="{Binding RetryCommand}" />
|
|
</Grid>
|
|
</Border>
|
|
|
|
<!-- Embedded ConPTY terminal, with a starting overlay until the session is spawned -->
|
|
<Panel>
|
|
<views:InteractiveTerminalView DataContext="{Binding Terminal}" />
|
|
<Border IsVisible="{Binding Terminal.IsStarting}"
|
|
Background="{DynamicResource VoidBrush}">
|
|
<StackPanel Orientation="Horizontal" Spacing="10"
|
|
HorizontalAlignment="Center" VerticalAlignment="Center">
|
|
<Ellipse Classes="spinner"/>
|
|
<TextBlock Classes="meta" Text="{loc:Tr missionControl.conptyStarting}"
|
|
Foreground="{DynamicResource TextDimBrush}"
|
|
VerticalAlignment="Center"/>
|
|
</StackPanel>
|
|
</Border>
|
|
</Panel>
|
|
|
|
</DockPanel>
|
|
</Border>
|
|
</UserControl>
|