Files
ClaudeDo/tests/ClaudeDo.Ui.Tests/ViewModels/TasksIslandClassifyItemsTests.cs
T
Mika Kuns c25732cff8 feat(claude-do): depends_on als Menge statt Einzelfeld
Ein Task kann jetzt auf beliebig viele Vorgaenger warten. Die Einzelspalte
tasks.depends_on_task_id wird durch die Beziehungstabelle task_dependencies
ersetzt (Composite-PK, beide FKs ON DELETE CASCADE -- das reproduziert das
alte ON DELETE SET NULL: geloeschter Vorgaenger = Kante weg = Task wieder
pickbar). BlockedByTaskId bleibt unberuehrt.

- Migration AddTaskDependencies kopiert jede bestehende depends_on_task_id
  verlustfrei in die Tabelle, bevor die Spalte fallengelassen wird
- QueuePicker gatet per doppelt negiertem NOT EXISTS: kein Task mit 0 Kanten
  wird blockiert, alle Kanten muessen done sein, eine Kante auf einen
  verschwundenen Task blockiert weiter
- SetDependsOnAsync ersetzt die ganze Menge; Zykluspruefung ist jetzt eine
  BFS ueber den Graphen, faengt also auch A->B->C->A
- blockedReason nennt alle offenen Vorgaenger (External/TaskBlocking, von
  ExternalMcpService und TaskWaitMcpTools gemeinsam genutzt)
- add_task/update_task nehmen dependsOnTaskIds; die alte Skalarform bleibt
  als Ein-Element-Menge inkl. ""-Clear-Sentinel gueltig
- UI: Fan-in-Zeile bleibt flach und listet alle Vorgaenger im After-Label,
  die lineare Kette rendert unveraendert
2026-09-02 15:08:05 +02:00

156 lines
5.3 KiB
C#

using ClaudeDo.Data;
using ClaudeDo.Data.Models;
using ClaudeDo.Ui.ViewModels.Islands;
using Microsoft.EntityFrameworkCore;
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
namespace ClaudeDo.Ui.Tests.ViewModels;
// ClassifyItems (used by Regroup) additionally mutates every row's chain-display fields via
// ApplyChainGrouping. ClearCompletedAsync only needs section membership/counts, so it goes
// through the pure PartitionItems instead — this must not write ShowAsChainMember/ChainStep/
// ChainAfterLabel as a side effect of counting completed rows.
public class TasksIslandClassifyItemsTests : IDisposable
{
private readonly string _dbPath;
public TasksIslandClassifyItemsTests()
{
_dbPath = Path.Combine(Path.GetTempPath(), $"claudedo_ui_classify_{Guid.NewGuid():N}.db");
using var ctx = NewContext();
ctx.Database.EnsureCreated();
}
public void Dispose()
{
try { File.Delete(_dbPath); } catch { }
try { File.Delete(_dbPath + "-wal"); } catch { }
try { File.Delete(_dbPath + "-shm"); } catch { }
}
private ClaudeDoDbContext NewContext()
{
var opts = new DbContextOptionsBuilder<ClaudeDoDbContext>()
.UseSqlite($"Data Source={_dbPath}")
.Options;
return new ClaudeDoDbContext(opts);
}
private TasksIslandViewModel BuildViewModel()
{
var factory = new TestDbFactory(NewContext);
return new TasksIslandViewModel(factory, worker: null);
}
private static ListNavItemViewModel UserList(string listEntityId, string name) =>
new() { Id = $"user:{listEntityId}", Kind = ListKind.User, Name = name };
private static async Task LoadAndWaitAsync(TasksIslandViewModel vm, ListNavItemViewModel list, int expectedCount = 1)
{
vm.LoadForList(list);
var deadline = DateTime.UtcNow.AddSeconds(5);
while (DateTime.UtcNow < deadline)
{
await Task.Delay(25);
if (vm.Items.Count >= expectedCount) break;
}
await Task.Delay(50);
}
private async Task SeedAsync(
params (string Id, TaskStatus Status, string? DependsOnTaskId, int SortOrder)[] tasks)
{
await using var db = NewContext();
db.Lists.Add(new ListEntity { Id = "list1", Name = "Default", CreatedAt = DateTime.UtcNow });
foreach (var t in tasks)
{
db.Tasks.Add(new TaskEntity
{
Number = TestTaskNumbers.Next(),
Id = t.Id,
ListId = "list1",
Title = t.Id,
CreatedAt = DateTime.UtcNow,
Status = t.Status,
SortOrder = t.SortOrder,
});
if (t.DependsOnTaskId is not null)
db.TaskDependencies.Add(new TaskDependencyEntity
{
TaskId = t.Id,
DependsOnTaskId = t.DependsOnTaskId,
});
}
await db.SaveChangesAsync();
}
[Fact]
public async Task ClearCompleted_counting_path_leaves_chain_fields_untouched()
{
await SeedAsync(
("head", TaskStatus.Idle, null, 0),
("dep", TaskStatus.Idle, "head", 1));
var vm = BuildViewModel();
await LoadAndWaitAsync(vm, UserList("list1", "Default"), expectedCount: 2);
var dep = vm.Items.Single(r => r.Id == "dep");
// Sanity: the initial Regroup (during load) computed the chain correctly.
Assert.True(dep.ShowAsChainMember);
Assert.Equal(1, dep.ChainStep);
// Corrupt the row to a sentinel distinguishable from both the correct and default value.
dep.ShowAsChainMember = false;
dep.ChainStep = 99;
dep.ChainAfterLabel = "SENTINEL";
// Nothing is completed, so ClearCompletedAsync does nothing but count via PartitionItems.
await vm.ClearCompletedCommand.ExecuteAsync(null);
Assert.False(dep.ShowAsChainMember);
Assert.Equal(99, dep.ChainStep);
Assert.Equal("SENTINEL", dep.ChainAfterLabel);
}
[Fact]
public async Task Regroup_still_recomputes_chain_fields()
{
await SeedAsync(
("head", TaskStatus.Idle, null, 0),
("dep", TaskStatus.Idle, "head", 1));
var vm = BuildViewModel();
await LoadAndWaitAsync(vm, UserList("list1", "Default"), expectedCount: 2);
var dep = vm.Items.Single(r => r.Id == "dep");
dep.ShowAsChainMember = false;
dep.ChainStep = 99;
dep.ChainAfterLabel = "SENTINEL";
vm.Regroup();
Assert.True(dep.ShowAsChainMember);
Assert.Equal(1, dep.ChainStep);
Assert.Null(dep.ChainAfterLabel);
}
[Fact]
public async Task ClearCompleted_still_deletes_completed_rows_and_reports_count()
{
await SeedAsync(
("open1", TaskStatus.Idle, null, 0),
("done1", TaskStatus.Done, null, 1),
("done2", TaskStatus.Done, null, 2));
var vm = BuildViewModel();
await LoadAndWaitAsync(vm, UserList("list1", "Default"), expectedCount: 3);
vm.IsShowingCompleted = true;
await vm.ClearCompletedCommand.ExecuteAsync(null);
Assert.DoesNotContain(vm.Items, r => r.Id is "done1" or "done2");
Assert.Contains(vm.Items, r => r.Id == "open1");
}
}