Compare commits
544 Commits
a135485339
...
feature/de
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
50c10b6e75 | ||
|
|
075b6d13af | ||
|
|
324f1d9c7c | ||
|
|
c592ca32fb | ||
|
|
7ce418d474 | ||
|
|
ab260ad0a6 | ||
|
|
b3b87df320 | ||
|
|
da73324e3a | ||
|
|
c5a4e350e9 | ||
|
|
e547921fdd | ||
|
|
f1316dfd0e | ||
|
|
cc7355eaa4 | ||
|
|
22a1ba7f30 | ||
|
|
a3f407b0e5 | ||
|
|
469e68bbc8 | ||
|
|
176b9855bf | ||
|
|
5d34f95fe0 | ||
|
|
0e130177fc | ||
|
|
5363570fb4 | ||
|
|
f60becaf06 | ||
|
|
519bfbe6b3 | ||
|
|
06e3acd5ac | ||
|
|
f3052dc5fc | ||
|
|
9d133e227b | ||
|
|
7542bc2058 | ||
|
|
ef86a8c29b | ||
|
|
da23b6cd3a | ||
|
|
c10f564265 | ||
|
|
8036de1019 | ||
|
|
7873e60095 | ||
|
|
6f4b5d5544 | ||
|
|
f25c7599bd | ||
|
|
6fdf04d6a0 | ||
|
|
ee0d1257dd | ||
|
|
204b089000 | ||
|
|
da4ab0ca5e | ||
|
|
c035720b37 | ||
|
|
4522ac906b | ||
|
|
2455eacb1f | ||
|
|
d8b86e33a3 | ||
|
|
49b9f1ffde | ||
|
|
4d52845130 | ||
|
|
9a117a5429 | ||
|
|
202e8dea49 | ||
|
|
1e547dea18 | ||
|
|
56ebc2803f | ||
|
|
cf7f0da400 | ||
|
|
ac1e9b06de | ||
|
|
79bfc79d33 | ||
|
|
1b3c6bdbb4 | ||
|
|
bd1e3db1d9 | ||
|
|
edc9f77357 | ||
|
|
883dbc6af7 | ||
|
|
9bdf99d95f | ||
|
|
c8f468f270 | ||
|
|
84fd2c11a0 | ||
|
|
30b49d1071 | ||
|
|
ad7d74820a | ||
|
|
75aa42b877 | ||
|
|
925b72ae83 | ||
|
|
cd683ba227 | ||
|
|
d0ab382973 | ||
|
|
3e3041c1c7 | ||
|
|
92cee125cc | ||
|
|
bba3c55e1c | ||
|
|
26f5936d14 | ||
|
|
b72a7888e4 | ||
|
|
beae2d639d | ||
|
|
ac137f7c1c | ||
|
|
97e38fb480 | ||
|
|
b63c78c234 | ||
|
|
37ce673a57 | ||
|
|
b9741ef38b | ||
|
|
0a0d7e8551 | ||
|
|
2dfa9956c5 | ||
|
|
773811d060 | ||
|
|
3756b81817 | ||
|
|
72a86fc173 | ||
|
|
cc46019622 | ||
|
|
71ac48162a | ||
|
|
bcf5e2f51f | ||
|
|
fb055ce740 | ||
|
|
9e7f37b5cc | ||
|
|
39fa83a0a0 | ||
|
|
15ed624d4a | ||
|
|
52e3980cd1 | ||
|
|
53d897aff4 | ||
|
|
7d743f17c6 | ||
|
|
26758b6e8a | ||
|
|
914095dc99 | ||
|
|
4d82079cac | ||
|
|
3a40e39fc8 | ||
|
|
2e73d3333d | ||
|
|
c764b2bf6e | ||
|
|
f7d1b37343 | ||
|
|
fab17720cc | ||
|
|
9470c5b10b | ||
|
|
c45f892591 | ||
|
|
a8670ee23a | ||
|
|
7676ecf0d4 | ||
|
|
fa83d7f441 | ||
|
|
e48475d6cd | ||
|
|
46f42a4d93 | ||
|
|
46ac3fc930 | ||
|
|
5e0859fbb8 | ||
|
|
2d00160283 | ||
|
|
20b3a29d08 | ||
|
|
fd7f8ac78f | ||
|
|
0bb809445e | ||
|
|
3c66d65160 | ||
|
|
ffe0fb9820 | ||
|
|
00ef11ac33 | ||
|
|
312b411654 | ||
|
|
364a037cb3 | ||
|
|
2fbf054a57 | ||
|
|
350a89f364 | ||
|
|
086c6f6c45 | ||
|
|
070f5de1b1 | ||
|
|
f529a5ff22 | ||
|
|
6a85d82fcf | ||
|
|
35ad1715d3 | ||
|
|
3c40bb5ea3 | ||
|
|
d95d55e6b8 | ||
|
|
d22b50e171 | ||
|
|
a83a0c41e8 | ||
|
|
9efde2bf88 | ||
|
|
8dc8b8ba8e | ||
|
|
baeea9c2a7 | ||
|
|
a935bf9664 | ||
|
|
2d55f88a41 | ||
|
|
a8d8a8bd65 | ||
|
|
0bc3d2a6c4 | ||
|
|
b886d58c07 | ||
|
|
a8943a9f7a | ||
|
|
eccd06e182 | ||
|
|
731c291d61 | ||
|
|
c8b5ed3912 | ||
|
|
9bf44da13b | ||
|
|
b748c1569e | ||
|
|
74fc39f1a6 | ||
|
|
ccd2ee2cc7 | ||
|
|
5b89e3d03f | ||
|
|
e106b00b16 | ||
|
|
d7558ef451 | ||
|
|
4aa4353d11 | ||
|
|
50d84f12c9 | ||
|
|
e2271b5a50 | ||
|
|
bec87b3d6f | ||
|
|
4cb7ad8dfa | ||
|
|
992fbf0763 | ||
|
|
1d7b86dbef | ||
|
|
036586e736 | ||
|
|
d9e5d2600b | ||
|
|
10d86b4bd6 | ||
|
|
f72cfae7d9 | ||
|
|
e5a2ed250d | ||
|
|
536d819328 | ||
|
|
869cf72abe | ||
|
|
f1715a34fa | ||
|
|
26998f05ff | ||
|
|
7db8f213d8 | ||
|
|
37738e3c8f | ||
|
|
81fd186fb2 | ||
|
|
3127930454 | ||
|
|
bed4255a5e | ||
|
|
dff06d9e35 | ||
|
|
0efad7a004 | ||
|
|
eaf27e8b3a | ||
|
|
13c3393e3a | ||
|
|
4704a28e5d | ||
|
|
1cb5171fba | ||
|
|
4684a0af76 | ||
|
|
6c27ffbdca | ||
|
|
21f1cf2a85 | ||
|
|
c88ed9d5eb | ||
|
|
9c1f20f2d9 | ||
|
|
e8d018dd54 | ||
|
|
1ca32a6bdd | ||
|
|
b86677d554 | ||
|
|
3e072fae66 | ||
|
|
4a36fbe5e0 | ||
|
|
9e5a3fe962 | ||
|
|
3f98fd0ae5 | ||
|
|
8420b87bd1 | ||
|
|
c0978df19a | ||
|
|
3ac9e030e2 | ||
|
|
4c6e6594dc | ||
|
|
5170914a7a | ||
|
|
b1f4349dab | ||
|
|
23326a1833 | ||
|
|
ca0594328a | ||
|
|
22d06acb35 | ||
|
|
ab44ba5e41 | ||
|
|
6c3afce329 | ||
|
|
f8e387bbc1 | ||
|
|
2a36998ac7 | ||
|
|
4148dcdb18 | ||
|
|
5783790733 | ||
|
|
edfb702ecc | ||
|
|
549b87bb74 | ||
|
|
400a078aec | ||
|
|
5baa1d7fbb | ||
|
|
1246bf7b88 | ||
|
|
00dc7ebccc | ||
|
|
0139607008 | ||
|
|
4ecd855fb1 | ||
|
|
759d9057ff | ||
|
|
2f1dcdc102 | ||
|
|
133f2d2f1d | ||
|
|
e2bb43ad6d | ||
|
|
867dc37228 | ||
|
|
4963a726de | ||
|
|
926471da6b | ||
|
|
9be8e6b3e0 | ||
|
|
b9e5dfccde | ||
|
|
c669370ecf | ||
|
|
4688e884bd | ||
|
|
8b21b0e646 | ||
|
|
4a786eb732 | ||
|
|
cd64f287c3 | ||
|
|
3585ad5ee2 | ||
|
|
990935e67d | ||
|
|
1b5a9285e6 | ||
|
|
e8f880e72f | ||
|
|
3228a08c7a | ||
|
|
ccec791fc1 | ||
|
|
187fb641fe | ||
|
|
0a719568ea | ||
|
|
ccec591ba2 | ||
|
|
a4cb03b1b5 | ||
|
|
f53292e134 | ||
|
|
539ebecf3a | ||
|
|
dff5651db7 | ||
|
|
9f49b0131f | ||
|
|
fb3a6acf52 | ||
|
|
4f84b15b6a | ||
|
|
27b0d51db0 | ||
|
|
2a381048fe | ||
|
|
bddef5abef | ||
|
|
51d3ea2e1c | ||
|
|
335b422e23 | ||
|
|
08f3babca4 | ||
|
|
9082f2ed71 | ||
|
|
0f64b1c6e0 | ||
|
|
dd453874ba | ||
|
|
00e1d2d6c9 | ||
|
|
9a9113542d | ||
|
|
8e595a1e43 | ||
|
|
97fc715856 | ||
|
|
ed8607d4c9 | ||
|
|
929e0ca1ee | ||
|
|
40a36308ae | ||
|
|
b9f5d829c8 | ||
|
|
e0dda3e71b | ||
|
|
d4c66dea63 | ||
|
|
a132127e9e | ||
|
|
6e3125e78d | ||
|
|
b00e4d994f | ||
|
|
16717ab9e9 | ||
|
|
7af892f410 | ||
|
|
e86464e802 | ||
|
|
df7337810e | ||
|
|
8944074997 | ||
|
|
fbd5d9f7ca | ||
|
|
5fdd9f0b4c | ||
|
|
bce4e0a1e6 | ||
|
|
229f865e7e | ||
|
|
a444033aa9 | ||
|
|
2265829a29 | ||
|
|
50e05b9140 | ||
|
|
538839c004 | ||
|
|
8d07fc298c | ||
|
|
e1bfbb0fa6 | ||
|
|
b1006ac7b0 | ||
|
|
4f5db367a7 | ||
|
|
c20fbe3613 | ||
|
|
16b0d1177a | ||
|
|
a1f05da97b | ||
|
|
0c0c73bc9e | ||
|
|
3d4a64a8fd | ||
|
|
bff15c9bf3 | ||
|
|
f40de4bbe0 | ||
|
|
e120b0fd70 | ||
|
|
e8ce725897 | ||
|
|
7a6bfbe1b4 | ||
|
|
5a25818e3a | ||
|
|
f0f8cd103d | ||
|
|
d52f23f7c8 | ||
|
|
cfc45118e4 | ||
|
|
1856943925 | ||
|
|
ce9fadc0b5 | ||
|
|
25ee623c42 | ||
|
|
41da124a31 | ||
|
|
77100b6b3b | ||
|
|
32daa4a602 | ||
|
|
b41a78ec29 | ||
|
|
9ea60701d2 | ||
|
|
5a592c4be6 | ||
|
|
7196aab31f | ||
|
|
fec2fe2dda | ||
|
|
3afe29d721 | ||
|
|
f3f8af4b11 | ||
|
|
c3493a3a74 | ||
|
|
ac2f1d824e | ||
|
|
53f4e2de0f | ||
|
|
99dc08488b | ||
|
|
26c4e5771b | ||
|
|
1e5b3a6c3e | ||
|
|
59d72635da | ||
|
|
7a88e8a848 | ||
|
|
b84716ff9c | ||
|
|
ce879f6f70 | ||
|
|
2f7f00d4cc | ||
|
|
6d0973c67c | ||
|
|
bb8b3e235a | ||
|
|
6e3947c0b1 | ||
|
|
128fb7d4d2 | ||
|
|
3af8fb9aa0 | ||
|
|
5b15e30b8a | ||
|
|
e5bce07719 | ||
|
|
9c638e72b1 | ||
|
|
c43b06d83d | ||
|
|
d4674cd74e | ||
|
|
e4d958dcf3 | ||
|
|
0f41384fa8 | ||
|
|
50b1589b23 | ||
|
|
1c689a8472 | ||
|
|
4877c11aa2 | ||
|
|
03617ee3cd | ||
|
|
7869c2a979 | ||
|
|
ce79a2d0fe | ||
|
|
09a930e28e | ||
|
|
c1c7862672 | ||
|
|
19f22d2d97 | ||
|
|
12668f684f | ||
|
|
967e0cd319 | ||
|
|
2223839595 | ||
|
|
7d61d38a34 | ||
|
|
e55367af67 | ||
|
|
0b19ea739c | ||
|
|
3587703fe8 | ||
|
|
7e3ae704fe | ||
|
|
232d7cb647 | ||
|
|
6c8048d0be | ||
|
|
6670771040 | ||
|
|
bc15c16e44 | ||
|
|
ca71275fc4 | ||
|
|
8f4e37ef56 | ||
|
|
789094fcd9 | ||
|
|
9f70f6747e | ||
|
|
182a9df7f3 | ||
|
|
79131f83c1 | ||
|
|
b888a5f0cd | ||
|
|
046da0fd81 | ||
|
|
b095a29f97 | ||
|
|
ce30d01b72 | ||
|
|
89f6b836ba | ||
|
|
b944597af4 | ||
|
|
5da69ee6aa | ||
|
|
5308ba3136 | ||
|
|
a62ef240d1 | ||
|
|
623ebf147b | ||
|
|
8d34db3f9b | ||
|
|
0d55002e5e | ||
|
|
d094a21e09 | ||
|
|
e68bb737e3 | ||
|
|
a6608bf8b3 | ||
|
|
df66c4af46 | ||
|
|
4c92da55ad | ||
|
|
d4d5a4b8e7 | ||
|
|
9ba238f4ad | ||
|
|
c1856657b5 | ||
|
|
47b07373af | ||
|
|
121e8cd476 | ||
|
|
cfbe2fd7e3 | ||
|
|
5079a5fc5c | ||
|
|
618235d8ed | ||
|
|
bca8c9e4cb | ||
|
|
8b02b63d3d | ||
|
|
f890fa85b9 | ||
|
|
fd5562b6e8 | ||
|
|
71c6c68c84 | ||
|
|
507f59f1d1 | ||
|
|
13c280f6d5 | ||
|
|
09e3e7e8b5 | ||
|
|
975db8ab54 | ||
|
|
f383645360 | ||
|
|
4e90828653 | ||
|
|
a335a3b684 | ||
|
|
0b90df6ff0 | ||
|
|
6c9ccf68b6 | ||
|
|
2ff0971dce | ||
|
|
8eafa71ed3 | ||
|
|
dc3fc443b4 | ||
|
|
ff7c239959 | ||
|
|
4ab906ff0b | ||
|
|
064a903076 | ||
|
|
8823265e5a | ||
|
|
cf7a6e413c | ||
|
|
7b737e6717 | ||
|
|
43af17e546 | ||
|
|
5c55f6c6cf | ||
|
|
bdb709b264 | ||
|
|
2d7f825ff3 | ||
|
|
721c36a66b | ||
|
|
10b2ca817b | ||
|
|
1b9f2d4de1 | ||
|
|
59dc1e2357 | ||
|
|
31a394e694 | ||
|
|
d99cb68afb | ||
|
|
1a74e1c058 | ||
|
|
e6846b7e6d | ||
|
|
e767d57640 | ||
|
|
25493528de | ||
|
|
14cc9fb891 | ||
|
|
7f96ae9508 | ||
|
|
6c54759aa0 | ||
|
|
615c1da665 | ||
|
|
e192285f5d | ||
|
|
a6ca1c0108 | ||
|
|
8f94dddbc5 | ||
|
|
45320427e8 | ||
|
|
16e1ddd129 | ||
|
|
288d2ece8b | ||
|
|
2ad6f20258 | ||
|
|
b2eb5fcfa4 | ||
|
|
8e9f09a8e6 | ||
|
|
ce23f64dc3 | ||
|
|
3008c36921 | ||
|
|
e58cac24e1 | ||
|
|
b9896399fa | ||
|
|
7d87c03cfa | ||
|
|
ef070ddab5 | ||
|
|
3142ba203f | ||
|
|
bc788e1e0f | ||
|
|
a6ebff3f34 | ||
|
|
389d9045d5 | ||
|
|
1aead9dad0 | ||
|
|
9d04d1d9f6 | ||
|
|
4c6fd9f024 | ||
|
|
2cab33d708 | ||
|
|
a1727b647c | ||
|
|
6bdfa73150 | ||
|
|
ada4d9fd9b | ||
|
|
6d460ea996 | ||
|
|
bc0f1e3122 | ||
|
|
63759ee7dc | ||
|
|
62106ff644 | ||
|
|
e77ba35b0e | ||
|
|
8afbf20613 | ||
|
|
5a03dc8430 | ||
|
|
e62485db3b | ||
|
|
a5ebfd12f8 | ||
|
|
2262ab0e13 | ||
|
|
0da527dbbc | ||
|
|
9beda55681 | ||
|
|
6800852ae4 | ||
|
|
48899b3df8 | ||
|
|
fce91bcf86 | ||
|
|
975e1ce50c | ||
|
|
1d61df8160 | ||
|
|
1370bf3dcc | ||
|
|
f2db5f4ad0 | ||
|
|
fd2ac4842f | ||
|
|
4de2deaebe | ||
|
|
b7c60f5838 | ||
| e455d85578 | |||
|
|
0782ba574b | ||
|
|
7b67e35720 | ||
|
|
c048264b95 | ||
|
|
6cb20a9213 | ||
|
|
99c6a71e4c | ||
|
|
0088d6e0e0 | ||
|
|
b115a4c512 | ||
|
|
9e09ae6b4e | ||
|
|
43a3740980 | ||
|
|
d28164caf4 | ||
|
|
77f7cf1423 | ||
|
|
84e6c2d5fc | ||
|
|
84b0ba8670 | ||
|
|
b6bec1e63c | ||
|
|
b32621a4e5 | ||
| 993851009b | |||
|
|
450e685580 | ||
|
|
0e116bec7b | ||
|
|
47b49743c0 | ||
|
|
506caa2c53 | ||
|
|
388a8c1fae | ||
|
|
42b208ff28 | ||
|
|
309f84b388 | ||
|
|
00608401aa | ||
|
|
229d4bbb2b | ||
| 845359b885 | |||
|
|
d4a46420c9 | ||
|
|
f704244b84 | ||
|
|
782110604b | ||
|
|
19bf032a2e | ||
|
|
b7464c9a11 | ||
|
|
524aaf85af | ||
|
|
a9e7479326 | ||
|
|
2e80cc606e | ||
|
|
d099138487 | ||
|
|
2278d97b7e | ||
|
|
74255ddc82 | ||
|
|
b466246c1b | ||
|
|
b3eb39a28b | ||
|
|
253e6f05e0 | ||
|
|
042a1b47c2 | ||
|
|
7a20534e7c | ||
|
|
ee2cbc92ef | ||
|
|
373f04a034 | ||
|
|
43d517dcfc | ||
|
|
8891d48af2 | ||
|
|
0b72c0fb53 | ||
|
|
a41e5b5b2d | ||
|
|
00c62178e1 | ||
|
|
bbe7d73de2 | ||
|
|
0934b294c2 | ||
|
|
b28d8f2f4a | ||
|
|
ec4ec44603 | ||
|
|
ee09706811 | ||
|
|
c06d1d6afb | ||
|
|
f906e7086c | ||
|
|
caf900b02d | ||
|
|
e80e3fccc0 | ||
|
|
e8056553fd | ||
|
|
ea4d2d7c0c | ||
|
|
98c188a5da | ||
|
|
0c3dcb0052 | ||
|
|
e017d66023 | ||
|
|
ba0b38b4f1 | ||
|
|
5b4cdd366e | ||
|
|
7c0f8d8408 | ||
|
|
0a7fcae137 | ||
|
|
5346737e2b | ||
|
|
80f6669585 | ||
|
|
27054e6715 | ||
|
|
ea7694566d | ||
|
|
46e01aefed | ||
|
|
41e0bea162 | ||
|
|
86012e02b9 | ||
|
|
da19eb807b | ||
|
|
0d37473575 | ||
|
|
6a4bf676ff |
@@ -6,7 +6,10 @@
|
|||||||
"mcp__plugin_context-mode_context-mode__batch_execute",
|
"mcp__plugin_context-mode_context-mode__batch_execute",
|
||||||
"mcp__plugin_context-mode_context-mode__execute",
|
"mcp__plugin_context-mode_context-mode__execute",
|
||||||
"mcp__plugin_context7_context7__query-docs",
|
"mcp__plugin_context7_context7__query-docs",
|
||||||
"mcp__plugin_context-mode_context-mode__search"
|
"mcp__plugin_context-mode_context-mode__search",
|
||||||
|
"Bash(git fetch *)",
|
||||||
|
"PowerShell(cmdkey *)",
|
||||||
|
"mcp__plugin_context7_context7__resolve-library-id"
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
16
.gitattributes
vendored
Normal file
16
.gitattributes
vendored
Normal file
@@ -0,0 +1,16 @@
|
|||||||
|
* text=auto eol=lf
|
||||||
|
|
||||||
|
*.sln text eol=crlf
|
||||||
|
*.slnx text eol=crlf
|
||||||
|
*.cmd text eol=crlf
|
||||||
|
*.bat text eol=crlf
|
||||||
|
*.ps1 text eol=crlf
|
||||||
|
|
||||||
|
*.png binary
|
||||||
|
*.jpg binary
|
||||||
|
*.jpeg binary
|
||||||
|
*.gif binary
|
||||||
|
*.ico binary
|
||||||
|
*.zip binary
|
||||||
|
*.exe binary
|
||||||
|
*.dll binary
|
||||||
@@ -53,7 +53,7 @@ jobs:
|
|||||||
cd "$WORK/src"
|
cd "$WORK/src"
|
||||||
dotnet publish src/ClaudeDo.App/ClaudeDo.App.csproj \
|
dotnet publish src/ClaudeDo.App/ClaudeDo.App.csproj \
|
||||||
-c Release -r win-x64 --self-contained true \
|
-c Release -r win-x64 --self-contained true \
|
||||||
/p:Version=$VERSION -o out/app
|
/p:MinVerVersionOverride=$VERSION -o out/app
|
||||||
|
|
||||||
- name: Publish ClaudeDo.Worker (win-x64, self-contained)
|
- name: Publish ClaudeDo.Worker (win-x64, self-contained)
|
||||||
env:
|
env:
|
||||||
@@ -65,7 +65,7 @@ jobs:
|
|||||||
cd "$WORK/src"
|
cd "$WORK/src"
|
||||||
dotnet publish src/ClaudeDo.Worker/ClaudeDo.Worker.csproj \
|
dotnet publish src/ClaudeDo.Worker/ClaudeDo.Worker.csproj \
|
||||||
-c Release -r win-x64 --self-contained true \
|
-c Release -r win-x64 --self-contained true \
|
||||||
/p:Version=$VERSION -o out/worker
|
/p:MinVerVersionOverride=$VERSION -o out/worker
|
||||||
|
|
||||||
- name: Publish ClaudeDo.Installer (win-x64, single-file, framework-dependent)
|
- name: Publish ClaudeDo.Installer (win-x64, single-file, framework-dependent)
|
||||||
env:
|
env:
|
||||||
@@ -80,7 +80,7 @@ jobs:
|
|||||||
# Target machines need .NET 8 Desktop Runtime (x64).
|
# Target machines need .NET 8 Desktop Runtime (x64).
|
||||||
dotnet publish src/ClaudeDo.Installer/ClaudeDo.Installer.csproj \
|
dotnet publish src/ClaudeDo.Installer/ClaudeDo.Installer.csproj \
|
||||||
-c Release -r win-x64 --self-contained false \
|
-c Release -r win-x64 --self-contained false \
|
||||||
/p:Version=$VERSION /p:PublishSingleFile=true \
|
/p:MinVerVersionOverride=$VERSION /p:PublishSingleFile=true \
|
||||||
-o out/installer
|
-o out/installer
|
||||||
|
|
||||||
- name: Package assets
|
- name: Package assets
|
||||||
|
|||||||
5
.gitignore
vendored
5
.gitignore
vendored
@@ -1,3 +1,6 @@
|
|||||||
|
# Local dev worktrees (created by using-git-worktrees skill)
|
||||||
|
.worktrees/
|
||||||
|
|
||||||
# .NET build output
|
# .NET build output
|
||||||
bin/
|
bin/
|
||||||
obj/
|
obj/
|
||||||
@@ -42,6 +45,8 @@ artifacts/
|
|||||||
|
|
||||||
# Avalonia / XAML designer
|
# Avalonia / XAML designer
|
||||||
*.designer.cs
|
*.designer.cs
|
||||||
|
# ...but EF Core migration Designer files are real source and must be tracked
|
||||||
|
!**/Migrations/*.Designer.cs
|
||||||
|
|
||||||
# Project-specific
|
# Project-specific
|
||||||
*.db
|
*.db
|
||||||
|
|||||||
32
CLAUDE.md
32
CLAUDE.md
@@ -35,20 +35,44 @@ Two-process system communicating over SignalR (`127.0.0.1:47821`):
|
|||||||
- EF Core migrations manage schema (Migrations/ folder in ClaudeDo.Data)
|
- EF Core migrations manage schema (Migrations/ folder in ClaudeDo.Data)
|
||||||
- `IDbContextFactory<ClaudeDoDbContext>` used by singleton consumers (e.g. Worker)
|
- `IDbContextFactory<ClaudeDoDbContext>` used by singleton consumers (e.g. Worker)
|
||||||
- Entity configuration via `IEntityTypeConfiguration<T>` in Configuration/ folder
|
- Entity configuration via `IEntityTypeConfiguration<T>` in Configuration/ folder
|
||||||
- Task status flow: Manual | Queued -> Running -> Done | Failed
|
- Task status flow: Idle | Queued -> Running -> WaitingForReview -> Done | Failed | Cancelled. A standalone task's successful run lands in WaitingForReview (planning children go straight to Done); from review you can approve (Done), reject-rerun (Queued, resumes the session with feedback), reject-park (Idle), or cancel (Cancelled).
|
||||||
- Worktree state flow: Active -> Merged | Discarded | Kept
|
- Worktree state flow: Active -> Merged | Discarded | Kept
|
||||||
- Tags "agent" and "manual" are seeded; "agent" tag marks tasks for automated queue pickup
|
- The queue picker claims tasks by `Status=Queued` (with `BlockedByTaskId IS NULL`); the legacy tag system was removed
|
||||||
|
- Interfaces live in an `Interfaces/` subfolder beside their consumers (namespace unchanged)
|
||||||
|
- Small single-consumer helper types live in their consumer's file, not standalone files
|
||||||
- Commit messages use conventional format: `{commitType}(slug): title`
|
- Commit messages use conventional format: `{commitType}(slug): title`
|
||||||
- Views use compiled bindings (`x:DataType`)
|
- Views use compiled bindings (`x:DataType`)
|
||||||
- ViewModels use `[ObservableProperty]` and `[RelayCommand]` source generators
|
- ViewModels use `[ObservableProperty]` and `[RelayCommand]` source generators
|
||||||
|
|
||||||
|
## Working style (autonomous)
|
||||||
|
|
||||||
|
For any non-trivial feature, bug, or change, run this loop without hand-holding:
|
||||||
|
|
||||||
|
1. **Brainstorm first** (superpowers:brainstorming) — ask clarifying questions one at a time, propose 2–3 options with a recommendation, present a short design, get approval before building.
|
||||||
|
2. **Write it down** — a spec in `docs/superpowers/specs/YYYY-MM-DD-<topic>-design.md` and a step-by-step plan in `docs/superpowers/plans/` (superpowers:writing-plans). Commit the docs.
|
||||||
|
3. **Implement on main** with superpowers:subagent-driven-development — one subagent per task, TDD, build + test, commit per task with Conventional Commits. Once the plan is approved, do NOT pause for re-approval between tasks; only stop for genuine decisions or blockers.
|
||||||
|
4. **Trust but verify** — read each subagent's diff and run the build/tests yourself before marking a task done.
|
||||||
|
5. **Bugs** → superpowers:systematic-debugging (find the root cause before any fix).
|
||||||
|
6. **Never claim UI works without running it** — explicitly flag visual-verification gaps for the user to check.
|
||||||
|
|
||||||
|
Commit freely (per task + the spec/plan docs). Never push without asking.
|
||||||
|
|
||||||
## Building & Testing
|
## Building & Testing
|
||||||
|
|
||||||
|
`dotnet build ClaudeDo.slnx` requires .NET 9; on .NET 8 build individual projects with `-c Release` (a running Worker locks the `Debug` output).
|
||||||
|
|
||||||
```bash
|
```bash
|
||||||
dotnet build ClaudeDo.slnx
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release # pulls in Ui + Data
|
||||||
dotnet test tests/ClaudeDo.Worker.Tests
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release # also: Data.Tests, Ui.Tests, Localization.Tests, Installer.Tests, Releases.Tests
|
||||||
```
|
```
|
||||||
|
|
||||||
|
### Gotchas
|
||||||
|
- **Subagents:** use the `sonnet` model; stage files explicitly by path — never `git add -A` (parallel sessions often leave unrelated WIP in the tree).
|
||||||
|
- **Icons:** `PathIcon` *fills* its geometry. Line-art/stroke icons must be authored as filled geometry, or rendered with a stroked `Path` — otherwise they render invisible.
|
||||||
|
- **Localization:** `locales/en.json` and `locales/de.json` keys must stay in parity (Localization.Tests enforces it).
|
||||||
|
- **Test fakes:** changing `IWorkerClient` / `WorkerHub` / ViewModel constructors breaks hand-rolled fakes in both test projects — update them.
|
||||||
|
|
||||||
## Docs
|
## Docs
|
||||||
|
|
||||||
- `docs/plan.md` — full architecture and design spec
|
- `docs/plan.md` — full architecture and design spec
|
||||||
|
|||||||
@@ -5,10 +5,16 @@
|
|||||||
<Project Path="src/ClaudeDo.Ui/ClaudeDo.Ui.csproj" />
|
<Project Path="src/ClaudeDo.Ui/ClaudeDo.Ui.csproj" />
|
||||||
<Project Path="src/ClaudeDo.Worker/ClaudeDo.Worker.csproj" />
|
<Project Path="src/ClaudeDo.Worker/ClaudeDo.Worker.csproj" />
|
||||||
<Project Path="src/ClaudeDo.Installer/ClaudeDo.Installer.csproj" />
|
<Project Path="src/ClaudeDo.Installer/ClaudeDo.Installer.csproj" />
|
||||||
|
<Project Path="src/ClaudeDo.Releases/ClaudeDo.Releases.csproj" />
|
||||||
|
<Project Path="src/ClaudeDo.Localization/ClaudeDo.Localization.csproj" />
|
||||||
|
<Project Path="src/ClaudeDo.Logging/ClaudeDo.Logging.csproj" />
|
||||||
</Folder>
|
</Folder>
|
||||||
<Folder Name="/tests/">
|
<Folder Name="/tests/">
|
||||||
|
<Project Path="tests/ClaudeDo.Data.Tests/ClaudeDo.Data.Tests.csproj" />
|
||||||
<Project Path="tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj" />
|
<Project Path="tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj" />
|
||||||
<Project Path="tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj" />
|
<Project Path="tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj" />
|
||||||
<Project Path="tests/ClaudeDo.Installer.Tests/ClaudeDo.Installer.Tests.csproj" />
|
<Project Path="tests/ClaudeDo.Installer.Tests/ClaudeDo.Installer.Tests.csproj" />
|
||||||
|
<Project Path="tests/ClaudeDo.Releases.Tests/ClaudeDo.Releases.Tests.csproj" />
|
||||||
|
<Project Path="tests/ClaudeDo.Localization.Tests/ClaudeDo.Localization.Tests.csproj" />
|
||||||
</Folder>
|
</Folder>
|
||||||
</Solution>
|
</Solution>
|
||||||
|
|||||||
8
Directory.Build.props
Normal file
8
Directory.Build.props
Normal file
@@ -0,0 +1,8 @@
|
|||||||
|
<Project>
|
||||||
|
<PropertyGroup>
|
||||||
|
<MinVerTagPrefix>v</MinVerTagPrefix>
|
||||||
|
</PropertyGroup>
|
||||||
|
<ItemGroup>
|
||||||
|
<PackageReference Include="MinVer" Version="5.0.0" PrivateAssets="all" />
|
||||||
|
</ItemGroup>
|
||||||
|
</Project>
|
||||||
102
docs/mailbox-proposal.md
Normal file
102
docs/mailbox-proposal.md
Normal file
@@ -0,0 +1,102 @@
|
|||||||
|
# Task Mailbox — Push Messages Into Running Sessions
|
||||||
|
|
||||||
|
**Status:** PARKED (2026-06-04) — not building this.
|
||||||
|
**Why parked:** The generic Claude-Mailbox plugin (the `mcp__mailbox__*` tools used in normal sessions) already covers the core need — cross-session messaging, inbox checks, a sender — at the harness level for any project. Integrating it directly into ClaudeDo (task/worktree-scoped inboxes, per-worktree CLAUDE.md + hook seeding, UI badges, `send_to_peer`) is a sizable build (migration + MCP tools + SignalR + UI + hooks) for marginal gain over the plugin. Revisit only if the generic plugin proves insufficient for the parallel-session workflow. The original proposal is kept below for reference.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
**Context:** the user runs parallel Claude sessions (e.g. backend + frontend) and wants to push messages into a session while it's busy inside a subagent. A shared folder works for one-offs; this turns it into a first-class ClaudeDo feature so every future parallel-session project gets it for free.
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
Claude CLI processes one turn at a time. While a subagent (or any long tool) runs, no new user input can be injected. The harness offers no mid-execution interrupt. The workable window is *between* tool calls — so we need a cheap "inbox check" the agent can poll at natural checkpoints, plus a UI affordance and a cross-session sender.
|
||||||
|
|
||||||
|
## Design
|
||||||
|
|
||||||
|
### 1. Data
|
||||||
|
|
||||||
|
New table `task_messages`:
|
||||||
|
|
||||||
|
| col | type | notes |
|
||||||
|
|---|---|---|
|
||||||
|
| `id` | INTEGER PK | |
|
||||||
|
| `task_id` | TEXT FK → tasks.id | recipient |
|
||||||
|
| `sender` | TEXT | `'user'` \| `'task:<id>'` (for cross-session) |
|
||||||
|
| `body` | TEXT | markdown |
|
||||||
|
| `created_at` | TEXT | ISO |
|
||||||
|
| `delivered_at` | TEXT NULL | set when inbox pulls it |
|
||||||
|
|
||||||
|
EF Core migration + repository. Async, CancellationToken, matches existing conventions.
|
||||||
|
|
||||||
|
### 2. Worker MCP tools (extend existing `mcp__claudedo__*` server)
|
||||||
|
|
||||||
|
- **`check_inbox(task_id)`** → returns undelivered messages for this task and marks them delivered. Idempotent. Empty array if nothing pending.
|
||||||
|
- **`send_to_task(task_id, body)`** → inserts a row. Callable from *any* session — this is how the frontend session tells the backend session something.
|
||||||
|
- **`inbox_status(task_id)`** → `{ pending: int }` for a cheap "is there anything?" poll.
|
||||||
|
|
||||||
|
All three run in-proc in the Worker, go through the existing repository layer.
|
||||||
|
|
||||||
|
### 3. SignalR additions on `WorkerHub`
|
||||||
|
|
||||||
|
Server methods (UI → Worker):
|
||||||
|
- `SendTaskMessage(taskId, body)` — UI calls this; worker inserts the row and fires `TaskMessageQueued`.
|
||||||
|
|
||||||
|
Client events (Worker → UI):
|
||||||
|
- `TaskMessageQueued(taskId, pendingCount)` — so the UI can show an unread badge.
|
||||||
|
- `TaskMessageDelivered(taskId, pendingCount)` — when the agent pulls it, badge clears.
|
||||||
|
|
||||||
|
### 4. UI
|
||||||
|
|
||||||
|
On every `Running` task row + detail pane:
|
||||||
|
- "Send to session" textarea + Enter to submit → `SendTaskMessage`.
|
||||||
|
- Unread badge showing `pendingCount`.
|
||||||
|
- Read-only message timeline (who sent what, when delivered).
|
||||||
|
|
||||||
|
### 5. Agent-side poll discipline
|
||||||
|
|
||||||
|
Two complementary mechanisms so it's robust whether or not the agent remembers:
|
||||||
|
|
||||||
|
**a) CLAUDE.md instruction** (seeded by worker into each worktree's `CLAUDE.md`):
|
||||||
|
> After every subagent completes and before starting the next step, call `mcp__claudedo__check_inbox`. Treat returned messages as user input with priority over the current plan.
|
||||||
|
|
||||||
|
**b) PostToolUse hook on `Agent`** (written into the worktree's `.claude/settings.json` by the Worker when it creates the tree):
|
||||||
|
- Runs `mcp__claudedo__inbox_status` via a tiny CLI shim the worker ships.
|
||||||
|
- If `pending > 0`, the hook emits a system reminder: "Inbox has N pending messages — call `mcp__claudedo__check_inbox` now."
|
||||||
|
- Keeps the burden off the agent's memory. Belt + suspenders.
|
||||||
|
|
||||||
|
### 6. Cross-session pattern
|
||||||
|
|
||||||
|
Backend session and frontend session are just two tasks with known IDs. Either can call `send_to_task(other_id, body)` via the MCP server. No shared folder needed — the DB is already the shared channel.
|
||||||
|
|
||||||
|
To make this ergonomic:
|
||||||
|
- A "linked tasks" concept: tag two tasks as peers at creation time. The Worker exposes `send_to_peer(body)` as sugar around `send_to_task` so neither session needs to hardcode the other's UUID.
|
||||||
|
|
||||||
|
## Limits (honest)
|
||||||
|
|
||||||
|
- Messages arrive *between* tool calls, not mid-tool. A 20-minute subagent still blocks 20 minutes. Splitting work into shorter subagents is still the right discipline.
|
||||||
|
- If the agent ignores the CLAUDE.md instruction, the hook catches it next tool call — but we can't force immediate consumption.
|
||||||
|
- `-p` (print) mode with stdin prompt is one-shot and can't be extended. This design targets *interactive* sessions (Planning Sessions already use this mode). For queued `-p` runs, the mailbox is effectively a post-run instruction carrier.
|
||||||
|
|
||||||
|
## Why this is the repeatable "Grundgerüst"
|
||||||
|
|
||||||
|
Once this lands in ClaudeDo, the workflow becomes:
|
||||||
|
1. Create two linked tasks (`backend`, `frontend`) with `working_dir` set.
|
||||||
|
2. Start each — each gets its own worktree, its own Planning Session terminal, its own inbox with `check_inbox` + `send_to_peer`.
|
||||||
|
3. Push messages from the UI or from the other session. No per-project scaffolding, no custom hooks, no shared folder.
|
||||||
|
|
||||||
|
Every future parallel-session project inherits the mailbox.
|
||||||
|
|
||||||
|
## Build order (suggested)
|
||||||
|
|
||||||
|
1. Migration + repo + model. Tests first.
|
||||||
|
2. MCP tools (`check_inbox`, `send_to_task`, `inbox_status`) + unit tests.
|
||||||
|
3. SignalR method + events + UI textarea/badge.
|
||||||
|
4. Worker writes CLAUDE.md addendum + `.claude/settings.json` hook into each new worktree.
|
||||||
|
5. Linked-tasks sugar (`send_to_peer`).
|
||||||
|
6. Manual verification: queue a long subagent, send a message, confirm it's picked up at the next tool boundary.
|
||||||
|
|
||||||
|
## Open questions
|
||||||
|
|
||||||
|
- Should messages be deleted or soft-kept after delivery? Leaning soft-kept for the timeline UI.
|
||||||
|
- Priority / interrupt semantics — do we want a "high priority" flag that the agent should surface immediately vs. batch?
|
||||||
|
- Should `send_to_peer` also work when the peer is `Queued` (i.e. not yet running)? Probably yes — deliver on start.
|
||||||
199
docs/open.md
199
docs/open.md
@@ -1,193 +1,30 @@
|
|||||||
# ClaudeDo — Offene Punkte
|
# ClaudeDo — Offene Punkte
|
||||||
|
|
||||||
Stand: 2026-04-13 nach Slice F. Branch `main` @ `48e4aab`. Alle Tests grün (38/38), Build 0 Warnings.
|
Stand: 2026-06-04. **Nur noch offene Punkte.** Was erledigt ist, steht in den Commits und im Code — nicht hier.
|
||||||
|
|
||||||
Dieses Dokument listet alles, was noch fehlt — gruppiert nach Aufwand/Risiko und mit konkreten Datei-Pointern, damit wir es in der IDE der Reihe nach durchgehen können.
|
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
## 1. Verification (vor allem anderen)
|
## Manuelle Verifikation (offen)
|
||||||
|
|
||||||
Die in `plan.md` definierten Verification-Steps sind teilweise nur durch Build/Tests abgedeckt. Diese sollten manuell einmal durchlaufen werden, BEVOR wir Polish bauen — damit wir wissen, was tatsächlich kaputt ist.
|
Kein Code-Aufwand, nur Durchspielen mit explizit notiertem Pass-Kriterium. Der Großteil der Pipeline ist laut User bereits in der Praxis getestet; hier das, was noch ein falsifizierbares Observable braucht.
|
||||||
|
|
||||||
| # | Plan | Status | Was tun |
|
- **Worktree-Pipeline:**
|
||||||
|---|------|--------|---------|
|
- Worktree-Happy-Path → `worktrees.state='active'`, `head_commit` gesetzt, `diff_stat` non-empty, Branch `claudedo/<id>` auf Disk.
|
||||||
| 1 | Schema-Init | Auto verifiziert (Worker startet ohne Crash, WAL-Files entstehen) | OK |
|
- No-Changes-Run → `status='Done'`, `head_commit IS NULL`, `diff_stat IS NULL`.
|
||||||
| 1a | SignalR-Endpoint | Manuell verifiziert (HTTP 400 auf `/hub` ohne Handshake) | OK |
|
- Kein Git-Repo (`working_dir=C:\Temp`) → `status='Failed'`, **keine** `worktrees`-Row, Git-Fehler im Log.
|
||||||
| 1b | Hub-Roundtrip `Ping` | **Nicht getestet** | Test-Client schreiben oder UI starten und im Log nach "pong" schauen |
|
- **Feature-Walkthroughs:** Planning-Session-Flow (Draft→Finalize→Chain), Prime/Daily-Prep-Trigger, Weekly-Report-Generierung, Self-Update (Banner → Update → „up to date").
|
||||||
| 2 | `claude --version` Preflight | **Nicht implementiert** | `Worker/Program.cs`: vor `app.Run()` einmal `claude --version` shellen und bei Exit≠0 abbrechen |
|
- **Worker-Autostart am Gerät:** Logoff/Logon-Autostart, Update-Pfad, Uninstall entfernt die Startup-`.lnk`.
|
||||||
| 3 | Smoke-Spawn (`claude -p` mit Prompt "ping") | **Nicht getestet** | Integrationstest schreiben oder einmal manuell laufen lassen |
|
|
||||||
| 4 | E2E Happy Path (Non-Worktree) | **Nicht getestet** | UI starten → Liste "Test" anlegen → Task mit Tag `agent` + Status `queued` + Description "Schreibe ein Haiku über Intralogistik" → Run abwarten → Result prüfen |
|
|
||||||
| 5 | Worktree Happy Path | **Nicht getestet** | Manueller Test mit echtem Repo (z.B. einem temp-Repo) |
|
|
||||||
| 6 | No-Changes-Run | **Nicht getestet** | Prompt der nichts ändert → `head_commit` bleibt NULL |
|
|
||||||
| 7 | Kein Git-Repo | **Nicht getestet** | working_dir auf `C:\Temp` → Task `failed`, keine `worktrees`-Row |
|
|
||||||
| 8 | Merge-UI | **Nicht getestet** (UI ruft `GitService.MergeFfOnlyAsync`, aber nie ausgeführt) | Manuell |
|
|
||||||
| 9 | Override-Parallelität | Tests vorhanden für Slot-Logik, **End-to-End nicht** | UI: zwei Tasks queuen, `Run Now` auf der zweiten → beide laufen parallel |
|
|
||||||
| 10 | Schedule | Logik per Test abgedeckt, **End-to-End nicht** | Task mit `scheduled_for = now+2min` |
|
|
||||||
| 11 | Worker-Offline-Erkennung | UI hat Status-Bar, aber **nicht visuell verifiziert** | Worker killen, schauen ob Status auf "offline" wechselt |
|
|
||||||
| 12 | Live-Stream | **Nicht getestet** | Während Run TaskDetail öffnen, beobachten ob ndjson-Zeilen erscheinen |
|
|
||||||
| 13 | Wake-up (UI ruft `WakeQueue` nach Anlage) | Implementiert in `TaskListViewModel`, **nicht visuell verifiziert** | Tasks nach Anlage in <1s gepickert |
|
|
||||||
|
|
||||||
**Vorschlag:** Wir machen einmal Step 4 (Haiku-Happy-Path) gemeinsam — wenn das läuft, ist die ganze Pipeline lebendig.
|
## Offene Code-Punkte
|
||||||
|
|
||||||
|
- **Status-Bar Live-Update:** Prüfen, ob `RunNow`-Enable/Disable pro Task-Row bei Connection-Change sauber re-evaluiert. Connection-Status lebt in `IslandsShellViewModel` / `WorkerConnectionModalViewModel` (es gibt keinen `StatusBarViewModel` mehr). Erst messen, dann ggf. fixen. Klein.
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
## 2. UI-Polish (kritisch für Benutzbarkeit)
|
## Bewusst verworfen (nicht erneut vorschlagen)
|
||||||
|
|
||||||
Im aktuellen Stand kompiliert die UI, aber mehrere Stellen sind als `// TODO` markiert. Reihenfolge nach Schmerz:
|
- **CI-Build/Test-Pipeline** — push-to-main + release-on-push deckt das ab; Tests laufen am Ende jeder Session.
|
||||||
|
- **Real-`claude`-Smoke-Test als xUnit-Test** — kein Claude in `dotnet test`; bleibt manueller Check (siehe oben). Tests nutzen `FakeClaudeProcess`.
|
||||||
### 2.1 Folder-Picker für `Working Directory`
|
- **`architecture.md` / ADRs** — die per-Projekt-`CLAUDE.md`-Dateien sind die lebende Doku; ADRs lohnen solo nicht.
|
||||||
- **Datei:** `src/ClaudeDo.Ui/Views/ListEditorView.axaml` + `src/ClaudeDo.Ui/ViewModels/ListEditorViewModel.cs`
|
- **Task-Mailbox-Integration** — geparkt; das generische `mcp__mailbox__*`-Plugin reicht (Begründung in `mailbox-proposal.md`).
|
||||||
- **Aktuell:** plain `TextBox` — Pfad muss getippt werden.
|
- **Tag-Negation, Tag-Multi-Select, Notes-`lists.kind`-Switch, Install-Service-Skript** — durch die aktuelle Architektur überholt (Tag-System entfernt, Notes/Autostart anders gelöst).
|
||||||
- **Soll:** Button "…" daneben → öffnet `IStorageProvider.OpenFolderPickerAsync`, schreibt Pfad ins Feld.
|
|
||||||
- **Aufwand:** klein, ~30 Zeilen.
|
|
||||||
|
|
||||||
### 2.2 Delete-Confirmation
|
|
||||||
- **Dateien:** `MainWindowViewModel.DeleteList`, `TaskListViewModel.DeleteTask`
|
|
||||||
- **Aktuell:** löscht direkt ohne Rückfrage. Datenverlust-Risiko.
|
|
||||||
- **Soll:** Mini-Dialog "Wirklich löschen?" mit Ja/Nein.
|
|
||||||
- **Aufwand:** klein, generisches `ConfirmDialog` lohnt sich (1× bauen, mehrfach nutzen).
|
|
||||||
|
|
||||||
### 2.3 Markdown-Rendering für Result + Description
|
|
||||||
- **Datei:** `src/ClaudeDo.Ui/Views/TaskDetailView.axaml`
|
|
||||||
- **Aktuell:** `TextBox IsReadOnly="True"` mit Plaintext.
|
|
||||||
- **Soll:** `Markdown.Avalonia` Package einbinden und auf `MarkdownScrollViewer` umstellen.
|
|
||||||
- **Aufwand:** mittel — Package + ein paar XAML-Anpassungen. Theme-Integration kann nerven.
|
|
||||||
|
|
||||||
### 2.4 Live-Log Auto-Scroll
|
|
||||||
- **Datei:** `src/ClaudeDo.Ui/Views/TaskDetailView.axaml.cs` (oder im VM)
|
|
||||||
- **Aktuell:** ndjson-Zeilen werden angehängt, aber Scrollposition bleibt stehen.
|
|
||||||
- **Soll:** Bei jeder neuen Zeile `ScrollViewer.ScrollToEnd()` solange User nicht manuell hochgescrollt hat (Sticky-Bottom-Pattern).
|
|
||||||
- **Aufwand:** klein, ein attached behavior reicht.
|
|
||||||
|
|
||||||
### 2.5 Diff-Viewer
|
|
||||||
- **Datei:** `TaskDetailViewModel.ShowDiffAsync`
|
|
||||||
- **Aktuell:** `Process.Start("cmd", "/k git diff …")` — separates Konsolenfenster, hässlich.
|
|
||||||
- **Soll:** entweder unified-diff inline anzeigen (`git diff` Output in `TextBox` mit Mono-Font + Color für +/-) oder einen externen Diff-Tool-Hook (`git difftool`).
|
|
||||||
- **Aufwand:** mittel. MVP: einfach nur den Diff-Output in einem Modal.
|
|
||||||
|
|
||||||
### 2.6 Status-Bar Active-Tasks Live-Update
|
|
||||||
- **Datei:** `StatusBarViewModel`
|
|
||||||
- **Risiko:** das Slot-State-Update kommt vom WorkerClient, aber `RunNowCommand.NotifyCanExecuteChanged` triggert nicht pro Item bei `IsConnected`-Wechsel (vom Slice-F-Agent dokumentiert).
|
|
||||||
- **Soll:** Über `WeakReferenceMessenger` (CommunityToolkit.Mvvm) eine Connection-Change-Message verteilen, an die alle `TaskItemViewModel` lauschen.
|
|
||||||
- **Aufwand:** klein, aber muss sauber gemacht werden.
|
|
||||||
|
|
||||||
### 2.7 Settings-Dialog
|
|
||||||
- **Datei:** *neu* — `Views/SettingsDialog.axaml` + VM
|
|
||||||
- **Aktuell:** `~/.todo-app/ui.config.json` muss von Hand editiert werden.
|
|
||||||
- **Soll:** Dialog mit Feldern: DB-Pfad, SignalR-Port, Default-Tags. Persistiert zurück in JSON.
|
|
||||||
- **Aufwand:** mittel. Achtung: Port-Wechsel braucht Worker-Restart.
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## 3. Worker-Robustheit
|
|
||||||
|
|
||||||
### 3.1 CLI-Preflight beim Worker-Start
|
|
||||||
- **Datei:** `src/ClaudeDo.Worker/Program.cs`
|
|
||||||
- **Soll:** vor `app.Run()` `claude --version` ausführen; bei Fehler `app.Logger.LogCritical` + `Environment.Exit(1)`.
|
|
||||||
- **Aufwand:** klein, ~20 Zeilen. Liefert Verification Step 2.
|
|
||||||
|
|
||||||
### 3.2 Worktree-Cleanup beim Anlege-Failed
|
|
||||||
- **Datei:** `src/ClaudeDo.Worker/Runner/WorktreeManager.cs`
|
|
||||||
- **Aktuell:** Wenn `WorktreeAddAsync` zwischen `CreateAsync`-Schritten failt (z.B. Branch existiert schon), bleibt evtl. ein halbangelegter Worktree-Dir auf der Platte.
|
|
||||||
- **Soll:** try/finally — bei Fehler `git worktree remove --force` als Best-Effort-Cleanup.
|
|
||||||
- **Aufwand:** klein.
|
|
||||||
|
|
||||||
### 3.3 Logging über `Microsoft.Extensions.Logging` strukturieren
|
|
||||||
- **Datei:** alle Worker-Komponenten
|
|
||||||
- **Aktuell:** ILogger wird benutzt, aber kein File-Sink konfiguriert.
|
|
||||||
- **Soll:** Optional Serilog oder einfach `AddFile` (Karambolage.Extensions.Logging.File) — Service-Modus braucht persistente Logs außerhalb der Console.
|
|
||||||
- **Aufwand:** klein.
|
|
||||||
|
|
||||||
### 3.4 Tag-Negation / Exclusion (Plan-TODO)
|
|
||||||
- **Plan-Sektion:** "Tag-Modell"
|
|
||||||
- **Aktuell:** Tags sind rein additiv (`list_tags ∪ task_tags`).
|
|
||||||
- **Soll:** Mechanismus, um auf Task-Ebene einen List-Tag auszuschließen. Z.B. neue Tabelle `task_tag_exclusions` ODER ein Prefix `!tag` im task_tags-Eintrag.
|
|
||||||
- **Aufwand:** mittel — Schema + Repo + Tests + UI.
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## 4. Service-Deployment (Plan-Sektion „Worker als Windows-Service")
|
|
||||||
|
|
||||||
### 4.1 Windows-Service-Hosting in Code
|
|
||||||
- **Datei:** `src/ClaudeDo.Worker/Program.cs`
|
|
||||||
- **Pakete:** `Microsoft.Extensions.Hosting.WindowsServices`
|
|
||||||
- **Soll:**
|
|
||||||
```csharp
|
|
||||||
builder.Host.UseWindowsService(o => o.ServiceName = "ClaudeDoWorker");
|
|
||||||
builder.Logging.AddEventLog(...);
|
|
||||||
```
|
|
||||||
- **Aufwand:** klein.
|
|
||||||
|
|
||||||
### 4.2 Pfad-Auflösung absolut machen
|
|
||||||
- Bereits in `WorkerConfig.Load` per `Paths.Expand` gemacht — verifizieren, dass auch `cfg.ClaudeBin` ggf. in Service-PATH gefunden wird.
|
|
||||||
|
|
||||||
### 4.3 Install-Skripte / Doku
|
|
||||||
- **Datei:** *neu* — `docs/install-service.md` oder `scripts/install-service.cmd`
|
|
||||||
- **Inhalt:** `dotnet publish` + `sc.exe create` + `sc.exe failure` + Hinweis auf `obj=` (User-Account) wegen Claude-CLI-Session.
|
|
||||||
- **Aufwand:** klein.
|
|
||||||
|
|
||||||
### 4.4 (später) Installer-Projekt
|
|
||||||
- WiX/MSIX, registriert Service + UI-Shortcut. Plan-Sektion „Offene Punkte".
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## 5. Tests / CI
|
|
||||||
|
|
||||||
### 5.1 GitHub-Actions / Gitea-Actions Pipeline
|
|
||||||
- **Datei:** *neu* — `.gitea/workflows/ci.yml` (oder `.github/workflows/ci.yml`)
|
|
||||||
- **Inhalt:** `dotnet restore` → `dotnet build --no-restore` → `dotnet test --no-build`. Auf Push + PR.
|
|
||||||
- **Aufwand:** klein.
|
|
||||||
|
|
||||||
### 5.2 Echter SignalR-Roundtrip-Test
|
|
||||||
- **Datei:** *neu* — `tests/ClaudeDo.Worker.Tests/Hub/WorkerHubTests.cs`
|
|
||||||
- **Soll:** mit `WebApplicationFactory` + `HubConnectionBuilder` testen, dass `Ping`, `GetActive`, `RunNow`-Throw-Verhalten korrekt sind. Plan-Verification 1b + 9.
|
|
||||||
- **Aufwand:** mittel.
|
|
||||||
|
|
||||||
### 5.3 Smoke-Test gegen echten `claude`
|
|
||||||
- **Datei:** *neu* — `tests/ClaudeDo.Worker.Tests/Runner/ClaudeProcessSmokeTest.cs`
|
|
||||||
- **Soll:** Real-CLI-Test, der mit `[Fact(Skip="..."]` ausgegraut bleibt und nur lokal aktiviert wird, wenn `CLAUDE_AUTHENTICATED=1` Env-Var gesetzt ist.
|
|
||||||
- **Aufwand:** klein.
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## 6. Dokumentation
|
|
||||||
|
|
||||||
### 6.1 README.md
|
|
||||||
- Komplett fehlt. Mind. 1× kurz: was ist es, wie starten (Worker + UI), wo Config.
|
|
||||||
- **Aufwand:** klein.
|
|
||||||
|
|
||||||
### 6.2 `docs/architecture.md`
|
|
||||||
- In `plan.md` schon teilweise enthalten — kann entweder konsolidiert oder explizit ausgegliedert werden.
|
|
||||||
|
|
||||||
### 6.3 ADRs für die getroffenen Entscheidungen
|
|
||||||
- Z.B. „SignalR vs. SQLite-Polling für IPC", „Worktree pro Task", „SignalR über Loopback ohne Auth".
|
|
||||||
- **Aufwand:** klein, hilfreich für später.
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## 7. Bekannte Code-Schulden / Smells
|
|
||||||
|
|
||||||
| Stelle | Issue |
|
|
||||||
|---|---|
|
|
||||||
| `WorkerHub.GetActive` returnt `IReadOnlyList<object>` mit anonymen Typen | Sollte ein expliziter DTO sein (`ActiveTaskDto`), den Worker UND Ui teilen. Aktuell duplizieren beide das Schema. |
|
|
||||||
| `TaskRunner` führt eine `if (list.WorkingDir != null)` Verzweigung mitten in der Methode | Strategy-Pattern (`IRunStrategy`: SandboxStrategy, WorktreeStrategy) wenn die Methode wächst. Aktuell noch klein genug. |
|
|
||||||
| `App.Services` als public static `ServiceProvider` | Service-Locator-Antipattern. Toleriert, weil nur in `App.OnFrameworkInitializationCompleted` verwendet. Falls mehr Code drauf zugreift → echtes DI durchziehen. |
|
|
||||||
| Embedded `schema.sql` ohne Versionierung | Solange das Schema nicht in Production läuft, OK. Sobald User-Daten existieren → `migrations/` Folder + Version-Tabelle. |
|
|
||||||
| CRLF-Warnings beim Commit | `.gitattributes` mit `* text=auto eol=lf` (oder explizit pro Sprache) wäre sauberer. |
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Empfohlene Reihenfolge für die nächste Session
|
|
||||||
|
|
||||||
1. **Verification Step 4** zusammen durchspielen → falls etwas grundlegend kaputt ist, jetzt finden, nicht später.
|
|
||||||
2. **CLI-Preflight (3.1)** + **Folder-Picker (2.1)** + **Delete-Confirm (2.2)** — kleine, isolierte Wins.
|
|
||||||
3. **Auto-Scroll (2.4)** + **Active-Tasks Live-Update (2.6)** — User-Experience im Detail-Pane.
|
|
||||||
4. **Markdown-Rendering (2.3)** — größer, lohnt sich aber für Lesbarkeit.
|
|
||||||
5. **Worktree-Cleanup (3.2)** — Robustheit, bevor wir Worktrees ernsthaft nutzen.
|
|
||||||
6. **CI-Pipeline (5.1)** — automatisches Sicherheitsnetz für alles weitere.
|
|
||||||
7. **Service-Deployment (4)** — wenn die App lokal stabil läuft.
|
|
||||||
8. **Settings-Dialog (2.7)** + **Diff-Viewer (2.5)** — Polish.
|
|
||||||
9. **Tag-Negation (3.4)** — wenn der Bedarf konkret wird.
|
|
||||||
|
|
||||||
Punkte 1–3 sind ein realistischer Block für eine Session.
|
|
||||||
|
|||||||
37
docs/plan.md
37
docs/plan.md
@@ -49,7 +49,9 @@ Schema in 3NF. Keine Mehrwert-Felder (z.B. JSON-Arrays), keine transitiven Abhä
|
|||||||
- `list_id` TEXT NOT NULL REFERENCES `lists(id)` ON DELETE CASCADE
|
- `list_id` TEXT NOT NULL REFERENCES `lists(id)` ON DELETE CASCADE
|
||||||
- `title` TEXT NOT NULL
|
- `title` TEXT NOT NULL
|
||||||
- `description` TEXT NULL
|
- `description` TEXT NULL
|
||||||
- `status` TEXT NOT NULL — `manual` | `queued` | `running` | `done` | `failed` (`running` bleibt persistiert für Crash-Recovery: stale `running`-Tasks werden beim Worker-Start auf `failed` gesetzt)
|
- `status` TEXT NOT NULL — Lifecycle-only: `idle` | `queued` | `running` | `done` | `failed` | `cancelled` (`running` bleibt persistiert für Crash-Recovery: stale `running`-Tasks werden beim Worker-Start auf `failed` gesetzt). Planungs-Hierarchie und Chain-Blocking laufen über zwei separate Felder.
|
||||||
|
- `planning_phase` TEXT NOT NULL DEFAULT `'none'` — Parent-only Marker: `none` | `active` (Planung läuft) | `finalized` (Plan committed, Children existieren). Ein Parent kann `status='idle'` sein und gleichzeitig `planning_phase='finalized'` (für Re-Runs).
|
||||||
|
- `blocked_by_task_id` TEXT NULL REFERENCES `tasks(id)` ON DELETE SET NULL — Vorgänger in einem sequenziellen Subtask-Chain. Ein `queued`-Row mit `blocked_by_task_id IS NOT NULL` wird vom Picker übersprungen.
|
||||||
- `scheduled_for` TIMESTAMP NULL — "nicht vor"
|
- `scheduled_for` TIMESTAMP NULL — "nicht vor"
|
||||||
- `result` TEXT NULL (Markdown)
|
- `result` TEXT NULL (Markdown)
|
||||||
- `log_path` TEXT NULL — Pfad zur ndjson-Log-Datei
|
- `log_path` TEXT NULL — Pfad zur ndjson-Log-Datei
|
||||||
@@ -229,36 +231,21 @@ Beispiel: `feat(lager-app): add barcode scan retry logic`
|
|||||||
|
|
||||||
DB-Zugriff via Microsoft.Data.Sqlite + Repository-Layer (`TaskRepository`, `ListRepository`). Git-Operationen (UI + Worker) über gemeinsamen `GitService` in `ClaudeDo.Data`. MVVM via CommunityToolkit.Mvvm.
|
DB-Zugriff via Microsoft.Data.Sqlite + Repository-Layer (`TaskRepository`, `ListRepository`). Git-Operationen (UI + Worker) über gemeinsamen `GitService` in `ClaudeDo.Data`. MVVM via CommunityToolkit.Mvvm.
|
||||||
|
|
||||||
## Worker als Windows-Service (Ziel-Deployment)
|
## Worker-Deployment (Autostart via Startup-Shortcut)
|
||||||
|
|
||||||
Initial läuft der Worker als Console-Prozess (lokales Dev-Setup). Im Endzustand soll er als **Windows-Service** automatisch starten.
|
Der Worker läuft als **WinExe** (kein Konsolenfenster) — kein Windows-Service, kein Scheduled Task.
|
||||||
|
|
||||||
**Code-seitig:**
|
**Autostart:** Der Installer legt eine Verknüpfung `ClaudeDo Worker.lnk` im Startup-Ordner des Users an (`%APPDATA%\Microsoft\Windows\Start Menu\Programs\Startup\`). Dafür nutzt `ClaudeDo.Installer` den Helper `AutostartShortcut` (mit extrahiertem `ShortcutFactory` COM-Helper). Beim Windows-Logon startet Windows die Verknüpfung automatisch — ohne Elevated-Rechte und mit vollem Zugriff auf die `~/.claude/`-Session des Users.
|
||||||
- Paket `Microsoft.Extensions.Hosting.WindowsServices` referenzieren.
|
|
||||||
- In `Program.cs`: `builder.Host.UseWindowsService(o => o.ServiceName = "ClaudeDoWorker")`.
|
|
||||||
- Logging zusätzlich über `EventLog` (`builder.Logging.AddEventLog(...)`), damit Service-Fehler im Windows Event Viewer landen.
|
|
||||||
- Alle Pfade in `worker.config.json` **absolut** auflösen (`%USERPROFILE%` / `~` expandieren) — der Service-Working-Directory ist standardmäßig `C:\Windows\System32`.
|
|
||||||
- `StaleTaskRecovery` (siehe oben) sorgt nach Service-Restart automatisch für das Aufräumen hängender `running`-Tasks.
|
|
||||||
- Restart-Verhalten via `sc.exe failure`-Konfig oder beim Install.
|
|
||||||
|
|
||||||
**Install:**
|
**Manueller Start (App-seitig):** Der Installer-Step `StartWorkerStep` startet den Worker beim Install/Update via `Process.Start` direkt. Die App (`IslandsShellViewModel`) startet den Worker **nicht** selbst. Stattdessen: ist der Worker ~12 Sekunden nach App-Start noch offline, erscheint einmalig ein `WorkerConnectionModal` mit drei Optionen (Start Worker / Rerun Installer / Dismiss). Der Connection-Status-Pill in der Fußzeile ist ein klickbarer Button, der das Modal auf Anfrage erneut öffnet.
|
||||||
- Veröffentlichen mit `dotnet publish -c Release -r win-x64 --self-contained false`.
|
|
||||||
- Service registrieren:
|
|
||||||
```cmd
|
|
||||||
sc.exe create ClaudeDoWorker binPath= "C:\Path\To\ClaudeDo.Worker.exe" start= auto
|
|
||||||
sc.exe failure ClaudeDoWorker reset= 60 actions= restart/5000/restart/10000/restart/30000
|
|
||||||
```
|
|
||||||
- Später optional: kleines `ClaudeDo.Installer`-Projekt (WiX oder MSIX), das das auch macht.
|
|
||||||
|
|
||||||
**Auth-Konflikt mit "User-CLI-Session" beachten:**
|
**Stop/Uninstall:** `StopWorkerStep` beendet den Worker via prozessbasiertem Kill (kein `schtasks /End` mehr). `UninstallRunner` löscht die Startup-`.lnk`. Als Migrations-Schritt für ältere Installationen löscht der Uninstaller auch den Legacy-Scheduled-Task „ClaudeDoWorker" und den Legacy-Windows-Service (best-effort).
|
||||||
Der Worker-Service läuft per Default unter `LocalSystem` — der hat **keinen Zugriff** auf die `~/.claude/`-Session des interaktiven Users, in der der CLI-Login liegt. Optionen:
|
|
||||||
|
|
||||||
1. **Empfohlen:** Service unter dem **User-Account** laufen lassen (`sc.exe config ClaudeDoWorker obj= ".\<username>" password= "..."` oder via `services.msc` → "Log On As"). Dann greift die bestehende `claude login`-Session des Users. Voraussetzung: User-Account hat das Recht "Log on as a service".
|
**Logging:** Serilog-File-Sink nach `~/.todo-app/logs/worker-*.log`. Single-Instance-Mutex verhindert parallele Instanzen.
|
||||||
2. **Fallback:** Wieder auf API-Key wechseln (`ANTHROPIC_API_KEY` als Umgebungsvariable des Service oder im `worker.config.json`). Dann ist der Service unabhängig vom User-Profil — verliert aber den Vorteil "kein Key-Handling".
|
|
||||||
|
|
||||||
Entscheidung wird beim Service-Deployment getroffen, bleibt für die initiale Console-Variante irrelevant. Service-Modus erfordert keine Schema- oder API-Änderungen am Worker.
|
**Pfade:** `WorkerConfig.Load` expandiert `~`/`%USERPROFILE%` für alle Pfad-Felder.
|
||||||
|
|
||||||
**SignalR im Service-Modus:** Bindung bleibt `127.0.0.1:47821`. Da die UI auf demselben Rechner läuft, ist Loopback-Erreichbarkeit gegeben — Windows-Firewall greift bei Loopback nicht.
|
**SignalR:** Bindung bleibt `127.0.0.1:47821`. Da die UI auf demselben Rechner läuft, ist Loopback-Erreichbarkeit gegeben — Windows-Firewall greift bei Loopback nicht.
|
||||||
|
|
||||||
## Project-Layout (Monorepo)
|
## Project-Layout (Monorepo)
|
||||||
|
|
||||||
@@ -317,4 +304,4 @@ Vorteil Monorepo: gemeinsames `schema.sql`, atomische Änderungen über UI+Worke
|
|||||||
- Bulk-Discard alter Worktrees.
|
- Bulk-Discard alter Worktrees.
|
||||||
- Anzeige der ndjson-Message-Chronik im UI.
|
- Anzeige der ndjson-Message-Chronik im UI.
|
||||||
- Windows Job Objects für garantierten Child-Cleanup beim Worker-Crash.
|
- Windows Job Objects für garantierten Child-Cleanup beim Worker-Crash.
|
||||||
- Installer-Projekt (`ClaudeDo.Installer`, WiX/MSIX), das den Service registriert + UI shortcut anlegt.
|
- Install-Skripte/Doku für manuelles Deployment ohne Installer.
|
||||||
|
|||||||
217
docs/prompts-inventory.md
Normal file
217
docs/prompts-inventory.md
Normal file
@@ -0,0 +1,217 @@
|
|||||||
|
|
||||||
|
|
||||||
|
|
||||||
|
# ClaudeDo — Prompt & CLI Inventory
|
||||||
|
|
||||||
|
Snapshot of every string ClaudeDo sends to Claude CLI, plus the CLI-flag surface that shapes each run. Intended as a working doc for tomorrow's prompt-tuning pass.
|
||||||
|
|
||||||
|
Date: 2026-04-24
|
||||||
|
|
||||||
|
> **Update 2026-06-04 — prompts externalized.** All prose prompts now live as
|
||||||
|
> editable files under `~/.todo-app/prompts/`, each seeded from a bundled default in
|
||||||
|
> `src/ClaudeDo.Data/PromptFiles.cs` (read via `ReadOrDefault` / `Render`, which
|
||||||
|
> substitutes only named `{tokens}`):
|
||||||
|
> `system.md`, `planning-system.md`, `planning-initial.md` (`{title}`/`{description}`),
|
||||||
|
> `retry.md`, `daily-prep.md` (`{date}`/`{maxTasks}`), `weekly-report.md`
|
||||||
|
> (`{start}`/`{end}`; German output). The old `agent.md` and `planning.md` are
|
||||||
|
> retired — `system.md` is the single appended system prompt (the agent/manual split
|
||||||
|
> is gone), and the planning system prompt is `planning-system.md`. Daily-prep and
|
||||||
|
> retry prompts are now English; retry leans on the resumed session and appends the
|
||||||
|
> captured stderr only when it's a real error (not the generic "exited with code N").
|
||||||
|
> The system prompt instructs the agent to emit `CLAUDEDO_BLOCKED: <reason>` on its
|
||||||
|
> own line for any true blocker; `StreamAnalyzer` collects every marker, strips them
|
||||||
|
> from the result, and `TaskRunner` folds them into the review result as a
|
||||||
|
> "⚠ Roadblocks" section. All six prompt files are editable from Settings → Files.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 1. Task-execution prompts (agent-tagged tasks → Claude CLI)
|
||||||
|
|
||||||
|
Used for every "agent" task that the queue picks up or that `RunNow` dispatches.
|
||||||
|
Orchestration lives in `src/ClaudeDo.Worker/Runner/TaskRunner.cs` and `ClaudeArgsBuilder.cs`.
|
||||||
|
|
||||||
|
### 1.1 User prompt (stdin) — `TaskRunner.RunAsync` ~L101–L110
|
||||||
|
|
||||||
|
Plain text, no template around it:
|
||||||
|
|
||||||
|
```
|
||||||
|
{task.Title}
|
||||||
|
|
||||||
|
{task.Description?.Trim()} ← only if non-empty
|
||||||
|
|
||||||
|
## Sub-Tasks ← only if subtasks exist
|
||||||
|
- [ ] {subtask.Title} ← "[x]" if completed
|
||||||
|
...
|
||||||
|
```
|
||||||
|
|
||||||
|
Notes
|
||||||
|
- Title is included verbatim — no leading `#` heading.
|
||||||
|
- No role tags, no XML, no delimiters between title and description — just blank lines.
|
||||||
|
- Sub-Tasks section uses markdown checkboxes. This is the only structural scaffolding.
|
||||||
|
- No context about the project, working dir, or git state is added here.
|
||||||
|
|
||||||
|
### 1.2 Retry prompt (on failure, when a session ID exists) — `TaskRunner` ~L126
|
||||||
|
|
||||||
|
```
|
||||||
|
The previous attempt failed with:
|
||||||
|
|
||||||
|
{result.ErrorMarkdown}
|
||||||
|
|
||||||
|
Try again and fix the issues.
|
||||||
|
```
|
||||||
|
|
||||||
|
Fired once per task via `--resume <session_id>`; if the retry also fails, the task is marked Failed.
|
||||||
|
|
||||||
|
### 1.3 Follow-up prompt (multi-turn `ContinueAsync`) — `TaskRunner.ContinueAsync` L159
|
||||||
|
|
||||||
|
The UI/hub supplies `followUpPrompt` as-is; no wrapping. The session is resumed via `--resume`. So the effective "prompt template" is whatever the user types in the Continue textbox.
|
||||||
|
|
||||||
|
### 1.4 System prompt — merged in `TaskRunner` ~L413–L418
|
||||||
|
|
||||||
|
Built by `TaskRunner.MergeInstructions(global, list, task)` which concatenates three optional strings with `\n\n`:
|
||||||
|
|
||||||
|
1. `AppSettings.DefaultClaudeInstructions` (global, set in Settings modal, default `""`)
|
||||||
|
2. `list_config.SystemPrompt` (per-list override)
|
||||||
|
3. `task.SystemPrompt` (per-task override)
|
||||||
|
|
||||||
|
The merged string is passed as `--append-system-prompt <instructions>` to the CLI. Empty/whitespace → flag is omitted entirely.
|
||||||
|
|
||||||
|
**Currently the global `DefaultClaudeInstructions` ships as empty string** (see `AppSettingsEntity.cs` L9). Anything in the system prompt today is whatever the user typed into Settings / List-Settings / Task-Settings.
|
||||||
|
|
||||||
|
### 1.5 CLI args — `ClaudeArgsBuilder.Build` (`ClaudeArgsBuilder.cs`)
|
||||||
|
|
||||||
|
Always on:
|
||||||
|
- `-p`
|
||||||
|
- `--output-format stream-json`
|
||||||
|
- `--verbose`
|
||||||
|
- `--permission-mode {auto|acceptEdits|plan|default}` (legacy `bypassPermissions` → `auto`)
|
||||||
|
|
||||||
|
Conditional:
|
||||||
|
- `--model {sonnet|opus|haiku|...}` — from `task.Model ?? list.Model ?? AppSettings.DefaultModel` (default `sonnet`)
|
||||||
|
- `--max-turns {n}` — `AppSettings.DefaultMaxTurns` (default `100`)
|
||||||
|
- `--append-system-prompt "{merged instructions}"` — see 1.4
|
||||||
|
- `--agents '[{"file":"{path}"}]'` — from task or list override, points at an agent `.md`
|
||||||
|
- `--resume {session_id}` — for retries and `ContinueAsync`
|
||||||
|
|
||||||
|
Unused but pre-declared:
|
||||||
|
- `ResultSchema` — a `{summary, files_changed, commit_type}` JSON schema is serialized but **never attached** to args in `Build`. Dead code today; relevant if we turn on `--output-schema`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 2. Planning-agent prompts (`/plan` / Planning session)
|
||||||
|
|
||||||
|
Used by the Planning feature, which spawns a Claude session inside a git worktree with MCP tools so the agent can create Subtasks under the parent.
|
||||||
|
Source: `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs`.
|
||||||
|
|
||||||
|
### 2.1 System prompt — `BuildSystemPrompt()` L290–L308
|
||||||
|
|
||||||
|
```
|
||||||
|
You are a planning assistant for ClaudeDo.
|
||||||
|
Your role is to help break down a task into smaller, actionable subtasks.
|
||||||
|
Your final goal WILL ALWAYS be the creation of Subtasks
|
||||||
|
|
||||||
|
ALWAYS invoke the `superpowers:brainstorming` skill via the Skill tool at the
|
||||||
|
start of every planning session, and follow its process end-to-end. It guides
|
||||||
|
you through clarifying questions, approach exploration, and design approval
|
||||||
|
BEFORE any subtasks are created. Do not create child tasks until the user has
|
||||||
|
approved a design.
|
||||||
|
|
||||||
|
NEVER Change files yourself.
|
||||||
|
|
||||||
|
ALWAYS Use the available MCP tools (mcp__claudedo__*) to create child tasks once the
|
||||||
|
design is approved. When you are done planning, finalize the session.
|
||||||
|
|
||||||
|
Be concise and focused. Each subtask should be independently executable.
|
||||||
|
```
|
||||||
|
|
||||||
|
Written to `{session-dir}/system-prompt.md` at session start and fed via `--append-system-prompt`.
|
||||||
|
|
||||||
|
Notes / known oddities
|
||||||
|
- Trailing space on "NEVER Change files yourself. " and on the blank line above the ALWAYS/MCP block.
|
||||||
|
- Mixes voice ("Your role is", "ALWAYS invoke") — could be tightened.
|
||||||
|
- Implicitly relies on the `superpowers:brainstorming` skill being installed in the worktree's Claude config.
|
||||||
|
- Does not name the MCP tools explicitly (the `mcp__claudedo__*` wildcard assumes the agent discovers them via tool listing).
|
||||||
|
|
||||||
|
### 2.2 Initial prompt — `BuildInitialPrompt(task)` L310–L323
|
||||||
|
|
||||||
|
```
|
||||||
|
# Task: {task.Title}
|
||||||
|
|
||||||
|
{task.Description} ← only if non-empty
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
Please analyze this task and break it down into concrete subtasks.
|
||||||
|
```
|
||||||
|
|
||||||
|
Written to `{session-dir}/initial-prompt.txt`; the Windows Terminal launcher pipes it to the Claude CLI on start.
|
||||||
|
|
||||||
|
### 2.3 Planning session CLI flags
|
||||||
|
|
||||||
|
`PlanningSessionManager` itself does not build CLI args — the `WindowsTerminalPlanningLauncher` does. Relevant facts:
|
||||||
|
- Permission mode: **plan** (per recent commit `8e9f09a` "run planning agent in plan permission mode and enforce brainstorming skill").
|
||||||
|
- Runs with an `.mcp.json` that points at our local MCP server (`http://127.0.0.1:{port}/mcp`) with a per-session bearer token.
|
||||||
|
- `.claude/settings.local.json` sets `"enableAllProjectMcpServers": true` so the MCP tools auto-activate.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 3. Commit-message template (not a prompt, but agent-visible)
|
||||||
|
|
||||||
|
Built by `CommitMessageBuilder.Build` (`CommitMessageBuilder.cs`). Format:
|
||||||
|
|
||||||
|
```
|
||||||
|
{commitType}({listSlug}): {title ≤60 chars}
|
||||||
|
|
||||||
|
{description ≤400 chars} ← only if set
|
||||||
|
|
||||||
|
ClaudeDo-Task: {taskId}
|
||||||
|
```
|
||||||
|
|
||||||
|
- `commitType` comes from `task.CommitType` (default `chore`, list default configurable).
|
||||||
|
- Slug = lowercased list name with non-alphanumerics stripped, runs collapsed to `-`.
|
||||||
|
- The agent sees the resulting commit in `git log` during retries and follow-ups, so phrasing here bleeds into model behavior on multi-turn work.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 4. Where each prompt is edited (UI surface)
|
||||||
|
|
||||||
|
| Prompt slot | Edited in | Stored as |
|
||||||
|
|-------------------------------------|--------------------------------------------|--------------------------------------------|
|
||||||
|
| Global `DefaultClaudeInstructions` | Settings modal (`SettingsModalViewModel`) | `app_settings.DefaultClaudeInstructions` |
|
||||||
|
| Per-list system prompt | List-Settings modal | `list_config.SystemPrompt` |
|
||||||
|
| Per-task system prompt | Details island / task agent settings | `tasks.system_prompt` |
|
||||||
|
| Per-task agent file | Details island | `tasks.agent_path` (absolute `.md` path) |
|
||||||
|
| Default model / max turns / perms | Settings modal | `app_settings.*` |
|
||||||
|
| Planning system prompt | **Hard-coded** in `PlanningSessionManager` | not editable from UI |
|
||||||
|
| Planning initial prompt template | **Hard-coded** in `PlanningSessionManager` | not editable from UI |
|
||||||
|
| Retry prompt | **Hard-coded** in `TaskRunner` | not editable |
|
||||||
|
| Task prompt structure (title/desc) | **Hard-coded** in `TaskRunner` | not editable |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 5. Things worth reviewing tomorrow
|
||||||
|
|
||||||
|
1. **Task-execution prompt has no frame at all.** Just title + description. Consider whether a thin wrapper (goal / constraints / done-criteria) improves agent focus without bloating small tasks.
|
||||||
|
2. **Global DefaultClaudeInstructions is empty out of the box.** This is the cleanest place to put project-wide guardrails (commit format, branch etiquette, verify-before-done, no force push). Right now nothing is there.
|
||||||
|
3. **Planning system prompt**:
|
||||||
|
- Typo-level: trailing spaces, inconsistent capitalization ("ALWAYS"/"NEVER"/"Always").
|
||||||
|
- "Your final goal WILL ALWAYS be the creation of Subtasks" conflicts slightly with "Do not create child tasks until the user has approved a design" — rewordable.
|
||||||
|
- Does not state how many subtasks is reasonable, nor how granular.
|
||||||
|
- Does not describe the MCP tool surface; the agent has to discover `mcp__claudedo__*` tools.
|
||||||
|
4. **Retry prompt is minimal.** `"Try again and fix the issues."` — could be firmer about not repeating the same failure mode.
|
||||||
|
5. **Sub-Tasks block** is dumped as plain checkboxes with no instruction ("please complete all open items", "do them in order", etc.). If the user relies on subtasks for ordering, that intent isn't conveyed.
|
||||||
|
6. **ResultSchema is defined but unused.** Decide: drop it, or wire it up (`--output-schema`) and start asking for structured summaries.
|
||||||
|
7. **Commit-message template** never tells the agent what `commit_type` to pick when it has flexibility — the value is hard-coded per task. Consider exposing as a prompt hint or inferring from diffs.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 6. File pointers
|
||||||
|
|
||||||
|
- `src/ClaudeDo.Worker/Runner/TaskRunner.cs` — user/retry/follow-up prompts, MergeInstructions
|
||||||
|
- `src/ClaudeDo.Worker/Runner/ClaudeArgsBuilder.cs` — CLI args + ResultSchema
|
||||||
|
- `src/ClaudeDo.Worker/Runner/CommitMessageBuilder.cs` — commit template
|
||||||
|
- `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs` — planning system + initial prompts
|
||||||
|
- `src/ClaudeDo.Worker/Planning/WindowsTerminalPlanningLauncher.cs` — planning CLI invocation
|
||||||
|
- `src/ClaudeDo.Data/Models/AppSettingsEntity.cs` — global defaults
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Modals/SettingsModalViewModel.cs` — UI for global defaults
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Modals/ListSettingsModalViewModel.cs` — UI for per-list overrides
|
||||||
File diff suppressed because it is too large
Load Diff
File diff suppressed because it is too large
Load Diff
927
docs/superpowers/plans/2026-04-23-planning-sessions-plan-c-ui.md
Normal file
927
docs/superpowers/plans/2026-04-23-planning-sessions-plan-c-ui.md
Normal file
@@ -0,0 +1,927 @@
|
|||||||
|
# Planning Sessions — Plan C: UI Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Wire the planning-session feature into the UI: context-menu entries, hierarchical display of parent + children, draft styling, unfinished-session dialog, and the `WorkerClient` methods that call the hub endpoints built in Plan B.
|
||||||
|
|
||||||
|
**Architecture:** Extend `TaskRowViewModel` with hierarchy-aware flags (`IsChild`, `IsPlanningParent`, `IsExpanded`). `TasksIslandViewModel` builds a flat stream that interleaves parents and their children based on expanded state. Context-menu entries on `TaskRowView` gate on task status. Draft styling lives in the existing island styles. A modal dialog reuses the project's `TaskCompletionSource<T>` pattern.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, Avalonia 12, CommunityToolkit.Mvvm (`[ObservableProperty]`, `[RelayCommand]`), compiled bindings, SignalR client.
|
||||||
|
|
||||||
|
**Spec reference:** `docs/superpowers/specs/2026-04-23-planning-sessions-design.md` section 6.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Prerequisite Gate
|
||||||
|
|
||||||
|
This plan depends on Plan A being merged to `main`. Plan B's interface contract (hub method names, return types) is locked in the spec §6.6 and Plan B task 13 — this plan can proceed in parallel with Plan B.
|
||||||
|
|
||||||
|
Before starting:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git fetch origin main
|
||||||
|
git checkout main
|
||||||
|
git pull --ff-only
|
||||||
|
ls src/ClaudeDo.Data/Migrations/*AddPlanningSupport*.cs
|
||||||
|
```
|
||||||
|
|
||||||
|
If the file is missing, wait for Plan A:
|
||||||
|
```bash
|
||||||
|
while ! ls src/ClaudeDo.Data/Migrations/*AddPlanningSupport*.cs >/dev/null 2>&1; do
|
||||||
|
echo "Waiting for Plan A to merge..."
|
||||||
|
sleep 60
|
||||||
|
git fetch origin main && git pull --ff-only
|
||||||
|
done
|
||||||
|
```
|
||||||
|
|
||||||
|
Then branch:
|
||||||
|
```bash
|
||||||
|
git checkout -b feat/planning-sessions-ui
|
||||||
|
```
|
||||||
|
|
||||||
|
**Parallel-with-Plan-B note:** Plan B may not yet be merged when this plan runs. The `WorkerClient` methods in Task 9 will compile against Plan B's SignalR hub method names (they're string-based SignalR invocations), so they don't have a build-time dependency. Runtime end-to-end testing requires Plan B merged; until then, mock-test what's possible and smoke-test manually once both plans land.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File Structure
|
||||||
|
|
||||||
|
**Modified:**
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs` — add `ParentTaskId`, `IsChild`, `IsPlanningParent`, `IsExpanded`, `PlanningBadge` properties.
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs` — add planning commands, expanded-state map, flat-stream rebuild logic.
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml` — chevron, indentation, badges, draft styling hooks.
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml.cs` — context-menu event handlers (if code-behind is used; else inline).
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/TasksIslandView.axaml` — use the extended TaskRowView template.
|
||||||
|
- `src/ClaudeDo.Ui/Services/WorkerClient.cs` — five new hub method wrappers matching Plan B.
|
||||||
|
- `src/ClaudeDo.Ui/Design/IslandStyles.axaml` — `.draft`, `.planning-parent`, `.planned-parent`, badge styles.
|
||||||
|
|
||||||
|
**Created:**
|
||||||
|
- `src/ClaudeDo.Ui/Views/Dialogs/UnfinishedPlanningDialog.axaml` + `.axaml.cs` — modal Resume/Finalize/Discard dialog.
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Dialogs/UnfinishedPlanningDialogViewModel.cs` — dialog VM.
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs` — VM-level tests.
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/UiVm/TaskRowViewModelPlanningTests.cs` — VM-level tests.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: Extend `TaskRowViewModel`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs`
|
||||||
|
- Create: `tests/ClaudeDo.Worker.Tests/UiVm/TaskRowViewModelPlanningTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write failing test for planning flags**
|
||||||
|
|
||||||
|
Create the test file. Adapt the existing `TaskRowViewModelTests` pattern (look at `tests/ClaudeDo.Worker.Tests/UiVm/TaskRowViewModelTests.cs` for how VMs are constructed in tests):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Ui.ViewModels.Islands;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.UiVm;
|
||||||
|
|
||||||
|
public sealed class TaskRowViewModelPlanningTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void Draft_Status_SetsIsChildFlag_WhenParentIdIsNotNull()
|
||||||
|
{
|
||||||
|
// Adapt the constructor call to your actual TaskRowViewModel signature (see TaskRowViewModelTests).
|
||||||
|
var vm = TestHelpers.MakeRow(
|
||||||
|
status: "draft",
|
||||||
|
parentTaskId: "parent-id");
|
||||||
|
|
||||||
|
Assert.True(vm.IsChild);
|
||||||
|
Assert.False(vm.IsPlanningParent);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Planning_Status_SetsIsPlanningParent()
|
||||||
|
{
|
||||||
|
var vm = TestHelpers.MakeRow(status: "planning", parentTaskId: null);
|
||||||
|
|
||||||
|
Assert.True(vm.IsPlanningParent);
|
||||||
|
Assert.False(vm.IsChild);
|
||||||
|
Assert.Equal("PLANNING", vm.PlanningBadge);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Planned_Status_ShowsPlannedBadge()
|
||||||
|
{
|
||||||
|
var vm = TestHelpers.MakeRow(status: "planned", parentTaskId: null);
|
||||||
|
|
||||||
|
Assert.True(vm.IsPlanningParent);
|
||||||
|
Assert.Equal("PLANNED", vm.PlanningBadge);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void NonPlanningStatus_NoBadge()
|
||||||
|
{
|
||||||
|
var vm = TestHelpers.MakeRow(status: "manual", parentTaskId: null);
|
||||||
|
|
||||||
|
Assert.False(vm.IsPlanningParent);
|
||||||
|
Assert.Null(vm.PlanningBadge);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
internal static class TestHelpers
|
||||||
|
{
|
||||||
|
public static TaskRowViewModel MakeRow(string status, string? parentTaskId)
|
||||||
|
{
|
||||||
|
// Implement based on actual TaskRowViewModel constructor.
|
||||||
|
// The TaskRowViewModelTests.cs file in the same folder shows the existing pattern.
|
||||||
|
throw new NotImplementedException("Adapt to your TaskRowViewModel constructor");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Open `tests/ClaudeDo.Worker.Tests/UiVm/TaskRowViewModelTests.cs` first to see how the VM is constructed in tests, then fill in `TestHelpers.MakeRow` accordingly.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run; verify fail**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter "FullyQualifiedName~TaskRowViewModelPlanningTests"`
|
||||||
|
Expected: FAIL (properties not yet on VM).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Extend the VM**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs` add the new properties using `[ObservableProperty]`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[ObservableProperty] private string? parentTaskId;
|
||||||
|
[ObservableProperty] private bool isExpanded = true;
|
||||||
|
|
||||||
|
public bool IsChild => !string.IsNullOrEmpty(ParentTaskId);
|
||||||
|
public bool IsPlanningParent => string.Equals(Status, "planning", StringComparison.OrdinalIgnoreCase)
|
||||||
|
|| string.Equals(Status, "planned", StringComparison.OrdinalIgnoreCase);
|
||||||
|
|
||||||
|
public string? PlanningBadge => Status switch
|
||||||
|
{
|
||||||
|
string s when string.Equals(s, "planning", StringComparison.OrdinalIgnoreCase) => "PLANNING",
|
||||||
|
string s when string.Equals(s, "planned", StringComparison.OrdinalIgnoreCase) => "PLANNED",
|
||||||
|
_ => null,
|
||||||
|
};
|
||||||
|
|
||||||
|
public bool IsDraft => string.Equals(Status, "draft", StringComparison.OrdinalIgnoreCase);
|
||||||
|
```
|
||||||
|
|
||||||
|
Since `IsChild`, `IsPlanningParent`, `PlanningBadge`, and `IsDraft` are computed from other observables, you must raise property-changed notifications when `Status` or `ParentTaskId` changes. Use `[ObservableProperty]` partial methods:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
partial void OnStatusChanged(string value)
|
||||||
|
{
|
||||||
|
OnPropertyChanged(nameof(IsPlanningParent));
|
||||||
|
OnPropertyChanged(nameof(PlanningBadge));
|
||||||
|
OnPropertyChanged(nameof(IsDraft));
|
||||||
|
}
|
||||||
|
|
||||||
|
partial void OnParentTaskIdChanged(string? value)
|
||||||
|
{
|
||||||
|
OnPropertyChanged(nameof(IsChild));
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
If the existing VM already has `OnStatusChanged` (check for generator outputs), merge into it rather than duplicating.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run; verify pass**
|
||||||
|
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs tests/ClaudeDo.Worker.Tests/UiVm/TaskRowViewModelPlanningTests.cs
|
||||||
|
git commit -m "feat(ui): TaskRowViewModel gains planning hierarchy flags"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: `WorkerClient` planning methods
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/WorkerClient.cs`
|
||||||
|
- Create: DTOs matching Plan B return types (either inline in the client file or new file `src/ClaudeDo.Ui/Services/PlanningDtos.cs`).
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add DTOs**
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Ui/Services/PlanningDtos.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Ui.Services;
|
||||||
|
|
||||||
|
public sealed record PlanningSessionFilesDto(
|
||||||
|
string SessionDirectory,
|
||||||
|
string McpConfigPath,
|
||||||
|
string SystemPromptPath,
|
||||||
|
string InitialPromptPath);
|
||||||
|
|
||||||
|
public sealed record PlanningSessionStartInfo(
|
||||||
|
string ParentTaskId,
|
||||||
|
string WorkingDir,
|
||||||
|
PlanningSessionFilesDto Files);
|
||||||
|
|
||||||
|
public sealed record PlanningSessionResumeInfo(
|
||||||
|
string ParentTaskId,
|
||||||
|
string WorkingDir,
|
||||||
|
string ClaudeSessionId,
|
||||||
|
string McpConfigPath);
|
||||||
|
```
|
||||||
|
|
||||||
|
These field names must match Plan B's `PlanningSessionStartContext` / `PlanningSessionResumeContext` exactly (case-sensitive JSON deserialization through SignalR).
|
||||||
|
|
||||||
|
- [ ] **Step 2: Add `WorkerClient` methods**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Services/WorkerClient.cs`, add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public Task<PlanningSessionStartInfo> StartPlanningSessionAsync(string taskId, CancellationToken ct = default)
|
||||||
|
=> _connection.InvokeAsync<PlanningSessionStartInfo>("StartPlanningSessionAsync", taskId, ct);
|
||||||
|
|
||||||
|
public Task<PlanningSessionResumeInfo> ResumePlanningSessionAsync(string taskId, CancellationToken ct = default)
|
||||||
|
=> _connection.InvokeAsync<PlanningSessionResumeInfo>("ResumePlanningSessionAsync", taskId, ct);
|
||||||
|
|
||||||
|
public Task DiscardPlanningSessionAsync(string taskId, CancellationToken ct = default)
|
||||||
|
=> _connection.InvokeAsync("DiscardPlanningSessionAsync", taskId, ct);
|
||||||
|
|
||||||
|
public Task<int> FinalizePlanningSessionAsync(string taskId, bool queueAgentTasks = true, CancellationToken ct = default)
|
||||||
|
=> _connection.InvokeAsync<int>("FinalizePlanningSessionAsync", taskId, queueAgentTasks, ct);
|
||||||
|
|
||||||
|
public Task<int> GetPendingDraftCountAsync(string taskId, CancellationToken ct = default)
|
||||||
|
=> _connection.InvokeAsync<int>("GetPendingDraftCountAsync", taskId, ct);
|
||||||
|
```
|
||||||
|
|
||||||
|
Replace `_connection` with whatever name the existing `WorkerClient` uses for its `HubConnection` field.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Expected: builds.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Services/PlanningDtos.cs src/ClaudeDo.Ui/Services/WorkerClient.cs
|
||||||
|
git commit -m "feat(ui): WorkerClient planning-session methods"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: `TasksIslandViewModel` — planning commands + expanded state
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs`
|
||||||
|
- Create: `tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add commands to the VM**
|
||||||
|
|
||||||
|
In `TasksIslandViewModel.cs`, add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private readonly Dictionary<string, bool> _expandedState = new();
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private async Task OpenPlanningSessionAsync(TaskRowViewModel? row)
|
||||||
|
{
|
||||||
|
if (row is null || !string.Equals(row.Status, "manual", StringComparison.OrdinalIgnoreCase))
|
||||||
|
return;
|
||||||
|
try
|
||||||
|
{
|
||||||
|
await _workerClient.StartPlanningSessionAsync(row.Id);
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
await _dialogs.ShowErrorAsync("Could not start planning session", ex.Message);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private async Task ResumePlanningSessionAsync(TaskRowViewModel? row)
|
||||||
|
{
|
||||||
|
if (row is null || !row.IsPlanningParent) return;
|
||||||
|
try
|
||||||
|
{
|
||||||
|
await _workerClient.ResumePlanningSessionAsync(row.Id);
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
await _dialogs.ShowErrorAsync("Could not resume planning session", ex.Message);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private async Task DiscardPlanningSessionAsync(TaskRowViewModel? row)
|
||||||
|
{
|
||||||
|
if (row is null) return;
|
||||||
|
var confirm = await _dialogs.ConfirmAsync(
|
||||||
|
"Discard planning session?",
|
||||||
|
"This will delete all draft tasks and reset the parent to Manual.");
|
||||||
|
if (!confirm) return;
|
||||||
|
await _workerClient.DiscardPlanningSessionAsync(row.Id);
|
||||||
|
}
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private async Task FinalizePlanningSessionAsync(TaskRowViewModel? row)
|
||||||
|
{
|
||||||
|
if (row is null) return;
|
||||||
|
await _workerClient.FinalizePlanningSessionAsync(row.Id, queueAgentTasks: true);
|
||||||
|
}
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private void ToggleExpand(TaskRowViewModel? row)
|
||||||
|
{
|
||||||
|
if (row is null) return;
|
||||||
|
var next = !(_expandedState.TryGetValue(row.Id, out var current) ? current : true);
|
||||||
|
_expandedState[row.Id] = next;
|
||||||
|
row.IsExpanded = next;
|
||||||
|
RebuildFlatStreams();
|
||||||
|
}
|
||||||
|
|
||||||
|
private void RebuildFlatStreams()
|
||||||
|
{
|
||||||
|
// Existing code builds OpenItems/CompletedItems from the task list.
|
||||||
|
// Modify it so that: after emitting a parent, if IsPlanningParent && IsExpanded,
|
||||||
|
// its Draft / Manual / Queued / Running / Done children are emitted next.
|
||||||
|
// Children already know they are children (ParentTaskId != null) and are styled as such.
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
The existing `RebuildFlatStreams` (or equivalent) probably just groups tasks by status. You need to intersperse the hierarchy:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
// Pseudocode — fit to the existing code shape.
|
||||||
|
var topLevel = allRows.Where(r => !r.IsChild).OrderBy(r => r.SortOrder);
|
||||||
|
var flat = new List<TaskRowViewModel>();
|
||||||
|
foreach (var parent in topLevel)
|
||||||
|
{
|
||||||
|
flat.Add(parent);
|
||||||
|
if (parent.IsPlanningParent && parent.IsExpanded)
|
||||||
|
{
|
||||||
|
var children = allRows
|
||||||
|
.Where(r => r.ParentTaskId == parent.Id)
|
||||||
|
.OrderBy(r => r.SortOrder)
|
||||||
|
.ToList();
|
||||||
|
flat.AddRange(children);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// Then bucket `flat` into OpenItems/CompletedItems like today, preserving order.
|
||||||
|
```
|
||||||
|
|
||||||
|
Pass dependencies: the VM already has a `WorkerClient` or equivalent — reuse it. Add a dialog service if not already injected:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public interface IDialogService
|
||||||
|
{
|
||||||
|
Task<bool> ConfirmAsync(string title, string message);
|
||||||
|
Task ShowErrorAsync(string title, string message);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
If an analog already exists (check existing editor dialogs), use it.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Write failing VM tests**
|
||||||
|
|
||||||
|
`tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Ui.ViewModels.Islands;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.UiVm;
|
||||||
|
|
||||||
|
public sealed class TasksIslandViewModelPlanningTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void ToggleExpand_CollapsesChildrenOfPlanningParent()
|
||||||
|
{
|
||||||
|
// Arrange: create VM with one Planning parent and two Draft children.
|
||||||
|
// Act: call ToggleExpandCommand with the parent.
|
||||||
|
// Assert: flat stream no longer contains the children.
|
||||||
|
// Adapt to how the existing TasksIslandViewModel is instantiated.
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void OpenPlanningSessionCommand_ManualTaskOnly_CanExecuteTrue()
|
||||||
|
{
|
||||||
|
// Arrange VM with a Manual row.
|
||||||
|
// Assert CanExecute for OpenPlanningSession command is true for Manual rows,
|
||||||
|
// false for Queued/Running/Done/Failed rows.
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
These are skeleton tests — implement with the same construction pattern used by the existing `TasksIslandViewModelTests` if one exists, or build a minimal VM fake with a stub `WorkerClient`.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build + test**
|
||||||
|
|
||||||
|
Run:
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests --filter "FullyQualifiedName~TasksIslandViewModelPlanningTests"
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs
|
||||||
|
git commit -m "feat(ui): planning commands and expand/collapse in TasksIslandViewModel"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: `TaskRowView` — indent, chevron, badges, draft styling
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Wrap the row content with a Grid that has an indent column**
|
||||||
|
|
||||||
|
Open `TaskRowView.axaml`. The existing root is likely a `Grid` or `Border`. Replace/refactor the top-level layout to:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Grid ColumnDefinitions="Auto,*">
|
||||||
|
<Border Grid.Column="0"
|
||||||
|
Width="24"
|
||||||
|
IsVisible="{Binding IsChild}">
|
||||||
|
<Rectangle Width="1" Fill="{DynamicResource TextFaintBrush}" HorizontalAlignment="Right" Margin="0,4"/>
|
||||||
|
</Border>
|
||||||
|
|
||||||
|
<Grid Grid.Column="1" ColumnDefinitions="Auto,*,Auto">
|
||||||
|
<!-- Chevron for planning parents -->
|
||||||
|
<Button Grid.Column="0"
|
||||||
|
Classes="icon-btn chevron"
|
||||||
|
Width="18" Height="18"
|
||||||
|
IsVisible="{Binding IsPlanningParent}"
|
||||||
|
Command="{Binding $parent[ItemsControl].((vm:TasksIslandViewModel)DataContext).ToggleExpandCommand}"
|
||||||
|
CommandParameter="{Binding}">
|
||||||
|
<PathIcon Width="10" Height="10">
|
||||||
|
<PathIcon.Data>
|
||||||
|
<MultiBinding Converter="{StaticResource ChevronDataConverter}">
|
||||||
|
<Binding Path="IsExpanded"/>
|
||||||
|
</MultiBinding>
|
||||||
|
</PathIcon.Data>
|
||||||
|
</PathIcon>
|
||||||
|
</Button>
|
||||||
|
|
||||||
|
<!-- existing title/description area -->
|
||||||
|
<StackPanel Grid.Column="1" ...>
|
||||||
|
<!-- existing title binding with added italic when IsDraft -->
|
||||||
|
<TextBlock Text="{Binding Title}"
|
||||||
|
FontStyle="{Binding IsDraft, Converter={StaticResource BoolToItalicConverter}}"
|
||||||
|
Opacity="{Binding IsDraft, Converter={StaticResource BoolToDraftOpacityConverter}}" />
|
||||||
|
</StackPanel>
|
||||||
|
|
||||||
|
<!-- Badges -->
|
||||||
|
<StackPanel Grid.Column="2" Orientation="Horizontal" Spacing="4">
|
||||||
|
<Border Classes="badge draft" IsVisible="{Binding IsDraft}">
|
||||||
|
<TextBlock Text="DRAFT"/>
|
||||||
|
</Border>
|
||||||
|
<Border Classes="badge planning" IsVisible="{Binding IsPlanningParent}">
|
||||||
|
<TextBlock Text="{Binding PlanningBadge}"/>
|
||||||
|
</Border>
|
||||||
|
</StackPanel>
|
||||||
|
</Grid>
|
||||||
|
</Grid>
|
||||||
|
```
|
||||||
|
|
||||||
|
This is a structural edit — preserve all existing bindings for status color, completion toggle, star, scheduled-for, etc. The new indentation column and badges are additive.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Add the converters**
|
||||||
|
|
||||||
|
If `ChevronDataConverter`, `BoolToItalicConverter`, `BoolToDraftOpacityConverter` do not exist, add them to `src/ClaudeDo.Ui/Converters/` (or inline as compiled converters). Example inline:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<!-- in UserControl.Resources of TaskRowView.axaml, or in App.axaml for global -->
|
||||||
|
<Style Selector="Border.badge">
|
||||||
|
<Setter Property="CornerRadius" Value="3"/>
|
||||||
|
<Setter Property="Padding" Value="4,1"/>
|
||||||
|
<Setter Property="Background" Value="{DynamicResource BadgeBgBrush}"/>
|
||||||
|
</Style>
|
||||||
|
<Style Selector="Border.badge.draft">
|
||||||
|
<Setter Property="Background" Value="{DynamicResource DraftBadgeBrush}"/>
|
||||||
|
</Style>
|
||||||
|
<Style Selector="Border.badge.planning">
|
||||||
|
<Setter Property="Background" Value="{DynamicResource PlanningBadgeBrush}"/>
|
||||||
|
</Style>
|
||||||
|
```
|
||||||
|
|
||||||
|
If converters must be code-based, a minimal `BoolToItalicConverter`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using Avalonia.Data.Converters;
|
||||||
|
using Avalonia.Media;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Converters;
|
||||||
|
|
||||||
|
public sealed class BoolToItalicConverter : IValueConverter
|
||||||
|
{
|
||||||
|
public object Convert(object? value, Type targetType, object? parameter, System.Globalization.CultureInfo culture)
|
||||||
|
=> value is true ? FontStyle.Italic : FontStyle.Normal;
|
||||||
|
|
||||||
|
public object ConvertBack(object? value, Type targetType, object? parameter, System.Globalization.CultureInfo culture)
|
||||||
|
=> throw new NotSupportedException();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Register in `App.axaml` resources.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Expected: builds cleanly (XAML compiles).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml src/ClaudeDo.Ui/Converters/
|
||||||
|
git commit -m "feat(ui): TaskRowView hierarchy indentation, chevron, badges, draft italic"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: `TaskRowView` — planning context-menu entries
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Locate the existing context menu**
|
||||||
|
|
||||||
|
Open `TaskRowView.axaml`. The ContextMenu lives somewhere on the root element or as a `ContextMenu.Items`/`ContextFlyout`. Find the block that defines entries like "Edit", "Run now", etc.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Insert planning entries conditionally**
|
||||||
|
|
||||||
|
Add within the existing menu (order: after "Run now" and a separator):
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<MenuItem Header="Open planning Session"
|
||||||
|
Command="{Binding $parent[ItemsControl].((vm:TasksIslandViewModel)DataContext).OpenPlanningSessionCommand}"
|
||||||
|
CommandParameter="{Binding}"
|
||||||
|
IsVisible="{Binding Status, Converter={StaticResource IsManualAndNotChildConverter}, ConverterParameter={Binding IsChild}}"/>
|
||||||
|
|
||||||
|
<MenuItem Header="Resume planning Session"
|
||||||
|
Command="{Binding $parent[ItemsControl].((vm:TasksIslandViewModel)DataContext).ResumePlanningSessionCommand}"
|
||||||
|
CommandParameter="{Binding}"
|
||||||
|
IsVisible="{Binding Status, Converter={StaticResource IsPlanningConverter}}"/>
|
||||||
|
|
||||||
|
<MenuItem Header="Discard planning session"
|
||||||
|
Command="{Binding $parent[ItemsControl].((vm:TasksIslandViewModel)DataContext).DiscardPlanningSessionCommand}"
|
||||||
|
CommandParameter="{Binding}"
|
||||||
|
IsVisible="{Binding Status, Converter={StaticResource IsPlanningConverter}}"/>
|
||||||
|
```
|
||||||
|
|
||||||
|
Simpler alternative without multi-condition converters: expose direct bool VM properties that combine the logic — `CanOpenPlanningSession`, `CanResumePlanningSession`, `CanDiscardPlanningSession`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
// In TaskRowViewModel
|
||||||
|
public bool CanOpenPlanningSession =>
|
||||||
|
string.Equals(Status, "manual", StringComparison.OrdinalIgnoreCase) && !IsChild;
|
||||||
|
|
||||||
|
public bool CanResumeOrDiscardPlanning =>
|
||||||
|
string.Equals(Status, "planning", StringComparison.OrdinalIgnoreCase);
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `OnPropertyChanged(nameof(CanOpenPlanningSession))` and friends in the status/parent-id partial methods from Task 1. Then the XAML simplifies to:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<MenuItem Header="Open planning Session"
|
||||||
|
Command="{Binding ...OpenPlanningSessionCommand}"
|
||||||
|
CommandParameter="{Binding}"
|
||||||
|
IsVisible="{Binding CanOpenPlanningSession}"/>
|
||||||
|
```
|
||||||
|
|
||||||
|
Use this simpler path — cleaner.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Expected: builds.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs
|
||||||
|
git commit -m "feat(ui): planning entries in task context menu"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 6: Island styles — draft, badges
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Design/IslandStyles.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add brushes + styles**
|
||||||
|
|
||||||
|
Append within `<Styles.Resources>` or wherever brushes are defined:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<SolidColorBrush x:Key="DraftBadgeBrush" Color="#4A5568"/>
|
||||||
|
<SolidColorBrush x:Key="PlanningBadgeBrush" Color="#D69E2E"/>
|
||||||
|
<SolidColorBrush x:Key="PlannedBadgeBrush" Color="#3182CE"/>
|
||||||
|
```
|
||||||
|
|
||||||
|
Add styles:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Style Selector="Border.badge">
|
||||||
|
<Setter Property="CornerRadius" Value="3"/>
|
||||||
|
<Setter Property="Padding" Value="4,1"/>
|
||||||
|
<Setter Property="VerticalAlignment" Value="Center"/>
|
||||||
|
</Style>
|
||||||
|
|
||||||
|
<Style Selector="Border.badge > TextBlock">
|
||||||
|
<Setter Property="FontSize" Value="9"/>
|
||||||
|
<Setter Property="FontWeight" Value="Bold"/>
|
||||||
|
<Setter Property="Foreground" Value="White"/>
|
||||||
|
</Style>
|
||||||
|
|
||||||
|
<Style Selector="Border.badge.draft">
|
||||||
|
<Setter Property="Background" Value="{DynamicResource DraftBadgeBrush}"/>
|
||||||
|
</Style>
|
||||||
|
|
||||||
|
<Style Selector="Border.badge.planning">
|
||||||
|
<Setter Property="Background" Value="{DynamicResource PlanningBadgeBrush}"/>
|
||||||
|
</Style>
|
||||||
|
|
||||||
|
<Style Selector="Border.badge.planned">
|
||||||
|
<Setter Property="Background" Value="{DynamicResource PlannedBadgeBrush}"/>
|
||||||
|
</Style>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build and manually verify**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Launch app, create a task, right-click, use Open planning Session (if Plan B merged) or simulate via DB. Verify badge + italic draft rendering visually.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Design/IslandStyles.axaml
|
||||||
|
git commit -m "feat(ui): draft and planning badge styles"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 7: Unfinished-planning-session dialog
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Ui/Views/Dialogs/UnfinishedPlanningDialog.axaml` + `.axaml.cs`
|
||||||
|
- Create: `src/ClaudeDo.Ui/ViewModels/Dialogs/UnfinishedPlanningDialogViewModel.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Create the VM**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Ui/ViewModels/Dialogs/UnfinishedPlanningDialogViewModel.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using CommunityToolkit.Mvvm.ComponentModel;
|
||||||
|
using CommunityToolkit.Mvvm.Input;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.ViewModels.Dialogs;
|
||||||
|
|
||||||
|
public enum UnfinishedPlanningDialogResult
|
||||||
|
{
|
||||||
|
Cancel,
|
||||||
|
Resume,
|
||||||
|
FinalizeNow,
|
||||||
|
Discard,
|
||||||
|
}
|
||||||
|
|
||||||
|
public sealed partial class UnfinishedPlanningDialogViewModel : ObservableObject
|
||||||
|
{
|
||||||
|
[ObservableProperty] private string title = "Unfinished planning session";
|
||||||
|
[ObservableProperty] private string taskTitle = "";
|
||||||
|
[ObservableProperty] private int draftCount;
|
||||||
|
|
||||||
|
public TaskCompletionSource<UnfinishedPlanningDialogResult> Result { get; } = new();
|
||||||
|
|
||||||
|
[RelayCommand] private void Resume() => Result.TrySetResult(UnfinishedPlanningDialogResult.Resume);
|
||||||
|
[RelayCommand] private void FinalizeNow() => Result.TrySetResult(UnfinishedPlanningDialogResult.FinalizeNow);
|
||||||
|
[RelayCommand] private void Discard() => Result.TrySetResult(UnfinishedPlanningDialogResult.Discard);
|
||||||
|
[RelayCommand] private void Cancel() => Result.TrySetResult(UnfinishedPlanningDialogResult.Cancel);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Create the view**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Ui/Views/Dialogs/UnfinishedPlanningDialog.axaml`:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Window xmlns="https://github.com/avaloniaui"
|
||||||
|
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
|
||||||
|
xmlns:vm="using:ClaudeDo.Ui.ViewModels.Dialogs"
|
||||||
|
x:Class="ClaudeDo.Ui.Views.Dialogs.UnfinishedPlanningDialog"
|
||||||
|
x:DataType="vm:UnfinishedPlanningDialogViewModel"
|
||||||
|
Width="440" Height="220"
|
||||||
|
WindowStartupLocation="CenterOwner"
|
||||||
|
CanResize="False"
|
||||||
|
Title="{Binding Title}">
|
||||||
|
<StackPanel Margin="20" Spacing="12">
|
||||||
|
<TextBlock Text="{Binding Title}" FontWeight="Bold" FontSize="15"/>
|
||||||
|
<TextBlock Text="{Binding TaskTitle}" Opacity="0.85"/>
|
||||||
|
<TextBlock>
|
||||||
|
<Run Text="{Binding DraftCount}"/>
|
||||||
|
<Run Text=" draft tasks waiting to be finalized."/>
|
||||||
|
</TextBlock>
|
||||||
|
|
||||||
|
<StackPanel Orientation="Horizontal" Spacing="8" HorizontalAlignment="Right">
|
||||||
|
<Button Content="Discard" Command="{Binding DiscardCommand}"/>
|
||||||
|
<Button Content="Finalize now" Command="{Binding FinalizeNowCommand}"/>
|
||||||
|
<Button Content="Resume" Classes="accent" Command="{Binding ResumeCommand}"/>
|
||||||
|
</StackPanel>
|
||||||
|
</StackPanel>
|
||||||
|
</Window>
|
||||||
|
```
|
||||||
|
|
||||||
|
`UnfinishedPlanningDialog.axaml.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using Avalonia.Controls;
|
||||||
|
using Avalonia.Markup.Xaml;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Views.Dialogs;
|
||||||
|
|
||||||
|
public partial class UnfinishedPlanningDialog : Window
|
||||||
|
{
|
||||||
|
public UnfinishedPlanningDialog()
|
||||||
|
{
|
||||||
|
InitializeComponent();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Wire into `TasksIslandViewModel`**
|
||||||
|
|
||||||
|
When the user right-clicks a `Planning` row OR when the app starts and a `Planning` row is present, show the dialog. Add a helper in the VM:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private async Task<UnfinishedPlanningDialogResult> AskUnfinishedPlanningAsync(TaskRowViewModel row)
|
||||||
|
{
|
||||||
|
var dialogVm = new UnfinishedPlanningDialogViewModel
|
||||||
|
{
|
||||||
|
TaskTitle = row.Title,
|
||||||
|
DraftCount = await _workerClient.GetPendingDraftCountAsync(row.Id),
|
||||||
|
};
|
||||||
|
var dlg = new UnfinishedPlanningDialog { DataContext = dialogVm };
|
||||||
|
_ = dlg.ShowDialog(_ownerWindow);
|
||||||
|
return await dialogVm.Result.Task;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Replace the direct resume/discard/finalize commands (from Task 3) with calls that first pop this dialog and dispatch based on result. For example:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[RelayCommand]
|
||||||
|
private async Task ResumePlanningSessionAsync(TaskRowViewModel? row)
|
||||||
|
{
|
||||||
|
if (row is null || !row.IsPlanningParent) return;
|
||||||
|
var choice = await AskUnfinishedPlanningAsync(row);
|
||||||
|
switch (choice)
|
||||||
|
{
|
||||||
|
case UnfinishedPlanningDialogResult.Resume:
|
||||||
|
await _workerClient.ResumePlanningSessionAsync(row.Id);
|
||||||
|
break;
|
||||||
|
case UnfinishedPlanningDialogResult.FinalizeNow:
|
||||||
|
await _workerClient.FinalizePlanningSessionAsync(row.Id);
|
||||||
|
break;
|
||||||
|
case UnfinishedPlanningDialogResult.Discard:
|
||||||
|
await _workerClient.DiscardPlanningSessionAsync(row.Id);
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build + manual run**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Expected: builds.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Views/Dialogs/UnfinishedPlanningDialog.axaml src/ClaudeDo.Ui/Views/Dialogs/UnfinishedPlanningDialog.axaml.cs src/ClaudeDo.Ui/ViewModels/Dialogs/UnfinishedPlanningDialogViewModel.cs src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs
|
||||||
|
git commit -m "feat(ui): unfinished planning session dialog"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 8: TasksIslandView — wire new templates
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/TasksIslandView.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: No structural change required**
|
||||||
|
|
||||||
|
The hierarchy is already handled by `TasksIslandViewModel.RebuildFlatStreams` interleaving children into `OpenItems`/`CompletedItems`. The existing `ItemsControl` bindings in `TasksIslandView` automatically pick up the new rows. Indentation/chevron/badge rendering is entirely inside `TaskRowView` (Task 4).
|
||||||
|
|
||||||
|
Verify the view does not have any logic that filters out children based on `ParentTaskId IS NOT NULL` today. If it does, remove that filter — the VM is now authoritative about what's in the stream.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build + manual check**
|
||||||
|
|
||||||
|
Launch the UI, create a manual task, and manually update its status to `Planning` in the DB (or wait for Plan B). Create one child in DB. Verify indentation and chevron render.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit (if any change was made)**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Views/Islands/TasksIslandView.axaml
|
||||||
|
git commit -m "chore(ui): verify tasks view renders hierarchy via flat stream"
|
||||||
|
```
|
||||||
|
|
||||||
|
If no change — skip the commit.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 9: Delete-with-children handling
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs` (existing delete command)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Catch `DbUpdateException` from delete**
|
||||||
|
|
||||||
|
Find the existing delete command. Wrap the repository/hub call:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[RelayCommand]
|
||||||
|
private async Task RemoveAsync(TaskRowViewModel? row)
|
||||||
|
{
|
||||||
|
if (row is null) return;
|
||||||
|
try
|
||||||
|
{
|
||||||
|
await _workerClient.DeleteTaskAsync(row.Id);
|
||||||
|
}
|
||||||
|
catch (HubException ex) when (ex.Message.Contains("foreign key", StringComparison.OrdinalIgnoreCase)
|
||||||
|
|| ex.Message.Contains("FOREIGN KEY", StringComparison.OrdinalIgnoreCase)
|
||||||
|
|| ex.Message.Contains("Restrict", StringComparison.OrdinalIgnoreCase))
|
||||||
|
{
|
||||||
|
var childrenCount = 1; // or query via a new hub method if exact count matters
|
||||||
|
var choice = await _dialogs.ConfirmAsync(
|
||||||
|
"Cannot delete",
|
||||||
|
$"This task has child tasks. Delete all including children?");
|
||||||
|
if (!choice) return;
|
||||||
|
// Recursive delete — iterate children first. For v1 MVP, instruct user to
|
||||||
|
// discard the planning session first. Simpler, safer.
|
||||||
|
await _dialogs.ShowErrorAsync(
|
||||||
|
"Cannot delete",
|
||||||
|
"Discard the planning session or delete child tasks manually first.");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
**Simplification for v1:** do not implement "Delete all including children" yet. Show an error instructing the user to discard the planning session or delete children first. This avoids an additional hub endpoint and keeps Plan C bounded.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Expected: builds.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs
|
||||||
|
git commit -m "feat(ui): friendly error when deleting task with children"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 10: Manual smoke test + final verification
|
||||||
|
|
||||||
|
**Files:** none
|
||||||
|
|
||||||
|
- [ ] **Step 1: Full test run**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests`
|
||||||
|
Expected: all tests pass.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build the full app**
|
||||||
|
|
||||||
|
Run:
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj
|
||||||
|
```
|
||||||
|
Expected: all succeed.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Manual smoke test (requires Plan B merged)**
|
||||||
|
|
||||||
|
1. Launch the app.
|
||||||
|
2. Create a Manual task with a title and some TODO-style description.
|
||||||
|
3. Right-click → "Open planning Session".
|
||||||
|
4. Verify Windows Terminal opens with Claude CLI running.
|
||||||
|
5. In the terminal, ask Claude to create two child tasks (`mcp__claudedo__create_child_task`).
|
||||||
|
6. Watch the UI: drafts appear under the parent (italic, grey, badge DRAFT).
|
||||||
|
7. Ask Claude to `finalize`.
|
||||||
|
8. Verify drafts become Manual/Queued children, parent flips to PLANNED badge.
|
||||||
|
9. Close terminal without finalize on a new planning task; right-click the Planning task: dialog appears with Resume/Finalize/Discard.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Document any UI tweaks needed in `docs/open.md`**
|
||||||
|
|
||||||
|
Add a checklist item under UI verification for planning session visuals.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Final commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add docs/open.md
|
||||||
|
git commit -m "docs(open): add planning-session manual verification checklist"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Out of scope for Plan C
|
||||||
|
|
||||||
|
- Recursive delete of parent-with-children via UI (error-only in v1).
|
||||||
|
- Collapse-state persistence across app restarts (in-memory only).
|
||||||
|
- Keyboard shortcut for "Open planning Session".
|
||||||
|
- Visual differentiation for PLANNED parents beyond a badge (e.g., subtle background tint) — can be added later if visually needed.
|
||||||
1831
docs/superpowers/plans/2026-04-23-self-update.md
Normal file
1831
docs/superpowers/plans/2026-04-23-self-update.md
Normal file
File diff suppressed because it is too large
Load Diff
718
docs/superpowers/plans/2026-04-23-worker-log-footer.md
Normal file
718
docs/superpowers/plans/2026-04-23-worker-log-footer.md
Normal file
@@ -0,0 +1,718 @@
|
|||||||
|
# Worker Log Footer Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Surface important Worker lifecycle events in the UI footer as a single rotating, color-coded line that auto-hides after 30s of silence.
|
||||||
|
|
||||||
|
**Architecture:** Add `WorkerLogLevel` enum in shared `ClaudeDo.Data` project. `HubBroadcaster` gets a `WorkerLog(message, level, timestampUtc)` SignalR event. Seven emit sites in `TaskRunner`, `TaskMergeService`, `TaskResetService` (callers of `WorktreeManager`, not WorktreeManager itself — they have the task title in scope). UI side: `WorkerClient` surfaces a `WorkerLogReceived` event; footer state lives on `IslandsShellViewModel` (existing root VM for `MainWindow`, also owns connection state); `System.Timers.Timer` clears the line after 30s; a `WorkerLogLevelToBrushConverter` maps level → brush in XAML.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, ASP.NET Core SignalR, Avalonia 12, CommunityToolkit.Mvvm, xUnit.
|
||||||
|
|
||||||
|
**Spec:** `docs/superpowers/specs/2026-04-23-worker-log-footer-design.md`
|
||||||
|
|
||||||
|
**Deviation from spec:** Spec names `WorktreeManager.CreateAsync` / `DiscardAsync` as emit sites. In practice, `WorktreeManager` has only the task ID in scope; its callers (`TaskRunner`, `TaskResetService`) have the title. Emitting from callers avoids adding constructor dependencies to `WorktreeManager` and produces identical user-visible behavior.
|
||||||
|
|
||||||
|
**Build note:** Per project convention, `dotnet build ClaudeDo.slnx` fails on .NET 8 — always build individual csprojs.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 1: Add `WorkerLogLevel` enum (shared contract)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Data/Models/WorkerLogLevel.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the enum**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Data.Models;
|
||||||
|
|
||||||
|
public enum WorkerLogLevel
|
||||||
|
{
|
||||||
|
Info,
|
||||||
|
Success,
|
||||||
|
Warn,
|
||||||
|
Error,
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build Data project**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Data/ClaudeDo.Data.csproj`
|
||||||
|
Expected: Build succeeded, 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Data/Models/WorkerLogLevel.cs
|
||||||
|
git commit -m "feat(data): add WorkerLogLevel enum"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 2: Add `WorkerLog` broadcaster method + SignalR JSON enum-as-string
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Hub/HubBroadcaster.cs` (append method)
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Program.cs` (line ~23 — the `AddSignalR()` call)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add enum-as-string serialization**
|
||||||
|
|
||||||
|
Replace:
|
||||||
|
```csharp
|
||||||
|
builder.Services.AddSignalR();
|
||||||
|
```
|
||||||
|
with:
|
||||||
|
```csharp
|
||||||
|
builder.Services.AddSignalR().AddJsonProtocol(options =>
|
||||||
|
{
|
||||||
|
options.PayloadSerializerOptions.Converters.Add(new System.Text.Json.Serialization.JsonStringEnumConverter());
|
||||||
|
});
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Add `WorkerLog` method to `HubBroadcaster`**
|
||||||
|
|
||||||
|
Add the following method inside `HubBroadcaster` class (after the existing `RunCreated` method):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public Task WorkerLog(string message, WorkerLogLevel level, DateTime timestampUtc) =>
|
||||||
|
_hub.Clients.All.SendAsync("WorkerLog", message, level, timestampUtc);
|
||||||
|
```
|
||||||
|
|
||||||
|
Add to the using block at top of file (if not already present):
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: Build succeeded, 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Hub/HubBroadcaster.cs src/ClaudeDo.Worker/Program.cs
|
||||||
|
git commit -m "feat(worker): add WorkerLog SignalR event"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 3: Emit `WorkerLog` from `TaskRunner`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Runner/TaskRunner.cs`
|
||||||
|
|
||||||
|
Four emit sites in this file:
|
||||||
|
1. **Created worktree** — right after `_wtManager.CreateAsync` succeeds (around line 69).
|
||||||
|
2. **Started Claude** — just before invoking Claude process.
|
||||||
|
3. **Committed changes** — after auto-commit (before the `WorktreeUpdated` broadcast around line 318).
|
||||||
|
4. **Finished** — at both success (line 330) and failure paths, mirroring the existing `TaskFinished` call.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add using for `WorkerLogLevel`**
|
||||||
|
|
||||||
|
Ensure `TaskRunner.cs` has at the top:
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Emit "Created worktree"**
|
||||||
|
|
||||||
|
After the line `wtCtx = await _wtManager.CreateAsync(task, list, ct);` (around line 69), add:
|
||||||
|
```csharp
|
||||||
|
await _broadcaster.WorkerLog($"Created worktree for \"{task.Title}\"", WorkerLogLevel.Info, DateTime.UtcNow);
|
||||||
|
```
|
||||||
|
(Place inside the same `if` branch that called `CreateAsync`, after the assignment.)
|
||||||
|
|
||||||
|
- [ ] **Step 3: Emit "Started Claude"**
|
||||||
|
|
||||||
|
Locate the point just before `ClaudeProcess` is invoked (search for where `ClaudeProcess` or `RunProcessAsync` is called). Just before the invocation, add:
|
||||||
|
```csharp
|
||||||
|
await _broadcaster.WorkerLog($"Started Claude for \"{task.Title}\"", WorkerLogLevel.Info, DateTime.UtcNow);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Emit "Committed changes"**
|
||||||
|
|
||||||
|
Locate the auto-commit code path (around line 318, just before `await _broadcaster.WorktreeUpdated(task.Id);`). Add immediately before that call:
|
||||||
|
```csharp
|
||||||
|
await _broadcaster.WorkerLog($"Committed changes in \"{task.Title}\"", WorkerLogLevel.Info, DateTime.UtcNow);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Emit "Finished (done)"**
|
||||||
|
|
||||||
|
Find the success finish path (around line 330, where `TaskFinished` is broadcast with status `"done"`). Add immediately before that call:
|
||||||
|
```csharp
|
||||||
|
await _broadcaster.WorkerLog($"Finished \"{task.Title}\" (done)", WorkerLogLevel.Success, DateTime.UtcNow);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 6: Emit "Finished (failed)"**
|
||||||
|
|
||||||
|
Find the failure path (search for `TaskFinished` with status `"failed"`). Add immediately before:
|
||||||
|
```csharp
|
||||||
|
await _broadcaster.WorkerLog($"Finished \"{task.Title}\" (failed)", WorkerLogLevel.Error, DateTime.UtcNow);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 7: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: Build succeeded, 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 8: Run existing Worker tests (no regressions)**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj`
|
||||||
|
Expected: All tests pass.
|
||||||
|
|
||||||
|
- [ ] **Step 9: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Runner/TaskRunner.cs
|
||||||
|
git commit -m "feat(worker): emit WorkerLog events from TaskRunner"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 4: Emit `WorkerLog` from `TaskMergeService` and `TaskResetService`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Services/TaskMergeService.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Services/TaskResetService.cs`
|
||||||
|
|
||||||
|
Both services already have `HubBroadcaster` injected (`_broadcaster`). Both already load the task entity (needed for title).
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add using in both files**
|
||||||
|
|
||||||
|
Add to the top of each file (if not already present):
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Emit "Merged" in `TaskMergeService.MergeAsync`**
|
||||||
|
|
||||||
|
Locate the existing log line around line 137:
|
||||||
|
```csharp
|
||||||
|
_logger.LogInformation(
|
||||||
|
"Merged task {TaskId} branch {Branch} into {Target} (remove worktree: {Remove})",
|
||||||
|
...);
|
||||||
|
```
|
||||||
|
|
||||||
|
Immediately after it (before `return new MergeResult(...)` on line 140), add:
|
||||||
|
```csharp
|
||||||
|
await _broadcaster.WorkerLog($"Merged \"{task.Title}\" into {targetBranch}", WorkerLogLevel.Success, DateTime.UtcNow);
|
||||||
|
```
|
||||||
|
Use whatever variable names `task` and `targetBranch` are in scope — adjust to match the actual local names at that site.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Emit "Discarded" in `TaskResetService.ResetAsync`**
|
||||||
|
|
||||||
|
Locate the call `await _wtManager.DiscardAsync(wt, list.WorkingDir, ct);` (line 53). Immediately after it, add:
|
||||||
|
```csharp
|
||||||
|
await _broadcaster.WorkerLog($"Discarded worktree for \"{task.Title}\"", WorkerLogLevel.Warn, DateTime.UtcNow);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Emit "Reset" in `TaskResetService.ResetAsync`**
|
||||||
|
|
||||||
|
Locate the existing line `_logger.LogInformation("Reset task {TaskId} to Manual ...` (line 66). Immediately after it, add:
|
||||||
|
```csharp
|
||||||
|
await _broadcaster.WorkerLog($"Reset \"{task.Title}\"", WorkerLogLevel.Warn, DateTime.UtcNow);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: Build succeeded, 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Run existing Worker tests**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj`
|
||||||
|
Expected: All tests pass.
|
||||||
|
|
||||||
|
- [ ] **Step 7: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Services/TaskMergeService.cs src/ClaudeDo.Worker/Services/TaskResetService.cs
|
||||||
|
git commit -m "feat(worker): emit WorkerLog for merge, discard, reset"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 5: Add `WorkerLogEntry` record + `WorkerLogReceived` event on `WorkerClient`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/WorkerClient.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add using for `WorkerLogLevel`**
|
||||||
|
|
||||||
|
Add at the top of `WorkerClient.cs`:
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Declare the `WorkerLogEntry` record**
|
||||||
|
|
||||||
|
Add at the top of the file (above or below the `WorkerClient` class, same namespace):
|
||||||
|
```csharp
|
||||||
|
public sealed record WorkerLogEntry(string Message, WorkerLogLevel Level, DateTime TimestampUtc);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Add the event field**
|
||||||
|
|
||||||
|
Alongside the other `public event Action<...>?` declarations (around lines 42-48), add:
|
||||||
|
```csharp
|
||||||
|
public event Action<WorkerLogEntry>? WorkerLogReceivedEvent;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Register the SignalR handler**
|
||||||
|
|
||||||
|
Alongside the other `_hub.On<...>` registrations (around lines 80-117), add:
|
||||||
|
```csharp
|
||||||
|
_hub.On<string, WorkerLogLevel, DateTime>("WorkerLog", (message, level, timestampUtc) =>
|
||||||
|
{
|
||||||
|
WorkerLogReceivedEvent?.Invoke(new WorkerLogEntry(message, level, timestampUtc));
|
||||||
|
});
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Expected: Build succeeded, 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Services/WorkerClient.cs
|
||||||
|
git commit -m "feat(ui): subscribe to WorkerLog SignalR event"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 6: Create `ClaudeDo.Ui.Tests` project and add `WorkerLogLevelToBrushConverter`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Ui/Converters/WorkerLogLevelToBrushConverter.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/App.axaml` (register converter as resource)
|
||||||
|
- Create: `tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj`
|
||||||
|
- Create: `tests/ClaudeDo.Ui.Tests/WorkerLogLevelToBrushConverterTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the converter**
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Ui/Converters/WorkerLogLevelToBrushConverter.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System;
|
||||||
|
using System.Globalization;
|
||||||
|
using Avalonia;
|
||||||
|
using Avalonia.Data.Converters;
|
||||||
|
using Avalonia.Media;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Converters;
|
||||||
|
|
||||||
|
public sealed class WorkerLogLevelToBrushConverter : IValueConverter
|
||||||
|
{
|
||||||
|
private static readonly IBrush SuccessBrush = new SolidColorBrush(Color.Parse("#4CAF50"));
|
||||||
|
private static readonly IBrush WarnBrush = new SolidColorBrush(Color.Parse("#FFA726"));
|
||||||
|
private static readonly IBrush ErrorBrush = new SolidColorBrush(Color.Parse("#EF5350"));
|
||||||
|
private static readonly IBrush InfoFallback = new SolidColorBrush(Color.Parse("#888888"));
|
||||||
|
|
||||||
|
public object? Convert(object? value, Type targetType, object? parameter, CultureInfo culture)
|
||||||
|
{
|
||||||
|
if (value is not WorkerLogLevel level)
|
||||||
|
return AvaloniaProperty.UnsetValue;
|
||||||
|
|
||||||
|
return level switch
|
||||||
|
{
|
||||||
|
WorkerLogLevel.Success => SuccessBrush,
|
||||||
|
WorkerLogLevel.Warn => WarnBrush,
|
||||||
|
WorkerLogLevel.Error => ErrorBrush,
|
||||||
|
WorkerLogLevel.Info => ResolveInfoBrush(),
|
||||||
|
_ => AvaloniaProperty.UnsetValue,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
public object? ConvertBack(object? value, Type targetType, object? parameter, CultureInfo culture) =>
|
||||||
|
throw new NotSupportedException();
|
||||||
|
|
||||||
|
private static IBrush ResolveInfoBrush()
|
||||||
|
{
|
||||||
|
if (Application.Current is { } app &&
|
||||||
|
app.Resources.TryGetResource("TextDimBrush", app.ActualThemeVariant, out var res) &&
|
||||||
|
res is IBrush brush)
|
||||||
|
{
|
||||||
|
return brush;
|
||||||
|
}
|
||||||
|
return InfoFallback;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Register converter in `App.axaml`**
|
||||||
|
|
||||||
|
Open `src/ClaudeDo.Ui/App.axaml`. Inside the `<Application.Resources>` section (add one if missing), add alongside any existing converter entries:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<converters:WorkerLogLevelToBrushConverter x:Key="WorkerLogLevelToBrush"/>
|
||||||
|
```
|
||||||
|
|
||||||
|
Ensure the `xmlns:converters="using:ClaudeDo.Ui.Converters"` namespace is declared at the root `<Application>` element. If other converters (e.g. `StatusColorConverter`) are already resources in `App.axaml` follow the same pattern; if they're declared per-view, declare this converter at the top of `MainWindow.axaml` in Task 8 instead.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Create UI test project**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj`:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Project Sdk="Microsoft.NET.Sdk">
|
||||||
|
<PropertyGroup>
|
||||||
|
<TargetFramework>net8.0</TargetFramework>
|
||||||
|
<Nullable>enable</Nullable>
|
||||||
|
<IsPackable>false</IsPackable>
|
||||||
|
</PropertyGroup>
|
||||||
|
<ItemGroup>
|
||||||
|
<PackageReference Include="Avalonia" Version="12.0.0" />
|
||||||
|
<PackageReference Include="Avalonia.Headless" Version="12.0.0" />
|
||||||
|
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.11.1" />
|
||||||
|
<PackageReference Include="xunit" Version="2.9.2" />
|
||||||
|
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2" />
|
||||||
|
</ItemGroup>
|
||||||
|
<ItemGroup>
|
||||||
|
<ProjectReference Include="..\..\src\ClaudeDo.Ui\ClaudeDo.Ui.csproj" />
|
||||||
|
</ItemGroup>
|
||||||
|
</Project>
|
||||||
|
```
|
||||||
|
|
||||||
|
If the existing `tests/ClaudeDo.Worker.Tests/*.csproj` uses different `Microsoft.NET.Test.Sdk` / xUnit versions, match those versions exactly to avoid analyzer mismatches.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Write the failing test**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Ui.Tests/WorkerLogLevelToBrushConverterTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.Globalization;
|
||||||
|
using Avalonia;
|
||||||
|
using Avalonia.Media;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Ui.Converters;
|
||||||
|
using Xunit;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Tests;
|
||||||
|
|
||||||
|
public class WorkerLogLevelToBrushConverterTests
|
||||||
|
{
|
||||||
|
[Theory]
|
||||||
|
[InlineData(WorkerLogLevel.Success, "#FF4CAF50")]
|
||||||
|
[InlineData(WorkerLogLevel.Warn, "#FFFFA726")]
|
||||||
|
[InlineData(WorkerLogLevel.Error, "#FFEF5350")]
|
||||||
|
public void Convert_maps_level_to_expected_brush_color(WorkerLogLevel level, string expectedArgb)
|
||||||
|
{
|
||||||
|
var converter = new WorkerLogLevelToBrushConverter();
|
||||||
|
|
||||||
|
var result = converter.Convert(level, typeof(IBrush), null, CultureInfo.InvariantCulture);
|
||||||
|
|
||||||
|
var solid = Assert.IsType<SolidColorBrush>(result);
|
||||||
|
Assert.Equal(expectedArgb.ToLowerInvariant(), $"#{solid.Color.ToUInt32():X8}".ToLowerInvariant());
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Convert_info_returns_a_brush_fallback_when_no_app()
|
||||||
|
{
|
||||||
|
var converter = new WorkerLogLevelToBrushConverter();
|
||||||
|
|
||||||
|
var result = converter.Convert(WorkerLogLevel.Info, typeof(IBrush), null, CultureInfo.InvariantCulture);
|
||||||
|
|
||||||
|
Assert.IsAssignableFrom<IBrush>(result);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Convert_unknown_value_returns_unset()
|
||||||
|
{
|
||||||
|
var converter = new WorkerLogLevelToBrushConverter();
|
||||||
|
|
||||||
|
var result = converter.Convert("not a level", typeof(IBrush), null, CultureInfo.InvariantCulture);
|
||||||
|
|
||||||
|
Assert.Equal(AvaloniaProperty.UnsetValue, result);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Run the tests**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj`
|
||||||
|
Expected: All 5 tests pass.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Converters/WorkerLogLevelToBrushConverter.cs src/ClaudeDo.Ui/App.axaml tests/ClaudeDo.Ui.Tests/
|
||||||
|
git commit -m "feat(ui): add WorkerLogLevelToBrushConverter with tests"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 7: Add footer state + 30s auto-clear timer to `IslandsShellViewModel`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`
|
||||||
|
- Create: `tests/ClaudeDo.Ui.Tests/IslandsShellViewModelWorkerLogTests.cs`
|
||||||
|
|
||||||
|
Timer uses `System.Timers.Timer` (not `DispatcherTimer`) so unit tests don't need an Avalonia dispatcher. The elapsed callback marshals to the UI thread via `Dispatcher.UIThread.Post` when the dispatcher is available; in tests the VM logic under test sets properties directly so no marshalling is needed.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Ui.Tests/IslandsShellViewModelWorkerLogTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Ui.Services;
|
||||||
|
using ClaudeDo.Ui.ViewModels;
|
||||||
|
using Xunit;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Tests;
|
||||||
|
|
||||||
|
public class IslandsShellViewModelWorkerLogTests
|
||||||
|
{
|
||||||
|
private static IslandsShellViewModel NewVm() =>
|
||||||
|
// The real constructor requires island VMs + WorkerClient. These tests
|
||||||
|
// only exercise the WorkerLog handling, so we use a test-only constructor
|
||||||
|
// that bypasses the sub-VMs. Add `internal IslandsShellViewModel()` for tests.
|
||||||
|
IslandsShellViewModel.CreateForTests();
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Receiving_event_sets_text_level_and_visible()
|
||||||
|
{
|
||||||
|
var vm = NewVm();
|
||||||
|
var at = new DateTime(2026, 4, 23, 14, 32, 0, DateTimeKind.Utc);
|
||||||
|
|
||||||
|
vm.OnWorkerLogReceived(new WorkerLogEntry("Created worktree for \"X\"", WorkerLogLevel.Info, at));
|
||||||
|
|
||||||
|
Assert.True(vm.IsWorkerLogVisible);
|
||||||
|
Assert.Equal(WorkerLogLevel.Info, vm.WorkerLogLevel);
|
||||||
|
Assert.Contains("Created worktree for \"X\"", vm.WorkerLogText);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Second_event_replaces_first()
|
||||||
|
{
|
||||||
|
var vm = NewVm();
|
||||||
|
vm.OnWorkerLogReceived(new WorkerLogEntry("first", WorkerLogLevel.Info, DateTime.UtcNow));
|
||||||
|
vm.OnWorkerLogReceived(new WorkerLogEntry("second", WorkerLogLevel.Success, DateTime.UtcNow));
|
||||||
|
|
||||||
|
Assert.Contains("second", vm.WorkerLogText);
|
||||||
|
Assert.Equal(WorkerLogLevel.Success, vm.WorkerLogLevel);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void ClearWorkerLog_hides_line()
|
||||||
|
{
|
||||||
|
var vm = NewVm();
|
||||||
|
vm.OnWorkerLogReceived(new WorkerLogEntry("msg", WorkerLogLevel.Info, DateTime.UtcNow));
|
||||||
|
|
||||||
|
vm.ClearWorkerLog();
|
||||||
|
|
||||||
|
Assert.False(vm.IsWorkerLogVisible);
|
||||||
|
Assert.Null(vm.WorkerLogText);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Text_is_formatted_as_HHmm_dot_message_local_time()
|
||||||
|
{
|
||||||
|
var vm = NewVm();
|
||||||
|
var utc = new DateTime(2026, 4, 23, 12, 0, 0, DateTimeKind.Utc);
|
||||||
|
var expectedLocalHhmm = utc.ToLocalTime().ToString("HH:mm");
|
||||||
|
|
||||||
|
vm.OnWorkerLogReceived(new WorkerLogEntry("hello", WorkerLogLevel.Info, utc));
|
||||||
|
|
||||||
|
Assert.StartsWith(expectedLocalHhmm + " · ", vm.WorkerLogText);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run tests to confirm they fail to compile**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj`
|
||||||
|
Expected: Build errors — `CreateForTests`, `OnWorkerLogReceived`, `ClearWorkerLog`, `IsWorkerLogVisible`, `WorkerLogText`, `WorkerLogLevel` do not yet exist.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement on `IslandsShellViewModel`**
|
||||||
|
|
||||||
|
Open `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`. Add `using`s if missing:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.Timers;
|
||||||
|
using Avalonia.Threading;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Ui.Services;
|
||||||
|
```
|
||||||
|
|
||||||
|
Inside the class, add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[ObservableProperty] private string? workerLogText;
|
||||||
|
[ObservableProperty] private WorkerLogLevel workerLogLevel;
|
||||||
|
[ObservableProperty] private bool isWorkerLogVisible;
|
||||||
|
|
||||||
|
private readonly Timer _workerLogTimer = new(TimeSpan.FromSeconds(30).TotalMilliseconds)
|
||||||
|
{
|
||||||
|
AutoReset = false,
|
||||||
|
};
|
||||||
|
|
||||||
|
internal static IslandsShellViewModel CreateForTests() =>
|
||||||
|
(IslandsShellViewModel)System.Runtime.Serialization.FormatterServices
|
||||||
|
.GetUninitializedObject(typeof(IslandsShellViewModel));
|
||||||
|
```
|
||||||
|
|
||||||
|
(If `FormatterServices` is unavailable under `net8.0`, instead add a parameterless `internal IslandsShellViewModel() {}` constructor guarded for tests only.)
|
||||||
|
|
||||||
|
In the existing real constructor, wire up subscription (after the line `Worker.PropertyChanged += ...` block, around line 63-70):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Worker.WorkerLogReceivedEvent += OnWorkerLogReceived;
|
||||||
|
_workerLogTimer.Elapsed += (_, _) =>
|
||||||
|
{
|
||||||
|
if (Dispatcher.UIThread.CheckAccess()) ClearWorkerLog();
|
||||||
|
else Dispatcher.UIThread.Post(ClearWorkerLog);
|
||||||
|
};
|
||||||
|
```
|
||||||
|
|
||||||
|
Add the methods the tests call:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public void OnWorkerLogReceived(WorkerLogEntry entry)
|
||||||
|
{
|
||||||
|
var hhmm = entry.TimestampUtc.ToLocalTime().ToString("HH:mm");
|
||||||
|
WorkerLogText = $"{hhmm} · {entry.Message}";
|
||||||
|
WorkerLogLevel = entry.Level;
|
||||||
|
IsWorkerLogVisible = true;
|
||||||
|
|
||||||
|
_workerLogTimer.Stop();
|
||||||
|
_workerLogTimer.Start();
|
||||||
|
}
|
||||||
|
|
||||||
|
public void ClearWorkerLog()
|
||||||
|
{
|
||||||
|
IsWorkerLogVisible = false;
|
||||||
|
WorkerLogText = null;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run tests**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj`
|
||||||
|
Expected: All tests pass (5 converter + 4 VM = 9 tests).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Build the UI project as a sanity check**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs tests/ClaudeDo.Ui.Tests/IslandsShellViewModelWorkerLogTests.cs
|
||||||
|
git commit -m "feat(ui): add worker log state and 30s timer to shell VM"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 8: Update `MainWindow.axaml` footer — dock log line right
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/MainWindow.axaml` (lines 104-135 — the footer `Border`)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add the converter resource to the window (if not already in App.axaml)**
|
||||||
|
|
||||||
|
If Task 6 declared the converter in `App.axaml`, skip this step. Otherwise, add a `<Window.Resources>` block near the top of `MainWindow.axaml`:
|
||||||
|
```xml
|
||||||
|
<Window.Resources>
|
||||||
|
<converters:WorkerLogLevelToBrushConverter x:Key="WorkerLogLevelToBrush"/>
|
||||||
|
</Window.Resources>
|
||||||
|
```
|
||||||
|
Ensure `xmlns:converters="using:ClaudeDo.Ui.Converters"` is declared on the root `<Window>`.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Replace the footer body**
|
||||||
|
|
||||||
|
Replace the existing footer `<Border Grid.Row="2" ...>` inner contents (the `<StackPanel>` at lines 109-134) with:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<DockPanel LastChildFill="True" Margin="14,0">
|
||||||
|
<!-- Left: connection pill -->
|
||||||
|
<StackPanel DockPanel.Dock="Left" Orientation="Horizontal" Spacing="7"
|
||||||
|
VerticalAlignment="Center">
|
||||||
|
<Ellipse Width="7" Height="7" Fill="#4CAF50"
|
||||||
|
IsVisible="{Binding Worker.IsConnected}"/>
|
||||||
|
<Ellipse Width="7" Height="7" Fill="#FFA726"
|
||||||
|
IsVisible="{Binding Worker.IsReconnecting}"/>
|
||||||
|
<Ellipse Width="7" Height="7" Fill="#EF5350"
|
||||||
|
IsVisible="{Binding IsOffline}"/>
|
||||||
|
<TextBlock Text="{Binding ConnectionText, Converter={StaticResource UpperCase}}"
|
||||||
|
FontFamily="{DynamicResource MonoFont}"
|
||||||
|
FontSize="10"
|
||||||
|
LetterSpacing="1.4"
|
||||||
|
Foreground="{DynamicResource TextDimBrush}"
|
||||||
|
VerticalAlignment="Center"/>
|
||||||
|
</StackPanel>
|
||||||
|
|
||||||
|
<!-- Right: worker log line -->
|
||||||
|
<TextBlock DockPanel.Dock="Right"
|
||||||
|
Text="{Binding WorkerLogText}"
|
||||||
|
IsVisible="{Binding IsWorkerLogVisible}"
|
||||||
|
Foreground="{Binding WorkerLogLevel, Converter={StaticResource WorkerLogLevelToBrush}}"
|
||||||
|
FontFamily="{DynamicResource MonoFont}"
|
||||||
|
FontSize="10"
|
||||||
|
LetterSpacing="1.4"
|
||||||
|
TextTrimming="CharacterEllipsis"
|
||||||
|
VerticalAlignment="Center"/>
|
||||||
|
|
||||||
|
<!-- Spacer (fills remaining space between pill and log) -->
|
||||||
|
<Panel/>
|
||||||
|
</DockPanel>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build the UI**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Expected: Build succeeded, 0 errors. No XAML compilation errors.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build the full app (entry point)**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Manual smoke test**
|
||||||
|
|
||||||
|
Start the Worker and the App (two separate processes per CLAUDE.md).
|
||||||
|
|
||||||
|
Exercise each event and confirm the footer line appears with the expected color and copy:
|
||||||
|
|
||||||
|
1. Start a task → expect `HH:MM · Created worktree for "<title>"` (dim/info).
|
||||||
|
2. Observe while Claude runs → expect `HH:MM · Started Claude for "<title>"` (dim/info).
|
||||||
|
3. Task commits → expect `HH:MM · Committed changes in "<title>"` (dim/info).
|
||||||
|
4. Task finishes successfully → expect `HH:MM · Finished "<title>" (done)` (green).
|
||||||
|
5. Trigger a failing task → expect `HH:MM · Finished "<title>" (failed)` (red).
|
||||||
|
6. Reset a failed task → expect `HH:MM · Discarded worktree for "<title>"` (amber) followed by `HH:MM · Reset "<title>"` (amber).
|
||||||
|
7. Merge a completed task → expect `HH:MM · Merged "<title>" into <branch>` (green).
|
||||||
|
8. Wait 30s with no new events → footer log line disappears (connection pill remains).
|
||||||
|
9. Trigger a burst of 3 events in quick succession → only the most recent is shown; timer resets on each.
|
||||||
|
10. Long task title (≥60 chars) → line is ellipsized, connection pill on the left remains fully visible.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Views/MainWindow.axaml
|
||||||
|
git commit -m "feat(ui): show worker log line in footer"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Self-Review
|
||||||
|
|
||||||
|
- **Spec coverage:**
|
||||||
|
- Enum `WorkerLogLevel` in `ClaudeDo.Data` — Task 1 ✓
|
||||||
|
- SignalR enum-as-string — Task 2 ✓
|
||||||
|
- `HubBroadcaster.WorkerLog` — Task 2 ✓
|
||||||
|
- 7 emit sites with correct level mapping — Tasks 3, 4 ✓
|
||||||
|
- `WorkerClient.WorkerLogReceived` event + `WorkerLogEntry` record — Task 5 ✓
|
||||||
|
- `WorkerLogLevelToBrushConverter` with unit tests — Task 6 ✓
|
||||||
|
- Footer VM state + 30s timer + tests — Task 7 ✓
|
||||||
|
- Footer XAML (DockPanel, connection left, log right, level-based color, ellipsis) — Task 8 ✓
|
||||||
|
- Out-of-scope items (history drawer, filtering, persistence) — correctly omitted ✓
|
||||||
|
|
||||||
|
- **Placeholder scan:** No "TBD" / "handle edge cases" / "similar to Task N". All code is inline.
|
||||||
|
|
||||||
|
- **Type consistency:** `WorkerLogEntry(Message, Level, TimestampUtc)` — same signature used in Task 5 (declaration), Task 7 (consumer tests + VM). `WorkerLog(message, level, timestampUtc)` — same signature in Task 2 (broadcaster) and Tasks 3-4 (callers). `OnWorkerLogReceived` / `ClearWorkerLog` / `IsWorkerLogVisible` / `WorkerLogText` / `WorkerLogLevel` — consistent between Task 7 test and Task 7 implementation.
|
||||||
1918
docs/superpowers/plans/2026-04-24-planning-merge-all.md
Normal file
1918
docs/superpowers/plans/2026-04-24-planning-merge-all.md
Normal file
File diff suppressed because it is too large
Load Diff
@@ -0,0 +1,799 @@
|
|||||||
|
# Planning UX Polish + Sequential Subtask Queue — Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Add sequential execution of planning subtasks (new `Waiting` status, context-menu trigger, worker-side chain advancement) plus three small UX changes (auto-collapse done planning parents in the task list, collapsible Description in the Details pane, narrower island GridSplitters).
|
||||||
|
|
||||||
|
**Architecture:** Foundation first — add the new `Waiting` enum value and its surface in the UI (chip, virtual-queued filter, row plumbing). Then ship the three UI polish items independently. Finally build the worker-side chain coordinator behind TDD and wire up the SignalR method + context-menu entry.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, Avalonia 12, CommunityToolkit.Mvvm, EF Core (Sqlite), SignalR, xUnit.
|
||||||
|
|
||||||
|
**Spec:** `docs/superpowers/specs/2026-04-24-planning-ux-and-sequential-subtasks-design.md`
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: Add `Waiting` status to the enum
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Data/Models/TaskEntity.cs` (TaskStatus enum)
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs` (chip class switch)
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs` (virtual-queued match predicate)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add `Waiting` to the enum**
|
||||||
|
|
||||||
|
Append `Waiting` as the last value (keeps existing numeric slots stable for any int-serialized rows).
|
||||||
|
|
||||||
|
`src/ClaudeDo.Data/Models/TaskEntity.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public enum TaskStatus
|
||||||
|
{
|
||||||
|
Manual,
|
||||||
|
Queued,
|
||||||
|
Running,
|
||||||
|
Done,
|
||||||
|
Failed,
|
||||||
|
Planning,
|
||||||
|
Planned,
|
||||||
|
Draft,
|
||||||
|
Waiting,
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Extend `StatusChipClass` switch in TaskRowViewModel**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs` — update the switch:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public string StatusChipClass => Status switch
|
||||||
|
{
|
||||||
|
TaskStatus.Running => "running",
|
||||||
|
TaskStatus.Failed => "error",
|
||||||
|
TaskStatus.Done => "review",
|
||||||
|
TaskStatus.Queued => "queued",
|
||||||
|
TaskStatus.Waiting => "waiting",
|
||||||
|
_ => "idle",
|
||||||
|
};
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Add `IsWaiting` and include it in virtual-queued matching**
|
||||||
|
|
||||||
|
In the same `TaskRowViewModel.cs`, add alongside `IsQueued`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public bool IsWaiting => Status == TaskStatus.Waiting;
|
||||||
|
```
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs`, find the `TaskMatchesList` static method and update the `virtual:queued` branch so tasks in `Waiting` also match. Locate the existing match for `ListKind.Virtual when list.Id == "virtual:queued"` and change it to match `t.Status == TaskStatus.Queued || t.Status == TaskStatus.Waiting`. If the existing line reads `t.Status == TaskStatus.Queued` exactly, replace it with `t.Status == TaskStatus.Queued || t.Status == TaskStatus.Waiting`.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build**
|
||||||
|
|
||||||
|
Run:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Data/ClaudeDo.Data.csproj
|
||||||
|
dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: both build with 0 errors. Existing warnings OK.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Data/Models/TaskEntity.cs \
|
||||||
|
src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs \
|
||||||
|
src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs
|
||||||
|
git commit -m "feat(data): add Waiting task status and include it in virtual:queued"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: Narrower island GridSplitters
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/MainWindow.axaml` (lines 158 and 170)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Halve the splitter width**
|
||||||
|
|
||||||
|
Both `GridSplitter` elements currently use `Width="5"`. Change both to `Width="3"`. Leave all other attributes untouched.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Views/MainWindow.axaml
|
||||||
|
git commit -m "style(ui): narrow island GridSplitters from 5 to 3"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: Collapsible Description section in Details pane
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/DetailsIslandViewModel.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/DetailsIslandView.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add observable flag + toggle command**
|
||||||
|
|
||||||
|
In `DetailsIslandViewModel.cs`, add beside the existing editable fields:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[ObservableProperty] private bool _isDescriptionExpanded = true;
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private void ToggleDescriptionExpanded() => IsDescriptionExpanded = !IsDescriptionExpanded;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Reset flag when a new task is loaded**
|
||||||
|
|
||||||
|
Find the method that handles a new `Task` being bound (the existing `OnTaskChanged` / `Bind` path — it's the spot that already sets `EditableTitle`, `EditableDescription`, etc.). At the start of the load path where fields get reset, add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
IsDescriptionExpanded = true;
|
||||||
|
```
|
||||||
|
|
||||||
|
(If the reset is scattered, put it next to the `EditableDescription = ""` assignment.)
|
||||||
|
|
||||||
|
- [ ] **Step 3: Wrap the description TextBox in a collapsible section**
|
||||||
|
|
||||||
|
In `DetailsIslandView.axaml`, locate the description TextBox. Wrap it so it looks like:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<StackPanel Spacing="4">
|
||||||
|
<Button Classes="flat"
|
||||||
|
Command="{Binding ToggleDescriptionExpandedCommand}"
|
||||||
|
HorizontalAlignment="Stretch"
|
||||||
|
HorizontalContentAlignment="Left"
|
||||||
|
Padding="0">
|
||||||
|
<StackPanel Orientation="Horizontal" Spacing="6">
|
||||||
|
<PathIcon Width="10" Height="10"
|
||||||
|
Data="{StaticResource Icon.ChevronDown}"
|
||||||
|
IsVisible="{Binding IsDescriptionExpanded}"/>
|
||||||
|
<PathIcon Width="10" Height="10"
|
||||||
|
Data="{StaticResource Icon.ChevronRight}"
|
||||||
|
IsVisible="{Binding !IsDescriptionExpanded}"/>
|
||||||
|
<TextBlock Classes="eyebrow" Text="DESCRIPTION"/>
|
||||||
|
</StackPanel>
|
||||||
|
</Button>
|
||||||
|
|
||||||
|
<!-- existing description TextBox goes here unchanged, but add: -->
|
||||||
|
<TextBox ...existing attributes...
|
||||||
|
IsVisible="{Binding IsDescriptionExpanded}"/>
|
||||||
|
</StackPanel>
|
||||||
|
```
|
||||||
|
|
||||||
|
If the existing `Icon.ChevronDown` / `Icon.ChevronRight` static resources don't exist, inspect `App.axaml` (or wherever `StaticResource Icon.*` icons live) and pick the closest existing chevron pair. If only one direction exists, use a simple `▾` / `▸` TextBlock substitute:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<TextBlock Text="▾" IsVisible="{Binding IsDescriptionExpanded}"/>
|
||||||
|
<TextBlock Text="▸" IsVisible="{Binding !IsDescriptionExpanded}"/>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Manual verify**
|
||||||
|
|
||||||
|
Launch the app (`dotnet run --project src/ClaudeDo.App`), open a task with a description, click the chevron. Verify the body collapses/expands; verify opening a different task restores the expanded default.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/Islands/DetailsIslandViewModel.cs \
|
||||||
|
src/ClaudeDo.Ui/Views/Islands/DetailsIslandView.axaml
|
||||||
|
git commit -m "feat(ui): collapsible description section in details pane"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: Auto-collapse done planning parents in task list
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add expansion state + "all children done" flag to `TaskRowViewModel`**
|
||||||
|
|
||||||
|
In `TaskRowViewModel.cs`, add below the existing observable properties:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[ObservableProperty] private bool _areChildrenExpanded = true;
|
||||||
|
[ObservableProperty] private bool _allChildrenDone;
|
||||||
|
|
||||||
|
partial void OnAllChildrenDoneChanged(bool value)
|
||||||
|
{
|
||||||
|
// Default children to collapsed once the planning parent is fully done.
|
||||||
|
if (value) AreChildrenExpanded = false;
|
||||||
|
}
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private void ToggleChildrenExpanded() => AreChildrenExpanded = !AreChildrenExpanded;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Compute `AllChildrenDone` during Regroup in `TasksIslandViewModel`**
|
||||||
|
|
||||||
|
In `TasksIslandViewModel.cs`, locate the `Regroup()` method (the one that clears and repopulates `OverdueItems`/`OpenItems`/`CompletedItems`). Before it distributes rows, build a lookup of children by parent id:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var childrenByParent = Items
|
||||||
|
.Where(r => r.IsChild && r.ParentTaskId is not null)
|
||||||
|
.GroupBy(r => r.ParentTaskId!)
|
||||||
|
.ToDictionary(g => g.Key, g => g.ToList());
|
||||||
|
|
||||||
|
foreach (var parent in Items.Where(r => r.IsPlanningParent && !r.IsChild))
|
||||||
|
{
|
||||||
|
if (childrenByParent.TryGetValue(parent.Id, out var kids) && kids.Count > 0)
|
||||||
|
parent.AllChildrenDone = kids.All(c => c.Status == TaskStatus.Done);
|
||||||
|
else
|
||||||
|
parent.AllChildrenDone = false;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Then inside the existing distribution loop, skip child rows whose parent row has `AreChildrenExpanded == false`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
foreach (var row in Items)
|
||||||
|
{
|
||||||
|
if (row.IsChild && row.ParentTaskId is not null)
|
||||||
|
{
|
||||||
|
var parentRow = Items.FirstOrDefault(p => p.Id == row.ParentTaskId);
|
||||||
|
if (parentRow is not null && !parentRow.AreChildrenExpanded) continue;
|
||||||
|
}
|
||||||
|
// ... existing distribution into Overdue/Open/Completed ...
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
If `Regroup()` currently uses LINQ expressions instead of a loop, split them out into explicit foreach so the skip is clear. Keep the overdue/completed logic intact — children of a collapsed parent are excluded from every bucket.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Re-run Regroup when a row's expansion flag toggles**
|
||||||
|
|
||||||
|
In `TasksIslandViewModel.cs`, in the constructor (after `Items` is created), subscribe to changes so toggling one row triggers a regroup:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Items.CollectionChanged += (_, e) =>
|
||||||
|
{
|
||||||
|
if (e.NewItems is not null)
|
||||||
|
foreach (TaskRowViewModel r in e.NewItems)
|
||||||
|
r.PropertyChanged += OnItemPropertyChanged;
|
||||||
|
if (e.OldItems is not null)
|
||||||
|
foreach (TaskRowViewModel r in e.OldItems)
|
||||||
|
r.PropertyChanged -= OnItemPropertyChanged;
|
||||||
|
};
|
||||||
|
```
|
||||||
|
|
||||||
|
Add the handler:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private void OnItemPropertyChanged(object? sender, System.ComponentModel.PropertyChangedEventArgs e)
|
||||||
|
{
|
||||||
|
if (e.PropertyName == nameof(TaskRowViewModel.AreChildrenExpanded))
|
||||||
|
Regroup();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Add chevron toggle button to the planning-parent row**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml`, inside the main task card where the title/eyebrow row lives (co-located with `PlanningBadge`), add a chevron button visible only when `IsPlanningParent && HasPlanningChildren`:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Button Classes="flat"
|
||||||
|
Command="{Binding ToggleChildrenExpandedCommand}"
|
||||||
|
IsVisible="{Binding HasPlanningChildren}"
|
||||||
|
Padding="0" Margin="0,0,6,0"
|
||||||
|
VerticalAlignment="Center">
|
||||||
|
<TextBlock FontSize="10"
|
||||||
|
Text="▾"
|
||||||
|
IsVisible="{Binding AreChildrenExpanded}"/>
|
||||||
|
<TextBlock FontSize="10"
|
||||||
|
Text="▸"
|
||||||
|
IsVisible="{Binding !AreChildrenExpanded}"/>
|
||||||
|
</Button>
|
||||||
|
```
|
||||||
|
|
||||||
|
Place it immediately before the title TextBlock in the parent-row layout. Leave child rows untouched.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Build**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Manual verify**
|
||||||
|
|
||||||
|
Create a planning parent with ≥2 children. Mark both children `Done` (manually via DB if needed, or via a full planning run). Reload the list — the children should be hidden by default. Click the chevron on the parent — children appear. Click again — collapse.
|
||||||
|
|
||||||
|
- [ ] **Step 7: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs \
|
||||||
|
src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs \
|
||||||
|
src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml
|
||||||
|
git commit -m "feat(ui): auto-collapse done planning parents in task list"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: PlanningChainCoordinator — worker-side chain advancement (TDD)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Worker/Planning/PlanningChainCoordinator.cs`
|
||||||
|
- Create: `tests/ClaudeDo.Worker.Tests/Planning/PlanningChainCoordinatorTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the first failing test — queueing sets first child Queued, rest Waiting**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Worker.Tests/Planning/PlanningChainCoordinatorTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.Threading.Tasks;
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Worker.Planning;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using Xunit;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.Planning;
|
||||||
|
|
||||||
|
public class PlanningChainCoordinatorTests
|
||||||
|
{
|
||||||
|
private static DbContextOptions<ClaudeDoDbContext> InMemoryOptions() =>
|
||||||
|
new DbContextOptionsBuilder<ClaudeDoDbContext>()
|
||||||
|
.UseSqlite("DataSource=:memory:;Cache=Shared")
|
||||||
|
.Options;
|
||||||
|
|
||||||
|
private static async Task<(ClaudeDoDbContext ctx, TaskRepository repo)> NewDbAsync()
|
||||||
|
{
|
||||||
|
var ctx = new ClaudeDoDbContext(InMemoryOptions());
|
||||||
|
await ctx.Database.OpenConnectionAsync();
|
||||||
|
await ctx.Database.EnsureCreatedAsync();
|
||||||
|
return (ctx, new TaskRepository(ctx));
|
||||||
|
}
|
||||||
|
|
||||||
|
private static async Task SeedPlanningFamily(TaskRepository repo, string parentId, int childCount)
|
||||||
|
{
|
||||||
|
await repo.AddAsync(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = parentId, ListId = "L1", Title = "Parent",
|
||||||
|
CreatedAt = System.DateTime.UtcNow, Status = TaskStatus.Planned,
|
||||||
|
});
|
||||||
|
for (int i = 0; i < childCount; i++)
|
||||||
|
{
|
||||||
|
await repo.AddAsync(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = $"{parentId}-c{i}", ListId = "L1", Title = $"Child {i}",
|
||||||
|
CreatedAt = System.DateTime.UtcNow, Status = TaskStatus.Manual,
|
||||||
|
ParentTaskId = parentId, SortOrder = i,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task QueueSubtasksSequentially_SetsFirstQueued_RestWaiting()
|
||||||
|
{
|
||||||
|
var (ctx, repo) = await NewDbAsync();
|
||||||
|
await using var _ = ctx;
|
||||||
|
await SeedPlanningFamily(repo, "P", 3);
|
||||||
|
|
||||||
|
var coord = new PlanningChainCoordinator(repo);
|
||||||
|
await coord.QueueSubtasksSequentiallyAsync("P", default);
|
||||||
|
|
||||||
|
var kids = await ctx.Tasks.Where(t => t.ParentTaskId == "P").OrderBy(t => t.SortOrder).ToListAsync();
|
||||||
|
Assert.Equal(TaskStatus.Queued, kids[0].Status);
|
||||||
|
Assert.Equal(TaskStatus.Waiting, kids[1].Status);
|
||||||
|
Assert.Equal(TaskStatus.Waiting, kids[2].Status);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run the test — expect failure (class doesn't exist)**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj --filter FullyQualifiedName~PlanningChainCoordinatorTests
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: compile error "PlanningChainCoordinator not found".
|
||||||
|
|
||||||
|
- [ ] **Step 3: Create the coordinator with the minimum to pass**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Worker/Planning/PlanningChainCoordinator.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Planning;
|
||||||
|
|
||||||
|
public sealed class PlanningChainCoordinator
|
||||||
|
{
|
||||||
|
private readonly TaskRepository _tasks;
|
||||||
|
|
||||||
|
public PlanningChainCoordinator(TaskRepository tasks) => _tasks = tasks;
|
||||||
|
|
||||||
|
public async Task QueueSubtasksSequentiallyAsync(string parentTaskId, CancellationToken ct)
|
||||||
|
{
|
||||||
|
var parent = await _tasks.GetByIdAsync(parentTaskId, ct)
|
||||||
|
?? throw new InvalidOperationException($"Task {parentTaskId} not found.");
|
||||||
|
|
||||||
|
var children = (await _tasks.GetChildrenAsync(parentTaskId, ct))
|
||||||
|
.OrderBy(t => t.SortOrder)
|
||||||
|
.ToList();
|
||||||
|
if (children.Count == 0)
|
||||||
|
throw new InvalidOperationException("Parent has no subtasks.");
|
||||||
|
|
||||||
|
var bad = children.FirstOrDefault(c => c.Status is not (TaskStatus.Manual or TaskStatus.Planned));
|
||||||
|
if (bad is not null)
|
||||||
|
throw new InvalidOperationException($"Child {bad.Id} is in status {bad.Status}; expected Manual or Planned.");
|
||||||
|
|
||||||
|
for (int i = 0; i < children.Count; i++)
|
||||||
|
{
|
||||||
|
children[i].Status = i == 0 ? TaskStatus.Queued : TaskStatus.Waiting;
|
||||||
|
await _tasks.UpdateAsync(children[i], ct);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
If `TaskRepository.GetChildrenAsync` does not yet exist, add it:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
// in src/ClaudeDo.Data/Repositories/TaskRepository.cs
|
||||||
|
public Task<List<TaskEntity>> GetChildrenAsync(string parentTaskId, CancellationToken ct = default) =>
|
||||||
|
_ctx.Tasks.Where(t => t.ParentTaskId == parentTaskId).ToListAsync(ct);
|
||||||
|
```
|
||||||
|
|
||||||
|
(If the repo uses `AsNoTracking()` elsewhere for reads, match that pattern. For this method we want tracked entities so `UpdateAsync` works without extra attach.)
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run the test — expect pass**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj --filter FullyQualifiedName~PlanningChainCoordinatorTests
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: 1 passed.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Add failing test — on child Done, next Waiting sibling flips to Queued**
|
||||||
|
|
||||||
|
Append to `PlanningChainCoordinatorTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task OnChildDone_FlipsNextWaitingToQueued()
|
||||||
|
{
|
||||||
|
var (ctx, repo) = await NewDbAsync();
|
||||||
|
await using var _ = ctx;
|
||||||
|
await SeedPlanningFamily(repo, "P", 3);
|
||||||
|
|
||||||
|
var coord = new PlanningChainCoordinator(repo);
|
||||||
|
await coord.QueueSubtasksSequentiallyAsync("P", default);
|
||||||
|
|
||||||
|
// Simulate first child finishing Done.
|
||||||
|
var first = await ctx.Tasks.FirstAsync(t => t.Id == "P-c0");
|
||||||
|
first.Status = TaskStatus.Done;
|
||||||
|
await ctx.SaveChangesAsync();
|
||||||
|
|
||||||
|
var advanced = await coord.OnChildFinishedAsync("P-c0", TaskStatus.Done, default);
|
||||||
|
|
||||||
|
Assert.Equal("P-c1", advanced);
|
||||||
|
var kids = await ctx.Tasks.Where(t => t.ParentTaskId == "P").OrderBy(t => t.SortOrder).ToListAsync();
|
||||||
|
Assert.Equal(TaskStatus.Done, kids[0].Status);
|
||||||
|
Assert.Equal(TaskStatus.Queued, kids[1].Status);
|
||||||
|
Assert.Equal(TaskStatus.Waiting, kids[2].Status);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 6: Run — expect failure**
|
||||||
|
|
||||||
|
Expected: compile error "OnChildFinishedAsync does not exist".
|
||||||
|
|
||||||
|
- [ ] **Step 7: Implement `OnChildFinishedAsync`**
|
||||||
|
|
||||||
|
In `PlanningChainCoordinator.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
/// <summary>
|
||||||
|
/// Call after a child task transitions to a terminal status.
|
||||||
|
/// Returns the id of the newly-queued sibling (if any), else null.
|
||||||
|
/// </summary>
|
||||||
|
public async Task<string?> OnChildFinishedAsync(string childTaskId, TaskStatus finalStatus, CancellationToken ct)
|
||||||
|
{
|
||||||
|
if (finalStatus != TaskStatus.Done) return null;
|
||||||
|
|
||||||
|
var child = await _tasks.GetByIdAsync(childTaskId, ct);
|
||||||
|
if (child?.ParentTaskId is null) return null;
|
||||||
|
|
||||||
|
var siblings = (await _tasks.GetChildrenAsync(child.ParentTaskId, ct))
|
||||||
|
.OrderBy(t => t.SortOrder)
|
||||||
|
.ToList();
|
||||||
|
|
||||||
|
var next = siblings
|
||||||
|
.Where(s => s.SortOrder > child.SortOrder && s.Status == TaskStatus.Waiting)
|
||||||
|
.FirstOrDefault();
|
||||||
|
if (next is null) return null;
|
||||||
|
|
||||||
|
next.Status = TaskStatus.Queued;
|
||||||
|
await _tasks.UpdateAsync(next, ct);
|
||||||
|
return next.Id;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 8: Run — expect pass**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj --filter FullyQualifiedName~PlanningChainCoordinatorTests
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: 2 passed.
|
||||||
|
|
||||||
|
- [ ] **Step 9: Add failing test — on Failed, chain stops**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task OnChildFailed_DoesNotAdvanceChain()
|
||||||
|
{
|
||||||
|
var (ctx, repo) = await NewDbAsync();
|
||||||
|
await using var _ = ctx;
|
||||||
|
await SeedPlanningFamily(repo, "P", 3);
|
||||||
|
|
||||||
|
var coord = new PlanningChainCoordinator(repo);
|
||||||
|
await coord.QueueSubtasksSequentiallyAsync("P", default);
|
||||||
|
|
||||||
|
var first = await ctx.Tasks.FirstAsync(t => t.Id == "P-c0");
|
||||||
|
first.Status = TaskStatus.Failed;
|
||||||
|
await ctx.SaveChangesAsync();
|
||||||
|
|
||||||
|
var advanced = await coord.OnChildFinishedAsync("P-c0", TaskStatus.Failed, default);
|
||||||
|
|
||||||
|
Assert.Null(advanced);
|
||||||
|
var kids = await ctx.Tasks.Where(t => t.ParentTaskId == "P").OrderBy(t => t.SortOrder).ToListAsync();
|
||||||
|
Assert.Equal(TaskStatus.Failed, kids[0].Status);
|
||||||
|
Assert.Equal(TaskStatus.Waiting, kids[1].Status);
|
||||||
|
Assert.Equal(TaskStatus.Waiting, kids[2].Status);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 10: Run — expect pass (existing guard handles it)**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj --filter FullyQualifiedName~PlanningChainCoordinatorTests
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: 3 passed.
|
||||||
|
|
||||||
|
- [ ] **Step 11: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Planning/PlanningChainCoordinator.cs \
|
||||||
|
src/ClaudeDo.Data/Repositories/TaskRepository.cs \
|
||||||
|
tests/ClaudeDo.Worker.Tests/Planning/PlanningChainCoordinatorTests.cs
|
||||||
|
git commit -m "feat(worker): add PlanningChainCoordinator with sequential subtask advancement"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 6: Hook chain advancement into TaskRunner finish path
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Runner/TaskRunner.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Program.cs` (DI registration)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Register `PlanningChainCoordinator` in DI**
|
||||||
|
|
||||||
|
Locate `src/ClaudeDo.Worker/Program.cs` where other services are registered (look for `services.AddSingleton<PlanningSessionManager>` or similar). Add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
services.AddScoped<PlanningChainCoordinator>();
|
||||||
|
```
|
||||||
|
|
||||||
|
Use `AddScoped` if `TaskRepository` is scoped (check how it's registered — match its lifetime). If `TaskRepository` is constructed ad-hoc inside the worker, add a constructor overload on `PlanningChainCoordinator` that takes `IDbContextFactory<ClaudeDoDbContext>` and builds its own `TaskRepository` per call, then register as Singleton. Mirror the pattern used by `PlanningSessionManager`.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Inject coordinator into `TaskRunner`**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Worker/Runner/TaskRunner.cs`, add `PlanningChainCoordinator` to the constructor parameter list and store it in a readonly field (match the style used for `_broadcaster`).
|
||||||
|
|
||||||
|
If `TaskRunner` is not a good fit for direct injection (e.g., it's used in contexts without DI), instead inject `IServiceProvider` / `IDbContextFactory<ClaudeDoDbContext>` and new-up a coordinator inside the finish handler. Pick whichever matches existing `TaskRunner` patterns.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Call coordinator after Done/Failed emission**
|
||||||
|
|
||||||
|
Immediately after each `await _broadcaster.TaskFinished(slot, task.Id, "done", finishedAt);` on line ~338 and the two failed emissions on lines ~355 and ~372, add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
if (task.ParentTaskId is not null)
|
||||||
|
{
|
||||||
|
var advancedId = await _chainCoordinator.OnChildFinishedAsync(
|
||||||
|
task.Id,
|
||||||
|
/* Done or Failed based on path */,
|
||||||
|
CancellationToken.None);
|
||||||
|
if (advancedId is not null)
|
||||||
|
await _broadcaster.TaskUpdated(advancedId);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Use `TaskStatus.Done` in the done-path call site and `TaskStatus.Failed` in the failed-path call sites. For the failed paths that use `justFailed` rather than `task`, read `justFailed?.ParentTaskId` and `justFailed?.Id` to stay consistent with the surrounding code.
|
||||||
|
|
||||||
|
After this call the existing queue-pickup loop will see the newly-Queued sibling and dispatch it on its next tick.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Run full test suite**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: all pre-existing tests + 3 new ones pass.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Runner/TaskRunner.cs \
|
||||||
|
src/ClaudeDo.Worker/Program.cs
|
||||||
|
git commit -m "feat(worker): advance planning subtask chain on child finish"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 7: Hub method + client + context menu entry
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Hub/WorkerHub.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/IWorkerClient.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/WorkerClient.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add hub method**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Worker/Hub/WorkerHub.cs`, add (match the style of other planning methods):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public async Task QueuePlanningSubtasks(string parentTaskId)
|
||||||
|
{
|
||||||
|
await using var ctx = await _dbFactory.CreateDbContextAsync();
|
||||||
|
var repo = new TaskRepository(ctx);
|
||||||
|
var coord = new PlanningChainCoordinator(repo);
|
||||||
|
await coord.QueueSubtasksSequentiallyAsync(parentTaskId, CancellationToken.None);
|
||||||
|
|
||||||
|
// Broadcast updates for the parent and all its children so the UI refreshes.
|
||||||
|
var children = await ctx.Tasks
|
||||||
|
.Where(t => t.ParentTaskId == parentTaskId)
|
||||||
|
.Select(t => t.Id)
|
||||||
|
.ToListAsync();
|
||||||
|
await _broadcaster.TaskUpdated(parentTaskId);
|
||||||
|
foreach (var id in children)
|
||||||
|
await _broadcaster.TaskUpdated(id);
|
||||||
|
|
||||||
|
// Make sure the queue picks up the now-Queued first child immediately.
|
||||||
|
_queueSignal.Wake();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
If the existing hub constructs `PlanningSessionManager` via DI directly, inject `PlanningChainCoordinator` the same way and call `_chainCoordinator.QueueSubtasksSequentiallyAsync(...)` instead of newing one up. If the hub exposes a queue-wakeup via a different name than `_queueSignal`, use that (search the file for `WakeQueue` or `.Wake()`).
|
||||||
|
|
||||||
|
- [ ] **Step 2: Add method to `IWorkerClient`**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Services/IWorkerClient.cs`, add next to the other planning methods:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Task QueuePlanningSubtasksAsync(string parentTaskId, CancellationToken ct = default);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement in `WorkerClient`**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Services/WorkerClient.cs`, add (match the pattern of `StartPlanningSessionAsync` etc.):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public Task QueuePlanningSubtasksAsync(string parentTaskId, CancellationToken ct = default) =>
|
||||||
|
_connection.InvokeAsync("QueuePlanningSubtasks", parentTaskId, ct);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Add `CanQueueSubtasksSequentially` + `HasPlanningChildren` observable to `TaskRowViewModel`**
|
||||||
|
|
||||||
|
Confirm `HasPlanningChildren` exists (it's referenced in the spec). If not, add it as `[ObservableProperty] bool _hasPlanningChildren;` and ensure `TasksIslandViewModel.Regroup()` already sets it (there should be a parent-side "has children" pass similar to the `AllChildrenDone` one added in Task 4 — if not, set it there).
|
||||||
|
|
||||||
|
Then add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public bool CanQueueSubtasksSequentially =>
|
||||||
|
IsPlanningParent && HasPlanningChildren && !IsChild;
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `OnPropertyChanged(nameof(CanQueueSubtasksSequentially))` inside `OnStatusChanged` and `OnHasPlanningChildrenChanged` so the flag refreshes when status or children change.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Add context-menu entry**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml`, inside the existing `<ContextMenu>`, directly after the "Discard planning session" item:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Separator IsVisible="{Binding CanQueueSubtasksSequentially}"/>
|
||||||
|
<MenuItem Header="Queue subtasks sequentially"
|
||||||
|
IsVisible="{Binding CanQueueSubtasksSequentially}"
|
||||||
|
Click="OnQueueSubtasksSequentiallyClick"/>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 6: Add click handler in code-behind**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml.cs`, add (match the other `On*Click` handlers — they pull the `TaskRowViewModel` from `DataContext` and call the shell / worker):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private async void OnQueueSubtasksSequentiallyClick(object? sender, Avalonia.Interactivity.RoutedEventArgs e)
|
||||||
|
{
|
||||||
|
if (DataContext is not TaskRowViewModel row) return;
|
||||||
|
var worker = App.Services.GetRequiredService<IWorkerClient>();
|
||||||
|
try
|
||||||
|
{
|
||||||
|
await worker.QueuePlanningSubtasksAsync(row.Id);
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
// Match the toast/log pattern used by OnSendToQueueClick et al.
|
||||||
|
System.Diagnostics.Debug.WriteLine($"QueuePlanningSubtasks failed: {ex}");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Use the same `App.Services` / `IWorkerClient` lookup pattern as `OnSendToQueueClick` — do not introduce a new DI pattern. If the existing handlers use a shell/mediator indirection, use that instead.
|
||||||
|
|
||||||
|
- [ ] **Step 7: Build**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 8: Manual verify end-to-end**
|
||||||
|
|
||||||
|
1. Launch app: `dotnet run --project src/ClaudeDo.App`.
|
||||||
|
2. Open a planning task with ≥2 subtasks (all in `Manual`/`Planned`).
|
||||||
|
3. Right-click parent → **Queue subtasks sequentially**.
|
||||||
|
4. Confirm in the task list: first child shows `Queued` chip, others show `Waiting` chip.
|
||||||
|
5. Let the first run to completion (or, for a quick smoke test, edit the DB to mark it `Done` and emit `TaskUpdated` via a restart).
|
||||||
|
6. Confirm the next child's status flips `Waiting → Queued` without user interaction.
|
||||||
|
7. Force-fail a child (cancel it mid-run) — confirm remaining `Waiting` children stay `Waiting`.
|
||||||
|
|
||||||
|
- [ ] **Step 9: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Hub/WorkerHub.cs \
|
||||||
|
src/ClaudeDo.Ui/Services/IWorkerClient.cs \
|
||||||
|
src/ClaudeDo.Ui/Services/WorkerClient.cs \
|
||||||
|
src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs \
|
||||||
|
src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml \
|
||||||
|
src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml.cs
|
||||||
|
git commit -m "feat(ui+worker): context menu to queue planning subtasks sequentially"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Self-review checklist (for the plan author before handing off)
|
||||||
|
|
||||||
|
- All four spec items mapped: auto-collapse (Task 4), collapsible description (Task 3), narrower splitters (Task 2), sequential subtask queue (Tasks 1, 5, 6, 7).
|
||||||
|
- `Waiting` enum touches: enum, chip class, virtual:queued filter — covered in Task 1.
|
||||||
|
- TDD applied where it pays off (the coordinator); UI tasks rely on manual verification (correct for this codebase).
|
||||||
|
- No placeholders. Every code step shows the code to paste.
|
||||||
|
- Type names consistent: `PlanningChainCoordinator`, `QueueSubtasksSequentiallyAsync`, `OnChildFinishedAsync`, `QueuePlanningSubtasksAsync`, `AreChildrenExpanded`, `AllChildrenDone`, `IsDescriptionExpanded` — used the same across tasks.
|
||||||
|
- Commits are small and conventional.
|
||||||
999
docs/superpowers/plans/2026-04-24-planning-worktree-plan.md
Normal file
999
docs/superpowers/plans/2026-04-24-planning-worktree-plan.md
Normal file
@@ -0,0 +1,999 @@
|
|||||||
|
# Planning Session Worktree Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Make `mcp__claudedo__*` tools available inside planning sessions by running each session in an ephemeral git worktree that holds a project-scope `.mcp.json` and a settings override that auto-trusts project MCP servers.
|
||||||
|
|
||||||
|
**Architecture:** `PlanningSessionManager` creates a short-lived git worktree from `HEAD` of the list's working directory on `StartAsync`, writes `.mcp.json` (with env-var expansion for the bearer token) and `.claude/settings.local.json` into it, and returns the worktree path as the spawn directory. `WindowsTerminalPlanningLauncher` passes the token via env var (`CLAUDEDO_PLANNING_TOKEN`) and stops passing `--mcp-config`. Finalize/Discard force-remove the worktree and branch.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, xUnit, real SQLite (DbFixture), real git worktrees via `ClaudeDo.Data.Git.GitService`.
|
||||||
|
|
||||||
|
**Spec:** `docs/superpowers/specs/2026-04-24-planning-worktree-design.md`
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File Structure
|
||||||
|
|
||||||
|
**Modify:**
|
||||||
|
- `src/ClaudeDo.Worker/Planning/PlanningSessionContext.cs` — add `Token`, `WorktreePath`, `BranchName` to start context; add `Token` and rename `McpConfigPath` → `WorktreePath` on resume context
|
||||||
|
- `src/ClaudeDo.Worker/Planning/PlanningSessionFiles.cs` — drop `McpConfigPath` field
|
||||||
|
- `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs` — worktree create/cleanup, token persistence, new ctor deps
|
||||||
|
- `src/ClaudeDo.Worker/Planning/WindowsTerminalPlanningLauncher.cs` — env var, drop `--mcp-config`
|
||||||
|
- `src/ClaudeDo.Worker/Program.cs` — DI wiring for new ctor signature
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/Planning/PlanningSessionManagerTests.cs` — add git init, update existing assertions
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/Planning/PlanningEndToEndTests.cs` — add git init in setup
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/Planning/WindowsTerminalPlanningLauncherTests.cs` — assert env var, no `--mcp-config`
|
||||||
|
|
||||||
|
Each file has one clear responsibility; no new files needed.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: Extend context records with token and worktree info
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Planning/PlanningSessionContext.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Edit the records**
|
||||||
|
|
||||||
|
Replace the full file content with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Worker.Planning;
|
||||||
|
|
||||||
|
public sealed record PlanningSessionStartContext(
|
||||||
|
string ParentTaskId,
|
||||||
|
string WorkingDir,
|
||||||
|
string Token,
|
||||||
|
string WorktreePath,
|
||||||
|
string BranchName,
|
||||||
|
PlanningSessionFiles Files);
|
||||||
|
|
||||||
|
public sealed record PlanningSessionResumeContext(
|
||||||
|
string ParentTaskId,
|
||||||
|
string WorkingDir,
|
||||||
|
string ClaudeSessionId,
|
||||||
|
string Token,
|
||||||
|
string WorktreePath);
|
||||||
|
```
|
||||||
|
|
||||||
|
Note: `WorkingDir` on both records now points at the worktree (callers that used it as "spawn dir" remain correct; callers that needed "list working dir" must be updated separately — no such callers exist today).
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build to see breakage**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: FAIL — `PlanningSessionManager` and `WindowsTerminalPlanningLauncher` no longer match these signatures.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit stub**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Planning/PlanningSessionContext.cs
|
||||||
|
git commit -m "refactor(worker): extend planning contexts with token and worktree"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: Drop `McpConfigPath` from `PlanningSessionFiles`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Planning/PlanningSessionFiles.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Edit the record**
|
||||||
|
|
||||||
|
Replace the full file content with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Worker.Planning;
|
||||||
|
|
||||||
|
public sealed record PlanningSessionFiles(
|
||||||
|
string SessionDirectory,
|
||||||
|
string SystemPromptPath,
|
||||||
|
string InitialPromptPath);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Planning/PlanningSessionFiles.cs
|
||||||
|
git commit -m "refactor(worker): drop McpConfigPath from PlanningSessionFiles"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: Extend `PlanningSessionManager` constructors
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs` (fields + constructors only)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add using directives**
|
||||||
|
|
||||||
|
At the top of `PlanningSessionManager.cs`, add these imports alongside the existing ones:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data.Git;
|
||||||
|
using ClaudeDo.Worker.Config;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Replace fields and constructors**
|
||||||
|
|
||||||
|
Replace the block from `private const string McpServerUrl` down to the end of `CreateRepos()` with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private const string McpServerUrl = "http://127.0.0.1:47821/mcp";
|
||||||
|
|
||||||
|
private readonly IDbContextFactory<ClaudeDoDbContext>? _factory;
|
||||||
|
private readonly TaskRepository? _tasksOverride;
|
||||||
|
private readonly ListRepository? _listsOverride;
|
||||||
|
private readonly AppSettingsRepository? _settingsOverride;
|
||||||
|
private readonly GitService _git;
|
||||||
|
private readonly WorkerConfig _cfg;
|
||||||
|
private readonly string _rootDirectory;
|
||||||
|
|
||||||
|
// DI constructor.
|
||||||
|
public PlanningSessionManager(
|
||||||
|
IDbContextFactory<ClaudeDoDbContext> factory,
|
||||||
|
GitService git,
|
||||||
|
WorkerConfig cfg,
|
||||||
|
string rootDirectory)
|
||||||
|
{
|
||||||
|
_factory = factory;
|
||||||
|
_git = git;
|
||||||
|
_cfg = cfg;
|
||||||
|
_rootDirectory = rootDirectory;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Test constructor.
|
||||||
|
public PlanningSessionManager(
|
||||||
|
TaskRepository tasks,
|
||||||
|
ListRepository lists,
|
||||||
|
AppSettingsRepository settings,
|
||||||
|
GitService git,
|
||||||
|
WorkerConfig cfg,
|
||||||
|
string rootDirectory)
|
||||||
|
{
|
||||||
|
_tasksOverride = tasks;
|
||||||
|
_listsOverride = lists;
|
||||||
|
_settingsOverride = settings;
|
||||||
|
_git = git;
|
||||||
|
_cfg = cfg;
|
||||||
|
_rootDirectory = rootDirectory;
|
||||||
|
}
|
||||||
|
|
||||||
|
private (TaskRepository tasks, ListRepository lists, AppSettingsRepository settings, ClaudeDoDbContext? ctx) CreateRepos()
|
||||||
|
{
|
||||||
|
if (_tasksOverride is not null)
|
||||||
|
return (_tasksOverride, _listsOverride!, _settingsOverride!, null);
|
||||||
|
var ctx = _factory!.CreateDbContext();
|
||||||
|
return (new TaskRepository(ctx), new ListRepository(ctx), new AppSettingsRepository(ctx), ctx);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Update all `CreateRepos()` call-sites in this file**
|
||||||
|
|
||||||
|
Every call currently binds `(tasks, lists, ctx)`. Change each to `(tasks, lists, settings, ctx)` (search the file for `= CreateRepos();`).
|
||||||
|
|
||||||
|
The `_` and `__` discard patterns on the returned `ctx` (lines like `await using var _ = ctx;`) remain valid.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build — expect test breakage**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: PASS (production code compiles).
|
||||||
|
|
||||||
|
Run: `dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj`
|
||||||
|
Expected: FAIL — test ctor calls don't match. Will be fixed in Task 10.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs
|
||||||
|
git commit -m "refactor(worker): inject GitService and WorkerConfig into PlanningSessionManager"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: Add a worktree-path helper and the token-file helpers
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs` (add private helpers)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add three private helpers at the bottom of the class (before the closing `}`)**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private static string BranchNameFor(string taskId) =>
|
||||||
|
$"claudedo/planning/{taskId.Replace("-", "")}";
|
||||||
|
|
||||||
|
private string WorktreePathFor(string taskId, string strategy, string? centralRootOverride, string listWorkingDir)
|
||||||
|
{
|
||||||
|
var centralRoot = !string.IsNullOrWhiteSpace(centralRootOverride)
|
||||||
|
? centralRootOverride!
|
||||||
|
: _cfg.CentralWorktreeRoot;
|
||||||
|
|
||||||
|
var raw = strategy.Equals("central", StringComparison.OrdinalIgnoreCase)
|
||||||
|
? Path.Combine(centralRoot, "planning", taskId)
|
||||||
|
: Path.Combine(Path.GetDirectoryName(listWorkingDir)!, ".claudedo-worktrees", "planning", taskId);
|
||||||
|
|
||||||
|
return Path.GetFullPath(raw);
|
||||||
|
}
|
||||||
|
|
||||||
|
private static string TokenFilePathFor(string sessionDir) =>
|
||||||
|
Path.Combine(sessionDir, "token");
|
||||||
|
|
||||||
|
private static async Task WriteTokenFileAsync(string path, string token, CancellationToken ct)
|
||||||
|
{
|
||||||
|
await File.WriteAllTextAsync(path, token, ct);
|
||||||
|
// Best-effort current-user-only ACL on Windows. On non-Windows the inherited
|
||||||
|
// perms from the parent dir apply; acceptable because sessionDir is already
|
||||||
|
// under the user's home (~/.todo-app/sessions/).
|
||||||
|
if (OperatingSystem.IsWindows())
|
||||||
|
{
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var fi = new FileInfo(path);
|
||||||
|
var ac = fi.GetAccessControl();
|
||||||
|
ac.SetAccessRuleProtection(isProtected: true, preserveInheritance: false);
|
||||||
|
var me = System.Security.Principal.WindowsIdentity.GetCurrent().User!;
|
||||||
|
ac.AddAccessRule(new System.Security.AccessControl.FileSystemAccessRule(
|
||||||
|
me,
|
||||||
|
System.Security.AccessControl.FileSystemRights.FullControl,
|
||||||
|
System.Security.AccessControl.AccessControlType.Allow));
|
||||||
|
fi.SetAccessControl(ac);
|
||||||
|
}
|
||||||
|
catch { /* ACL hardening is best-effort */ }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private static async Task<string> ReadTokenFileAsync(string path, CancellationToken ct)
|
||||||
|
{
|
||||||
|
if (!File.Exists(path))
|
||||||
|
throw new InvalidOperationException($"Token file missing: {path}");
|
||||||
|
return (await File.ReadAllTextAsync(path, ct)).Trim();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs
|
||||||
|
git commit -m "refactor(worker): add worktree path and token file helpers"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: Rewrite `BuildMcpConfigJson` to use env-var expansion
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Replace `BuildMcpConfigJson` body**
|
||||||
|
|
||||||
|
Find the existing `private static string BuildMcpConfigJson(string token)` method. Replace with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private static string BuildMcpConfigJson()
|
||||||
|
{
|
||||||
|
var payload = new
|
||||||
|
{
|
||||||
|
mcpServers = new
|
||||||
|
{
|
||||||
|
claudedo = new
|
||||||
|
{
|
||||||
|
type = "http",
|
||||||
|
url = McpServerUrl,
|
||||||
|
headers = new Dictionary<string, string>
|
||||||
|
{
|
||||||
|
["Authorization"] = "Bearer ${CLAUDEDO_PLANNING_TOKEN}"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
|
return JsonSerializer.Serialize(payload, new JsonSerializerOptions { WriteIndented = true });
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
(The token argument is dropped — claude expands `${CLAUDEDO_PLANNING_TOKEN}` at load time from the spawned process environment.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Also add settings override builder below it**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private const string SettingsLocalJson = """
|
||||||
|
{
|
||||||
|
"enableAllProjectMcpServers": true
|
||||||
|
}
|
||||||
|
""";
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs
|
||||||
|
git commit -m "refactor(worker): switch MCP config to env-var token expansion"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 6: Rewrite `StartAsync` to create the worktree
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs` (body of `StartAsync` only)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Replace `StartAsync` body (keep signature)**
|
||||||
|
|
||||||
|
Replace the entire method body with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public async Task<PlanningSessionStartContext> StartAsync(string taskId, CancellationToken ct)
|
||||||
|
{
|
||||||
|
var (tasks, lists, settings, ctx) = CreateRepos();
|
||||||
|
await using var _ = ctx;
|
||||||
|
|
||||||
|
var task = await tasks.GetByIdAsync(taskId, ct)
|
||||||
|
?? throw new InvalidOperationException($"Task {taskId} not found.");
|
||||||
|
if (task.ParentTaskId is not null)
|
||||||
|
throw new InvalidOperationException("Cannot start a planning session on a child task.");
|
||||||
|
if (task.Status != TaskStatus.Manual)
|
||||||
|
throw new InvalidOperationException($"Task is in status {task.Status}; only Manual can start planning.");
|
||||||
|
|
||||||
|
var list = await lists.GetByIdAsync(task.ListId, ct)
|
||||||
|
?? throw new InvalidOperationException($"List {task.ListId} not found.");
|
||||||
|
var listWorkingDir = list.WorkingDir
|
||||||
|
?? throw new InvalidOperationException($"List {task.ListId} has no working directory configured.");
|
||||||
|
|
||||||
|
if (!await _git.IsGitRepoAsync(listWorkingDir, ct))
|
||||||
|
throw new InvalidOperationException($"Working directory is not a git repository: {listWorkingDir}");
|
||||||
|
|
||||||
|
var appSettings = await settings.GetAsync(ct);
|
||||||
|
var worktreePath = WorktreePathFor(taskId, appSettings.WorktreeStrategy, appSettings.CentralWorktreeRoot, listWorkingDir);
|
||||||
|
var branchName = BranchNameFor(taskId);
|
||||||
|
var baseCommit = await _git.RevParseHeadAsync(listWorkingDir, ct);
|
||||||
|
|
||||||
|
Directory.CreateDirectory(Path.GetDirectoryName(worktreePath)!);
|
||||||
|
try
|
||||||
|
{
|
||||||
|
await _git.WorktreeAddAsync(listWorkingDir, branchName, worktreePath, baseCommit, ct);
|
||||||
|
}
|
||||||
|
catch (InvalidOperationException ex) when (ex.Message.Contains("already exists", StringComparison.OrdinalIgnoreCase))
|
||||||
|
{
|
||||||
|
// Self-heal: remove phantom worktrees, prune, delete branch, retry once.
|
||||||
|
var stalePaths = await _git.ListWorktreePathsForBranchAsync(listWorkingDir, branchName, ct);
|
||||||
|
foreach (var stale in stalePaths)
|
||||||
|
{
|
||||||
|
try { await _git.WorktreeRemoveAsync(listWorkingDir, stale, force: true, ct); } catch { }
|
||||||
|
}
|
||||||
|
try { await _git.WorktreePruneAsync(listWorkingDir, ct); } catch { }
|
||||||
|
try { await _git.BranchDeleteAsync(listWorkingDir, branchName, force: true, ct); } catch { }
|
||||||
|
await _git.WorktreeAddAsync(listWorkingDir, branchName, worktreePath, baseCommit, ct);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Write .mcp.json and .claude/settings.local.json into the worktree.
|
||||||
|
var mcpPath = Path.Combine(worktreePath, ".mcp.json");
|
||||||
|
await File.WriteAllTextAsync(mcpPath, BuildMcpConfigJson(), ct);
|
||||||
|
|
||||||
|
var claudeDir = Path.Combine(worktreePath, ".claude");
|
||||||
|
Directory.CreateDirectory(claudeDir);
|
||||||
|
await File.WriteAllTextAsync(Path.Combine(claudeDir, "settings.local.json"), SettingsLocalJson, ct);
|
||||||
|
|
||||||
|
// Session dir + token + prompt files.
|
||||||
|
var token = GenerateToken();
|
||||||
|
var started = await tasks.SetPlanningStartedAsync(taskId, token, ct)
|
||||||
|
?? throw new InvalidOperationException("Failed to transition task to Planning.");
|
||||||
|
|
||||||
|
var sessionDir = Path.Combine(_rootDirectory, taskId);
|
||||||
|
Directory.CreateDirectory(sessionDir);
|
||||||
|
|
||||||
|
var files = new PlanningSessionFiles(
|
||||||
|
sessionDir,
|
||||||
|
Path.Combine(sessionDir, "system-prompt.md"),
|
||||||
|
Path.Combine(sessionDir, "initial-prompt.txt"));
|
||||||
|
|
||||||
|
await WriteTokenFileAsync(TokenFilePathFor(sessionDir), token, ct);
|
||||||
|
await File.WriteAllTextAsync(files.SystemPromptPath, BuildSystemPrompt(), ct);
|
||||||
|
await File.WriteAllTextAsync(files.InitialPromptPath, BuildInitialPrompt(task), ct);
|
||||||
|
|
||||||
|
return new PlanningSessionStartContext(
|
||||||
|
ParentTaskId: taskId,
|
||||||
|
WorkingDir: worktreePath,
|
||||||
|
Token: token,
|
||||||
|
WorktreePath: worktreePath,
|
||||||
|
BranchName: branchName,
|
||||||
|
Files: files);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs
|
||||||
|
git commit -m "feat(worker): create ephemeral worktree and write .mcp.json in StartAsync"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 7: Rewrite `ResumeAsync` and add cleanup to `FinalizeAsync` / `DiscardAsync`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs` (three methods)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Replace `ResumeAsync` body**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public async Task<PlanningSessionResumeContext> ResumeAsync(string taskId, CancellationToken ct)
|
||||||
|
{
|
||||||
|
var (tasks, lists, settings, ctx) = CreateRepos();
|
||||||
|
await using var _ = ctx;
|
||||||
|
|
||||||
|
var task = await tasks.GetByIdAsync(taskId, ct)
|
||||||
|
?? throw new InvalidOperationException($"Task {taskId} not found.");
|
||||||
|
if (task.Status != TaskStatus.Planning)
|
||||||
|
throw new InvalidOperationException($"Task is in status {task.Status}; resume requires Planning.");
|
||||||
|
if (string.IsNullOrEmpty(task.PlanningSessionId))
|
||||||
|
throw new InvalidOperationException("No Claude session ID captured yet; cannot resume.");
|
||||||
|
|
||||||
|
var sessionDir = Path.Combine(_rootDirectory, taskId);
|
||||||
|
if (!Directory.Exists(sessionDir))
|
||||||
|
throw new InvalidOperationException($"Session directory missing: {sessionDir}");
|
||||||
|
|
||||||
|
var list = await lists.GetByIdAsync(task.ListId, ct)
|
||||||
|
?? throw new InvalidOperationException($"List {task.ListId} not found.");
|
||||||
|
var listWorkingDir = list.WorkingDir
|
||||||
|
?? throw new InvalidOperationException($"List {task.ListId} has no working directory configured.");
|
||||||
|
|
||||||
|
var appSettings = await settings.GetAsync(ct);
|
||||||
|
var worktreePath = WorktreePathFor(taskId, appSettings.WorktreeStrategy, appSettings.CentralWorktreeRoot, listWorkingDir);
|
||||||
|
if (!Directory.Exists(worktreePath))
|
||||||
|
throw new InvalidOperationException($"Planning worktree missing — cannot resume: {worktreePath}");
|
||||||
|
|
||||||
|
var token = await ReadTokenFileAsync(TokenFilePathFor(sessionDir), ct);
|
||||||
|
|
||||||
|
return new PlanningSessionResumeContext(
|
||||||
|
ParentTaskId: taskId,
|
||||||
|
WorkingDir: worktreePath,
|
||||||
|
ClaudeSessionId: task.PlanningSessionId,
|
||||||
|
Token: token,
|
||||||
|
WorktreePath: worktreePath);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Extend `FinalizeAsync` to clean up worktree + branch**
|
||||||
|
|
||||||
|
Replace the existing `FinalizeAsync` body with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public async Task<int> FinalizeAsync(string taskId, bool queueAgentTasks, CancellationToken ct)
|
||||||
|
{
|
||||||
|
var (tasks, lists, settings, ctx) = CreateRepos();
|
||||||
|
await using var __ = ctx;
|
||||||
|
|
||||||
|
var count = await tasks.FinalizePlanningAsync(taskId, queueAgentTasks, ct);
|
||||||
|
|
||||||
|
// Best-effort cleanup — don't block finalization on git state.
|
||||||
|
await TryCleanupWorktreeAsync(taskId, lists, settings, ct);
|
||||||
|
|
||||||
|
var sessionDir = Path.Combine(_rootDirectory, taskId);
|
||||||
|
if (Directory.Exists(sessionDir))
|
||||||
|
{
|
||||||
|
try { Directory.Delete(sessionDir, recursive: true); } catch { }
|
||||||
|
}
|
||||||
|
|
||||||
|
return count;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Extend `DiscardAsync` with the same cleanup**
|
||||||
|
|
||||||
|
Replace the body of `DiscardAsync` with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public async Task DiscardAsync(string taskId, CancellationToken ct)
|
||||||
|
{
|
||||||
|
var (tasks, lists, settings, ctx) = CreateRepos();
|
||||||
|
await using var __ = ctx;
|
||||||
|
|
||||||
|
var ok = await tasks.DiscardPlanningAsync(taskId, ct);
|
||||||
|
|
||||||
|
await TryCleanupWorktreeAsync(taskId, lists, settings, ct);
|
||||||
|
|
||||||
|
var sessionDir = Path.Combine(_rootDirectory, taskId);
|
||||||
|
if (Directory.Exists(sessionDir))
|
||||||
|
{
|
||||||
|
try { Directory.Delete(sessionDir, recursive: true); } catch { }
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!ok)
|
||||||
|
throw new InvalidOperationException($"Task {taskId} was not in Planning state; nothing to discard.");
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Add the `TryCleanupWorktreeAsync` helper**
|
||||||
|
|
||||||
|
Add this private method near the other helpers:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private async Task TryCleanupWorktreeAsync(
|
||||||
|
string taskId,
|
||||||
|
ListRepository lists,
|
||||||
|
AppSettingsRepository settings,
|
||||||
|
CancellationToken ct)
|
||||||
|
{
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var (tasks, _, _, ctx2) = CreateRepos();
|
||||||
|
await using var __ = ctx2;
|
||||||
|
|
||||||
|
var task = await tasks.GetByIdAsync(taskId, ct);
|
||||||
|
if (task is null) return;
|
||||||
|
|
||||||
|
var list = await lists.GetByIdAsync(task.ListId, ct);
|
||||||
|
var listWorkingDir = list?.WorkingDir;
|
||||||
|
if (string.IsNullOrEmpty(listWorkingDir) || !Directory.Exists(listWorkingDir)) return;
|
||||||
|
|
||||||
|
var appSettings = await settings.GetAsync(ct);
|
||||||
|
var worktreePath = WorktreePathFor(taskId, appSettings.WorktreeStrategy, appSettings.CentralWorktreeRoot, listWorkingDir);
|
||||||
|
var branchName = BranchNameFor(taskId);
|
||||||
|
|
||||||
|
if (Directory.Exists(worktreePath))
|
||||||
|
{
|
||||||
|
try { await _git.WorktreeRemoveAsync(listWorkingDir, worktreePath, force: true, ct); }
|
||||||
|
catch { /* best effort */ }
|
||||||
|
}
|
||||||
|
try { await _git.BranchDeleteAsync(listWorkingDir, branchName, force: true, ct); } catch { }
|
||||||
|
}
|
||||||
|
catch { /* best effort — never block finalize/discard */ }
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs
|
||||||
|
git commit -m "feat(worker): cleanup planning worktree and branch on finalize/discard"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 8: Update `WindowsTerminalPlanningLauncher`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Planning/WindowsTerminalPlanningLauncher.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Rewrite `LaunchStartAsync`**
|
||||||
|
|
||||||
|
Replace the full method body with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public Task LaunchStartAsync(PlanningSessionStartContext ctx, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
if (!Directory.Exists(ctx.WorkingDir))
|
||||||
|
throw new PlanningLaunchException($"Working directory does not exist: {ctx.WorkingDir}");
|
||||||
|
|
||||||
|
if (!File.Exists(ctx.Files.SystemPromptPath))
|
||||||
|
throw new PlanningLaunchException($"System prompt file not found: {ctx.Files.SystemPromptPath}");
|
||||||
|
if (!File.Exists(ctx.Files.InitialPromptPath))
|
||||||
|
throw new PlanningLaunchException($"Initial prompt file not found: {ctx.Files.InitialPromptPath}");
|
||||||
|
|
||||||
|
var resolvedWt = Resolve(_wtPath);
|
||||||
|
if (resolvedWt is null)
|
||||||
|
throw new PlanningLaunchException($"Windows Terminal not found: {_wtPath}");
|
||||||
|
|
||||||
|
var resolvedClaude = Resolve(_claudePath);
|
||||||
|
if (resolvedClaude is null)
|
||||||
|
throw new PlanningLaunchException($"claude executable not found: {_claudePath}");
|
||||||
|
|
||||||
|
var psi = new ProcessStartInfo
|
||||||
|
{
|
||||||
|
FileName = resolvedWt,
|
||||||
|
UseShellExecute = false,
|
||||||
|
CreateNoWindow = false,
|
||||||
|
};
|
||||||
|
|
||||||
|
psi.Environment["MAX_THINKING_TOKENS"] = "20000";
|
||||||
|
psi.Environment["CLAUDEDO_PLANNING_TOKEN"] = ctx.Token;
|
||||||
|
|
||||||
|
// Arg order: --allowedTools is variadic (space-separated). The positional
|
||||||
|
// prompt must follow a single-value flag, or it will be swallowed.
|
||||||
|
// --append-system-prompt-file serves as that buffer.
|
||||||
|
psi.ArgumentList.Add("-d");
|
||||||
|
psi.ArgumentList.Add(ctx.WorkingDir);
|
||||||
|
psi.ArgumentList.Add(resolvedClaude);
|
||||||
|
psi.ArgumentList.Add("--model");
|
||||||
|
psi.ArgumentList.Add(Model);
|
||||||
|
psi.ArgumentList.Add("--allowedTools");
|
||||||
|
psi.ArgumentList.Add(AllowedTools);
|
||||||
|
psi.ArgumentList.Add("--append-system-prompt-file");
|
||||||
|
psi.ArgumentList.Add(ctx.Files.SystemPromptPath);
|
||||||
|
psi.ArgumentList.Add(File.ReadAllText(ctx.Files.InitialPromptPath));
|
||||||
|
|
||||||
|
var proc = Process.Start(psi)
|
||||||
|
?? throw new PlanningLaunchException("Failed to start Windows Terminal process.");
|
||||||
|
|
||||||
|
return Task.CompletedTask;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Rewrite `LaunchResumeAsync`**
|
||||||
|
|
||||||
|
Replace the full method body with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public Task LaunchResumeAsync(PlanningSessionResumeContext ctx, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
if (!Directory.Exists(ctx.WorkingDir))
|
||||||
|
throw new PlanningLaunchException($"Working directory does not exist: {ctx.WorkingDir}");
|
||||||
|
|
||||||
|
var resolvedWt = Resolve(_wtPath);
|
||||||
|
if (resolvedWt is null)
|
||||||
|
throw new PlanningLaunchException($"Windows Terminal not found: {_wtPath}");
|
||||||
|
|
||||||
|
var resolvedClaude = Resolve(_claudePath);
|
||||||
|
if (resolvedClaude is null)
|
||||||
|
throw new PlanningLaunchException($"claude executable not found: {_claudePath}");
|
||||||
|
|
||||||
|
var psi = new ProcessStartInfo
|
||||||
|
{
|
||||||
|
FileName = resolvedWt,
|
||||||
|
UseShellExecute = false,
|
||||||
|
CreateNoWindow = false,
|
||||||
|
};
|
||||||
|
|
||||||
|
psi.Environment["CLAUDEDO_PLANNING_TOKEN"] = ctx.Token;
|
||||||
|
|
||||||
|
psi.ArgumentList.Add("-d");
|
||||||
|
psi.ArgumentList.Add(ctx.WorkingDir);
|
||||||
|
psi.ArgumentList.Add(resolvedClaude);
|
||||||
|
psi.ArgumentList.Add("--resume");
|
||||||
|
psi.ArgumentList.Add(ctx.ClaudeSessionId);
|
||||||
|
|
||||||
|
var proc = Process.Start(psi)
|
||||||
|
?? throw new PlanningLaunchException("Failed to start Windows Terminal process.");
|
||||||
|
|
||||||
|
return Task.CompletedTask;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Planning/WindowsTerminalPlanningLauncher.cs
|
||||||
|
git commit -m "feat(worker): launcher passes planning token via env, drops --mcp-config"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 9: Update DI wiring in `Program.cs`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Program.cs` (around line 59–62)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Update the registration**
|
||||||
|
|
||||||
|
Find:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
builder.Services.AddSingleton(sp =>
|
||||||
|
new PlanningSessionManager(
|
||||||
|
sp.GetRequiredService<IDbContextFactory<ClaudeDoDbContext>>(),
|
||||||
|
planningSessionsDir));
|
||||||
|
```
|
||||||
|
|
||||||
|
Replace with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
builder.Services.AddSingleton(sp =>
|
||||||
|
new PlanningSessionManager(
|
||||||
|
sp.GetRequiredService<IDbContextFactory<ClaudeDoDbContext>>(),
|
||||||
|
sp.GetRequiredService<GitService>(),
|
||||||
|
cfg,
|
||||||
|
planningSessionsDir));
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build full worker**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Program.cs
|
||||||
|
git commit -m "chore(worker): wire GitService and WorkerConfig into PlanningSessionManager DI"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 10: Fix existing tests (add git init, update constructor calls, drop McpConfigPath assertions)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `tests/ClaudeDo.Worker.Tests/Planning/PlanningSessionManagerTests.cs`
|
||||||
|
- Modify: `tests/ClaudeDo.Worker.Tests/Planning/PlanningEndToEndTests.cs`
|
||||||
|
- Modify: `tests/ClaudeDo.Worker.Tests/Planning/WindowsTerminalPlanningLauncherTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add a shared git-init helper**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Worker.Tests/Infrastructure/GitRepoFixture.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.Diagnostics;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.Infrastructure;
|
||||||
|
|
||||||
|
public static class GitRepoFixture
|
||||||
|
{
|
||||||
|
public static void InitRepoWithInitialCommit(string dir)
|
||||||
|
{
|
||||||
|
Directory.CreateDirectory(dir);
|
||||||
|
Run(dir, "init", "-b", "main");
|
||||||
|
Run(dir, "config", "user.email", "test@claudedo.local");
|
||||||
|
Run(dir, "config", "user.name", "test");
|
||||||
|
File.WriteAllText(Path.Combine(dir, "README.md"), "seed\n");
|
||||||
|
Run(dir, "add", "-A");
|
||||||
|
Run(dir, "commit", "-m", "chore: seed");
|
||||||
|
}
|
||||||
|
|
||||||
|
private static void Run(string cwd, params string[] args)
|
||||||
|
{
|
||||||
|
var psi = new ProcessStartInfo("git") { WorkingDirectory = cwd, RedirectStandardError = true, RedirectStandardOutput = true };
|
||||||
|
foreach (var a in args) psi.ArgumentList.Add(a);
|
||||||
|
var p = Process.Start(psi)!;
|
||||||
|
p.WaitForExit();
|
||||||
|
if (p.ExitCode != 0)
|
||||||
|
throw new InvalidOperationException($"git {string.Join(" ", args)} failed: {p.StandardError.ReadToEnd()}");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Update `PlanningSessionManagerTests` constructor and seed helper**
|
||||||
|
|
||||||
|
In `PlanningSessionManagerTests.cs`, find the constructor and add after `_rootDir = …;`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
_git = new ClaudeDo.Data.Git.GitService();
|
||||||
|
_cfg = new ClaudeDo.Worker.Config.WorkerConfig { CentralWorktreeRoot = Path.Combine(_rootDir, "central") };
|
||||||
|
_settingsRepo = new ClaudeDo.Data.Repositories.AppSettingsRepository(_ctx);
|
||||||
|
// Seed settings row so the manager can read strategy.
|
||||||
|
_settingsRepo.UpsertAsync(new ClaudeDo.Data.Models.AppSettingsEntity { Id = 1, WorktreeStrategy = "sibling" }).GetAwaiter().GetResult();
|
||||||
|
_sut = new PlanningSessionManager(_tasks, _lists, _settingsRepo, _git, _cfg, _rootDir);
|
||||||
|
```
|
||||||
|
|
||||||
|
Add three private fields to the class:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private readonly ClaudeDo.Data.Git.GitService _git;
|
||||||
|
private readonly ClaudeDo.Worker.Config.WorkerConfig _cfg;
|
||||||
|
private readonly ClaudeDo.Data.Repositories.AppSettingsRepository _settingsRepo;
|
||||||
|
```
|
||||||
|
|
||||||
|
Change `SeedListAsync` to init a git repo:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private async Task<(string listId, string workingDir)> SeedListAsync()
|
||||||
|
{
|
||||||
|
var listId = Guid.NewGuid().ToString();
|
||||||
|
var wd = Path.Combine(Path.GetTempPath(), $"cd_wd_{Guid.NewGuid():N}");
|
||||||
|
ClaudeDo.Worker.Tests.Infrastructure.GitRepoFixture.InitRepoWithInitialCommit(wd);
|
||||||
|
await _lists.AddAsync(new ListEntity
|
||||||
|
{
|
||||||
|
Id = listId,
|
||||||
|
Name = "Test",
|
||||||
|
WorkingDir = wd,
|
||||||
|
CreatedAt = DateTime.UtcNow,
|
||||||
|
});
|
||||||
|
return (listId, wd);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Update assertions in the existing `StartAsync_…` test**
|
||||||
|
|
||||||
|
The old test asserts `ctx.Files.McpConfigPath`. Replace with worktree-based assertions:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Assert.Equal(parent.Id, ctx.ParentTaskId);
|
||||||
|
Assert.Equal(ctx.WorktreePath, ctx.WorkingDir);
|
||||||
|
Assert.True(Directory.Exists(ctx.WorktreePath));
|
||||||
|
var mcpPath = Path.Combine(ctx.WorktreePath, ".mcp.json");
|
||||||
|
Assert.True(File.Exists(mcpPath));
|
||||||
|
Assert.True(File.Exists(Path.Combine(ctx.WorktreePath, ".claude", "settings.local.json")));
|
||||||
|
Assert.True(File.Exists(ctx.Files.SystemPromptPath));
|
||||||
|
Assert.True(File.Exists(ctx.Files.InitialPromptPath));
|
||||||
|
|
||||||
|
var mcp = await File.ReadAllTextAsync(mcpPath);
|
||||||
|
Assert.Contains("${CLAUDEDO_PLANNING_TOKEN}", mcp);
|
||||||
|
Assert.DoesNotContain(ctx.Token, mcp);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Update `PlanningEndToEndTests` SUT construction similarly**
|
||||||
|
|
||||||
|
Add the same fields + ctor arguments. Replace any `new PlanningSessionManager(tasks, lists, rootDir)` with `new PlanningSessionManager(tasks, lists, settingsRepo, git, cfg, rootDir)` and ensure the seeded working directory is git-initialized.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Update `WindowsTerminalPlanningLauncherTests`**
|
||||||
|
|
||||||
|
If the existing tests construct `PlanningSessionStartContext` manually, update to supply the new `Token`, `WorktreePath`, `BranchName` fields. Add an assertion that the test observes (via a fake `IPlanningTerminalLauncher`-level check or by verifying the psi after a refactor seam) that the env var is set.
|
||||||
|
|
||||||
|
If the existing launcher test only verifies behavior that's no longer directly testable (it spawns wt.exe), leave those tests as-is but ensure they still compile with the new ctor shape.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Run all planning tests**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj --filter "FullyQualifiedName~Planning"`
|
||||||
|
Expected: PASS for all tests that previously passed.
|
||||||
|
|
||||||
|
- [ ] **Step 7: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add tests/ClaudeDo.Worker.Tests/Planning/ tests/ClaudeDo.Worker.Tests/Infrastructure/GitRepoFixture.cs
|
||||||
|
git commit -m "test(worker): adapt planning tests to git-backed worktree flow"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 11: New tests — worktree creation, cleanup, self-heal, resume
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `tests/ClaudeDo.Worker.Tests/Planning/PlanningSessionManagerTests.cs` (append new tests)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing "worktree is removed on discard" test**
|
||||||
|
|
||||||
|
Append to the test class:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task DiscardAsync_RemovesWorktreeAndBranch()
|
||||||
|
{
|
||||||
|
var (listId, wd) = await SeedListAsync();
|
||||||
|
var parent = await SeedManualTaskAsync(listId);
|
||||||
|
|
||||||
|
var ctx = await _sut.StartAsync(parent.Id, CancellationToken.None);
|
||||||
|
Assert.True(Directory.Exists(ctx.WorktreePath));
|
||||||
|
|
||||||
|
await _sut.DiscardAsync(parent.Id, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.False(Directory.Exists(ctx.WorktreePath));
|
||||||
|
// branch deleted
|
||||||
|
var paths = await _git.ListWorktreePathsForBranchAsync(wd, ctx.BranchName);
|
||||||
|
Assert.Empty(paths);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run — expect PASS**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj --filter "DiscardAsync_RemovesWorktreeAndBranch"`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Add "non-git working dir errors" test**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task StartAsync_ThrowsWhenWorkingDirIsNotGitRepo()
|
||||||
|
{
|
||||||
|
var listId = Guid.NewGuid().ToString();
|
||||||
|
var wd = Path.Combine(Path.GetTempPath(), $"cd_nogit_{Guid.NewGuid():N}");
|
||||||
|
Directory.CreateDirectory(wd);
|
||||||
|
await _lists.AddAsync(new ListEntity { Id = listId, Name = "NoGit", WorkingDir = wd, CreatedAt = DateTime.UtcNow });
|
||||||
|
|
||||||
|
var t = await SeedManualTaskAsync(listId);
|
||||||
|
|
||||||
|
await Assert.ThrowsAsync<InvalidOperationException>(() => _sut.StartAsync(t.Id, CancellationToken.None));
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Run and expect PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Add self-heal test**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task StartAsync_SelfHealsWhenBranchAlreadyExists()
|
||||||
|
{
|
||||||
|
var (listId, wd) = await SeedListAsync();
|
||||||
|
var parent = await SeedManualTaskAsync(listId);
|
||||||
|
|
||||||
|
// Pre-create a colliding branch.
|
||||||
|
var branch = $"claudedo/planning/{parent.Id.Replace("-", "")}";
|
||||||
|
var head = await _git.RevParseHeadAsync(wd);
|
||||||
|
var procInfo = new System.Diagnostics.ProcessStartInfo("git") { WorkingDirectory = wd };
|
||||||
|
procInfo.ArgumentList.Add("branch");
|
||||||
|
procInfo.ArgumentList.Add(branch);
|
||||||
|
procInfo.ArgumentList.Add(head);
|
||||||
|
var p = System.Diagnostics.Process.Start(procInfo)!;
|
||||||
|
p.WaitForExit();
|
||||||
|
|
||||||
|
var ctx = await _sut.StartAsync(parent.Id, CancellationToken.None);
|
||||||
|
Assert.True(Directory.Exists(ctx.WorktreePath));
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Run and expect PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Add resume test**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task ResumeAsync_ReturnsContextWithTokenAndWorktree()
|
||||||
|
{
|
||||||
|
var (listId, wd) = await SeedListAsync();
|
||||||
|
var parent = await SeedManualTaskAsync(listId);
|
||||||
|
|
||||||
|
var startCtx = await _sut.StartAsync(parent.Id, CancellationToken.None);
|
||||||
|
|
||||||
|
// Simulate the claude session capturing its session id.
|
||||||
|
await _tasks.UpdatePlanningSessionIdAsync(parent.Id, "session-abc", CancellationToken.None);
|
||||||
|
|
||||||
|
var resumeCtx = await _sut.ResumeAsync(parent.Id, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.Equal(startCtx.Token, resumeCtx.Token);
|
||||||
|
Assert.Equal(startCtx.WorktreePath, resumeCtx.WorktreePath);
|
||||||
|
Assert.Equal("session-abc", resumeCtx.ClaudeSessionId);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Run and expect PASS. If `UpdatePlanningSessionIdAsync` doesn't exist, use whatever repository method captures the Claude session id in this codebase (search the repo for the existing pattern) and substitute; do **not** skip this step.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Run all planning tests**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj --filter "FullyQualifiedName~Planning"`
|
||||||
|
Expected: all PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 7: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add tests/ClaudeDo.Worker.Tests/Planning/PlanningSessionManagerTests.cs
|
||||||
|
git commit -m "test(worker): cover planning worktree lifecycle and self-heal"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 12: Manual end-to-end verification
|
||||||
|
|
||||||
|
**Files:** none (manual)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Build all projects**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj && dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Start Worker + UI, create a manual task on a list whose WorkingDir is a real git repo, hit "Start planning"**
|
||||||
|
|
||||||
|
Expected:
|
||||||
|
- A Windows Terminal opens with `claude` running in a worktree under `<parent-of-WorkingDir>\.claudedo-worktrees\planning\<taskId>` (or the central root if strategy=central).
|
||||||
|
- No trust prompt appears for the `claudedo` MCP server.
|
||||||
|
- Inside claude, `/mcp` lists `claudedo` as connected.
|
||||||
|
- Asking claude "create a subtask" invokes `mcp__claudedo__*` tools and the new child task appears in the UI.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Click Discard**
|
||||||
|
|
||||||
|
Expected:
|
||||||
|
- The worktree directory is gone; `git branch --list claudedo/planning/*` returns nothing; `~/.todo-app/sessions/<taskId>` is gone.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Repeat with Finalize** — same expected cleanup.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Close Windows Terminal mid-session, then "Resume"** — same worktree opens again with `--resume`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Deferred / follow-up
|
||||||
|
|
||||||
|
- **Defensive startup cleanup of orphaned planning worktrees.** Enumerate `.claudedo-worktrees/planning/*` (both sibling and central) and GC any whose session dir no longer exists. Ship as a follow-up plan if orphans become a real problem in practice.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Self-Review Notes
|
||||||
|
|
||||||
|
- **Spec coverage:** Every section in `docs/superpowers/specs/2026-04-24-planning-worktree-design.md` maps to a task above (data flow → Task 6; launcher → Task 8; cleanup → Task 7; self-heal → Task 6 + Task 11.4; non-git error → Task 11.3; resume → Task 7 + Task 11.5; trust prompt bypass → Task 5 + Task 6). The one spec item deferred is the defensive startup cleanup.
|
||||||
|
- **Placeholder scan:** One conditional in Task 11.5 ("use whatever repository method captures the Claude session id") — this is deliberate: the existing codebase has an accessor whose exact name depends on local conventions and it's faster for the engineer to grep than for me to guess wrong. Every other step has full code.
|
||||||
|
- **Type consistency:** `PlanningSessionStartContext.WorktreePath` and `ResumeContext.WorktreePath` both `string`. `BranchName` only on Start (Resume recomputes via `BranchNameFor`). `Token` on both. `Files.McpConfigPath` removed everywhere.
|
||||||
@@ -0,0 +1,897 @@
|
|||||||
|
# External MCP — CRUD Extensions Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Extend the always-on `ExternalMcpService` with full task CRUD plus tag management so a normal Claude CLI session can fully manage scope-creep tasks via MCP.
|
||||||
|
|
||||||
|
**Architecture:** Pure extension of the existing service. New repository helper for tag replacement; five new/extended `[McpServerTool]` methods. No DI changes (`TagRepository` is already registered for `TaskRepository`/`ListRepository`). Uses the same `X-ClaudeDo-Key` middleware already in place.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, EF Core (SQLite), `ModelContextProtocol.Server` (MCP SDK), xUnit.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Pre-flight
|
||||||
|
|
||||||
|
The test assembly `tests/ClaudeDo.Worker.Tests` currently fails to compile on `main` because of pre-existing in-progress work on `PlanningChainCoordinator` (stale `TaskRunner` / `WorkerHub` constructor calls in `QueueServiceTests.cs`, `QueueServiceSlotGuardTests.cs`, `PlanningHubTests.cs`). This is unrelated to this work and must NOT be fixed here.
|
||||||
|
|
||||||
|
Consequence: `dotnet test` cannot execute until that refactor lands. Each task's "Run test, verify it fails" step uses `dotnet build` of the **test csproj** to confirm only the new test's compile expectations, and `dotnet build` of the **production csproj** to confirm production code is correct. When the refactor lands, the engineer or user re-runs `dotnet test --filter "FullyQualifiedName~ExternalMcpServiceTests"` to validate the new tests for real.
|
||||||
|
|
||||||
|
Build commands used throughout (per the project memory note "use csproj, not .slnx, on .NET 8"):
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Data/ClaudeDo.Data.csproj
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File Map
|
||||||
|
|
||||||
|
| File | Change |
|
||||||
|
|---|---|
|
||||||
|
| `src/ClaudeDo.Data/Repositories/TaskRepository.cs` | Add `SetTagsAsync` (replace tag set, auto-create rows) |
|
||||||
|
| `src/ClaudeDo.Worker/External/ExternalMcpService.cs` | Inject `TagRepository`; extend `AddTask` with `tags`; add `UpdateTask`, `DeleteTask`, `SetTaskTags`, `ListTags` |
|
||||||
|
| `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs` | New test file with fakes mirroring `Planning/PlanningMcpServiceTests.cs` |
|
||||||
|
|
||||||
|
`TagRepository.GetAllAsync` already exists — no change needed there.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 1: `TaskRepository.SetTagsAsync`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Data/Repositories/TaskRepository.cs` (add new method inside the `#region Tags` block, after `RemoveTagAsync`)
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/Repositories/TaskRepositoryTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
Append to `tests/ClaudeDo.Worker.Tests/Repositories/TaskRepositoryTests.cs` (use the existing `MakeTask`/list-seed helpers from that file — match the pattern used in adjacent tests):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task SetTagsAsync_AttachesNewTagsAndCreatesMissingRows()
|
||||||
|
{
|
||||||
|
var listId = await CreateListAsync("L");
|
||||||
|
var task = MakeTask(listId, "t");
|
||||||
|
await _tasks.AddAsync(task);
|
||||||
|
|
||||||
|
await _tasks.SetTagsAsync(task.Id, new[] { "agent", "novel-tag" });
|
||||||
|
|
||||||
|
var tags = await _tasks.GetTagsAsync(task.Id);
|
||||||
|
Assert.Contains(tags, t => t.Name == "agent");
|
||||||
|
Assert.Contains(tags, t => t.Name == "novel-tag");
|
||||||
|
Assert.Equal(2, tags.Count);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task SetTagsAsync_ReplacesExistingTagSet()
|
||||||
|
{
|
||||||
|
var listId = await CreateListAsync("L");
|
||||||
|
var task = MakeTask(listId, "t");
|
||||||
|
await _tasks.AddAsync(task);
|
||||||
|
await _tasks.SetTagsAsync(task.Id, new[] { "agent" });
|
||||||
|
|
||||||
|
await _tasks.SetTagsAsync(task.Id, new[] { "manual" });
|
||||||
|
|
||||||
|
var tags = await _tasks.GetTagsAsync(task.Id);
|
||||||
|
Assert.Single(tags);
|
||||||
|
Assert.Equal("manual", tags[0].Name);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task SetTagsAsync_DeduplicatesCaseInsensitively()
|
||||||
|
{
|
||||||
|
var listId = await CreateListAsync("L");
|
||||||
|
var task = MakeTask(listId, "t");
|
||||||
|
await _tasks.AddAsync(task);
|
||||||
|
|
||||||
|
await _tasks.SetTagsAsync(task.Id, new[] { "agent", "AGENT", "Agent" });
|
||||||
|
|
||||||
|
var tags = await _tasks.GetTagsAsync(task.Id);
|
||||||
|
Assert.Single(tags);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task SetTagsAsync_EmptyListClearsAllTags()
|
||||||
|
{
|
||||||
|
var listId = await CreateListAsync("L");
|
||||||
|
var task = MakeTask(listId, "t");
|
||||||
|
await _tasks.AddAsync(task);
|
||||||
|
await _tasks.SetTagsAsync(task.Id, new[] { "agent" });
|
||||||
|
|
||||||
|
await _tasks.SetTagsAsync(task.Id, Array.Empty<string>());
|
||||||
|
|
||||||
|
Assert.Empty(await _tasks.GetTagsAsync(task.Id));
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj
|
||||||
|
```
|
||||||
|
Expected: compile error `CS1061: 'TaskRepository' does not contain a definition for 'SetTagsAsync'`. (Existing unrelated `CS7036` errors from `PlanningChainCoordinator` work also appear — ignore.)
|
||||||
|
|
||||||
|
- [ ] **Step 3: Write minimal implementation**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Data/Repositories/TaskRepository.cs`, inside `#region Tags`, after `RemoveTagAsync`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public async Task SetTagsAsync(string taskId, IReadOnlyList<string> tagNames, CancellationToken ct = default)
|
||||||
|
{
|
||||||
|
var task = await _context.Tasks.Include(t => t.Tags).FirstOrDefaultAsync(t => t.Id == taskId, ct);
|
||||||
|
if (task is null) return;
|
||||||
|
|
||||||
|
task.Tags.Clear();
|
||||||
|
|
||||||
|
foreach (var name in tagNames.Where(n => !string.IsNullOrWhiteSpace(n)).Distinct(StringComparer.OrdinalIgnoreCase))
|
||||||
|
{
|
||||||
|
var tag = await _context.Tags.FirstOrDefaultAsync(t => t.Name == name, ct);
|
||||||
|
if (tag is null)
|
||||||
|
{
|
||||||
|
tag = new TagEntity { Name = name };
|
||||||
|
_context.Tags.Add(tag);
|
||||||
|
}
|
||||||
|
task.Tags.Add(tag);
|
||||||
|
}
|
||||||
|
|
||||||
|
await _context.SaveChangesAsync(ct);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run test to verify it compiles + production build still passes**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Data/ClaudeDo.Data.csproj
|
||||||
|
```
|
||||||
|
Expected: `Build succeeded. 0 Error(s)`.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj 2>&1 | grep "TaskRepositoryTests" || echo "no errors in TaskRepositoryTests"
|
||||||
|
```
|
||||||
|
Expected: no errors specific to `TaskRepositoryTests` (assembly may still fail due to unrelated `PlanningChainCoordinator` issues).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Data/Repositories/TaskRepository.cs tests/ClaudeDo.Worker.Tests/Repositories/TaskRepositoryTests.cs
|
||||||
|
git commit -m "feat(data): add TaskRepository.SetTagsAsync for full tag-set replacement"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 2: New test file scaffolding for `ExternalMcpService`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs`
|
||||||
|
|
||||||
|
This task creates the shared test fakes and one trivial passing test. Subsequent tasks reuse the same fakes.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Inspect existing patterns**
|
||||||
|
|
||||||
|
Read `tests/ClaudeDo.Worker.Tests/Planning/PlanningMcpServiceTests.cs` for the `FakeHubContext`/`RecordingClientProxy` pattern and `tests/ClaudeDo.Worker.Tests/Services/QueueServiceTests.cs` for how to construct a real `QueueService` for tests (the same approach is used here — `ExternalMcpService` depends on it for `WakeQueue`/`RunNow`/`CancelTask`).
|
||||||
|
|
||||||
|
- [ ] **Step 2: Write the test scaffolding**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Worker.External;
|
||||||
|
using ClaudeDo.Worker.Hub;
|
||||||
|
using ClaudeDo.Worker.Services;
|
||||||
|
using ClaudeDo.Worker.Tests.Infrastructure;
|
||||||
|
using Microsoft.AspNetCore.SignalR;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.External;
|
||||||
|
|
||||||
|
file sealed class RecordingHubClients : IHubClients
|
||||||
|
{
|
||||||
|
public RecordingClientProxy Proxy { get; } = new();
|
||||||
|
public IClientProxy All => Proxy;
|
||||||
|
public IClientProxy AllExcept(IReadOnlyList<string> excludedConnectionIds) => Proxy;
|
||||||
|
public IClientProxy Client(string connectionId) => Proxy;
|
||||||
|
public IClientProxy Clients(IReadOnlyList<string> connectionIds) => Proxy;
|
||||||
|
public IClientProxy Group(string groupName) => Proxy;
|
||||||
|
public IClientProxy GroupExcept(string groupName, IReadOnlyList<string> excludedConnectionIds) => Proxy;
|
||||||
|
public IClientProxy Groups(IReadOnlyList<string> groupNames) => Proxy;
|
||||||
|
public IClientProxy User(string userId) => Proxy;
|
||||||
|
public IClientProxy Users(IReadOnlyList<string> userIds) => Proxy;
|
||||||
|
}
|
||||||
|
|
||||||
|
file sealed class RecordingClientProxy : IClientProxy
|
||||||
|
{
|
||||||
|
public List<(string Method, object?[] Args)> Calls { get; } = new();
|
||||||
|
public Task SendCoreAsync(string method, object?[] args, CancellationToken cancellationToken = default)
|
||||||
|
{
|
||||||
|
Calls.Add((method, args));
|
||||||
|
return Task.CompletedTask;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
file sealed class FakeHubContext : IHubContext<WorkerHub>
|
||||||
|
{
|
||||||
|
public RecordingHubClients RecordingClients { get; } = new();
|
||||||
|
public IHubClients Clients => RecordingClients;
|
||||||
|
public IGroupManager Groups => throw new NotImplementedException();
|
||||||
|
}
|
||||||
|
|
||||||
|
public sealed class ExternalMcpServiceTests : IDisposable
|
||||||
|
{
|
||||||
|
private readonly DbFixture _db = new();
|
||||||
|
private readonly ClaudeDoDbContext _ctx;
|
||||||
|
private readonly TaskRepository _tasks;
|
||||||
|
private readonly ListRepository _lists;
|
||||||
|
private readonly TagRepository _tags;
|
||||||
|
private readonly FakeHubContext _hub;
|
||||||
|
private readonly HubBroadcaster _broadcaster;
|
||||||
|
|
||||||
|
public ExternalMcpServiceTests()
|
||||||
|
{
|
||||||
|
_ctx = _db.CreateContext();
|
||||||
|
_tasks = new TaskRepository(_ctx);
|
||||||
|
_lists = new ListRepository(_ctx);
|
||||||
|
_tags = new TagRepository(_ctx);
|
||||||
|
_hub = new FakeHubContext();
|
||||||
|
_broadcaster = new HubBroadcaster(_hub);
|
||||||
|
}
|
||||||
|
|
||||||
|
public void Dispose() { _ctx.Dispose(); _db.Dispose(); }
|
||||||
|
|
||||||
|
private async Task<string> SeedListAsync(string name = "L")
|
||||||
|
{
|
||||||
|
var id = Guid.NewGuid().ToString();
|
||||||
|
await _lists.AddAsync(new ListEntity { Id = id, Name = name, CreatedAt = DateTime.UtcNow });
|
||||||
|
return id;
|
||||||
|
}
|
||||||
|
|
||||||
|
private async Task<TaskEntity> SeedTaskAsync(string listId, string title = "t", TaskStatus status = TaskStatus.Manual)
|
||||||
|
{
|
||||||
|
var task = new TaskEntity
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid().ToString(),
|
||||||
|
ListId = listId,
|
||||||
|
Title = title,
|
||||||
|
Status = status,
|
||||||
|
CreatedAt = DateTime.UtcNow,
|
||||||
|
CommitType = "chore",
|
||||||
|
};
|
||||||
|
await _tasks.AddAsync(task);
|
||||||
|
return task;
|
||||||
|
}
|
||||||
|
|
||||||
|
// QueueService is needed by ExternalMcpService's constructor. For tests that
|
||||||
|
// only exercise UpdateTask / DeleteTask / SetTaskTags / ListTags / ListTags,
|
||||||
|
// we never call its WakeQueue/RunNow/CancelTask paths, so a real QueueService
|
||||||
|
// built with the same approach used in QueueServiceTests is sufficient.
|
||||||
|
private ExternalMcpService BuildSut(QueueService queue) =>
|
||||||
|
new(_tasks, _lists, queue, _broadcaster, _tags);
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task SeededListAndTask_AreRetrievable()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
var task = await SeedTaskAsync(listId);
|
||||||
|
Assert.NotNull(await _tasks.GetByIdAsync(task.Id));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
The trivial `SeededListAndTask_AreRetrievable` test exists to confirm the scaffolding compiles and the fakes work, without depending on `ExternalMcpService` itself yet.
|
||||||
|
|
||||||
|
Note: `BuildSut` uses a 5-argument constructor signature that does not exist yet — this matches the future signature added in Task 3. The compiler will accept this method only after Task 3.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Verify the file references resolve**
|
||||||
|
|
||||||
|
Build the test csproj and check for errors specific to `ExternalMcpServiceTests`:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj 2>&1 | grep "ExternalMcpServiceTests"
|
||||||
|
```
|
||||||
|
Expected output: only one error referring to the 5-arg `ExternalMcpService` constructor (resolved in Task 3). No missing-namespace or syntax errors.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs
|
||||||
|
git commit -m "test(external): scaffold ExternalMcpServiceTests"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 3: Inject `TagRepository` into `ExternalMcpService` + add `ListTags`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/External/ExternalMcpService.cs`
|
||||||
|
- Modify: `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs`
|
||||||
|
|
||||||
|
Smallest possible change to unblock everything else: take the new dependency and ship the simplest tool first.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test**
|
||||||
|
|
||||||
|
Add to `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs`. The `BuildSut` helper is defined in Task 2; tests construct `QueueService` the same way `QueueServiceTests.cs` does (look there for the exact constructor argument list and adopt it verbatim):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task ListTags_ReturnsSeededAndCustomTags()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
var task = await SeedTaskAsync(listId);
|
||||||
|
await _tasks.SetTagsAsync(task.Id, new[] { "agent", "custom-tag" });
|
||||||
|
|
||||||
|
using var queue = QueueServiceFactory.Create(_ctx, _broadcaster); // see helper note below
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
var tags = await sut.ListTags(CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.Contains(tags, t => t.Name == "agent");
|
||||||
|
Assert.Contains(tags, t => t.Name == "custom-tag");
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
If a `QueueServiceFactory` helper does not already exist in the test project, inline the construction by mirroring the setup found in `tests/ClaudeDo.Worker.Tests/Services/QueueServiceTests.cs` (it builds `QueueService` directly with `IDbContextFactory`, `HubBroadcaster`, fake claude process, etc.). Do NOT call `StartAsync`; just construct and dispose.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj 2>&1 | grep -E "ExternalMcpService|ExternalMcpServiceTests"
|
||||||
|
```
|
||||||
|
Expected: errors about the 5-arg constructor and `ListTags` not existing.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Worker/External/ExternalMcpService.cs`:
|
||||||
|
|
||||||
|
1. Add `TagRepository` field and constructor parameter:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private readonly TaskRepository _tasks;
|
||||||
|
private readonly ListRepository _lists;
|
||||||
|
private readonly QueueService _queue;
|
||||||
|
private readonly HubBroadcaster _broadcaster;
|
||||||
|
private readonly TagRepository _tags;
|
||||||
|
|
||||||
|
public ExternalMcpService(
|
||||||
|
TaskRepository tasks,
|
||||||
|
ListRepository lists,
|
||||||
|
QueueService queue,
|
||||||
|
HubBroadcaster broadcaster,
|
||||||
|
TagRepository tags)
|
||||||
|
{
|
||||||
|
_tasks = tasks;
|
||||||
|
_lists = lists;
|
||||||
|
_queue = queue;
|
||||||
|
_broadcaster = broadcaster;
|
||||||
|
_tags = tags;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
2. Add a tag DTO above the class (next to `TaskListDto`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public sealed record TagDto(long Id, string Name);
|
||||||
|
```
|
||||||
|
|
||||||
|
3. Add the new tool method (place at the end of the class, before `ToDto`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[McpServerTool, Description("List all known tags. Useful for discovering existing tag names (including 'agent' which marks tasks for auto-execution) before tagging.")]
|
||||||
|
public async Task<IReadOnlyList<TagDto>> ListTags(CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
var tags = await _tags.GetAllAsync(cancellationToken);
|
||||||
|
return tags.Select(t => new TagDto(t.Id, t.Name)).ToList();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Verify production build + new test compiles**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
```
|
||||||
|
Expected: `Build succeeded. 0 Error(s)`.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj 2>&1 | grep "ExternalMcpService"
|
||||||
|
```
|
||||||
|
Expected: no errors mentioning `ExternalMcpService` or `ListTags`. (Unrelated `PlanningChainCoordinator` errors persist.)
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/ExternalMcpService.cs tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs
|
||||||
|
git commit -m "feat(mcp/external): add ListTags + inject TagRepository"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 4: Extend `AddTask` to accept `tags`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/External/ExternalMcpService.cs` (`AddTask` method)
|
||||||
|
- Modify: `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
Append to `ExternalMcpServiceTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task AddTask_WithTags_AttachesTags()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
using var queue = /* same construction as ListTags test */;
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
var dto = await sut.AddTask(
|
||||||
|
listId, "scope-creep handoff", "desc", "claude-cli",
|
||||||
|
queueImmediately: false,
|
||||||
|
tags: new[] { "agent", "custom" },
|
||||||
|
CancellationToken.None);
|
||||||
|
|
||||||
|
var tags = await _tasks.GetTagsAsync(dto.Id);
|
||||||
|
Assert.Contains(tags, t => t.Name == "agent");
|
||||||
|
Assert.Contains(tags, t => t.Name == "custom");
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task AddTask_NullTags_BehavesAsBefore()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
using var queue = /* same construction */;
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
var dto = await sut.AddTask(
|
||||||
|
listId, "no tags", null, "claude-cli",
|
||||||
|
queueImmediately: false, tags: null, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.Empty(await _tasks.GetTagsAsync(dto.Id));
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
(Replace the `/* same construction */` placeholder with the actual `QueueService` construction used in Task 3 — repeat the code, do not extract.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj 2>&1 | grep "AddTask"
|
||||||
|
```
|
||||||
|
Expected: error that `AddTask` does not accept a 7th `tags` parameter.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement**
|
||||||
|
|
||||||
|
Replace the existing `AddTask` method in `ExternalMcpService.cs` with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[McpServerTool, Description("Create a new task in the given list. Set queueImmediately=true to enqueue it for agent execution. Optional tags are attached on creation; missing tag names auto-create.")]
|
||||||
|
public async Task<TaskDto> AddTask(
|
||||||
|
string listId,
|
||||||
|
string title,
|
||||||
|
string? description,
|
||||||
|
string createdBy,
|
||||||
|
bool queueImmediately,
|
||||||
|
IReadOnlyList<string>? tags,
|
||||||
|
CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
if (string.IsNullOrWhiteSpace(listId))
|
||||||
|
throw new InvalidOperationException("listId is required.");
|
||||||
|
if (string.IsNullOrWhiteSpace(title))
|
||||||
|
throw new InvalidOperationException("title is required.");
|
||||||
|
if (string.IsNullOrWhiteSpace(createdBy))
|
||||||
|
throw new InvalidOperationException("createdBy is required.");
|
||||||
|
|
||||||
|
var list = await _lists.GetByIdAsync(listId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"List {listId} not found.");
|
||||||
|
|
||||||
|
var entity = new TaskEntity
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid().ToString(),
|
||||||
|
ListId = listId,
|
||||||
|
Title = title,
|
||||||
|
Description = description,
|
||||||
|
Status = queueImmediately ? TaskStatus.Queued : TaskStatus.Manual,
|
||||||
|
CreatedAt = DateTime.UtcNow,
|
||||||
|
CommitType = list.DefaultCommitType,
|
||||||
|
CreatedBy = createdBy,
|
||||||
|
};
|
||||||
|
await _tasks.AddAsync(entity, cancellationToken);
|
||||||
|
|
||||||
|
if (tags is not null && tags.Count > 0)
|
||||||
|
await _tasks.SetTagsAsync(entity.Id, tags, cancellationToken);
|
||||||
|
|
||||||
|
if (queueImmediately)
|
||||||
|
_queue.WakeQueue();
|
||||||
|
|
||||||
|
await _broadcaster.TaskUpdated(entity.Id);
|
||||||
|
return ToDto(entity);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Verify production build**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
```
|
||||||
|
Expected: `Build succeeded. 0 Error(s)`.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/ExternalMcpService.cs tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs
|
||||||
|
git commit -m "feat(mcp/external): AddTask accepts tags on creation"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 5: `UpdateTask`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/External/ExternalMcpService.cs`
|
||||||
|
- Modify: `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
Append to `ExternalMcpServiceTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task UpdateTask_PatchesNonNullFieldsOnly()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
var task = await SeedTaskAsync(listId, "old title");
|
||||||
|
using var queue = /* same construction */;
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
var dto = await sut.UpdateTask(task.Id, "new title", null, null, null, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.Equal("new title", dto.Title);
|
||||||
|
var loaded = await _tasks.GetByIdAsync(task.Id);
|
||||||
|
Assert.Equal("new title", loaded!.Title);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task UpdateTask_TagsReplaceFullSet()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
var task = await SeedTaskAsync(listId);
|
||||||
|
await _tasks.SetTagsAsync(task.Id, new[] { "agent" });
|
||||||
|
using var queue = /* same construction */;
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
await sut.UpdateTask(task.Id, null, null, null, new[] { "manual" }, CancellationToken.None);
|
||||||
|
|
||||||
|
var tags = await _tasks.GetTagsAsync(task.Id);
|
||||||
|
Assert.Single(tags);
|
||||||
|
Assert.Equal("manual", tags[0].Name);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task UpdateTask_OnRunning_Throws()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
var task = await SeedTaskAsync(listId, status: TaskStatus.Running);
|
||||||
|
using var queue = /* same construction */;
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
||||||
|
sut.UpdateTask(task.Id, "x", null, null, null, CancellationToken.None));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task UpdateTask_NotFound_Throws()
|
||||||
|
{
|
||||||
|
using var queue = /* same construction */;
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
||||||
|
sut.UpdateTask("does-not-exist", "x", null, null, null, CancellationToken.None));
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj 2>&1 | grep "UpdateTask"
|
||||||
|
```
|
||||||
|
Expected: errors that `UpdateTask` does not exist on `ExternalMcpService`.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement**
|
||||||
|
|
||||||
|
Add to `ExternalMcpService.cs` (after `AddTask`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[McpServerTool, Description("Update an existing task's title, description, commit type, and/or tags. Pass null to leave a field unchanged. Tags are replaced as a full set when non-null. Refuses if the task is currently Running.")]
|
||||||
|
public async Task<TaskDto> UpdateTask(
|
||||||
|
string taskId,
|
||||||
|
string? title,
|
||||||
|
string? description,
|
||||||
|
string? commitType,
|
||||||
|
IReadOnlyList<string>? tags,
|
||||||
|
CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
var task = await _tasks.GetByIdAsync(taskId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"Task {taskId} not found.");
|
||||||
|
if (task.Status == TaskStatus.Running)
|
||||||
|
throw new InvalidOperationException("Cannot update a running task. Cancel it first.");
|
||||||
|
|
||||||
|
if (title is not null) task.Title = title;
|
||||||
|
if (description is not null) task.Description = description;
|
||||||
|
if (commitType is not null) task.CommitType = commitType;
|
||||||
|
await _tasks.UpdateAsync(task, cancellationToken);
|
||||||
|
|
||||||
|
if (tags is not null)
|
||||||
|
await _tasks.SetTagsAsync(taskId, tags, cancellationToken);
|
||||||
|
|
||||||
|
var reload = (await _tasks.GetByIdAsync(taskId, cancellationToken))!;
|
||||||
|
await _broadcaster.TaskUpdated(taskId);
|
||||||
|
return ToDto(reload);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Verify production build**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
```
|
||||||
|
Expected: `Build succeeded. 0 Error(s)`.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/ExternalMcpService.cs tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs
|
||||||
|
git commit -m "feat(mcp/external): add UpdateTask for content/tag patching"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 6: `DeleteTask`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/External/ExternalMcpService.cs`
|
||||||
|
- Modify: `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
Append to `ExternalMcpServiceTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task DeleteTask_RemovesTaskAndTagJoins()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
var task = await SeedTaskAsync(listId);
|
||||||
|
await _tasks.SetTagsAsync(task.Id, new[] { "agent" });
|
||||||
|
using var queue = /* same construction */;
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
await sut.DeleteTask(task.Id, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.Null(await _tasks.GetByIdAsync(task.Id));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task DeleteTask_OnRunning_Throws()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
var task = await SeedTaskAsync(listId, status: TaskStatus.Running);
|
||||||
|
using var queue = /* same construction */;
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
||||||
|
sut.DeleteTask(task.Id, CancellationToken.None));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task DeleteTask_NotFound_Throws()
|
||||||
|
{
|
||||||
|
using var queue = /* same construction */;
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
||||||
|
sut.DeleteTask("does-not-exist", CancellationToken.None));
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj 2>&1 | grep "DeleteTask"
|
||||||
|
```
|
||||||
|
Expected: errors that `DeleteTask` does not exist on `ExternalMcpService`.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement**
|
||||||
|
|
||||||
|
Add to `ExternalMcpService.cs` (after `UpdateTask`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[McpServerTool, Description("Delete a task. Refuses if the task is currently Running — cancel it first.")]
|
||||||
|
public async Task DeleteTask(string taskId, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
var task = await _tasks.GetByIdAsync(taskId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"Task {taskId} not found.");
|
||||||
|
if (task.Status == TaskStatus.Running)
|
||||||
|
throw new InvalidOperationException("Cannot delete a running task. Cancel it first.");
|
||||||
|
|
||||||
|
await _tasks.DeleteAsync(taskId, cancellationToken);
|
||||||
|
await _broadcaster.TaskUpdated(taskId);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Verify production build**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
```
|
||||||
|
Expected: `Build succeeded. 0 Error(s)`.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/ExternalMcpService.cs tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs
|
||||||
|
git commit -m "feat(mcp/external): add DeleteTask"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 7: `SetTaskTags`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/External/ExternalMcpService.cs`
|
||||||
|
- Modify: `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
Append to `ExternalMcpServiceTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task SetTaskTags_ReplacesTagSetAndBroadcasts()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
var task = await SeedTaskAsync(listId);
|
||||||
|
await _tasks.SetTagsAsync(task.Id, new[] { "agent" });
|
||||||
|
using var queue = /* same construction */;
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
var dto = await sut.SetTaskTags(task.Id, new[] { "manual" }, CancellationToken.None);
|
||||||
|
|
||||||
|
var tags = await _tasks.GetTagsAsync(task.Id);
|
||||||
|
Assert.Single(tags);
|
||||||
|
Assert.Equal("manual", tags[0].Name);
|
||||||
|
Assert.Contains(_hub.RecordingClients.Proxy.Calls,
|
||||||
|
c => c.Method == "TaskUpdated" && (string)c.Args[0]! == task.Id);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task SetTaskTags_OnRunning_Throws()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
var task = await SeedTaskAsync(listId, status: TaskStatus.Running);
|
||||||
|
using var queue = /* same construction */;
|
||||||
|
var sut = BuildSut(queue);
|
||||||
|
|
||||||
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
||||||
|
sut.SetTaskTags(task.Id, new[] { "manual" }, CancellationToken.None));
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj 2>&1 | grep "SetTaskTags"
|
||||||
|
```
|
||||||
|
Expected: errors that `SetTaskTags` does not exist.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement**
|
||||||
|
|
||||||
|
Add to `ExternalMcpService.cs` (after `DeleteTask`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[McpServerTool, Description("Replace the full tag set on an existing task. Missing tag names auto-create. Refuses if the task is Running.")]
|
||||||
|
public async Task<TaskDto> SetTaskTags(
|
||||||
|
string taskId,
|
||||||
|
IReadOnlyList<string> tags,
|
||||||
|
CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
var task = await _tasks.GetByIdAsync(taskId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"Task {taskId} not found.");
|
||||||
|
if (task.Status == TaskStatus.Running)
|
||||||
|
throw new InvalidOperationException("Cannot retag a running task. Cancel it first.");
|
||||||
|
|
||||||
|
await _tasks.SetTagsAsync(taskId, tags, cancellationToken);
|
||||||
|
var reload = (await _tasks.GetByIdAsync(taskId, cancellationToken))!;
|
||||||
|
await _broadcaster.TaskUpdated(taskId);
|
||||||
|
return ToDto(reload);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Verify production build**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
```
|
||||||
|
Expected: `Build succeeded. 0 Error(s)`.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/ExternalMcpService.cs tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs
|
||||||
|
git commit -m "feat(mcp/external): add SetTaskTags"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 8: Final verification + docs touch
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/CLAUDE.md` (one-line update reflecting the new tools)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Full production build**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
dotnet build src/ClaudeDo.Data/ClaudeDo.Data.csproj
|
||||||
|
```
|
||||||
|
Expected: both succeed with 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Update Worker CLAUDE.md**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Worker/CLAUDE.md`, locate the existing line near the bottom of the file describing external MCP tools (search for `ExternalMcpService` or `External/`). If a list of tools is already there, append the new tool names: `UpdateTask`, `DeleteTask`, `SetTaskTags`, `ListTags`. If no such line exists, add one short line under an existing structural section, for example under "Architecture":
|
||||||
|
|
||||||
|
```markdown
|
||||||
|
- **External/ExternalMcpService** — always-on MCP tools for general Claude sessions: `ListTaskLists`, `ListTasks`, `GetTask`, `AddTask` (with tags), `UpdateTask`, `UpdateTaskStatus`, `SetTaskTags`, `ListTags`, `DeleteTask`, `RunTaskNow`, `CancelTask`. Auth via optional `X-ClaudeDo-Key` header.
|
||||||
|
```
|
||||||
|
|
||||||
|
If the file already has a similar line — replace it; do not duplicate.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Verify the full test assembly state is unchanged**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj 2>&1 | grep -E "error CS" | grep -v "PlanningChainCoordinator\|TaskRunner.*chain\|WorkerHub.*planningChain"
|
||||||
|
```
|
||||||
|
Expected: empty output (every remaining error must be one of the pre-existing `PlanningChainCoordinator`-related errors and nothing new).
|
||||||
|
|
||||||
|
- [ ] **Step 4: When the unrelated refactor lands, run the new tests**
|
||||||
|
|
||||||
|
(Defer to whoever lands the `PlanningChainCoordinator` refactor — they should run:)
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj --filter "FullyQualifiedName~ExternalMcpServiceTests|FullyQualifiedName~TaskRepositoryTests.SetTagsAsync"
|
||||||
|
```
|
||||||
|
Expected: all new tests green.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/CLAUDE.md
|
||||||
|
git commit -m "docs(worker): document new external MCP tools"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Self-review
|
||||||
|
|
||||||
|
**Spec coverage:**
|
||||||
|
- `AddTask` extension with tags → Task 4 ✓
|
||||||
|
- `UpdateTask` → Task 5 ✓
|
||||||
|
- `DeleteTask` → Task 6 ✓
|
||||||
|
- `SetTaskTags` → Task 7 ✓
|
||||||
|
- `ListTags` → Task 3 ✓
|
||||||
|
- `TaskRepository.SetTagsAsync` → Task 1 ✓
|
||||||
|
- Auth (no change) → out of scope, called out in pre-flight ✓
|
||||||
|
- Tests for each tool → Tasks 1, 3-7 ✓
|
||||||
|
- Docs touch → Task 8 ✓
|
||||||
|
|
||||||
|
**Placeholder scan:** The phrase `/* same construction */` in tasks 4–7 is intentional — the engineer fills it in by mirroring the `QueueService` construction in Task 3 (which itself mirrors `QueueServiceTests.cs`). All other placeholders eliminated. No "TBD".
|
||||||
|
|
||||||
|
**Type consistency:**
|
||||||
|
- `IReadOnlyList<string>` for tag inputs everywhere ✓
|
||||||
|
- `TaskDto` returned by `AddTask`, `UpdateTask`, `SetTaskTags` ✓
|
||||||
|
- `TagDto(long Id, string Name)` consistent across `ListTags` ✓
|
||||||
|
- Constructor signature `(TaskRepository, ListRepository, QueueService, HubBroadcaster, TagRepository)` consistent between Task 3 implementation and Task 2 scaffold's `BuildSut` call ✓
|
||||||
|
- Method `TaskRepository.SetTagsAsync(string, IReadOnlyList<string>, CancellationToken)` consistent with all callers ✓
|
||||||
|
|
||||||
|
No issues found.
|
||||||
@@ -0,0 +1,225 @@
|
|||||||
|
# Session Prompts — Worker State & Queue Consolidation Slices 2–6
|
||||||
|
|
||||||
|
Paste-ready prompts for each remaining slice. Run **one slice per session** so the diff stays reviewable and tests stay green between commits. Spec lives at `docs/superpowers/specs/2026-04-27-worker-state-and-queue-consolidation-design.md` — reference it when the prompt asks.
|
||||||
|
|
||||||
|
**Common ground rules** (carry across all slices):
|
||||||
|
|
||||||
|
- Direct on `main`, one commit per slice, conventional commit messages.
|
||||||
|
- Build green (`dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj` + Data + Ui) before commit.
|
||||||
|
- Pre-existing test errors (TaskRunner/WorkerHub constructor drift in 4 test files) are **not** in scope to fix — they exist on `main` already. New compile errors my changes introduce ARE in scope.
|
||||||
|
- No drive-by refactors outside the slice's stated scope.
|
||||||
|
- New files must follow existing naming/folder conventions; legacy enum values stay until Slice 6.
|
||||||
|
- After each slice, update `~/.claude/projects/C--Private-ClaudeDo/memory/` if I learn something durable about the codebase.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Slice 2 — `TaskStateService` (centralized state machine)
|
||||||
|
|
||||||
|
**Prompt to paste into a fresh session:**
|
||||||
|
|
||||||
|
> Slice 2 of the worker state consolidation refactor. Spec: `docs/superpowers/specs/2026-04-27-worker-state-and-queue-consolidation-design.md` (sections 2 and 8). Slice 1 already landed (commit 7b737e6) — `TaskStatus` has `Idle`/`Cancelled`, `PlanningPhase` enum exists, `BlockedByTaskId` field exists. Legacy enum values still around.
|
||||||
|
>
|
||||||
|
> **Goal:** introduce `Worker/State/ITaskStateService` + `TaskStateService` as the single component that mutates `Status`, `PlanningPhase`, `BlockedByTaskId`. Migrate every existing caller. Mark repo `Mark*Async` helpers `internal`.
|
||||||
|
>
|
||||||
|
> **Public surface (verbatim from spec):**
|
||||||
|
> ```csharp
|
||||||
|
> Task<TransitionResult> EnqueueAsync(string taskId, CancellationToken ct);
|
||||||
|
> Task<TransitionResult> StartRunningAsync(string taskId, DateTime startedAt, CancellationToken ct);
|
||||||
|
> Task<TransitionResult> CompleteAsync(string taskId, DateTime finishedAt, string? result, CancellationToken ct);
|
||||||
|
> Task<TransitionResult> FailAsync(string taskId, DateTime finishedAt, string? error, CancellationToken ct);
|
||||||
|
> Task<TransitionResult> CancelAsync(string taskId, DateTime finishedAt, CancellationToken ct);
|
||||||
|
> Task<TransitionResult> ResetToIdleAsync(string taskId, CancellationToken ct);
|
||||||
|
> Task<TransitionResult> StartPlanningAsync(string parentId, CancellationToken ct);
|
||||||
|
> Task<TransitionResult> FinalizePlanningAsync(string parentId, CancellationToken ct);
|
||||||
|
> Task<TransitionResult> BlockOnAsync(string taskId, string predecessorTaskId, CancellationToken ct);
|
||||||
|
> Task<TransitionResult> UnblockAsync(string taskId, CancellationToken ct);
|
||||||
|
> Task<int> RecoverStaleRunningAsync(string reason, CancellationToken ct);
|
||||||
|
> ```
|
||||||
|
>
|
||||||
|
> **Allowed transition table:** see spec §2. Reject invalid transitions with `TransitionResult(false, "<reason>")` — no exceptions. Each transition is one atomic `ExecuteUpdate` with `WHERE Status = <expected>` for TOCTOU-freedom.
|
||||||
|
>
|
||||||
|
> **Side effects after successful DB write** (do these inside the service so callers don't need to remember):
|
||||||
|
> - On any `→ Queued`: call `_queue.WakeQueue()` directly for now (Slice 3 will replace with `IQueueWaker`). Inject `QueueService` lazily via `Func<QueueService>` to break the DI cycle if needed.
|
||||||
|
> - On any successful transition: `_broadcaster.TaskUpdated(taskId)`.
|
||||||
|
> - On `Done`/`Failed`/`Cancelled` for a child task: invoke `_chain.OnChildFinishedAsync(taskId, finalStatus, ct)`. If it returns a next-task-id, call `UnblockAsync` on it. Then run `_repo.TryCompleteParentAsync(parentId, ct)`.
|
||||||
|
>
|
||||||
|
> **Important:** `BlockOnAsync` and `UnblockAsync` should write `BlockedByTaskId` directly. `EnqueueAsync` for a Planning child should keep `BlockedByTaskId` null when it's the head of the chain. The chain coordinator will compose these calls in Slice 4 — for now just expose the API.
|
||||||
|
>
|
||||||
|
> **Caller migration (mechanical — preserve current behavior):**
|
||||||
|
> - `TaskRunner.HandleSuccess` → replace `taskRepo.MarkDoneAsync` + `TryCompleteParentAsync` + `_chain.OnChildFinishedAsync` block with a single `_state.CompleteAsync(taskId, finishedAt, result, CancellationToken.None)`.
|
||||||
|
> - `TaskRunner.HandleFailure` → `_state.FailAsync(taskId, finishedAt, errorMarkdown, CancellationToken.None)`.
|
||||||
|
> - `TaskRunner.MarkFailed` (early-fail path) → same.
|
||||||
|
> - `TaskRunner.RunAsync` start of run → `_state.StartRunningAsync(taskId, startedAt, ct)`.
|
||||||
|
> - `StaleTaskRecovery.StartAsync` → `_state.RecoverStaleRunningAsync("worker restart", ct)`.
|
||||||
|
> - `TaskResetService.ResetAsync` → `_state.ResetToIdleAsync(taskId, ct)` for the status flip; service keeps owning worktree cleanup.
|
||||||
|
> - `PlanningSessionManager.StartAsync` (the `SetPlanningStartedAsync` call) → `_state.StartPlanningAsync(parentId, ct)`. The manager still owns token/session-dir setup; only the status flip moves.
|
||||||
|
> - `PlanningChainCoordinator.OnChildFinishedAsync` (the `next.Status = TaskStatus.Queued` write) → keep its existing logic but use `_state.UnblockAsync(next.Id, ct)` for the actual write. The Slice 4 rewrite finishes the rest.
|
||||||
|
> - `ExternalMcpService.UpdateTaskStatus` (status flip in the Queued case) → `_state.EnqueueAsync(taskId, ct)`. The Manual case stays as-is until Slice 6 since `Manual` is still a valid legacy value.
|
||||||
|
>
|
||||||
|
> **Repo helpers to mark `internal`:** `MarkRunningAsync`, `MarkDoneAsync`, `MarkFailedAsync`, `FlipAllRunningToFailedAsync`. Verify nothing outside `ClaudeDo.Worker.State` calls them after migration. (`Worker.Tests` may need `InternalsVisibleTo` — add it if so.)
|
||||||
|
>
|
||||||
|
> **DI wiring:** register `TaskStateService` as Singleton in `Program.cs` for both the main app and the external-MCP app. The service holds no per-request state.
|
||||||
|
>
|
||||||
|
> **Tests:** new file `tests/ClaudeDo.Worker.Tests/State/TaskStateServiceTests.cs`. At minimum:
|
||||||
|
> - Happy path for each transition (verify DB state + side-effect mocks invoked).
|
||||||
|
> - Reject path for each invalid transition (verify result + DB unchanged).
|
||||||
|
> - Concurrency: two parallel `StartRunningAsync` for the same `Queued` task → exactly one returns `Ok=true`.
|
||||||
|
> - Mock or fake the broadcaster, queue, and chain-coordinator dependencies. Use real SQLite for the DB (existing test pattern).
|
||||||
|
>
|
||||||
|
> Build all projects, run the worker test project (the 4 pre-existing constructor-drift errors are out of scope — but my changes shouldn't add new errors), commit as `refactor(worker/state): introduce TaskStateService and route mutations through it`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Slice 3 — `IQueueWaker` + `IQueuePicker`
|
||||||
|
|
||||||
|
**Prompt to paste into a fresh session:**
|
||||||
|
|
||||||
|
> Slice 3 of the worker state consolidation refactor. Spec: `docs/superpowers/specs/2026-04-27-worker-state-and-queue-consolidation-design.md` (section 3). Slices 1 and 2 already landed.
|
||||||
|
>
|
||||||
|
> **Goal:** extract queue-wake and queue-pick from `QueueService` and `TaskRepository` into dedicated single-responsibility components. Make wakes automatic.
|
||||||
|
>
|
||||||
|
> **New components in `Worker/Queue/`:**
|
||||||
|
> - `IQueueWaker` (interface, `void Wake()`). Backed by `QueueWaker` singleton holding the existing `SemaphoreSlim`. Inject into `TaskStateService` (replaces the direct `QueueService` ref from Slice 2) and into `QueueService` itself.
|
||||||
|
> - `IQueuePicker` with `Task<TaskEntity?> ClaimNextAsync(DateTime now, CancellationToken ct)`. Implementation `QueuePicker` moves the raw SQL out of `TaskRepository.GetNextQueuedAgentTaskAsync` and **adds a `blocked_by_task_id IS NULL` filter to the WHERE clause**. Order stays `sort_order ASC, created_at ASC` (verify the existing query — add ORDER BY if missing). Atomic `UPDATE … RETURNING` flips `Queued → Running` and writes `started_at`.
|
||||||
|
>
|
||||||
|
> **Caller updates:**
|
||||||
|
> - `TaskStateService` swaps its `Func<QueueService>` for `IQueueWaker`. The `→ Queued` side-effect now calls `_waker.Wake()`.
|
||||||
|
> - `QueueService.ExecuteAsync` calls `_picker.ClaimNextAsync` instead of `_taskRepo.GetNextQueuedAgentTaskAsync`. The slot-claim, broadcaster, and `WakeQueue()` after slot release stay where they are.
|
||||||
|
> - `WorkerHub.WakeQueue()` and `ExternalMcpService.WakeQueue` calls in app code → remove the explicit invocations. The state-service triggers waking automatically. **Keep** the SignalR/MCP endpoint that exposes `WakeQueue()` for diagnostics/manual use — that one delegates to `_waker.Wake()`.
|
||||||
|
> - `TaskRepository.GetNextQueuedAgentTaskAsync` becomes a thin shim that forwards to `IQueuePicker` for any remaining tests, OR delete it and update tests to use the picker. Prefer delete if tests are easy to migrate.
|
||||||
|
>
|
||||||
|
> **Tests:** new `tests/ClaudeDo.Worker.Tests/Queue/QueuePickerTests.cs`:
|
||||||
|
> - Skipped: `BlockedByTaskId` set; missing agent tag; `scheduled_for > now`; status not Queued.
|
||||||
|
> - Picked: correct order (`sort_order, created_at`).
|
||||||
|
> - Atomic claim: two parallel pickers → exactly one row returned non-null, the other null.
|
||||||
|
>
|
||||||
|
> Update existing `TaskRepositoryTests.GetNextQueuedAgentTaskAsync_*` tests if they exercised the removed method.
|
||||||
|
>
|
||||||
|
> Build, test, commit as `refactor(worker/queue): split queue waker and picker, auto-wake on enqueue`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Slice 4 — Planning flow consolidation (kills the original bug)
|
||||||
|
|
||||||
|
**Prompt to paste into a fresh session:**
|
||||||
|
|
||||||
|
> Slice 4 of the worker state consolidation refactor. Spec: `docs/superpowers/specs/2026-04-27-worker-state-and-queue-consolidation-design.md` (section 4). Slices 1–3 already landed. **This slice eliminates the original "queue never picks up planning tasks" bug structurally.**
|
||||||
|
>
|
||||||
|
> **Goal:** one path through planning. Delete the dual-flow problem.
|
||||||
|
>
|
||||||
|
> **Changes:**
|
||||||
|
> - **Delete** `TaskRepository.FinalizePlanningAsync` entirely. Also delete its tests in `TaskRepositoryPlanningTests.cs`.
|
||||||
|
> - **Rewrite** `PlanningSessionManager.FinalizeAsync(taskId, queueAgentTasks, ct)`:
|
||||||
|
> 1. `_state.FinalizePlanningAsync(parentId, ct)` (sets parent `PlanningPhase=Finalized`, `Status=Idle`).
|
||||||
|
> 2. If `queueAgentTasks` is true, call the new `_chainCoordinator.SetupChainAsync(parentId, ct)`.
|
||||||
|
> 3. Existing worktree-cleanup + session-dir-deletion remains.
|
||||||
|
> 4. Return the count of children that ended up in the chain.
|
||||||
|
> - **Rename** `PlanningChainCoordinator.QueueSubtasksSequentiallyAsync` → `SetupChainAsync`. Make it `internal`. New behavior:
|
||||||
|
> - Eligibility check: children must be in `Status=Idle` (was `Manual` or `Planned` legacy values — keep tolerating those for one slice via OR).
|
||||||
|
> - Auto-attach `agent` tag to all children (already in WIP — keep that behavior).
|
||||||
|
> - For first child: `_state.EnqueueAsync(child[0].Id, ct)` (no BlockedBy, head of chain).
|
||||||
|
> - For rest: `_state.EnqueueAsync(child[i].Id, ct)` followed immediately by `_state.BlockOnAsync(child[i].Id, child[i-1].Id, ct)`. (Or: add a single `EnqueueBlockedAsync` helper to TaskStateService if call-site clutter bothers you.)
|
||||||
|
> - **Update** `PlanningChainCoordinator.OnChildFinishedAsync`: replace status-via-LINQ logic with: query for the next child where `BlockedByTaskId == childTaskId`, call `_state.UnblockAsync` on it. Drop the `Waiting` lookup entirely.
|
||||||
|
> - Audit `Status == TaskStatus.Waiting` in UI/tests — replace with `Status == Queued && BlockedByTaskId != null`. (UI changes confirmed against `TaskRowViewModel`, `TasksIslandViewModel` from Slice 1's WIP.)
|
||||||
|
>
|
||||||
|
> **Regression test:** new `tests/ClaudeDo.Worker.Tests/Planning/PlanningEndToEndTests.cs` (or extend existing) — `Active` parent + 3 drafts → call `FinalizeAsync(queueAgentTasks: true)` → assert within 200 ms the first child has `Status=Running` (queue picker claimed it) without anyone calling `WakeQueue()` manually. This was the bug the user originally reported.
|
||||||
|
>
|
||||||
|
> **Update** `PlanningMcpService.EditableStatuses` — replace `Waiting` with `Queued` (since blocked tasks are now `Queued + BlockedByTaskId`). Verify the MCP tool still gates on `parent.PlanningPhase == Active` (legacy: `parent.Status == Planning`).
|
||||||
|
>
|
||||||
|
> Build, test, commit as `feat(planning): consolidate finalize+chain via TaskStateService, fix queue pickup`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Slice 5 — `OverrideSlotService` + folder reorg
|
||||||
|
|
||||||
|
**Prompt to paste into a fresh session:**
|
||||||
|
|
||||||
|
> Slice 5 of the worker state consolidation refactor. Spec: `docs/superpowers/specs/2026-04-27-worker-state-and-queue-consolidation-design.md` (section 5). Slices 1–4 already landed.
|
||||||
|
>
|
||||||
|
> **Goal:** split the override slot out of QueueService and reorganize `Worker/Services/` into domain folders.
|
||||||
|
>
|
||||||
|
> **`OverrideSlotService` (new in `Worker/Queue/`):**
|
||||||
|
> - Owns the `_overrideSlot` field, `RunNow(taskId)`, `ContinueTask(taskId, followUpPrompt)`, and the override-slot piece of `CancelTask`.
|
||||||
|
> - Status mutations go through `TaskStateService.StartRunningAsync` (non-atomic claim is fine; serialized by slot lock).
|
||||||
|
> - `QueueService.CancelTask` delegates to `OverrideSlotService.TryCancel` first, falls back to its own queue slot.
|
||||||
|
> - WorkerHub's `RunNow`/`ContinueTask`/`CancelTask` SignalR endpoints route to the new service via `OverrideSlotService` when applicable; keep the signatures stable.
|
||||||
|
>
|
||||||
|
> **Folder reorg** (use `git mv`, don't copy/delete):
|
||||||
|
> ```
|
||||||
|
> Worker/State/ ← ITaskStateService.cs, TaskStateService.cs, TransitionResult.cs (already exist; no move needed if already there)
|
||||||
|
> Worker/Queue/ ← IQueueWaker.cs, QueueWaker.cs, IQueuePicker.cs, QueuePicker.cs, QueueService.cs, OverrideSlotService.cs, QueueSlotState.cs
|
||||||
|
> Worker/Lifecycle/ ← StaleTaskRecovery.cs, TaskResetService.cs, TaskMergeService.cs
|
||||||
|
> Worker/Worktrees/ ← WorktreeMaintenanceService.cs
|
||||||
|
> Worker/Agents/ ← AgentFileService.cs, DefaultAgentSeeder.cs
|
||||||
|
> Worker/Runner/ ← unchanged
|
||||||
|
> Worker/Planning/ ← unchanged
|
||||||
|
> Worker/External/ ← unchanged
|
||||||
|
> Worker/Hub/ ← unchanged
|
||||||
|
> ```
|
||||||
|
>
|
||||||
|
> Update namespaces to match folders (existing convention: namespace == folder path under `ClaudeDo.Worker`). Delete the old `Worker/Services/` folder once empty.
|
||||||
|
>
|
||||||
|
> Update DI registrations in `Program.cs` (both apps) — most calls just need `using` updates. `OverrideSlotService` is a new singleton.
|
||||||
|
>
|
||||||
|
> Update test `using` statements to follow.
|
||||||
|
>
|
||||||
|
> Build, test, commit as `refactor(worker): extract OverrideSlotService and reorganize Worker/Services into domain folders`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Slice 6 — Cleanup, legacy retirement, docs
|
||||||
|
|
||||||
|
**Prompt to paste into a fresh session:**
|
||||||
|
|
||||||
|
> Slice 6 (final) of the worker state consolidation refactor. Spec: `docs/superpowers/specs/2026-04-27-worker-state-and-queue-consolidation-design.md` (section 6 + slice plan). Slices 1–5 already landed.
|
||||||
|
>
|
||||||
|
> **Goal:** retire legacy enum values, backfill DB rows, update docs.
|
||||||
|
>
|
||||||
|
> **EF migration `RetireLegacyTaskStatus`:**
|
||||||
|
> ```sql
|
||||||
|
> UPDATE tasks SET status='idle' WHERE status IN ('manual', 'draft');
|
||||||
|
> UPDATE tasks SET status='idle', planning_phase='active' WHERE status='planning';
|
||||||
|
> UPDATE tasks SET status='idle', planning_phase='finalized' WHERE status='planned';
|
||||||
|
>
|
||||||
|
> -- Waiting → Queued + blocked_by from sort_order:
|
||||||
|
> WITH ordered AS (
|
||||||
|
> SELECT id,
|
||||||
|
> LAG(id) OVER (PARTITION BY parent_task_id ORDER BY sort_order, created_at) AS prev_id
|
||||||
|
> FROM tasks WHERE status='waiting'
|
||||||
|
> )
|
||||||
|
> UPDATE tasks
|
||||||
|
> SET status='queued',
|
||||||
|
> blocked_by_task_id=(SELECT prev_id FROM ordered WHERE ordered.id=tasks.id)
|
||||||
|
> WHERE id IN (SELECT id FROM ordered);
|
||||||
|
> ```
|
||||||
|
> Use `migrationBuilder.Sql(...)` for these. Down() is best-effort: `Cancelled` → `Failed`, `(idle, finalized)` → `planned`, `(idle, active)` → `planning`, `queued + blocked_by_task_id != null` → `waiting`. Document lossiness in a comment.
|
||||||
|
>
|
||||||
|
> **Code changes:**
|
||||||
|
> - Remove legacy values from `TaskStatus` enum: `Manual, Planning, Planned, Draft, Waiting`.
|
||||||
|
> - Strip the legacy branches from `TaskEntityConfiguration.StatusToString`/`StatusFromString`.
|
||||||
|
> - Default for `TaskEntity.Status` is `TaskStatus.Idle` (already correct after Slice 1's revert).
|
||||||
|
> - Audit + remap every remaining caller — they should already use new values from Slices 2–4, but search for any leftover `TaskStatus.Manual` etc. in:
|
||||||
|
> - tests (~10 files seed status — flip to `Idle`/`Queued`/etc.)
|
||||||
|
> - UI (`TaskRowViewModel.IsPlanningParent`, `IsDraft`, `CanOpenPlanningSession`, status maps — replace with `PlanningPhase` checks where appropriate)
|
||||||
|
> - any leftover guards in MCP/services
|
||||||
|
> - Mark `Mark*Async` repo helpers as `internal` if not already (Slice 2 should have done this — verify).
|
||||||
|
>
|
||||||
|
> **Docs to update:**
|
||||||
|
> - `src/ClaudeDo.Worker/CLAUDE.md` — new folder structure, new state-service flow, new wake mechanics, removal of legacy values.
|
||||||
|
> - `src/ClaudeDo.Data/CLAUDE.md` — TaskEntity new fields (`PlanningPhase`, `BlockedByTaskId`), retired legacy enum values, new tag-attach behavior.
|
||||||
|
> - `docs/plan.md` — update status flow section.
|
||||||
|
> - `docs/open.md` — close the "queue doesn't pick up planning tasks" item if it's tracked there; add any follow-ups discovered along the way.
|
||||||
|
> - Memory: update `~/.claude/projects/C--Private-ClaudeDo/memory/` with a new entry summarizing the new architecture (state-service + queue split + planning chain via blocked-by).
|
||||||
|
>
|
||||||
|
> **Sanity tests** — full test run. The 4 pre-existing constructor-drift errors should still be the only failures. If new ones surfaced from missed legacy-value remappings, fix them before commit.
|
||||||
|
>
|
||||||
|
> Build, full test run, commit as `refactor(data): retire legacy TaskStatus values and backfill existing rows`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## After Slice 6
|
||||||
|
|
||||||
|
- All 6 slices on `main`.
|
||||||
|
- The original bug ("queue doesn't pick up planning tasks") is structurally impossible.
|
||||||
|
- Worker has clear domain folders, single state-mutator, single queue-picker.
|
||||||
|
- Spec doc + this prompt file can be deleted or moved to `docs/superpowers/done/`.
|
||||||
2424
docs/superpowers/plans/2026-04-28-tabbed-settings-prime-claude.md
Normal file
2424
docs/superpowers/plans/2026-04-28-tabbed-settings-prime-claude.md
Normal file
File diff suppressed because it is too large
Load Diff
1423
docs/superpowers/plans/2026-05-19-worktree-overview-modal.md
Normal file
1423
docs/superpowers/plans/2026-05-19-worktree-overview-modal.md
Normal file
File diff suppressed because it is too large
Load Diff
834
docs/superpowers/plans/2026-05-29-repo-import-list-helper.md
Normal file
834
docs/superpowers/plans/2026-05-29-repo-import-list-helper.md
Normal file
@@ -0,0 +1,834 @@
|
|||||||
|
# Repo Import List Helper Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Add a helper that scans parent folders for git repos and bulk-creates lists (with `WorkingDir` pre-filled) for the repos the user ticks.
|
||||||
|
|
||||||
|
**Architecture:** A pure `RepoScanner` finds git repos under a parent folder. A `RepoImportModalViewModel` loads existing lists' working dirs, merges scanned candidates into a checklist (marking already-added repos), and creates `ListEntity` rows for ticked-new repos via `ListRepository`. `RepoImportModalView` hosts the checklist and a folder picker. Two entry points open the modal: a Help-menu item (handled by `IslandsShellViewModel`) and a folder button in the Lists island (handled by `ListsIslandViewModel`). Each entry point reloads the Lists island after the modal closes.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, Avalonia 12, CommunityToolkit.Mvvm source generators, EF Core (SQLite), xUnit.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File Structure
|
||||||
|
|
||||||
|
**Create:**
|
||||||
|
- `src/ClaudeDo.Ui/Services/RepoScanner.cs` — pure filesystem scan; `RepoCandidate` record + `RepoScanner.Scan`.
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Modals/RepoImportItemViewModel.cs` — one checklist row.
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Modals/RepoImportModalViewModel.cs` — modal VM (load, merge, create) + static `BuildCandidates`.
|
||||||
|
- `src/ClaudeDo.Ui/Views/Modals/RepoImportModalView.axaml` (+ `.axaml.cs`) — modal window + folder picker.
|
||||||
|
- `tests/ClaudeDo.Ui.Tests/RepoScannerTests.cs` — scanner unit tests.
|
||||||
|
- `tests/ClaudeDo.Ui.Tests/RepoImportCandidatesTests.cs` — merge/dedupe/already-added unit tests.
|
||||||
|
|
||||||
|
**Modify:**
|
||||||
|
- `src/ClaudeDo.App/Program.cs` — register `RepoImportModalViewModel` (transient) + a `Func<RepoImportModalViewModel>`; pass the Func into `IslandsShellViewModel`.
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Islands/ListsIslandViewModel.cs` — `ShowRepoImportModal` Func + `OpenRepoImportCommand`.
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/ListsIslandView.axaml` — folder button beside `+ New list`.
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/ListsIslandView.axaml.cs` — wire `ShowRepoImportModal`.
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs` — `ShowRepoImportModal` Func + `OpenRepoImportCommand`; inject `Func<RepoImportModalViewModel>`.
|
||||||
|
- `src/ClaudeDo.Ui/Views/MainWindow.axaml` — Help-menu item `Add repos as lists…`.
|
||||||
|
- `src/ClaudeDo.Ui/Views/MainWindow.axaml.cs` — wire `ShowRepoImportModal`.
|
||||||
|
- `src/ClaudeDo.Ui/CLAUDE.md` — document the new modal + entry points.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: RepoScanner
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Ui/Services/RepoScanner.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Ui.Tests/RepoScannerTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Ui.Tests/RepoScannerTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Ui.Services;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Tests;
|
||||||
|
|
||||||
|
public sealed class RepoScannerTests : IDisposable
|
||||||
|
{
|
||||||
|
private readonly string _root =
|
||||||
|
Path.Combine(Path.GetTempPath(), "repo-scan-" + Guid.NewGuid().ToString("N"));
|
||||||
|
|
||||||
|
public RepoScannerTests() => Directory.CreateDirectory(_root);
|
||||||
|
|
||||||
|
public void Dispose()
|
||||||
|
{
|
||||||
|
try { Directory.Delete(_root, recursive: true); } catch { }
|
||||||
|
}
|
||||||
|
|
||||||
|
private string MakeDir(string name)
|
||||||
|
{
|
||||||
|
var p = Path.Combine(_root, name);
|
||||||
|
Directory.CreateDirectory(p);
|
||||||
|
return p;
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Scan_ReturnsSubfoldersWithGitDirectory()
|
||||||
|
{
|
||||||
|
var repo = MakeDir("repo-a");
|
||||||
|
Directory.CreateDirectory(Path.Combine(repo, ".git"));
|
||||||
|
|
||||||
|
var result = RepoScanner.Scan(_root);
|
||||||
|
|
||||||
|
Assert.Single(result);
|
||||||
|
Assert.Equal("repo-a", result[0].Name);
|
||||||
|
Assert.Equal(repo, result[0].FullPath);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Scan_TreatsDotGitFileAsRepo()
|
||||||
|
{
|
||||||
|
var repo = MakeDir("worktree-repo");
|
||||||
|
File.WriteAllText(Path.Combine(repo, ".git"), "gitdir: ../somewhere");
|
||||||
|
|
||||||
|
var result = RepoScanner.Scan(_root);
|
||||||
|
|
||||||
|
Assert.Single(result);
|
||||||
|
Assert.Equal("worktree-repo", result[0].Name);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Scan_IgnoresPlainFolders()
|
||||||
|
{
|
||||||
|
MakeDir("not-a-repo");
|
||||||
|
|
||||||
|
var result = RepoScanner.Scan(_root);
|
||||||
|
|
||||||
|
Assert.Empty(result);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Scan_IsNotRecursive()
|
||||||
|
{
|
||||||
|
var nested = MakeDir(Path.Combine("outer", "inner"));
|
||||||
|
Directory.CreateDirectory(Path.Combine(nested, ".git"));
|
||||||
|
// outer itself has no .git
|
||||||
|
|
||||||
|
var result = RepoScanner.Scan(_root);
|
||||||
|
|
||||||
|
Assert.Empty(result);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Scan_ReturnsEmptyForMissingFolder()
|
||||||
|
{
|
||||||
|
var result = RepoScanner.Scan(Path.Combine(_root, "does-not-exist"));
|
||||||
|
|
||||||
|
Assert.Empty(result);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run tests to verify they fail**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Ui.Tests --filter RepoScannerTests`
|
||||||
|
Expected: FAIL — `RepoScanner` / `RepoCandidate` do not exist (compile error).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement RepoScanner**
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Ui/Services/RepoScanner.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Ui.Services;
|
||||||
|
|
||||||
|
public sealed record RepoCandidate(string Name, string FullPath);
|
||||||
|
|
||||||
|
public static class RepoScanner
|
||||||
|
{
|
||||||
|
public static IReadOnlyList<RepoCandidate> Scan(string parentFolder)
|
||||||
|
{
|
||||||
|
if (string.IsNullOrWhiteSpace(parentFolder) || !Directory.Exists(parentFolder))
|
||||||
|
return Array.Empty<RepoCandidate>();
|
||||||
|
|
||||||
|
var result = new List<RepoCandidate>();
|
||||||
|
IEnumerable<string> subdirs;
|
||||||
|
try { subdirs = Directory.EnumerateDirectories(parentFolder); }
|
||||||
|
catch { return Array.Empty<RepoCandidate>(); }
|
||||||
|
|
||||||
|
foreach (var dir in subdirs)
|
||||||
|
{
|
||||||
|
var gitPath = Path.Combine(dir, ".git");
|
||||||
|
if (Directory.Exists(gitPath) || File.Exists(gitPath))
|
||||||
|
result.Add(new RepoCandidate(Path.GetFileName(dir), dir));
|
||||||
|
}
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run tests to verify they pass**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Ui.Tests --filter RepoScannerTests`
|
||||||
|
Expected: PASS (5 tests).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Services/RepoScanner.cs tests/ClaudeDo.Ui.Tests/RepoScannerTests.cs
|
||||||
|
git commit -m "feat(ui): add RepoScanner for git repo discovery"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: RepoImportItemViewModel
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Ui/ViewModels/Modals/RepoImportItemViewModel.cs`
|
||||||
|
|
||||||
|
No dedicated test (trivial display VM; covered indirectly by Task 3).
|
||||||
|
|
||||||
|
- [ ] **Step 1: Implement the item VM**
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Ui/ViewModels/Modals/RepoImportItemViewModel.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using CommunityToolkit.Mvvm.ComponentModel;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.ViewModels.Modals;
|
||||||
|
|
||||||
|
public sealed partial class RepoImportItemViewModel : ViewModelBase
|
||||||
|
{
|
||||||
|
public string Name { get; init; } = "";
|
||||||
|
public string FullPath { get; init; } = "";
|
||||||
|
|
||||||
|
// True when a list already points at this path. Such rows are shown ticked + disabled.
|
||||||
|
public bool AlreadyAdded { get; init; }
|
||||||
|
public bool CanToggle => !AlreadyAdded;
|
||||||
|
|
||||||
|
[ObservableProperty] private bool _isChecked;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/Modals/RepoImportItemViewModel.cs
|
||||||
|
git commit -m "feat(ui): add RepoImportItemViewModel"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: RepoImportModalViewModel
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Ui/ViewModels/Modals/RepoImportModalViewModel.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Ui.Tests/RepoImportCandidatesTests.cs`
|
||||||
|
|
||||||
|
The pure `BuildCandidates` static method is the tested seam (dedupe + already-added marking). `LoadAsync`/`CreateAsync` touch the DB and are verified manually.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Ui.Tests/RepoImportCandidatesTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Ui.Services;
|
||||||
|
using ClaudeDo.Ui.ViewModels.Modals;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Tests;
|
||||||
|
|
||||||
|
public sealed class RepoImportCandidatesTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void BuildCandidates_NewRepo_IsCheckedAndNotAlreadyAdded()
|
||||||
|
{
|
||||||
|
var found = new[] { new RepoCandidate("repo-a", @"C:\src\repo-a") };
|
||||||
|
var current = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||||
|
var existing = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||||
|
|
||||||
|
var items = RepoImportModalViewModel.BuildCandidates(found, current, existing);
|
||||||
|
|
||||||
|
Assert.Single(items);
|
||||||
|
Assert.True(items[0].IsChecked);
|
||||||
|
Assert.False(items[0].AlreadyAdded);
|
||||||
|
Assert.Equal("repo-a", items[0].Name);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void BuildCandidates_ExistingWorkingDir_IsMarkedAlreadyAdded()
|
||||||
|
{
|
||||||
|
var found = new[] { new RepoCandidate("repo-a", @"C:\src\repo-a") };
|
||||||
|
var current = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||||
|
var existing = new HashSet<string>(new[] { @"c:\src\repo-a" }, StringComparer.OrdinalIgnoreCase);
|
||||||
|
|
||||||
|
var items = RepoImportModalViewModel.BuildCandidates(found, current, existing);
|
||||||
|
|
||||||
|
Assert.Single(items);
|
||||||
|
Assert.True(items[0].AlreadyAdded);
|
||||||
|
Assert.True(items[0].IsChecked); // already-added rows render ticked
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void BuildCandidates_SkipsPathsAlreadyShown()
|
||||||
|
{
|
||||||
|
var found = new[] { new RepoCandidate("repo-a", @"C:\src\repo-a") };
|
||||||
|
var current = new HashSet<string>(new[] { @"c:\src\repo-a" }, StringComparer.OrdinalIgnoreCase);
|
||||||
|
var existing = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||||
|
|
||||||
|
var items = RepoImportModalViewModel.BuildCandidates(found, current, existing);
|
||||||
|
|
||||||
|
Assert.Empty(items);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run tests to verify they fail**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Ui.Tests --filter RepoImportCandidatesTests`
|
||||||
|
Expected: FAIL — `RepoImportModalViewModel` does not exist (compile error).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement the modal VM**
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Ui/ViewModels/Modals/RepoImportModalViewModel.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.Collections.ObjectModel;
|
||||||
|
using System.ComponentModel;
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Ui.Services;
|
||||||
|
using CommunityToolkit.Mvvm.Input;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.ViewModels.Modals;
|
||||||
|
|
||||||
|
public sealed partial class RepoImportModalViewModel : ViewModelBase
|
||||||
|
{
|
||||||
|
private readonly IDbContextFactory<ClaudeDoDbContext> _dbFactory;
|
||||||
|
private readonly HashSet<string> _existingDirs = new(StringComparer.OrdinalIgnoreCase);
|
||||||
|
|
||||||
|
public ObservableCollection<RepoImportItemViewModel> Repos { get; } = new();
|
||||||
|
|
||||||
|
public Action? CloseAction { get; set; }
|
||||||
|
|
||||||
|
public int CreateCount => Repos.Count(r => r.IsChecked && !r.AlreadyAdded);
|
||||||
|
public bool CanCreate => CreateCount > 0;
|
||||||
|
public string CreateButtonText => $"Create {CreateCount} list(s)";
|
||||||
|
|
||||||
|
public RepoImportModalViewModel(IDbContextFactory<ClaudeDoDbContext> dbFactory)
|
||||||
|
{
|
||||||
|
_dbFactory = dbFactory;
|
||||||
|
}
|
||||||
|
|
||||||
|
public async Task LoadAsync(CancellationToken ct = default)
|
||||||
|
{
|
||||||
|
Repos.Clear();
|
||||||
|
_existingDirs.Clear();
|
||||||
|
|
||||||
|
await using var ctx = await _dbFactory.CreateDbContextAsync(ct);
|
||||||
|
var lists = new ListRepository(ctx);
|
||||||
|
foreach (var l in await lists.GetAllAsync(ct))
|
||||||
|
{
|
||||||
|
if (!string.IsNullOrWhiteSpace(l.WorkingDir))
|
||||||
|
_existingDirs.Add(l.WorkingDir!);
|
||||||
|
}
|
||||||
|
NotifyCreateState();
|
||||||
|
}
|
||||||
|
|
||||||
|
public void AddFolders(IEnumerable<string> folders)
|
||||||
|
{
|
||||||
|
var current = new HashSet<string>(
|
||||||
|
Repos.Select(r => r.FullPath), StringComparer.OrdinalIgnoreCase);
|
||||||
|
|
||||||
|
foreach (var folder in folders)
|
||||||
|
{
|
||||||
|
var found = RepoScanner.Scan(folder);
|
||||||
|
foreach (var item in BuildCandidates(found, current, _existingDirs))
|
||||||
|
{
|
||||||
|
item.PropertyChanged += OnItemChanged;
|
||||||
|
Repos.Add(item);
|
||||||
|
current.Add(item.FullPath);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
NotifyCreateState();
|
||||||
|
}
|
||||||
|
|
||||||
|
public static List<RepoImportItemViewModel> BuildCandidates(
|
||||||
|
IEnumerable<RepoCandidate> found,
|
||||||
|
IReadOnlySet<string> currentPaths,
|
||||||
|
IReadOnlySet<string> existingDirs)
|
||||||
|
{
|
||||||
|
var items = new List<RepoImportItemViewModel>();
|
||||||
|
foreach (var c in found)
|
||||||
|
{
|
||||||
|
if (currentPaths.Contains(c.FullPath)) continue;
|
||||||
|
items.Add(new RepoImportItemViewModel
|
||||||
|
{
|
||||||
|
Name = c.Name,
|
||||||
|
FullPath = c.FullPath,
|
||||||
|
AlreadyAdded = existingDirs.Contains(c.FullPath),
|
||||||
|
IsChecked = true,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
return items;
|
||||||
|
}
|
||||||
|
|
||||||
|
private void OnItemChanged(object? sender, PropertyChangedEventArgs e)
|
||||||
|
{
|
||||||
|
if (e.PropertyName == nameof(RepoImportItemViewModel.IsChecked))
|
||||||
|
NotifyCreateState();
|
||||||
|
}
|
||||||
|
|
||||||
|
private void NotifyCreateState()
|
||||||
|
{
|
||||||
|
OnPropertyChanged(nameof(CreateCount));
|
||||||
|
OnPropertyChanged(nameof(CanCreate));
|
||||||
|
OnPropertyChanged(nameof(CreateButtonText));
|
||||||
|
}
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private async Task CreateAsync()
|
||||||
|
{
|
||||||
|
var toCreate = Repos.Where(r => r.IsChecked && !r.AlreadyAdded).ToList();
|
||||||
|
if (toCreate.Count > 0)
|
||||||
|
{
|
||||||
|
await using var ctx = await _dbFactory.CreateDbContextAsync();
|
||||||
|
var lists = new ListRepository(ctx);
|
||||||
|
foreach (var r in toCreate)
|
||||||
|
{
|
||||||
|
await lists.AddAsync(new ListEntity
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid().ToString("N"),
|
||||||
|
Name = r.Name,
|
||||||
|
WorkingDir = r.FullPath,
|
||||||
|
DefaultCommitType = CommitTypeRegistry.DefaultType,
|
||||||
|
CreatedAt = DateTime.UtcNow,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
CloseAction?.Invoke();
|
||||||
|
}
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private void Cancel() => CloseAction?.Invoke();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run tests to verify they pass**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Ui.Tests --filter RepoImportCandidatesTests`
|
||||||
|
Expected: PASS (3 tests).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/Modals/RepoImportModalViewModel.cs tests/ClaudeDo.Ui.Tests/RepoImportCandidatesTests.cs
|
||||||
|
git commit -m "feat(ui): add RepoImportModalViewModel with candidate merge logic"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: RepoImportModalView
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Ui/Views/Modals/RepoImportModalView.axaml`
|
||||||
|
- Create: `src/ClaudeDo.Ui/Views/Modals/RepoImportModalView.axaml.cs`
|
||||||
|
|
||||||
|
Modeled on `AboutModalView.axaml` (header/body/footer) and `ListSettingsModalView.axaml.cs` (folder picker).
|
||||||
|
|
||||||
|
- [ ] **Step 1: Create the view XAML**
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Ui/Views/Modals/RepoImportModalView.axaml`:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Window xmlns="https://github.com/avaloniaui"
|
||||||
|
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
|
||||||
|
xmlns:vm="using:ClaudeDo.Ui.ViewModels.Modals"
|
||||||
|
x:Class="ClaudeDo.Ui.Views.Modals.RepoImportModalView"
|
||||||
|
x:DataType="vm:RepoImportModalViewModel"
|
||||||
|
Title="Add repos as lists"
|
||||||
|
Width="560" Height="480"
|
||||||
|
WindowDecorations="None"
|
||||||
|
ExtendClientAreaToDecorationsHint="True"
|
||||||
|
WindowStartupLocation="CenterOwner"
|
||||||
|
Background="{DynamicResource SurfaceBrush}">
|
||||||
|
<Window.KeyBindings>
|
||||||
|
<KeyBinding Gesture="Escape" Command="{Binding CancelCommand}"/>
|
||||||
|
</Window.KeyBindings>
|
||||||
|
<Border BorderBrush="{DynamicResource LineBrush}" BorderThickness="1">
|
||||||
|
<Grid RowDefinitions="36,Auto,*,52">
|
||||||
|
|
||||||
|
<!-- Header -->
|
||||||
|
<Border Grid.Row="0" Background="{DynamicResource DeepBrush}"
|
||||||
|
BorderBrush="{DynamicResource LineBrush}" BorderThickness="0,0,0,1">
|
||||||
|
<Grid ColumnDefinitions="*,Auto" Margin="14,0">
|
||||||
|
<TextBlock Text="ADD REPOS AS LISTS" FontFamily="{DynamicResource MonoFont}" FontSize="11"
|
||||||
|
LetterSpacing="1.4" Foreground="{DynamicResource TextBrush}" VerticalAlignment="Center"/>
|
||||||
|
<Button Grid.Column="1" Classes="icon-btn" Content="✕" FontSize="12"
|
||||||
|
Command="{Binding CancelCommand}" VerticalAlignment="Center"/>
|
||||||
|
</Grid>
|
||||||
|
</Border>
|
||||||
|
|
||||||
|
<!-- Add folder row -->
|
||||||
|
<Border Grid.Row="1" Padding="16,12,16,4">
|
||||||
|
<Button Content="Add folder…" Click="AddFolderClicked" HorizontalAlignment="Left"/>
|
||||||
|
</Border>
|
||||||
|
|
||||||
|
<!-- Repo checklist -->
|
||||||
|
<ScrollViewer Grid.Row="2" Padding="16,4,16,8">
|
||||||
|
<ItemsControl ItemsSource="{Binding Repos}">
|
||||||
|
<ItemsControl.ItemTemplate>
|
||||||
|
<DataTemplate DataType="vm:RepoImportItemViewModel">
|
||||||
|
<Grid ColumnDefinitions="Auto,*,Auto" Margin="0,4">
|
||||||
|
<CheckBox Grid.Column="0"
|
||||||
|
IsChecked="{Binding IsChecked, Mode=TwoWay}"
|
||||||
|
IsEnabled="{Binding CanToggle}"
|
||||||
|
VerticalAlignment="Center"/>
|
||||||
|
<StackPanel Grid.Column="1" Margin="6,0" VerticalAlignment="Center">
|
||||||
|
<TextBlock Text="{Binding Name}" Foreground="{DynamicResource TextBrush}" FontSize="13"/>
|
||||||
|
<TextBlock Text="{Binding FullPath}" Foreground="{DynamicResource TextFaintBrush}"
|
||||||
|
FontFamily="{DynamicResource MonoFont}" FontSize="10"
|
||||||
|
TextTrimming="CharacterEllipsis"/>
|
||||||
|
</StackPanel>
|
||||||
|
<TextBlock Grid.Column="2" Text="(already added)"
|
||||||
|
Foreground="{DynamicResource TextFaintBrush}" FontSize="11"
|
||||||
|
VerticalAlignment="Center"
|
||||||
|
IsVisible="{Binding AlreadyAdded}"/>
|
||||||
|
</Grid>
|
||||||
|
</DataTemplate>
|
||||||
|
</ItemsControl.ItemTemplate>
|
||||||
|
</ItemsControl>
|
||||||
|
</ScrollViewer>
|
||||||
|
|
||||||
|
<!-- Footer -->
|
||||||
|
<Border Grid.Row="3" Background="{DynamicResource DeepBrush}"
|
||||||
|
BorderBrush="{DynamicResource LineBrush}" BorderThickness="0,1,0,0">
|
||||||
|
<StackPanel Orientation="Horizontal" Spacing="8" HorizontalAlignment="Right"
|
||||||
|
VerticalAlignment="Center" Margin="16,0">
|
||||||
|
<Button Content="Cancel" Command="{Binding CancelCommand}" MinWidth="90"/>
|
||||||
|
<Button Content="{Binding CreateButtonText}" Command="{Binding CreateCommand}"
|
||||||
|
IsEnabled="{Binding CanCreate}" MinWidth="120" Classes="accent"/>
|
||||||
|
</StackPanel>
|
||||||
|
</Border>
|
||||||
|
|
||||||
|
</Grid>
|
||||||
|
</Border>
|
||||||
|
</Window>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Create the code-behind with folder picker**
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Ui/Views/Modals/RepoImportModalView.axaml.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using Avalonia.Controls;
|
||||||
|
using Avalonia.Input;
|
||||||
|
using Avalonia.Interactivity;
|
||||||
|
using Avalonia.Platform.Storage;
|
||||||
|
using ClaudeDo.Ui.ViewModels.Modals;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Views.Modals;
|
||||||
|
|
||||||
|
public partial class RepoImportModalView : Window
|
||||||
|
{
|
||||||
|
public RepoImportModalView()
|
||||||
|
{
|
||||||
|
InitializeComponent();
|
||||||
|
}
|
||||||
|
|
||||||
|
private void TitleBar_PointerPressed(object? sender, PointerPressedEventArgs e)
|
||||||
|
{
|
||||||
|
if (e.GetCurrentPoint(this).Properties.IsLeftButtonPressed)
|
||||||
|
BeginMoveDrag(e);
|
||||||
|
}
|
||||||
|
|
||||||
|
private async void AddFolderClicked(object? sender, RoutedEventArgs e)
|
||||||
|
{
|
||||||
|
if (DataContext is not RepoImportModalViewModel vm) return;
|
||||||
|
var top = TopLevel.GetTopLevel(this);
|
||||||
|
if (top is null) return;
|
||||||
|
|
||||||
|
var folders = await top.StorageProvider.OpenFolderPickerAsync(new FolderPickerOpenOptions
|
||||||
|
{
|
||||||
|
Title = "Choose folders containing repos",
|
||||||
|
AllowMultiple = true,
|
||||||
|
});
|
||||||
|
if (folders.Count == 0) return;
|
||||||
|
|
||||||
|
vm.AddFolders(folders.Select(f => f.Path.LocalPath));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Expected: Build succeeded. (`TitleBar_PointerPressed` is unused for now but kept for parity with other modals; if the build warns as error, leave it — other modals keep the same handler.)
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Views/Modals/RepoImportModalView.axaml src/ClaudeDo.Ui/Views/Modals/RepoImportModalView.axaml.cs
|
||||||
|
git commit -m "feat(ui): add RepoImportModalView"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: DI registration
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.App/Program.cs:106` (after `ListSettingsModalViewModel` registration)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Register the modal VM and its factory**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.App/Program.cs`, after the line `sc.AddTransient<ListSettingsModalViewModel>();` add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
sc.AddTransient<RepoImportModalViewModel>();
|
||||||
|
sc.AddTransient<Func<RepoImportModalViewModel>>(sp => () => sp.GetRequiredService<RepoImportModalViewModel>());
|
||||||
|
```
|
||||||
|
|
||||||
|
(`RepoImportModalViewModel` is in namespace `ClaudeDo.Ui.ViewModels.Modals`, already imported in `Program.cs` via the existing modal VM usings — verify the using is present; if not, add `using ClaudeDo.Ui.ViewModels.Modals;`.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.App/Program.cs
|
||||||
|
git commit -m "chore(di): register RepoImportModalViewModel"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 6: Lists island entry point
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/ListsIslandViewModel.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/ListsIslandView.axaml`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/ListsIslandView.axaml.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add Func + command to the VM**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/ViewModels/Islands/ListsIslandViewModel.cs`, next to the existing `ShowListSettingsModal` property (around line 30), add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public Func<RepoImportModalViewModel, System.Threading.Tasks.Task>? ShowRepoImportModal { get; set; }
|
||||||
|
```
|
||||||
|
|
||||||
|
Then add a command (place it near `CreateListAsync`, e.g. after the `OpenWorktreesOverviewAsync` command around line 71):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[RelayCommand]
|
||||||
|
private async System.Threading.Tasks.Task OpenRepoImportAsync()
|
||||||
|
{
|
||||||
|
if (ShowRepoImportModal is null || _services is null) return;
|
||||||
|
var vm = _services.GetRequiredService<RepoImportModalViewModel>();
|
||||||
|
await vm.LoadAsync();
|
||||||
|
await ShowRepoImportModal(vm);
|
||||||
|
await LoadAsync();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
(`RepoImportModalViewModel` is in `ClaudeDo.Ui.ViewModels.Modals`, already imported at the top of this file.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Add the folder button in XAML**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Views/Islands/ListsIslandView.axaml`, replace the existing `+ New list` button block (lines 171-183) with a row that holds both the new-list button and a folder-scan button:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<!-- New list + import row -->
|
||||||
|
<Grid ColumnDefinitions="*,Auto" Margin="0,4,0,0">
|
||||||
|
<Button Grid.Column="0" Classes="new-list-btn"
|
||||||
|
Command="{Binding CreateListCommand}">
|
||||||
|
<StackPanel Orientation="Horizontal" Spacing="6">
|
||||||
|
<PathIcon Data="{StaticResource Icon.Plus}"
|
||||||
|
Width="13" Height="13"
|
||||||
|
Foreground="{DynamicResource TextMuteBrush}"
|
||||||
|
VerticalAlignment="Center"/>
|
||||||
|
<TextBlock Text="New list" FontSize="12"
|
||||||
|
Foreground="{DynamicResource TextMuteBrush}"
|
||||||
|
VerticalAlignment="Center"/>
|
||||||
|
</StackPanel>
|
||||||
|
</Button>
|
||||||
|
<Button Grid.Column="1" Classes="icon-btn" Margin="6,0,0,0"
|
||||||
|
Command="{Binding OpenRepoImportCommand}"
|
||||||
|
ToolTip.Tip="Add repos as lists">
|
||||||
|
<PathIcon Data="{StaticResource Icon.Folder}"
|
||||||
|
Width="14" Height="14"
|
||||||
|
Foreground="{DynamicResource TextMuteBrush}"/>
|
||||||
|
</Button>
|
||||||
|
</Grid>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Wire the Func in the code-behind**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Views/Islands/ListsIslandView.axaml.cs`, inside the `DataContextChanged` handler (after the `vm.ShowWorktreesOverviewModal = ...` assignment, before the closing brace of the `if` block around line 66), add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
vm.ShowRepoImportModal = async modal =>
|
||||||
|
{
|
||||||
|
var window = new RepoImportModalView { DataContext = modal };
|
||||||
|
modal.CloseAction = () => window.Close();
|
||||||
|
var top = TopLevel.GetTopLevel(this) as Window;
|
||||||
|
if (top is null) window.Show();
|
||||||
|
else await window.ShowDialog(top);
|
||||||
|
};
|
||||||
|
```
|
||||||
|
|
||||||
|
(`RepoImportModalView` is in `ClaudeDo.Ui.Views.Modals`, already imported in this file.)
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Ui/ClaudeDo.Ui.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/Islands/ListsIslandViewModel.cs src/ClaudeDo.Ui/Views/Islands/ListsIslandView.axaml src/ClaudeDo.Ui/Views/Islands/ListsIslandView.axaml.cs
|
||||||
|
git commit -m "feat(ui): add repo import button to Lists island"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 7: Help-menu entry point
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`
|
||||||
|
- Modify: `src/ClaudeDo.App/Program.cs` (pass the Func into the shell VM)
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/MainWindow.axaml`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/MainWindow.axaml.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add Func, factory field, and command to the shell VM**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`:
|
||||||
|
|
||||||
|
(a) Near the `ShowAboutModal` property (line 44), add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public Func<RepoImportModalViewModel, Task>? ShowRepoImportModal { get; set; }
|
||||||
|
```
|
||||||
|
|
||||||
|
(b) Add a backing field for the factory next to `_worktreesOverviewVmFactory` (declared as a private readonly field elsewhere in the class). Add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private readonly Func<RepoImportModalViewModel>? _repoImportVmFactory;
|
||||||
|
```
|
||||||
|
|
||||||
|
(c) Add a parameter to the public constructor (line 162-171) — append after `mergeVmFactory`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Func<MergeModalViewModel> mergeVmFactory,
|
||||||
|
Func<RepoImportModalViewModel> repoImportVmFactory)
|
||||||
|
```
|
||||||
|
|
||||||
|
and in the constructor body assign it (next to `_mergeVmFactory = mergeVmFactory;`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
_repoImportVmFactory = repoImportVmFactory;
|
||||||
|
```
|
||||||
|
|
||||||
|
(d) Add the command near `OpenAbout` (line 256):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[RelayCommand]
|
||||||
|
private async Task OpenRepoImport()
|
||||||
|
{
|
||||||
|
if (ShowRepoImportModal is null || _repoImportVmFactory is null) return;
|
||||||
|
var vm = _repoImportVmFactory();
|
||||||
|
await vm.LoadAsync();
|
||||||
|
await ShowRepoImportModal(vm);
|
||||||
|
if (Lists is not null) await Lists.LoadAsync();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
(`RepoImportModalViewModel` is in `ClaudeDo.Ui.ViewModels.Modals`, already imported in this file.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Pass the Func into the shell VM in DI**
|
||||||
|
|
||||||
|
`IslandsShellViewModel` is registered with `sc.AddSingleton<IslandsShellViewModel>();` (Program.cs:123), which resolves constructor params from the container. Since Task 5 registered `Func<RepoImportModalViewModel>`, no change to the registration call is required — the new constructor parameter resolves automatically. Verify by building in Step 5.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Add the Help-menu item**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Views/MainWindow.axaml`, inside the Help `MenuItem` (after the `About…` item at line 74), add:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<MenuItem Header="Add repos as lists…" Command="{Binding OpenRepoImportCommand}"/>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Wire the Func in MainWindow code-behind**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Views/MainWindow.axaml.cs`, inside `OnDataContextChanged` (after the `vm.ShowWorktreesOverviewModal = ...` block, before the closing brace of the `if` at line 65), add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
vm.ShowRepoImportModal = async (modal) =>
|
||||||
|
{
|
||||||
|
var dlg = new RepoImportModalView { DataContext = modal };
|
||||||
|
modal.CloseAction = () => dlg.Close();
|
||||||
|
await dlg.ShowDialog(this);
|
||||||
|
};
|
||||||
|
```
|
||||||
|
|
||||||
|
(`RepoImportModalView` is in `ClaudeDo.Ui.Views.Modals`, already imported in this file.)
|
||||||
|
|
||||||
|
- [ ] **Step 5: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: Build succeeded (this also builds the Ui project).
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs src/ClaudeDo.Ui/Views/MainWindow.axaml src/ClaudeDo.Ui/Views/MainWindow.axaml.cs
|
||||||
|
git commit -m "feat(ui): add 'Add repos as lists' Help-menu entry point"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 8: Manual verification + docs
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/CLAUDE.md`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Run the full Ui test suite**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Ui.Tests`
|
||||||
|
Expected: PASS (all tests, including the new `RepoScannerTests` and `RepoImportCandidatesTests`).
|
||||||
|
|
||||||
|
- [ ] **Step 2: Manual smoke test**
|
||||||
|
|
||||||
|
Launch the app (`dotnet run --project src/ClaudeDo.App/ClaudeDo.App.csproj`). Verify:
|
||||||
|
- Lists island shows a folder button next to `+ New list`; clicking it opens the modal.
|
||||||
|
- Help menu shows `Add repos as lists…`; clicking it opens the same modal.
|
||||||
|
- `Add folder…` → pick a parent folder containing git repos → repos appear as ticked rows; non-repo subfolders are absent.
|
||||||
|
- A repo that already has a list appears ticked, disabled, with `(already added)`.
|
||||||
|
- The confirm button reads `Create N list(s)` and is disabled when N is 0.
|
||||||
|
- Confirming creates the lists; they appear in the Lists island immediately after the modal closes.
|
||||||
|
|
||||||
|
Note: if you cannot run the GUI in this environment, state that explicitly rather than claiming the UI works.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Update CLAUDE.md**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/CLAUDE.md`, under the `## Views` section, add a bullet:
|
||||||
|
|
||||||
|
```markdown
|
||||||
|
- **RepoImportModalView** — bulk-creates lists from git repos discovered under chosen parent folders. Opened via the folder button beside "New list" in the Lists island, or the "Add repos as lists…" Help-menu item. Repos already wired to a list show as disabled/"(already added)".
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/CLAUDE.md
|
||||||
|
git commit -m "docs(ui): document RepoImportModalView"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Self-Review Notes
|
||||||
|
|
||||||
|
- **Spec coverage:** Entry points (Help menu — Task 7; Lists island button — Task 6); `RepoScanner` non-recursive `.git` dir/file detection (Task 1); `RepoImportModalViewModel` load existing dirs + merge + create (Task 3); already-added disabled rows + `(already added)` label (Tasks 2/3/4); combined multi-folder checklist with path dedupe (Task 3 `AddFolders`); defaults Name/WorkingDir/DefaultCommitType (Task 3 `CreateAsync`); reload Lists island after close (Tasks 6/7); DI registration (Task 5); tests for scanner + merge logic (Tasks 1/3). All spec sections map to a task.
|
||||||
|
- **Type consistency:** `RepoCandidate(Name, FullPath)`, `RepoScanner.Scan`, `RepoImportItemViewModel{Name,FullPath,AlreadyAdded,CanToggle,IsChecked}`, `RepoImportModalViewModel{Repos,CreateCount,CanCreate,CreateButtonText,LoadAsync,AddFolders,BuildCandidates,CreateCommand,CancelCommand,ShowRepoImportModal,CloseAction}` used consistently across tasks.
|
||||||
|
- **YAGNI:** No recursive scan, no inline rename, no per-list model/prompt/agent during import — all explicitly out of scope.
|
||||||
655
docs/superpowers/plans/2026-05-29-worker-per-user-autostart.md
Normal file
655
docs/superpowers/plans/2026-05-29-worker-per-user-autostart.md
Normal file
@@ -0,0 +1,655 @@
|
|||||||
|
# Worker Per-User Autostart Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Replace the worker's Windows service with a per-user logon Scheduled Task so the worker runs as the logged-in user (Claude auth works), windowless, with file logging and auto-restart.
|
||||||
|
|
||||||
|
**Architecture:** Worker becomes a windowless (`WinExe`) process with Serilog file logging and a single-instance mutex. The installer registers a hidden logon Scheduled Task (via `schtasks /Create /XML`), migrates away the old `ClaudeDoWorker` service, and manages the worker as a process. The app launches/restarts the worker as a process and ensures it's running.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, ASP.NET Core (worker), WPF (installer), Avalonia (app), Serilog, Windows Task Scheduler (`schtasks`), `sc.exe`.
|
||||||
|
|
||||||
|
**Build note:** `.slnx` fails on .NET 8 — always build individual `.csproj` files.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File Structure
|
||||||
|
|
||||||
|
**Worker**
|
||||||
|
- Modify `src/ClaudeDo.Worker/ClaudeDo.Worker.csproj` — WinExe, Serilog packages, drop Hosting.WindowsServices.
|
||||||
|
- Modify `src/ClaudeDo.Worker/Program.cs` — mutex, Serilog, remove `UseWindowsService`.
|
||||||
|
|
||||||
|
**Installer**
|
||||||
|
- Create `src/ClaudeDo.Installer/Core/ScheduledTaskXml.cs` — pure XML builder.
|
||||||
|
- Create `src/ClaudeDo.Installer/Steps/RegisterAutostartStep.cs` — migrate service + register task.
|
||||||
|
- Rename/rewrite `StopServiceStep.cs` → `StopWorkerStep.cs`, `StartServiceStep.cs` → `StartWorkerStep.cs`.
|
||||||
|
- Delete `src/ClaudeDo.Installer/Steps/RegisterServiceStep.cs`.
|
||||||
|
- Modify `Pages/ServicePage/ServicePageViewModel.cs` + `ServicePageView.xaml` — drop account radios.
|
||||||
|
- Modify `Core/InstallContext.cs` — drop `ServiceAccount`.
|
||||||
|
- Modify `Pages/InstallPage/InstallPageViewModel.cs` — pipeline wiring.
|
||||||
|
- Modify `App.xaml.cs` — DI registration.
|
||||||
|
- Modify `Core/UninstallRunner.cs` — task delete + process kill.
|
||||||
|
- Modify `Views/SettingsViewModel.cs` — use renamed steps.
|
||||||
|
|
||||||
|
**App**
|
||||||
|
- Create `src/ClaudeDo.Ui/Services/WorkerLocator.cs` — resolve worker exe path.
|
||||||
|
- Modify `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs` — process restart + ensure-running.
|
||||||
|
- Modify `src/ClaudeDo.App/Program.cs` — register `WorkerLocator`, pass to shell VM if needed.
|
||||||
|
|
||||||
|
**Tests**
|
||||||
|
- Create `tests/ClaudeDo.Installer.Tests/ScheduledTaskXmlTests.cs`.
|
||||||
|
- Create `tests/ClaudeDo.Ui.Tests/Services/WorkerLocatorTests.cs`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: Worker → WinExe + Serilog packages
|
||||||
|
|
||||||
|
**Files:** Modify `src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
|
||||||
|
- [ ] **Step 1:** In the main `<PropertyGroup>` add `<OutputType>WinExe</OutputType>`. Remove the `Microsoft.Extensions.Hosting.WindowsServices` PackageReference. Add:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<PackageReference Include="Serilog.AspNetCore" Version="8.0.3" />
|
||||||
|
<PackageReference Include="Serilog.Sinks.File" Version="6.0.0" />
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2:** Build: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj` — Expected: succeeds (packages restore).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: Worker single-instance mutex + Serilog + drop UseWindowsService
|
||||||
|
|
||||||
|
**Files:** Modify `src/ClaudeDo.Worker/Program.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1:** At the very top of the file (before `var cfg = WorkerConfig.Load();`), add the single-instance guard:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.Threading;
|
||||||
|
|
||||||
|
// Single-instance per user session. Multiple launch paths exist (logon task,
|
||||||
|
// app ensure-running, Restart button); a second instance exits cleanly instead
|
||||||
|
// of fighting over the SignalR port.
|
||||||
|
var mutex = new Mutex(true, @"Local\ClaudeDoWorker", out var createdNew);
|
||||||
|
if (!createdNew)
|
||||||
|
return; // another instance already owns the port; exit 0
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2:** Remove the `builder.Host.UseWindowsService(...)` line (lines ~21-23 incl. the comment).
|
||||||
|
|
||||||
|
- [ ] **Step 3:** After `var builder = WebApplication.CreateBuilder(args);`, add Serilog file logging:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using Serilog;
|
||||||
|
|
||||||
|
var logRoot = ClaudeDo.Data.Paths.Expand(cfg.LogRoot);
|
||||||
|
Directory.CreateDirectory(logRoot);
|
||||||
|
builder.Host.UseSerilog((ctx, lc) => lc
|
||||||
|
.MinimumLevel.Information()
|
||||||
|
.WriteTo.File(
|
||||||
|
System.IO.Path.Combine(logRoot, "worker-.log"),
|
||||||
|
rollingInterval: RollingInterval.Day,
|
||||||
|
retainedFileCountLimit: 7,
|
||||||
|
shared: true));
|
||||||
|
```
|
||||||
|
|
||||||
|
(If `cfg.LogRoot` is already absolute/expanded, `Paths.Expand` is a safe no-op. Verify `WorkerConfig` exposes `LogRoot`; if the property differs, use the actual name.)
|
||||||
|
|
||||||
|
- [ ] **Step 4:** At the very end of the file, after the run block, add `GC.KeepAlive(mutex);` to ensure the mutex isn't collected.
|
||||||
|
|
||||||
|
- [ ] **Step 5:** Build: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj` — Expected: succeeds.
|
||||||
|
|
||||||
|
- [ ] **Step 6:** Run worker tests: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj` — Expected: all pass (set `CLAUDEDO_SKIP_CLI_PREFLIGHT=1` if needed; existing tests already handle this).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: Scheduled-task XML builder (pure, TDD)
|
||||||
|
|
||||||
|
**Files:** Create `src/ClaudeDo.Installer/Core/ScheduledTaskXml.cs`, Test `tests/ClaudeDo.Installer.Tests/ScheduledTaskXmlTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test:**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Installer.Core;
|
||||||
|
using Xunit;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Installer.Tests;
|
||||||
|
|
||||||
|
public class ScheduledTaskXmlTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void Build_EmbedsUserExeAndLogonTrigger()
|
||||||
|
{
|
||||||
|
var xml = ScheduledTaskXml.Build(
|
||||||
|
userId: "MACHINE\\mika",
|
||||||
|
workerExePath: @"C:\Program Files\ClaudeDo\worker\ClaudeDo.Worker.exe",
|
||||||
|
restartIntervalMinutes: 1);
|
||||||
|
|
||||||
|
Assert.Contains("<LogonTrigger>", xml);
|
||||||
|
Assert.Contains("<UserId>MACHINE\\mika</UserId>", xml);
|
||||||
|
Assert.Contains("<LogonType>InteractiveToken</LogonType>", xml);
|
||||||
|
Assert.Contains("<Hidden>true</Hidden>", xml);
|
||||||
|
Assert.Contains("<RunLevel>LeastPrivilege</RunLevel>", xml);
|
||||||
|
Assert.Contains(@"C:\Program Files\ClaudeDo\worker\ClaudeDo.Worker.exe", xml);
|
||||||
|
Assert.Contains("<Interval>PT1M</Interval>", xml);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Build_ClampsRestartIntervalToOneMinuteMinimum()
|
||||||
|
{
|
||||||
|
var xml = ScheduledTaskXml.Build("M\\u", @"C:\w.exe", restartIntervalMinutes: 0);
|
||||||
|
Assert.Contains("<Interval>PT1M</Interval>", xml);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run it, verify fail:** `dotnet test tests/ClaudeDo.Installer.Tests/ClaudeDo.Installer.Tests.csproj --filter ScheduledTaskXmlTests` — Expected: FAIL (type missing).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement:**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.Security;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Installer.Core;
|
||||||
|
|
||||||
|
/// <summary>Builds a Task Scheduler definition XML for the per-user worker autostart.
|
||||||
|
/// Pure function so it can be unit-tested without admin rights.</summary>
|
||||||
|
public static class ScheduledTaskXml
|
||||||
|
{
|
||||||
|
public static string Build(string userId, string workerExePath, int restartIntervalMinutes)
|
||||||
|
{
|
||||||
|
var minutes = restartIntervalMinutes < 1 ? 1 : restartIntervalMinutes;
|
||||||
|
var user = SecurityElement.Escape(userId);
|
||||||
|
var cmd = SecurityElement.Escape(workerExePath);
|
||||||
|
return $"""
|
||||||
|
<?xml version="1.0" encoding="UTF-16"?>
|
||||||
|
<Task version="1.4" xmlns="http://schemas.microsoft.com/windows/2004/02/mit/task">
|
||||||
|
<RegistrationInfo>
|
||||||
|
<Description>ClaudeDo background worker (per-user).</Description>
|
||||||
|
</RegistrationInfo>
|
||||||
|
<Triggers>
|
||||||
|
<LogonTrigger>
|
||||||
|
<Enabled>true</Enabled>
|
||||||
|
<UserId>{user}</UserId>
|
||||||
|
</LogonTrigger>
|
||||||
|
</Triggers>
|
||||||
|
<Principals>
|
||||||
|
<Principal id="Author">
|
||||||
|
<UserId>{user}</UserId>
|
||||||
|
<LogonType>InteractiveToken</LogonType>
|
||||||
|
<RunLevel>LeastPrivilege</RunLevel>
|
||||||
|
</Principal>
|
||||||
|
</Principals>
|
||||||
|
<Settings>
|
||||||
|
<MultipleInstancesPolicy>IgnoreNew</MultipleInstancesPolicy>
|
||||||
|
<DisallowStartIfOnBatteries>false</DisallowStartIfOnBatteries>
|
||||||
|
<StopIfGoingOnBatteries>false</StopIfGoingOnBatteries>
|
||||||
|
<AllowHardTerminate>true</AllowHardTerminate>
|
||||||
|
<StartWhenAvailable>true</StartWhenAvailable>
|
||||||
|
<Hidden>true</Hidden>
|
||||||
|
<ExecutionTimeLimit>PT0S</ExecutionTimeLimit>
|
||||||
|
<RestartOnFailure>
|
||||||
|
<Interval>PT{minutes}M</Interval>
|
||||||
|
<Count>3</Count>
|
||||||
|
</RestartOnFailure>
|
||||||
|
</Settings>
|
||||||
|
<Actions Context="Author">
|
||||||
|
<Exec>
|
||||||
|
<Command>{cmd}</Command>
|
||||||
|
</Exec>
|
||||||
|
</Actions>
|
||||||
|
</Task>
|
||||||
|
""";
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run, verify pass:** same filter — Expected: PASS.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: RegisterAutostartStep (migrate service + register task)
|
||||||
|
|
||||||
|
**Files:** Create `src/ClaudeDo.Installer/Steps/RegisterAutostartStep.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Implement** (no unit test — shells out to `sc`/`schtasks`; logic kept thin):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.IO;
|
||||||
|
using System.Security.Principal;
|
||||||
|
using ClaudeDo.Installer.Core;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Installer.Steps;
|
||||||
|
|
||||||
|
public sealed class RegisterAutostartStep : IInstallStep
|
||||||
|
{
|
||||||
|
public const string TaskName = "ClaudeDoWorker";
|
||||||
|
private const string LegacyServiceName = "ClaudeDoWorker";
|
||||||
|
|
||||||
|
public string Name => "Register Autostart";
|
||||||
|
|
||||||
|
public async Task<StepResult> ExecuteAsync(InstallContext ctx, IProgress<string> progress, CancellationToken ct)
|
||||||
|
{
|
||||||
|
var workerExe = Path.Combine(ctx.InstallDirectory, "worker", "ClaudeDo.Worker.exe");
|
||||||
|
if (!File.Exists(workerExe))
|
||||||
|
return StepResult.Fail($"Worker executable not found: {workerExe}");
|
||||||
|
|
||||||
|
// 1) Migrate away the legacy Windows service if present.
|
||||||
|
progress.Report("Checking for legacy worker service...");
|
||||||
|
var (queryExit, _) = await ProcessRunner.RunAsync("sc.exe", $"query {LegacyServiceName}", null, progress, ct);
|
||||||
|
if (queryExit == 0)
|
||||||
|
{
|
||||||
|
progress.Report("Removing legacy worker service...");
|
||||||
|
await ProcessRunner.RunAsync("sc.exe", $"stop {LegacyServiceName}", null, progress, ct);
|
||||||
|
await ProcessRunner.RunAsync("sc.exe", $"delete {LegacyServiceName}", null, progress, ct);
|
||||||
|
for (var i = 0; i < 30; i++)
|
||||||
|
{
|
||||||
|
ct.ThrowIfCancellationRequested();
|
||||||
|
var (q, _) = await ProcessRunner.RunAsync("sc.exe", $"query {LegacyServiceName}", null, progress, ct);
|
||||||
|
if (q != 0) break;
|
||||||
|
await Task.Delay(1000, ct);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// 2) Register (or replace) the per-user logon task.
|
||||||
|
var userId = WindowsIdentity.GetCurrent().Name;
|
||||||
|
var minutes = Math.Max(1, ctx.RestartDelayMs / 60000);
|
||||||
|
var xml = ScheduledTaskXml.Build(userId, workerExe, minutes);
|
||||||
|
|
||||||
|
var xmlPath = Path.Combine(Path.GetTempPath(), $"ClaudeDoWorker-{Guid.NewGuid():N}.xml");
|
||||||
|
await File.WriteAllTextAsync(xmlPath, xml, new System.Text.UnicodeEncoding(false, true), ct);
|
||||||
|
try
|
||||||
|
{
|
||||||
|
progress.Report("Registering logon task...");
|
||||||
|
var (exit, output) = await ProcessRunner.RunAsync(
|
||||||
|
"schtasks.exe", $"/Create /TN \"{TaskName}\" /XML \"{xmlPath}\" /F", null, progress, ct);
|
||||||
|
if (exit != 0)
|
||||||
|
return StepResult.Fail($"schtasks /Create failed (exit {exit}): {output}");
|
||||||
|
}
|
||||||
|
finally
|
||||||
|
{
|
||||||
|
try { File.Delete(xmlPath); } catch { /* best effort */ }
|
||||||
|
}
|
||||||
|
|
||||||
|
return StepResult.Ok();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build:** `dotnet build src/ClaudeDo.Installer/ClaudeDo.Installer.csproj` — Expected: succeeds (after Task 5/6 it compiles fully; if `RestartDelayMs` exists on `InstallContext` already, this compiles now).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: StopWorkerStep + StartWorkerStep (replace service steps)
|
||||||
|
|
||||||
|
**Files:** Create `src/ClaudeDo.Installer/Steps/StopWorkerStep.cs`, `src/ClaudeDo.Installer/Steps/StartWorkerStep.cs`. Delete `StopServiceStep.cs`, `StartServiceStep.cs`, `RegisterServiceStep.cs`.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Create `StopWorkerStep.cs`:**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.Diagnostics;
|
||||||
|
using System.IO;
|
||||||
|
using ClaudeDo.Installer.Core;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Installer.Steps;
|
||||||
|
|
||||||
|
public sealed class StopWorkerStep : IInstallStep
|
||||||
|
{
|
||||||
|
public const string TaskName = "ClaudeDoWorker";
|
||||||
|
public const string ProcessName = "ClaudeDo.Worker";
|
||||||
|
|
||||||
|
public string Name => "Stop Worker";
|
||||||
|
|
||||||
|
public async Task<StepResult> ExecuteAsync(InstallContext ctx, IProgress<string> progress, CancellationToken ct)
|
||||||
|
{
|
||||||
|
progress.Report("Stopping worker task (if running)...");
|
||||||
|
await ProcessRunner.RunAsync("schtasks.exe", $"/End /TN \"{TaskName}\"", null, progress, ct);
|
||||||
|
|
||||||
|
progress.Report("Stopping worker process (if running)...");
|
||||||
|
var installDir = ctx.InstallDirectory;
|
||||||
|
foreach (var p in Process.GetProcessesByName(ProcessName))
|
||||||
|
{
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var path = p.MainModule?.FileName;
|
||||||
|
if (path is not null && !IsUnder(path, installDir)) continue;
|
||||||
|
p.Kill(entireProcessTree: true);
|
||||||
|
p.WaitForExit(10000);
|
||||||
|
}
|
||||||
|
catch { /* process may have exited or be inaccessible */ }
|
||||||
|
finally { p.Dispose(); }
|
||||||
|
}
|
||||||
|
await Task.CompletedTask;
|
||||||
|
return StepResult.Ok();
|
||||||
|
}
|
||||||
|
|
||||||
|
private static bool IsUnder(string filePath, string dir)
|
||||||
|
{
|
||||||
|
try
|
||||||
|
{
|
||||||
|
if (string.IsNullOrWhiteSpace(dir)) return true; // can't scope — be permissive
|
||||||
|
var full = Path.GetFullPath(filePath);
|
||||||
|
var root = Path.GetFullPath(dir).TrimEnd(Path.DirectorySeparatorChar) + Path.DirectorySeparatorChar;
|
||||||
|
return full.StartsWith(root, StringComparison.OrdinalIgnoreCase);
|
||||||
|
}
|
||||||
|
catch { return false; }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Create `StartWorkerStep.cs`:**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Installer.Core;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Installer.Steps;
|
||||||
|
|
||||||
|
public sealed class StartWorkerStep : IInstallStep
|
||||||
|
{
|
||||||
|
public const string TaskName = "ClaudeDoWorker";
|
||||||
|
|
||||||
|
public string Name => "Start Worker";
|
||||||
|
|
||||||
|
public async Task<StepResult> ExecuteAsync(InstallContext ctx, IProgress<string> progress, CancellationToken ct)
|
||||||
|
{
|
||||||
|
progress.Report("Starting worker...");
|
||||||
|
var (exit, output) = await ProcessRunner.RunAsync("schtasks.exe", $"/Run /TN \"{TaskName}\"", null, progress, ct);
|
||||||
|
if (exit != 0)
|
||||||
|
return StepResult.Fail($"schtasks /Run failed (exit {exit}): {output}");
|
||||||
|
return StepResult.Ok();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3:** Delete `src/ClaudeDo.Installer/Steps/StopServiceStep.cs`, `StartServiceStep.cs`, `RegisterServiceStep.cs`.
|
||||||
|
|
||||||
|
- [ ] **Step 4:** Grep for remaining references: `StopServiceStep`, `StartServiceStep`, `RegisterServiceStep` across `src/` — fix each (Tasks 6-9 cover them).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 6: InstallContext + ServicePage cleanup
|
||||||
|
|
||||||
|
**Files:** Modify `src/ClaudeDo.Installer/Core/InstallContext.cs`, `Pages/ServicePage/ServicePageViewModel.cs`, `Pages/ServicePage/ServicePageView.xaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1:** In `InstallContext.cs` remove the `ServiceAccount` property (keep `AutoStart`, `RestartDelayMs`, `SignalRPort`, `ClaudeBin`, etc.).
|
||||||
|
|
||||||
|
- [ ] **Step 2:** In `ServicePageViewModel.cs` remove `IsLocalSystem`/`IsCurrentUser` `[ObservableProperty]` fields and the `_context.ServiceAccount = ...` line in `ApplyAsync`. Keep port/claudeBin/autostart/restartDelay.
|
||||||
|
|
||||||
|
- [ ] **Step 3:** In `ServicePageView.xaml` remove the radio buttons / account-selection UI bound to those properties. Leave the rest.
|
||||||
|
|
||||||
|
- [ ] **Step 4:** Build: `dotnet build src/ClaudeDo.Installer/ClaudeDo.Installer.csproj` — Expected: succeeds after Tasks 7-9.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 7: Pipeline wiring + DI
|
||||||
|
|
||||||
|
**Files:** Modify `Pages/InstallPage/InstallPageViewModel.cs`, `App.xaml.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1:** In `InstallPageViewModel.LoadAsync`, update the **Update** display steps to:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Steps.Add(new StepViewModel("Stop Worker"));
|
||||||
|
Steps.Add(new StepViewModel("Download and Extract"));
|
||||||
|
Steps.Add(new StepViewModel("Register Autostart"));
|
||||||
|
Steps.Add(new StepViewModel("Start Worker"));
|
||||||
|
Steps.Add(new StepViewModel("Write Install Manifest"));
|
||||||
|
Steps.Add(new StepViewModel("Register in Add/Remove Programs"));
|
||||||
|
```
|
||||||
|
|
||||||
|
And the **Fresh** display steps to:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Steps.Add(new StepViewModel("Download and Extract"));
|
||||||
|
Steps.Add(new StepViewModel("Write Configuration"));
|
||||||
|
Steps.Add(new StepViewModel("Initialize Database"));
|
||||||
|
Steps.Add(new StepViewModel("Register Autostart"));
|
||||||
|
Steps.Add(new StepViewModel("Create Shortcuts"));
|
||||||
|
Steps.Add(new StepViewModel("Register in Add/Remove Programs"));
|
||||||
|
Steps.Add(new StepViewModel("Write Install Manifest"));
|
||||||
|
Steps.Add(new StepViewModel("Start Worker"));
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2:** In `RunInstallAsync`, set the Update execution list to:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
steps = new IInstallStep[]
|
||||||
|
{
|
||||||
|
_serviceProvider.GetRequiredService<StopWorkerStep>(),
|
||||||
|
_serviceProvider.GetRequiredService<DownloadAndExtractStep>(),
|
||||||
|
_serviceProvider.GetRequiredService<RegisterAutostartStep>(),
|
||||||
|
_serviceProvider.GetRequiredService<StartWorkerStep>(),
|
||||||
|
_serviceProvider.GetRequiredService<WriteInstallManifestStep>(),
|
||||||
|
_serviceProvider.GetRequiredService<WriteUninstallRegistryStep>(),
|
||||||
|
};
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3:** In `App.xaml.cs` `BuildServices`, replace the service-step registrations. Fresh-install `IInstallStep` order must be: Download, WriteConfig, InitDatabase, **RegisterAutostart**, CreateShortcuts, WriteUninstallRegistry, WriteInstallManifest, **StartWorker**. Register:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
sc.AddSingleton<DownloadAndExtractStep>();
|
||||||
|
sc.AddSingleton<IInstallStep>(sp => sp.GetRequiredService<DownloadAndExtractStep>());
|
||||||
|
sc.AddSingleton<IInstallStep, WriteConfigStep>();
|
||||||
|
sc.AddSingleton<IInstallStep, InitDatabaseStep>();
|
||||||
|
sc.AddSingleton<RegisterAutostartStep>();
|
||||||
|
sc.AddSingleton<IInstallStep>(sp => sp.GetRequiredService<RegisterAutostartStep>());
|
||||||
|
sc.AddSingleton<IInstallStep, CreateShortcutsStep>();
|
||||||
|
sc.AddSingleton<WriteUninstallRegistryStep>();
|
||||||
|
sc.AddSingleton<IInstallStep>(sp => sp.GetRequiredService<WriteUninstallRegistryStep>());
|
||||||
|
sc.AddSingleton<WriteInstallManifestStep>();
|
||||||
|
sc.AddSingleton<IInstallStep>(sp => sp.GetRequiredService<WriteInstallManifestStep>());
|
||||||
|
sc.AddSingleton<StartWorkerStep>();
|
||||||
|
sc.AddSingleton<IInstallStep>(sp => sp.GetRequiredService<StartWorkerStep>());
|
||||||
|
|
||||||
|
// Not part of the default fresh IEnumerable<IInstallStep> — pulled individually.
|
||||||
|
sc.AddSingleton<StopWorkerStep>();
|
||||||
|
```
|
||||||
|
|
||||||
|
Remove old `StopServiceStep`/`StartServiceStep`/`RegisterServiceStep` registrations.
|
||||||
|
|
||||||
|
- [ ] **Step 4:** Build: `dotnet build src/ClaudeDo.Installer/ClaudeDo.Installer.csproj` — Expected: succeeds after Tasks 8-9.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 8: SettingsViewModel + UninstallRunner
|
||||||
|
|
||||||
|
**Files:** Modify `Views/SettingsViewModel.cs`, `Core/UninstallRunner.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1:** In `SettingsViewModel.cs`, change ctor params/fields `StopServiceStep`/`StartServiceStep` → `StopWorkerStep`/`StartWorkerStep` (rename type usages only; the Save/Repair logic stays). Update the `Repair` step array to `{ _stopWorker, _downloadStep, _startWorker }`.
|
||||||
|
|
||||||
|
- [ ] **Step 2:** In `UninstallRunner.cs`:
|
||||||
|
- Constructor param `StopServiceStep` → `StopWorkerStep` (field too).
|
||||||
|
- Replace `sc.exe delete ClaudeDoWorker` with task removal + legacy service cleanup:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
// 3) Unregister autostart task + remove any legacy service.
|
||||||
|
progress.Report("Removing autostart task...");
|
||||||
|
await ProcessRunner.RunAsync("schtasks.exe", $"/Delete /TN \"{StopWorkerStep.TaskName}\" /F", null, progress, ct);
|
||||||
|
await ProcessRunner.RunAsync("sc.exe", "delete ClaudeDoWorker", null, progress, ct); // legacy, best-effort
|
||||||
|
```
|
||||||
|
|
||||||
|
- The existing `_stopService.ExecuteAsync` call becomes `_stopWorker.ExecuteAsync` (kills the worker process before deleting files).
|
||||||
|
|
||||||
|
- [ ] **Step 3:** Build: `dotnet build src/ClaudeDo.Installer/ClaudeDo.Installer.csproj` — Expected: **succeeds, 0 errors**.
|
||||||
|
|
||||||
|
- [ ] **Step 4:** Run installer tests: `dotnet test tests/ClaudeDo.Installer.Tests/ClaudeDo.Installer.Tests.csproj` — Expected: all pass (incl. new `ScheduledTaskXmlTests`).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 9: App WorkerLocator (TDD)
|
||||||
|
|
||||||
|
**Files:** Create `src/ClaudeDo.Ui/Services/WorkerLocator.cs`, Test `tests/ClaudeDo.Ui.Tests/Services/WorkerLocatorTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write failing test:**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Ui.Services;
|
||||||
|
using Xunit;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Tests.Services;
|
||||||
|
|
||||||
|
public class WorkerLocatorTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void FindByWalkingUp_FindsWorkerExeBesideInstallJson()
|
||||||
|
{
|
||||||
|
var root = Path.Combine(Path.GetTempPath(), "claudedo_wl_" + Guid.NewGuid().ToString("N"));
|
||||||
|
var appDir = Path.Combine(root, "app");
|
||||||
|
var workerDir = Path.Combine(root, "worker");
|
||||||
|
Directory.CreateDirectory(appDir);
|
||||||
|
Directory.CreateDirectory(workerDir);
|
||||||
|
File.WriteAllText(Path.Combine(root, "install.json"), "{}");
|
||||||
|
var exe = Path.Combine(workerDir, "ClaudeDo.Worker.exe");
|
||||||
|
File.WriteAllText(exe, "");
|
||||||
|
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var found = new WorkerLocator().FindByWalkingUp(appDir);
|
||||||
|
Assert.Equal(exe, found);
|
||||||
|
}
|
||||||
|
finally { Directory.Delete(root, recursive: true); }
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void FindByWalkingUp_ReturnsNullWhenNoManifest()
|
||||||
|
{
|
||||||
|
var dir = Path.Combine(Path.GetTempPath(), "claudedo_wl_none_" + Guid.NewGuid().ToString("N"));
|
||||||
|
Directory.CreateDirectory(dir);
|
||||||
|
try { Assert.Null(new WorkerLocator().FindByWalkingUp(dir)); }
|
||||||
|
finally { Directory.Delete(dir, recursive: true); }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run, verify fail:** `dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj --filter WorkerLocatorTests` — Expected: FAIL.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement** (mirror `InstallerLocator`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Ui.Services;
|
||||||
|
|
||||||
|
public sealed class WorkerLocator
|
||||||
|
{
|
||||||
|
private const string InstallJson = "install.json";
|
||||||
|
private const string WorkerExe = "ClaudeDo.Worker.exe";
|
||||||
|
private const string WorkerSubdir = "worker";
|
||||||
|
|
||||||
|
public string? Find()
|
||||||
|
=> FindByWalkingUp(AppContext.BaseDirectory)
|
||||||
|
?? (OperatingSystem.IsWindows() ? FindByRegistry() : null);
|
||||||
|
|
||||||
|
public string? FindByWalkingUp(string startDir)
|
||||||
|
{
|
||||||
|
var dir = new DirectoryInfo(startDir);
|
||||||
|
while (dir is not null)
|
||||||
|
{
|
||||||
|
if (File.Exists(Path.Combine(dir.FullName, InstallJson)))
|
||||||
|
{
|
||||||
|
var candidate = Path.Combine(dir.FullName, WorkerSubdir, WorkerExe);
|
||||||
|
return File.Exists(candidate) ? candidate : null;
|
||||||
|
}
|
||||||
|
dir = dir.Parent;
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
[System.Runtime.Versioning.SupportedOSPlatform("windows")]
|
||||||
|
public string? FindByRegistry()
|
||||||
|
{
|
||||||
|
if (!OperatingSystem.IsWindows()) return null;
|
||||||
|
try
|
||||||
|
{
|
||||||
|
using var key = Microsoft.Win32.Registry.LocalMachine
|
||||||
|
.OpenSubKey(@"Software\Microsoft\Windows\CurrentVersion\Uninstall\ClaudeDo");
|
||||||
|
var location = key?.GetValue("InstallLocation") as string;
|
||||||
|
if (string.IsNullOrEmpty(location)) return null;
|
||||||
|
var candidate = Path.Combine(location, WorkerSubdir, WorkerExe);
|
||||||
|
return File.Exists(candidate) ? candidate : null;
|
||||||
|
}
|
||||||
|
catch { return null; }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run, verify pass.**
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 10: App restart-worker + ensure-running
|
||||||
|
|
||||||
|
**Files:** Modify `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`, `src/ClaudeDo.App/Program.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1:** In `App/Program.cs` register the locator: `sc.AddSingleton<WorkerLocator>();` and ensure `IslandsShellViewModel` receives it (constructor injection; the VM is `AddSingleton<IslandsShellViewModel>()` so DI supplies it).
|
||||||
|
|
||||||
|
- [ ] **Step 2:** In `IslandsShellViewModel`, add a `WorkerLocator` constructor dependency and store it. Replace `RestartWorkerService` (the `ServiceController` version) with a process relaunch:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private void RestartWorkerService()
|
||||||
|
{
|
||||||
|
var exe = _workerLocator.Find();
|
||||||
|
if (exe is null) throw new InvalidOperationException("Worker executable not found.");
|
||||||
|
|
||||||
|
foreach (var p in System.Diagnostics.Process.GetProcessesByName("ClaudeDo.Worker"))
|
||||||
|
{
|
||||||
|
try { p.Kill(entireProcessTree: true); p.WaitForExit(10000); }
|
||||||
|
catch { /* may have exited */ }
|
||||||
|
finally { p.Dispose(); }
|
||||||
|
}
|
||||||
|
System.Diagnostics.Process.Start(new System.Diagnostics.ProcessStartInfo(exe) { UseShellExecute = true });
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Update `RestartWorkerAsync` messages accordingly (drop the "service not installed" `InvalidOperationException` branch wording → generic failure).
|
||||||
|
|
||||||
|
- [ ] **Step 3:** Add ensure-running on startup. After the VM wires up the worker connection, schedule a one-shot check:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private bool _ensureRunningAttempted;
|
||||||
|
|
||||||
|
private async Task EnsureWorkerRunningAsync()
|
||||||
|
{
|
||||||
|
if (_ensureRunningAttempted) return;
|
||||||
|
_ensureRunningAttempted = true;
|
||||||
|
await Task.Delay(TimeSpan.FromSeconds(4));
|
||||||
|
if (_worker.IsConnected) return;
|
||||||
|
var exe = _workerLocator.Find();
|
||||||
|
if (exe is null) return;
|
||||||
|
try { System.Diagnostics.Process.Start(new System.Diagnostics.ProcessStartInfo(exe) { UseShellExecute = true }); }
|
||||||
|
catch { /* logon task is the primary mechanism; this is a convenience */ }
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Call `_ = EnsureWorkerRunningAsync();` from the VM's existing init path (where the connection is started). Use the actual `WorkerClient` field name and its `IsConnected` member.
|
||||||
|
|
||||||
|
- [ ] **Step 4:** Remove `using System.ServiceProcess;` and the `ServiceController` usage. Remove the `System.ServiceProcess.ServiceProcess` package reference from `ClaudeDo.Ui.csproj` if present and now unused.
|
||||||
|
|
||||||
|
- [ ] **Step 5:** Build: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj` — Expected: succeeds.
|
||||||
|
|
||||||
|
- [ ] **Step 6:** Run UI tests: `dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj` — Expected: all pass (incl. `WorkerLocatorTests`). If `IslandsShellViewModel` construction is exercised in a test, supply a `WorkerLocator` instance.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 11: Full build + test sweep
|
||||||
|
|
||||||
|
- [ ] **Step 1:** Build each project:
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
dotnet build src/ClaudeDo.Installer/ClaudeDo.Installer.csproj
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj
|
||||||
|
```
|
||||||
|
Expected: all succeed, 0 errors.
|
||||||
|
|
||||||
|
- [ ] **Step 2:** Run all test projects:
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj
|
||||||
|
dotnet test tests/ClaudeDo.Installer.Tests/ClaudeDo.Installer.Tests.csproj
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj
|
||||||
|
dotnet test tests/ClaudeDo.Releases.Tests/ClaudeDo.Releases.Tests.csproj
|
||||||
|
```
|
||||||
|
Expected: all pass.
|
||||||
|
|
||||||
|
- [ ] **Step 3:** Grep for leftovers: `ServiceController`, `UseWindowsService`, `RegisterServiceStep`, `StopServiceStep`, `StartServiceStep`, `ServiceAccount` in `src/` — Expected: no matches (except the legacy `sc delete ClaudeDoWorker` migration/cleanup strings).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Notes for the implementer
|
||||||
|
- Worker config property for the log directory: confirm the exact name on `WorkerConfig` (spec assumes `LogRoot`). Use the real one.
|
||||||
|
- `ProcessRunner.RunAsync` signature is `(string file, string args, string? workingDir, IProgress<string> progress, CancellationToken ct)` returning `(int ExitCode, string Output)` — match existing call sites.
|
||||||
|
- Keep the legacy `sc delete ClaudeDoWorker` calls (migration + uninstall) so existing service installs are cleaned up.
|
||||||
970
docs/superpowers/plans/2026-05-30-external-mcp-ui-parity.md
Normal file
970
docs/superpowers/plans/2026-05-30-external-mcp-ui-parity.md
Normal file
@@ -0,0 +1,970 @@
|
|||||||
|
# External MCP — UI Parity (Start & Observe) Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Add MCP tools so an external Claude session can fully *start* and *observe* ClaudeDo sessions (list/config management, run history, logs, agent listing, reset-failed, app-settings read), reaching UI parity for those concerns.
|
||||||
|
|
||||||
|
**Architecture:** New focused `[McpServerToolType]` classes in `src/ClaudeDo.Worker/External/`, each injecting an existing worker service (no logic duplication). All registered in the *external* `WebApplication` DI container in `Program.cs`. Mutations broadcast the same SignalR events the hub raises, keeping the UI in sync.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, `ModelContextProtocol.Server`, EF Core (SQLite), xUnit integration tests (real SQLite via `DbFixture`).
|
||||||
|
|
||||||
|
> **Build/test note (from project memory):** `dotnet build ClaudeDo.slnx` fails on .NET 8. Build the csproj directly:
|
||||||
|
> `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
> Test: `dotnet test tests/ClaudeDo.Worker.Tests`
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File Structure
|
||||||
|
|
||||||
|
**Create:**
|
||||||
|
- `src/ClaudeDo.Worker/External/ListMcpTools.cs` — list create/update/delete tools
|
||||||
|
- `src/ClaudeDo.Worker/External/ConfigMcpTools.cs` — list-config + task-config tools + DTO
|
||||||
|
- `src/ClaudeDo.Worker/External/RunHistoryMcpTools.cs` — run history + log read tools + DTO
|
||||||
|
- `src/ClaudeDo.Worker/External/AgentMcpTools.cs` — agent listing tool
|
||||||
|
- `src/ClaudeDo.Worker/External/LifecycleMcpTools.cs` — reset-failed-task tool
|
||||||
|
- `src/ClaudeDo.Worker/External/AppSettingsMcpTools.cs` — app-settings read tool
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/External/ListMcpToolsTests.cs`
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/External/ConfigMcpToolsTests.cs`
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/External/RunHistoryMcpToolsTests.cs`
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/External/LifecycleMcpToolsTests.cs`
|
||||||
|
|
||||||
|
**Modify:**
|
||||||
|
- `src/ClaudeDo.Worker/Program.cs:188-217` — register new tool classes + services in the external builder
|
||||||
|
- `src/ClaudeDo.Worker/CLAUDE.md:27` — remove stale tag tools, refresh the External MCP tool inventory
|
||||||
|
|
||||||
|
**Reference (existing, do not change):**
|
||||||
|
- `ListRepository` — `AddAsync`, `UpdateAsync`, `DeleteAsync`, `GetByIdAsync`, `GetAllAsync`, `GetConfigAsync`, `SetConfigAsync`, `DeleteConfigAsync`
|
||||||
|
- `TaskRepository.UpdateAgentSettingsAsync(taskId, model?, systemPrompt?, agentPath?)`
|
||||||
|
- `TaskRunRepository` — `GetByTaskIdAsync`, `GetByIdAsync`, `GetLatestByTaskIdAsync`
|
||||||
|
- `TaskResetService.ResetAsync(taskId, ct)` — refuses Running, discards worktree, resets to Idle
|
||||||
|
- `AgentFileService.ScanAsync(ct)` → `List<AgentInfo>`; `AgentInfo(string Name, string Description, string Path)`
|
||||||
|
- `AppSettingsRepository.GetAsync()` → `AppSettingsEntity`
|
||||||
|
- `TaskRunEntity` fields: `Id, TaskId, RunNumber, SessionId, IsRetry, ResultMarkdown, StructuredOutputJson, ErrorMarkdown, ExitCode, TurnCount, TokensIn, TokensOut, LogPath, StartedAt, FinishedAt`
|
||||||
|
- `CommitTypeRegistry.DefaultType`
|
||||||
|
- `HubBroadcaster.ListUpdated(id)`, `.TaskUpdated(id)`
|
||||||
|
|
||||||
|
> **Spec refinement (YAGNI):** the spec listed an agent "refresh" tool. `AgentFileService.ScanAsync` reads disk fresh on every call, so a separate refresh is redundant for an MCP client. We implement `ListAgents` only.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: List management tools (`ListMcpTools`)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Worker/External/ListMcpTools.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/External/ListMcpToolsTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Worker.External;
|
||||||
|
using ClaudeDo.Worker.Hub;
|
||||||
|
using ClaudeDo.Worker.Tests.Infrastructure;
|
||||||
|
using Microsoft.AspNetCore.SignalR;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.External;
|
||||||
|
|
||||||
|
internal sealed class ListToolsHubClients : IHubClients
|
||||||
|
{
|
||||||
|
public ListToolsClientProxy Proxy { get; } = new();
|
||||||
|
public IClientProxy All => Proxy;
|
||||||
|
public IClientProxy AllExcept(IReadOnlyList<string> e) => Proxy;
|
||||||
|
public IClientProxy Client(string c) => Proxy;
|
||||||
|
public IClientProxy Clients(IReadOnlyList<string> c) => Proxy;
|
||||||
|
public IClientProxy Group(string g) => Proxy;
|
||||||
|
public IClientProxy GroupExcept(string g, IReadOnlyList<string> e) => Proxy;
|
||||||
|
public IClientProxy Groups(IReadOnlyList<string> g) => Proxy;
|
||||||
|
public IClientProxy User(string u) => Proxy;
|
||||||
|
public IClientProxy Users(IReadOnlyList<string> u) => Proxy;
|
||||||
|
}
|
||||||
|
internal sealed class ListToolsClientProxy : IClientProxy
|
||||||
|
{
|
||||||
|
public Task SendCoreAsync(string m, object?[] a, CancellationToken ct = default) => Task.CompletedTask;
|
||||||
|
}
|
||||||
|
internal sealed class ListToolsHubContext : IHubContext<WorkerHub>
|
||||||
|
{
|
||||||
|
public ListToolsHubClients RecordingClients { get; } = new();
|
||||||
|
public IHubClients Clients => RecordingClients;
|
||||||
|
public IGroupManager Groups => throw new NotImplementedException();
|
||||||
|
}
|
||||||
|
|
||||||
|
public sealed class ListMcpToolsTests : IDisposable
|
||||||
|
{
|
||||||
|
private readonly DbFixture _db = new();
|
||||||
|
private readonly ClaudeDoDbContext _ctx;
|
||||||
|
private readonly ListRepository _lists;
|
||||||
|
private readonly ListMcpTools _sut;
|
||||||
|
|
||||||
|
public ListMcpToolsTests()
|
||||||
|
{
|
||||||
|
_ctx = _db.CreateContext();
|
||||||
|
_lists = new ListRepository(_ctx);
|
||||||
|
_sut = new ListMcpTools(_lists, new HubBroadcaster(new ListToolsHubContext()));
|
||||||
|
}
|
||||||
|
|
||||||
|
public void Dispose() { _ctx.Dispose(); _db.Dispose(); }
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task CreateList_PersistsWithDefaults()
|
||||||
|
{
|
||||||
|
var dto = await _sut.CreateList("My List", null, null, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.Equal("My List", dto.Name);
|
||||||
|
var loaded = await _lists.GetByIdAsync(dto.Id);
|
||||||
|
Assert.NotNull(loaded);
|
||||||
|
Assert.Equal("chore", loaded!.DefaultCommitType);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task UpdateList_PatchesNameWorkingDirAndCommitType()
|
||||||
|
{
|
||||||
|
var created = await _sut.CreateList("orig", null, null, CancellationToken.None);
|
||||||
|
|
||||||
|
var dto = await _sut.UpdateList(created.Id, "renamed", "C:/work", "feat", CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.Equal("renamed", dto.Name);
|
||||||
|
Assert.Equal("C:/work", dto.WorkingDir);
|
||||||
|
var loaded = await _lists.GetByIdAsync(created.Id);
|
||||||
|
Assert.Equal("feat", loaded!.DefaultCommitType);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task UpdateList_NotFound_Throws()
|
||||||
|
{
|
||||||
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
||||||
|
_sut.UpdateList("missing", "x", null, null, CancellationToken.None));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task DeleteList_RemovesList()
|
||||||
|
{
|
||||||
|
var created = await _sut.CreateList("gone", null, null, CancellationToken.None);
|
||||||
|
|
||||||
|
await _sut.DeleteList(created.Id, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.Null(await _lists.GetByIdAsync(created.Id));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter ListMcpToolsTests`
|
||||||
|
Expected: FAIL — `ListMcpTools` does not exist (compile error).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Write minimal implementation**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.ComponentModel;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Worker.Hub;
|
||||||
|
using ModelContextProtocol.Server;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.External;
|
||||||
|
|
||||||
|
public sealed record ListSummaryDto(string Id, string Name, string? WorkingDir, string DefaultCommitType);
|
||||||
|
|
||||||
|
[McpServerToolType]
|
||||||
|
public sealed class ListMcpTools
|
||||||
|
{
|
||||||
|
private readonly ListRepository _lists;
|
||||||
|
private readonly HubBroadcaster _broadcaster;
|
||||||
|
|
||||||
|
public ListMcpTools(ListRepository lists, HubBroadcaster broadcaster)
|
||||||
|
{
|
||||||
|
_lists = lists;
|
||||||
|
_broadcaster = broadcaster;
|
||||||
|
}
|
||||||
|
|
||||||
|
[McpServerTool, Description("Create a new task list. workingDir sets the git repo tasks run against; commitType defaults to 'chore'.")]
|
||||||
|
public async Task<ListSummaryDto> CreateList(
|
||||||
|
string name, string? workingDir, string? commitType, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
if (string.IsNullOrWhiteSpace(name))
|
||||||
|
throw new InvalidOperationException("name is required.");
|
||||||
|
|
||||||
|
var entity = new ListEntity
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid().ToString(),
|
||||||
|
Name = name,
|
||||||
|
WorkingDir = string.IsNullOrWhiteSpace(workingDir) ? null : workingDir,
|
||||||
|
DefaultCommitType = string.IsNullOrWhiteSpace(commitType) ? CommitTypeRegistry.DefaultType : commitType,
|
||||||
|
CreatedAt = DateTime.UtcNow,
|
||||||
|
};
|
||||||
|
await _lists.AddAsync(entity, cancellationToken);
|
||||||
|
await _broadcaster.ListUpdated(entity.Id);
|
||||||
|
return ToDto(entity);
|
||||||
|
}
|
||||||
|
|
||||||
|
[McpServerTool, Description("Rename a list and/or change its working dir and default commit type. Pass null to leave a field unchanged.")]
|
||||||
|
public async Task<ListSummaryDto> UpdateList(
|
||||||
|
string listId, string? name, string? workingDir, string? commitType, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
var entity = await _lists.GetByIdAsync(listId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"List {listId} not found.");
|
||||||
|
|
||||||
|
if (name is not null) entity.Name = name;
|
||||||
|
if (workingDir is not null)
|
||||||
|
entity.WorkingDir = string.IsNullOrWhiteSpace(workingDir) ? null : workingDir;
|
||||||
|
if (commitType is not null)
|
||||||
|
entity.DefaultCommitType = string.IsNullOrWhiteSpace(commitType) ? CommitTypeRegistry.DefaultType : commitType;
|
||||||
|
|
||||||
|
await _lists.UpdateAsync(entity, cancellationToken);
|
||||||
|
await _broadcaster.ListUpdated(listId);
|
||||||
|
return ToDto(entity);
|
||||||
|
}
|
||||||
|
|
||||||
|
[McpServerTool, Description("Delete a list and its tasks. Irreversible.")]
|
||||||
|
public async Task DeleteList(string listId, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
_ = await _lists.GetByIdAsync(listId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"List {listId} not found.");
|
||||||
|
await _lists.DeleteAsync(listId, cancellationToken);
|
||||||
|
await _broadcaster.ListUpdated(listId);
|
||||||
|
}
|
||||||
|
|
||||||
|
private static ListSummaryDto ToDto(ListEntity l) =>
|
||||||
|
new(l.Id, l.Name, l.WorkingDir, l.DefaultCommitType);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
> If `CommitTypeRegistry` is not in scope, add `using ClaudeDo.Data;` (verify its namespace with a quick grep before assuming).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run test to verify it passes**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter ListMcpToolsTests`
|
||||||
|
Expected: PASS (4 tests).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/ListMcpTools.cs tests/ClaudeDo.Worker.Tests/External/ListMcpToolsTests.cs
|
||||||
|
git commit -m "feat(worker): add external MCP list-management tools"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: List & task config tools (`ConfigMcpTools`)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Worker/External/ConfigMcpTools.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/External/ConfigMcpToolsTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Worker.External;
|
||||||
|
using ClaudeDo.Worker.Hub;
|
||||||
|
using ClaudeDo.Worker.Tests.Infrastructure;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.External;
|
||||||
|
|
||||||
|
public sealed class ConfigMcpToolsTests : IDisposable
|
||||||
|
{
|
||||||
|
private readonly DbFixture _db = new();
|
||||||
|
private readonly ClaudeDoDbContext _ctx;
|
||||||
|
private readonly ListRepository _lists;
|
||||||
|
private readonly TaskRepository _tasks;
|
||||||
|
private readonly ConfigMcpTools _sut;
|
||||||
|
|
||||||
|
public ConfigMcpToolsTests()
|
||||||
|
{
|
||||||
|
_ctx = _db.CreateContext();
|
||||||
|
_lists = new ListRepository(_ctx);
|
||||||
|
_tasks = new TaskRepository(_ctx);
|
||||||
|
_sut = new ConfigMcpTools(_lists, _tasks, new HubBroadcaster(new ListToolsHubContext()));
|
||||||
|
}
|
||||||
|
|
||||||
|
public void Dispose() { _ctx.Dispose(); _db.Dispose(); }
|
||||||
|
|
||||||
|
private async Task<string> SeedListAsync()
|
||||||
|
{
|
||||||
|
var id = Guid.NewGuid().ToString();
|
||||||
|
await _lists.AddAsync(new ListEntity { Id = id, Name = "L", CreatedAt = DateTime.UtcNow });
|
||||||
|
return id;
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task SetAndGetListConfig_RoundTrips()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
|
||||||
|
await _sut.SetListConfig(listId, "sonnet", "be terse", null, CancellationToken.None);
|
||||||
|
var cfg = await _sut.GetListConfig(listId, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.NotNull(cfg);
|
||||||
|
Assert.Equal("sonnet", cfg!.Model);
|
||||||
|
Assert.Equal("be terse", cfg.SystemPrompt);
|
||||||
|
Assert.Null(cfg.AgentPath);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task SetListConfig_AllNull_ClearsConfig()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
await _sut.SetListConfig(listId, "sonnet", null, null, CancellationToken.None);
|
||||||
|
|
||||||
|
await _sut.SetListConfig(listId, null, null, null, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.Null(await _sut.GetListConfig(listId, CancellationToken.None));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task SetTaskConfig_PersistsOverrides()
|
||||||
|
{
|
||||||
|
var listId = await SeedListAsync();
|
||||||
|
var task = new TaskEntity
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid().ToString(),
|
||||||
|
ListId = listId,
|
||||||
|
Title = "t",
|
||||||
|
Status = ClaudeDo.Data.Models.TaskStatus.Idle,
|
||||||
|
CreatedAt = DateTime.UtcNow,
|
||||||
|
CommitType = "chore",
|
||||||
|
};
|
||||||
|
await _tasks.AddAsync(task);
|
||||||
|
|
||||||
|
await _sut.SetTaskConfig(task.Id, "opus", null, null, CancellationToken.None);
|
||||||
|
|
||||||
|
var loaded = await _tasks.GetByIdAsync(task.Id);
|
||||||
|
Assert.Equal("opus", loaded!.Model);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter ConfigMcpToolsTests`
|
||||||
|
Expected: FAIL — `ConfigMcpTools` does not exist.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Write minimal implementation**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.ComponentModel;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Worker.Hub;
|
||||||
|
using ModelContextProtocol.Server;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.External;
|
||||||
|
|
||||||
|
public sealed record TaskConfigDto(string? Model, string? SystemPrompt, string? AgentPath);
|
||||||
|
|
||||||
|
[McpServerToolType]
|
||||||
|
public sealed class ConfigMcpTools
|
||||||
|
{
|
||||||
|
private readonly ListRepository _lists;
|
||||||
|
private readonly TaskRepository _tasks;
|
||||||
|
private readonly HubBroadcaster _broadcaster;
|
||||||
|
|
||||||
|
public ConfigMcpTools(ListRepository lists, TaskRepository tasks, HubBroadcaster broadcaster)
|
||||||
|
{
|
||||||
|
_lists = lists;
|
||||||
|
_tasks = tasks;
|
||||||
|
_broadcaster = broadcaster;
|
||||||
|
}
|
||||||
|
|
||||||
|
[McpServerTool, Description("Get a list's default config (model, system prompt, agent path). Returns null if no config is set.")]
|
||||||
|
public async Task<TaskConfigDto?> GetListConfig(string listId, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
var cfg = await _lists.GetConfigAsync(listId, cancellationToken);
|
||||||
|
return cfg is null ? null : new TaskConfigDto(cfg.Model, cfg.SystemPrompt, cfg.AgentPath);
|
||||||
|
}
|
||||||
|
|
||||||
|
[McpServerTool, Description("Set a list's default model/system prompt/agent path. Passing all three as null clears the list config.")]
|
||||||
|
public async Task SetListConfig(
|
||||||
|
string listId, string? model, string? systemPrompt, string? agentPath, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
_ = await _lists.GetByIdAsync(listId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"List {listId} not found.");
|
||||||
|
|
||||||
|
var m = Nullify(model);
|
||||||
|
var sp = Nullify(systemPrompt);
|
||||||
|
var ap = Nullify(agentPath);
|
||||||
|
|
||||||
|
if (m is null && sp is null && ap is null)
|
||||||
|
await _lists.DeleteConfigAsync(listId, cancellationToken);
|
||||||
|
else
|
||||||
|
await _lists.SetConfigAsync(new ListConfigEntity
|
||||||
|
{
|
||||||
|
ListId = listId, Model = m, SystemPrompt = sp, AgentPath = ap,
|
||||||
|
}, cancellationToken);
|
||||||
|
|
||||||
|
await _broadcaster.ListUpdated(listId);
|
||||||
|
}
|
||||||
|
|
||||||
|
[McpServerTool, Description("Set per-task config overrides (model/system prompt/agent path). Pass null to clear a field.")]
|
||||||
|
public async Task SetTaskConfig(
|
||||||
|
string taskId, string? model, string? systemPrompt, string? agentPath, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
_ = await _tasks.GetByIdAsync(taskId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"Task {taskId} not found.");
|
||||||
|
|
||||||
|
await _tasks.UpdateAgentSettingsAsync(taskId, Nullify(model), Nullify(systemPrompt), Nullify(agentPath), cancellationToken);
|
||||||
|
await _broadcaster.TaskUpdated(taskId);
|
||||||
|
}
|
||||||
|
|
||||||
|
private static string? Nullify(string? s) => string.IsNullOrWhiteSpace(s) ? null : s;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
> Verify `UpdateAgentSettingsAsync` accepts a `CancellationToken` (read `TaskRepository.cs:157`). If it does not, drop the `cancellationToken` argument from that call.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run test to verify it passes**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter ConfigMcpToolsTests`
|
||||||
|
Expected: PASS (3 tests).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/ConfigMcpTools.cs tests/ClaudeDo.Worker.Tests/External/ConfigMcpToolsTests.cs
|
||||||
|
git commit -m "feat(worker): add external MCP list/task config tools"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: Run history & log tools (`RunHistoryMcpTools`)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Worker/External/RunHistoryMcpTools.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/External/RunHistoryMcpToolsTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Worker.External;
|
||||||
|
using ClaudeDo.Worker.Tests.Infrastructure;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.External;
|
||||||
|
|
||||||
|
public sealed class RunHistoryMcpToolsTests : IDisposable
|
||||||
|
{
|
||||||
|
private readonly DbFixture _db = new();
|
||||||
|
private readonly ClaudeDoDbContext _ctx;
|
||||||
|
private readonly TaskRunRepository _runs;
|
||||||
|
private readonly RunHistoryMcpTools _sut;
|
||||||
|
|
||||||
|
public RunHistoryMcpToolsTests()
|
||||||
|
{
|
||||||
|
_ctx = _db.CreateContext();
|
||||||
|
_runs = new TaskRunRepository(_ctx);
|
||||||
|
_sut = new RunHistoryMcpTools(_runs);
|
||||||
|
}
|
||||||
|
|
||||||
|
public void Dispose() { _ctx.Dispose(); _db.Dispose(); }
|
||||||
|
|
||||||
|
private async Task SeedTaskAsync(string taskId)
|
||||||
|
{
|
||||||
|
var lists = new ListRepository(_ctx);
|
||||||
|
var tasks = new TaskRepository(_ctx);
|
||||||
|
var listId = Guid.NewGuid().ToString();
|
||||||
|
await lists.AddAsync(new ListEntity { Id = listId, Name = "L", CreatedAt = DateTime.UtcNow });
|
||||||
|
await tasks.AddAsync(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = taskId, ListId = listId, Title = "t",
|
||||||
|
Status = ClaudeDo.Data.Models.TaskStatus.Done, CreatedAt = DateTime.UtcNow, CommitType = "chore",
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task ListRuns_ReturnsProjectedRuns()
|
||||||
|
{
|
||||||
|
var taskId = Guid.NewGuid().ToString();
|
||||||
|
await SeedTaskAsync(taskId);
|
||||||
|
await _runs.AddAsync(new TaskRunEntity
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid().ToString(), TaskId = taskId, RunNumber = 1,
|
||||||
|
IsRetry = false, Prompt = "p", ResultMarkdown = "done", TokensIn = 10, TokensOut = 20,
|
||||||
|
});
|
||||||
|
|
||||||
|
var list = await _sut.ListRuns(taskId, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.Single(list);
|
||||||
|
Assert.Equal("done", list[0].ResultMarkdown);
|
||||||
|
Assert.Equal(10, list[0].TokensIn);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task GetTaskLog_NoLog_Throws()
|
||||||
|
{
|
||||||
|
var taskId = Guid.NewGuid().ToString();
|
||||||
|
await SeedTaskAsync(taskId);
|
||||||
|
|
||||||
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
||||||
|
_sut.GetTaskLog(taskId, CancellationToken.None));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task GetTaskLog_ReadsLatestRunLogFile()
|
||||||
|
{
|
||||||
|
var taskId = Guid.NewGuid().ToString();
|
||||||
|
await SeedTaskAsync(taskId);
|
||||||
|
var logPath = Path.Combine(Path.GetTempPath(), $"claudedo_log_{Guid.NewGuid():N}.txt");
|
||||||
|
await File.WriteAllTextAsync(logPath, "hello log");
|
||||||
|
await _runs.AddAsync(new TaskRunEntity
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid().ToString(), TaskId = taskId, RunNumber = 1,
|
||||||
|
IsRetry = false, Prompt = "p", LogPath = logPath,
|
||||||
|
});
|
||||||
|
|
||||||
|
var content = await _sut.GetTaskLog(taskId, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.Equal("hello log", content);
|
||||||
|
File.Delete(logPath);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter RunHistoryMcpToolsTests`
|
||||||
|
Expected: FAIL — `RunHistoryMcpTools` does not exist.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Write minimal implementation**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.ComponentModel;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ModelContextProtocol.Server;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.External;
|
||||||
|
|
||||||
|
public sealed record RunDto(
|
||||||
|
string Id, int RunNumber, string? SessionId, bool IsRetry,
|
||||||
|
string? ResultMarkdown, string? StructuredOutputJson, string? ErrorMarkdown,
|
||||||
|
int? ExitCode, int? TurnCount, int? TokensIn, int? TokensOut,
|
||||||
|
DateTime? StartedAt, DateTime? FinishedAt);
|
||||||
|
|
||||||
|
[McpServerToolType]
|
||||||
|
public sealed class RunHistoryMcpTools
|
||||||
|
{
|
||||||
|
private readonly TaskRunRepository _runs;
|
||||||
|
|
||||||
|
public RunHistoryMcpTools(TaskRunRepository runs) => _runs = runs;
|
||||||
|
|
||||||
|
[McpServerTool, Description("List all execution runs for a task (newest run metadata, tokens, turns, result, error).")]
|
||||||
|
public async Task<IReadOnlyList<RunDto>> ListRuns(string taskId, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
var runs = await _runs.GetByTaskIdAsync(taskId, cancellationToken);
|
||||||
|
return runs.Select(ToDto).ToList();
|
||||||
|
}
|
||||||
|
|
||||||
|
[McpServerTool, Description("Get a single execution run by its run id.")]
|
||||||
|
public async Task<RunDto> GetRun(string runId, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
var run = await _runs.GetByIdAsync(runId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"Run {runId} not found.");
|
||||||
|
return ToDto(run);
|
||||||
|
}
|
||||||
|
|
||||||
|
[McpServerTool, Description("Fetch the raw log output of a task's latest run. Throws if no log is available.")]
|
||||||
|
public async Task<string> GetTaskLog(string taskId, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
var run = await _runs.GetLatestByTaskIdAsync(taskId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"No runs found for task {taskId}.");
|
||||||
|
if (string.IsNullOrWhiteSpace(run.LogPath) || !File.Exists(run.LogPath))
|
||||||
|
throw new InvalidOperationException("No log available for the latest run.");
|
||||||
|
return await File.ReadAllTextAsync(run.LogPath, cancellationToken);
|
||||||
|
}
|
||||||
|
|
||||||
|
private static RunDto ToDto(TaskRunEntity r) => new(
|
||||||
|
r.Id, r.RunNumber, r.SessionId, r.IsRetry,
|
||||||
|
r.ResultMarkdown, r.StructuredOutputJson, r.ErrorMarkdown,
|
||||||
|
r.ExitCode, r.TurnCount, r.TokensIn, r.TokensOut,
|
||||||
|
r.StartedAt, r.FinishedAt);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run test to verify it passes**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter RunHistoryMcpToolsTests`
|
||||||
|
Expected: PASS (3 tests).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/RunHistoryMcpTools.cs tests/ClaudeDo.Worker.Tests/External/RunHistoryMcpToolsTests.cs
|
||||||
|
git commit -m "feat(worker): add external MCP run-history and log tools"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: Agent listing tool (`AgentMcpTools`)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Worker/External/AgentMcpTools.cs`
|
||||||
|
- Test: none new — covered indirectly; `AgentFileService` already has unit coverage. (This tool is a thin pass-through.)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write minimal implementation**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.ComponentModel;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Worker.Agents;
|
||||||
|
using ModelContextProtocol.Server;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.External;
|
||||||
|
|
||||||
|
[McpServerToolType]
|
||||||
|
public sealed class AgentMcpTools
|
||||||
|
{
|
||||||
|
private readonly AgentFileService _agents;
|
||||||
|
|
||||||
|
public AgentMcpTools(AgentFileService agents) => _agents = agents;
|
||||||
|
|
||||||
|
[McpServerTool, Description("List available agent definition files (name, description, path) for use as a task's agent path.")]
|
||||||
|
public async Task<IReadOnlyList<AgentInfo>> ListAgents(CancellationToken cancellationToken)
|
||||||
|
=> await _agents.ScanAsync(cancellationToken);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/AgentMcpTools.cs
|
||||||
|
git commit -m "feat(worker): add external MCP agent-listing tool"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: Reset-failed-task tool (`LifecycleMcpTools`)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Worker/External/LifecycleMcpTools.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/External/LifecycleMcpToolsTests.cs`
|
||||||
|
|
||||||
|
`TaskResetService.ResetAsync` already refuses Running tasks and discards the worktree. The MCP tool adds a guard that the task must be `Failed` (the only sensible reset target via this surface) and delegates.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Worker.External;
|
||||||
|
using ClaudeDo.Worker.Hub;
|
||||||
|
using ClaudeDo.Worker.Lifecycle;
|
||||||
|
using ClaudeDo.Worker.Runner;
|
||||||
|
using ClaudeDo.Worker.State;
|
||||||
|
using ClaudeDo.Worker.Tests.Infrastructure;
|
||||||
|
using ClaudeDo.Worker.Tests.Services;
|
||||||
|
using ClaudeDo.Data.Git;
|
||||||
|
using ClaudeDo.Worker.Config;
|
||||||
|
using Microsoft.Extensions.Logging.Abstractions;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.External;
|
||||||
|
|
||||||
|
public sealed class LifecycleMcpToolsTests : IDisposable
|
||||||
|
{
|
||||||
|
private readonly DbFixture _db = new();
|
||||||
|
private readonly ClaudeDoDbContext _ctx;
|
||||||
|
private readonly TaskRepository _tasks;
|
||||||
|
private readonly ListRepository _lists;
|
||||||
|
|
||||||
|
public LifecycleMcpToolsTests()
|
||||||
|
{
|
||||||
|
_ctx = _db.CreateContext();
|
||||||
|
_tasks = new TaskRepository(_ctx);
|
||||||
|
_lists = new ListRepository(_ctx);
|
||||||
|
}
|
||||||
|
|
||||||
|
public void Dispose() { _ctx.Dispose(); _db.Dispose(); }
|
||||||
|
|
||||||
|
private LifecycleMcpTools BuildSut()
|
||||||
|
{
|
||||||
|
var cfg = new WorkerConfig
|
||||||
|
{
|
||||||
|
SandboxRoot = Path.Combine(Path.GetTempPath(), $"cd_{Guid.NewGuid():N}"),
|
||||||
|
LogRoot = Path.Combine(Path.GetTempPath(), $"cdl_{Guid.NewGuid():N}"),
|
||||||
|
};
|
||||||
|
var dbFactory = _db.CreateFactory();
|
||||||
|
var broadcaster = new HubBroadcaster(new ListToolsHubContext());
|
||||||
|
var wtManager = new WorktreeManager(new GitService(), dbFactory, cfg, NullLogger<WorktreeManager>.Instance);
|
||||||
|
var state = TaskStateServiceBuilder.Build(dbFactory).State;
|
||||||
|
var reset = new TaskResetService(dbFactory, wtManager, broadcaster, state, NullLogger<TaskResetService>.Instance);
|
||||||
|
return new LifecycleMcpTools(_tasks, reset);
|
||||||
|
}
|
||||||
|
|
||||||
|
private async Task<TaskEntity> SeedTaskAsync(TaskStatus status)
|
||||||
|
{
|
||||||
|
var listId = Guid.NewGuid().ToString();
|
||||||
|
await _lists.AddAsync(new ListEntity { Id = listId, Name = "L", CreatedAt = DateTime.UtcNow });
|
||||||
|
var task = new TaskEntity
|
||||||
|
{
|
||||||
|
Id = Guid.NewGuid().ToString(), ListId = listId, Title = "t",
|
||||||
|
Status = status, CreatedAt = DateTime.UtcNow, CommitType = "chore",
|
||||||
|
};
|
||||||
|
await _tasks.AddAsync(task);
|
||||||
|
return task;
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task ResetFailedTask_OnFailed_ResetsToIdle()
|
||||||
|
{
|
||||||
|
var task = await SeedTaskAsync(TaskStatus.Failed);
|
||||||
|
var sut = BuildSut();
|
||||||
|
|
||||||
|
await sut.ResetFailedTask(task.Id, CancellationToken.None);
|
||||||
|
|
||||||
|
var loaded = await _tasks.GetByIdAsync(task.Id);
|
||||||
|
Assert.Equal(TaskStatus.Idle, loaded!.Status);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task ResetFailedTask_OnNonFailed_Throws()
|
||||||
|
{
|
||||||
|
var task = await SeedTaskAsync(TaskStatus.Done);
|
||||||
|
var sut = BuildSut();
|
||||||
|
|
||||||
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
||||||
|
sut.ResetFailedTask(task.Id, CancellationToken.None));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task ResetFailedTask_NotFound_Throws()
|
||||||
|
{
|
||||||
|
var sut = BuildSut();
|
||||||
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
||||||
|
sut.ResetFailedTask("missing", CancellationToken.None));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter LifecycleMcpToolsTests`
|
||||||
|
Expected: FAIL — `LifecycleMcpTools` does not exist.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Write minimal implementation**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.ComponentModel;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Worker.Lifecycle;
|
||||||
|
using ModelContextProtocol.Server;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.External;
|
||||||
|
|
||||||
|
[McpServerToolType]
|
||||||
|
public sealed class LifecycleMcpTools
|
||||||
|
{
|
||||||
|
private readonly TaskRepository _tasks;
|
||||||
|
private readonly TaskResetService _reset;
|
||||||
|
|
||||||
|
public LifecycleMcpTools(TaskRepository tasks, TaskResetService reset)
|
||||||
|
{
|
||||||
|
_tasks = tasks;
|
||||||
|
_reset = reset;
|
||||||
|
}
|
||||||
|
|
||||||
|
[McpServerTool, Description("Reset a failed task: discards its worktree and returns it to Idle so it can be run again. Only Failed tasks are accepted.")]
|
||||||
|
public async Task ResetFailedTask(string taskId, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
var task = await _tasks.GetByIdAsync(taskId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"Task {taskId} not found.");
|
||||||
|
if (task.Status != TaskStatus.Failed)
|
||||||
|
throw new InvalidOperationException($"Task {taskId} is {task.Status}, not Failed. Only failed tasks can be reset via this tool.");
|
||||||
|
|
||||||
|
await _reset.ResetAsync(taskId, cancellationToken);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run test to verify it passes**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter LifecycleMcpToolsTests`
|
||||||
|
Expected: PASS (3 tests). (Git-dependent worktree discard is skipped when no worktree row exists — these tasks have none.)
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/LifecycleMcpTools.cs tests/ClaudeDo.Worker.Tests/External/LifecycleMcpToolsTests.cs
|
||||||
|
git commit -m "feat(worker): add external MCP reset-failed-task tool"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 6: App-settings read tool (`AppSettingsMcpTools`)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Worker/External/AppSettingsMcpTools.cs`
|
||||||
|
- Test: none new — thin read-only pass-through over `AppSettingsRepository.GetAsync`.
|
||||||
|
|
||||||
|
This tool is read-only by design (writing app settings is out of scope). It uses the db factory (registered as a singleton in the external builder) to open a context per call, mirroring the hub's pattern.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write minimal implementation**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.ComponentModel;
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using ModelContextProtocol.Server;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.External;
|
||||||
|
|
||||||
|
public sealed record AppSettingsReadDto(
|
||||||
|
string DefaultModel, int DefaultMaxTurns, string DefaultPermissionMode,
|
||||||
|
string WorktreeStrategy, string? CentralWorktreeRoot,
|
||||||
|
bool WorktreeAutoCleanupEnabled, int WorktreeAutoCleanupDays);
|
||||||
|
|
||||||
|
[McpServerToolType]
|
||||||
|
public sealed class AppSettingsMcpTools
|
||||||
|
{
|
||||||
|
private readonly IDbContextFactory<ClaudeDoDbContext> _dbFactory;
|
||||||
|
|
||||||
|
public AppSettingsMcpTools(IDbContextFactory<ClaudeDoDbContext> dbFactory) => _dbFactory = dbFactory;
|
||||||
|
|
||||||
|
[McpServerTool, Description("Read the worker's app-level defaults (model, max turns, permission mode, worktree strategy). Read-only.")]
|
||||||
|
public async Task<AppSettingsReadDto> GetAppSettings(CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
using var ctx = await _dbFactory.CreateDbContextAsync(cancellationToken);
|
||||||
|
var row = await new AppSettingsRepository(ctx).GetAsync();
|
||||||
|
return new AppSettingsReadDto(
|
||||||
|
row.DefaultModel, row.DefaultMaxTurns, row.DefaultPermissionMode,
|
||||||
|
row.WorktreeStrategy, row.CentralWorktreeRoot,
|
||||||
|
row.WorktreeAutoCleanupEnabled, row.WorktreeAutoCleanupDays);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
> Verify `AppSettingsRepository.GetAsync` signature (it may take a `CancellationToken`). Adjust the call if so. Confirm `AppSettingsEntity` property names match (`DefaultModel`, `DefaultMaxTurns`, `DefaultPermissionMode`, `WorktreeStrategy`, `CentralWorktreeRoot`, `WorktreeAutoCleanupEnabled`, `WorktreeAutoCleanupDays`) — they are used identically in `WorkerHub.GetAppSettings` (lines 206-219).
|
||||||
|
|
||||||
|
- [ ] **Step 2: Verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/AppSettingsMcpTools.cs
|
||||||
|
git commit -m "feat(worker): add external MCP app-settings read tool"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 7: Register new tools in the external MCP app
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Program.cs:188-217`
|
||||||
|
|
||||||
|
The external `WebApplication` has its own DI container. Each new tool class and every service it needs must be registered there, and each class added via `.WithTools<T>()`.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add service + tool registrations**
|
||||||
|
|
||||||
|
In the `if (cfg.ExternalMcpPort > 0)` block, after the existing
|
||||||
|
`externalBuilder.Services.AddScoped<ExternalMcpService>();` line, add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
externalBuilder.Services.AddScoped<TaskRunRepository>();
|
||||||
|
externalBuilder.Services.AddSingleton(app.Services.GetRequiredService<WorktreeManager>());
|
||||||
|
externalBuilder.Services.AddSingleton(app.Services.GetRequiredService<AgentFileService>());
|
||||||
|
externalBuilder.Services.AddScoped<TaskResetService>();
|
||||||
|
externalBuilder.Services.AddScoped<ListMcpTools>();
|
||||||
|
externalBuilder.Services.AddScoped<ConfigMcpTools>();
|
||||||
|
externalBuilder.Services.AddScoped<RunHistoryMcpTools>();
|
||||||
|
externalBuilder.Services.AddScoped<AgentMcpTools>();
|
||||||
|
externalBuilder.Services.AddScoped<LifecycleMcpTools>();
|
||||||
|
externalBuilder.Services.AddScoped<AppSettingsMcpTools>();
|
||||||
|
```
|
||||||
|
|
||||||
|
And extend the `AddMcpServer()` chain:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
externalBuilder.Services.AddMcpServer()
|
||||||
|
.WithHttpTransport()
|
||||||
|
.WithTools<ExternalMcpService>()
|
||||||
|
.WithTools<ListMcpTools>()
|
||||||
|
.WithTools<ConfigMcpTools>()
|
||||||
|
.WithTools<RunHistoryMcpTools>()
|
||||||
|
.WithTools<AgentMcpTools>()
|
||||||
|
.WithTools<LifecycleMcpTools>()
|
||||||
|
.WithTools<AppSettingsMcpTools>();
|
||||||
|
```
|
||||||
|
|
||||||
|
> **Verify before editing:** confirm `WorktreeManager` and `AgentFileService` are registered as singletons in the *main* `app` container (grep `Program.cs` for `WorktreeManager` and `AgentFileService`). If `AgentFileService` is constructed with a directory string rather than DI-resolved, register it in the external builder the same way the main app does (e.g. `new AgentFileService(agentsDir)`), not via `GetRequiredService`. `TaskResetService` depends on `WorktreeManager`, `IDbContextFactory`, `HubBroadcaster`, `ITaskStateService`, `ILogger<TaskResetService>` — all already singletons in the external builder except `WorktreeManager` (added above) and the logger (provided by default logging).
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build the worker**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
Expected: Build succeeded, no DI-related compile errors.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Run the full worker test suite**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests`
|
||||||
|
Expected: PASS (all existing + new tests).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Program.cs
|
||||||
|
git commit -m "feat(worker): register new external MCP tool classes"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 8: Documentation cleanup
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/CLAUDE.md:27`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Replace the stale External MCP inventory line**
|
||||||
|
|
||||||
|
Replace the line beginning `- **External/ExternalMcpService** — always-on MCP tools…` with an accurate inventory that drops the (non-existent) tag tools and lists the new surface:
|
||||||
|
|
||||||
|
```markdown
|
||||||
|
- **External/*** — always-on MCP tools for general Claude sessions, organized by concern:
|
||||||
|
- `ExternalMcpService` — task CRUD + execution: `ListTaskLists`, `ListTasks`, `GetTask`, `AddTask`, `UpdateTask`, `UpdateTaskStatus` (`Idle`/`Queued`), `RunTaskNow`, `CancelTask`, `DeleteTask`
|
||||||
|
- `ListMcpTools` — `CreateList`, `UpdateList`, `DeleteList`
|
||||||
|
- `ConfigMcpTools` — `GetListConfig`, `SetListConfig`, `SetTaskConfig`
|
||||||
|
- `RunHistoryMcpTools` — `ListRuns`, `GetRun`, `GetTaskLog`
|
||||||
|
- `AgentMcpTools` — `ListAgents`
|
||||||
|
- `LifecycleMcpTools` — `ResetFailedTask`
|
||||||
|
- `AppSettingsMcpTools` — `GetAppSettings` (read-only)
|
||||||
|
- Purpose is scoped to *starting* and *observing* sessions — no worktree/merge, multi-turn, planning, or app-settings writes. Auth via optional `X-ClaudeDo-Key` header.
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/CLAUDE.md
|
||||||
|
git commit -m "docs(worker): correct external MCP tool inventory, drop removed tags"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Self-Review
|
||||||
|
|
||||||
|
**Spec coverage:**
|
||||||
|
- List management → Task 1 ✓
|
||||||
|
- List & task config → Task 2 ✓
|
||||||
|
- Run history & logs → Task 3 ✓
|
||||||
|
- Agents (read-only) → Task 4 ✓
|
||||||
|
- Reset failed task → Task 5 ✓
|
||||||
|
- App settings (read-only) → Task 6 ✓
|
||||||
|
- DI wiring (separate external app) → Task 7 ✓
|
||||||
|
- Tag doc cleanup → Task 8 ✓
|
||||||
|
- Out-of-scope items (multi-turn, worktree ops, planning, app-settings writes, tags, agent create/edit) → not implemented ✓
|
||||||
|
|
||||||
|
**Placeholder scan:** No TBD/TODO. The three "verify before editing" notes point at real signatures the implementer must confirm (cancellation-token overloads, `AgentFileService` construction, registry namespaces) — these are verification steps with concrete fallbacks, not placeholders.
|
||||||
|
|
||||||
|
**Type consistency:** `ListSummaryDto`, `TaskConfigDto`, `RunDto`, `AppSettingsReadDto` defined once and used consistently. `AgentInfo` reused directly (no new DTO). Tool method names match between implementation, tests, and the Task-8 doc inventory (`CreateList`/`UpdateList`/`DeleteList`, `GetListConfig`/`SetListConfig`/`SetTaskConfig`, `ListRuns`/`GetRun`/`GetTaskLog`, `ListAgents`, `ResetFailedTask`, `GetAppSettings`).
|
||||||
@@ -0,0 +1,36 @@
|
|||||||
|
# UI Normalization — Visual Check
|
||||||
|
|
||||||
|
Run the app and walk each surface. Lane B intentionally shifted some values (12px→13px, 9px→10px, 16px→18px, off-palette colors folded to the palette), so small differences are expected — you're checking nothing looks *broken*.
|
||||||
|
|
||||||
|
## Global
|
||||||
|
- [ ] All text renders in **Inter Tight** (sans), not Segoe UI. Labels that were previously "off" (Settings field labels) now match.
|
||||||
|
- [ ] Mono text (chips, log lines, file paths, eyebrows, titlebar titles) still renders in JetBrains Mono.
|
||||||
|
|
||||||
|
## Main window
|
||||||
|
- [ ] Status-bar connection dot color: online = moss green, reconnecting = peat/amber, offline = blood red.
|
||||||
|
- [ ] Islands, task rows, chips, agent strips, terminal all look unchanged.
|
||||||
|
|
||||||
|
## Task row
|
||||||
|
- [ ] Schedule flyout (the date popup) renders with a visible border (was a broken/missing `BorderBrush` key — now `LineBrush`).
|
||||||
|
|
||||||
|
## Modals — now wrapped in ModalShell (check titlebar drag, ✕ close, footer buttons)
|
||||||
|
- [ ] **Settings** — titlebar "SETTINGS", drag works, ✕ closes, Cancel/Save footer. Tabs (General/Worktrees/Files/Prime Claude) intact.
|
||||||
|
- [ ] **List settings** — Delete (left) + Cancel/Save (right) footer; section panels intact.
|
||||||
|
- [ ] **Merge** — task summary + action buttons.
|
||||||
|
- [ ] **About** — version/data/logs/config labels.
|
||||||
|
- [ ] **Unfinished planning** — body text + primary action.
|
||||||
|
- [ ] **Repo import** — toolbar at top of body, repo list scrolls, footer.
|
||||||
|
- [ ] **Worktrees overview** — rows render; force-remove/phantom text is red (StatusError); state badge text legible. NOTE: window decorations changed to borderless (ModalShell draws the border) — confirm it still looks right.
|
||||||
|
- [ ] **Diff modal** — diff text mono, add/del colors, merge button in footer.
|
||||||
|
- [ ] **Conflict resolution** — now ModalShell; conflict list mono; error text red.
|
||||||
|
|
||||||
|
## Not wrapped in ModalShell (intentional — distinct chrome)
|
||||||
|
- [ ] **Worktree modal** (the big 1100×720 acrylic-blur diff window) — unchanged look, fonts slightly normalized.
|
||||||
|
- [ ] **Planning diff view** (embedded) — diff renders, mono font, warning text red.
|
||||||
|
|
||||||
|
## Date picker
|
||||||
|
- [ ] Selected day: accent background with light text (was hardcoded white → TextBrush).
|
||||||
|
|
||||||
|
## If something looks wrong
|
||||||
|
- Font/size off → check the snap mapping in `2026-05-30-ui-normalization.md` (11→Mono=11, 12→Body=13).
|
||||||
|
- A modal's layout broke → that modal's body may have coupled to the old Grid rows; revert just that file's ModalShell wrap and keep only the token changes (the fallback noted in the plan).
|
||||||
473
docs/superpowers/plans/2026-05-30-ui-normalization.md
Normal file
473
docs/superpowers/plans/2026-05-30-ui-normalization.md
Normal file
@@ -0,0 +1,473 @@
|
|||||||
|
# UI Normalization Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Make the design tokens the single source of truth for every visual value in the Avalonia UI, remove duplicated styles, and add a reusable `ModalShell` control for the copy-pasted modal chrome.
|
||||||
|
|
||||||
|
**Architecture:** Establish global control defaults in `App.axaml`, expand/repoint brushes in `Tokens.axaml`, promote shared styles into `IslandStyles.axaml`, then mechanically migrate every view to reference tokens (snapping stray values to the nearest token per "lane B"). Off-palette colors fold into the existing palette. A new `ModalShell` templated control replaces the per-modal titlebar/border/footer markup.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, Avalonia 12 (Fluent theme, dark variant), compiled XAML (`x:DataType`), CommunityToolkit.Mvvm.
|
||||||
|
|
||||||
|
**Verification model:** There are no unit tests for XAML. The "test" for every task is a clean build:
|
||||||
|
- `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj` (compiles Ui + Data; validates all StaticResource keys and compiled bindings)
|
||||||
|
|
||||||
|
Build with the `.csproj` directly — `.slnx` requires .NET 9 and will fail on this machine (.NET 8).
|
||||||
|
|
||||||
|
**Normalization rules (apply everywhere unless a task says otherwise):**
|
||||||
|
|
||||||
|
Font sizes — replace every `FontSize="N"` literal with the token whose value it snaps to:
|
||||||
|
| literal | token |
|
||||||
|
|---|---|
|
||||||
|
| 9 | `{StaticResource FontSizeEyebrow}` (10) |
|
||||||
|
| 10 | `{StaticResource FontSizeEyebrow}` (10) |
|
||||||
|
| 11 | `{StaticResource FontSizeMono}` (11) |
|
||||||
|
| 12 | `{StaticResource FontSizeBody}` (13) |
|
||||||
|
| 13 | `{StaticResource FontSizeBody}` (13) |
|
||||||
|
| 14 | `{StaticResource FontSizeTaskTitle}` (14) |
|
||||||
|
| 16 | `{StaticResource FontSizeH3}` (18) |
|
||||||
|
| 18 | `{StaticResource FontSizeH3}` (18) |
|
||||||
|
| 24 | `{StaticResource FontSizeH2}` (24) |
|
||||||
|
| 32 | `{StaticResource FontSizeH1}` (32) |
|
||||||
|
|
||||||
|
Spacing — modal body padding literals `16` and `20` snap to `18`; keep other axis values mapped to the nearest of SpaceXs=4/SpaceSm=8/SpaceMd=12/SpaceLg=14/SpaceXl=18/Space2Xl=24. Leave values that already equal a token as plain numbers (do **not** churn every margin into a resource ref — only modal body padding is standardized).
|
||||||
|
|
||||||
|
Corner radius — `4` → `6`; TextBox inputs use `8`.
|
||||||
|
|
||||||
|
Colors — fold off-palette to palette:
|
||||||
|
| literal / named | replacement |
|
||||||
|
|---|---|
|
||||||
|
| `#4CAF50` (online dot) | `{DynamicResource StatusRunningBrush}` |
|
||||||
|
| `#FFA726` (reconnecting dot) | `{DynamicResource StatusReviewBrush}` |
|
||||||
|
| `#EF5350` (offline / phantom) | `{DynamicResource StatusErrorBrush}` |
|
||||||
|
| `OrangeRed`, `Orange` | `{DynamicResource BloodBrush}` |
|
||||||
|
| `White` (badge / danger text) | `{DynamicResource TextBrush}` |
|
||||||
|
| `White` (on accent primary button) | `{DynamicResource DeepBrush}` |
|
||||||
|
| `#FF080C0B` (terminal bg) | `{DynamicResource VoidBrush}` |
|
||||||
|
| `#0DFFFFFF` (island hairline) | `{DynamicResource HairlineOverlayBrush}` |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Phase 1 — Foundation
|
||||||
|
|
||||||
|
### Task 1: Add new brushes & repoint badges in Tokens.axaml
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Design/Tokens.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add named tint, hairline brushes**
|
||||||
|
|
||||||
|
In the BRUSHES section (after the Status*Brush block ending ~line 85), add:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<!-- Subtle white overlay (island hairline border) -->
|
||||||
|
<SolidColorBrush x:Key="HairlineOverlayBrush" Color="#0DFFFFFF" />
|
||||||
|
|
||||||
|
<!-- Status tints (12% fill / 30% border of the status hue) — reused by chips & agent strips -->
|
||||||
|
<SolidColorBrush x:Key="RunningTintBrush" Color="#1F7C9166" />
|
||||||
|
<SolidColorBrush x:Key="RunningTintBorderBrush" Color="#4C7C9166" />
|
||||||
|
<SolidColorBrush x:Key="ReviewTintBrush" Color="#1FD4A574" />
|
||||||
|
<SolidColorBrush x:Key="ReviewTintBorderBrush" Color="#4CD4A574" />
|
||||||
|
<SolidColorBrush x:Key="ErrorTintBrush" Color="#1FC87060" />
|
||||||
|
<SolidColorBrush x:Key="ErrorTintBorderBrush" Color="#4CC87060" />
|
||||||
|
<SolidColorBrush x:Key="QueuedTintBrush" Color="#1F8B9D7A" />
|
||||||
|
<SolidColorBrush x:Key="QueuedTintBorderBrush" Color="#4C8B9D7A" />
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build to verify tokens parse**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: PASS (no errors).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Design/Tokens.axaml
|
||||||
|
git commit -m "feat(ui): add named tint and hairline overlay brush tokens"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 2: Global control defaults in App.axaml
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.App/App.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add Window default style**
|
||||||
|
|
||||||
|
Inside `<Application.Styles>`, after `<StyleInclude Source="avares://ClaudeDo.Ui/Design/IslandStyles.axaml" />` and before the ListBoxItem styles, add:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<!-- Global defaults: every Window inherits Inter Tight + body size.
|
||||||
|
Controls that need mono opt in via their own class/style. -->
|
||||||
|
<Style Selector="Window">
|
||||||
|
<Setter Property="FontFamily" Value="{DynamicResource SansFont}" />
|
||||||
|
<Setter Property="FontSize" Value="{DynamicResource FontSizeBody}" />
|
||||||
|
<Setter Property="Foreground" Value="{DynamicResource TextBrush}" />
|
||||||
|
</Style>
|
||||||
|
```
|
||||||
|
|
||||||
|
(FontFamily/FontSize/Foreground are inherited properties in Avalonia, so setting them on the Window root propagates to all descendant text controls.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.App/App.axaml
|
||||||
|
git commit -m "feat(ui): set global Inter Tight font default on all windows"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 3: Promote shared styles into IslandStyles.axaml
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Design/IslandStyles.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add shared modal styles**
|
||||||
|
|
||||||
|
At the end of the `<Styles>` element (before the closing `</Styles>` at line ~901), add:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<!-- ============================================================ -->
|
||||||
|
<!-- SHARED MODAL STYLES (promoted from per-modal Window.Styles) -->
|
||||||
|
<!-- ============================================================ -->
|
||||||
|
<Style Selector="TextBlock.field-label">
|
||||||
|
<Setter Property="FontSize" Value="{StaticResource FontSizeMono}" />
|
||||||
|
<Setter Property="Foreground" Value="{StaticResource TextDimBrush}" />
|
||||||
|
<Setter Property="Margin" Value="0,0,0,4" />
|
||||||
|
</Style>
|
||||||
|
|
||||||
|
<Style Selector="TextBlock.path-mono">
|
||||||
|
<Setter Property="FontFamily" Value="{StaticResource MonoFont}" />
|
||||||
|
<Setter Property="FontSize" Value="{StaticResource FontSizeMono}" />
|
||||||
|
<Setter Property="Foreground" Value="{StaticResource TextDimBrush}" />
|
||||||
|
<Setter Property="TextTrimming" Value="CharacterEllipsis" />
|
||||||
|
</Style>
|
||||||
|
|
||||||
|
<!-- Standalone modal action buttons (not the .btn family) -->
|
||||||
|
<Style Selector="Button.primary">
|
||||||
|
<Setter Property="Background" Value="{StaticResource AccentDimBrush}" />
|
||||||
|
<Setter Property="BorderBrush" Value="{StaticResource AccentBrush}" />
|
||||||
|
<Setter Property="Foreground" Value="{StaticResource TextBrush}" />
|
||||||
|
<Setter Property="FontWeight" Value="SemiBold" />
|
||||||
|
</Style>
|
||||||
|
<Style Selector="Button.danger">
|
||||||
|
<Setter Property="Background" Value="{StaticResource BloodBrush}" />
|
||||||
|
<Setter Property="Foreground" Value="{StaticResource TextBrush}" />
|
||||||
|
</Style>
|
||||||
|
```
|
||||||
|
|
||||||
|
Note: `TextBlock.section-label` already exists at line ~864 — do NOT re-add it.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Replace hardcoded values inside existing IslandStyles rules**
|
||||||
|
|
||||||
|
Apply the normalization rules to the existing style setters in this file:
|
||||||
|
- Every `FontSize="N"` setter → the snapped token ref (table above). Specific lines: 149 (10→FontSizeEyebrow), 206 (11→FontSizeMono), 252 (13→FontSizeBody), 397 (11→FontSizeMono), 453 (9→FontSizeEyebrow), 475 (10→FontSizeEyebrow), 483 (10→FontSizeEyebrow), 556 (12→FontSizeBody), 573 (9→FontSizeEyebrow), 597 (12→FontSizeBody), 622 (10→FontSizeEyebrow), 638 (12→FontSizeBody), 697 (14→FontSizeTaskTitle), 771 (10→FontSizeEyebrow), 783 (10→FontSizeEyebrow), 788 (10→FontSizeEyebrow), 819 (11→FontSizeMono), 867 (10→FontSizeEyebrow), 884 (9→FontSizeEyebrow).
|
||||||
|
- Chip tint backgrounds/borders → named brushes:
|
||||||
|
- line 155/156 `#1F7C9166`/`#4C7C9166` → `{StaticResource RunningTintBrush}`/`{StaticResource RunningTintBorderBrush}`
|
||||||
|
- 163/164 review tints → `ReviewTintBrush`/`ReviewTintBorderBrush`
|
||||||
|
- 171/172 error tints → `ErrorTintBrush`/`ErrorTintBorderBrush`
|
||||||
|
- 179/180 queued tints → `QueuedTintBrush`/`QueuedTintBorderBrush`
|
||||||
|
- agent-strip tints at 361/362 (`#147C9166`/`#4C7C9166`), 365/366, 368/369, 374/375 → the matching `*TintBrush`/`*TintBorderBrush` (snap the `#14` alpha to the shared `#1F` tint).
|
||||||
|
- line 123 `#0DFFFFFF` → `{StaticResource HairlineOverlayBrush}`.
|
||||||
|
- line 389 & 810 `#FF080C0B` → `{StaticResource VoidBrush}`.
|
||||||
|
- line 887 badge `White` → `{StaticResource TextBrush}`.
|
||||||
|
- Badge brushes at lines 88-90: replace the three `<SolidColorBrush>` definitions with palette refs:
|
||||||
|
```xml
|
||||||
|
<SolidColorBrush x:Key="DraftBadgeBrush" Color="{StaticResource TextMuteColor}"/>
|
||||||
|
<SolidColorBrush x:Key="PlanningBadgeBrush" Color="{StaticResource PeatColor}"/>
|
||||||
|
<SolidColorBrush x:Key="PlannedBadgeBrush" Color="{StaticResource SageColor}"/>
|
||||||
|
```
|
||||||
|
- Corner radius `4` setters (447 live-chip, 813 task-live-tail `5`→leave, badges 878 `3`→leave) → only snap `4`→`6` where it appears as `CornerRadius="4"` on live-chip (447) and kbd (614) and badge tints. Leave `3` and `5` as-is (no nearby token; they're intentional micro-radii). NOTE: if unsure, leave radius alone — radius churn is lowest priority.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Design/IslandStyles.axaml
|
||||||
|
git commit -m "refactor(ui): tokenize IslandStyles values and add shared modal styles"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Phase 2 — Per-view token migration (independent; parallelizable)
|
||||||
|
|
||||||
|
For each task: open the file, apply the **normalization rules** (font/color/spacing/radius tables at top). Remove any local `Window.Styles` block that only redefines `section-label`, `field-label`, `path-mono`, `Button.primary`, or `Button.danger` (now shared from IslandStyles). Keep local styles that are genuinely unique to that view. After each file, build and commit.
|
||||||
|
|
||||||
|
Each task ends with:
|
||||||
|
- Build: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj` → PASS
|
||||||
|
- Commit: `git add <file> && git commit -m "refactor(ui): tokenize <view>"`
|
||||||
|
|
||||||
|
### Task 4: MainWindow.axaml
|
||||||
|
- Snap all `FontSize` literals (lines ~46,52,59,67,112,136,209,222,231).
|
||||||
|
- Status dots: `#4CAF50`→`StatusRunningBrush`, `#FFA726`→`StatusReviewBrush`, `#EF5350`→`StatusErrorBrush` (lines ~200,203,205).
|
||||||
|
|
||||||
|
### Task 5: Islands — ListsIslandView.axaml, TasksIslandView.axaml
|
||||||
|
- ListsIslandView: snap FontSize (18,10,12 at lines ~18,49,57,58,59); username TextBlock (~57) gets no explicit FontFamily (inherits SansFont now — correct, leave it).
|
||||||
|
- TasksIslandView: snap FontSize (24,11 at ~15,19).
|
||||||
|
|
||||||
|
### Task 6: DetailsIslandView.axaml
|
||||||
|
- Snap all FontSize (10,14,11,10,13,12 at lines ~54,57,92,114,138,142,199,269).
|
||||||
|
- `OrangeRed`→`BloodBrush` (~154).
|
||||||
|
- TextBox `CornerRadius="6"`→`8` (~172,274). TextBox `Padding="8"` leave.
|
||||||
|
- Remove any redundant inline label styles superseded by shared `field-label`.
|
||||||
|
|
||||||
|
### Task 7: TaskRowView.axaml (includes the BorderBrush bug fix)
|
||||||
|
- Snap FontSize (10,14 at ~85,103).
|
||||||
|
- **Bug fix:** `BorderBrush="{DynamicResource BorderBrush}"` → `{DynamicResource LineBrush}` (the schedule-flyout border, ~line 188/222). `BorderBrush` is not a defined key.
|
||||||
|
- Schedule flyout: title/labels inherit SansFont now (leave unset).
|
||||||
|
|
||||||
|
### Task 8: AgentStripView.axaml, SessionTerminalView.axaml
|
||||||
|
- AgentStrip: snap FontSize (10,9 at ~22,29,73,78); commit chip radius `4`→`6` (~102).
|
||||||
|
- SessionTerminal: snap FontSize (10,11 at ~17,69).
|
||||||
|
|
||||||
|
### Task 9: ThemedDatePicker.axaml
|
||||||
|
- Snap any FontSize literals; popup border `CornerRadius="10"` → leave (10 = ChipCornerRadius value, acceptable) OR `{StaticResource ChipCornerRadius}`. Tokenize colors if any literals present.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Phase 3 — ModalShell control
|
||||||
|
|
||||||
|
### Task 10: Create ModalShell control
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Ui/Views/Controls/ModalShell.axaml.cs`
|
||||||
|
- Create: `src/ClaudeDo.Ui/Views/Controls/ModalShell.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the code-behind (templated control)**
|
||||||
|
|
||||||
|
`ModalShell.axaml.cs`:
|
||||||
|
```csharp
|
||||||
|
using System;
|
||||||
|
using System.Windows.Input;
|
||||||
|
using Avalonia;
|
||||||
|
using Avalonia.Controls;
|
||||||
|
using Avalonia.Controls.Primitives;
|
||||||
|
using Avalonia.Input;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Views.Controls;
|
||||||
|
|
||||||
|
/// <summary>Reusable modal chrome: titlebar (drag + close) wrapping a body and optional footer.</summary>
|
||||||
|
public class ModalShell : ContentControl
|
||||||
|
{
|
||||||
|
public static readonly StyledProperty<string?> TitleProperty =
|
||||||
|
AvaloniaProperty.Register<ModalShell, string?>(nameof(Title));
|
||||||
|
|
||||||
|
public static readonly StyledProperty<object?> FooterProperty =
|
||||||
|
AvaloniaProperty.Register<ModalShell, object?>(nameof(Footer));
|
||||||
|
|
||||||
|
public static readonly StyledProperty<ICommand?> CloseCommandProperty =
|
||||||
|
AvaloniaProperty.Register<ModalShell, ICommand?>(nameof(CloseCommand));
|
||||||
|
|
||||||
|
public string? Title { get => GetValue(TitleProperty); set => SetValue(TitleProperty, value); }
|
||||||
|
public object? Footer { get => GetValue(FooterProperty); set => SetValue(FooterProperty, value); }
|
||||||
|
public ICommand? CloseCommand { get => GetValue(CloseCommandProperty); set => SetValue(CloseCommandProperty, value); }
|
||||||
|
|
||||||
|
protected override void OnApplyTemplate(TemplateAppliedEventArgs e)
|
||||||
|
{
|
||||||
|
base.OnApplyTemplate(e);
|
||||||
|
if (e.NameScope.Find<Border>("PART_TitleBar") is { } bar)
|
||||||
|
bar.PointerPressed += OnTitleBarPressed;
|
||||||
|
}
|
||||||
|
|
||||||
|
private void OnTitleBarPressed(object? sender, PointerPressedEventArgs e)
|
||||||
|
{
|
||||||
|
if (e.GetCurrentPoint(this).Properties.IsLeftButtonPressed
|
||||||
|
&& VisualRoot is Window w)
|
||||||
|
w.BeginMoveDrag(e);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Write the ControlTheme**
|
||||||
|
|
||||||
|
`ModalShell.axaml`:
|
||||||
|
```xml
|
||||||
|
<ResourceDictionary xmlns="https://github.com/avaloniaui"
|
||||||
|
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
|
||||||
|
xmlns:ctl="using:ClaudeDo.Ui.Views.Controls">
|
||||||
|
<ControlTheme x:Key="{x:Type ctl:ModalShell}" TargetType="ctl:ModalShell">
|
||||||
|
<Setter Property="Template">
|
||||||
|
<ControlTemplate>
|
||||||
|
<Border Background="{DynamicResource SurfaceBrush}"
|
||||||
|
BorderBrush="{DynamicResource LineBrush}"
|
||||||
|
BorderThickness="1"
|
||||||
|
CornerRadius="{DynamicResource ModalCornerRadius}"
|
||||||
|
ClipToBounds="True">
|
||||||
|
<DockPanel>
|
||||||
|
<!-- Title bar -->
|
||||||
|
<Border Name="PART_TitleBar" DockPanel.Dock="Top" Height="36"
|
||||||
|
Background="{DynamicResource DeepBrush}"
|
||||||
|
BorderBrush="{DynamicResource LineBrush}"
|
||||||
|
BorderThickness="0,0,0,1">
|
||||||
|
<Grid ColumnDefinitions="*,Auto" Margin="14,0">
|
||||||
|
<TextBlock Text="{TemplateBinding Title}"
|
||||||
|
FontFamily="{DynamicResource MonoFont}"
|
||||||
|
FontSize="{DynamicResource FontSizeMono}"
|
||||||
|
LetterSpacing="1.4"
|
||||||
|
Foreground="{DynamicResource TextBrush}"
|
||||||
|
VerticalAlignment="Center"/>
|
||||||
|
<Button Grid.Column="1" Classes="icon-btn" Content="✕"
|
||||||
|
FontSize="{DynamicResource FontSizeBody}"
|
||||||
|
Command="{TemplateBinding CloseCommand}"
|
||||||
|
VerticalAlignment="Center"/>
|
||||||
|
</Grid>
|
||||||
|
</Border>
|
||||||
|
<!-- Footer (optional) -->
|
||||||
|
<Border Name="PART_Footer" DockPanel.Dock="Bottom"
|
||||||
|
Background="{DynamicResource DeepBrush}"
|
||||||
|
BorderBrush="{DynamicResource LineBrush}"
|
||||||
|
BorderThickness="0,1,0,0"
|
||||||
|
IsVisible="{TemplateBinding Footer, Converter={x:Static ObjectConverters.IsNotNull}}">
|
||||||
|
<ContentPresenter Content="{TemplateBinding Footer}" Margin="16,8"/>
|
||||||
|
</Border>
|
||||||
|
<!-- Body -->
|
||||||
|
<ContentPresenter Content="{TemplateBinding Content}"/>
|
||||||
|
</DockPanel>
|
||||||
|
</Border>
|
||||||
|
</ControlTemplate>
|
||||||
|
</Setter>
|
||||||
|
</ControlTheme>
|
||||||
|
</ResourceDictionary>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Register the ControlTheme**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.App/App.axaml`, inside `<ResourceDictionary.MergedDictionaries>` (after the Tokens include), add:
|
||||||
|
```xml
|
||||||
|
<ResourceInclude Source="avares://ClaudeDo.Ui/Views/Controls/ModalShell.axaml" />
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Views/Controls/ModalShell.axaml src/ClaudeDo.Ui/Views/Controls/ModalShell.axaml.cs src/ClaudeDo.App/App.axaml
|
||||||
|
git commit -m "feat(ui): add reusable ModalShell control"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 11: Migrate SettingsModalView to ModalShell (reference migration)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Modals/SettingsModalView.axaml`
|
||||||
|
- Modify (if needed): `src/ClaudeDo.Ui/Views/Modals/SettingsModalView.axaml.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Replace chrome with ModalShell**
|
||||||
|
|
||||||
|
- Add namespace if missing: `xmlns:ctl="using:ClaudeDo.Ui.Views.Controls"` (already present).
|
||||||
|
- Remove the local `Window.Styles` entries for `section-label`, `field-label`, `path-mono`, `Button.danger`, `Button.primary` (now shared). Keep any genuinely unique styles.
|
||||||
|
- Replace the outer `<Border>...<Grid RowDefinitions="36,*,52">` structure with:
|
||||||
|
```xml
|
||||||
|
<ctl:ModalShell Title="SETTINGS" CloseCommand="{Binding CancelCommand}">
|
||||||
|
<ctl:ModalShell.Footer>
|
||||||
|
<StackPanel Orientation="Horizontal" Spacing="8" HorizontalAlignment="Right" VerticalAlignment="Center">
|
||||||
|
<Button Content="Cancel" Command="{Binding CancelCommand}" MinWidth="90"/>
|
||||||
|
<Button Content="Save" Classes="primary" Command="{Binding SaveCommand}" IsEnabled="{Binding !IsBusy}" MinWidth="90"/>
|
||||||
|
</StackPanel>
|
||||||
|
</ctl:ModalShell.Footer>
|
||||||
|
<!-- existing DockPanel body (tabs + validation strip) goes here unchanged -->
|
||||||
|
</ctl:ModalShell>
|
||||||
|
```
|
||||||
|
- The body is the existing `<DockPanel Grid.Row="1">` content minus `Grid.Row`.
|
||||||
|
- Snap remaining FontSize literals in the body per the rules.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Remove obsolete drag handler if now unused**
|
||||||
|
|
||||||
|
If `TitleBar_PointerPressed` in `SettingsModalView.axaml.cs` is no longer referenced (ModalShell handles dragging), delete the method and the `x:Name="TitleBar"`/`PointerPressed` wiring. If the build complains about an unused handler, that's the signal.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Views/Modals/SettingsModalView.axaml src/ClaudeDo.Ui/Views/Modals/SettingsModalView.axaml.cs
|
||||||
|
git commit -m "refactor(ui): migrate SettingsModal to ModalShell"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 12: Migrate remaining modals to ModalShell
|
||||||
|
|
||||||
|
Repeat the Task 11 pattern for each modal below. One commit per file. Each: swap chrome → `ModalShell`, lift action buttons into `ModalShell.Footer`, drop local duplicate styles, delete now-unused `*_PointerPressed` drag handlers, snap FontSize/colors per rules, build, commit.
|
||||||
|
|
||||||
|
- [ ] **12a:** `ListSettingsModalView.axaml` (+ `.axaml.cs`)
|
||||||
|
- [ ] **12b:** `MergeModalView.axaml` (+ `.axaml.cs`)
|
||||||
|
- [ ] **12c:** `AboutModalView.axaml` (+ `.axaml.cs`) — labels inherit SansFont now.
|
||||||
|
- [ ] **12d:** `UnfinishedPlanningModalView.axaml` (+ `.axaml.cs`)
|
||||||
|
- [ ] **12e:** `RepoImportModalView.axaml` (+ `.axaml.cs`)
|
||||||
|
- [ ] **12f:** `WorktreesOverviewModalView.axaml` (+ `.axaml.cs`) — also fold `Border.wt-row` to reuse `task-row` if trivial; snap FontSize; `#EF5350`→`StatusErrorBrush`; `White` badge text→`TextBrush`.
|
||||||
|
|
||||||
|
Each ends with build PASS + `git commit -m "refactor(ui): migrate <Modal> to ModalShell"`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 13: DiffModalView, PlanningDiffView, ConflictResolutionView (Static→Dynamic + chrome)
|
||||||
|
|
||||||
|
These three currently use `StaticResource` for token lookups. Migrate chrome to `ModalShell` where they are full windows, and convert token references.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Convert resource references**
|
||||||
|
|
||||||
|
In each of `DiffModalView.axaml`, `PlanningDiffView.axaml`, `ConflictResolutionView.axaml`: change every `{StaticResource <Brush/Token>}` used in an **element attribute** to `{DynamicResource ...}`. Leave `{StaticResource ...}` inside `<Style>`/`Setter` blocks (Avalonia styles resolve StaticResource fine and DynamicResource in setters is discouraged).
|
||||||
|
|
||||||
|
- [ ] **Step 2: Apply normalization rules**
|
||||||
|
|
||||||
|
- Snap FontSize literals.
|
||||||
|
- `Consolas,Menlo,monospace` raw font (PlanningDiffView ~98, ConflictResolution ~47) → `{DynamicResource MonoFont}`.
|
||||||
|
- `Orange`/`OrangeRed` → `{DynamicResource BloodBrush}`.
|
||||||
|
- DiffModal tints `#1A4A6B4A`/`#1AC87060` → `{DynamicResource RunningTintBrush}`/`{DynamicResource ErrorTintBrush}`.
|
||||||
|
- Migrate window chrome to `ModalShell` if the file is a Window with the titlebar/footer pattern (DiffModalView, ConflictResolutionView). PlanningDiffView is an embedded view — only convert resources + fonts, no ModalShell.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build + commit (one per file)**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj` → PASS
|
||||||
|
Commit: `git commit -m "refactor(ui): tokenize and dynamic-ize <view>"`
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Phase 4 — Final verification
|
||||||
|
|
||||||
|
### Task 14: Full build + visual checklist
|
||||||
|
|
||||||
|
- [ ] **Step 1: Build both projects**
|
||||||
|
|
||||||
|
Run:
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
```
|
||||||
|
Expected: both PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Grep for stragglers**
|
||||||
|
|
||||||
|
Confirm no remaining hardcoded values slipped through:
|
||||||
|
- `FontSize="` with a numeric literal in any `Views/**/*.axaml` (should be near-zero; only token refs remain).
|
||||||
|
- Off-palette hex (`#4CAF50`, `#FFA726`, `#EF5350`, `#FF080C0B`, `OrangeRed`, `Orange`) — should be zero.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Produce the human visual-check checklist**
|
||||||
|
|
||||||
|
Write a short checklist (`docs/superpowers/plans/2026-05-30-ui-normalization-visualcheck.md`) listing each view/modal and what to eyeball (font looks like Inter Tight, status dots correct color, modal titlebars/footers intact, badges distinguishable, diff/planning views render). This is the regression gate the user runs by launching the app.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Self-Review notes
|
||||||
|
|
||||||
|
- **Spec coverage:** global defaults (T2), token source-of-truth fonts/spacing/radius (rules + T3–T13), color fold (T1,T3,T4,T6,T12,T13), shared styles (T3), ModalShell (T10–T13), bug fixes — BorderBrush (T7), Static→Dynamic (T13). All spec sections mapped.
|
||||||
|
- **Risk note:** ModalShell migration (T11–T13) is the highest-risk part because each modal's body layout differs. Tasks are per-file so a failure is isolated. If a modal's body has tight coupling to the old Grid rows, keeping that modal's hand-rolled chrome (and only tokenizing it) is an acceptable fallback — note it in the commit.
|
||||||
|
- **Line numbers** are from the pre-change audit and may drift as edits land; treat them as guides, locate by content.
|
||||||
175
docs/superpowers/plans/2026-06-01-waiting-for-review-state.md
Normal file
175
docs/superpowers/plans/2026-06-01-waiting-for-review-state.md
Normal file
@@ -0,0 +1,175 @@
|
|||||||
|
# Waiting for Review — Task State — Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Add a `WaitingForReview` lifecycle state that standalone tasks enter after a successful run, with approve / reject-rerun / reject-park / cancel exits, exposed via UI and MCP.
|
||||||
|
|
||||||
|
**Architecture:** New enum value + nullable `ReviewFeedback` column. `TaskStateService` gains review transitions. `TaskRunner.HandleSuccess` routes standalone-task success to review. `QueueService.RunInSlotAsync` resumes the Claude session when re-running a rejected task. New MCP `review_task` tool + UI commands.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, EF Core (SQLite, TEXT enum), SignalR, Avalonia MVVM, xUnit.
|
||||||
|
|
||||||
|
**Scope decision (locked):** Only standalone tasks (`ParentTaskId == null`) route to `WaitingForReview`. Planning **child** tasks continue to `Done` on success so the sequential planning chain (which advances on *terminal* states) is unaffected. Flagged for user confirmation.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: Data layer — enum, converter, column
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Data/Models/TaskEntity.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Data/Configuration/TaskEntityConfiguration.cs`
|
||||||
|
- Create: EF migration via CLI
|
||||||
|
|
||||||
|
- [ ] **Step 1:** Add `WaitingForReview` to `TaskStatus` enum (after `Running`) and add `public string? ReviewFeedback { get; set; }` to `TaskEntity`.
|
||||||
|
- [ ] **Step 2:** In `TaskEntityConfiguration`, add `TaskStatus.WaitingForReview => "waiting_for_review"` to `StatusToString` and `"waiting_for_review" => TaskStatus.WaitingForReview` to `StatusFromString`; map the column: `builder.Property(t => t.ReviewFeedback).HasColumnName("review_feedback");`
|
||||||
|
- [ ] **Step 3:** Create migration: `dotnet ef migrations add AddReviewFeedback --project src/ClaudeDo.Data/ClaudeDo.Data.csproj`. Verify it only adds the `review_feedback` TEXT column (nullable). If `dotnet ef` unavailable, hand-write the migration + designer following the latest migration in `Migrations/`.
|
||||||
|
- [ ] **Step 4:** Build `dotnet build src/ClaudeDo.Data/ClaudeDo.Data.csproj`. Expected: success.
|
||||||
|
- [ ] **Step 5:** Commit.
|
||||||
|
|
||||||
|
## Task 2: Worker — review transitions in TaskStateService
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/State/TaskStateService.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Worker/State/Interfaces/ITaskStateService.cs` (add new method signatures)
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/...` (state transition tests)
|
||||||
|
|
||||||
|
New methods (all return `TransitionResult`, broadcast `TaskUpdated`):
|
||||||
|
|
||||||
|
- `SubmitForReviewAsync(taskId, finishedAt, result, ct)` — guard `Status == Running`; set `Status=WaitingForReview, FinishedAt, Result`. Does NOT call `OnChildTerminalAsync` (review is non-terminal; only invoked for standalone tasks anyway).
|
||||||
|
- `ApproveReviewAsync(taskId, ct)` — guard `Status == WaitingForReview`; set `Status=Done`.
|
||||||
|
- `RejectToQueueAsync(taskId, feedback, ct)` — reject empty/whitespace feedback (`TransitionResult(false, "Feedback is required to reject for re-run.")`); guard `Status == WaitingForReview`; set `Status=Queued, ReviewFeedback=feedback`; `_waker.Wake()`.
|
||||||
|
- `RejectToIdleAsync(taskId, ct)` — guard `Status == WaitingForReview`; set `Status=Idle, ReviewFeedback=null` (leave `Result` intact).
|
||||||
|
- `ClearReviewFeedbackAsync(taskId, ct)` — set `ReviewFeedback=null` (no status change, no guard); used by the runner after consuming feedback.
|
||||||
|
- Extend `CancelAsync` guard: `(Status == Running || Status == Queued || Status == WaitingForReview)`.
|
||||||
|
|
||||||
|
- [ ] **Step 1:** Write failing tests in a new `tests/ClaudeDo.Worker.Tests/State/ReviewTransitionTests.cs` (follow existing TaskStateService test setup). Cover: submit-for-review from Running; approve from WaitingForReview→Done; reject-to-queue stores feedback + status Queued; empty feedback rejected; reject-to-idle clears feedback + keeps Result; cancel from WaitingForReview→Cancelled; invalid (approve from Idle) returns `!Ok`.
|
||||||
|
- [ ] **Step 2:** Run tests, expect FAIL (methods missing).
|
||||||
|
- [ ] **Step 3:** Implement the methods + interface signatures + CancelAsync guard.
|
||||||
|
- [ ] **Step 4:** Run tests, expect PASS.
|
||||||
|
- [ ] **Step 5:** Commit.
|
||||||
|
|
||||||
|
## Task 3: Worker — route standalone success to review
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Runner/TaskRunner.cs` (`HandleSuccess`)
|
||||||
|
|
||||||
|
- [ ] **Step 1:** In `HandleSuccess`, after commit, branch:
|
||||||
|
```csharp
|
||||||
|
var finishedAt = DateTime.UtcNow;
|
||||||
|
if (task.ParentTaskId is null)
|
||||||
|
{
|
||||||
|
await _state.SubmitForReviewAsync(task.Id, finishedAt, result.ResultMarkdown, CancellationToken.None);
|
||||||
|
await _broadcaster.WorkerLog($"Finished \"{task.Title}\" (waiting for review)", WorkerLogLevel.Success, DateTime.UtcNow);
|
||||||
|
await _broadcaster.TaskFinished(slot, task.Id, "waiting_for_review", finishedAt);
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
await _state.CompleteAsync(task.Id, finishedAt, result.ResultMarkdown, CancellationToken.None);
|
||||||
|
await _broadcaster.WorkerLog($"Finished \"{task.Title}\" (done)", WorkerLogLevel.Success, DateTime.UtcNow);
|
||||||
|
await _broadcaster.TaskFinished(slot, task.Id, "done", finishedAt);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
- [ ] **Step 2:** Build worker. Expected: success.
|
||||||
|
- [ ] **Step 3:** Commit.
|
||||||
|
|
||||||
|
## Task 4: Worker — resume-aware re-run in QueueService
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Queue/QueueService.cs` (`RunInSlotAsync`)
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/...`
|
||||||
|
|
||||||
|
- [ ] **Step 1:** In `RunInSlotAsync`, after loading `task`:
|
||||||
|
```csharp
|
||||||
|
if (!string.IsNullOrWhiteSpace(task.ReviewFeedback))
|
||||||
|
{
|
||||||
|
var feedback = task.ReviewFeedback!;
|
||||||
|
string? sessionId;
|
||||||
|
using (var ctx = _dbFactory.CreateDbContext())
|
||||||
|
sessionId = (await new TaskRunRepository(ctx).GetLatestByTaskIdAsync(taskId, ct))?.SessionId;
|
||||||
|
await _state.ClearReviewFeedbackAsync(taskId, ct); // inject ITaskStateService
|
||||||
|
if (sessionId is not null)
|
||||||
|
{
|
||||||
|
await _runner.ContinueAsync(taskId, feedback, "queue", ct);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
task.Description = string.IsNullOrWhiteSpace(task.Description)
|
||||||
|
? $"Reviewer feedback: {feedback}"
|
||||||
|
: $"{task.Description}\n\nReviewer feedback: {feedback}";
|
||||||
|
}
|
||||||
|
await _runner.RunAsync(task, "queue", ct);
|
||||||
|
```
|
||||||
|
Inject `ITaskStateService _state` into `QueueService` (add to ctor + DI already provides it).
|
||||||
|
- [ ] **Step 2:** Build worker, expect success.
|
||||||
|
- [ ] **Step 3:** Commit.
|
||||||
|
|
||||||
|
## Task 5: MCP — review_task tool + status reference
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/External/ExternalMcpService.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1:** Add `review_task` tool:
|
||||||
|
```csharp
|
||||||
|
[McpServerTool, Description(
|
||||||
|
"Review a task that is WaitingForReview. decision: 'approve' (→ Done), " +
|
||||||
|
"'reject_rerun' (→ Queued, resumes the agent session with feedback — feedback required), " +
|
||||||
|
"'reject_park' (→ Idle for manual editing), 'cancel' (→ Cancelled). ")]
|
||||||
|
public async Task<TaskDto> ReviewTask(string taskId, string decision, string? feedback, CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
var task = await _tasks.GetByIdAsync(taskId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"Task {taskId} not found.");
|
||||||
|
TransitionResult r = decision.ToLowerInvariant() switch
|
||||||
|
{
|
||||||
|
"approve" => await _state.ApproveReviewAsync(taskId, cancellationToken),
|
||||||
|
"reject_rerun" => await _state.RejectToQueueAsync(taskId, feedback ?? "", cancellationToken),
|
||||||
|
"reject_park" => await _state.RejectToIdleAsync(taskId, cancellationToken),
|
||||||
|
"cancel" => await _state.CancelAsync(taskId, DateTime.UtcNow, cancellationToken),
|
||||||
|
_ => throw new InvalidOperationException($"Unknown decision '{decision}'. Use approve, reject_rerun, reject_park, or cancel."),
|
||||||
|
};
|
||||||
|
if (!r.Ok) throw new InvalidOperationException(r.Reason ?? "Review action failed.");
|
||||||
|
return ToDto((await _tasks.GetByIdAsync(taskId, cancellationToken))!);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
- [ ] **Step 2:** Add `WaitingForReview` to `GetTaskStatusValues` list; update the validation strings in `ListTasks` and the lifecycle text in `GetTask`/`UpdateTaskStatus` to include `WaitingForReview`.
|
||||||
|
- [ ] **Step 3:** Build worker, expect success.
|
||||||
|
- [ ] **Step 4:** Commit.
|
||||||
|
|
||||||
|
## Task 6: UI — client + hub methods
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Hub/WorkerHub.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/Interfaces/IWorkerClient.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/WorkerClient.cs`
|
||||||
|
- Modify: `tests/ClaudeDo.Ui.Tests/StubWorkerClient.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1:** Hub: add `ApproveReview(taskId)`, `RejectReviewToQueue(taskId, feedback)`, `RejectReviewToIdle(taskId)`, `CancelReview(taskId)` — each calls the matching `_state` method via `HubGuard`-style mapping (`if (!result.Ok) throw new HubException(...)`).
|
||||||
|
- [ ] **Step 2:** `IWorkerClient` + `WorkerClient`: add `ApproveReviewAsync`, `RejectReviewToQueueAsync(taskId, feedback)`, `RejectReviewToIdleAsync`, `CancelReviewAsync` invoking the hub methods. Add no-op/stub impls to `StubWorkerClient`.
|
||||||
|
- [ ] **Step 3:** Build App + Ui.Tests. Expected: success.
|
||||||
|
- [ ] **Step 4:** Commit.
|
||||||
|
|
||||||
|
## Task 7: UI — converter, row VM, view buttons
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Converters/StatusColorConverter.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs` (commands)
|
||||||
|
- Modify: the task row/detail AXAML to surface Approve / Reject / Park / Cancel when `IsWaitingForReview`
|
||||||
|
|
||||||
|
- [ ] **Step 1:** `StatusColorConverter`: add `"waiting_for_review" => Brushes.MediumPurple,` (placeholder — user does visual pass).
|
||||||
|
- [ ] **Step 2:** `TaskRowViewModel`: add `public bool IsWaitingForReview => Status == TaskStatus.WaitingForReview;`, raise it in `OnStatusChanged`, and add `(TaskStatus.WaitingForReview, _) => "review"` to `StatusChipClass`.
|
||||||
|
- [ ] **Step 3:** `TasksIslandViewModel`: add relay commands `ApproveReview`, `RejectReviewRerun` (prompts for feedback), `RejectReviewPark`, `CancelReview` operating on the selected/target row, calling the new client methods.
|
||||||
|
- [ ] **Step 4:** Add buttons to the relevant view bound to those commands, visible when `IsWaitingForReview`. Reject-rerun uses a text-input flyout/dialog for required feedback.
|
||||||
|
- [ ] **Step 5:** Build App + Ui.Tests. Expected: success. (Visual layout: flagged for user's visual pass — cannot render here.)
|
||||||
|
- [ ] **Step 6:** Commit.
|
||||||
|
|
||||||
|
## Task 8: Docs + full verification
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: root `CLAUDE.md`, `src/ClaudeDo.Data/CLAUDE.md`, `src/ClaudeDo.Worker/CLAUDE.md`
|
||||||
|
|
||||||
|
- [ ] **Step 1:** Update status flow lines + worker transition table to include `WaitingForReview` and the new transitions.
|
||||||
|
- [ ] **Step 2:** Build all projects (csproj individually — `.slnx` needs .NET 9) and run `dotnet test tests/ClaudeDo.Worker.Tests`, `tests/ClaudeDo.Ui.Tests`, `tests/ClaudeDo.Data.Tests`. Expected: all green.
|
||||||
|
- [ ] **Step 3:** Commit.
|
||||||
|
|
||||||
|
## Self-Review notes
|
||||||
|
|
||||||
|
- Spec coverage: §1 state machine → Tasks 2,3; §2 data → Task 1; §3 transitions → Task 2; §4 resume → Task 4; §5 MCP → Task 5; §6 hub → Task 6; §7 UI → Tasks 6,7; §8 docs → Task 8; testing → Tasks 2,4,8.
|
||||||
|
- Method names consistent across tasks: `SubmitForReviewAsync`, `ApproveReviewAsync`, `RejectToQueueAsync`, `RejectToIdleAsync`, `ClearReviewFeedbackAsync` (state); `ApproveReview`/`RejectReviewToQueue`/`RejectReviewToIdle`/`CancelReview` (hub); `ApproveReviewAsync`/`RejectReviewToQueueAsync`/`RejectReviewToIdleAsync`/`CancelReviewAsync` (client).
|
||||||
829
docs/superpowers/plans/2026-06-01-worker-lifecycle.md
Normal file
829
docs/superpowers/plans/2026-06-01-worker-lifecycle.md
Normal file
@@ -0,0 +1,829 @@
|
|||||||
|
# Worker Lifecycle Redesign Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Make the worker owned by a single external mechanism (a per-user Startup-folder shortcut in production), stop the App from auto-spawning its own worker, and show an actionable prompt when the App can't connect.
|
||||||
|
|
||||||
|
**Architecture:** Installer creates a `.lnk` in the Windows Startup folder instead of a Scheduled Task (migrating existing installs by deleting the old task). The App's `IslandsShellViewModel` drops `EnsureWorkerRunningAsync` and instead runs a one-shot grace timer that opens a `WorkerConnectionModal` (Start Worker / Rerun Installer / Dismiss) if still offline; the footer status pill becomes a button that reopens it.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, WPF installer (COM `IShellLink` for shortcuts), Avalonia + CommunityToolkit.Mvvm UI, xUnit.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File Structure
|
||||||
|
|
||||||
|
**Installer (`src/ClaudeDo.Installer`)**
|
||||||
|
- Create: `Core/ShortcutFactory.cs` — shared `IShellLink` COM helper (`CreateShortcut`).
|
||||||
|
- Create: `Core/AutostartShortcut.cs` — install/remove the worker Startup-folder `.lnk`.
|
||||||
|
- Modify: `Steps/CreateShortcutsStep.cs` — use `ShortcutFactory`, drop embedded COM.
|
||||||
|
- Modify: `Steps/RegisterAutostartStep.cs` — Startup shortcut + legacy-task delete (no more task XML).
|
||||||
|
- Modify: `Steps/StartWorkerStep.cs` — `Process.Start` instead of `schtasks /Run`.
|
||||||
|
- Modify: `Steps/StopWorkerStep.cs` — drop `schtasks /End`.
|
||||||
|
- Modify: `Core/UninstallRunner.cs` — remove the Startup `.lnk`.
|
||||||
|
- Delete: `Core/ScheduledTaskXml.cs` (and its test).
|
||||||
|
|
||||||
|
**App (`src/ClaudeDo.Ui`)**
|
||||||
|
- Create: `ViewModels/Modals/WorkerConnectionModalViewModel.cs`.
|
||||||
|
- Create: `Views/Modals/WorkerConnectionModalView.axaml` (+ `.axaml.cs`).
|
||||||
|
- Modify: `ViewModels/IslandsShellViewModel.cs` — remove auto-spawn; add hook, command, grace timer, decision gate.
|
||||||
|
- Modify: `Views/MainWindow.axaml.cs` — wire the new modal.
|
||||||
|
- Modify: `Views/MainWindow.axaml` — clickable status pill.
|
||||||
|
|
||||||
|
**Tests**
|
||||||
|
- Modify: `tests/ClaudeDo.Installer.Tests/` — delete `ScheduledTaskXmlTests.cs`; add `ShortcutFactoryTests.cs`, `AutostartShortcutTests.cs`.
|
||||||
|
- Add: `tests/ClaudeDo.Ui.Tests/ConnectionPromptGateTests.cs`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: ShortcutFactory (shared COM helper)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Installer/Core/ShortcutFactory.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Installer/Steps/CreateShortcutsStep.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Installer.Tests/ShortcutFactoryTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test**
|
||||||
|
|
||||||
|
`tests/ClaudeDo.Installer.Tests/ShortcutFactoryTests.cs`:
|
||||||
|
```csharp
|
||||||
|
using System.IO;
|
||||||
|
using ClaudeDo.Installer.Core;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Installer.Tests;
|
||||||
|
|
||||||
|
public class ShortcutFactoryTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void CreateShortcut_writes_lnk_file()
|
||||||
|
{
|
||||||
|
var dir = Path.Combine(Path.GetTempPath(), "cdshortcut-" + Guid.NewGuid().ToString("N"));
|
||||||
|
Directory.CreateDirectory(dir);
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var target = Path.Combine(dir, "fake.exe");
|
||||||
|
File.WriteAllText(target, "");
|
||||||
|
var lnk = Path.Combine(dir, "x.lnk");
|
||||||
|
|
||||||
|
ShortcutFactory.CreateShortcut(lnk, target, dir, "desc");
|
||||||
|
|
||||||
|
Assert.True(File.Exists(lnk));
|
||||||
|
}
|
||||||
|
finally { Directory.Delete(dir, recursive: true); }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Installer.Tests --filter ShortcutFactoryTests`
|
||||||
|
Expected: FAIL — `ShortcutFactory` does not exist (compile error).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Create `ShortcutFactory` (move COM interop out of `CreateShortcutsStep`)**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Installer/Core/ShortcutFactory.cs`:
|
||||||
|
```csharp
|
||||||
|
using System.Runtime.InteropServices;
|
||||||
|
using System.Runtime.InteropServices.ComTypes;
|
||||||
|
using System.Text;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Installer.Core;
|
||||||
|
|
||||||
|
public static class ShortcutFactory
|
||||||
|
{
|
||||||
|
public static void CreateShortcut(string shortcutPath, string targetPath, string workingDir, string description)
|
||||||
|
{
|
||||||
|
var link = (IShellLink)new ShellLink();
|
||||||
|
link.SetPath(targetPath);
|
||||||
|
link.SetWorkingDirectory(workingDir);
|
||||||
|
link.SetDescription(description);
|
||||||
|
link.SetIconLocation(targetPath, 0);
|
||||||
|
|
||||||
|
var file = (IPersistFile)link;
|
||||||
|
file.Save(shortcutPath, false);
|
||||||
|
}
|
||||||
|
|
||||||
|
[ComImport]
|
||||||
|
[Guid("00021401-0000-0000-C000-000000000046")]
|
||||||
|
private class ShellLink { }
|
||||||
|
|
||||||
|
[ComImport]
|
||||||
|
[InterfaceType(ComInterfaceType.InterfaceIsIUnknown)]
|
||||||
|
[Guid("000214F9-0000-0000-C000-000000000046")]
|
||||||
|
private interface IShellLink
|
||||||
|
{
|
||||||
|
void GetPath([Out, MarshalAs(UnmanagedType.LPWStr)] StringBuilder pszFile, int cchMaxPath, IntPtr pfd, int fFlags);
|
||||||
|
void GetIDList(out IntPtr ppidl);
|
||||||
|
void SetIDList(IntPtr pidl);
|
||||||
|
void GetDescription([Out, MarshalAs(UnmanagedType.LPWStr)] StringBuilder pszName, int cchMaxName);
|
||||||
|
void SetDescription([MarshalAs(UnmanagedType.LPWStr)] string pszName);
|
||||||
|
void GetWorkingDirectory([Out, MarshalAs(UnmanagedType.LPWStr)] StringBuilder pszDir, int cchMaxPath);
|
||||||
|
void SetWorkingDirectory([MarshalAs(UnmanagedType.LPWStr)] string pszDir);
|
||||||
|
void GetArguments([Out, MarshalAs(UnmanagedType.LPWStr)] StringBuilder pszArgs, int cchMaxPath);
|
||||||
|
void SetArguments([MarshalAs(UnmanagedType.LPWStr)] string pszArgs);
|
||||||
|
void GetHotkey(out short pwHotkey);
|
||||||
|
void SetHotkey(short wHotkey);
|
||||||
|
void GetShowCmd(out int piShowCmd);
|
||||||
|
void SetShowCmd(int iShowCmd);
|
||||||
|
void GetIconLocation([Out, MarshalAs(UnmanagedType.LPWStr)] StringBuilder pszIconPath, int cchIconPath, out int piIcon);
|
||||||
|
void SetIconLocation([MarshalAs(UnmanagedType.LPWStr)] string pszIconPath, int iIcon);
|
||||||
|
void SetRelativePath([MarshalAs(UnmanagedType.LPWStr)] string pszPathRel, int dwReserved);
|
||||||
|
void Resolve(IntPtr hwnd, int fFlags);
|
||||||
|
void SetPath([MarshalAs(UnmanagedType.LPWStr)] string pszFile);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Replace the embedded COM in `CreateShortcutsStep` with the helper**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Installer/Steps/CreateShortcutsStep.cs`: delete the private `CreateShortcut` method and the entire `#region COM Interop for IShellLink` block (lines 47-90), remove the now-unused `using System.Runtime.InteropServices;`, `using System.Runtime.InteropServices.ComTypes;`, and `using System.Text;`. Replace the two `CreateShortcut(...)` call sites with `ShortcutFactory.CreateShortcut(...)`:
|
||||||
|
```csharp
|
||||||
|
ShortcutFactory.CreateShortcut(startMenuPath, appExe, workingDir, "ClaudeDo Task Manager");
|
||||||
|
```
|
||||||
|
```csharp
|
||||||
|
ShortcutFactory.CreateShortcut(desktopPath, appExe, workingDir, "ClaudeDo Task Manager");
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Run tests to verify they pass**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Installer.Tests --filter ShortcutFactoryTests`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Installer/Core/ShortcutFactory.cs src/ClaudeDo.Installer/Steps/CreateShortcutsStep.cs tests/ClaudeDo.Installer.Tests/ShortcutFactoryTests.cs
|
||||||
|
git commit -m "refactor(installer): extract ShortcutFactory COM helper"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: AutostartShortcut helper
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Installer/Core/AutostartShortcut.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Installer.Tests/AutostartShortcutTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
`tests/ClaudeDo.Installer.Tests/AutostartShortcutTests.cs`:
|
||||||
|
```csharp
|
||||||
|
using System.IO;
|
||||||
|
using ClaudeDo.Installer.Core;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Installer.Tests;
|
||||||
|
|
||||||
|
public class AutostartShortcutTests
|
||||||
|
{
|
||||||
|
private static string TempDir()
|
||||||
|
{
|
||||||
|
var dir = Path.Combine(Path.GetTempPath(), "cdautostart-" + Guid.NewGuid().ToString("N"));
|
||||||
|
Directory.CreateDirectory(dir);
|
||||||
|
return dir;
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Install_creates_lnk_with_expected_name()
|
||||||
|
{
|
||||||
|
var startup = TempDir();
|
||||||
|
var workerDir = TempDir();
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var workerExe = Path.Combine(workerDir, "ClaudeDo.Worker.exe");
|
||||||
|
File.WriteAllText(workerExe, "");
|
||||||
|
|
||||||
|
AutostartShortcut.Install(startup, workerExe);
|
||||||
|
|
||||||
|
Assert.True(File.Exists(Path.Combine(startup, AutostartShortcut.FileName)));
|
||||||
|
}
|
||||||
|
finally { Directory.Delete(startup, true); Directory.Delete(workerDir, true); }
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Remove_deletes_existing_lnk()
|
||||||
|
{
|
||||||
|
var startup = TempDir();
|
||||||
|
var workerDir = TempDir();
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var workerExe = Path.Combine(workerDir, "ClaudeDo.Worker.exe");
|
||||||
|
File.WriteAllText(workerExe, "");
|
||||||
|
AutostartShortcut.Install(startup, workerExe);
|
||||||
|
|
||||||
|
AutostartShortcut.Remove(startup);
|
||||||
|
|
||||||
|
Assert.False(File.Exists(Path.Combine(startup, AutostartShortcut.FileName)));
|
||||||
|
}
|
||||||
|
finally { Directory.Delete(startup, true); Directory.Delete(workerDir, true); }
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Remove_is_noop_when_missing()
|
||||||
|
{
|
||||||
|
var startup = TempDir();
|
||||||
|
try { AutostartShortcut.Remove(startup); } // must not throw
|
||||||
|
finally { Directory.Delete(startup, true); }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run tests to verify they fail**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Installer.Tests --filter AutostartShortcutTests`
|
||||||
|
Expected: FAIL — `AutostartShortcut` does not exist.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Create `AutostartShortcut`**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Installer/Core/AutostartShortcut.cs`:
|
||||||
|
```csharp
|
||||||
|
using System.IO;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Installer.Core;
|
||||||
|
|
||||||
|
public static class AutostartShortcut
|
||||||
|
{
|
||||||
|
public const string FileName = "ClaudeDo Worker.lnk";
|
||||||
|
|
||||||
|
public static string DefaultStartupDir =>
|
||||||
|
Environment.GetFolderPath(Environment.SpecialFolder.Startup);
|
||||||
|
|
||||||
|
public static string PathIn(string startupDir) => Path.Combine(startupDir, FileName);
|
||||||
|
|
||||||
|
public static void Install(string startupDir, string workerExe)
|
||||||
|
{
|
||||||
|
Directory.CreateDirectory(startupDir);
|
||||||
|
var workingDir = Path.GetDirectoryName(workerExe) ?? startupDir;
|
||||||
|
ShortcutFactory.CreateShortcut(PathIn(startupDir), workerExe, workingDir, "ClaudeDo background worker");
|
||||||
|
}
|
||||||
|
|
||||||
|
public static void Remove(string startupDir)
|
||||||
|
{
|
||||||
|
var path = PathIn(startupDir);
|
||||||
|
if (File.Exists(path)) File.Delete(path);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run tests to verify they pass**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Installer.Tests --filter AutostartShortcutTests`
|
||||||
|
Expected: PASS (3 tests).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Installer/Core/AutostartShortcut.cs tests/ClaudeDo.Installer.Tests/AutostartShortcutTests.cs
|
||||||
|
git commit -m "feat(installer): add AutostartShortcut helper for Startup-folder lnk"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: RegisterAutostartStep → Startup shortcut + task migration
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Installer/Steps/RegisterAutostartStep.cs`
|
||||||
|
- Delete: `src/ClaudeDo.Installer/Core/ScheduledTaskXml.cs`
|
||||||
|
- Delete: `tests/ClaudeDo.Installer.Tests/ScheduledTaskXmlTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Replace the step body**
|
||||||
|
|
||||||
|
Rewrite `src/ClaudeDo.Installer/Steps/RegisterAutostartStep.cs` to:
|
||||||
|
```csharp
|
||||||
|
using System.IO;
|
||||||
|
using ClaudeDo.Installer.Core;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Installer.Steps;
|
||||||
|
|
||||||
|
public sealed class RegisterAutostartStep : IInstallStep
|
||||||
|
{
|
||||||
|
public const string LegacyTaskName = "ClaudeDoWorker";
|
||||||
|
private const string LegacyServiceName = "ClaudeDoWorker";
|
||||||
|
|
||||||
|
public string Name => "Register Autostart";
|
||||||
|
|
||||||
|
public async Task<StepResult> ExecuteAsync(InstallContext ctx, IProgress<string> progress, CancellationToken ct)
|
||||||
|
{
|
||||||
|
var workerExe = Path.Combine(ctx.InstallDirectory, "worker", "ClaudeDo.Worker.exe");
|
||||||
|
if (!File.Exists(workerExe))
|
||||||
|
return StepResult.Fail($"Worker executable not found: {workerExe}");
|
||||||
|
|
||||||
|
// 1) Migrate away the legacy Windows service if present.
|
||||||
|
progress.Report("Checking for legacy worker service...");
|
||||||
|
var (queryExit, _) = await ProcessRunner.RunAsync("sc.exe", $"query {LegacyServiceName}", null, progress, ct);
|
||||||
|
if (queryExit == 0)
|
||||||
|
{
|
||||||
|
progress.Report("Removing legacy worker service...");
|
||||||
|
await ProcessRunner.RunAsync("sc.exe", $"stop {LegacyServiceName}", null, progress, ct);
|
||||||
|
await ProcessRunner.RunAsync("sc.exe", $"delete {LegacyServiceName}", null, progress, ct);
|
||||||
|
for (var i = 0; i < 30; i++)
|
||||||
|
{
|
||||||
|
ct.ThrowIfCancellationRequested();
|
||||||
|
var (q, _) = await ProcessRunner.RunAsync("sc.exe", $"query {LegacyServiceName}", null, progress, ct);
|
||||||
|
if (q != 0) break;
|
||||||
|
await Task.Delay(1000, ct);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// 2) Migrate away the legacy logon scheduled task if present (best-effort).
|
||||||
|
progress.Report("Removing legacy logon task...");
|
||||||
|
await ProcessRunner.RunAsync("schtasks.exe", $"/Delete /TN \"{LegacyTaskName}\" /F", null, progress, ct);
|
||||||
|
|
||||||
|
// 3) Register per-user autostart via a Startup-folder shortcut.
|
||||||
|
progress.Report("Creating Startup shortcut...");
|
||||||
|
try
|
||||||
|
{
|
||||||
|
AutostartShortcut.Install(AutostartShortcut.DefaultStartupDir, workerExe);
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
return StepResult.Fail($"Failed to create Startup shortcut: {ex.Message}");
|
||||||
|
}
|
||||||
|
|
||||||
|
return StepResult.Ok();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Delete the obsolete scheduled-task code and its test**
|
||||||
|
|
||||||
|
Run:
|
||||||
|
```bash
|
||||||
|
git rm src/ClaudeDo.Installer/Core/ScheduledTaskXml.cs tests/ClaudeDo.Installer.Tests/ScheduledTaskXmlTests.cs
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build the installer to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Installer/ClaudeDo.Installer.csproj`
|
||||||
|
Expected: Build succeeded. (If `RegisterAutostartStep.TaskName` was referenced elsewhere, the build will flag it — Task 4 and Task 5 update those references; if the build fails only there, proceed to those tasks before re-running.)
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Installer/Steps/RegisterAutostartStep.cs
|
||||||
|
git commit -m "feat(installer): register autostart via Startup shortcut, drop scheduled task"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: StartWorkerStep + StopWorkerStep
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Installer/Steps/StartWorkerStep.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Installer/Steps/StopWorkerStep.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Rewrite `StartWorkerStep` to launch the exe directly**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Installer/Steps/StartWorkerStep.cs`:
|
||||||
|
```csharp
|
||||||
|
using System.Diagnostics;
|
||||||
|
using System.IO;
|
||||||
|
using ClaudeDo.Installer.Core;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Installer.Steps;
|
||||||
|
|
||||||
|
public sealed class StartWorkerStep : IInstallStep
|
||||||
|
{
|
||||||
|
public string Name => "Start Worker";
|
||||||
|
|
||||||
|
public Task<StepResult> ExecuteAsync(InstallContext ctx, IProgress<string> progress, CancellationToken ct)
|
||||||
|
{
|
||||||
|
var workerExe = Path.Combine(ctx.InstallDirectory, "worker", "ClaudeDo.Worker.exe");
|
||||||
|
if (!File.Exists(workerExe))
|
||||||
|
return Task.FromResult(StepResult.Fail($"Worker executable not found: {workerExe}"));
|
||||||
|
|
||||||
|
progress.Report("Starting worker...");
|
||||||
|
try
|
||||||
|
{
|
||||||
|
Process.Start(new ProcessStartInfo(workerExe) { UseShellExecute = true });
|
||||||
|
return Task.FromResult(StepResult.Ok());
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
return Task.FromResult(StepResult.Fail($"Failed to start worker: {ex.Message}"));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Drop the `schtasks /End` call in `StopWorkerStep`**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Installer/Steps/StopWorkerStep.cs`, remove these two lines (the task no longer exists; the process kill below is the real stop):
|
||||||
|
```csharp
|
||||||
|
progress.Report("Stopping worker task (if running)...");
|
||||||
|
await ProcessRunner.RunAsync("schtasks.exe", $"/End /TN \"{TaskName}\"", null, progress, ct);
|
||||||
|
```
|
||||||
|
Keep the `public const string TaskName = "ClaudeDoWorker";` line — `UninstallRunner` still references it for legacy-task cleanup (Task 5). The method keeps its `async` modifier (it still has `await Task.CompletedTask;`).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Installer/ClaudeDo.Installer.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Installer/Steps/StartWorkerStep.cs src/ClaudeDo.Installer/Steps/StopWorkerStep.cs
|
||||||
|
git commit -m "feat(installer): start worker via Process.Start, drop schtasks stop"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: UninstallRunner removes the Startup shortcut
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Installer/Core/UninstallRunner.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add Startup `.lnk` removal**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Installer/Core/UninstallRunner.cs`, the shortcut-removal block (step 4, around lines 53-60) currently removes the Desktop and Start Menu `.lnk`s. Add the Startup shortcut removal right after them:
|
||||||
|
```csharp
|
||||||
|
// 4) Remove shortcuts (best-effort — a stuck .lnk must not block the rest).
|
||||||
|
progress.Report("Removing shortcuts...");
|
||||||
|
TryDeleteFile(Path.Combine(
|
||||||
|
Environment.GetFolderPath(Environment.SpecialFolder.CommonDesktopDirectory),
|
||||||
|
"ClaudeDo.lnk"));
|
||||||
|
TryDeleteFile(Path.Combine(
|
||||||
|
Environment.GetFolderPath(Environment.SpecialFolder.CommonStartMenu),
|
||||||
|
"Programs", "ClaudeDo.lnk"));
|
||||||
|
TryDeleteFile(AutostartShortcut.PathIn(AutostartShortcut.DefaultStartupDir));
|
||||||
|
```
|
||||||
|
The existing `schtasks /Delete /TN "{StopWorkerStep.TaskName}" /F` line (step 3) stays — it cleans up the legacy task on machines that still have it.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Installer/ClaudeDo.Installer.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Installer/Core/UninstallRunner.cs
|
||||||
|
git commit -m "feat(installer): remove Startup worker shortcut on uninstall"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 6: App stops auto-spawning the worker
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Remove the auto-spawn call**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`, delete this line from the constructor (line 224):
|
||||||
|
```csharp
|
||||||
|
_ = EnsureWorkerRunningAsync();
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Remove the `EnsureWorkerRunningAsync` method and its flag**
|
||||||
|
|
||||||
|
Delete the `_ensureRunningAttempted` field (line 308) and the whole `EnsureWorkerRunningAsync` method (lines 310-320):
|
||||||
|
```csharp
|
||||||
|
private bool _ensureRunningAttempted;
|
||||||
|
|
||||||
|
private async Task EnsureWorkerRunningAsync()
|
||||||
|
{
|
||||||
|
if (_ensureRunningAttempted) return;
|
||||||
|
_ensureRunningAttempted = true;
|
||||||
|
await Task.Delay(TimeSpan.FromSeconds(4));
|
||||||
|
if (Worker?.IsConnected == true) return;
|
||||||
|
var exe = _workerLocator.Find();
|
||||||
|
if (exe is null) return;
|
||||||
|
try { System.Diagnostics.Process.Start(new System.Diagnostics.ProcessStartInfo(exe) { UseShellExecute = true }); }
|
||||||
|
catch { /* logon task is the primary mechanism; this is a convenience */ }
|
||||||
|
}
|
||||||
|
```
|
||||||
|
Keep `RestartWorkerAsync` / `RestartWorkerService` (still used by the existing Restart button). `_workerLocator` stays in use (RestartWorkerService + Task 8).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: Build succeeded (no remaining references to `EnsureWorkerRunningAsync`).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs
|
||||||
|
git commit -m "refactor(ui): stop auto-spawning the worker on app start"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 7: WorkerConnectionModal (VM + View)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Ui/ViewModels/Modals/WorkerConnectionModalViewModel.cs`
|
||||||
|
- Create: `src/ClaudeDo.Ui/Views/Modals/WorkerConnectionModalView.axaml`
|
||||||
|
- Create: `src/ClaudeDo.Ui/Views/Modals/WorkerConnectionModalView.axaml.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Create the ViewModel**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Ui/ViewModels/Modals/WorkerConnectionModalViewModel.cs`:
|
||||||
|
```csharp
|
||||||
|
using System;
|
||||||
|
using System.Diagnostics;
|
||||||
|
using ClaudeDo.Ui.Services;
|
||||||
|
using CommunityToolkit.Mvvm.Input;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.ViewModels.Modals;
|
||||||
|
|
||||||
|
public sealed partial class WorkerConnectionModalViewModel : ViewModelBase
|
||||||
|
{
|
||||||
|
private readonly WorkerLocator _workerLocator;
|
||||||
|
private readonly InstallerLocator _installerLocator;
|
||||||
|
|
||||||
|
public WorkerConnectionModalViewModel(WorkerLocator workerLocator, InstallerLocator installerLocator)
|
||||||
|
{
|
||||||
|
_workerLocator = workerLocator;
|
||||||
|
_installerLocator = installerLocator;
|
||||||
|
}
|
||||||
|
|
||||||
|
public Action? CloseAction { get; set; }
|
||||||
|
|
||||||
|
[RelayCommand] private void Close() => CloseAction?.Invoke();
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private void StartWorker()
|
||||||
|
{
|
||||||
|
var exe = _workerLocator.Find();
|
||||||
|
if (exe is null) return;
|
||||||
|
try { Process.Start(new ProcessStartInfo(exe) { UseShellExecute = true }); }
|
||||||
|
catch { /* nothing useful to show */ }
|
||||||
|
CloseAction?.Invoke();
|
||||||
|
}
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private void RerunInstaller()
|
||||||
|
{
|
||||||
|
var path = _installerLocator.Find();
|
||||||
|
if (path is null) return;
|
||||||
|
try
|
||||||
|
{
|
||||||
|
Process.Start(new ProcessStartInfo(path) { UseShellExecute = true });
|
||||||
|
Environment.Exit(0);
|
||||||
|
}
|
||||||
|
catch { /* nothing useful to show */ }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Create the View (mirrors `AboutModalView` + `ModalShell`)**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Ui/Views/Modals/WorkerConnectionModalView.axaml`:
|
||||||
|
```xml
|
||||||
|
<Window xmlns="https://github.com/avaloniaui"
|
||||||
|
xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
|
||||||
|
xmlns:vm="using:ClaudeDo.Ui.ViewModels.Modals"
|
||||||
|
xmlns:ctl="using:ClaudeDo.Ui.Views.Controls"
|
||||||
|
x:Class="ClaudeDo.Ui.Views.Modals.WorkerConnectionModalView"
|
||||||
|
x:DataType="vm:WorkerConnectionModalViewModel"
|
||||||
|
Title="Worker not reachable"
|
||||||
|
Width="520" Height="240"
|
||||||
|
WindowDecorations="None"
|
||||||
|
ExtendClientAreaToDecorationsHint="True"
|
||||||
|
WindowStartupLocation="CenterOwner"
|
||||||
|
Background="{DynamicResource SurfaceBrush}">
|
||||||
|
<Window.KeyBindings>
|
||||||
|
<KeyBinding Gesture="Escape" Command="{Binding CloseCommand}"/>
|
||||||
|
</Window.KeyBindings>
|
||||||
|
|
||||||
|
<ctl:ModalShell Title="WORKER NOT REACHABLE" CloseCommand="{Binding CloseCommand}">
|
||||||
|
<Grid RowDefinitions="*,Auto" Margin="20,16">
|
||||||
|
<TextBlock Grid.Row="0" Classes="meta" TextWrapping="Wrap"
|
||||||
|
Text="ClaudeDo can't reach the background worker. It is normally started automatically at logon. You can start it now, or reinstall if the problem persists."/>
|
||||||
|
<StackPanel Grid.Row="1" Orientation="Horizontal" Spacing="8"
|
||||||
|
HorizontalAlignment="Right" Margin="0,16,0,0">
|
||||||
|
<Button Classes="btn" Content="Dismiss" Command="{Binding CloseCommand}"/>
|
||||||
|
<Button Classes="btn" Content="Rerun Installer" Command="{Binding RerunInstallerCommand}"/>
|
||||||
|
<Button Classes="btn primary" Content="Start Worker" Command="{Binding StartWorkerCommand}"/>
|
||||||
|
</StackPanel>
|
||||||
|
</Grid>
|
||||||
|
</ctl:ModalShell>
|
||||||
|
</Window>
|
||||||
|
```
|
||||||
|
|
||||||
|
`src/ClaudeDo.Ui/Views/Modals/WorkerConnectionModalView.axaml.cs`:
|
||||||
|
```csharp
|
||||||
|
using Avalonia.Controls;
|
||||||
|
using Avalonia.Markup.Xaml;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Views.Modals;
|
||||||
|
|
||||||
|
public partial class WorkerConnectionModalView : Window
|
||||||
|
{
|
||||||
|
public WorkerConnectionModalView()
|
||||||
|
{
|
||||||
|
InitializeComponent();
|
||||||
|
}
|
||||||
|
|
||||||
|
private void InitializeComponent() => AvaloniaXamlLoader.Load(this);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/Modals/WorkerConnectionModalViewModel.cs src/ClaudeDo.Ui/Views/Modals/WorkerConnectionModalView.axaml src/ClaudeDo.Ui/Views/Modals/WorkerConnectionModalView.axaml.cs
|
||||||
|
git commit -m "feat(ui): add worker connection help modal"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 8: Shell hook, command, grace timer + decision gate
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Ui.Tests/ConnectionPromptGateTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test for the decision gate**
|
||||||
|
|
||||||
|
`tests/ClaudeDo.Ui.Tests/ConnectionPromptGateTests.cs`:
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Ui.ViewModels;
|
||||||
|
using Xunit;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Tests;
|
||||||
|
|
||||||
|
public class ConnectionPromptGateTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void Shows_once_when_offline()
|
||||||
|
{
|
||||||
|
var vm = new IslandsShellViewModel();
|
||||||
|
Assert.True(vm.DecideShowConnectionPrompt(isOffline: true));
|
||||||
|
Assert.False(vm.DecideShowConnectionPrompt(isOffline: true)); // not a second time
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Does_not_show_when_connected_before_grace()
|
||||||
|
{
|
||||||
|
var vm = new IslandsShellViewModel();
|
||||||
|
Assert.False(vm.DecideShowConnectionPrompt(isOffline: false));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Ui.Tests --filter ConnectionPromptGateTests`
|
||||||
|
Expected: FAIL — `DecideShowConnectionPrompt` does not exist.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Add the hook, command, gate, and grace timer**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`:
|
||||||
|
|
||||||
|
Add a hook property near the other `Show*Modal` hooks (after line 52):
|
||||||
|
```csharp
|
||||||
|
// Set by MainWindow to open the worker-connection help dialog.
|
||||||
|
public Func<Modals.WorkerConnectionModalViewModel, Task>? ShowWorkerConnectionModal { get; set; }
|
||||||
|
```
|
||||||
|
|
||||||
|
Add the gate field + method and the open command (place near `OpenAbout`, around line 271):
|
||||||
|
```csharp
|
||||||
|
private bool _connectionPromptShown;
|
||||||
|
|
||||||
|
internal bool DecideShowConnectionPrompt(bool isOffline)
|
||||||
|
{
|
||||||
|
if (!isOffline) return false;
|
||||||
|
if (_connectionPromptShown) return false;
|
||||||
|
_connectionPromptShown = true;
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
private async Task OpenWorkerConnectionHelpAsync()
|
||||||
|
{
|
||||||
|
var vm = new Modals.WorkerConnectionModalViewModel(_workerLocator, _installerLocator);
|
||||||
|
if (ShowWorkerConnectionModal is not null) await ShowWorkerConnectionModal(vm);
|
||||||
|
}
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private Task OpenWorkerConnectionHelp() => OpenWorkerConnectionHelpAsync();
|
||||||
|
```
|
||||||
|
|
||||||
|
Add the grace timer field near `_clearTimer` (line 74):
|
||||||
|
```csharp
|
||||||
|
private readonly System.Timers.Timer _connectTimer = new(12_000) { AutoReset = false };
|
||||||
|
```
|
||||||
|
|
||||||
|
Wire and start it inside the **public** constructor (after the `_primeStatusTimer.Elapsed` wiring, near line 222 — NOT in the parameterless test constructor):
|
||||||
|
```csharp
|
||||||
|
_connectTimer.Elapsed += (_, _) => Dispatcher.UIThread.Post(() =>
|
||||||
|
{
|
||||||
|
if (DecideShowConnectionPrompt(IsOffline)) _ = OpenWorkerConnectionHelpAsync();
|
||||||
|
});
|
||||||
|
_connectTimer.Start();
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run tests to verify they pass**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Ui.Tests --filter ConnectionPromptGateTests`
|
||||||
|
Expected: PASS (2 tests).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Build the app**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs tests/ClaudeDo.Ui.Tests/ConnectionPromptGateTests.cs
|
||||||
|
git commit -m "feat(ui): prompt once on worker connection failure with grace timer"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 9: Wire the modal in MainWindow + clickable status pill
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/MainWindow.axaml.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/MainWindow.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Wire the dialog hook**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Views/MainWindow.axaml.cs`, inside `OnDataContextChanged`, after the existing `vm.ShowRepoImportModal = ...` block (line 70), add:
|
||||||
|
```csharp
|
||||||
|
vm.ShowWorkerConnectionModal = async (connVm) =>
|
||||||
|
{
|
||||||
|
var dlg = new WorkerConnectionModalView { DataContext = connVm };
|
||||||
|
connVm.CloseAction = () => dlg.Close();
|
||||||
|
await dlg.ShowDialog(this);
|
||||||
|
};
|
||||||
|
```
|
||||||
|
(`ClaudeDo.Ui.Views.Modals` is already imported at line 10.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Make the status pill a button**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Views/MainWindow.axaml`, replace the left "connection pill" `StackPanel` (lines 190-202) with a `Button` wrapping the same content:
|
||||||
|
```xml
|
||||||
|
<!-- Left: connection pill (click to open worker help) -->
|
||||||
|
<Button DockPanel.Dock="Left"
|
||||||
|
Command="{Binding OpenWorkerConnectionHelpCommand}"
|
||||||
|
Background="Transparent" BorderThickness="0" Padding="0"
|
||||||
|
Cursor="Hand" VerticalAlignment="Center">
|
||||||
|
<StackPanel Orientation="Horizontal" Spacing="7" VerticalAlignment="Center">
|
||||||
|
<Ellipse Width="7" Height="7" Fill="{DynamicResource StatusRunningBrush}"
|
||||||
|
IsVisible="{Binding Worker.IsConnected}"/>
|
||||||
|
<Ellipse Width="7" Height="7" Fill="{DynamicResource StatusReviewBrush}"
|
||||||
|
IsVisible="{Binding Worker.IsReconnecting}"/>
|
||||||
|
<Ellipse Width="7" Height="7" Fill="{DynamicResource StatusErrorBrush}"
|
||||||
|
IsVisible="{Binding IsOffline}"/>
|
||||||
|
<TextBlock Classes="eyebrow"
|
||||||
|
Text="{Binding ConnectionText, Converter={StaticResource UpperCase}}"
|
||||||
|
LetterSpacing="1.4"
|
||||||
|
VerticalAlignment="Center"/>
|
||||||
|
</StackPanel>
|
||||||
|
</Button>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build the app**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Manual verification**
|
||||||
|
|
||||||
|
Start the worker (or leave it stopped) and run the App:
|
||||||
|
- Worker stopped → after ~12s the "WORKER NOT REACHABLE" dialog appears once. **Start Worker** launches it (footer pill turns ONLINE); **Rerun Installer** launches the installer and exits; **Dismiss** closes and does not reappear automatically.
|
||||||
|
- Click the footer status pill anytime → the dialog reopens.
|
||||||
|
- Worker running before launch → no dialog appears.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Views/MainWindow.axaml.cs src/ClaudeDo.Ui/Views/MainWindow.axaml
|
||||||
|
git commit -m "feat(ui): wire worker connection modal and make status pill clickable"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 10: Full build + test sweep
|
||||||
|
|
||||||
|
- [ ] **Step 1: Build the touched projects**
|
||||||
|
|
||||||
|
Run:
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj
|
||||||
|
dotnet build src/ClaudeDo.Installer/ClaudeDo.Installer.csproj
|
||||||
|
```
|
||||||
|
Expected: both Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run the affected test suites**
|
||||||
|
|
||||||
|
Run:
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Installer.Tests
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests
|
||||||
|
```
|
||||||
|
Expected: all pass; no references to the deleted `ScheduledTaskXml`.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Final commit (if any stragglers)**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add -A
|
||||||
|
git commit -m "chore: worker lifecycle redesign cleanup" || echo "nothing to commit"
|
||||||
|
```
|
||||||
983
docs/superpowers/plans/2026-06-02-prime-recurring-weekdays.md
Normal file
983
docs/superpowers/plans/2026-06-02-prime-recurring-weekdays.md
Normal file
@@ -0,0 +1,983 @@
|
|||||||
|
# Prime Recurring Weekday Schedule — Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Replace the Prime schedule's date-range model with a recurring weekday model — pick a set of weekdays plus a time, and the ping fires on the next eligible day the worker is running.
|
||||||
|
|
||||||
|
**Architecture:** A `[Flags] PrimeDays` weekday bitmask stored as a single `days_of_week` int column replaces `StartDate`/`EndDate`/`WorkdaysOnly`. `NextDueCalculator` walks forward to the next selected weekday; the existing 30-minute catch-up and already-fired-today logic are untouched. UI swaps the range picker + Mon–Fri checkbox for seven toggle buttons. Both SignalR DTO copies carry a single `int Days`.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, EF Core (SQLite), Avalonia 12 (CommunityToolkit.Mvvm), SignalR, xUnit.
|
||||||
|
|
||||||
|
**Spec:** `docs/superpowers/specs/2026-06-02-prime-recurring-weekdays-design.md`
|
||||||
|
|
||||||
|
**Build/test note:** `dotnet build ClaudeDo.slnx` needs .NET 9; on .NET 8 build individual csproj. Commands in this plan use the per-project form.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File Structure
|
||||||
|
|
||||||
|
- `src/ClaudeDo.Data/Models/PrimeDays.cs` — **new**, `[Flags]` enum.
|
||||||
|
- `src/ClaudeDo.Data/Models/PrimeScheduleEntity.cs` — swap fields.
|
||||||
|
- `src/ClaudeDo.Data/Configuration/PrimeScheduleEntityConfiguration.cs` — column mapping.
|
||||||
|
- `src/ClaudeDo.Data/Migrations/*` — new migration + snapshot.
|
||||||
|
- `src/ClaudeDo.Data/Repositories/PrimeScheduleRepository.cs` — upsert fields + ordering.
|
||||||
|
- `src/ClaudeDo.Worker/Prime/PrimeScheduleDto.cs` — `int Days`.
|
||||||
|
- `src/ClaudeDo.Worker/Prime/NextDueCalculator.cs` — weekday eligibility.
|
||||||
|
- `src/ClaudeDo.Worker/Prime/PrimeScheduler.cs` — `ToDto` mapping.
|
||||||
|
- `src/ClaudeDo.Worker/Hub/WorkerHub.cs` — list/upsert mapping.
|
||||||
|
- `src/ClaudeDo.Ui/Services/PrimeScheduleDto.cs` — `int Days`.
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Modals/Settings/PrimeScheduleRowViewModel.cs` — 7 day bools.
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Modals/Settings/PrimeClaudeTabViewModel.cs` — defaults + validation.
|
||||||
|
- `src/ClaudeDo.Ui/Design/IslandStyles.axaml` — `day-toggle` style class.
|
||||||
|
- `src/ClaudeDo.Ui/Views/Modals/SettingsModalView.axaml` — row template.
|
||||||
|
- Tests: `NextDueCalculatorTests`, `PrimeSchedulerTests`, `PrimeScheduleRepositoryTests`, `PrimeClaudeTabViewModelTests`.
|
||||||
|
- Docs: `src/ClaudeDo.Data/CLAUDE.md`, root `CLAUDE.md`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: PrimeDays enum + entity + configuration
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Data/Models/PrimeDays.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Data/Models/PrimeScheduleEntity.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Data/Configuration/PrimeScheduleEntityConfiguration.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Create the flags enum**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Data/Models/PrimeDays.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Data.Models;
|
||||||
|
|
||||||
|
[Flags]
|
||||||
|
public enum PrimeDays
|
||||||
|
{
|
||||||
|
None = 0,
|
||||||
|
Monday = 1,
|
||||||
|
Tuesday = 2,
|
||||||
|
Wednesday = 4,
|
||||||
|
Thursday = 8,
|
||||||
|
Friday = 16,
|
||||||
|
Saturday = 32,
|
||||||
|
Sunday = 64,
|
||||||
|
Weekdays = Monday | Tuesday | Wednesday | Thursday | Friday, // 31
|
||||||
|
All = Weekdays | Saturday | Sunday, // 127
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Swap entity fields**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Data/Models/PrimeScheduleEntity.cs`, remove `StartDate`, `EndDate`, `WorkdaysOnly` and add `Days`. Result:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Data.Models;
|
||||||
|
|
||||||
|
public sealed class PrimeScheduleEntity
|
||||||
|
{
|
||||||
|
public Guid Id { get; set; } = Guid.NewGuid();
|
||||||
|
public PrimeDays Days { get; set; } = PrimeDays.Weekdays;
|
||||||
|
public TimeSpan TimeOfDay { get; set; }
|
||||||
|
public bool Enabled { get; set; } = true;
|
||||||
|
public DateTimeOffset? LastRunAt { get; set; }
|
||||||
|
public string? PromptOverride { get; set; }
|
||||||
|
public DateTimeOffset CreatedAt { get; set; } = DateTimeOffset.UtcNow;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Update entity configuration**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Data/Configuration/PrimeScheduleEntityConfiguration.cs`, replace the `start_date`/`end_date`/`workdays_only` property lines with a `days_of_week` mapping (EF maps the enum to INTEGER automatically):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
builder.Property(s => s.Days).HasColumnName("days_of_week")
|
||||||
|
.IsRequired().HasDefaultValue(PrimeDays.Weekdays);
|
||||||
|
builder.Property(s => s.TimeOfDay).HasColumnName("time_of_day").IsRequired();
|
||||||
|
builder.Property(s => s.Enabled).HasColumnName("enabled").IsRequired().HasDefaultValue(true);
|
||||||
|
```
|
||||||
|
|
||||||
|
Leave `Id`, `LastRunAt`, `PromptOverride`, `CreatedAt` mappings unchanged. Add `using ClaudeDo.Data.Models;` if not present (it already is).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build the Data project**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Data/ClaudeDo.Data.csproj`
|
||||||
|
Expected: FAILS — `PrimeScheduleRepository`, snapshot, etc. still reference removed fields. That is expected; Tasks 2–3 fix it. (If you prefer a clean build gate, proceed to Task 2 before building.)
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Data/Models/PrimeDays.cs src/ClaudeDo.Data/Models/PrimeScheduleEntity.cs src/ClaudeDo.Data/Configuration/PrimeScheduleEntityConfiguration.cs
|
||||||
|
git commit -m "feat(data): model Prime schedule as weekday bitmask"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: Repository
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Data/Repositories/PrimeScheduleRepository.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Update `ListAsync` ordering**
|
||||||
|
|
||||||
|
The old ordering used `StartDate`. Order by `TimeOfDay`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public async Task<IReadOnlyList<PrimeScheduleEntity>> ListAsync(CancellationToken ct = default)
|
||||||
|
{
|
||||||
|
var rows = await _context.PrimeSchedules.AsNoTracking()
|
||||||
|
.OrderBy(s => s.TimeOfDay)
|
||||||
|
.ToListAsync(ct);
|
||||||
|
return rows;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Update `UpsertAsync` field copy**
|
||||||
|
|
||||||
|
Replace the three removed-field assignments with `Days`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
else
|
||||||
|
{
|
||||||
|
existing.Days = entity.Days;
|
||||||
|
existing.TimeOfDay = entity.TimeOfDay;
|
||||||
|
existing.Enabled = entity.Enabled;
|
||||||
|
existing.PromptOverride = entity.PromptOverride;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Leave `GetAsync`, `DeleteAsync`, `UpdateLastRunAsync` unchanged.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit** (build verified after migration in Task 3)
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Data/Repositories/PrimeScheduleRepository.cs
|
||||||
|
git commit -m "feat(data): persist weekday bitmask in prime schedule repo"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: EF migration
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Data/Migrations/<timestamp>_PrimeWeekdays.cs` (generated)
|
||||||
|
- Modify: `src/ClaudeDo.Data/Migrations/ClaudeDoDbContextModelSnapshot.cs` (generated)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Generate the migration**
|
||||||
|
|
||||||
|
Run from repo root:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet ef migrations add PrimeWeekdays --project src/ClaudeDo.Data/ClaudeDo.Data.csproj --startup-project src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
```
|
||||||
|
|
||||||
|
Expected: a new `*_PrimeWeekdays.cs` file and an updated snapshot. (If `dotnet ef` is unavailable, hand-write the migration using the body below.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Replace the generated `Up` body with an explicit backfill**
|
||||||
|
|
||||||
|
EF's auto-generated drop/add would discard existing schedules' weekday intent. Edit the new migration's `Up` to add the column, backfill from `workdays_only`, then drop the old columns:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
protected override void Up(MigrationBuilder migrationBuilder)
|
||||||
|
{
|
||||||
|
migrationBuilder.AddColumn<int>(
|
||||||
|
name: "days_of_week",
|
||||||
|
table: "prime_schedules",
|
||||||
|
type: "INTEGER",
|
||||||
|
nullable: false,
|
||||||
|
defaultValue: 31);
|
||||||
|
|
||||||
|
migrationBuilder.Sql(
|
||||||
|
"UPDATE prime_schedules SET days_of_week = CASE WHEN workdays_only = 1 THEN 31 ELSE 127 END;");
|
||||||
|
|
||||||
|
migrationBuilder.DropColumn(name: "start_date", table: "prime_schedules");
|
||||||
|
migrationBuilder.DropColumn(name: "end_date", table: "prime_schedules");
|
||||||
|
migrationBuilder.DropColumn(name: "workdays_only", table: "prime_schedules");
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Replace the generated `Down` body**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
protected override void Down(MigrationBuilder migrationBuilder)
|
||||||
|
{
|
||||||
|
migrationBuilder.AddColumn<DateOnly>(
|
||||||
|
name: "start_date", table: "prime_schedules",
|
||||||
|
type: "TEXT", nullable: false, defaultValue: new DateOnly(2000, 1, 1));
|
||||||
|
migrationBuilder.AddColumn<DateOnly>(
|
||||||
|
name: "end_date", table: "prime_schedules",
|
||||||
|
type: "TEXT", nullable: false, defaultValue: new DateOnly(2099, 12, 31));
|
||||||
|
migrationBuilder.AddColumn<bool>(
|
||||||
|
name: "workdays_only", table: "prime_schedules",
|
||||||
|
type: "INTEGER", nullable: false, defaultValue: true);
|
||||||
|
|
||||||
|
migrationBuilder.Sql(
|
||||||
|
"UPDATE prime_schedules SET workdays_only = CASE WHEN days_of_week = 127 THEN 0 ELSE 1 END;");
|
||||||
|
|
||||||
|
migrationBuilder.DropColumn(name: "days_of_week", table: "prime_schedules");
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `using System;` at the top of the migration file if `DateOnly` defaults require it (the existing AddPrimeSchedules migration already imports `System`).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build the Data project**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Data/ClaudeDo.Data.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Data/Migrations
|
||||||
|
git commit -m "feat(data): migrate prime schedules to days_of_week bitmask"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: Worker DTO + NextDueCalculator (TDD)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Prime/PrimeScheduleDto.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Prime/NextDueCalculator.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/Prime/NextDueCalculatorTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Update the Worker DTO**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Worker/Prime/PrimeScheduleDto.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Worker.Prime;
|
||||||
|
|
||||||
|
public sealed record PrimeScheduleDto(
|
||||||
|
Guid Id,
|
||||||
|
int Days,
|
||||||
|
TimeSpan TimeOfDay,
|
||||||
|
bool Enabled,
|
||||||
|
DateTimeOffset? LastRunAt,
|
||||||
|
string? PromptOverride);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Rewrite the calculator tests**
|
||||||
|
|
||||||
|
Replace the entire body of `tests/ClaudeDo.Worker.Tests/Prime/NextDueCalculatorTests.cs`. Note: 2026-05-05 is a Tuesday; 2026-05-08 is a Friday; 2026-05-09/10 are Sat/Sun; 2026-05-11 is a Monday.
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Worker.Prime;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.Prime;
|
||||||
|
|
||||||
|
public class NextDueCalculatorTests
|
||||||
|
{
|
||||||
|
private static PrimeScheduleDto Schedule(
|
||||||
|
PrimeDays days, TimeSpan time,
|
||||||
|
bool enabled = true, DateTimeOffset? lastRun = null) =>
|
||||||
|
new(Guid.NewGuid(), (int)days, time, enabled, lastRun, null);
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Disabled_Schedule_Returns_Null()
|
||||||
|
{
|
||||||
|
var now = new DateTimeOffset(2026, 5, 5, 6, 0, 0, TimeSpan.FromHours(2));
|
||||||
|
var s = Schedule(PrimeDays.All, new(7, 0, 0), enabled: false);
|
||||||
|
Assert.Null(NextDueCalculator.Compute(new[] { s }, now, TimeSpan.FromMinutes(30)));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void No_Days_Selected_Returns_Null()
|
||||||
|
{
|
||||||
|
var now = new DateTimeOffset(2026, 5, 5, 6, 0, 0, TimeSpan.FromHours(2));
|
||||||
|
var s = Schedule(PrimeDays.None, new(7, 0, 0));
|
||||||
|
Assert.Null(NextDueCalculator.Compute(new[] { s }, now, TimeSpan.FromMinutes(30)));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Future_Same_Day_Returns_Today_At_Target()
|
||||||
|
{
|
||||||
|
var now = new DateTimeOffset(2026, 5, 5, 6, 0, 0, TimeSpan.FromHours(2)); // Tue
|
||||||
|
var s = Schedule(PrimeDays.All, new(7, 0, 0));
|
||||||
|
var r = NextDueCalculator.Compute(new[] { s }, now, TimeSpan.FromMinutes(30));
|
||||||
|
Assert.NotNull(r);
|
||||||
|
Assert.Equal(new DateTimeOffset(2026, 5, 5, 7, 0, 0, now.Offset), r!.At);
|
||||||
|
Assert.False(r.FireImmediately);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Within_CatchUp_Window_Fires_Immediately()
|
||||||
|
{
|
||||||
|
var now = new DateTimeOffset(2026, 5, 5, 7, 15, 0, TimeSpan.FromHours(2));
|
||||||
|
var s = Schedule(PrimeDays.All, new(7, 0, 0));
|
||||||
|
var r = NextDueCalculator.Compute(new[] { s }, now, TimeSpan.FromMinutes(30));
|
||||||
|
Assert.NotNull(r);
|
||||||
|
Assert.True(r!.FireImmediately);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Past_CatchUp_Window_Skips_To_Next_Eligible_Day()
|
||||||
|
{
|
||||||
|
var now = new DateTimeOffset(2026, 5, 5, 9, 0, 0, TimeSpan.FromHours(2)); // Tue
|
||||||
|
var s = Schedule(PrimeDays.All, new(7, 0, 0));
|
||||||
|
var r = NextDueCalculator.Compute(new[] { s }, now, TimeSpan.FromMinutes(30));
|
||||||
|
Assert.NotNull(r);
|
||||||
|
Assert.Equal(new DateOnly(2026, 5, 6), DateOnly.FromDateTime(r!.At.LocalDateTime));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Weekdays_Only_Skips_Weekend()
|
||||||
|
{
|
||||||
|
var now = new DateTimeOffset(2026, 5, 8, 8, 0, 0, TimeSpan.FromHours(2)); // Fri, past catch-up
|
||||||
|
var s = Schedule(PrimeDays.Weekdays, new(7, 0, 0));
|
||||||
|
var r = NextDueCalculator.Compute(new[] { s }, now, TimeSpan.FromMinutes(30));
|
||||||
|
Assert.NotNull(r);
|
||||||
|
Assert.Equal(DayOfWeek.Monday, r!.At.LocalDateTime.DayOfWeek);
|
||||||
|
Assert.Equal(new DateOnly(2026, 5, 11), DateOnly.FromDateTime(r.At.LocalDateTime));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Single_Day_Schedule_Targets_That_Weekday()
|
||||||
|
{
|
||||||
|
var now = new DateTimeOffset(2026, 5, 5, 8, 0, 0, TimeSpan.FromHours(2)); // Tue, past catch-up
|
||||||
|
var s = Schedule(PrimeDays.Friday, new(7, 0, 0));
|
||||||
|
var r = NextDueCalculator.Compute(new[] { s }, now, TimeSpan.FromMinutes(30));
|
||||||
|
Assert.NotNull(r);
|
||||||
|
Assert.Equal(DayOfWeek.Friday, r!.At.LocalDateTime.DayOfWeek);
|
||||||
|
Assert.Equal(new DateOnly(2026, 5, 8), DateOnly.FromDateTime(r.At.LocalDateTime));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Already_Fired_Today_Skips_To_Next_Eligible_Day()
|
||||||
|
{
|
||||||
|
var now = new DateTimeOffset(2026, 5, 5, 6, 0, 0, TimeSpan.FromHours(2));
|
||||||
|
var lastRun = new DateTimeOffset(2026, 5, 5, 7, 1, 0, TimeSpan.FromHours(2));
|
||||||
|
var s = Schedule(PrimeDays.All, new(7, 0, 0), lastRun: lastRun);
|
||||||
|
var r = NextDueCalculator.Compute(new[] { s }, now, TimeSpan.FromMinutes(30));
|
||||||
|
Assert.NotNull(r);
|
||||||
|
Assert.Equal(new DateOnly(2026, 5, 6), DateOnly.FromDateTime(r!.At.LocalDateTime));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Multiple_Schedules_Returns_Earliest()
|
||||||
|
{
|
||||||
|
var now = new DateTimeOffset(2026, 5, 5, 6, 0, 0, TimeSpan.FromHours(2));
|
||||||
|
var early = Schedule(PrimeDays.All, new(7, 0, 0));
|
||||||
|
var late = Schedule(PrimeDays.All, new(9, 0, 0));
|
||||||
|
var r = NextDueCalculator.Compute(new[] { late, early }, now, TimeSpan.FromMinutes(30));
|
||||||
|
Assert.NotNull(r);
|
||||||
|
Assert.Equal(early.Id, r!.Schedule.Id);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Run the tests to verify they fail**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter FullyQualifiedName~NextDueCalculatorTests`
|
||||||
|
Expected: FAIL — `PrimeScheduleDto` no longer has `StartDate`/`EndDate`/`workdaysOnly`, and the calculator still references them (compile errors).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Rewrite the calculator**
|
||||||
|
|
||||||
|
Replace the entire body of `src/ClaudeDo.Worker/Prime/NextDueCalculator.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Prime;
|
||||||
|
|
||||||
|
public sealed record NextDue(PrimeScheduleDto Schedule, DateTimeOffset At, bool FireImmediately);
|
||||||
|
|
||||||
|
public static class NextDueCalculator
|
||||||
|
{
|
||||||
|
public static NextDue? Compute(
|
||||||
|
IEnumerable<PrimeScheduleDto> schedules,
|
||||||
|
DateTimeOffset now,
|
||||||
|
TimeSpan catchUp)
|
||||||
|
{
|
||||||
|
NextDue? best = null;
|
||||||
|
foreach (var s in schedules)
|
||||||
|
{
|
||||||
|
if (!s.Enabled) continue;
|
||||||
|
var due = ComputeFor(s, now, catchUp);
|
||||||
|
if (due is null) continue;
|
||||||
|
if (best is null || due.At < best.At) best = due;
|
||||||
|
}
|
||||||
|
return best;
|
||||||
|
}
|
||||||
|
|
||||||
|
private static NextDue? ComputeFor(PrimeScheduleDto s, DateTimeOffset now, TimeSpan catchUp)
|
||||||
|
{
|
||||||
|
if ((PrimeDays)s.Days == PrimeDays.None) return null;
|
||||||
|
|
||||||
|
var todayLocal = DateOnly.FromDateTime(now.LocalDateTime);
|
||||||
|
var alreadyFiredToday = s.LastRunAt is { } last &&
|
||||||
|
DateOnly.FromDateTime(last.LocalDateTime) == todayLocal;
|
||||||
|
|
||||||
|
if (!alreadyFiredToday && IsEligibleDay(s, todayLocal))
|
||||||
|
{
|
||||||
|
var todayTarget = ToOffset(todayLocal, s.TimeOfDay, now.Offset);
|
||||||
|
if (todayTarget >= now)
|
||||||
|
return new NextDue(s, todayTarget, false);
|
||||||
|
if (now <= todayTarget + catchUp)
|
||||||
|
return new NextDue(s, now, true);
|
||||||
|
}
|
||||||
|
|
||||||
|
var d = todayLocal.AddDays(1);
|
||||||
|
for (int i = 0; i < 7; i++)
|
||||||
|
{
|
||||||
|
if (IsEligibleDay(s, d))
|
||||||
|
return new NextDue(s, ToOffset(d, s.TimeOfDay, now.Offset), false);
|
||||||
|
d = d.AddDays(1);
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
private static bool IsEligibleDay(PrimeScheduleDto s, DateOnly d) =>
|
||||||
|
((PrimeDays)s.Days & ToFlag(d.DayOfWeek)) != PrimeDays.None;
|
||||||
|
|
||||||
|
private static PrimeDays ToFlag(DayOfWeek dow) => dow switch
|
||||||
|
{
|
||||||
|
DayOfWeek.Monday => PrimeDays.Monday,
|
||||||
|
DayOfWeek.Tuesday => PrimeDays.Tuesday,
|
||||||
|
DayOfWeek.Wednesday => PrimeDays.Wednesday,
|
||||||
|
DayOfWeek.Thursday => PrimeDays.Thursday,
|
||||||
|
DayOfWeek.Friday => PrimeDays.Friday,
|
||||||
|
DayOfWeek.Saturday => PrimeDays.Saturday,
|
||||||
|
DayOfWeek.Sunday => PrimeDays.Sunday,
|
||||||
|
_ => PrimeDays.None,
|
||||||
|
};
|
||||||
|
|
||||||
|
private static DateTimeOffset ToOffset(DateOnly day, TimeSpan time, TimeSpan offset) =>
|
||||||
|
new(day.Year, day.Month, day.Day, time.Hours, time.Minutes, time.Seconds, offset);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Run the calculator tests**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter FullyQualifiedName~NextDueCalculatorTests`
|
||||||
|
Expected: still FAILS to build — `PrimeScheduler.ToDto` and `WorkerHub` mappings reference removed fields. Proceed to Tasks 5–6, then re-run.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Prime/PrimeScheduleDto.cs src/ClaudeDo.Worker/Prime/NextDueCalculator.cs tests/ClaudeDo.Worker.Tests/Prime/NextDueCalculatorTests.cs
|
||||||
|
git commit -m "feat(worker): compute prime due-time from weekday bitmask"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: PrimeScheduler.ToDto + scheduler tests
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Prime/PrimeScheduler.cs:104-105`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/Prime/PrimeSchedulerTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Update the `ToDto` mapping**
|
||||||
|
|
||||||
|
Replace the `ToDto` method in `PrimeScheduler.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private static PrimeScheduleDto ToDto(Data.Models.PrimeScheduleEntity e) =>
|
||||||
|
new(e.Id, (int)e.Days, e.TimeOfDay, e.Enabled, e.LastRunAt, e.PromptOverride);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Update scheduler test fixtures**
|
||||||
|
|
||||||
|
In `tests/ClaudeDo.Worker.Tests/Prime/PrimeSchedulerTests.cs`, every `new PrimeScheduleEntity { ... }` initializer sets `StartDate`/`EndDate`/`WorkdaysOnly`. Replace those three lines in each of the three initializers (lines ~48-52, ~89-94, ~131-136) with a single `Days` assignment. Each initializer becomes:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
await new PrimeScheduleRepository(ctx).UpsertAsync(new PrimeScheduleEntity
|
||||||
|
{
|
||||||
|
Id = id,
|
||||||
|
Days = PrimeDays.All,
|
||||||
|
TimeOfDay = new TimeSpan(7, 0, 0),
|
||||||
|
Enabled = true,
|
||||||
|
CreatedAt = DateTimeOffset.UtcNow,
|
||||||
|
});
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `using ClaudeDo.Data.Models;` to the file's usings if not already present (it is, via line 1).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Run scheduler + calculator tests**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests --filter "FullyQualifiedName~Prime"`
|
||||||
|
Expected: still build-fails until `WorkerHub` (Task 6) compiles. After Task 6, this command must PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Prime/PrimeScheduler.cs tests/ClaudeDo.Worker.Tests/Prime/PrimeSchedulerTests.cs
|
||||||
|
git commit -m "test(worker): adapt prime scheduler tests to weekday model"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 6: WorkerHub mapping + repository tests
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Hub/WorkerHub.cs:488-518`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/Repositories/PrimeScheduleRepositoryTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Update `ListPrimeSchedules`**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public async Task<List<PrimeScheduleDto>> ListPrimeSchedules()
|
||||||
|
{
|
||||||
|
using var ctx = _dbFactory.CreateDbContext();
|
||||||
|
var rows = await new PrimeScheduleRepository(ctx).ListAsync();
|
||||||
|
return rows.Select(e => new PrimeScheduleDto(
|
||||||
|
e.Id, (int)e.Days, e.TimeOfDay, e.Enabled, e.LastRunAt, e.PromptOverride)).ToList();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Update `UpsertPrimeSchedule`**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public async Task<PrimeScheduleDto> UpsertPrimeSchedule(PrimeScheduleDto dto)
|
||||||
|
{
|
||||||
|
using var ctx = _dbFactory.CreateDbContext();
|
||||||
|
var repo = new PrimeScheduleRepository(ctx);
|
||||||
|
var existing = await repo.GetAsync(dto.Id);
|
||||||
|
var entity = new ClaudeDo.Data.Models.PrimeScheduleEntity
|
||||||
|
{
|
||||||
|
Id = dto.Id == Guid.Empty ? Guid.NewGuid() : dto.Id,
|
||||||
|
Days = (ClaudeDo.Data.Models.PrimeDays)dto.Days,
|
||||||
|
TimeOfDay = dto.TimeOfDay,
|
||||||
|
Enabled = dto.Enabled,
|
||||||
|
PromptOverride = dto.PromptOverride,
|
||||||
|
CreatedAt = existing?.CreatedAt ?? DateTimeOffset.UtcNow,
|
||||||
|
LastRunAt = existing?.LastRunAt,
|
||||||
|
};
|
||||||
|
await repo.UpsertAsync(entity);
|
||||||
|
_primeSignal.Signal();
|
||||||
|
return new PrimeScheduleDto(entity.Id, (int)entity.Days, entity.TimeOfDay,
|
||||||
|
entity.Enabled, entity.LastRunAt, entity.PromptOverride);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
`DeletePrimeSchedule` is unchanged.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Update repository tests**
|
||||||
|
|
||||||
|
In `tests/ClaudeDo.Worker.Tests/Repositories/PrimeScheduleRepositoryTests.cs`, replace each entity initializer's `StartDate`/`EndDate`/`WorkdaysOnly` lines with `Days = PrimeDays.Weekdays,` (drop them where only `StartDate`/`EndDate` appear). The three initializers become:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
// Upsert_Then_List_RoundTrips
|
||||||
|
await new PrimeScheduleRepository(ctx).UpsertAsync(new PrimeScheduleEntity
|
||||||
|
{
|
||||||
|
Id = id,
|
||||||
|
Days = PrimeDays.Weekdays,
|
||||||
|
TimeOfDay = new TimeSpan(7, 0, 0),
|
||||||
|
Enabled = true,
|
||||||
|
CreatedAt = DateTimeOffset.UtcNow,
|
||||||
|
});
|
||||||
|
```
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
// UpdateLastRunAt_Persists
|
||||||
|
await new PrimeScheduleRepository(ctx).UpsertAsync(new PrimeScheduleEntity
|
||||||
|
{
|
||||||
|
Id = id,
|
||||||
|
Days = PrimeDays.Weekdays,
|
||||||
|
TimeOfDay = new TimeSpan(7, 0, 0),
|
||||||
|
Enabled = true,
|
||||||
|
CreatedAt = DateTimeOffset.UtcNow,
|
||||||
|
});
|
||||||
|
```
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
// Delete_Removes_Row
|
||||||
|
await new PrimeScheduleRepository(ctx).UpsertAsync(new PrimeScheduleEntity
|
||||||
|
{
|
||||||
|
Id = id,
|
||||||
|
Days = PrimeDays.All,
|
||||||
|
TimeOfDay = TimeSpan.Zero,
|
||||||
|
Enabled = true,
|
||||||
|
CreatedAt = DateTimeOffset.UtcNow,
|
||||||
|
});
|
||||||
|
```
|
||||||
|
|
||||||
|
Add an assertion in `Upsert_Then_List_RoundTrips` after the existing time assertion:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Assert.Equal(PrimeDays.Weekdays, rows[0].Days);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build worker + run all worker tests**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj && dotnet test tests/ClaudeDo.Worker.Tests`
|
||||||
|
Expected: PASS (all Prime + repository tests green).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Hub/WorkerHub.cs tests/ClaudeDo.Worker.Tests/Repositories/PrimeScheduleRepositoryTests.cs
|
||||||
|
git commit -m "feat(worker): map prime schedule weekday bitmask over the hub"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 7: UI DTO + ViewModels + tests (TDD)
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/PrimeScheduleDto.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Modals/Settings/PrimeScheduleRowViewModel.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Modals/Settings/PrimeClaudeTabViewModel.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Ui.Tests/ViewModels/PrimeClaudeTabViewModelTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Update the UI DTO**
|
||||||
|
|
||||||
|
`src/ClaudeDo.Ui/Services/PrimeScheduleDto.cs` (keep `PrimeFiredEvent` unchanged):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Ui.Services;
|
||||||
|
|
||||||
|
public sealed record PrimeScheduleDto(
|
||||||
|
Guid Id,
|
||||||
|
int Days,
|
||||||
|
TimeSpan TimeOfDay,
|
||||||
|
bool Enabled,
|
||||||
|
DateTimeOffset? LastRunAt,
|
||||||
|
string? PromptOverride);
|
||||||
|
|
||||||
|
public sealed record PrimeFiredEvent(
|
||||||
|
Guid ScheduleId,
|
||||||
|
bool Success,
|
||||||
|
string Message,
|
||||||
|
DateTimeOffset FiredAt);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Rewrite the row VM**
|
||||||
|
|
||||||
|
Replace the body of `src/ClaudeDo.Ui/ViewModels/Modals/Settings/PrimeScheduleRowViewModel.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Ui.Services;
|
||||||
|
using CommunityToolkit.Mvvm.ComponentModel;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.ViewModels.Modals.Settings;
|
||||||
|
|
||||||
|
public sealed partial class PrimeScheduleRowViewModel : ViewModelBase
|
||||||
|
{
|
||||||
|
private const int Mon = 1, Tue = 2, Wed = 4, Thu = 8, Fri = 16, Sat = 32, Sun = 64;
|
||||||
|
|
||||||
|
public Guid Id { get; }
|
||||||
|
public bool IsExisting { get; }
|
||||||
|
|
||||||
|
[ObservableProperty] private bool _enabled;
|
||||||
|
[ObservableProperty] private bool _monday;
|
||||||
|
[ObservableProperty] private bool _tuesday;
|
||||||
|
[ObservableProperty] private bool _wednesday;
|
||||||
|
[ObservableProperty] private bool _thursday;
|
||||||
|
[ObservableProperty] private bool _friday;
|
||||||
|
[ObservableProperty] private bool _saturday;
|
||||||
|
[ObservableProperty] private bool _sunday;
|
||||||
|
[ObservableProperty] private TimeSpan _timeOfDay;
|
||||||
|
[ObservableProperty] private DateTimeOffset? _lastRunAt;
|
||||||
|
|
||||||
|
public string LastRunLabel => LastRunAt is { } v ? v.LocalDateTime.ToString("g") : "—";
|
||||||
|
|
||||||
|
partial void OnLastRunAtChanged(DateTimeOffset? value) => OnPropertyChanged(nameof(LastRunLabel));
|
||||||
|
|
||||||
|
public PrimeScheduleRowViewModel(PrimeScheduleDto dto, bool isExisting)
|
||||||
|
{
|
||||||
|
Id = dto.Id;
|
||||||
|
IsExisting = isExisting;
|
||||||
|
Enabled = dto.Enabled;
|
||||||
|
Monday = (dto.Days & Mon) != 0;
|
||||||
|
Tuesday = (dto.Days & Tue) != 0;
|
||||||
|
Wednesday = (dto.Days & Wed) != 0;
|
||||||
|
Thursday = (dto.Days & Thu) != 0;
|
||||||
|
Friday = (dto.Days & Fri) != 0;
|
||||||
|
Saturday = (dto.Days & Sat) != 0;
|
||||||
|
Sunday = (dto.Days & Sun) != 0;
|
||||||
|
TimeOfDay = dto.TimeOfDay;
|
||||||
|
LastRunAt = dto.LastRunAt;
|
||||||
|
}
|
||||||
|
|
||||||
|
public int DaysMask()
|
||||||
|
{
|
||||||
|
int m = 0;
|
||||||
|
if (Monday) m |= Mon;
|
||||||
|
if (Tuesday) m |= Tue;
|
||||||
|
if (Wednesday) m |= Wed;
|
||||||
|
if (Thursday) m |= Thu;
|
||||||
|
if (Friday) m |= Fri;
|
||||||
|
if (Saturday) m |= Sat;
|
||||||
|
if (Sunday) m |= Sun;
|
||||||
|
return m;
|
||||||
|
}
|
||||||
|
|
||||||
|
public PrimeScheduleDto ToDto() =>
|
||||||
|
new(Id, DaysMask(), TimeOfDay, Enabled, LastRunAt, null);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Update the tab VM**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/ViewModels/Modals/Settings/PrimeClaudeTabViewModel.cs`, replace `Validate` and `AddSchedule`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public string? Validate()
|
||||||
|
{
|
||||||
|
foreach (var r in Rows)
|
||||||
|
{
|
||||||
|
if (r.DaysMask() == 0)
|
||||||
|
return $"Schedule {r.TimeOfDay:hh\\:mm}: select at least one day.";
|
||||||
|
if (r.TimeOfDay < TimeSpan.Zero || r.TimeOfDay >= TimeSpan.FromDays(1))
|
||||||
|
return "Time must be between 00:00 and 23:59.";
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[RelayCommand]
|
||||||
|
private void AddSchedule()
|
||||||
|
{
|
||||||
|
var dto = new PrimeScheduleDto(
|
||||||
|
Id: Guid.NewGuid(),
|
||||||
|
Days: 31, // Mon–Fri
|
||||||
|
TimeOfDay: new TimeSpan(7, 0, 0),
|
||||||
|
Enabled: true,
|
||||||
|
LastRunAt: null,
|
||||||
|
PromptOverride: null);
|
||||||
|
Rows.Add(new PrimeScheduleRowViewModel(dto, isExisting: false));
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
`LoadAsync`, `SaveAsync`, `RemoveSchedule`, `ApplyFiredEvent` are unchanged.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Rewrite the tab VM tests**
|
||||||
|
|
||||||
|
Replace the body of `tests/ClaudeDo.Ui.Tests/ViewModels/PrimeClaudeTabViewModelTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Ui.Services;
|
||||||
|
using ClaudeDo.Ui.ViewModels.Modals.Settings;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Tests.ViewModels;
|
||||||
|
|
||||||
|
public class PrimeClaudeTabViewModelTests
|
||||||
|
{
|
||||||
|
private sealed class FakeApi : IPrimeScheduleApi
|
||||||
|
{
|
||||||
|
public List<PrimeScheduleDto> Stored { get; } = new();
|
||||||
|
public List<PrimeScheduleDto> Upserts { get; } = new();
|
||||||
|
public List<Guid> Deletes { get; } = new();
|
||||||
|
public Task<List<PrimeScheduleDto>> ListAsync() => Task.FromResult(Stored.ToList());
|
||||||
|
public Task<PrimeScheduleDto?> UpsertAsync(PrimeScheduleDto dto)
|
||||||
|
{
|
||||||
|
Upserts.Add(dto);
|
||||||
|
return Task.FromResult<PrimeScheduleDto?>(dto);
|
||||||
|
}
|
||||||
|
public Task DeleteAsync(Guid id) { Deletes.Add(id); return Task.CompletedTask; }
|
||||||
|
}
|
||||||
|
|
||||||
|
private static PrimeScheduleDto Dto(Guid id, int days, TimeSpan time) =>
|
||||||
|
new(id, days, time, true, null, null);
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Load_Populates_Rows()
|
||||||
|
{
|
||||||
|
var api = new FakeApi();
|
||||||
|
api.Stored.Add(Dto(Guid.NewGuid(), 31, new TimeSpan(7, 0, 0)));
|
||||||
|
var vm = new PrimeClaudeTabViewModel(api);
|
||||||
|
await vm.LoadAsync();
|
||||||
|
Assert.Single(vm.Rows);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void AddSchedule_Appends_Row_With_Defaults()
|
||||||
|
{
|
||||||
|
var vm = new PrimeClaudeTabViewModel(new FakeApi());
|
||||||
|
vm.AddScheduleCommand.Execute(null);
|
||||||
|
Assert.Single(vm.Rows);
|
||||||
|
Assert.True(vm.Rows[0].Enabled);
|
||||||
|
Assert.True(vm.Rows[0].Monday);
|
||||||
|
Assert.True(vm.Rows[0].Friday);
|
||||||
|
Assert.False(vm.Rows[0].Saturday);
|
||||||
|
Assert.Equal(new TimeSpan(7, 0, 0), vm.Rows[0].TimeOfDay);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Row_Decomposes_And_Recomposes_Days()
|
||||||
|
{
|
||||||
|
var vm = new PrimeClaudeTabViewModel(new FakeApi());
|
||||||
|
vm.AddScheduleCommand.Execute(null);
|
||||||
|
var row = vm.Rows[0];
|
||||||
|
Assert.Equal(31, row.DaysMask());
|
||||||
|
row.Saturday = true;
|
||||||
|
Assert.Equal(63, row.DaysMask());
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Save_Diffs_New_And_Removed_Rows()
|
||||||
|
{
|
||||||
|
var api = new FakeApi();
|
||||||
|
var keptId = Guid.NewGuid();
|
||||||
|
var deletedId = Guid.NewGuid();
|
||||||
|
api.Stored.Add(Dto(keptId, 31, new TimeSpan(7, 0, 0)));
|
||||||
|
api.Stored.Add(Dto(deletedId, 31, new TimeSpan(8, 0, 0)));
|
||||||
|
|
||||||
|
var vm = new PrimeClaudeTabViewModel(api);
|
||||||
|
await vm.LoadAsync();
|
||||||
|
vm.RemoveScheduleCommand.Execute(vm.Rows.Single(r => r.Id == deletedId));
|
||||||
|
vm.AddScheduleCommand.Execute(null);
|
||||||
|
|
||||||
|
await vm.SaveAsync();
|
||||||
|
|
||||||
|
Assert.Contains(deletedId, api.Deletes);
|
||||||
|
Assert.Equal(2, api.Upserts.Count);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Validate_Reports_No_Days_Selected()
|
||||||
|
{
|
||||||
|
var vm = new PrimeClaudeTabViewModel(new FakeApi());
|
||||||
|
vm.AddScheduleCommand.Execute(null);
|
||||||
|
var row = vm.Rows[0];
|
||||||
|
row.Monday = row.Tuesday = row.Wednesday = row.Thursday = row.Friday = false;
|
||||||
|
Assert.NotNull(vm.Validate());
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Validate_Passes_With_One_Day()
|
||||||
|
{
|
||||||
|
var vm = new PrimeClaudeTabViewModel(new FakeApi());
|
||||||
|
vm.AddScheduleCommand.Execute(null);
|
||||||
|
Assert.Null(vm.Validate());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Run UI tests**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Ui.Tests --filter FullyQualifiedName~PrimeClaudeTabViewModelTests`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Services/PrimeScheduleDto.cs src/ClaudeDo.Ui/ViewModels/Modals/Settings/PrimeScheduleRowViewModel.cs src/ClaudeDo.Ui/ViewModels/Modals/Settings/PrimeClaudeTabViewModel.cs tests/ClaudeDo.Ui.Tests/ViewModels/PrimeClaudeTabViewModelTests.cs
|
||||||
|
git commit -m "feat(ui): drive prime schedule rows from weekday toggles"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 8: XAML — toggle-button row
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Design/IslandStyles.axaml`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Modals/SettingsModalView.axaml`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add a `day-toggle` style class**
|
||||||
|
|
||||||
|
Append to `src/ClaudeDo.Ui/Design/IslandStyles.axaml` (inside the root `<Styles>` element, alongside the other style selectors). Uses existing dynamic-resource tokens — no hardcoded colors:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Style Selector="ToggleButton.day-toggle">
|
||||||
|
<Setter Property="MinWidth" Value="34"/>
|
||||||
|
<Setter Property="Padding" Value="6,4"/>
|
||||||
|
<Setter Property="Margin" Value="0"/>
|
||||||
|
<Setter Property="HorizontalContentAlignment" Value="Center"/>
|
||||||
|
<Setter Property="Background" Value="{DynamicResource DeepBrush}"/>
|
||||||
|
<Setter Property="Foreground" Value="{DynamicResource TextBrush}"/>
|
||||||
|
<Setter Property="BorderBrush" Value="{DynamicResource LineBrush}"/>
|
||||||
|
<Setter Property="BorderThickness" Value="1"/>
|
||||||
|
<Setter Property="CornerRadius" Value="4"/>
|
||||||
|
</Style>
|
||||||
|
<Style Selector="ToggleButton.day-toggle:checked /template/ ContentPresenter">
|
||||||
|
<Setter Property="Background" Value="{DynamicResource AccentBrush}"/>
|
||||||
|
</Style>
|
||||||
|
```
|
||||||
|
|
||||||
|
If `AccentBrush` is not a defined token, use the brush the project uses for primary/selected affordances (check the `primary` button style in this file and reuse that brush). Final visual pass is the user's.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Replace the Prime row template**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Views/Modals/SettingsModalView.axaml`, replace the `<Grid ...>` inside the Prime `DataTemplate` (currently columns `Auto,*,Auto,Auto,Auto,Auto` with the `ThemedDatePicker` and Mon–Fri checkbox) with:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Grid ColumnDefinitions="Auto,*,Auto,Auto,Auto" ColumnSpacing="8">
|
||||||
|
<CheckBox Grid.Column="0" IsChecked="{Binding Enabled, Mode=TwoWay}" VerticalAlignment="Center"/>
|
||||||
|
<StackPanel Grid.Column="1" Orientation="Horizontal" Spacing="4" VerticalAlignment="Center">
|
||||||
|
<ToggleButton Classes="day-toggle" Content="Mo" IsChecked="{Binding Monday, Mode=TwoWay}"/>
|
||||||
|
<ToggleButton Classes="day-toggle" Content="Tu" IsChecked="{Binding Tuesday, Mode=TwoWay}"/>
|
||||||
|
<ToggleButton Classes="day-toggle" Content="We" IsChecked="{Binding Wednesday, Mode=TwoWay}"/>
|
||||||
|
<ToggleButton Classes="day-toggle" Content="Th" IsChecked="{Binding Thursday, Mode=TwoWay}"/>
|
||||||
|
<ToggleButton Classes="day-toggle" Content="Fr" IsChecked="{Binding Friday, Mode=TwoWay}"/>
|
||||||
|
<ToggleButton Classes="day-toggle" Content="Sa" IsChecked="{Binding Saturday, Mode=TwoWay}"/>
|
||||||
|
<ToggleButton Classes="day-toggle" Content="Su" IsChecked="{Binding Sunday, Mode=TwoWay}"/>
|
||||||
|
</StackPanel>
|
||||||
|
<TextBox Grid.Column="2" Width="64"
|
||||||
|
Text="{Binding TimeOfDay, Mode=TwoWay, Converter={StaticResource TimeSpanToHhmm}}"
|
||||||
|
VerticalAlignment="Center"/>
|
||||||
|
<TextBlock Classes="meta" Grid.Column="3" Text="{Binding LastRunLabel}" VerticalAlignment="Center"
|
||||||
|
MinWidth="80"/>
|
||||||
|
<Button Classes="icon-btn" Grid.Column="4" Content="✕"
|
||||||
|
Command="{Binding $parent[ItemsControl].((vm:SettingsModalViewModel)DataContext).Prime.RemoveScheduleCommand}"
|
||||||
|
CommandParameter="{Binding}"/>
|
||||||
|
</Grid>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Update the explainer text**
|
||||||
|
|
||||||
|
Replace the intro `TextBlock` Text in the Prime tab (`SettingsModalView.axaml`):
|
||||||
|
|
||||||
|
```xml
|
||||||
|
Text="Prime your Claude usage window by firing a single non-interactive ping on the days you choose, at a chosen time. Only runs while ClaudeDo is open. If the app starts within 30 minutes of the target time, the ping fires immediately."/>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Remove the now-unused range converter (only if unreferenced)**
|
||||||
|
|
||||||
|
The `DateOnlyToDateTime` resource on line 23 was used only by the range picker. Grep the file: if `DateOnlyToDateTime` has no other reference, remove the `<conv:DateOnlyToDateTimeConverter x:Key="DateOnlyToDateTime"/>` line. Keep `TimeSpanToHhmm` (still used).
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Manual UI check**
|
||||||
|
|
||||||
|
Start the worker, then the app. Open Settings → Prime Claude. Verify: a row shows 7 toggle buttons with Mon–Fri lit by default; toggling Sat/Sun persists after Save+reopen; clearing all days shows the validation error on Save. (UI correctness can only be confirmed in the running app — state so explicitly if it cannot be run.)
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Design/IslandStyles.axaml src/ClaudeDo.Ui/Views/Modals/SettingsModalView.axaml
|
||||||
|
git commit -m "feat(ui): replace prime date range with weekday toggle buttons"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 9: Docs
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Data/CLAUDE.md`
|
||||||
|
- Modify: `CLAUDE.md`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Update the Data CLAUDE.md**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Data/CLAUDE.md`, the Models section has no PrimeSchedule line today; add one under Models, and confirm the `prime_schedules` table mention in the Schema section stays accurate:
|
||||||
|
|
||||||
|
```markdown
|
||||||
|
- **PrimeScheduleEntity** — Id, Days (`[Flags] PrimeDays` weekday bitmask, stored as `days_of_week` int), TimeOfDay, Enabled, LastRunAt, PromptOverride, CreatedAt. Recurs on the selected weekdays; no date range.
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Update the root CLAUDE.md if Prime is described**
|
||||||
|
|
||||||
|
Grep `CLAUDE.md` for "Prime"; if there is a Prime description mentioning a date range, update it to "recurring weekday schedule". If there is no such line, make no change.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Full test sweep**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests && dotnet test tests/ClaudeDo.Ui.Tests`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Data/CLAUDE.md CLAUDE.md
|
||||||
|
git commit -m "docs: describe recurring-weekday Prime schedule"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Self-Review Notes
|
||||||
|
|
||||||
|
- **Spec coverage:** data model (T1), scheduling logic (T4), UI toggles (T7–T8), migration+backfill (T3), both DTOs (T4/T7), tests (T4–T7), out-of-scope items excluded. ✓
|
||||||
|
- **Type consistency:** entity `PrimeDays Days`; both DTOs `int Days`; hub/scheduler cast `(int)`/`(PrimeDays)` at boundaries; calculator casts `(PrimeDays)s.Days`; row VM exposes 7 bools + `DaysMask()`. ✓
|
||||||
|
- **Build ripple:** a single type change breaks several projects at once, so some intermediate steps note expected build failures; the gating green builds are T3 Step 4 (Data), T6 Step 4 (Worker + tests), T8 Step 4 (App). ✓
|
||||||
|
```
|
||||||
517
docs/superpowers/plans/2026-06-03-daily-prep-live-view.md
Normal file
517
docs/superpowers/plans/2026-06-03-daily-prep-live-view.md
Normal file
@@ -0,0 +1,517 @@
|
|||||||
|
# Daily Prep — Live Output View + Clear Day — Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Stream the daily-prep run's output into a live, human-readable view (a new mode in the Details island), and add a "Clear Day" button that empties MyDay.
|
||||||
|
|
||||||
|
**Architecture:** The worker broadcasts `PrepStarted/PrepLine/PrepFinished` over SignalR (mirroring `TaskStarted/TaskMessage/TaskFinished`). `PrimeRunner` forwards each Claude stdout line instead of discarding it. The UI `WorkerClient` re-raises these as events; `DetailsIslandViewModel` gains a `PrepLog` + `IsPrepMode` panel rendered with the existing terminal renderer. A `ClearMyDay` hub method bulk-clears `IsMyDay`. MyDay header gets "Vorbereitungs-Log" and "Tag leeren" buttons.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, ASP.NET Core SignalR, EF Core (SQLite), Avalonia + CommunityToolkit.Mvvm, xUnit.
|
||||||
|
|
||||||
|
**Spec:** `docs/superpowers/specs/2026-06-03-daily-prep-live-view-design.md`
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Build & test commands
|
||||||
|
|
||||||
|
`.slnx` needs .NET 9; build/test individual csproj with `-c Release` (a running Worker may lock Debug).
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
UI cannot be GUI-smoke-tested headlessly — note that explicitly where it applies; the human verifies visuals.
|
||||||
|
|
||||||
|
## Reference anchors (verify before editing — line numbers drift)
|
||||||
|
|
||||||
|
- `src/ClaudeDo.Worker/Prime/Interfaces/IPrimeBroadcaster.cs` — currently only `PrimeFiredAsync`.
|
||||||
|
- `src/ClaudeDo.Worker/Hub/HubBroadcaster.cs:13-57` — broadcast methods; `PrimeFired` at ~52-56.
|
||||||
|
- `src/ClaudeDo.Worker/Prime/PrimeRunner.cs:31-79` — `FireAsync`; discard lambda at ~55-60; ctor at ~19-29.
|
||||||
|
- `src/ClaudeDo.Worker/Hub/WorkerHub.cs:542-549` — `RunDailyPrepNow` (uses `_broadcaster`); DailyNote CRUD at 559-583 (shows the db-context pattern this hub uses).
|
||||||
|
- `src/ClaudeDo.Ui/Services/Interfaces/IWorkerClient.cs:19` — `TaskMessageEvent`; `:55` — `RunDailyPrepNowAsync`.
|
||||||
|
- `src/ClaudeDo.Ui/Services/WorkerClient.cs:99-122` — `TaskStarted/Finished/Message` hub.On; `:170-173` — `PrimeFired` hub.On (the pattern to copy).
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Islands/DetailsIslandViewModel.cs` — `IsNotesMode` ~56, `Log` ~193, ctor/subscriptions ~272-337, `OnTaskMessage` ~339-363 (stdout→`StreamLineFormatter`→`Log`), `ShowNotes` ~478-483.
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/DetailsIslandView.axaml:131-302` — body grid; task panel `IsVisible="{Binding !IsNotesMode}"`, notes panel `IsVisible="{Binding IsNotesMode}"`; `SessionTerminalView` embedded ~295.
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/SessionTerminalView.axaml:54-75` — `ItemsControl ItemsSource="{Binding Log}"` + the `LogLineViewModel` item template to reuse.
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs` — `NotesRequested` ~29, `OpenNotesCommand`+`PrepareDayCommand` ~33-45, `ShowNotesRow`/`IsMyDayList` ~65-66, both set in `LoadForList` ~212-213.
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/TasksIslandView.axaml:69-84` — Notes + PrepareDay buttons (styling to copy).
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs:199-201` — island event wiring; `:225` — `PrimeFired` subscription.
|
||||||
|
- Fakes to keep in sync: `tests/ClaudeDo.Ui.Tests/StubWorkerClient.cs`, `tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs` (`FakeWorkerClient`).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: Worker — prep output broadcast + streaming
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Prime/Interfaces/IPrimeBroadcaster.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Hub/HubBroadcaster.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Prime/PrimeRunner.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/Prime/PrimeRunnerTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test.** Extend `PrimeRunnerTests` with a fake `IPrimeBroadcaster` that records calls. The fake `IClaudeProcess` should invoke `onStdoutLine` with two sample lines and return `RunResult { ExitCode = 0, ResultMarkdown = "ok" }`.
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task FireAsync_streams_started_lines_and_finished()
|
||||||
|
{
|
||||||
|
var broadcaster = new RecordingPrimeBroadcaster();
|
||||||
|
var claude = new FakeClaudeProcess(emitLines: new[] { "{\"a\":1}", "{\"b\":2}" }, exitCode: 0, result: "ok");
|
||||||
|
var runner = NewRunner(claude, broadcaster); // build with temp-sqlite dbFactory + fake clock + logger + broadcaster
|
||||||
|
var schedule = new PrimeScheduleDto(Guid.Empty, 0, TimeSpan.Zero, true, null, null);
|
||||||
|
|
||||||
|
var outcome = await runner.FireAsync(schedule, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.True(outcome.Success);
|
||||||
|
Assert.Equal(1, broadcaster.StartedCount);
|
||||||
|
Assert.Equal(new[] { "{\"a\":1}", "{\"b\":2}" }, broadcaster.Lines);
|
||||||
|
Assert.Single(broadcaster.FinishedResults);
|
||||||
|
Assert.True(broadcaster.FinishedResults[0]);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
`RecordingPrimeBroadcaster` implements `IPrimeBroadcaster`: `StartedCount`, `List<string> Lines`, `List<bool> FinishedResults`, and a no-op `PrimeFiredAsync`. If the existing `FakeClaudeProcess` cannot emit lines, add an optional `emitLines` parameter that loops `await onStdoutLine(line)` before returning.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run — expect FAIL** (interface methods + ctor param missing).
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter PrimeRunner
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Extend `IPrimeBroadcaster`:**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public interface IPrimeBroadcaster
|
||||||
|
{
|
||||||
|
Task PrimeFiredAsync(Guid scheduleId, bool success, string message, DateTimeOffset firedAt);
|
||||||
|
Task PrepStartedAsync();
|
||||||
|
Task PrepLineAsync(string line);
|
||||||
|
Task PrepFinishedAsync(bool success);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
(Keep the existing `PrimeFiredAsync` signature exactly as it is in the current file.)
|
||||||
|
|
||||||
|
- [ ] **Step 4: Implement in `HubBroadcaster`** (add next to `PrimeFired`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public Task PrepStarted() => _hub.Clients.All.SendAsync("PrepStarted");
|
||||||
|
public Task PrepLine(string line) => _hub.Clients.All.SendAsync("PrepLine", line);
|
||||||
|
public Task PrepFinished(bool success) => _hub.Clients.All.SendAsync("PrepFinished", success);
|
||||||
|
|
||||||
|
Task IPrimeBroadcaster.PrepStartedAsync() => PrepStarted();
|
||||||
|
Task IPrimeBroadcaster.PrepLineAsync(string line) => PrepLine(line);
|
||||||
|
Task IPrimeBroadcaster.PrepFinishedAsync(bool success) => PrepFinished(success);
|
||||||
|
```
|
||||||
|
|
||||||
|
(Match the existing explicit-interface style used for `PrimeFiredAsync`.)
|
||||||
|
|
||||||
|
- [ ] **Step 5: Wire `PrimeRunner`.** Add `IPrimeBroadcaster _broadcaster` as a ctor param (and field). Rewrite the body of `FireAsync` after the gate check to:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
if (!await _gate.WaitAsync(0, ct))
|
||||||
|
return new PrimeRunOutcome(false, "Daily prep already running");
|
||||||
|
|
||||||
|
var success = false;
|
||||||
|
try
|
||||||
|
{
|
||||||
|
await _broadcaster.PrepStartedAsync();
|
||||||
|
|
||||||
|
var cwd = Paths.AppDataRoot();
|
||||||
|
Directory.CreateDirectory(cwd);
|
||||||
|
|
||||||
|
int maxTasks;
|
||||||
|
await using (var dbCtx = await _dbFactory.CreateDbContextAsync(ct))
|
||||||
|
{
|
||||||
|
var settings = await new AppSettingsRepository(dbCtx).GetAsync(ct);
|
||||||
|
maxTasks = settings.DailyPrepMaxTasks < 1 ? 1 : settings.DailyPrepMaxTasks;
|
||||||
|
}
|
||||||
|
|
||||||
|
var today = DateOnly.FromDateTime(_clock.Now.LocalDateTime);
|
||||||
|
var prompt = DailyPrepPrompt.BuildPrompt(maxTasks, today);
|
||||||
|
var args = DailyPrepPrompt.BuildArgs(MaxTurns);
|
||||||
|
|
||||||
|
using var timeoutCts = CancellationTokenSource.CreateLinkedTokenSource(ct);
|
||||||
|
timeoutCts.CancelAfter(FireTimeout);
|
||||||
|
|
||||||
|
var result = await _claude.RunAsync(
|
||||||
|
arguments: args,
|
||||||
|
prompt: prompt,
|
||||||
|
workingDirectory: cwd,
|
||||||
|
onStdoutLine: line => _broadcaster.PrepLineAsync(line),
|
||||||
|
ct: timeoutCts.Token);
|
||||||
|
|
||||||
|
success = result.IsSuccess;
|
||||||
|
return success
|
||||||
|
? new PrimeRunOutcome(true, "Daily prep complete")
|
||||||
|
: new PrimeRunOutcome(false, $"exit code {result.ExitCode}");
|
||||||
|
}
|
||||||
|
catch (OperationCanceledException) when (!ct.IsCancellationRequested)
|
||||||
|
{
|
||||||
|
return new PrimeRunOutcome(false, $"timed out after {FireTimeout.TotalMinutes:0} min");
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
_logger.LogWarning(ex, "Daily prep run failed");
|
||||||
|
return new PrimeRunOutcome(false, ex.Message);
|
||||||
|
}
|
||||||
|
finally
|
||||||
|
{
|
||||||
|
await _broadcaster.PrepFinishedAsync(success);
|
||||||
|
_gate.Release();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
DI is unchanged: `AddSingleton<IPrimeRunner, PrimeRunner>()` resolves `IPrimeBroadcaster` (registered as `sp => sp.GetRequiredService<HubBroadcaster>()`).
|
||||||
|
|
||||||
|
- [ ] **Step 6: Update existing `PrimeRunnerTests` ctor calls** to pass the recording broadcaster; build + run.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter PrimeRunner
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 7: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Prime src/ClaudeDo.Worker/Hub/HubBroadcaster.cs tests/ClaudeDo.Worker.Tests/Prime
|
||||||
|
git commit -m "feat(daily-prep): stream prep output via PrepStarted/PrepLine/PrepFinished"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: Worker — `ClearMyDay` hub method
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Hub/WorkerHub.cs`
|
||||||
|
- Test: a new/existing hub test under `tests/ClaudeDo.Worker.Tests/Hub/` (mirror an existing hub test that seeds a real SQLite db and constructs `WorkerHub`)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test.** Seed three tasks: two with `IsMyDay=true` (one Idle, one Done), one with `IsMyDay=false`. Construct `WorkerHub` the way existing hub tests do (the same `null!` argument list, plus a recording `HubBroadcaster`/clients). Call `ClearMyDay()`; assert both MyDay rows are now `false`, the third is untouched, and the returned count is 2.
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task ClearMyDay_clears_all_isMyDay_tasks()
|
||||||
|
{
|
||||||
|
// seed via the test's db helper ...
|
||||||
|
var hub = NewHub(/* ... */);
|
||||||
|
var cleared = await hub.ClearMyDay();
|
||||||
|
|
||||||
|
Assert.Equal(2, cleared);
|
||||||
|
await using var ctx = NewContext();
|
||||||
|
Assert.False(await ctx.Tasks.AnyAsync(t => t.IsMyDay));
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run — expect FAIL.**
|
||||||
|
|
||||||
|
- [ ] **Step 3: Add the method** to `WorkerHub` (use the same db-context acquisition the neighbouring hub methods use — e.g. `_dbFactory`/repository field name found in the file — and the existing `_broadcaster` field):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public async Task<int> ClearMyDay()
|
||||||
|
{
|
||||||
|
await using var ctx = await _dbFactory.CreateDbContextAsync();
|
||||||
|
var ids = await ctx.Tasks.Where(t => t.IsMyDay).Select(t => t.Id).ToListAsync();
|
||||||
|
if (ids.Count == 0) return 0;
|
||||||
|
|
||||||
|
await ctx.Tasks.Where(t => t.IsMyDay)
|
||||||
|
.ExecuteUpdateAsync(s => s.SetProperty(t => t.IsMyDay, false));
|
||||||
|
|
||||||
|
foreach (var id in ids)
|
||||||
|
await _broadcaster.TaskUpdated(id);
|
||||||
|
|
||||||
|
return ids.Count;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
If `WorkerHub` does not already have an `IDbContextFactory<ClaudeDoDbContext>` field, use whatever data-access dependency the other hub methods use (read the file). Do NOT add a new ctor param unless unavoidable (it would break hub-test fakes — if you must, update all `new WorkerHub(...)` call sites).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run — expect PASS.** Build Worker.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Hub/WorkerHub.cs tests/ClaudeDo.Worker.Tests/Hub
|
||||||
|
git commit -m "feat(daily-prep): add ClearMyDay hub method"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: UI — WorkerClient prep events + ClearMyDayAsync
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/Interfaces/IWorkerClient.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/WorkerClient.cs`
|
||||||
|
- Modify fakes: `tests/ClaudeDo.Ui.Tests/StubWorkerClient.cs`, `tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs` (FakeWorkerClient)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Declare on `IWorkerClient`** (near `TaskMessageEvent` / `RunDailyPrepNowAsync`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
event Action? PrepStartedEvent;
|
||||||
|
event Action<string>? PrepLineEvent;
|
||||||
|
event Action<bool>? PrepFinishedEvent;
|
||||||
|
Task ClearMyDayAsync();
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Implement in `WorkerClient`.** Add the events; register hub callbacks mirroring the `PrimeFired` registration (~line 170):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public event Action? PrepStartedEvent;
|
||||||
|
public event Action<string>? PrepLineEvent;
|
||||||
|
public event Action<bool>? PrepFinishedEvent;
|
||||||
|
|
||||||
|
// in the hub-wiring section:
|
||||||
|
_hub.On("PrepStarted", () => Dispatcher.UIThread.Post(() => PrepStartedEvent?.Invoke()));
|
||||||
|
_hub.On<string>("PrepLine", line => Dispatcher.UIThread.Post(() => PrepLineEvent?.Invoke(line)));
|
||||||
|
_hub.On<bool>("PrepFinished", ok => Dispatcher.UIThread.Post(() => PrepFinishedEvent?.Invoke(ok)));
|
||||||
|
|
||||||
|
public Task ClearMyDayAsync() => _connection.InvokeAsync("ClearMyDay");
|
||||||
|
```
|
||||||
|
|
||||||
|
(Use the exact connection field name and async-call style of neighbouring methods like `RunDailyPrepNowAsync` / `GenerateWeekReport`. `ClearMyDay` returns `int` on the hub; invoking it as a void `InvokeAsync("ClearMyDay")` is fine, or `InvokeAsync<int>` if you want the count.)
|
||||||
|
|
||||||
|
- [ ] **Step 3: Update the fakes.** Add the three events (as `public event …` auto-implemented) and `ClearMyDayAsync() => Task.CompletedTask` to both `StubWorkerClient` and `FakeWorkerClient`. For the ClearDay command test (Task 5), give `StubWorkerClient` a `ClearMyDayCalls` counter incremented in `ClearMyDayAsync`.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build App + both test projects; fix any remaining fake gaps.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Services tests
|
||||||
|
git commit -m "feat(daily-prep): expose prep stream events and ClearMyDay on the UI worker client"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: UI — Details island prep mode + live log
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/DetailsIslandViewModel.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/DetailsIslandView.axaml`
|
||||||
|
- Test: `tests/ClaudeDo.Ui.Tests/...DetailsIslandViewModel...` (mirror existing Details VM tests; if none, add a small test file)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test.** Construct `DetailsIslandViewModel` with a `StubWorkerClient` (mirror existing construction). Then:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public void PrepLine_event_appends_to_PrepLog()
|
||||||
|
{
|
||||||
|
var stub = new StubWorkerClient();
|
||||||
|
var vm = NewDetailsVm(stub);
|
||||||
|
|
||||||
|
stub.RaisePrepLine("{\"type\":\"assistant\",\"text\":\"hi\"}"); // helper that invokes PrepLineEvent
|
||||||
|
Assert.NotEmpty(vm.PrepLog);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void ShowPrep_sets_prep_mode_and_clears_notes_mode()
|
||||||
|
{
|
||||||
|
var vm = NewDetailsVm(new StubWorkerClient());
|
||||||
|
vm.ShowPrep();
|
||||||
|
Assert.True(vm.IsPrepMode);
|
||||||
|
Assert.False(vm.IsNotesMode);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `RaisePrepStarted/RaisePrepLine/RaisePrepFinished` helpers to `StubWorkerClient` that invoke the corresponding events.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run — expect FAIL.**
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement in `DetailsIslandViewModel`:**
|
||||||
|
- Add `[ObservableProperty] private bool _isPrepMode;` and `[ObservableProperty] private bool _isPrepRunning;`.
|
||||||
|
- Add `public ObservableCollection<LogLineViewModel> PrepLog { get; } = new();`.
|
||||||
|
- In the ctor, subscribe: `_worker.PrepStartedEvent += OnPrepStarted; _worker.PrepLineEvent += OnPrepLine; _worker.PrepFinishedEvent += OnPrepFinished;` (guard with the same `_worker is not null` pattern used for other events).
|
||||||
|
- Handlers:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private void OnPrepStarted()
|
||||||
|
{
|
||||||
|
PrepLog.Clear();
|
||||||
|
IsPrepRunning = true;
|
||||||
|
}
|
||||||
|
|
||||||
|
private void OnPrepLine(string line) => AppendStdoutLine(PrepLog, line);
|
||||||
|
|
||||||
|
private void OnPrepFinished(bool success) => IsPrepRunning = false;
|
||||||
|
```
|
||||||
|
|
||||||
|
- Factor the stdout-formatting currently inside `OnTaskMessage` into a reusable
|
||||||
|
`private void AppendStdoutLine(ObservableCollection<LogLineViewModel> target, string line)`
|
||||||
|
that runs the line through `StreamLineFormatter` and appends `LogLineViewModel`(s).
|
||||||
|
Have `OnTaskMessage`'s stdout branch call `AppendStdoutLine(Log, strippedLine)` so both
|
||||||
|
paths share one implementation. (Events arrive already on the UI thread via
|
||||||
|
`Dispatcher.UIThread.Post` in `WorkerClient`, so direct collection mutation is correct.)
|
||||||
|
- Add `public void ShowPrep()` mirroring `ShowNotes()`: call `Bind(null)`, set
|
||||||
|
`IsNotesMode = false`, `IsPrepMode = true`.
|
||||||
|
- In `ShowNotes()` add `IsPrepMode = false`. In `Bind(...)` reset both `IsNotesMode` and
|
||||||
|
`IsPrepMode` to false (find where `IsNotesMode` is reset; add `IsPrepMode` beside it).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Update `DetailsIslandView.axaml`.**
|
||||||
|
- Change the task-details panel visibility from `IsVisible="{Binding !IsNotesMode}"` to a
|
||||||
|
converter-free multi-condition. Avalonia lacks `&&` in bindings, so add a computed
|
||||||
|
property `public bool IsTaskDetailVisible => !IsNotesMode && !IsPrepMode;` to the VM
|
||||||
|
(raise its change notification from the `OnIsNotesModeChanged`/`OnIsPrepModeChanged`
|
||||||
|
partial methods generated by `[ObservableProperty]`) and bind the task panel to
|
||||||
|
`IsVisible="{Binding IsTaskDetailVisible}"`.
|
||||||
|
- Add a third panel after the notes panel:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Panel IsVisible="{Binding IsPrepMode}">
|
||||||
|
<DockPanel>
|
||||||
|
<TextBlock DockPanel.Dock="Top" Margin="16,12"
|
||||||
|
Text="{loc:Tr details.prepTitle}" Classes="h2"/>
|
||||||
|
<ScrollViewer>
|
||||||
|
<ItemsControl ItemsSource="{Binding PrepLog}"/>
|
||||||
|
</ScrollViewer>
|
||||||
|
</DockPanel>
|
||||||
|
</Panel>
|
||||||
|
```
|
||||||
|
|
||||||
|
The `ItemsControl` reuses the implicit `LogLineViewModel` `DataTemplate` that
|
||||||
|
`SessionTerminalView` relies on. If that template is defined locally inside
|
||||||
|
`SessionTerminalView.axaml` (not in a shared resource), either move it to a shared
|
||||||
|
`ResourceDictionary` (e.g. App resources) and reference it from both, or set the
|
||||||
|
`ItemsControl.ItemTemplate` to a copy of that template. Prefer sharing over copying.
|
||||||
|
Add `details.prepTitle` ("Daily prep" / "Tagesvorbereitung") to both locale json files.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Run UI tests — expect PASS; build App.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui src/ClaudeDo.Localization tests/ClaudeDo.Ui.Tests
|
||||||
|
git commit -m "feat(daily-prep): add live prep-output mode to the Details island"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: UI — MyDay buttons + shell wiring
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/TasksIslandView.axaml`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Localization/locales/en.json`, `de.json`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/UiVm/...` or `tests/ClaudeDo.Ui.Tests/...` (TasksIslandViewModel)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests.**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task ClearDayCommand_calls_worker()
|
||||||
|
{
|
||||||
|
var stub = new StubWorkerClient();
|
||||||
|
var vm = NewTasksVm(stub);
|
||||||
|
await vm.ClearDayCommand.ExecuteAsync(null);
|
||||||
|
Assert.Equal(1, stub.ClearMyDayCalls);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task PrepareDayCommand_raises_PrepRequested()
|
||||||
|
{
|
||||||
|
var vm = NewTasksVm(new StubWorkerClient());
|
||||||
|
var raised = false;
|
||||||
|
vm.PrepRequested += () => raised = true;
|
||||||
|
await vm.PrepareDayCommand.ExecuteAsync(null);
|
||||||
|
Assert.True(raised);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run — expect FAIL.**
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement in `TasksIslandViewModel`:**
|
||||||
|
- Add `public event Action? PrepRequested;` next to `NotesRequested`.
|
||||||
|
- In `PrepareDayAsync` (the existing `[RelayCommand]`), raise `PrepRequested?.Invoke();`
|
||||||
|
in addition to the existing `RunDailyPrepNowAsync()` call.
|
||||||
|
- Add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[RelayCommand]
|
||||||
|
private void ShowPrepLog() => PrepRequested?.Invoke();
|
||||||
|
|
||||||
|
[RelayCommand]
|
||||||
|
private async Task ClearDayAsync()
|
||||||
|
{
|
||||||
|
if (_worker is null) return;
|
||||||
|
try { await _worker.ClearMyDayAsync(); }
|
||||||
|
catch { /* worker offline; broadcast will reconcile on return */ }
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Add the two buttons** to the MyDay header in `TasksIslandView.axaml`,
|
||||||
|
immediately after the existing "Prepare day" button (~line 84), copying its styling
|
||||||
|
(`DockPanel.Dock="Top" Classes="btn" HorizontalAlignment="Stretch"
|
||||||
|
HorizontalContentAlignment="Left" Margin="16,0,16,8" IsVisible="{Binding IsMyDayList}"`):
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Button DockPanel.Dock="Top" Classes="btn" HorizontalAlignment="Stretch"
|
||||||
|
HorizontalContentAlignment="Left" Margin="16,0,16,8"
|
||||||
|
IsVisible="{Binding IsMyDayList}"
|
||||||
|
Command="{Binding ShowPrepLogCommand}"
|
||||||
|
Content="{loc:Tr tasks.prepLog}"/>
|
||||||
|
<Button DockPanel.Dock="Top" Classes="btn" HorizontalAlignment="Stretch"
|
||||||
|
HorizontalContentAlignment="Left" Margin="16,0,16,8"
|
||||||
|
IsVisible="{Binding IsMyDayList}"
|
||||||
|
Command="{Binding ClearDayCommand}"
|
||||||
|
Content="{loc:Tr tasks.clearDay}"/>
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `tasks.prepLog` (en "Prep log" / de "Vorbereitungs-Log") and `tasks.clearDay`
|
||||||
|
(en "Clear day" / de "Tag leeren") to both locale json files.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Wire the shell.** In `IslandsShellViewModel` where `Tasks.NotesRequested`
|
||||||
|
is wired (~line 201), add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Tasks.PrepRequested += () => Details.ShowPrep();
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 6: Run tests + build App.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 7: Manual smoke (human, not headless):** start Worker + App, open MyDay, click
|
||||||
|
"Tag vorbereiten" → Details island opens in prep mode and streams readable lines; click
|
||||||
|
"Tag leeren" → MyDay empties; after a scheduled run, "Vorbereitungs-Log" opens the filled
|
||||||
|
log. Confirm the three buttons only appear on MyDay.
|
||||||
|
|
||||||
|
- [ ] **Step 8: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui src/ClaudeDo.Localization tests
|
||||||
|
git commit -m "feat(daily-prep): add Prep-log and Clear-day buttons to MyDay header"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Final verification
|
||||||
|
|
||||||
|
- [ ] Build Worker + App (Release).
|
||||||
|
- [ ] `dotnet test` Worker.Tests, Ui.Tests, Localization.Tests — all green.
|
||||||
|
- [ ] Manual: prep streams live into the Details island (manual opens it; scheduled fills it silently, opened via the button); Clear Day empties MyDay immediately.
|
||||||
|
|
||||||
|
## Notes / risks
|
||||||
|
|
||||||
|
- Mode flags `IsNotesMode` / `IsPrepMode` are mutually exclusive; the task-details panel
|
||||||
|
uses the computed `IsTaskDetailVisible`. Verify all three modes switch cleanly.
|
||||||
|
- Reusing the `LogLineViewModel` template: prefer promoting it to a shared resource over
|
||||||
|
copying, to avoid drift between the session terminal and the prep log.
|
||||||
|
- `ClearMyDay` broadcasts one `TaskUpdated` per affected id; MyDay is small (capped), so
|
||||||
|
this is fine.
|
||||||
|
- Keep `PrimeRunner`'s "already running" early-return emitting no prep events.
|
||||||
736
docs/superpowers/plans/2026-06-03-daily-prep.md
Normal file
736
docs/superpowers/plans/2026-06-03-daily-prep.md
Normal file
@@ -0,0 +1,736 @@
|
|||||||
|
# Daily Prep ("Prime Claude") Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Turn the Prime Time warm-up into a daily preparation where Claude reads open tasks and moves an effort-aware, capped subset into MyDay, triggered by the Prime schedule and a manual button.
|
||||||
|
|
||||||
|
**Architecture:** Agentic. Two new tools on the always-on `ExternalMcpService` (`get_daily_prep_candidates`, `set_my_day` with a server-side cap-guard). The existing `PrimeRunner` is rewritten to launch a headless `claude -p` run with a fixed parameterized prompt and `--allowedTools` for those two tools, relying on the already-registered `claudedo` MCP (no separate `--mcp-config`). A new `DailyPrepMaxTasks` app setting drives the cap. A manual hub method reuses the same runner with a single-flight guard.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, ASP.NET Core, EF Core (SQLite), SignalR, ModelContextProtocol, Avalonia (CommunityToolkit.Mvvm), xUnit.
|
||||||
|
|
||||||
|
**Spec:** `docs/superpowers/specs/2026-06-03-daily-prep-design.md`
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Deviation from spec (deliberate, to minimize churn)
|
||||||
|
|
||||||
|
The spec proposed renaming `IPrimeRunner`/`PrimeRunner`/`PrimeScheduler` → `DailyPrep*`. **We keep the existing names and the `FireAsync(PrimeScheduleDto, ct)` signature** and only rewrite the runner body. This avoids touching the scheduler, DI registration, `IPrimeBroadcaster`, and the existing Prime tests for a pure rename. The per-schedule `PromptOverride` field becomes unused by the runner (left in the DB/UI untouched).
|
||||||
|
|
||||||
|
## Build & test commands (this repo)
|
||||||
|
|
||||||
|
`.slnx` needs .NET 9; on .NET 8 build/test individual projects. Use `-c Release` if a running Worker locks `Debug`.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Data.Tests/ClaudeDo.Data.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
Tests use **real SQLite + real git** (project convention). Mirror the setup already present in the test file you are extending.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File Structure
|
||||||
|
|
||||||
|
**Create**
|
||||||
|
- `src/ClaudeDo.Data/Migrations/<timestamp>_DailyPrepMaxTasks.cs` (+ Designer, via `dotnet ef`)
|
||||||
|
- `src/ClaudeDo.Worker/Prime/DailyPrepPrompt.cs` — pure prompt + args builder (easy to unit-test)
|
||||||
|
|
||||||
|
**Modify**
|
||||||
|
- `src/ClaudeDo.Data/Models/AppSettingsEntity.cs` — add `DailyPrepMaxTasks`
|
||||||
|
- `src/ClaudeDo.Data/Configuration/AppSettingsEntityConfiguration.cs` — map column
|
||||||
|
- `src/ClaudeDo.Data/Repositories/AppSettingsRepository.cs` — persist field in `UpdateAsync`
|
||||||
|
- `src/ClaudeDo.Worker/External/ExternalMcpService.cs` — add 2 tools + DTOs
|
||||||
|
- `src/ClaudeDo.Worker/Prime/PrimeRunner.cs` — rewrite body to daily prep + single-flight
|
||||||
|
- `src/ClaudeDo.Worker/Hub/WorkerHub.cs` — add `DailyPrepMaxTasks` to AppSettings DTO + `RunDailyPrepNow`
|
||||||
|
- `src/ClaudeDo.Ui/Services/WorkerClient.cs` — mirror `DailyPrepMaxTasks` in the UI AppSettings DTO + add `RunDailyPrepNow` call
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Modals/Settings/PrimeClaudeTabViewModel.cs` (+ its view) — numeric editor for `DailyPrepMaxTasks`
|
||||||
|
- MyDay list header view + its ViewModel — "Tag vorbereiten" button + command
|
||||||
|
|
||||||
|
**Test**
|
||||||
|
- `tests/ClaudeDo.Data.Tests/...AppSettings...` — new field persists / default 5
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs` — candidate filter + set_my_day + cap-guard
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/Prime/DailyPrepPromptTests.cs` — prompt/args content
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/Prime/PrimeRunnerTests.cs` (if present) — single-flight + success/failure via `IClaudeProcess` fake
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: `DailyPrepMaxTasks` app setting
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Data/Models/AppSettingsEntity.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Data/Configuration/AppSettingsEntityConfiguration.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Data/Repositories/AppSettingsRepository.cs`
|
||||||
|
- Create (via `dotnet ef`): `src/ClaudeDo.Data/Migrations/<timestamp>_DailyPrepMaxTasks.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Data.Tests` (extend existing AppSettings repository test, or add `AppSettingsRepositoryTests.cs`)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test**
|
||||||
|
|
||||||
|
In a Data.Tests file (mirror the existing repo test harness that opens a real SQLite `ClaudeDoDbContext`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task DailyPrepMaxTasks_defaults_to_5_and_persists()
|
||||||
|
{
|
||||||
|
await using var ctx = NewContext(); // existing helper that migrates a temp sqlite db
|
||||||
|
var repo = new AppSettingsRepository(ctx);
|
||||||
|
|
||||||
|
var initial = await repo.GetAsync();
|
||||||
|
Assert.Equal(5, initial.DailyPrepMaxTasks);
|
||||||
|
|
||||||
|
initial.DailyPrepMaxTasks = 8;
|
||||||
|
await repo.UpdateAsync(initial);
|
||||||
|
|
||||||
|
var reloaded = await repo.GetAsync();
|
||||||
|
Assert.Equal(8, reloaded.DailyPrepMaxTasks);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run it — expect FAIL** (`AppSettingsEntity` has no `DailyPrepMaxTasks`).
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Data.Tests/ClaudeDo.Data.Tests.csproj -c Release --filter DailyPrepMaxTasks_defaults_to_5_and_persists
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Add the property** to `AppSettingsEntity.cs` after `StandupWeekday`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
// Max number of open tasks the daily prep ("Prime Claude") may place in MyDay.
|
||||||
|
public int DailyPrepMaxTasks { get; set; } = 5;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Map the column** in `AppSettingsEntityConfiguration.cs`, after the `StandupWeekday` mapping (before `builder.HasData(...)`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
builder.Property(s => s.DailyPrepMaxTasks)
|
||||||
|
.HasColumnName("daily_prep_max_tasks").IsRequired().HasDefaultValue(5);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Persist it** in `AppSettingsRepository.UpdateAsync`, after the `StandupWeekday` assignment:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
row.DailyPrepMaxTasks = updated.DailyPrepMaxTasks < 1 ? 1 : updated.DailyPrepMaxTasks;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 6: Generate the migration** (regenerates the model snapshot — do NOT hand-edit the snapshot):
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet ef migrations add DailyPrepMaxTasks \
|
||||||
|
-p src/ClaudeDo.Data/ClaudeDo.Data.csproj \
|
||||||
|
-s src/ClaudeDo.Worker/ClaudeDo.Worker.csproj
|
||||||
|
```
|
||||||
|
|
||||||
|
Verify the generated `Up` contains an `AddColumn<int>("daily_prep_max_tasks", ... defaultValue: 5)` and an `UpdateData` setting the singleton row's `daily_prep_max_tasks` to 5. If `dotnet ef` is unavailable, hand-write the migration mirroring `20260603072822_WeeklyReport.cs` **and** add the matching `Property<int>("DailyPrepMaxTasks").HasColumnName("daily_prep_max_tasks")` line to `ClaudeDoDbContextModelSnapshot.cs` under the `AppSettingsEntity` builder.
|
||||||
|
|
||||||
|
- [ ] **Step 7: Run the test — expect PASS.**
|
||||||
|
|
||||||
|
- [ ] **Step 8: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Data tests/ClaudeDo.Data.Tests
|
||||||
|
git commit -m "feat(daily-prep): add DailyPrepMaxTasks app setting"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: `get_daily_prep_candidates` MCP tool
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/External/ExternalMcpService.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs`
|
||||||
|
|
||||||
|
Read `ExternalMcpServiceTests.cs` first and reuse its existing harness (how it builds an `ExternalMcpService` with a real SQLite context, `ListRepository`, `TaskRepository`, fake `HubBroadcaster`, etc.). The new tool reads **all** lists/tasks itself via the injected `_dbFactory`, so it needs no new constructor args.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test.** Seed: a list with `WorkingDir = @"D:\work\repo"` holding two `Idle` tasks (one blocked, one not) and one `Done` task; a second list with `WorkingDir = @"C:\Private\secret"` holding one `Idle` task; a third list with `WorkingDir = null` holding one `Idle` task; and one `Idle` task with `IsMyDay = true` in the first list. Set `AppSettings.ReportExcludedPaths = "[\"C:\\\\Private\"]"`.
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task GetDailyPrepCandidates_filters_by_status_block_and_excluded_repo()
|
||||||
|
{
|
||||||
|
// ... seed as described, using the file's existing seed helpers ...
|
||||||
|
var svc = NewService();
|
||||||
|
|
||||||
|
var result = await svc.GetDailyPrepCandidates(CancellationToken.None);
|
||||||
|
|
||||||
|
// Only the non-blocked, Idle, non-MyDay task in the non-excluded repo is a candidate.
|
||||||
|
Assert.Single(result.Candidates);
|
||||||
|
Assert.Equal("idle-unblocked", result.Candidates[0].Id);
|
||||||
|
// The Idle MyDay task is reported separately, not as a candidate.
|
||||||
|
Assert.Single(result.CurrentMyDay);
|
||||||
|
Assert.Equal(1, result.MaxTasks > 0 ? 1 : 1); // MaxTasks comes from AppSettings (default 5)
|
||||||
|
Assert.Equal(5, result.MaxTasks);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run it — expect FAIL** (method missing).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Add the DTOs** near the other record declarations at the top of `ExternalMcpService.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public sealed record DailyPrepCandidateDto(
|
||||||
|
string Id, string ListId, string ListName, string Title, string? Description,
|
||||||
|
bool IsStarred, DateTime? ScheduledFor, DateTime CreatedAt);
|
||||||
|
|
||||||
|
public sealed record DailyPrepDataDto(
|
||||||
|
int MaxTasks,
|
||||||
|
IReadOnlyList<DailyPrepCandidateDto> Candidates,
|
||||||
|
IReadOnlyList<DailyPrepCandidateDto> CurrentMyDay);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Add the tool method** to the `ExternalMcpService` class body:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[McpServerTool, Description(
|
||||||
|
"Daily prep: returns the open tasks eligible for today's MyDay selection. " +
|
||||||
|
"candidates = Idle, not blocked, in a git repo not excluded from the weekly report, and not already in MyDay. " +
|
||||||
|
"currentMyDay = Idle tasks already flagged IsMyDay (count them toward the cap). " +
|
||||||
|
"maxTasks = the hard cap on total open MyDay tasks. Use set_my_day to add tasks (never exceed maxTasks).")]
|
||||||
|
public async Task<DailyPrepDataDto> GetDailyPrepCandidates(CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
await using var ctx = await _dbFactory.CreateDbContextAsync(cancellationToken);
|
||||||
|
|
||||||
|
var settings = await new AppSettingsRepository(ctx).GetAsync(cancellationToken);
|
||||||
|
var excludes = DailyPrepFilter.ParseExcludes(settings.ReportExcludedPaths);
|
||||||
|
var maxTasks = settings.DailyPrepMaxTasks < 1 ? 1 : settings.DailyPrepMaxTasks;
|
||||||
|
|
||||||
|
var idle = await ctx.Tasks
|
||||||
|
.AsNoTracking()
|
||||||
|
.Include(t => t.List)
|
||||||
|
.Where(t => t.Status == TaskStatus.Idle)
|
||||||
|
.ToListAsync(cancellationToken);
|
||||||
|
|
||||||
|
var currentMyDay = idle
|
||||||
|
.Where(t => t.IsMyDay)
|
||||||
|
.OrderBy(t => t.SortOrder)
|
||||||
|
.Select(ToCandidate)
|
||||||
|
.ToList();
|
||||||
|
|
||||||
|
var candidates = idle
|
||||||
|
.Where(t => !t.IsMyDay
|
||||||
|
&& t.BlockedByTaskId == null
|
||||||
|
&& DailyPrepFilter.IsIncludedRepo(t.List?.WorkingDir, excludes))
|
||||||
|
.OrderBy(t => t.CreatedAt)
|
||||||
|
.Select(ToCandidate)
|
||||||
|
.ToList();
|
||||||
|
|
||||||
|
return new DailyPrepDataDto(maxTasks, candidates, currentMyDay);
|
||||||
|
}
|
||||||
|
|
||||||
|
private static DailyPrepCandidateDto ToCandidate(TaskEntity t) => new(
|
||||||
|
t.Id, t.ListId, t.List?.Name ?? "", t.Title, t.Description,
|
||||||
|
t.IsStarred, t.ScheduledFor, t.CreatedAt);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Add the filter helper** as a small static class at the bottom of `ExternalMcpService.cs` (single-consumer helper lives beside its consumer, per repo convention):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
internal static class DailyPrepFilter
|
||||||
|
{
|
||||||
|
public static string[] ParseExcludes(string? json)
|
||||||
|
{
|
||||||
|
if (string.IsNullOrWhiteSpace(json)) return [];
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var list = System.Text.Json.JsonSerializer.Deserialize<List<string>>(json);
|
||||||
|
return list is null ? [] : list.Select(Normalize).Where(p => p.Length > 0).ToArray();
|
||||||
|
}
|
||||||
|
catch (System.Text.Json.JsonException) { return []; }
|
||||||
|
}
|
||||||
|
|
||||||
|
public static bool IsIncludedRepo(string? workingDir, string[] excludes)
|
||||||
|
{
|
||||||
|
if (string.IsNullOrWhiteSpace(workingDir)) return false; // not a repo → excluded
|
||||||
|
var norm = Normalize(workingDir);
|
||||||
|
return !excludes.Any(p => norm.StartsWith(p, StringComparison.OrdinalIgnoreCase));
|
||||||
|
}
|
||||||
|
|
||||||
|
private static string Normalize(string path) =>
|
||||||
|
path.Trim().Replace('/', '\\').TrimEnd('\\');
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `using ClaudeDo.Data.Repositories;` if not already present (it is, via existing usings).
|
||||||
|
|
||||||
|
- [ ] **Step 6: Run the test — expect PASS.**
|
||||||
|
|
||||||
|
- [ ] **Step 7: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/ExternalMcpService.cs tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs
|
||||||
|
git commit -m "feat(daily-prep): add get_daily_prep_candidates MCP tool"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: `set_my_day` MCP tool with cap-guard
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/External/ExternalMcpService.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests.**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task SetMyDay_sets_flag_and_sort_order()
|
||||||
|
{
|
||||||
|
var svc = NewService();
|
||||||
|
var id = await SeedIdleTask("My task"); // existing/added helper returning task id
|
||||||
|
|
||||||
|
var dto = await svc.SetMyDay(id, isMyDay: true, sortOrder: 3, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.True(dto.IsMyDay);
|
||||||
|
Assert.Equal(3, dto.SortOrder);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task SetMyDay_rejects_when_cap_reached()
|
||||||
|
{
|
||||||
|
// AppSettings.DailyPrepMaxTasks = 1 (set in seed)
|
||||||
|
var svc = NewService();
|
||||||
|
var first = await SeedIdleTask("a");
|
||||||
|
var second = await SeedIdleTask("b");
|
||||||
|
await svc.SetMyDay(first, true, null, CancellationToken.None);
|
||||||
|
|
||||||
|
var ex = await Assert.ThrowsAsync<InvalidOperationException>(
|
||||||
|
() => svc.SetMyDay(second, true, null, CancellationToken.None));
|
||||||
|
Assert.Contains("limit", ex.Message, StringComparison.OrdinalIgnoreCase);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task SetMyDay_unset_is_always_allowed()
|
||||||
|
{
|
||||||
|
var svc = NewService();
|
||||||
|
var id = await SeedIdleTask("a");
|
||||||
|
await svc.SetMyDay(id, true, null, CancellationToken.None);
|
||||||
|
|
||||||
|
var dto = await svc.SetMyDay(id, false, null, CancellationToken.None);
|
||||||
|
Assert.False(dto.IsMyDay);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
`SetMyDay` returns the existing `TaskDto`. Add a `SortOrder` field to `TaskDto` — see Step 3a. (`SeedIdleTask` / the `DailyPrepMaxTasks=1` seed reuse the file's existing seeding helpers.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run — expect FAIL.**
|
||||||
|
|
||||||
|
- [ ] **Step 3a: Add `SortOrder` to `TaskDto`** (record + `ToDto`) so the result reflects ordering:
|
||||||
|
|
||||||
|
In the `TaskDto` record add `int SortOrder` as the last positional member, and in `ToDto(TaskEntity t)` add `t.SortOrder` as the last argument. (Update any test that constructs `TaskDto` positionally — search the test project.)
|
||||||
|
|
||||||
|
- [ ] **Step 3b: Add the tool method:**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[McpServerTool, Description(
|
||||||
|
"Daily prep: set or clear a task's MyDay flag, optionally setting its sortOrder " +
|
||||||
|
"(use consecutive sortOrder values to keep related tasks together). " +
|
||||||
|
"Setting isMyDay=true is rejected if it would exceed the MyDay cap (DailyPrepMaxTasks open MyDay tasks); " +
|
||||||
|
"clearing (isMyDay=false) is always allowed.")]
|
||||||
|
public async Task<TaskDto> SetMyDay(
|
||||||
|
string taskId,
|
||||||
|
bool isMyDay,
|
||||||
|
int? sortOrder,
|
||||||
|
CancellationToken cancellationToken)
|
||||||
|
{
|
||||||
|
await using var ctx = await _dbFactory.CreateDbContextAsync(cancellationToken);
|
||||||
|
|
||||||
|
var task = await ctx.Tasks.FirstOrDefaultAsync(t => t.Id == taskId, cancellationToken)
|
||||||
|
?? throw new InvalidOperationException($"Task {taskId} not found.");
|
||||||
|
|
||||||
|
if (isMyDay && !task.IsMyDay)
|
||||||
|
{
|
||||||
|
var settings = await new AppSettingsRepository(ctx).GetAsync(cancellationToken);
|
||||||
|
var max = settings.DailyPrepMaxTasks < 1 ? 1 : settings.DailyPrepMaxTasks;
|
||||||
|
var openMyDay = await ctx.Tasks.CountAsync(
|
||||||
|
t => t.IsMyDay && t.Status == TaskStatus.Idle, cancellationToken);
|
||||||
|
if (openMyDay >= max)
|
||||||
|
throw new InvalidOperationException(
|
||||||
|
$"MyDay limit {max} reached. Clear a task before adding another.");
|
||||||
|
}
|
||||||
|
|
||||||
|
task.IsMyDay = isMyDay;
|
||||||
|
if (sortOrder is not null) task.SortOrder = sortOrder.Value;
|
||||||
|
await ctx.SaveChangesAsync(cancellationToken);
|
||||||
|
|
||||||
|
await _broadcaster.TaskUpdated(taskId);
|
||||||
|
return ToDto(task);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run — expect PASS.**
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/External/ExternalMcpService.cs tests/ClaudeDo.Worker.Tests
|
||||||
|
git commit -m "feat(daily-prep): add set_my_day MCP tool with cap-guard"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: Rewrite `PrimeRunner` to run the daily prep
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Worker/Prime/DailyPrepPrompt.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Prime/PrimeRunner.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/Prime/DailyPrepPromptTests.cs`, and extend `PrimeRunnerTests.cs` if it exists
|
||||||
|
|
||||||
|
The runner needs the cap `X` (read from `AppSettings`) and today's date. Inject `IDbContextFactory<ClaudeDoDbContext>` into `PrimeRunner` (it is resolvable in the main app DI) and an `IPrimeClock` for the date (already registered).
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write failing prompt/args tests.**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public class DailyPrepPromptTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void Build_prompt_contains_cap_and_date()
|
||||||
|
{
|
||||||
|
var prompt = DailyPrepPrompt.BuildPrompt(maxTasks: 5, today: new DateOnly(2026, 6, 3));
|
||||||
|
Assert.Contains("5", prompt);
|
||||||
|
Assert.Contains("2026-06-03", prompt);
|
||||||
|
Assert.Contains("get_daily_prep_candidates", prompt);
|
||||||
|
Assert.Contains("set_my_day", prompt);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Build_args_allows_only_the_two_tools()
|
||||||
|
{
|
||||||
|
var args = DailyPrepPrompt.BuildArgs(maxTurns: 30);
|
||||||
|
Assert.Contains("--output-format stream-json", args);
|
||||||
|
Assert.Contains("--max-turns 30", args);
|
||||||
|
Assert.Contains("--allowedTools", args);
|
||||||
|
Assert.Contains("mcp__claudedo__get_daily_prep_candidates", args);
|
||||||
|
Assert.Contains("mcp__claudedo__set_my_day", args);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run — expect FAIL.**
|
||||||
|
|
||||||
|
- [ ] **Step 3: Create `DailyPrepPrompt.cs`:**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Worker.Prime;
|
||||||
|
|
||||||
|
public static class DailyPrepPrompt
|
||||||
|
{
|
||||||
|
public const string CandidatesTool = "mcp__claudedo__get_daily_prep_candidates";
|
||||||
|
public const string SetMyDayTool = "mcp__claudedo__set_my_day";
|
||||||
|
|
||||||
|
public static string BuildArgs(int maxTurns) =>
|
||||||
|
"-p --output-format stream-json --verbose --permission-mode acceptEdits " +
|
||||||
|
$"--max-turns {maxTurns} " +
|
||||||
|
$"--allowedTools {CandidatesTool} {SetMyDayTool}";
|
||||||
|
|
||||||
|
public static string BuildPrompt(int maxTasks, DateOnly today) =>
|
||||||
|
$"""
|
||||||
|
Du bereitest meinen Arbeitstag fuer {today:yyyy-MM-dd} vor.
|
||||||
|
|
||||||
|
1. Rufe {CandidatesTool} auf.
|
||||||
|
2. Behalte bereits als MyDay markierte offene Tasks (currentMyDay) — entferne sie nicht.
|
||||||
|
3. Fuelle bis maximal {maxTasks} offene Tasks GESAMT in MyDay auf (currentMyDay zaehlt mit). Niemals mehr.
|
||||||
|
4. Schaetze pro Kandidat grob den Aufwand und waehle eine machbare Mischung (nicht nur Grossbrocken).
|
||||||
|
Priorisiere isStarred, faellige (scheduledFor) und aeltere Tasks.
|
||||||
|
5. Lege thematisch verwandte Tasks durch aufeinanderfolgende sortOrder-Werte nebeneinander.
|
||||||
|
6. Setze die Auswahl via {SetMyDayTool}(taskId, true, sortOrder). Markiere nichts ausserhalb der Kandidatenliste.
|
||||||
|
|
||||||
|
Wenn es keine Kandidaten gibt, tue nichts.
|
||||||
|
""";
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run prompt tests — expect PASS.**
|
||||||
|
|
||||||
|
- [ ] **Step 5: Rewrite `PrimeRunner.cs`:**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Worker.Runner;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Prime;
|
||||||
|
|
||||||
|
public sealed class PrimeRunner : IPrimeRunner
|
||||||
|
{
|
||||||
|
private static readonly TimeSpan FireTimeout = TimeSpan.FromMinutes(5);
|
||||||
|
private const int MaxTurns = 30;
|
||||||
|
|
||||||
|
private readonly IClaudeProcess _claude;
|
||||||
|
private readonly IDbContextFactory<ClaudeDoDbContext> _dbFactory;
|
||||||
|
private readonly IPrimeClock _clock;
|
||||||
|
private readonly ILogger<PrimeRunner> _logger;
|
||||||
|
private readonly SemaphoreSlim _gate = new(1, 1);
|
||||||
|
|
||||||
|
public PrimeRunner(
|
||||||
|
IClaudeProcess claude,
|
||||||
|
IDbContextFactory<ClaudeDoDbContext> dbFactory,
|
||||||
|
IPrimeClock clock,
|
||||||
|
ILogger<PrimeRunner> logger)
|
||||||
|
{
|
||||||
|
_claude = claude;
|
||||||
|
_dbFactory = dbFactory;
|
||||||
|
_clock = clock;
|
||||||
|
_logger = logger;
|
||||||
|
}
|
||||||
|
|
||||||
|
public async Task<PrimeRunOutcome> FireAsync(PrimeScheduleDto schedule, CancellationToken ct)
|
||||||
|
{
|
||||||
|
if (!await _gate.WaitAsync(0, ct))
|
||||||
|
return new PrimeRunOutcome(false, "Daily prep already running");
|
||||||
|
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var cwd = Paths.AppDataRoot();
|
||||||
|
Directory.CreateDirectory(cwd);
|
||||||
|
|
||||||
|
int maxTasks;
|
||||||
|
await using (var dbCtx = await _dbFactory.CreateDbContextAsync(ct))
|
||||||
|
{
|
||||||
|
var settings = await new AppSettingsRepository(dbCtx).GetAsync(ct);
|
||||||
|
maxTasks = settings.DailyPrepMaxTasks < 1 ? 1 : settings.DailyPrepMaxTasks;
|
||||||
|
}
|
||||||
|
|
||||||
|
var today = DateOnly.FromDateTime(_clock.Now.LocalDateTime);
|
||||||
|
var prompt = DailyPrepPrompt.BuildPrompt(maxTasks, today);
|
||||||
|
var args = DailyPrepPrompt.BuildArgs(MaxTurns);
|
||||||
|
|
||||||
|
using var timeoutCts = CancellationTokenSource.CreateLinkedTokenSource(ct);
|
||||||
|
timeoutCts.CancelAfter(FireTimeout);
|
||||||
|
|
||||||
|
var result = await _claude.RunAsync(
|
||||||
|
arguments: args,
|
||||||
|
prompt: prompt,
|
||||||
|
workingDirectory: cwd,
|
||||||
|
onStdoutLine: _ => Task.CompletedTask,
|
||||||
|
ct: timeoutCts.Token);
|
||||||
|
|
||||||
|
return result.IsSuccess
|
||||||
|
? new PrimeRunOutcome(true, "Daily prep complete")
|
||||||
|
: new PrimeRunOutcome(false, $"exit code {result.ExitCode}");
|
||||||
|
}
|
||||||
|
catch (OperationCanceledException) when (!ct.IsCancellationRequested)
|
||||||
|
{
|
||||||
|
return new PrimeRunOutcome(false, $"timed out after {FireTimeout.TotalMinutes:0} min");
|
||||||
|
}
|
||||||
|
catch (Exception ex)
|
||||||
|
{
|
||||||
|
_logger.LogWarning(ex, "Daily prep run failed");
|
||||||
|
return new PrimeRunOutcome(false, ex.Message);
|
||||||
|
}
|
||||||
|
finally
|
||||||
|
{
|
||||||
|
_gate.Release();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 6: Fix the DI registration is unchanged** (`AddSingleton<IPrimeRunner, PrimeRunner>()` already works — the new ctor deps `IDbContextFactory` and `IPrimeClock` are registered). Build the Worker.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 7: Update/extend `PrimeRunnerTests.cs`** (if present) to match the new ctor: construct `PrimeRunner` with a fake `IClaudeProcess`, a real temp-SQLite `IDbContextFactory`, a fake `IPrimeClock`, and a logger. Add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task FireAsync_returns_already_running_when_gate_held()
|
||||||
|
{
|
||||||
|
var runner = NewRunner(claudeDelay: TimeSpan.FromSeconds(2));
|
||||||
|
var schedule = new PrimeScheduleDto(Guid.Empty, 0, TimeSpan.Zero, true, null, null);
|
||||||
|
|
||||||
|
var first = runner.FireAsync(schedule, CancellationToken.None);
|
||||||
|
var second = await runner.FireAsync(schedule, CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.False(second.Success);
|
||||||
|
Assert.Contains("already running", second.Message, StringComparison.OrdinalIgnoreCase);
|
||||||
|
await first;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
If no `PrimeRunnerTests.cs` exists, create one. The fake `IClaudeProcess` should optionally delay (to keep the gate held) and return a successful `RunResult { ExitCode = 0, ResultMarkdown = "ok" }`.
|
||||||
|
|
||||||
|
- [ ] **Step 8: Run — expect PASS.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter "DailyPrepPrompt|PrimeRunner"
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 9: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Prime tests/ClaudeDo.Worker.Tests/Prime
|
||||||
|
git commit -m "feat(daily-prep): run daily prep from PrimeRunner via allowed MCP tools"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: Hub — `RunDailyPrepNow` + expose `DailyPrepMaxTasks`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Hub/WorkerHub.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/WorkerClient.cs`
|
||||||
|
|
||||||
|
Read `WorkerHub.cs` first. It already exposes a `GetAppSettings`/`UpdateAppSettings` pair backed by a DTO record (the one carrying `ReportExcludedPaths`, `StandupWeekday`).
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add `DailyPrepMaxTasks` to the hub AppSettings DTO record** (the record near the top of `WorkerHub.cs` that lists `ReportExcludedPaths`). Add `int DailyPrepMaxTasks` as a member. In the read mapping (`GetAppSettings`, where `row.ReportExcludedPaths` is read) add `row.DailyPrepMaxTasks`; in the write mapping (`UpdateAppSettings`, where `ReportExcludedPaths = dto.ReportExcludedPaths`) add `DailyPrepMaxTasks = dto.DailyPrepMaxTasks`.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Add the hub method.** Inject `IPrimeRunner` and `HubBroadcaster` if the hub does not already have them (the hub is constructed by SignalR via DI; both are registered singletons). Then:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public async Task<bool> RunDailyPrepNow()
|
||||||
|
{
|
||||||
|
var schedule = new PrimeScheduleDto(Guid.Empty, 0, TimeSpan.Zero, true, null, null);
|
||||||
|
var firedAt = DateTimeOffset.Now;
|
||||||
|
var outcome = await _primeRunner.FireAsync(schedule, Context.ConnectionAborted);
|
||||||
|
await _broadcaster.PrimeFired(Guid.Empty, outcome.Success, outcome.Message, firedAt);
|
||||||
|
return outcome.Success;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `using ClaudeDo.Worker.Prime;` to `WorkerHub.cs` if missing.
|
||||||
|
|
||||||
|
> **Caution (memory):** changing the `WorkerHub` constructor breaks hand-rolled hub-test fakes in `ClaudeDo.Worker.Tests` and possibly `ClaudeDo.Ui.Tests`. After editing, build the test projects and fix every `new WorkerHub(...)` / fake `IWorkerClient` construction the compiler flags.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Mirror the DTO in the UI** (`WorkerClient.cs`, the AppSettings DTO around line 498): add `int DailyPrepMaxTasks` to the record (same position as in the hub DTO). Add a `RunDailyPrepNow` client call:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public Task<bool> RunDailyPrepNowAsync() =>
|
||||||
|
_connection.InvokeAsync<bool>("RunDailyPrepNow");
|
||||||
|
```
|
||||||
|
|
||||||
|
(Match the exact connection field/name and the async-wrapper style used by neighbouring calls like `GenerateWeekReport`.)
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build Worker + App + test projects; fix any broken fakes.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Hub/WorkerHub.cs src/ClaudeDo.Ui/Services/WorkerClient.cs tests
|
||||||
|
git commit -m "feat(daily-prep): add RunDailyPrepNow hub method and expose DailyPrepMaxTasks"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 6: Settings UI — edit `DailyPrepMaxTasks`
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Modals/Settings/PrimeClaudeTabViewModel.cs`
|
||||||
|
- Modify: the Prime Claude tab markup in `src/ClaudeDo.Ui/Views/Modals/SettingsModalView.axaml`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Modals/SettingsModalViewModel.cs` (load/save wiring, where other AppSettings fields are mapped)
|
||||||
|
|
||||||
|
Read these three files first; mirror how an existing numeric AppSetting (e.g. `MaxParallelExecutions` or `WorktreeAutoCleanupDays`) is loaded from the hub DTO, bound, and saved back.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add an observable property** to `PrimeClaudeTabViewModel.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[ObservableProperty] private int _dailyPrepMaxTasks = 5;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Wire load/save** in `SettingsModalViewModel.cs`: where the AppSettings DTO is read into the tabs, set `PrimeClaude.DailyPrepMaxTasks = dto.DailyPrepMaxTasks;`. Where the DTO is written, include `DailyPrepMaxTasks = PrimeClaude.DailyPrepMaxTasks`. (Use the exact tab property name for the Prime Claude tab in that VM.)
|
||||||
|
|
||||||
|
- [ ] **Step 3: Add the editor** in the Prime Claude tab of `SettingsModalView.axaml`, near the schedule list:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<StackPanel Orientation="Horizontal" Spacing="8" VerticalAlignment="Center">
|
||||||
|
<TextBlock Text="{x:Static loc:L.Settings_DailyPrepMaxTasks}" VerticalAlignment="Center"/>
|
||||||
|
<NumericUpDown Minimum="1" Maximum="50" Increment="1" Width="100"
|
||||||
|
Value="{Binding PrimeClaude.DailyPrepMaxTasks}"/>
|
||||||
|
</StackPanel>
|
||||||
|
```
|
||||||
|
|
||||||
|
Add the `Settings_DailyPrepMaxTasks` key to both `locales/en.json` and `locales/de.json` (en: "Max tasks per day", de: "Max. Aufgaben pro Tag"). If the tab does not use localized labels yet, use a plain `Text="Max tasks per day"` string to match its current style.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build the App; smoke-build the UI.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui src/ClaudeDo.Localization
|
||||||
|
git commit -m "feat(daily-prep): add DailyPrepMaxTasks editor to Prime Claude settings"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 7: MyDay header — "Tag vorbereiten" button
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: the ViewModel backing the MyDay list view (the one that exposes the smart-list header/toolbar; find it under `src/ClaudeDo.Ui/ViewModels/Islands/` — likely the tasks/list island VM that has access to `IWorkerClient`)
|
||||||
|
- Modify: the corresponding view (`.axaml`) that renders the list header
|
||||||
|
|
||||||
|
Read the island VM + view first. Find where the active list is known to be `smart:my-day` so the button can be shown only there (mirror any existing conditional header content). The VM already holds a worker-client reference used by other commands (e.g. RunNow) — reuse it.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add the command** to the island VM:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[RelayCommand]
|
||||||
|
private async Task PrepareDayAsync()
|
||||||
|
{
|
||||||
|
await _workerClient.RunDailyPrepNowAsync();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
(Use the VM's existing worker-client field name. The MyDay list refreshes automatically via the `TaskUpdated` broadcast the tools emit, so no manual reload is needed.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Add an `IsMyDayList` (or reuse existing selected-list) guard** so the button only appears on the MyDay smart list. If the VM already exposes the selected list id, add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public bool IsMyDayList => SelectedListId == "smart:my-day";
|
||||||
|
```
|
||||||
|
|
||||||
|
and raise its change notification wherever `SelectedListId` changes (mirror existing patterns; if a `[NotifyPropertyChangedFor]` or manual `OnPropertyChanged` is already used for the selection, add this property to it).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Add the button** to the list header in the view, visible only on MyDay:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Button Content="{x:Static loc:L.MyDay_PrepareDay}"
|
||||||
|
Command="{Binding PrepareDayCommand}"
|
||||||
|
IsVisible="{Binding IsMyDayList}"/>
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `MyDay_PrepareDay` to `locales/en.json` ("Prepare day") and `locales/de.json` ("Tag vorbereiten"), or a plain string if the view is not localized.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build the App.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Manual smoke (cannot be unit-tested):** start the Worker and App, open MyDay, click "Tag vorbereiten", confirm tasks appear (capped) and the button is hidden on other lists. Report results explicitly — do not claim UI success without running it.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui src/ClaudeDo.Localization
|
||||||
|
git commit -m "feat(daily-prep): add Prepare-day button to MyDay header"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Final verification
|
||||||
|
|
||||||
|
- [ ] `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release`
|
||||||
|
- [ ] `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release`
|
||||||
|
- [ ] `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release`
|
||||||
|
- [ ] `dotnet test tests/ClaudeDo.Data.Tests/ClaudeDo.Data.Tests.csproj -c Release`
|
||||||
|
- [ ] `dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release`
|
||||||
|
- [ ] End-to-end manual run: schedule fires (or button) → Claude calls the two tools → MyDay gets a capped subset; re-run keeps existing MyDay and tops up without exceeding the cap.
|
||||||
|
|
||||||
|
## Notes / risks
|
||||||
|
|
||||||
|
- Relies on the globally registered `claudedo` MCP (installer `RegisterMcpStep`). If absent, the prep run produces 0 changes — acceptable for v1.
|
||||||
|
- `--permission-mode acceptEdits` + explicit `--allowedTools` pre-approves exactly the two tools so the headless run never blocks on a permission prompt.
|
||||||
|
- The cap-guard counts `Idle && IsMyDay` tasks; it is the source of truth for the "never move everything in" invariant regardless of Claude's behavior.
|
||||||
|
- Future phase (out of scope): external ticket sources (Jira) feed into `get_daily_prep_candidates` behind a task-source abstraction.
|
||||||
1481
docs/superpowers/plans/2026-06-03-localization.md
Normal file
1481
docs/superpowers/plans/2026-06-03-localization.md
Normal file
File diff suppressed because it is too large
Load Diff
2311
docs/superpowers/plans/2026-06-03-weekly-report.md
Normal file
2311
docs/superpowers/plans/2026-06-03-weekly-report.md
Normal file
File diff suppressed because it is too large
Load Diff
972
docs/superpowers/plans/2026-06-04-bundled-prompts-overhaul.md
Normal file
972
docs/superpowers/plans/2026-06-04-bundled-prompts-overhaul.md
Normal file
@@ -0,0 +1,972 @@
|
|||||||
|
# Bundled Prompts Overhaul Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Externalize every bundled prose prompt into editable files with strong defaults, collapse system+agent, and add an inline `CLAUDEDO_BLOCKED:` roadblock protocol surfaced at review.
|
||||||
|
|
||||||
|
**Architecture:** `PromptFiles` becomes the single source of prompt defaults + a pure token renderer. Each consumer (TaskRunner, PlanningSessionManager, DailyPrepPrompt, WeekReportPromptBuilder) reads its prompt via `PromptFiles`. `StreamAnalyzer` collects roadblock markers from streamed assistant text; the runner folds them into the review result.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, xUnit, EF Core (no schema change in this plan).
|
||||||
|
|
||||||
|
Spec: `docs/superpowers/specs/2026-06-04-bundled-prompts-overhaul-design.md`
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File structure
|
||||||
|
|
||||||
|
- `src/ClaudeDo.Data/PromptFiles.cs` — new `PromptKind` members, new defaults, `RenderTemplate` + `ReadOrDefault` + `Render`.
|
||||||
|
- `src/ClaudeDo.Worker/Runner/StreamAnalyzer.cs` — collect `Blocks` from assistant text.
|
||||||
|
- `src/ClaudeDo.Worker/Runner/RunResult.cs` — carry `Blocks`.
|
||||||
|
- `src/ClaudeDo.Worker/Runner/ClaudeProcess.cs` — pass `Blocks`; expose no-result prefix const.
|
||||||
|
- `src/ClaudeDo.Worker/Runner/TaskRunner.cs` — drop agent file; retry via `retry.md`; fold blocks into review result.
|
||||||
|
- `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs` — read planning prompts via `PromptFiles`.
|
||||||
|
- `src/ClaudeDo.Worker/Prime/DailyPrepPrompt.cs` — read `daily-prep.md`.
|
||||||
|
- `src/ClaudeDo.Worker/Report/WeekReportPromptBuilder.cs` — read `weekly-report.md`.
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Modals/Settings/FilesSettingsTabViewModel.cs` + its view — expose new prompt files, drop agent.
|
||||||
|
- Tests in `tests/ClaudeDo.Data.Tests` and `tests/ClaudeDo.Worker.Tests`.
|
||||||
|
|
||||||
|
Build commands (this repo is on .NET 8 — build per project, not the .slnx):
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Data.Tests/ClaudeDo.Data.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: PromptFiles — kinds, defaults, pure renderer
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Data/PromptFiles.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Data.Tests/PromptFilesTests.cs` (create)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write failing tests for the pure renderer**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Data.Tests/PromptFilesTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Tests;
|
||||||
|
|
||||||
|
public class PromptFilesTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void RenderTemplate_replaces_known_tokens()
|
||||||
|
{
|
||||||
|
var outp = PromptFiles.RenderTemplate(
|
||||||
|
"Plan for {date}, cap {maxTasks}.",
|
||||||
|
new Dictionary<string, string> { ["date"] = "2026-06-04", ["maxTasks"] = "5" });
|
||||||
|
Assert.Equal("Plan for 2026-06-04, cap 5.", outp);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void RenderTemplate_leaves_unknown_braces_intact()
|
||||||
|
{
|
||||||
|
var outp = PromptFiles.RenderTemplate(
|
||||||
|
"## {Wochentag}, {dd.MM.yyyy} — {start}",
|
||||||
|
new Dictionary<string, string> { ["start"] = "01.06.2026" });
|
||||||
|
Assert.Equal("## {Wochentag}, {dd.MM.yyyy} — 01.06.2026", outp);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void DefaultFor_system_mentions_blocked_marker_and_scope()
|
||||||
|
{
|
||||||
|
var d = PromptFiles.DefaultFor(PromptKind.System);
|
||||||
|
Assert.Contains("CLAUDEDO_BLOCKED:", d);
|
||||||
|
Assert.Contains("unattended", d, StringComparison.OrdinalIgnoreCase);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void DefaultFor_planning_initial_has_title_and_description_tokens()
|
||||||
|
{
|
||||||
|
var d = PromptFiles.DefaultFor(PromptKind.PlanningInitial);
|
||||||
|
Assert.Contains("{title}", d);
|
||||||
|
Assert.Contains("{description}", d);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void PathFor_planning_is_planning_system_file()
|
||||||
|
{
|
||||||
|
Assert.EndsWith("planning-system.md", PromptFiles.PathFor(PromptKind.Planning));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run tests to verify they fail**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Data.Tests/ClaudeDo.Data.Tests.csproj -c Release`
|
||||||
|
Expected: FAIL — `RenderTemplate`/`DefaultFor` don't exist, `PromptKind.PlanningInitial` undefined.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Rewrite PromptFiles.cs**
|
||||||
|
|
||||||
|
Replace the entire contents of `src/ClaudeDo.Data/PromptFiles.cs` with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.Text;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data;
|
||||||
|
|
||||||
|
public enum PromptKind { System, Planning, PlanningInitial, Retry, DailyPrep, WeeklyReport }
|
||||||
|
|
||||||
|
public static class PromptFiles
|
||||||
|
{
|
||||||
|
public static string Root => Path.Combine(Paths.AppDataRoot(), "prompts");
|
||||||
|
|
||||||
|
public static string PathFor(PromptKind kind) => kind switch
|
||||||
|
{
|
||||||
|
PromptKind.System => Path.Combine(Root, "system.md"),
|
||||||
|
PromptKind.Planning => Path.Combine(Root, "planning-system.md"),
|
||||||
|
PromptKind.PlanningInitial => Path.Combine(Root, "planning-initial.md"),
|
||||||
|
PromptKind.Retry => Path.Combine(Root, "retry.md"),
|
||||||
|
PromptKind.DailyPrep => Path.Combine(Root, "daily-prep.md"),
|
||||||
|
PromptKind.WeeklyReport => Path.Combine(Root, "weekly-report.md"),
|
||||||
|
_ => throw new ArgumentOutOfRangeException(nameof(kind))
|
||||||
|
};
|
||||||
|
|
||||||
|
public static void EnsureExists(PromptKind kind)
|
||||||
|
{
|
||||||
|
Directory.CreateDirectory(Root);
|
||||||
|
var path = PathFor(kind);
|
||||||
|
if (File.Exists(path)) return;
|
||||||
|
File.WriteAllText(path, DefaultFor(kind));
|
||||||
|
}
|
||||||
|
|
||||||
|
public static string? ReadOrNull(PromptKind kind)
|
||||||
|
{
|
||||||
|
var path = PathFor(kind);
|
||||||
|
if (!File.Exists(path)) return null;
|
||||||
|
var content = File.ReadAllText(path).Trim();
|
||||||
|
return string.IsNullOrEmpty(content) ? null : content;
|
||||||
|
}
|
||||||
|
|
||||||
|
/// <summary>File content if present and non-empty, otherwise the bundled default.</summary>
|
||||||
|
public static string ReadOrDefault(PromptKind kind) => ReadOrNull(kind) ?? DefaultFor(kind);
|
||||||
|
|
||||||
|
/// <summary>Render a prompt: read file-or-default, then substitute named tokens.</summary>
|
||||||
|
public static string Render(PromptKind kind, IReadOnlyDictionary<string, string> values)
|
||||||
|
=> RenderTemplate(ReadOrDefault(kind), values);
|
||||||
|
|
||||||
|
/// <summary>Replace only the given {name} tokens; any other braces pass through untouched.</summary>
|
||||||
|
public static string RenderTemplate(string template, IReadOnlyDictionary<string, string> values)
|
||||||
|
{
|
||||||
|
var sb = new StringBuilder(template);
|
||||||
|
foreach (var (key, val) in values)
|
||||||
|
sb.Replace("{" + key + "}", val);
|
||||||
|
return sb.ToString();
|
||||||
|
}
|
||||||
|
|
||||||
|
public static string DefaultFor(PromptKind kind) => kind switch
|
||||||
|
{
|
||||||
|
PromptKind.System => SystemDefault,
|
||||||
|
PromptKind.Planning => PlanningSystemDefault,
|
||||||
|
PromptKind.PlanningInitial => PlanningInitialDefault,
|
||||||
|
PromptKind.Retry => RetryDefault,
|
||||||
|
PromptKind.DailyPrep => DailyPrepDefault,
|
||||||
|
PromptKind.WeeklyReport => WeeklyReportDefault,
|
||||||
|
_ => ""
|
||||||
|
};
|
||||||
|
|
||||||
|
private const string SystemDefault = """
|
||||||
|
# Working Agreement
|
||||||
|
|
||||||
|
You are completing one well-defined task autonomously in a git repository.
|
||||||
|
|
||||||
|
## Scope
|
||||||
|
- Do exactly what the task asks — no unrequested refactors, renames, dependency
|
||||||
|
changes, or "while I'm here" cleanup.
|
||||||
|
- If intent is ambiguous, state the assumption you're making and proceed with the
|
||||||
|
most reasonable reading. Stop only if you genuinely cannot move forward.
|
||||||
|
- Prefer three similar lines over a premature abstraction. Don't build for
|
||||||
|
hypothetical future needs.
|
||||||
|
|
||||||
|
## Working in the repo
|
||||||
|
- Read a file before editing it. Match the conventions already in this codebase —
|
||||||
|
they override generic defaults.
|
||||||
|
- Prefer editing existing files to creating new ones. Don't write comments that
|
||||||
|
just restate the code.
|
||||||
|
- Validate only at real boundaries (user input, external APIs).
|
||||||
|
|
||||||
|
## Finishing
|
||||||
|
- Before claiming done, verify: run the build and relevant tests, confirm they
|
||||||
|
pass, and report what you ran. If you couldn't verify something, say so plainly.
|
||||||
|
- Make focused commits using the repository's existing commit-message convention.
|
||||||
|
|
||||||
|
## Safety
|
||||||
|
- Never force-push, hard-reset, or delete branches/files beyond the task's scope
|
||||||
|
without being asked.
|
||||||
|
- Don't introduce injection/XSS/secret-leak issues. Never commit credentials.
|
||||||
|
|
||||||
|
## You are running unattended
|
||||||
|
You run autonomously with no human watching. There is no one to answer mid-task
|
||||||
|
questions, so never stop to ask — make the most reasonable decision, note the
|
||||||
|
assumption, and continue.
|
||||||
|
|
||||||
|
## When you are blocked
|
||||||
|
If something genuinely prevents you from completing part of the task (missing
|
||||||
|
credentials, contradictory requirements, a destructive action you won't take
|
||||||
|
unasked), do NOT silently give up. Write this marker on its own line, then keep
|
||||||
|
working on whatever else you can:
|
||||||
|
|
||||||
|
CLAUDEDO_BLOCKED: <one short sentence describing what blocked you>
|
||||||
|
|
||||||
|
Emit it as many times as needed — once per distinct blocker. Use it only for true
|
||||||
|
blockers, not for routine decisions you can make yourself.
|
||||||
|
""";
|
||||||
|
|
||||||
|
private const string PlanningSystemDefault = """
|
||||||
|
You are the planning assistant for ClaudeDo. Your job is to break a task into
|
||||||
|
smaller, independently executable subtasks — the session ends by creating those
|
||||||
|
subtasks.
|
||||||
|
|
||||||
|
Start every session by invoking the `superpowers:brainstorming` skill (Skill
|
||||||
|
tool) and follow it end to end: clarifying questions one at a time, then 2–3
|
||||||
|
approaches with a recommendation, then a short design. Do not create any subtasks
|
||||||
|
until the user has approved the design.
|
||||||
|
|
||||||
|
You can ONLY shape this task's plan — you cannot edit files or touch other tasks.
|
||||||
|
The tools available to you are: CreateChildTask, ListChildTasks, UpdateChildTask,
|
||||||
|
DeleteChildTask, UpdatePlanningTask, and Finalize. Use nothing else.
|
||||||
|
|
||||||
|
Once the design is approved, create the child tasks with CreateChildTask, then
|
||||||
|
call Finalize. Keep each subtask concrete and self-contained with a clear
|
||||||
|
done-state, ordered so dependencies come first.
|
||||||
|
""";
|
||||||
|
|
||||||
|
private const string PlanningInitialDefault = """
|
||||||
|
# Task to plan: {title}
|
||||||
|
|
||||||
|
{description}
|
||||||
|
""";
|
||||||
|
|
||||||
|
private const string RetryDefault = """
|
||||||
|
The task did not complete on the previous attempt — you may have run out of
|
||||||
|
turns, hit an error, or stopped before finishing.
|
||||||
|
|
||||||
|
Review the work already done in this session and the current state of the
|
||||||
|
repository, identify what is still incomplete or broken, and finish the task.
|
||||||
|
Don't restart from scratch or repeat a failed approach. Verify the result
|
||||||
|
(build + tests) before you stop.
|
||||||
|
""";
|
||||||
|
|
||||||
|
private const string DailyPrepDefault = """
|
||||||
|
You are preparing my workday for {date}.
|
||||||
|
|
||||||
|
1. Call mcp__claudedo__get_daily_prep_candidates.
|
||||||
|
2. Keep tasks already marked MyDay (currentMyDay) — never remove them.
|
||||||
|
3. Fill MyDay to at most {maxTasks} open tasks TOTAL (currentMyDay counts). Never exceed it.
|
||||||
|
4. Estimate each candidate's effort and pick a feasible mix — not only big items.
|
||||||
|
Prioritize isStarred, due (scheduledFor), and older tasks.
|
||||||
|
5. Place related tasks next to each other using consecutive sortOrder values.
|
||||||
|
6. Apply via mcp__claudedo__set_my_day(taskId, true, sortOrder). Never mark anything
|
||||||
|
outside the candidate list.
|
||||||
|
|
||||||
|
If there are no candidates, do nothing.
|
||||||
|
""";
|
||||||
|
|
||||||
|
private const string WeeklyReportDefault = """
|
||||||
|
You are generating a concise weekly standup report for a software developer,
|
||||||
|
covering {start} to {end}.
|
||||||
|
|
||||||
|
Rules:
|
||||||
|
- Write the ENTIRE report in German.
|
||||||
|
- Group by day. One "## {Wochentag}, {dd.MM.yyyy}" section per day that has
|
||||||
|
activity (German weekday names). Omit days with no activity.
|
||||||
|
- Within each day: 3–5 first-person, past-tense bullets ("- Habe X umgesetzt",
|
||||||
|
"- Y behoben"). Merge related small work into one bullet.
|
||||||
|
- Drop trivia: typo fixes, pure exploration, false starts, tooling/log noise.
|
||||||
|
- Blend the developer's own notes and the derived activity into ONE deduplicated
|
||||||
|
bullet list per day. The notes are authoritative — never omit or contradict them.
|
||||||
|
- Name the project/repo when it adds clarity.
|
||||||
|
- Output ONLY the dated sections. No preamble, no intro, no closing remarks.
|
||||||
|
|
||||||
|
Two sections follow below: an activity log derived from Claude session history,
|
||||||
|
and the developer's own notes. Base the report on both; the notes are
|
||||||
|
authoritative where they conflict with the derived activity.
|
||||||
|
""";
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run tests to verify they pass**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Data.Tests/ClaudeDo.Data.Tests.csproj -c Release`
|
||||||
|
Expected: PASS (5 new tests).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Data/PromptFiles.cs tests/ClaudeDo.Data.Tests/PromptFilesTests.cs
|
||||||
|
git commit -m "feat(prompts): externalize prompt kinds with defaults and token renderer"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: TaskRunner — drop agent file from system prompt merge
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Runner/TaskRunner.cs:382-386`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Remove the agent-file read and merge**
|
||||||
|
|
||||||
|
In `ResolveConfigAsync`, replace:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var systemFile = PromptFiles.ReadOrNull(PromptKind.System);
|
||||||
|
var agentFile = PromptFiles.ReadOrNull(PromptKind.Agent);
|
||||||
|
|
||||||
|
var instructions = MergeInstructions(
|
||||||
|
systemFile, global.DefaultClaudeInstructions, listConfig?.SystemPrompt, task.SystemPrompt, agentFile);
|
||||||
|
```
|
||||||
|
|
||||||
|
with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var systemFile = PromptFiles.ReadOrNull(PromptKind.System);
|
||||||
|
|
||||||
|
var instructions = MergeInstructions(
|
||||||
|
systemFile, global.DefaultClaudeInstructions, listConfig?.SystemPrompt, task.SystemPrompt);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release`
|
||||||
|
Expected: PASS (no reference to `PromptKind.Agent` remains).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Runner/TaskRunner.cs
|
||||||
|
git commit -m "refactor(prompts): collapse agent prompt into system prompt"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 3: Retry prompt from file + conditional stderr append
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Runner/ClaudeProcess.cs:101-103` (expose prefix const)
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Runner/TaskRunner.cs` (add `BuildRetryPrompt`, use it at ~L107)
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/Runner/RetryPromptTests.cs` (create)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write failing tests for the retry-prompt helper**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Worker.Tests/Runner/RetryPromptTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Worker.Runner;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.Runner;
|
||||||
|
|
||||||
|
public class RetryPromptTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void Generic_no_result_error_is_not_appended()
|
||||||
|
{
|
||||||
|
var prompt = TaskRunner.BuildRetryPrompt($"{ClaudeProcess.NoResultPrefix} 1 and no result.");
|
||||||
|
Assert.DoesNotContain("Captured error", prompt);
|
||||||
|
Assert.Contains("did not complete", prompt);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Real_error_is_appended()
|
||||||
|
{
|
||||||
|
var prompt = TaskRunner.BuildRetryPrompt("error CS1002: ; expected");
|
||||||
|
Assert.Contains("Captured error", prompt);
|
||||||
|
Assert.Contains("CS1002", prompt);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Null_error_yields_bare_prompt()
|
||||||
|
{
|
||||||
|
var prompt = TaskRunner.BuildRetryPrompt(null);
|
||||||
|
Assert.DoesNotContain("Captured error", prompt);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run tests to verify they fail**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter RetryPromptTests`
|
||||||
|
Expected: FAIL — `BuildRetryPrompt` / `NoResultPrefix` don't exist.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Expose the no-result prefix in ClaudeProcess**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Worker/Runner/ClaudeProcess.cs`, add the const near the top of the class and use it in the error fallback. Replace:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var error = lastStderr.Length > 0
|
||||||
|
? lastStderr.ToString().Trim()
|
||||||
|
: $"Claude exited with code {exitCode} and no result.";
|
||||||
|
```
|
||||||
|
|
||||||
|
with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var error = lastStderr.Length > 0
|
||||||
|
? lastStderr.ToString().Trim()
|
||||||
|
: $"{NoResultPrefix} {exitCode} and no result.";
|
||||||
|
```
|
||||||
|
|
||||||
|
and add inside the class (e.g. just below the fields):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public const string NoResultPrefix = "Claude exited with code";
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Add BuildRetryPrompt to TaskRunner and use it**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Worker/Runner/TaskRunner.cs`, add this static method (next to `MergeInstructions`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public static string BuildRetryPrompt(string? capturedError)
|
||||||
|
{
|
||||||
|
var basePrompt = PromptFiles.ReadOrDefault(PromptKind.Retry);
|
||||||
|
var isReal = !string.IsNullOrWhiteSpace(capturedError)
|
||||||
|
&& !capturedError!.StartsWith(ClaudeProcess.NoResultPrefix, StringComparison.Ordinal);
|
||||||
|
return isReal
|
||||||
|
? $"{basePrompt}\n\nCaptured error from the failed run:\n\n{capturedError!.Trim()}"
|
||||||
|
: basePrompt;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Then replace the inline retry prompt at ~L107:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var retryPrompt = $"The previous attempt failed with:\n\n{result.ErrorMarkdown}\n\nTry again and fix the issues.";
|
||||||
|
```
|
||||||
|
|
||||||
|
with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var retryPrompt = BuildRetryPrompt(result.ErrorMarkdown);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Run tests to verify they pass**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter RetryPromptTests`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Runner/ClaudeProcess.cs src/ClaudeDo.Worker/Runner/TaskRunner.cs tests/ClaudeDo.Worker.Tests/Runner/RetryPromptTests.cs
|
||||||
|
git commit -m "feat(prompts): retry prompt from file, append only real captured errors"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 4: PlanningSessionManager reads planning prompts from files
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs` (`BuildSystemPrompt` ~L366, `BuildInitialPrompt` ~L392)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Replace BuildSystemPrompt body**
|
||||||
|
|
||||||
|
Replace the whole method body of `BuildSystemPrompt()` with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private static string BuildSystemPrompt() => PromptFiles.ReadOrDefault(PromptKind.Planning);
|
||||||
|
```
|
||||||
|
|
||||||
|
(Delete the inline fallback string literal that followed.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Replace BuildInitialPrompt body**
|
||||||
|
|
||||||
|
Replace the whole method body of `BuildInitialPrompt(TaskEntity task)` with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private static string BuildInitialPrompt(TaskEntity task) =>
|
||||||
|
PromptFiles.Render(PromptKind.PlanningInitial, new Dictionary<string, string>
|
||||||
|
{
|
||||||
|
["title"] = task.Title,
|
||||||
|
["description"] = task.Description ?? "",
|
||||||
|
});
|
||||||
|
```
|
||||||
|
|
||||||
|
Ensure `using ClaudeDo.Data;` is present (it is — `PromptFiles` lived there already via `ReadOrNull`).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs
|
||||||
|
git commit -m "refactor(prompts): planning prompts read from editable files"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 5: DailyPrepPrompt reads from file
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Prime/DailyPrepPrompt.cs`
|
||||||
|
- Modify: `tests/ClaudeDo.Worker.Tests/Prime/DailyPrepPromptTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Update DailyPrepPromptTests to assert the English default render**
|
||||||
|
|
||||||
|
Replace the `Build_prompt_contains_cap_and_date` test body with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public void Build_prompt_contains_cap_and_date()
|
||||||
|
{
|
||||||
|
var prompt = DailyPrepPrompt.BuildPrompt(maxTasks: 5, today: new DateOnly(2026, 6, 3));
|
||||||
|
Assert.Contains("5", prompt);
|
||||||
|
Assert.Contains("2026-06-03", prompt);
|
||||||
|
Assert.Contains("get_daily_prep_candidates", prompt);
|
||||||
|
Assert.Contains("set_my_day", prompt);
|
||||||
|
Assert.Contains("preparing my workday", prompt);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
(The new assertion pins the English default; the file-read path is exercised by the same default when no `daily-prep.md` exists.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run test to verify it fails**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter DailyPrepPromptTests`
|
||||||
|
Expected: FAIL — current German prompt has no "preparing my workday".
|
||||||
|
|
||||||
|
- [ ] **Step 3: Rewrite BuildPrompt to read the file**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Worker/Prime/DailyPrepPrompt.cs`, replace the `BuildPrompt` method with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public static string BuildPrompt(int maxTasks, DateOnly today) =>
|
||||||
|
ClaudeDo.Data.PromptFiles.Render(
|
||||||
|
ClaudeDo.Data.PromptKind.DailyPrep,
|
||||||
|
new Dictionary<string, string>
|
||||||
|
{
|
||||||
|
["date"] = today.ToString("yyyy-MM-dd"),
|
||||||
|
["maxTasks"] = maxTasks.ToString(),
|
||||||
|
});
|
||||||
|
```
|
||||||
|
|
||||||
|
Leave `BuildArgs`, `LogPath`, and the tool-name consts unchanged.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run test to verify it passes**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter DailyPrepPromptTests`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Prime/DailyPrepPrompt.cs tests/ClaudeDo.Worker.Tests/Prime/DailyPrepPromptTests.cs
|
||||||
|
git commit -m "feat(prompts): daily-prep prompt from file, English default"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 6: WeekReportPromptBuilder reads instructions from file
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Report/WeekReportPromptBuilder.cs`
|
||||||
|
- Check: `tests/ClaudeDo.Worker.Tests/Report/WeekReportPromptBuilderTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Replace the inline Instructions with a file read**
|
||||||
|
|
||||||
|
In `WeekReportPromptBuilder.Build`, replace:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var sb = new StringBuilder();
|
||||||
|
sb.AppendLine(string.Format(CultureInfo.InvariantCulture, Instructions,
|
||||||
|
start.ToString("dd.MM.yyyy", CultureInfo.InvariantCulture),
|
||||||
|
end.ToString("dd.MM.yyyy", CultureInfo.InvariantCulture)));
|
||||||
|
sb.AppendLine();
|
||||||
|
```
|
||||||
|
|
||||||
|
with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var sb = new StringBuilder();
|
||||||
|
sb.AppendLine(ClaudeDo.Data.PromptFiles.Render(
|
||||||
|
ClaudeDo.Data.PromptKind.WeeklyReport,
|
||||||
|
new Dictionary<string, string>
|
||||||
|
{
|
||||||
|
["start"] = start.ToString("dd.MM.yyyy", CultureInfo.InvariantCulture),
|
||||||
|
["end"] = end.ToString("dd.MM.yyyy", CultureInfo.InvariantCulture),
|
||||||
|
}));
|
||||||
|
sb.AppendLine();
|
||||||
|
```
|
||||||
|
|
||||||
|
Then delete the now-unused `private const string Instructions = ...` block. (The `{Wochentag}`/`{dd.MM.yyyy}` literals inside the default survive because `RenderTemplate` only replaces `{start}`/`{end}`.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Verify the existing builder test still passes**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter WeekReportPromptBuilderTests`
|
||||||
|
Expected: PASS. If a test asserted exact old wording, update it to assert the date appears and that activity/notes sections render (the new default keeps German output rules).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Report/WeekReportPromptBuilder.cs tests/ClaudeDo.Worker.Tests/Report/WeekReportPromptBuilderTests.cs
|
||||||
|
git commit -m "feat(prompts): weekly-report instructions from file, point at data sections"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 7: StreamAnalyzer collects roadblock markers
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Runner/StreamAnalyzer.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/Runner/StreamAnalyzerTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write failing tests**
|
||||||
|
|
||||||
|
Append to `StreamAnalyzerTests`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public void Collects_Blocked_Markers_From_Assistant_Text()
|
||||||
|
{
|
||||||
|
var analyzer = new StreamAnalyzer();
|
||||||
|
analyzer.ProcessLine("""{"type":"assistant","message":{"content":[{"type":"text","text":"working\nCLAUDEDO_BLOCKED: missing API key\nmoving on"}]}}""");
|
||||||
|
analyzer.ProcessLine("""{"type":"assistant","message":{"content":[{"type":"text","text":"CLAUDEDO_BLOCKED: cannot reach db"}]}}""");
|
||||||
|
analyzer.ProcessLine("""{"type":"result","result":"done","session_id":"s1"}""");
|
||||||
|
var result = analyzer.GetResult();
|
||||||
|
Assert.Equal(2, result.Blocks.Count);
|
||||||
|
Assert.Equal("missing API key", result.Blocks[0]);
|
||||||
|
Assert.Equal("cannot reach db", result.Blocks[1]);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Strips_Blocked_Markers_From_Result_Text()
|
||||||
|
{
|
||||||
|
var analyzer = new StreamAnalyzer();
|
||||||
|
analyzer.ProcessLine("""{"type":"result","result":"All set.\nCLAUDEDO_BLOCKED: no creds\nDone.","session_id":"s1"}""");
|
||||||
|
var result = analyzer.GetResult();
|
||||||
|
Assert.DoesNotContain("CLAUDEDO_BLOCKED", result.ResultMarkdown);
|
||||||
|
Assert.Single(result.Blocks);
|
||||||
|
Assert.Equal("no creds", result.Blocks[0]);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void No_Markers_Means_Empty_Blocks()
|
||||||
|
{
|
||||||
|
var analyzer = new StreamAnalyzer();
|
||||||
|
analyzer.ProcessLine("""{"type":"result","result":"done","session_id":"s1"}""");
|
||||||
|
Assert.Empty(analyzer.GetResult().Blocks);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run tests to verify they fail**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter StreamAnalyzerTests`
|
||||||
|
Expected: FAIL — `Blocks` doesn't exist.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement marker collection in StreamAnalyzer**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Worker/Runner/StreamAnalyzer.cs`:
|
||||||
|
|
||||||
|
Add to `StreamResult`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public IReadOnlyList<string> Blocks { get; set; } = Array.Empty<string>();
|
||||||
|
```
|
||||||
|
|
||||||
|
Add a field and a constant to `StreamAnalyzer`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private readonly List<string> _blocks = new();
|
||||||
|
private const string BlockedPrefix = "CLAUDEDO_BLOCKED:";
|
||||||
|
```
|
||||||
|
|
||||||
|
In the `case "result":` branch, after `_resultMarkdown` is assigned, scan and strip:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
if (root.TryGetProperty("result", out var resultProp))
|
||||||
|
_resultMarkdown = StripAndCollect(resultProp.GetString());
|
||||||
|
```
|
||||||
|
|
||||||
|
In the `case "assistant":` branch, collect from text content (keep `_turnCount++`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
case "assistant":
|
||||||
|
_turnCount++;
|
||||||
|
CollectFromAssistant(root);
|
||||||
|
break;
|
||||||
|
```
|
||||||
|
|
||||||
|
Add these helpers to the class:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private void CollectFromAssistant(JsonElement root)
|
||||||
|
{
|
||||||
|
if (!root.TryGetProperty("message", out var msg)) return;
|
||||||
|
if (!msg.TryGetProperty("content", out var content) || content.ValueKind != JsonValueKind.Array) return;
|
||||||
|
foreach (var block in content.EnumerateArray())
|
||||||
|
if (block.TryGetProperty("type", out var t) && t.GetString() == "text"
|
||||||
|
&& block.TryGetProperty("text", out var txt))
|
||||||
|
ScanForBlocks(txt.GetString());
|
||||||
|
}
|
||||||
|
|
||||||
|
private void ScanForBlocks(string? text)
|
||||||
|
{
|
||||||
|
if (string.IsNullOrEmpty(text)) return;
|
||||||
|
foreach (var line in text.Split('\n'))
|
||||||
|
{
|
||||||
|
var trimmed = line.Trim();
|
||||||
|
if (trimmed.StartsWith(BlockedPrefix, StringComparison.Ordinal))
|
||||||
|
_blocks.Add(trimmed[BlockedPrefix.Length..].Trim());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private string? StripAndCollect(string? text)
|
||||||
|
{
|
||||||
|
if (string.IsNullOrEmpty(text)) return text;
|
||||||
|
ScanForBlocks(text);
|
||||||
|
var kept = text.Split('\n')
|
||||||
|
.Where(l => !l.Trim().StartsWith(BlockedPrefix, StringComparison.Ordinal));
|
||||||
|
return string.Join('\n', kept).Trim();
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `Blocks = _blocks` to the `GetResult()` initializer:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public StreamResult GetResult() => new()
|
||||||
|
{
|
||||||
|
ResultMarkdown = FallbackResult(),
|
||||||
|
StructuredOutputJson = _structuredOutputJson,
|
||||||
|
SessionId = _sessionId,
|
||||||
|
TurnCount = _turnCount,
|
||||||
|
TokensIn = _tokensIn,
|
||||||
|
TokensOut = _tokensOut,
|
||||||
|
ApiRetryCount = _apiRetryCount,
|
||||||
|
Blocks = _blocks,
|
||||||
|
};
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run tests to verify they pass**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter StreamAnalyzerTests`
|
||||||
|
Expected: PASS (all old + 3 new).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Runner/StreamAnalyzer.cs tests/ClaudeDo.Worker.Tests/Runner/StreamAnalyzerTests.cs
|
||||||
|
git commit -m "feat(roadblock): collect and strip CLAUDEDO_BLOCKED markers in StreamAnalyzer"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 8: RunResult + ClaudeProcess carry Blocks
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Runner/RunResult.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Runner/ClaudeProcess.cs:89-113`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add Blocks to RunResult**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Worker/Runner/RunResult.cs`, add inside the class:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public IReadOnlyList<string> Blocks { get; init; } = Array.Empty<string>();
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Populate Blocks in both RunResult returns**
|
||||||
|
|
||||||
|
In `ClaudeProcess.RunAsync`, add `Blocks = streamResult.Blocks,` to **both** the success `RunResult { ... }` (after `TokensOut`) and the error `RunResult { ... }` initializer.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build to verify it compiles**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Runner/RunResult.cs src/ClaudeDo.Worker/Runner/ClaudeProcess.cs
|
||||||
|
git commit -m "feat(roadblock): carry blocks through RunResult"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 9: Fold roadblocks into the review result
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Runner/TaskRunner.cs` (`HandleSuccess` ~L319-352; add `ComposeReviewResult`)
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/Runner/ReviewResultTests.cs` (create)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write failing tests for the compose helper**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Worker.Tests/Runner/ReviewResultTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Worker.Runner;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.Runner;
|
||||||
|
|
||||||
|
public class ReviewResultTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void No_blocks_returns_result_unchanged()
|
||||||
|
{
|
||||||
|
Assert.Equal("done", TaskRunner.ComposeReviewResult("done", Array.Empty<string>()));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Blocks_are_appended_as_a_section()
|
||||||
|
{
|
||||||
|
var outp = TaskRunner.ComposeReviewResult("done", new[] { "no creds", "db down" });
|
||||||
|
Assert.Contains("⚠ Roadblocks", outp);
|
||||||
|
Assert.Contains("- no creds", outp);
|
||||||
|
Assert.Contains("- db down", outp);
|
||||||
|
Assert.Contains("done", outp);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void Null_result_with_blocks_still_lists_them()
|
||||||
|
{
|
||||||
|
var outp = TaskRunner.ComposeReviewResult(null, new[] { "x" });
|
||||||
|
Assert.Contains("⚠ Roadblocks", outp);
|
||||||
|
Assert.Contains("- x", outp);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run tests to verify they fail**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter ReviewResultTests`
|
||||||
|
Expected: FAIL — `ComposeReviewResult` doesn't exist.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Add ComposeReviewResult and use it in HandleSuccess**
|
||||||
|
|
||||||
|
In `TaskRunner`, add:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public static string? ComposeReviewResult(string? result, IReadOnlyList<string> blocks)
|
||||||
|
{
|
||||||
|
if (blocks.Count == 0) return result;
|
||||||
|
var section = "⚠ Roadblocks reported during the run:\n"
|
||||||
|
+ string.Join('\n', blocks.Select(b => $"- {b}"));
|
||||||
|
return string.IsNullOrWhiteSpace(result) ? section : $"{result}\n\n{section}";
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
In `HandleSuccess`, compute the composed result once and pass it to both terminal writes:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var finishedAt = DateTime.UtcNow;
|
||||||
|
var reviewResult = ComposeReviewResult(result.ResultMarkdown, result.Blocks);
|
||||||
|
if (task.ParentTaskId is null && task.PlanningPhase == PlanningPhase.None)
|
||||||
|
{
|
||||||
|
await _state.SubmitForReviewAsync(task.Id, finishedAt, reviewResult, CancellationToken.None);
|
||||||
|
await _broadcaster.WorkerLog($"Finished \"{task.Title}\" (waiting for review)", WorkerLogLevel.Success, DateTime.UtcNow);
|
||||||
|
await _broadcaster.TaskFinished(slot, task.Id, "waiting_for_review", finishedAt);
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
await _state.CompleteAsync(task.Id, finishedAt, reviewResult, CancellationToken.None);
|
||||||
|
await _broadcaster.WorkerLog($"Finished \"{task.Title}\" (done)", WorkerLogLevel.Success, DateTime.UtcNow);
|
||||||
|
await _broadcaster.TaskFinished(slot, task.Id, "done", finishedAt);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
(Make sure `using System.Linq;` is available — it is, via implicit usings.)
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run tests to verify they pass**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter ReviewResultTests`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Runner/TaskRunner.cs tests/ClaudeDo.Worker.Tests/Runner/ReviewResultTests.cs
|
||||||
|
git commit -m "feat(roadblock): surface reported roadblocks in the review result"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 10: Files-settings UI exposes the new prompt files
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Modals/Settings/FilesSettingsTabViewModel.cs`
|
||||||
|
- Modify: the Files settings view (find with: `Grep "SystemPromptPath" src/ClaudeDo.Ui` → the `.axaml` binding to `OpenPromptCommand`)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Replace the prompt-path properties**
|
||||||
|
|
||||||
|
In `FilesSettingsTabViewModel`, replace the three path properties with the new set (drop Agent, add the rest):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public string SystemPromptPath { get; } = PromptFiles.PathFor(PromptKind.System);
|
||||||
|
public string PlanningPromptPath { get; } = PromptFiles.PathFor(PromptKind.Planning);
|
||||||
|
public string PlanningInitialPromptPath { get; } = PromptFiles.PathFor(PromptKind.PlanningInitial);
|
||||||
|
public string RetryPromptPath { get; } = PromptFiles.PathFor(PromptKind.Retry);
|
||||||
|
public string DailyPrepPromptPath { get; } = PromptFiles.PathFor(PromptKind.DailyPrep);
|
||||||
|
public string WeeklyReportPromptPath { get; } = PromptFiles.PathFor(PromptKind.WeeklyReport);
|
||||||
|
```
|
||||||
|
|
||||||
|
(`OpenPromptCommand` already parses the `PromptKind` name from its parameter, so no command change is needed.)
|
||||||
|
|
||||||
|
- [ ] **Step 2: Update the view**
|
||||||
|
|
||||||
|
Open the Files settings `.axaml`. For the existing System/Planning/Agent rows: keep System, keep Planning, **remove the Agent row**, and add four rows mirroring the System row's markup — each binding its label/path to the new property and passing the matching `PromptKind` name as the `OpenPromptCommand` parameter:
|
||||||
|
|
||||||
|
- `Planning` (system) → "Planning system prompt", `PlanningPromptPath`, parameter `Planning`
|
||||||
|
- `PlanningInitial` → "Planning kickoff prompt", `PlanningInitialPromptPath`, parameter `PlanningInitial`
|
||||||
|
- `Retry` → "Retry prompt", `RetryPromptPath`, parameter `Retry`
|
||||||
|
- `DailyPrep` → "Daily-prep prompt", `DailyPrepPromptPath`, parameter `DailyPrep`
|
||||||
|
- `WeeklyReport` → "Weekly-report prompt", `WeeklyReportPromptPath`, parameter `WeeklyReport`
|
||||||
|
|
||||||
|
Use the exact same control template as the existing System row (same button + `CommandParameter` shape); only the bound property, label text, and parameter string differ.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build the UI project**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Visual check (manual — flag for user)**
|
||||||
|
|
||||||
|
Start the app, open Settings → Files tab. Confirm six "Open" prompt buttons appear (System, Planning system, Planning kickoff, Retry, Daily-prep, Weekly-report), no Agent row, and each opens/seeds the right file under `~/.todo-app/prompts/`. **This step cannot be verified by the agent — ask the user to confirm visually.**
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/ViewModels/Modals/Settings/FilesSettingsTabViewModel.cs src/ClaudeDo.Ui/Views/**/*Files*.axaml
|
||||||
|
git commit -m "feat(ui): expose all editable prompt files, drop agent prompt"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 11: Full build + test sweep
|
||||||
|
|
||||||
|
- [ ] **Step 1: Build worker + app**
|
||||||
|
|
||||||
|
Run:
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
```
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run all affected test projects**
|
||||||
|
|
||||||
|
Run:
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Data.Tests/ClaudeDo.Data.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Update docs**
|
||||||
|
|
||||||
|
Update `docs/prompts-inventory.md` to note the externalized files and that `agent.md`/`planning.md` are retired in favor of `system.md`/`planning-system.md`. Note `CLAUDEDO_BLOCKED:` in the inventory.
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add docs/prompts-inventory.md
|
||||||
|
git commit -m "docs: refresh prompt inventory for externalized prompts + roadblock marker"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Self-review notes
|
||||||
|
|
||||||
|
- **Spec coverage:** system.md collapse (T2), planning prompts (T4), retry (T3), daily-prep English (T5), weekly-report + data pointer (T6), templating/`Render` (T1), roadblock detect/strip/route (T7–T9), file layout + migration via `EnsureExists`/new `PathFor` (T1), UI surface (T10). The "Out-of-scope improvements" system.md section is intentionally **deferred to the child-tasks plan** (it depends on the `SuggestImprovement` tool).
|
||||||
|
- **Migration:** old `planning.md`/`agent.md` go inert automatically — `TaskRunner` no longer reads agent (T2), planning now reads `planning-system.md` (T1 PathFor). No code deletes the old files; harmless.
|
||||||
|
- **Determinism:** content tests target `DefaultFor`/`RenderTemplate` (pure, no disk). Consumers fall back to the same default when no user file exists.
|
||||||
File diff suppressed because it is too large
Load Diff
725
docs/superpowers/plans/2026-06-04-debug-logging-traceability.md
Normal file
725
docs/superpowers/plans/2026-06-04-debug-logging-traceability.md
Normal file
@@ -0,0 +1,725 @@
|
|||||||
|
# Debug Logging & Frontend↔Backend Traceability Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Build-configuration-driven logging — verbose in Debug builds (Rider run button), minimal `Warning`+ in Release (installed app) — with both processes writing one shared `claudedo-.log` and a `TaskId` correlation key threading UI→Worker→UI.
|
||||||
|
|
||||||
|
**Architecture:** A new `ClaudeDo.Logging` library owns all Serilog setup: a `BuildConfig.IsDebug` runtime check (via the entry assembly's `DebuggableAttribute`, no `#if DEBUG`), a default-`TaskId` enricher, and a `LoggingSetup.Configure` method that branches sinks/levels on `IsDebug`. Worker and App both call it. `TaskId` rides Serilog `LogContext`, pushed at the per-task entry points on each side.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, Serilog (core + File + Console sinks), Serilog.Extensions.Logging (App bridge), Serilog.AspNetCore (Worker, already present), xUnit.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 1: Create the `ClaudeDo.Logging` project
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Logging/ClaudeDo.Logging.csproj`
|
||||||
|
- Create: `src/ClaudeDo.Logging/Placeholder.cs` (temporary, removed in Task 2)
|
||||||
|
- Modify: `ClaudeDo.slnx`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Create the csproj**
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Logging/ClaudeDo.Logging.csproj`:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Project Sdk="Microsoft.NET.Sdk">
|
||||||
|
|
||||||
|
<PropertyGroup>
|
||||||
|
<TargetFramework>net8.0</TargetFramework>
|
||||||
|
<Nullable>enable</Nullable>
|
||||||
|
<ImplicitUsings>enable</ImplicitUsings>
|
||||||
|
</PropertyGroup>
|
||||||
|
|
||||||
|
<ItemGroup>
|
||||||
|
<PackageReference Include="Serilog" Version="4.1.0" />
|
||||||
|
<PackageReference Include="Serilog.Sinks.File" Version="6.0.0" />
|
||||||
|
<PackageReference Include="Serilog.Sinks.Console" Version="6.0.0" />
|
||||||
|
</ItemGroup>
|
||||||
|
|
||||||
|
<ItemGroup>
|
||||||
|
<InternalsVisibleTo Include="ClaudeDo.Worker.Tests" />
|
||||||
|
</ItemGroup>
|
||||||
|
|
||||||
|
</Project>
|
||||||
|
```
|
||||||
|
|
||||||
|
> If NuGet reports a version conflict between `Serilog 4.1.0` and the `Serilog` core pulled transitively by `Serilog.AspNetCore 8.0.3` (Worker), align this `Serilog` version to whatever `Serilog.AspNetCore 8.0.3` resolves (check `dotnet list package --include-transitive`) and rebuild.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Add a temporary placeholder so the project compiles**
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Logging/Placeholder.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Logging;
|
||||||
|
|
||||||
|
internal static class Placeholder;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Register the project in the solution**
|
||||||
|
|
||||||
|
Edit `ClaudeDo.slnx` — add inside the `/src/` folder, after the `ClaudeDo.Localization` line:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Project Path="src/ClaudeDo.Logging/ClaudeDo.Logging.csproj" />
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build the new project**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Logging/ClaudeDo.Logging.csproj -c Release`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Logging/ClaudeDo.Logging.csproj src/ClaudeDo.Logging/Placeholder.cs ClaudeDo.slnx
|
||||||
|
git commit -m "build(logging): scaffold ClaudeDo.Logging project"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 2: `DefaultTaskIdEnricher` (TDD)
|
||||||
|
|
||||||
|
Adds `TaskId = "-"` to any log event that doesn't already carry a `TaskId` property, so the `[{TaskId}]` column never renders the raw token. A pushed `LogContext` value takes precedence (because `Enrich.FromLogContext()` runs first and the property is then already present).
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Logging/DefaultTaskIdEnricher.cs`
|
||||||
|
- Delete: `src/ClaudeDo.Logging/Placeholder.cs`
|
||||||
|
- Create: `tests/ClaudeDo.Worker.Tests/Logging/DefaultTaskIdEnricherTests.cs`
|
||||||
|
- Modify: `tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj` (add project reference)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Reference `ClaudeDo.Logging` from the test project**
|
||||||
|
|
||||||
|
Edit `tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj` — add to the existing `ProjectReference` ItemGroup:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<ProjectReference Include="..\..\src\ClaudeDo.Logging\ClaudeDo.Logging.csproj" />
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Write the failing test**
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Worker.Tests/Logging/DefaultTaskIdEnricherTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Logging;
|
||||||
|
using Serilog;
|
||||||
|
using Serilog.Context;
|
||||||
|
using Serilog.Core;
|
||||||
|
using Serilog.Events;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.Logging;
|
||||||
|
|
||||||
|
public sealed class DefaultTaskIdEnricherTests
|
||||||
|
{
|
||||||
|
private sealed class CollectingSink : ILogEventSink
|
||||||
|
{
|
||||||
|
public List<LogEvent> Events { get; } = new();
|
||||||
|
public void Emit(LogEvent logEvent) => Events.Add(logEvent);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void AddsDash_WhenNoTaskIdInScope()
|
||||||
|
{
|
||||||
|
var sink = new CollectingSink();
|
||||||
|
using var logger = new LoggerConfiguration()
|
||||||
|
.Enrich.FromLogContext()
|
||||||
|
.Enrich.With(new DefaultTaskIdEnricher())
|
||||||
|
.WriteTo.Sink(sink)
|
||||||
|
.CreateLogger();
|
||||||
|
|
||||||
|
logger.Information("hello");
|
||||||
|
|
||||||
|
var prop = Assert.Single(sink.Events).Properties["TaskId"];
|
||||||
|
Assert.Equal("\"-\"", prop.ToString());
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void KeepsPushedTaskId_WhenInScope()
|
||||||
|
{
|
||||||
|
var sink = new CollectingSink();
|
||||||
|
using var logger = new LoggerConfiguration()
|
||||||
|
.Enrich.FromLogContext()
|
||||||
|
.Enrich.With(new DefaultTaskIdEnricher())
|
||||||
|
.WriteTo.Sink(sink)
|
||||||
|
.CreateLogger();
|
||||||
|
|
||||||
|
using (LogContext.PushProperty("TaskId", "task-42"))
|
||||||
|
logger.Information("hello");
|
||||||
|
|
||||||
|
var prop = Assert.Single(sink.Events).Properties["TaskId"];
|
||||||
|
Assert.Equal("\"task-42\"", prop.ToString());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Run the test to verify it fails**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter DefaultTaskIdEnricherTests`
|
||||||
|
Expected: FAIL — `DefaultTaskIdEnricher` does not exist (compile error).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Implement the enricher and remove the placeholder**
|
||||||
|
|
||||||
|
Delete `src/ClaudeDo.Logging/Placeholder.cs`.
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Logging/DefaultTaskIdEnricher.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using Serilog.Core;
|
||||||
|
using Serilog.Events;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Logging;
|
||||||
|
|
||||||
|
/// <summary>Ensures every log event carries a TaskId property (defaulting to "-")
|
||||||
|
/// so the output template's [{TaskId}] column never renders the raw token.</summary>
|
||||||
|
public sealed class DefaultTaskIdEnricher : ILogEventEnricher
|
||||||
|
{
|
||||||
|
public void Enrich(LogEvent logEvent, ILogEventPropertyFactory propertyFactory)
|
||||||
|
{
|
||||||
|
if (!logEvent.Properties.ContainsKey("TaskId"))
|
||||||
|
logEvent.AddPropertyIfAbsent(propertyFactory.CreateProperty("TaskId", "-"));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Run the test to verify it passes**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter DefaultTaskIdEnricherTests`
|
||||||
|
Expected: PASS (2 tests).
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Logging/DefaultTaskIdEnricher.cs tests/ClaudeDo.Worker.Tests/Logging/DefaultTaskIdEnricherTests.cs tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj
|
||||||
|
git rm src/ClaudeDo.Logging/Placeholder.cs
|
||||||
|
git commit -m "feat(logging): default TaskId enricher with passing tests"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 3: `BuildConfig.IsDebug`
|
||||||
|
|
||||||
|
Detects whether the entry assembly was compiled in the Debug configuration (JIT optimizer disabled) — the runtime replacement for `#if DEBUG`.
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Logging/BuildConfig.cs`
|
||||||
|
- Create: `tests/ClaudeDo.Worker.Tests/Logging/BuildConfigTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test**
|
||||||
|
|
||||||
|
The test asserts the property returns *some* bool without throwing, and that the underlying detection logic agrees with the test assembly's own `DebuggableAttribute` (the test runs under whatever config `dotnet test` used). We assert the helper's result equals a locally-computed expectation so it passes under both Debug and Release test runs.
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Worker.Tests/Logging/BuildConfigTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.Diagnostics;
|
||||||
|
using System.Reflection;
|
||||||
|
using ClaudeDo.Logging;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.Logging;
|
||||||
|
|
||||||
|
public sealed class BuildConfigTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void IsDebug_MatchesEntryAssemblyDebuggableAttribute()
|
||||||
|
{
|
||||||
|
var entry = Assembly.GetEntryAssembly();
|
||||||
|
var expected = entry?
|
||||||
|
.GetCustomAttribute<DebuggableAttribute>()
|
||||||
|
?.IsJITOptimizerDisabled ?? false;
|
||||||
|
|
||||||
|
Assert.Equal(expected, BuildConfig.IsDebug);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run the test to verify it fails**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter BuildConfigTests`
|
||||||
|
Expected: FAIL — `BuildConfig` does not exist (compile error).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement `BuildConfig`**
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Logging/BuildConfig.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using System.Diagnostics;
|
||||||
|
using System.Reflection;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Logging;
|
||||||
|
|
||||||
|
/// <summary>Runtime build-configuration detection — the replacement for #if DEBUG.
|
||||||
|
/// Debug builds compile with the JIT optimizer disabled; Release builds enable it.</summary>
|
||||||
|
public static class BuildConfig
|
||||||
|
{
|
||||||
|
public static bool IsDebug { get; } =
|
||||||
|
Assembly.GetEntryAssembly()
|
||||||
|
?.GetCustomAttribute<DebuggableAttribute>()
|
||||||
|
?.IsJITOptimizerDisabled ?? false;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run the test to verify it passes**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter BuildConfigTests`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Logging/BuildConfig.cs tests/ClaudeDo.Worker.Tests/Logging/BuildConfigTests.cs
|
||||||
|
git commit -m "feat(logging): runtime Debug-build detection via DebuggableAttribute"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 4: `LoggingSetup.Configure`
|
||||||
|
|
||||||
|
The single shared configuration entry point. Applies enrichers, the output template, and branches sinks/levels on `BuildConfig.IsDebug`.
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `src/ClaudeDo.Logging/LoggingSetup.cs`
|
||||||
|
- Create: `tests/ClaudeDo.Worker.Tests/Logging/LoggingSetupTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing test**
|
||||||
|
|
||||||
|
Verifies a configured logger actually writes a `Warning` (emitted in both build configs) to a `claudedo-*.log` file under the given log root.
|
||||||
|
|
||||||
|
Create `tests/ClaudeDo.Worker.Tests/Logging/LoggingSetupTests.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using ClaudeDo.Logging;
|
||||||
|
using Serilog;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Worker.Tests.Logging;
|
||||||
|
|
||||||
|
public sealed class LoggingSetupTests
|
||||||
|
{
|
||||||
|
[Fact]
|
||||||
|
public void Configure_WritesSharedLogFile()
|
||||||
|
{
|
||||||
|
var logRoot = Path.Combine(Path.GetTempPath(), "claudedo-logtest-" + Guid.NewGuid().ToString("N"));
|
||||||
|
Directory.CreateDirectory(logRoot);
|
||||||
|
try
|
||||||
|
{
|
||||||
|
var logger = LoggingSetup.Configure(new LoggerConfiguration(), "test", logRoot).CreateLogger();
|
||||||
|
logger.Warning("marker-{Marker}", "xyz");
|
||||||
|
logger.Dispose(); // flush + release the file handle
|
||||||
|
|
||||||
|
var files = Directory.GetFiles(logRoot, "claudedo-*.log");
|
||||||
|
var file = Assert.Single(files);
|
||||||
|
var contents = File.ReadAllText(file);
|
||||||
|
Assert.Contains("marker-", contents);
|
||||||
|
Assert.Contains("test/", contents); // {Process} tag in the template
|
||||||
|
}
|
||||||
|
finally
|
||||||
|
{
|
||||||
|
try { Directory.Delete(logRoot, recursive: true); } catch { /* best effort */ }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run the test to verify it fails**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter LoggingSetupTests`
|
||||||
|
Expected: FAIL — `LoggingSetup` does not exist (compile error).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement `LoggingSetup`**
|
||||||
|
|
||||||
|
Create `src/ClaudeDo.Logging/LoggingSetup.cs`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using Serilog;
|
||||||
|
using Serilog.Events;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Logging;
|
||||||
|
|
||||||
|
public static class LoggingSetup
|
||||||
|
{
|
||||||
|
private const string OutputTemplate =
|
||||||
|
"[{Timestamp:HH:mm:ss.fff} {Level:u3}] {Process}/{SourceContext} [{TaskId}] {Message:lj}{NewLine}{Exception}";
|
||||||
|
|
||||||
|
/// <summary>Apply the shared ClaudeDo logging configuration.
|
||||||
|
/// Debug builds: Debug level, console + shared file. Release builds: Warning level, shared file only.</summary>
|
||||||
|
/// <param name="processTag">"worker" or "app" — tags every line so the interleaved file is readable.</param>
|
||||||
|
/// <param name="logRoot">Directory for the shared claudedo-.log (created if missing).</param>
|
||||||
|
public static LoggerConfiguration Configure(LoggerConfiguration cfg, string processTag, string logRoot)
|
||||||
|
{
|
||||||
|
Directory.CreateDirectory(logRoot);
|
||||||
|
var logFile = Path.Combine(logRoot, "claudedo-.log");
|
||||||
|
|
||||||
|
cfg.Enrich.FromLogContext()
|
||||||
|
.Enrich.WithProperty("Process", processTag)
|
||||||
|
.Enrich.With(new DefaultTaskIdEnricher());
|
||||||
|
|
||||||
|
if (BuildConfig.IsDebug)
|
||||||
|
{
|
||||||
|
cfg.MinimumLevel.Debug()
|
||||||
|
.WriteTo.Console(outputTemplate: OutputTemplate)
|
||||||
|
.WriteTo.File(
|
||||||
|
logFile,
|
||||||
|
rollingInterval: RollingInterval.Day,
|
||||||
|
retainedFileCountLimit: 2,
|
||||||
|
shared: true,
|
||||||
|
outputTemplate: OutputTemplate);
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
cfg.MinimumLevel.Warning()
|
||||||
|
.WriteTo.File(
|
||||||
|
logFile,
|
||||||
|
rollingInterval: RollingInterval.Day,
|
||||||
|
retainedFileCountLimit: 2,
|
||||||
|
shared: true,
|
||||||
|
outputTemplate: OutputTemplate);
|
||||||
|
}
|
||||||
|
|
||||||
|
return cfg;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run the test to verify it passes**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter LoggingSetupTests`
|
||||||
|
Expected: PASS.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Logging/LoggingSetup.cs tests/ClaudeDo.Worker.Tests/Logging/LoggingSetupTests.cs
|
||||||
|
git commit -m "feat(logging): shared LoggingSetup with build-config sink branching"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 5: Wire the Worker to the shared setup
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Program.cs:34-40`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add the project reference**
|
||||||
|
|
||||||
|
Edit `src/ClaudeDo.Worker/ClaudeDo.Worker.csproj` — add to the existing `ProjectReference` ItemGroup (the one with `ClaudeDo.Data`):
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<ProjectReference Include="..\ClaudeDo.Logging\ClaudeDo.Logging.csproj" />
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Replace the inline Serilog config**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Worker/Program.cs`, replace lines 34-40:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
builder.Host.UseSerilog((ctx, lc) => lc
|
||||||
|
.MinimumLevel.Information()
|
||||||
|
.WriteTo.File(
|
||||||
|
System.IO.Path.Combine(logRoot, "worker-.log"),
|
||||||
|
rollingInterval: RollingInterval.Day,
|
||||||
|
retainedFileCountLimit: 7,
|
||||||
|
shared: true));
|
||||||
|
```
|
||||||
|
|
||||||
|
with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
builder.Host.UseSerilog((ctx, lc) =>
|
||||||
|
ClaudeDo.Logging.LoggingSetup.Configure(lc, "worker", logRoot));
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build the Worker**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release`
|
||||||
|
Expected: Build succeeded. (If the Worker is running and locks the Debug output, this Release build is unaffected.)
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/ClaudeDo.Worker.csproj src/ClaudeDo.Worker/Program.cs
|
||||||
|
git commit -m "feat(logging): route Worker logging through shared LoggingSetup"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 6: Wire the App/Ui (currently log-silent) to the shared setup
|
||||||
|
|
||||||
|
The App uses a plain `ServiceCollection` with **no** logging registered. Add the Serilog→`ILogger` bridge so all `ILogger<T>` injections across App/Ui flow to the shared sinks, and flush on shutdown.
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.App/ClaudeDo.App.csproj`
|
||||||
|
- Modify: `src/ClaudeDo.App/Program.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add packages and the project reference**
|
||||||
|
|
||||||
|
Edit `src/ClaudeDo.App/ClaudeDo.App.csproj` — add to the package `ItemGroup`:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<PackageReference Include="Serilog.Extensions.Logging" Version="8.0.0" />
|
||||||
|
```
|
||||||
|
|
||||||
|
and to the `ProjectReference` ItemGroup:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<ProjectReference Include="..\ClaudeDo.Logging\ClaudeDo.Logging.csproj" />
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Add the logging registration in `BuildServices`**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.App/Program.cs`, inside `BuildServices()`, immediately after the `var sc = new ServiceCollection();` line (currently line 78), insert:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var logRoot = Path.Combine(Path.GetDirectoryName(dbPath)!, "logs");
|
||||||
|
var serilogLogger = ClaudeDo.Logging.LoggingSetup
|
||||||
|
.Configure(new Serilog.LoggerConfiguration(), "app", logRoot)
|
||||||
|
.CreateLogger();
|
||||||
|
sc.AddLogging(b => b.AddSerilog(serilogLogger, dispose: true));
|
||||||
|
```
|
||||||
|
|
||||||
|
Add these usings to the top of `Program.cs` (the `AddSerilog` `ILoggingBuilder` extension lives in the `Serilog` namespace; `AddLogging` lives in `Microsoft.Extensions.DependencyInjection`, already imported):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using Serilog;
|
||||||
|
using Microsoft.Extensions.Logging;
|
||||||
|
```
|
||||||
|
|
||||||
|
> `dbPath` is already computed just above (`var dbPath = Paths.Expand(settings.DbPath);`). Its parent directory is `~/.todo-app`, so `logs` sits beside the Worker's log root.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build the App**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release`
|
||||||
|
Expected: Build succeeded (pulls in Ui + Data + Logging).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Verify manually from Rider (visual-verification gap)**
|
||||||
|
|
||||||
|
This is a Debug-build behavior that cannot be asserted in a Release test run. Launch the App from Rider's run button and confirm:
|
||||||
|
- A `claudedo-*.log` appears in `~/.todo-app/logs/`.
|
||||||
|
- Console output (Rider run window) shows `Debug`-level lines tagged `app/...`.
|
||||||
|
|
||||||
|
Flag to the user that this step needs their eyes.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.App/ClaudeDo.App.csproj src/ClaudeDo.App/Program.cs
|
||||||
|
git commit -m "feat(logging): wire App/Ui logging to shared LoggingSetup"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 7: Push `TaskId` into `LogContext` in the Worker
|
||||||
|
|
||||||
|
Wraps the two per-task entry points so every nested log line (runner, state service, worktree, planning) carries the task's id automatically.
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Runner/TaskRunner.cs:47` (`RunAsync`) and `:171` (`ContinueAsync`)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add the using directive**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Worker/Runner/TaskRunner.cs`, add to the top usings:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using Serilog.Context;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Push TaskId at the top of `RunAsync`**
|
||||||
|
|
||||||
|
In `RunAsync` (line 47), insert as the very first statement of the method body (before `string? mcpToken = null;`):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using var _taskScope = LogContext.PushProperty("TaskId", task.Id);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Push TaskId at the top of `ContinueAsync`**
|
||||||
|
|
||||||
|
In `ContinueAsync` (line 171), insert as the very first statement of the method body (before `TaskEntity task;`). The parameter is `taskId`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using var _taskScope = LogContext.PushProperty("TaskId", taskId);
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build the Worker**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Worker/Runner/TaskRunner.cs
|
||||||
|
git commit -m "feat(logging): tag Worker task execution with TaskId for traceability"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 8: Push `TaskId` and add trace lines on the App side
|
||||||
|
|
||||||
|
`WorkerClient` currently logs nothing. Inject `ILogger<WorkerClient>`, add a small helper that pushes `TaskId` + emits a `Debug` trace line, and route the fire-and-forget task-targeted hub calls through it. This produces the UI half of the UI→Worker→UI trace under a shared `TaskId`.
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/WorkerClient.cs`
|
||||||
|
- Modify: `src/ClaudeDo.App/Program.cs:101` (registration)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add usings and the logger field/ctor param**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Services/WorkerClient.cs`, add to the usings:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
using Microsoft.Extensions.Logging;
|
||||||
|
using Serilog.Context;
|
||||||
|
```
|
||||||
|
|
||||||
|
Add a field beside `private readonly HubConnection _hub;` (line 32):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
private readonly ILogger<WorkerClient> _logger;
|
||||||
|
```
|
||||||
|
|
||||||
|
Change the constructor signature (line 68) from:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public WorkerClient(string signalRUrl)
|
||||||
|
{
|
||||||
|
```
|
||||||
|
|
||||||
|
to:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public WorkerClient(string signalRUrl, ILogger<WorkerClient> logger)
|
||||||
|
{
|
||||||
|
_logger = logger;
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Add the task-scoped invoke helper**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.Ui/Services/WorkerClient.cs`, add this private method next to `TryInvokeAsync` (after line 241):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
/// <summary>Invoke a task-targeted hub method under a TaskId log scope, emitting a debug trace line.</summary>
|
||||||
|
private async Task InvokeForTaskAsync(string taskId, string method, params object?[] args)
|
||||||
|
{
|
||||||
|
using (LogContext.PushProperty("TaskId", taskId))
|
||||||
|
{
|
||||||
|
_logger.LogDebug("UI invoking {Method} for task {TaskId}", method, taskId);
|
||||||
|
await _hub.InvokeCoreAsync(method, args);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Route the fire-and-forget task actions through the helper**
|
||||||
|
|
||||||
|
In the same file, replace each of these method bodies:
|
||||||
|
|
||||||
|
`RunNowAsync` (line 243):
|
||||||
|
```csharp
|
||||||
|
public Task RunNowAsync(string taskId)
|
||||||
|
=> InvokeForTaskAsync(taskId, "RunNow", taskId);
|
||||||
|
```
|
||||||
|
|
||||||
|
`ContinueTaskAsync` (line 248):
|
||||||
|
```csharp
|
||||||
|
public Task ContinueTaskAsync(string taskId, string followUpPrompt)
|
||||||
|
=> InvokeForTaskAsync(taskId, "ContinueTask", taskId, followUpPrompt);
|
||||||
|
```
|
||||||
|
|
||||||
|
`ResetTaskAsync` (line 253):
|
||||||
|
```csharp
|
||||||
|
public Task ResetTaskAsync(string taskId)
|
||||||
|
=> InvokeForTaskAsync(taskId, "ResetTask", taskId);
|
||||||
|
```
|
||||||
|
|
||||||
|
`CancelTaskAsync` (line 267):
|
||||||
|
```csharp
|
||||||
|
public Task CancelTaskAsync(string taskId)
|
||||||
|
=> InvokeForTaskAsync(taskId, "CancelTask", taskId);
|
||||||
|
```
|
||||||
|
|
||||||
|
`ApproveReviewAsync` (line 389):
|
||||||
|
```csharp
|
||||||
|
public Task ApproveReviewAsync(string taskId)
|
||||||
|
=> InvokeForTaskAsync(taskId, "ApproveReview", taskId);
|
||||||
|
```
|
||||||
|
|
||||||
|
`RejectReviewToQueueAsync` (line 394):
|
||||||
|
```csharp
|
||||||
|
public Task RejectReviewToQueueAsync(string taskId, string feedback)
|
||||||
|
=> InvokeForTaskAsync(taskId, "RejectReviewToQueue", taskId, feedback);
|
||||||
|
```
|
||||||
|
|
||||||
|
`RejectReviewToIdleAsync` (line 399):
|
||||||
|
```csharp
|
||||||
|
public Task RejectReviewToIdleAsync(string taskId)
|
||||||
|
=> InvokeForTaskAsync(taskId, "RejectReviewToIdle", taskId);
|
||||||
|
```
|
||||||
|
|
||||||
|
`CancelReviewAsync` (line 404):
|
||||||
|
```csharp
|
||||||
|
public Task CancelReviewAsync(string taskId)
|
||||||
|
=> InvokeForTaskAsync(taskId, "CancelReview", taskId);
|
||||||
|
```
|
||||||
|
|
||||||
|
> These all previously did `await _hub.InvokeAsync(method, ...)` with no return value, so converting them to expression-bodied delegations preserves behavior. Do **not** touch methods that return DTOs (e.g. `MergeTaskAsync`) or the planning methods — keep this change scoped to the void task actions above.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Update the DI registration to pass the logger**
|
||||||
|
|
||||||
|
In `src/ClaudeDo.App/Program.cs`, replace line 101:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
sc.AddSingleton(sp => new WorkerClient(sp.GetRequiredService<AppSettings>().SignalRUrl));
|
||||||
|
```
|
||||||
|
|
||||||
|
with:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
sc.AddSingleton(sp => new WorkerClient(
|
||||||
|
sp.GetRequiredService<AppSettings>().SignalRUrl,
|
||||||
|
sp.GetRequiredService<ILogger<WorkerClient>>()));
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `using Microsoft.Extensions.Logging;` to the top of `Program.cs` if not already present.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Build the App**
|
||||||
|
|
||||||
|
Run: `dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release`
|
||||||
|
Expected: Build succeeded.
|
||||||
|
|
||||||
|
> Note: `WorkerClient` is faked in tests via the `IWorkerClient` *interface* (hand-rolled fakes implement the interface, they do not subclass `WorkerClient`). This change adds a ctor parameter to the concrete class only and does not alter `IWorkerClient`, so the fakes are unaffected. Confirm by building the test projects in the next step.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Build the test projects to confirm fakes still compile**
|
||||||
|
|
||||||
|
Run: `dotnet build tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release && dotnet build tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release`
|
||||||
|
Expected: Build succeeded for both.
|
||||||
|
|
||||||
|
- [ ] **Step 7: Run the full Worker.Tests suite**
|
||||||
|
|
||||||
|
Run: `dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release`
|
||||||
|
Expected: PASS (all existing tests + the 4 new logging tests).
|
||||||
|
|
||||||
|
- [ ] **Step 8: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add src/ClaudeDo.Ui/Services/WorkerClient.cs src/ClaudeDo.App/Program.cs
|
||||||
|
git commit -m "feat(logging): tag UI task actions with TaskId + debug trace lines"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Final verification
|
||||||
|
|
||||||
|
- [ ] **Build the whole desktop + worker stack in Release:**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Run the logging tests:**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release --filter "FullyQualifiedName~Logging"
|
||||||
|
```
|
||||||
|
Expected: PASS (DefaultTaskIdEnricher × 2, BuildConfig × 1, LoggingSetup × 1).
|
||||||
|
|
||||||
|
- [ ] **Manual smoke test (visual-verification gap — needs the user):**
|
||||||
|
1. Run the Worker and App from Rider (Debug build). Confirm both write to one `~/.todo-app/logs/claudedo-*.log` with `app/...` and `worker/...` lines.
|
||||||
|
2. Run a task; grep that file for the task's id — confirm UI (`UI invoking RunNow…`) and Worker lines share the same `[<taskId>]`.
|
||||||
|
3. Build/install the Release app; confirm the log is near-silent (no `Debug`/`Information` noise, `Warning`+ only) and no console window logging.
|
||||||
1107
docs/superpowers/plans/2026-06-04-inherited-settings-and-turns.md
Normal file
1107
docs/superpowers/plans/2026-06-04-inherited-settings-and-turns.md
Normal file
File diff suppressed because it is too large
Load Diff
147
docs/superpowers/plans/2026-06-04-myday-icons-terminal-reuse.md
Normal file
147
docs/superpowers/plans/2026-06-04-myday-icons-terminal-reuse.md
Normal file
@@ -0,0 +1,147 @@
|
|||||||
|
# MyDay Icon Buttons + Terminal Reuse + Sort Icon Fix — Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: superpowers:subagent-driven-development. Steps use `- [ ]`.
|
||||||
|
|
||||||
|
**Goal:** Move the "Clear day" and "Prep log" actions into the MyDay header icon row as icon buttons (broom + list), render the prep log in the real `SessionTerminalView` ("cool terminal") by making that control reusable, and fix the invisible Sort icon.
|
||||||
|
|
||||||
|
**Approved design (chat):**
|
||||||
|
- Header icon row (`TasksIslandView.axaml`, the Sort/Eye/Settings `icon-btn` StackPanel) gets two more `icon-btn`, both `IsVisible="{Binding IsMyDayList}"`, inserted after the Eye button: **broom** (`Icon.Broom`) → `ClearDayCommand`, **list** (`Icon.List`) → `ShowPrepLogCommand`. The two full-width text buttons "Prep log" and "Clear day" are removed. "Tag vorbereiten" stays as the full-width button (already opens the prep view via `PrepRequested`).
|
||||||
|
- `SessionTerminalView` becomes reusable via StyledProperties so it renders both the task `Log` and the prep `PrepLog` with the same terminal look. The prep panel in `DetailsIslandView` embeds it instead of the copied `ItemsControl`.
|
||||||
|
- **Sort icon bug:** `PathIcon` fills geometry; `Icon.Sort` is an open-line path (no enclosed area) → invisible. Replace with a filled geometry. New icons (Broom, List) are authored as filled geometries too.
|
||||||
|
|
||||||
|
**Tech:** Avalonia (PathIcon/StreamGeometry, StyledProperty), CommunityToolkit.Mvvm, xUnit.
|
||||||
|
|
||||||
|
## Build/test
|
||||||
|
`.slnx` needs .NET 9 — build the csproj. Use `-c Release` if a Worker locks Debug.
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Localization.Tests/ClaudeDo.Localization.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
GUI cannot be smoke-tested headlessly — note it; the human verifies visuals.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task A: Icons + reusable SessionTerminalView
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Design/IslandStyles.axaml` (icon geometries)
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/SessionTerminalView.axaml` + `SessionTerminalView.axaml.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/DetailsIslandView.axaml` (both embeds)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Fix `Icon.Sort` + add `Icon.Broom`, `Icon.List`** as filled geometries in `IslandStyles.axaml` (in the `Styles.Resources` icon block). Replace the existing `Icon.Sort` line and add the two new ones:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<!-- Icon.Sort (filled bars, decreasing width) -->
|
||||||
|
<StreamGeometry x:Key="Icon.Sort">M4 6 H20 V8 H4 Z M4 11 H16 V13 H4 Z M4 16 H11 V18 H4 Z</StreamGeometry>
|
||||||
|
|
||||||
|
<!-- Icon.Broom (filled: handle + binding band + flared bristles) -->
|
||||||
|
<StreamGeometry x:Key="Icon.Broom">M11 3 H13 V10 H11 Z M8.5 10 H15.5 V12 H8.5 Z M9 12 H15 L17 21 H7 Z</StreamGeometry>
|
||||||
|
|
||||||
|
<!-- Icon.List (filled: square bullets + lines) -->
|
||||||
|
<StreamGeometry x:Key="Icon.List">M4 5 H6 V7 H4 Z M8 5 H20 V7 H8 Z M4 11 H6 V13 H4 Z M8 11 H20 V13 H8 Z M4 17 H6 V19 H4 Z M8 17 H20 V19 H8 Z</StreamGeometry>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Add StyledProperties to `SessionTerminalView`** (code-behind `SessionTerminalView.axaml.cs`). Add public StyledProperties and CLR wrappers:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public static readonly StyledProperty<System.Collections.IEnumerable?> EntriesProperty =
|
||||||
|
AvaloniaProperty.Register<SessionTerminalView, System.Collections.IEnumerable?>(nameof(Entries));
|
||||||
|
public static readonly StyledProperty<string?> LabelProperty =
|
||||||
|
AvaloniaProperty.Register<SessionTerminalView, string?>(nameof(Label));
|
||||||
|
public static readonly StyledProperty<bool> IsRunningProperty =
|
||||||
|
AvaloniaProperty.Register<SessionTerminalView, bool>(nameof(IsRunning));
|
||||||
|
public static readonly StyledProperty<bool> IsDoneProperty =
|
||||||
|
AvaloniaProperty.Register<SessionTerminalView, bool>(nameof(IsDone));
|
||||||
|
public static readonly StyledProperty<bool> IsFailedProperty =
|
||||||
|
AvaloniaProperty.Register<SessionTerminalView, bool>(nameof(IsFailed));
|
||||||
|
|
||||||
|
public System.Collections.IEnumerable? Entries { get => GetValue(EntriesProperty); set => SetValue(EntriesProperty, value); }
|
||||||
|
public string? Label { get => GetValue(LabelProperty); set => SetValue(LabelProperty, value); }
|
||||||
|
public bool IsRunning { get => GetValue(IsRunningProperty); set => SetValue(IsRunningProperty, value); }
|
||||||
|
public bool IsDone { get => GetValue(IsDoneProperty); set => SetValue(IsDoneProperty, value); }
|
||||||
|
public bool IsFailed { get => GetValue(IsFailedProperty); set => SetValue(IsFailedProperty, value); }
|
||||||
|
```
|
||||||
|
|
||||||
|
Replace the existing auto-scroll hook (which cast `DataContext as DetailsIslandViewModel` and watched `.Log.CollectionChanged`) with one that watches whichever collection `Entries` points at: in `OnPropertyChanged`, when `change.Property == EntriesProperty`, detach the old `INotifyCollectionChanged.CollectionChanged` handler and attach to the new value (if it implements `INotifyCollectionChanged`); the handler scrolls the existing ScrollViewer to the end (reuse the existing scroll logic / named ScrollViewer). Keep the named ScrollViewer's `x:Name`.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Repoint `SessionTerminalView.axaml` internal bindings to the control's own properties.** Give the root `UserControl` `x:Name="Root"`. Change:
|
||||||
|
- the `ItemsControl ItemsSource="{Binding Log}"` → `ItemsSource="{Binding #Root.Entries}"`
|
||||||
|
- the label `TextBlock` `Text="{Binding BranchLine, StringFormat='claude-session · {0}'}"` (or whatever it is) → `Text="{Binding #Root.Label}"`
|
||||||
|
- the LIVE chip `IsVisible="{Binding IsRunning}"` → `{Binding #Root.IsRunning}`; DONE → `#Root.IsDone`; FAILED → `#Root.IsFailed`.
|
||||||
|
Keep the `LogLineViewModel` item template as-is (it binds the item, not the VM). The `x:DataType` can stay `DetailsIslandViewModel` (element-name bindings to `#Root` don't depend on it) or be removed if it causes compile issues — verify the build.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Update both embeds in `DetailsIslandView.axaml`.**
|
||||||
|
- Task embed (currently `<islands:SessionTerminalView MaxHeight="420"/>`):
|
||||||
|
```xml
|
||||||
|
<islands:SessionTerminalView MaxHeight="420"
|
||||||
|
Entries="{Binding Log}"
|
||||||
|
Label="{Binding BranchLine, StringFormat='claude-session · {0}'}"
|
||||||
|
IsRunning="{Binding IsRunning}" IsDone="{Binding IsDone}" IsFailed="{Binding IsFailed}"/>
|
||||||
|
```
|
||||||
|
(Use the exact label binding the old internal header used — match the prior `StringFormat` text precisely so the task view is visually unchanged.)
|
||||||
|
- Prep panel: replace the whole copied `ItemsControl` (and its surrounding `ScrollViewer`/title) with:
|
||||||
|
```xml
|
||||||
|
<islands:SessionTerminalView
|
||||||
|
Entries="{Binding PrepLog}" Label="daily-prep"
|
||||||
|
IsRunning="{Binding IsPrepRunning}"/>
|
||||||
|
```
|
||||||
|
Keep the panel wrapper `<Panel IsVisible="{Binding IsPrepMode}">`. Drop the now-redundant `details.prepTitle` title TextBlock (the terminal header shows the `daily-prep` label). Leave the `details.prepTitle` locale key in place (harmless) OR remove it from both en/de if you prefer — if removing, run the localization test.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Build the App; confirm no binding/compile errors.**
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
(The existing DetailsIsland prep tests must still pass — `PrepLog`/`IsPrepMode`/`ShowPrep` are unchanged.)
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit** (stage only Task A files; do NOT `git add -A`):
|
||||||
|
```bash
|
||||||
|
git commit -m "feat(daily-prep): reuse SessionTerminal for prep log; fix invisible Sort icon; add Broom/List icons"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task B: MyDay header icon buttons
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/TasksIslandView.axaml`
|
||||||
|
- Modify: `src/ClaudeDo.Localization/locales/en.json`, `de.json`
|
||||||
|
|
||||||
|
Depends on Task A (uses `Icon.Broom` / `Icon.List`).
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add two `icon-btn` to the header icon StackPanel** (the one with Sort/Eye/Settings), inserted right after the Eye button and before Settings, both MyDay-only:
|
||||||
|
|
||||||
|
```xml
|
||||||
|
<Button Classes="icon-btn" IsVisible="{Binding IsMyDayList}"
|
||||||
|
Command="{Binding ClearDayCommand}" ToolTip.Tip="{loc:Tr tasks.clearDayTip}">
|
||||||
|
<PathIcon Width="15" Height="15" Data="{StaticResource Icon.Broom}"/>
|
||||||
|
</Button>
|
||||||
|
<Button Classes="icon-btn" IsVisible="{Binding IsMyDayList}"
|
||||||
|
Command="{Binding ShowPrepLogCommand}" ToolTip.Tip="{loc:Tr tasks.prepLogTip}">
|
||||||
|
<PathIcon Width="15" Height="15" Data="{StaticResource Icon.List}"/>
|
||||||
|
</Button>
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Remove the two full-width buttons** "Prep log" (`ShowPrepLogCommand`) and "Clear day" (`ClearDayCommand`) from the DockPanel button stack. Keep the "Prepare day" (`PrepareDayCommand`) full-width button and the Notes pinned-row button.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Locales.** Add `tasks.clearDayTip` (en "Clear day", de "Tag leeren") and `tasks.prepLogTip` (en "Prep log", de "Vorbereitungs-Log") to both json files. Remove the now-unused `tasks.clearDay` and `tasks.prepLog` keys from both (keep en/de in parity).
|
||||||
|
|
||||||
|
- [ ] **Step 4: Build + test.**
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Localization.Tests/ClaudeDo.Localization.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Manual smoke (human):** on MyDay the header shows Sort (now visible) + Eye + Broom + List + Settings; broom clears the day; list opens the prep terminal; "Tag vorbereiten" opens the prep terminal and streams; the three MyDay-only controls hide on other lists; the task session terminal still renders normally.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit** (stage only Task B files):
|
||||||
|
```bash
|
||||||
|
git commit -m "feat(daily-prep): move Clear-day and Prep-log into MyDay header icon row"
|
||||||
|
```
|
||||||
|
|
||||||
|
## Notes / risks
|
||||||
|
- Element-name bindings (`#Root.*`) require the `UserControl` to have `x:Name="Root"`; verify compiled bindings accept them (they do in Avalonia).
|
||||||
|
- The auto-scroll hook must re-subscribe when `Entries` changes; without it the prep log won't auto-scroll.
|
||||||
|
- `ClearDayCommand` / `ShowPrepLogCommand` already exist on `TasksIslandViewModel` — no VM changes; existing VM tests remain valid.
|
||||||
120
docs/superpowers/plans/2026-06-04-plan-day-in-log-window.md
Normal file
120
docs/superpowers/plans/2026-06-04-plan-day-in-log-window.md
Normal file
@@ -0,0 +1,120 @@
|
|||||||
|
# Move "Plan day" into the Prep-Log Window — Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: superpowers:subagent-driven-development. Steps use `- [ ]`.
|
||||||
|
|
||||||
|
**Goal:** Guard daily-prep planning behind a second click. The MyDay header's full-width "Tag vorbereiten" button is removed; instead the user opens the prep-log window (list icon), sees the last run or an empty-state hint, and clicks a **"Plan day"** button inside that window to run the prep.
|
||||||
|
|
||||||
|
**Approved flow:** Header list-icon (`ShowPrepLogCommand`) opens the prep window → if empty, an empty-state hint shows → "Plan day" button in the window runs `RunDailyPrepNowAsync()`.
|
||||||
|
|
||||||
|
**Tech:** Avalonia + CommunityToolkit.Mvvm, xUnit.
|
||||||
|
|
||||||
|
## Build/test
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Localization.Tests/ClaudeDo.Localization.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
GUI not headlessly verifiable — note it; human verifies visuals.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task: relocate planning trigger + empty-state
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs` (remove PrepareDay)
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/TasksIslandView.axaml` (remove header button)
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/DetailsIslandViewModel.cs` (PlanDayCommand + empty-state)
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Views/Islands/DetailsIslandView.axaml` (prep panel toolbar + empty hint)
|
||||||
|
- Modify: `src/ClaudeDo.Localization/locales/en.json`, `de.json`
|
||||||
|
- Test: `tests/ClaudeDo.Ui.Tests/ViewModels/DetailsIslandPrepModeTests.cs`, and the existing `TasksIslandDailyPrepTests.cs` (remove the obsolete prepare test)
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write/adjust tests first.**
|
||||||
|
- In `DetailsIslandPrepModeTests.cs` add:
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task PlanDayCommand_calls_worker()
|
||||||
|
{
|
||||||
|
var stub = new StubWorkerClient();
|
||||||
|
var vm = NewDetailsVm(stub);
|
||||||
|
await vm.PlanDayCommand.ExecuteAsync(null);
|
||||||
|
Assert.Equal(1, stub.RunDailyPrepNowCalls);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public void ShowPrepEmptyState_true_when_empty_and_not_running()
|
||||||
|
{
|
||||||
|
var vm = NewDetailsVm(new StubWorkerClient());
|
||||||
|
Assert.True(vm.ShowPrepEmptyState);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
`StubWorkerClient` needs a `RunDailyPrepNowCalls` counter incremented in `RunDailyPrepNowAsync` (add if missing; it currently likely returns `Task.FromResult(true)` — keep that and bump a counter).
|
||||||
|
- In `TasksIslandDailyPrepTests.cs` **remove** `PrepareDayCommand_raises_PrepRequested` (the command is being deleted). Keep `ClearDayCommand_calls_worker`.
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run — expect FAIL/compile error.**
|
||||||
|
|
||||||
|
- [ ] **Step 3: `TasksIslandViewModel` — remove planning trigger.**
|
||||||
|
- Delete the `PrepareDayAsync` `[RelayCommand]` entirely.
|
||||||
|
- Keep the `PrepRequested` event and `ShowPrepLog` command (the list icon still raises `PrepRequested` to open the window).
|
||||||
|
- Grep the VM for any remaining `PrepareDay` references and remove them.
|
||||||
|
|
||||||
|
- [ ] **Step 4: `TasksIslandView.axaml` — remove the header button.** Delete the full-width "Prepare day" `<Button … Command="{Binding PrepareDayCommand}" …>`. Leave the Notes pinned-row button, and the header icon buttons (broom = ClearDay, list = ShowPrepLog) untouched.
|
||||||
|
|
||||||
|
- [ ] **Step 5: `DetailsIslandViewModel` — add PlanDayCommand + empty-state.**
|
||||||
|
- Add:
|
||||||
|
```csharp
|
||||||
|
[RelayCommand]
|
||||||
|
private async Task PlanDayAsync()
|
||||||
|
{
|
||||||
|
if (_worker is null) return;
|
||||||
|
try { await _worker.RunDailyPrepNowAsync(); }
|
||||||
|
catch { /* worker offline; PrepStarted/PrepLine will reconcile */ }
|
||||||
|
}
|
||||||
|
|
||||||
|
public bool ShowPrepEmptyState => !IsPrepRunning && PrepLog.Count == 0;
|
||||||
|
```
|
||||||
|
- Notify `ShowPrepEmptyState`: in the constructor add `PrepLog.CollectionChanged += (_, _) => OnPropertyChanged(nameof(ShowPrepEmptyState));`, and add `partial void OnIsPrepRunningChanged(bool value) => OnPropertyChanged(nameof(ShowPrepEmptyState));`.
|
||||||
|
|
||||||
|
- [ ] **Step 6: `DetailsIslandView.axaml` — prep panel toolbar + empty hint.** In the `<Panel IsVisible="{Binding IsPrepMode}">`, wrap the existing `SessionTerminalView` in a `DockPanel`; dock a top toolbar row with the Plan-day button, and overlay/stack an empty-state hint:
|
||||||
|
```xml
|
||||||
|
<Panel IsVisible="{Binding IsPrepMode}">
|
||||||
|
<DockPanel>
|
||||||
|
<Border DockPanel.Dock="Top" Padding="12,8">
|
||||||
|
<Button Classes="btn primary"
|
||||||
|
Command="{Binding PlanDayCommand}"
|
||||||
|
IsEnabled="{Binding !IsPrepRunning}"
|
||||||
|
Content="{loc:Tr details.planDay}"/>
|
||||||
|
</Border>
|
||||||
|
<Panel>
|
||||||
|
<islands:SessionTerminalView
|
||||||
|
Entries="{Binding PrepLog}" Label="daily-prep"
|
||||||
|
IsRunning="{Binding IsPrepRunning}"/>
|
||||||
|
<TextBlock IsVisible="{Binding ShowPrepEmptyState}"
|
||||||
|
HorizontalAlignment="Center" VerticalAlignment="Center"
|
||||||
|
Foreground="{DynamicResource TextMuteBrush}"
|
||||||
|
Text="{loc:Tr details.prepEmpty}"/>
|
||||||
|
</Panel>
|
||||||
|
</DockPanel>
|
||||||
|
</Panel>
|
||||||
|
```
|
||||||
|
(Match the surrounding view's class names/brushes; use the existing button class style seen elsewhere, e.g. `Classes="btn"` — verify `primary` exists, else plain `btn`.)
|
||||||
|
|
||||||
|
- [ ] **Step 7: Locales.** Add `details.planDay` (en "Plan day", de "Tag planen") and `details.prepEmpty` (en "No prep run today yet — click Plan day", de "Heute noch keine Vorbereitung — klick Tag planen") to both json files. Remove the now-unused `tasks.prepareDay` key from both (grep first to confirm no other reference). Keep en/de key parity.
|
||||||
|
|
||||||
|
- [ ] **Step 8: Build + tests.**
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Localization.Tests/ClaudeDo.Localization.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 9: Manual smoke (human):** on MyDay there is no "Tag vorbereiten" button; the list icon opens the prep window showing the empty hint; "Plan day" runs the prep and streams; the hint disappears while running; after restart the persisted last run shows and "Plan day" is available to re-run.
|
||||||
|
|
||||||
|
- [ ] **Step 10: Commit:**
|
||||||
|
```bash
|
||||||
|
git commit -m "feat(daily-prep): trigger planning from inside the prep-log window with an empty-state hint"
|
||||||
|
```
|
||||||
|
|
||||||
|
## Notes / risks
|
||||||
|
- `PrepRequested` and `ShowPrepLogCommand` stay — only `PrepareDayCommand` and its header button are removed.
|
||||||
|
- `ShowPrepEmptyState` must re-notify on both `PrepLog` changes and `IsPrepRunning` changes, else the hint won't hide when a run starts or lines arrive.
|
||||||
|
- Removing `tasks.prepareDay`: confirm via grep it has no remaining references before deleting (keep locale parity or the Localization.Tests parity check fails).
|
||||||
208
docs/superpowers/plans/2026-06-04-prep-log-persistence.md
Normal file
208
docs/superpowers/plans/2026-06-04-prep-log-persistence.md
Normal file
@@ -0,0 +1,208 @@
|
|||||||
|
# Persist Daily-Prep Log Across Restarts — Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: superpowers:subagent-driven-development. Steps use `- [ ]`.
|
||||||
|
|
||||||
|
**Goal:** The prep log currently lives only in memory (`DetailsIslandViewModel.PrepLog`), so after an app restart the prep terminal is empty. Persist the last prep run's output to a file in the worker and load it into the prep terminal when opened.
|
||||||
|
|
||||||
|
**Root cause (confirmed):** `PrimeRunner.FireAsync` streams stdout lines via `_broadcaster.PrepLineAsync(line)` only — it writes no file and stores no record. `PrepLog` is an in-memory `ObservableCollection` populated only by live `PrepLine` events. Nothing persists → empty after restart.
|
||||||
|
|
||||||
|
**Approach:** Worker writes each streamed line to `<appdata>/logs/daily-prep.log` (truncated at run start = last run only) using the existing `LogWriter`. A new hub method `GetLastPrepLog()` returns the file (tail-capped, like `get_task_log`). The UI loads it into `PrepLog` when the prep view opens, but only when `PrepLog` is empty and no run is in progress.
|
||||||
|
|
||||||
|
**Tech:** ASP.NET Core SignalR, Avalonia + CommunityToolkit.Mvvm, xUnit.
|
||||||
|
|
||||||
|
## Build/test
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
GUI not headlessly verifiable — note it; human verifies visuals.
|
||||||
|
|
||||||
|
## Shared constant
|
||||||
|
The prep-log path must be identical in `PrimeRunner` (writer) and `WorkerHub` (reader). Define it once and reference from both:
|
||||||
|
`Path.Combine(ClaudeDo.Data.Paths.AppDataRoot(), "logs", "daily-prep.log")`.
|
||||||
|
Add a small static helper so both sides agree, e.g. in `src/ClaudeDo.Worker/Prime/DailyPrepPrompt.cs` (already the prep "home"):
|
||||||
|
```csharp
|
||||||
|
public static string LogPath() =>
|
||||||
|
System.IO.Path.Combine(ClaudeDo.Data.Paths.AppDataRoot(), "logs", "daily-prep.log");
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 1: Worker — write the prep log + serve it
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Prime/DailyPrepPrompt.cs` (add `LogPath()` helper)
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Prime/PrimeRunner.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Worker/Hub/WorkerHub.cs`
|
||||||
|
- Test: `tests/ClaudeDo.Worker.Tests/Prime/PrimeRunnerTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add `DailyPrepPrompt.LogPath()`** (code above).
|
||||||
|
|
||||||
|
- [ ] **Step 2: Write the failing test.** Extend the existing streaming test (or add one) asserting that after `FireAsync` with emitted stdout lines, the file at `DailyPrepPrompt.LogPath()` contains those lines, and that a prior run's content is replaced (truncate-on-start). Since the path is the real app-data logs dir, the test should delete the file first and clean up after; assert exact line content.
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task FireAsync_writes_last_run_to_prep_log_file()
|
||||||
|
{
|
||||||
|
var path = DailyPrepPrompt.LogPath();
|
||||||
|
if (File.Exists(path)) File.Delete(path);
|
||||||
|
|
||||||
|
var claude = new FakeClaudeProcess(emitLines: new[] { "lineA", "lineB" }, exitCode: 0, result: "ok");
|
||||||
|
var runner = NewRunner(claude, new RecordingPrimeBroadcaster());
|
||||||
|
await runner.FireAsync(new PrimeScheduleDto(Guid.Empty, 0, TimeSpan.Zero, true, null, null), CancellationToken.None);
|
||||||
|
|
||||||
|
var contents = await File.ReadAllTextAsync(path);
|
||||||
|
Assert.Contains("lineA", contents);
|
||||||
|
Assert.Contains("lineB", contents);
|
||||||
|
|
||||||
|
// Truncation: a second run with different lines replaces the file.
|
||||||
|
var claude2 = new FakeClaudeProcess(emitLines: new[] { "lineC" }, exitCode: 0, result: "ok");
|
||||||
|
var runner2 = NewRunner(claude2, new RecordingPrimeBroadcaster());
|
||||||
|
await runner2.FireAsync(new PrimeScheduleDto(Guid.Empty, 0, TimeSpan.Zero, true, null, null), CancellationToken.None);
|
||||||
|
var after = await File.ReadAllTextAsync(path);
|
||||||
|
Assert.DoesNotContain("lineA", after);
|
||||||
|
Assert.Contains("lineC", after);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 3: Run — expect FAIL.**
|
||||||
|
|
||||||
|
- [ ] **Step 4: Write the file in `PrimeRunner.FireAsync`.** After the gate is acquired and before `RunAsync`: compute `var logPath = DailyPrepPrompt.LogPath();`, delete it if present (truncate → last run only), then create `await using var logWriter = new LogWriter(logPath);`. Change the stream callback to write AND broadcast:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var logPath = DailyPrepPrompt.LogPath();
|
||||||
|
try { if (File.Exists(logPath)) File.Delete(logPath); } catch { /* best effort */ }
|
||||||
|
await using var logWriter = new LogWriter(logPath);
|
||||||
|
|
||||||
|
await _broadcaster.PrepStartedAsync();
|
||||||
|
// ... build prompt/args/timeoutCts ...
|
||||||
|
var result = await _claude.RunAsync(
|
||||||
|
arguments: args, prompt: prompt, workingDirectory: cwd,
|
||||||
|
onStdoutLine: async line =>
|
||||||
|
{
|
||||||
|
await logWriter.WriteLineAsync(line);
|
||||||
|
await _broadcaster.PrepLineAsync(line);
|
||||||
|
},
|
||||||
|
ct: timeoutCts.Token);
|
||||||
|
```
|
||||||
|
|
||||||
|
Keep the existing `success`/`finally`/`PrepFinishedAsync`/gate logic. `using ClaudeDo.Worker.Runner;` is already present (LogWriter lives there). The `await using` LogWriter disposes (flushes) before the method returns.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Run — expect PASS.** Build the Worker.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Add `WorkerHub.GetLastPrepLog()`** (no ctor change — reads the static path):
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public Task<string> GetLastPrepLog()
|
||||||
|
{
|
||||||
|
var path = DailyPrepPrompt.LogPath();
|
||||||
|
if (!File.Exists(path)) return Task.FromResult(string.Empty);
|
||||||
|
|
||||||
|
const int maxBytes = 256 * 1024;
|
||||||
|
var bytes = File.ReadAllBytes(path);
|
||||||
|
var text = bytes.Length <= maxBytes
|
||||||
|
? System.Text.Encoding.UTF8.GetString(bytes)
|
||||||
|
: System.Text.Encoding.UTF8.GetString(bytes, bytes.Length - maxBytes, maxBytes);
|
||||||
|
return Task.FromResult(text);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Add `using ClaudeDo.Worker.Prime;` to `WorkerHub.cs` if not present.
|
||||||
|
|
||||||
|
- [ ] **Step 7: Build Worker; run the full Worker.Tests project.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 8: Commit** (stage only Task 1 files):
|
||||||
|
```bash
|
||||||
|
git commit -m "feat(daily-prep): persist last prep run to a log file and serve it via GetLastPrepLog"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task 2: UI — load the persisted prep log when opening
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/Interfaces/IWorkerClient.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/Services/WorkerClient.cs`
|
||||||
|
- Modify: `src/ClaudeDo.Ui/ViewModels/Islands/DetailsIslandViewModel.cs`
|
||||||
|
- Modify fakes: `tests/ClaudeDo.Ui.Tests/StubWorkerClient.cs`, `tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs` (FakeWorkerClient)
|
||||||
|
- Test: `tests/ClaudeDo.Ui.Tests/ViewModels/DetailsIslandPrepModeTests.cs`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Declare on `IWorkerClient`:** `Task<string> GetLastPrepLogAsync();`
|
||||||
|
|
||||||
|
- [ ] **Step 2: Implement in `WorkerClient`:** `public Task<string> GetLastPrepLogAsync() => _hub.InvokeAsync<string>("GetLastPrepLog");` (match neighbouring call style; if there is a `TryInvokeAsync` helper for resilience, mirror `GetWeekReportAsync` and return `?? string.Empty`).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Update fakes.** Add `public Task<string> GetLastPrepLogAsync() => Task.FromResult(string.Empty);` to both fakes. In `StubWorkerClient`, make it return a settable backing field, e.g. `public string LastPrepLog = ""; public Task<string> GetLastPrepLogAsync() => Task.FromResult(LastPrepLog);`.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Write the failing test.**
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
[Fact]
|
||||||
|
public async Task ShowPrep_loads_persisted_log_when_empty()
|
||||||
|
{
|
||||||
|
var stub = new StubWorkerClient { LastPrepLog = "{\"type\":\"assistant\",\"text\":\"restored\"}" };
|
||||||
|
var vm = NewDetailsVm(stub);
|
||||||
|
|
||||||
|
vm.ShowPrep();
|
||||||
|
await Task.Delay(50); // allow the async load to run; or expose the load task to await deterministically
|
||||||
|
|
||||||
|
Assert.NotEmpty(vm.PrepLog);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Prefer determinism over `Task.Delay`: have `ShowPrep` start the load and expose the in-flight `Task` (e.g. a `LoadLastPrepLogAsync()` method the test can call/await directly), then assert. Use whichever the existing test style favors.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Implement load in `DetailsIslandViewModel`.** Add a method and call it from `ShowPrep`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public void ShowPrep()
|
||||||
|
{
|
||||||
|
Bind(null);
|
||||||
|
IsNotesMode = false;
|
||||||
|
IsPrepMode = true;
|
||||||
|
_ = LoadLastPrepLogIfEmptyAsync();
|
||||||
|
}
|
||||||
|
|
||||||
|
private async Task LoadLastPrepLogIfEmptyAsync()
|
||||||
|
{
|
||||||
|
if (_worker is null || IsPrepRunning || PrepLog.Count > 0) return;
|
||||||
|
string text;
|
||||||
|
try { text = await _worker.GetLastPrepLogAsync(); }
|
||||||
|
catch { return; }
|
||||||
|
if (IsPrepRunning || PrepLog.Count > 0) return; // a live run may have started meanwhile
|
||||||
|
foreach (var line in text.Split('\n'))
|
||||||
|
{
|
||||||
|
var trimmed = line.TrimEnd('\r');
|
||||||
|
if (trimmed.Length > 0) AppendStdoutLine(PrepLog, trimmed);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
This reuses the existing `AppendStdoutLine(PrepLog, line)` formatter path, so persisted NDJSON renders identically to the live stream. The guards ensure it never overwrites a live run (`PrepStarted` clears `PrepLog` and sets `IsPrepRunning`) or an already-loaded log.
|
||||||
|
|
||||||
|
- [ ] **Step 6: Build App + run UI tests.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Ui.Tests/ClaudeDo.Ui.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 7: Manual smoke (human):** run a prep, restart the app, open the prep log on MyDay → the last run's output is shown.
|
||||||
|
|
||||||
|
- [ ] **Step 8: Commit** (stage only Task 2 files):
|
||||||
|
```bash
|
||||||
|
git commit -m "feat(daily-prep): load persisted prep log into the terminal on open"
|
||||||
|
```
|
||||||
|
|
||||||
|
## Notes / risks
|
||||||
|
- `PrimeRunner` writes via the same `LogWriter` pattern `TaskRunner` uses; concurrency behavior matches existing code (no new locking introduced).
|
||||||
|
- Path is shared via `DailyPrepPrompt.LogPath()` so writer and reader never diverge.
|
||||||
|
- Load is guarded (`PrepLog empty && !IsPrepRunning`) to avoid clobbering a live stream — the order of `ShowPrep`'s flag set vs. the async load matters; re-check the guard after the await.
|
||||||
|
- Last run only (file truncated each run); history is out of scope.
|
||||||
74
docs/superpowers/plans/2026-06-04-review-and-roadblock-ux.md
Normal file
74
docs/superpowers/plans/2026-06-04-review-and-roadblock-ux.md
Normal file
@@ -0,0 +1,74 @@
|
|||||||
|
# Review & Roadblock UX Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** execute task-by-task (subagent-driven-development). Steps use `- [ ]`.
|
||||||
|
|
||||||
|
**Goal:** Move the task-row review actions into the Details panel, give the Details panel a real `WaitingForReview` state + a populated diff meter, and add a glanceable yellow roadblock indicator on the task card.
|
||||||
|
|
||||||
|
**Architecture:** Persist a `RoadblockCount` on `TaskEntity` (set by the runner when it folds in `CLAUDEDO_BLOCKED` markers). The row shows a warning badge when count > 0; review controls relocate to `DetailsIslandView`.
|
||||||
|
|
||||||
|
**Tech Stack:** .NET 8, Avalonia, EF Core (one migration), xUnit.
|
||||||
|
|
||||||
|
**Coordination:** A second session (`claudedo-childloop`) is building the child-tasks/improvement-loop in a worktree and will rebase onto main *after* these commits. It also touches `DetailsIslandViewModel`, `TaskRowView.axaml`, `TaskStateService`, `TaskStatus`. This plan deliberately stays OUT of `TaskStateService` and the `TaskStatus` enum (persisting `RoadblockCount` from the runner via the repository instead).
|
||||||
|
|
||||||
|
Build/test (per-project, .NET 8):
|
||||||
|
```bash
|
||||||
|
dotnet build src/ClaudeDo.App/ClaudeDo.App.csproj -c Release
|
||||||
|
dotnet build src/ClaudeDo.Worker/ClaudeDo.Worker.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Data.Tests/ClaudeDo.Data.Tests.csproj -c Release
|
||||||
|
dotnet test tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj -c Release
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task A — Persist RoadblockCount (Data + Worker, no UI)
|
||||||
|
|
||||||
|
**Files:** `TaskEntity.cs`, `TaskEntityConfiguration.cs`, new migration, `TaskRepository.cs`, `TaskRunner.cs`; test in `tests/ClaudeDo.Data.Tests`.
|
||||||
|
|
||||||
|
- Add `public int RoadblockCount { get; set; }` to `TaskEntity` (default 0).
|
||||||
|
- Map it in `TaskEntityConfiguration` to column `roadblock_count` (default 0). Mirror the pattern used by an existing scalar column (e.g. how `DailyPrepMaxTasks`/other ints are configured).
|
||||||
|
- Create EF migration `AddRoadblockCount` (run `dotnet ef migrations add AddRoadblockCount` against `src/ClaudeDo.Data`; if EF tooling is unavailable, hand-author the migration + Designer + snapshot edit mirroring the most recent migration). One column, default 0, no backfill needed.
|
||||||
|
- Add `TaskRepository.SetRoadblockCountAsync(string taskId, int count, CancellationToken ct)` using `ExecuteUpdateAsync` on `RoadblockCount`.
|
||||||
|
- In `TaskRunner.HandleSuccess`, BEFORE the terminal state write (`SubmitForReviewAsync`/`CompleteAsync`), call `SetRoadblockCountAsync(task.Id, result.Blocks.Count, CancellationToken.None)` so the `TaskUpdated` broadcast reflects it. (Do NOT route this through `TaskStateService`.)
|
||||||
|
- Test: a `TaskRepository` test that sets a count and reads it back.
|
||||||
|
- Commit: `feat(roadblock): persist roadblock count on the task`.
|
||||||
|
|
||||||
|
**Acceptance:** a finished run with N roadblocks leaves `tasks.roadblock_count = N`; a clean run leaves 0.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task B — Detail panel: host review actions + real WaitingForReview state + diff meter
|
||||||
|
|
||||||
|
**Files:** `DetailsIslandViewModel.cs`, `DetailsIslandView.axaml` (+ `.axaml.cs` if needed), locales if new keys; reuse `IWorkerClient.ApproveReview/RejectReviewToQueue/RejectReviewToIdle/CancelReview` (already exist).
|
||||||
|
|
||||||
|
1. **WaitingForReview state:**
|
||||||
|
- In `StatusToStateKey` map `WaitingForReview => "review"` (was `"running"`); in `FinishedStatusToStateKey` map `"waiting_for_review" => "review"`.
|
||||||
|
- Add `public bool IsWaitingForReview => AgentState == "review";` and raise it in `OnAgentStateChanged`.
|
||||||
|
- Add a `vm.agentStatus.review` locale key (en + de, parity) for the status label.
|
||||||
|
- Confirm `IsAgentSectionEnabled => !IsRunning` still holds (review is no longer "running", so the agent settings section re-enables in review — correct).
|
||||||
|
2. **Review actions (moved from the row):** add commands to `DetailsIslandViewModel` that call the worker for the selected task: `ApproveReviewCommand`, `RejectReviewCommand` (takes feedback text → `RejectReviewToQueueAsync`), `ParkReviewCommand` (`RejectReviewToIdleAsync`), `CancelReviewCommand` (`CancelReviewAsync`). Add a `ReviewFeedback` string property for the rejection comment. Mirror how the row's code-behind currently invokes these (see `TaskRowView.axaml.cs`).
|
||||||
|
- In `DetailsIslandView.axaml`, add a review section (visible when `IsWaitingForReview` and `IsTaskDetailVisible`) with Approve / Reject(+feedback box) / Park / Cancel, reusing the existing `tasks.approve/reject/park/cancel` + `tasks.feedback*` locale keys.
|
||||||
|
3. **Diff meter:** in `RefreshWorktreeAsync`, after setting `row.DiffStat`, parse the `--stat` summary into additions/deletions and assign `DiffAdditions`/`DiffDeletions` (drives `DiffMeterRatio`). Add a small static parser `ParseDiffStat(string?) -> (int add, int del)` reading the "N insertions(+), M deletions(-)" tail; unit-test it.
|
||||||
|
- Commit: `feat(ui): host review actions in the details panel; show review state and diff meter`.
|
||||||
|
|
||||||
|
**Acceptance:** selecting a `WaitingForReview` task shows a "review" status (not "running"), the four review actions work from the detail panel, and the diff meter reflects real additions/deletions.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task C — Task row: remove review buttons, add roadblock badge
|
||||||
|
|
||||||
|
**Files:** `TaskRowView.axaml`, `TaskRowView.axaml.cs`, `TaskRowViewModel.cs`; warning icon resource if missing.
|
||||||
|
|
||||||
|
- Remove the review-actions `StackPanel` (lines ~142–157) and the now-unused `RejectAnchor` flyout (~250–279) from `TaskRowView.axaml`, and the corresponding click handlers (`OnApproveReviewClick`, `OnRejectReviewClick`, `OnParkReviewClick`, `OnCancelReviewClick`, reject-flyout handlers) from the code-behind. (Review now lives in the detail panel — Task B.)
|
||||||
|
- `TaskRowViewModel`: add `int RoadblockCount` + `bool HasRoadblock => RoadblockCount > 0` + `string RoadblockTooltip` (e.g. `"{n} roadblock(s) reported — see details"`); map `RoadblockCount` in `FromEntity`.
|
||||||
|
- `TaskRowView.axaml`: add a yellow warning `PathIcon` immediately left of the action area (in the chip row, before the status chip or before the star — pick the spot that reads as "left of the Done/action button"), `IsVisible="{Binding HasRoadblock}"`, `ToolTip.Tip="{Binding RoadblockTooltip}"`. Use a filled-geometry warning icon (PathIcon fills geometry — a stroke path renders invisible); if no `Icon.Warning` resource exists, add one (filled triangle + exclamation) to the icon resources, colored with a yellow/amber brush.
|
||||||
|
- Commit: `feat(ui): roadblock badge on the task card; relocate review actions`.
|
||||||
|
|
||||||
|
**Acceptance:** rows no longer show the four review buttons; a task with `RoadblockCount > 0` shows a yellow ⚠ left of the action button with a tooltip; review still fully works via the detail panel.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Task D — Build + visual-check
|
||||||
|
|
||||||
|
- Full build (`App` + `Worker`) and run Data + Worker test suites; all green.
|
||||||
|
- **Manual (flag for user):** start the app, take a `WaitingForReview` task (the deploy roadblock task qualifies), confirm: row shows the ⚠ badge + no row review buttons; detail panel shows "review" state, working review actions, and a non-zero diff meter for the farewell/README tasks. The agent cannot verify GUI — ask the user.
|
||||||
|
- Then ping `claudedo-childloop` via mailbox with the exact shared-file diffs so it can rebase.
|
||||||
@@ -37,7 +37,7 @@ Fields:
|
|||||||
|---|---|---|
|
|---|---|---|
|
||||||
| `DefaultClaudeInstructions` | text | `""` |
|
| `DefaultClaudeInstructions` | text | `""` |
|
||||||
| `DefaultModel` | string | `sonnet` |
|
| `DefaultModel` | string | `sonnet` |
|
||||||
| `DefaultMaxTurns` | int | `30` |
|
| `DefaultMaxTurns` | int | `100` |
|
||||||
| `DefaultPermissionMode` | string | `acceptEdits` |
|
| `DefaultPermissionMode` | string | `acceptEdits` |
|
||||||
| `WorktreeStrategy` | string | `sibling` |
|
| `WorktreeStrategy` | string | `sibling` |
|
||||||
| `CentralWorktreeRoot` | string? | `null` |
|
| `CentralWorktreeRoot` | string? | `null` |
|
||||||
|
|||||||
468
docs/superpowers/specs/2026-04-23-planning-sessions-design.md
Normal file
468
docs/superpowers/specs/2026-04-23-planning-sessions-design.md
Normal file
@@ -0,0 +1,468 @@
|
|||||||
|
# Planning Sessions — Design
|
||||||
|
|
||||||
|
**Status:** Approved for implementation
|
||||||
|
**Date:** 2026-04-23
|
||||||
|
**Scope:** Feature — "Open planning Session" context menu on tasks that spawns an interactive Windows Terminal with Claude (Sonnet 4.6, medium thinking) and a scoped MCP server, letting the user brainstorm and have Claude break a rough task into concrete executable child-tasks.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 1. Goal
|
||||||
|
|
||||||
|
Allow a user to take a vague task (a title plus some TODO-style notes) and convert it — via interactive dialogue with Claude in a terminal — into a structured set of concrete, executable child-tasks that the worker queue can pick up and run.
|
||||||
|
|
||||||
|
The interaction is driven by Claude calling MCP tools against a scoped server running inside the existing `ClaudeDo.Worker` process. The parent task becomes a "Planning" container that holds its children as a flat (single-level) hierarchy.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 2. Status Flow
|
||||||
|
|
||||||
|
**Parent (new statuses `Planning`, `Planned`):**
|
||||||
|
|
||||||
|
```
|
||||||
|
Manual ──[Open planning Session]──▶ Planning ──[finalize]──▶ Planned
|
||||||
|
│ │
|
||||||
|
│ (all children reach terminal state)
|
||||||
|
│ ▼
|
||||||
|
│ Done
|
||||||
|
│ or
|
||||||
|
│ Failed (if any child Failed)
|
||||||
|
▼
|
||||||
|
[Discard] ──▶ Manual
|
||||||
|
```
|
||||||
|
|
||||||
|
**Child (new status `Draft`):**
|
||||||
|
|
||||||
|
```
|
||||||
|
Draft ──[finalize]──▶ Manual | Queued (if "agent" tag) ──▶ Running ──▶ Done | Failed
|
||||||
|
```
|
||||||
|
|
||||||
|
**Rules:**
|
||||||
|
- Parent with status `Planning` or `Planned` is **never** picked up by the queue.
|
||||||
|
- Children with status `Draft` are **never** picked up by the queue.
|
||||||
|
- Hierarchy is strictly **one level deep**: a child task cannot itself become a planning parent (enforced app-side: Plan menu item hidden/disabled if `ParentTaskId IS NOT NULL`).
|
||||||
|
- One planning session per parent task at a time (`StartPlanningSessionAsync` errors if parent is already `Planning`; use Resume instead).
|
||||||
|
- Parent auto-status on child completion (evaluated after any child reaches `Done` or `Failed`):
|
||||||
|
- At least one child `Failed` and no children still in non-terminal states → Parent `Failed`.
|
||||||
|
- All children `Done` → Parent `Done`.
|
||||||
|
- Any child still `Manual`/`Queued`/`Running`/`Draft` → Parent stays `Planned`.
|
||||||
|
- Worktree state (`Merged`/`Discarded`/`Kept`) is orthogonal; only `Task.Status` determines completion.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 3. Data Model
|
||||||
|
|
||||||
|
### 3.1 Schema changes to `Tasks` table
|
||||||
|
|
||||||
|
| Column | Type | Nullable | Purpose |
|
||||||
|
|---|---|---|---|
|
||||||
|
| `ParentTaskId` | `string` (FK → `Tasks.Id`, `DeleteBehavior.Restrict`) | yes | When set, row is a child of a planning parent. NULL = top-level task. |
|
||||||
|
| `PlanningSessionId` | `string` | yes | Claude CLI session ID captured after first run; used with `--resume`. Only set on planning parents. |
|
||||||
|
| `PlanningSessionToken` | `string` | yes | Random 32-byte Base64 token generated per session; acts as bearer for MCP calls. NULL when no active session. |
|
||||||
|
| `PlanningFinalizedAt` | `DateTime` | yes | Timestamp when `finalize` was called. NULL until finalized. |
|
||||||
|
|
||||||
|
Index: `(ParentTaskId)` for fast children lookup.
|
||||||
|
|
||||||
|
### 3.2 Status enum additions
|
||||||
|
|
||||||
|
`ClaudeDo.Data.Models.TaskStatus` gains:
|
||||||
|
- `Planning` — parent, session active or paused, drafts may exist.
|
||||||
|
- `Planned` — parent, finalized, children are real tasks (may still be running).
|
||||||
|
- `Draft` — child, created during session, not yet finalized.
|
||||||
|
|
||||||
|
Existing values unchanged: `Manual | Queued | Running | Done | Failed`. Persisted via `ValueConverter` to string (existing convention — confirmed via `TaskEntity.cs`).
|
||||||
|
|
||||||
|
### 3.3 Navigation properties
|
||||||
|
|
||||||
|
On `TaskEntity`:
|
||||||
|
```csharp
|
||||||
|
public string? ParentTaskId { get; set; }
|
||||||
|
public TaskEntity? Parent { get; set; }
|
||||||
|
public ICollection<TaskEntity> Children { get; set; } = new List<TaskEntity>();
|
||||||
|
public string? PlanningSessionId { get; set; }
|
||||||
|
public string? PlanningSessionToken { get; set; }
|
||||||
|
public DateTime? PlanningFinalizedAt { get; set; }
|
||||||
|
```
|
||||||
|
|
||||||
|
In `TaskEntityConfiguration`:
|
||||||
|
```csharp
|
||||||
|
.HasOne(t => t.Parent)
|
||||||
|
.WithMany(t => t.Children)
|
||||||
|
.HasForeignKey(t => t.ParentTaskId)
|
||||||
|
.OnDelete(DeleteBehavior.Restrict);
|
||||||
|
```
|
||||||
|
|
||||||
|
**Rationale for `Restrict`:** cascade delete would orphan worktrees of in-flight child tasks. UI must handle the `DbUpdateException` and prompt the user to discard children first.
|
||||||
|
|
||||||
|
### 3.4 Repository additions
|
||||||
|
|
||||||
|
`ITaskRepository` gains:
|
||||||
|
- `Task<IReadOnlyList<TaskEntity>> GetChildrenAsync(string parentId, CancellationToken ct)`
|
||||||
|
- `Task<TaskEntity> CreateChildAsync(string parentId, string title, string? description, IReadOnlyList<string>? tagNames, string? commitType, CancellationToken ct)` — creates with `Status = Draft`, `ParentTaskId = parentId`.
|
||||||
|
- `Task<int> FinalizePlanningAsync(string parentId, bool queueAgentTasks, CancellationToken ct)` — transactional: all Drafts → `Manual` (or `Queued` if tagged "agent" and `queueAgentTasks=true`), parent → `Planned`, set `PlanningFinalizedAt`, clear `PlanningSessionToken`. Returns count of finalized children.
|
||||||
|
- `Task<bool> DiscardPlanningAsync(string parentId, CancellationToken ct)` — deletes all Drafts, parent → `Manual`, clears `PlanningSessionId/Token/FinalizedAt`.
|
||||||
|
- `Task<TaskEntity?> SetPlanningStartedAsync(string taskId, string sessionToken, CancellationToken ct)` — sets parent `Status = Planning`, stores token; returns null if parent not in `Manual` state.
|
||||||
|
- `Task UpdatePlanningSessionIdAsync(string parentId, string sessionId, CancellationToken ct)` — captures Claude CLI session ID after launch.
|
||||||
|
- `Task<TaskEntity?> FindByPlanningTokenAsync(string token, CancellationToken ct)` — used by MCP auth handler.
|
||||||
|
|
||||||
|
`GetNextQueuedAgentTaskAsync` — verify the existing query filters on `Status = Queued`; no additional filter needed since Planning/Planned/Draft are different statuses. Add explicit regression test.
|
||||||
|
|
||||||
|
### 3.5 Auto-status hook
|
||||||
|
|
||||||
|
After every `MarkDoneAsync`/`MarkFailedAsync` on a task with `ParentTaskId != null`, check parent children. If all in terminal state:
|
||||||
|
- Any `Failed` → parent `Failed` with `FinishedAt = now()`.
|
||||||
|
- All `Done` (or worktrees `Discarded`) → parent `Done` with `FinishedAt = now()`.
|
||||||
|
|
||||||
|
Implemented as a private helper `TryCompleteParentAsync(string parentId, CancellationToken ct)` called at the end of the two Mark methods.
|
||||||
|
|
||||||
|
### 3.6 Migration
|
||||||
|
|
||||||
|
`dotnet ef migrations add AddPlanningSupport` — adds four columns and the `(ParentTaskId)` index. No data migration needed (new columns all nullable).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 4. MCP Server Surface
|
||||||
|
|
||||||
|
### 4.1 Transport
|
||||||
|
|
||||||
|
**HTTP (streamable) inside the existing Worker Kestrel host.** Mount on `/mcp` alongside the existing SignalR hub at `127.0.0.1:47821`. No separate process, no stdio proxy.
|
||||||
|
|
||||||
|
Library: `ModelContextProtocol` (official C# MCP SDK).
|
||||||
|
|
||||||
|
### 4.2 Authentication
|
||||||
|
|
||||||
|
Per-session bearer token:
|
||||||
|
1. `StartPlanningSessionAsync` generates a 32-byte random token, persists to `Tasks.PlanningSessionToken`.
|
||||||
|
2. Token is written into the session's `mcp.json` as `Authorization: Bearer <token>`.
|
||||||
|
3. Every MCP request passes through an auth filter that looks up the token via `FindByPlanningTokenAsync`. If found, the parent task ID is stored in the request context. If not, 401.
|
||||||
|
4. Token is invalidated (set NULL) on `finalize` or `discard`.
|
||||||
|
|
||||||
|
### 4.3 Tools
|
||||||
|
|
||||||
|
All tools are scoped to the parent task resolved from the request's token. `parent_id` is never an argument.
|
||||||
|
|
||||||
|
| Tool | Params | Returns | Effect |
|
||||||
|
|---|---|---|---|
|
||||||
|
| `create_child_task` | `title: string`, `description?: string`, `tags?: string[]`, `commit_type?: string` | `{ task_id, status: "Draft" }` | Creates a Draft child under this session's parent. |
|
||||||
|
| `list_child_tasks` | — | `[{ task_id, title, description, status, tags }]` | Lists children of this parent (in session context, always Drafts). |
|
||||||
|
| `update_child_task` | `task_id: string`, optional: `title`, `description`, `tags`, `commit_type` | `{ task }` | Errors if target is not a Draft or not a child of this parent. |
|
||||||
|
| `delete_child_task` | `task_id: string` | `{ ok: true }` | Errors if target is not a Draft or not a child of this parent. |
|
||||||
|
| `update_planning_task` | `title?: string`, `description?: string` | `{ task }` | Only title/description on the parent itself. |
|
||||||
|
| `finalize` | `queue_agent_tasks?: bool = true` | `{ finalized_count: int }` | Calls `FinalizePlanningAsync`. Token invalidated. |
|
||||||
|
|
||||||
|
### 4.4 Real-time UI
|
||||||
|
|
||||||
|
After each successful tool call, the MCP handler fires a `TaskUpdated` event on the Worker's SignalR hub. The UI subscribes as it already does; drafts appear/update live in the tasks list while the user chats with Claude in the terminal.
|
||||||
|
|
||||||
|
### 4.5 Errors
|
||||||
|
|
||||||
|
- 401 for missing/invalid token.
|
||||||
|
- MCP error `-32602` "task not found or not a child of this planning session" for cross-parent access attempts.
|
||||||
|
- MCP error `-32602` "cannot modify finalized task" for `update/delete` on non-Draft.
|
||||||
|
- Token validation short-circuits before tool dispatch.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 5. Terminal Launch & Claude CLI Invocation
|
||||||
|
|
||||||
|
### 5.1 Launcher service
|
||||||
|
|
||||||
|
New interface `IPlanningTerminalLauncher` in the UI or App layer:
|
||||||
|
```csharp
|
||||||
|
Task LaunchAsync(PlanningSessionStart info, CancellationToken ct);
|
||||||
|
Task LaunchResumeAsync(PlanningSessionResume info, CancellationToken ct);
|
||||||
|
```
|
||||||
|
|
||||||
|
`PlanningSessionStart` contains: `WorkingDir`, `McpConfigPath`, `InitialPromptPath`, `SystemPromptPath`.
|
||||||
|
`PlanningSessionResume` contains: `WorkingDir`, `McpConfigPath`, `ClaudeSessionId`.
|
||||||
|
|
||||||
|
### 5.2 Per-session files
|
||||||
|
|
||||||
|
Path: `~/.todo-app/planning-sessions/<parentTaskId>/`
|
||||||
|
- `mcp.json` — MCP config referencing the HTTP endpoint with bearer token.
|
||||||
|
- `system-prompt.md` — planning-mode system prompt (append, not replace).
|
||||||
|
- `initial-prompt.txt` — first user-visible message (title + description + short instructions).
|
||||||
|
|
||||||
|
Cleanup:
|
||||||
|
- `Discard` → remove directory.
|
||||||
|
- `Finalize` → keep directory (for audit; prune on app start if older than N days, optional).
|
||||||
|
|
||||||
|
### 5.3 `mcp.json` format
|
||||||
|
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"mcpServers": {
|
||||||
|
"claudedo": {
|
||||||
|
"type": "http",
|
||||||
|
"url": "http://127.0.0.1:47821/mcp",
|
||||||
|
"headers": { "Authorization": "Bearer <PlanningSessionToken>" }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
### 5.4 Claude CLI invocation (new session)
|
||||||
|
|
||||||
|
```
|
||||||
|
wt.exe -d "<list.WorkingDir>" cmd /k ^
|
||||||
|
claude ^
|
||||||
|
--model claude-sonnet-4-6 ^
|
||||||
|
--append-system-prompt "<contents of system-prompt.md>" ^
|
||||||
|
--mcp-config "<mcp.json absolute path>" ^
|
||||||
|
--allowedTools "mcp__claudedo__*,Read,Grep,Glob,WebFetch,WebSearch,Skill" ^
|
||||||
|
"<contents of initial-prompt.txt>"
|
||||||
|
```
|
||||||
|
|
||||||
|
### 5.5 Claude CLI invocation (resume)
|
||||||
|
|
||||||
|
```
|
||||||
|
wt.exe -d "<list.WorkingDir>" cmd /k ^
|
||||||
|
claude --resume <PlanningSessionId> --mcp-config "<mcp.json>"
|
||||||
|
```
|
||||||
|
Resume inherits model, system prompt, and allowed tools from the original session.
|
||||||
|
|
||||||
|
### 5.6 System prompt (draft, refined in Plan B)
|
||||||
|
|
||||||
|
> You are in a ClaudeDo planning session for a task. Your job is to brainstorm with the user, then break their rough intent into concrete, independently-executable child-tasks. Each child-task should be something a single automated agent can pick up and complete autonomously. Use the `mcp__claudedo__*` tools to create/update/delete drafts in real time. You may read the repository for context (Read/Grep/Glob) but must not modify any files. When the user is satisfied, call `finalize`. Skills you may find useful: `superpowers:writing-plans`, `superpowers:writing-clearly-and-concisely`.
|
||||||
|
|
||||||
|
### 5.7 Initial prompt (template)
|
||||||
|
|
||||||
|
```
|
||||||
|
<Parent task title>
|
||||||
|
|
||||||
|
<Parent task description, if any>
|
||||||
|
|
||||||
|
---
|
||||||
|
We're planning this task together. Brainstorm with me, then create concrete child-tasks via the MCP tools. I'll call `finalize` when we're done.
|
||||||
|
```
|
||||||
|
|
||||||
|
### 5.8 Unknowns to resolve during Plan B implementation
|
||||||
|
|
||||||
|
These are left **open** in this spec; they'll be pinned down during implementation via `mcp__plugin_context7_context7__query-docs` for the Claude Code CLI:
|
||||||
|
|
||||||
|
1. Exact flag for thinking budget (`--thinking-budget medium`? model suffix `claude-sonnet-4-6-thinking`? something else?).
|
||||||
|
2. Exact casing of tool names in `--allowedTools` (`Read`/`read`, `WebFetch`/`web_fetch`, `Skill`).
|
||||||
|
3. Whether `--append-system-prompt` accepts a file reference (`@path`) or requires inline string.
|
||||||
|
4. Whether Claude CLI supports a `--session-id` flag for pre-assigning the session ID, or whether we must read it back from `~/.claude/projects/<hash>/sessions/` after the process starts.
|
||||||
|
|
||||||
|
If (4) resolves to "read back", strategy:
|
||||||
|
- Poll `~/.claude/projects/<hash>/sessions/` directory modtimes shortly after launch; newest session file after launch timestamp is ours.
|
||||||
|
- Cache the result on the parent task via `UpdatePlanningSessionIdAsync`.
|
||||||
|
- If session ID can't be captured, Resume falls back to `claude --continue` (last session in that project).
|
||||||
|
|
||||||
|
### 5.9 Pre-flight checks
|
||||||
|
|
||||||
|
On `LaunchAsync`:
|
||||||
|
- `wt.exe` resolvable in PATH → else throw `PlanningLaunchException("Windows Terminal not found")`, UI shows install hint.
|
||||||
|
- `claude` resolvable in PATH → else `PlanningLaunchException("Claude CLI not installed")`.
|
||||||
|
- `list.WorkingDir` exists → else `PlanningLaunchException("Working directory not found: <path>")`.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 6. UI Changes
|
||||||
|
|
||||||
|
### 6.1 Context menu (`TaskRowView.axaml`)
|
||||||
|
|
||||||
|
New entries, conditional on status:
|
||||||
|
- `Manual` + `ParentTaskId IS NULL` → **"Open planning Session"**
|
||||||
|
- `Planning` → **"Resume planning Session"** and **"Discard planning session"**
|
||||||
|
- `Planned` / `Done` / `Failed` (parent) → no planning-related entries (7c: no re-planning).
|
||||||
|
- Children (`ParentTaskId IS NOT NULL`) → never show planning entries.
|
||||||
|
|
||||||
|
### 6.2 Hierarchy rendering (`TasksIslandView.axaml`)
|
||||||
|
|
||||||
|
Approach: **flat stream with indentation**, not a `TreeView`.
|
||||||
|
|
||||||
|
- `TasksIslandViewModel` builds `OpenItems`/`CompletedItems`/etc. as flat `ObservableCollection<TaskRowViewModel>` with parents followed by their children if expanded.
|
||||||
|
- `TaskRowViewModel` gets `IsChild: bool` and `IsPlanningParent: bool` and `IsExpanded: bool`.
|
||||||
|
- `TaskRowView` indents 24px when `IsChild`, shows a thin left border in `TextFaintBrush`.
|
||||||
|
- Parents with `IsPlanningParent` render a chevron (▸/▾) that toggles `IsExpanded`; collapsed parents hide their children from the flat stream.
|
||||||
|
- Expanded-state map kept in the VM (`Dictionary<string, bool>`, default `true`).
|
||||||
|
|
||||||
|
### 6.3 Draft and planning styling (`TaskRowView`)
|
||||||
|
|
||||||
|
- `Status = Draft` → row italic, 70% opacity, small left-aligned badge "DRAFT".
|
||||||
|
- Parent `Status = Planning` → badge "PLANNING" (accent: warning-amber).
|
||||||
|
- Parent `Status = Planned` → badge "PLANNED" (accent: neutral-blue).
|
||||||
|
|
||||||
|
### 6.4 Unfinished-session dialog
|
||||||
|
|
||||||
|
Trigger: on app start **and** on any context-menu click against a `Planning` parent.
|
||||||
|
|
||||||
|
Modal (built with existing `TaskCompletionSource<T>` dialog pattern):
|
||||||
|
|
||||||
|
```
|
||||||
|
Unfinished planning session
|
||||||
|
"<Parent title>"
|
||||||
|
<N> draft tasks waiting to be finalized.
|
||||||
|
|
||||||
|
[Resume] [Finalize now] [Discard]
|
||||||
|
```
|
||||||
|
|
||||||
|
- Resume → `ResumePlanningSessionAsync`, opens terminal with `--resume`.
|
||||||
|
- Finalize now → `FinalizePlanningSessionAsync` (server-side, no terminal). Useful when the user is confident drafts are good.
|
||||||
|
- Discard → `DiscardPlanningSessionAsync`.
|
||||||
|
|
||||||
|
### 6.5 TasksIslandViewModel commands
|
||||||
|
|
||||||
|
- `[RelayCommand] OpenPlanningSessionAsync(TaskRowViewModel? row)`
|
||||||
|
- `[RelayCommand] ResumePlanningSessionAsync(TaskRowViewModel? row)`
|
||||||
|
- `[RelayCommand] DiscardPlanningSessionAsync(TaskRowViewModel? row)`
|
||||||
|
- `[RelayCommand] FinalizePlanningSessionAsync(TaskRowViewModel? row)`
|
||||||
|
- `[RelayCommand] ToggleExpand(TaskRowViewModel parentRow)`
|
||||||
|
|
||||||
|
### 6.6 WorkerClient additions (`ClaudeDo.Ui/Services/WorkerClient.cs`)
|
||||||
|
|
||||||
|
- `Task<PlanningSessionLaunchInfo> StartPlanningSessionAsync(string taskId, CancellationToken ct)` — returns `{ WorkingDir, McpConfigPath, InitialPromptPath, SystemPromptPath }`.
|
||||||
|
- `Task<PlanningSessionResumeInfo> ResumePlanningSessionAsync(string taskId, CancellationToken ct)` — returns `{ WorkingDir, McpConfigPath, ClaudeSessionId }`.
|
||||||
|
- `Task<int> FinalizePlanningSessionAsync(string taskId, CancellationToken ct)` — returns finalized count.
|
||||||
|
- `Task DiscardPlanningSessionAsync(string taskId, CancellationToken ct)`.
|
||||||
|
- `Task<int> GetPendingDraftCountAsync(string taskId, CancellationToken ct)` — for the unfinished-session dialog.
|
||||||
|
|
||||||
|
Existing `TaskUpdated` event covers live draft updates; no new event needed.
|
||||||
|
|
||||||
|
### 6.7 Delete handling
|
||||||
|
|
||||||
|
When the user tries to delete a parent with children:
|
||||||
|
- Repository throws `DbUpdateException` (FK Restrict).
|
||||||
|
- UI catches, shows: "This task has N child tasks. Discard drafts and delete? / Delete all including children? / Cancel."
|
||||||
|
- "Delete all including children" → UI iterates children and deletes them first, then the parent.
|
||||||
|
- "Discard drafts" option only appears if parent status is `Planning` (drafts exist to discard).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 7. Lifecycle & Error Handling
|
||||||
|
|
||||||
|
### 7.1 Worker queue isolation
|
||||||
|
|
||||||
|
`GetNextQueuedAgentTaskAsync` filters on `Status = Queued` — Planning/Planned/Draft are excluded by status. Add explicit regression test to lock this in.
|
||||||
|
|
||||||
|
### 7.2 Parent auto-completion (repeat of 2, for implementation reference)
|
||||||
|
|
||||||
|
After `MarkDoneAsync`/`MarkFailedAsync`:
|
||||||
|
```csharp
|
||||||
|
if (task.ParentTaskId is not null)
|
||||||
|
await TryCompleteParentAsync(task.ParentTaskId, ct);
|
||||||
|
```
|
||||||
|
where `TryCompleteParentAsync` loads children, checks terminal status, sets parent accordingly.
|
||||||
|
|
||||||
|
### 7.3 Session-start errors
|
||||||
|
|
||||||
|
Table in §5.9 Pre-flight checks. UI receives typed exceptions, shows appropriate dialog.
|
||||||
|
|
||||||
|
### 7.4 Session-runtime errors
|
||||||
|
|
||||||
|
- Terminal crashes → drafts + token persist. Resume via dialog (§6.4).
|
||||||
|
- Worker restart → drafts + token persist. Resume rebuilds HTTP connection.
|
||||||
|
- MCP call fails transiently → Claude CLI retries or the model reports the error to the user in terminal; drafts remain in whatever state the last successful call left them.
|
||||||
|
- No session timeout — brainstorming may be long.
|
||||||
|
|
||||||
|
### 7.5 Concurrency
|
||||||
|
|
||||||
|
- Different parents → independent sessions, one token per parent.
|
||||||
|
- Same parent launched twice → `StartPlanningSessionAsync` throws; UI says "Already planning; use Resume".
|
||||||
|
- Cleanup on app exit: nothing — planning state is fully persisted in DB and files.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 8. Testing
|
||||||
|
|
||||||
|
### 8.1 Automated (in `ClaudeDo.Worker.Tests`)
|
||||||
|
|
||||||
|
**Schema & repository:**
|
||||||
|
- Migration applies cleanly on fresh DB.
|
||||||
|
- `GetChildrenAsync` returns only direct children, sorted.
|
||||||
|
- `CreateChildAsync` sets Status=Draft, ParentTaskId correctly.
|
||||||
|
- `FinalizePlanningAsync` transactionally transitions drafts to Manual/Queued, sets parent to Planned, sets timestamp, clears token. On simulated DB error, rolls back fully.
|
||||||
|
- `DiscardPlanningAsync` removes drafts, resets parent.
|
||||||
|
- `GetNextQueuedAgentTaskAsync` ignores Drafts, Planning parents, Planned parents.
|
||||||
|
- `Restrict` cascade: delete parent with children throws `DbUpdateException`.
|
||||||
|
|
||||||
|
**Auto-status hook (§7.2):**
|
||||||
|
- All children Done → parent Done.
|
||||||
|
- Mix: some Done, at least one Failed, rest in terminal state → parent Failed.
|
||||||
|
- Mix with one still Running → parent stays Planned.
|
||||||
|
- Parent stays Planned while any Draft exists (defensive — finalize should have cleared them).
|
||||||
|
|
||||||
|
**MCP handlers (against SQLite + in-process HTTP):**
|
||||||
|
- Valid token → tool executes.
|
||||||
|
- Missing/invalid token → 401.
|
||||||
|
- `create_child_task` → creates Draft, emits TaskUpdated event.
|
||||||
|
- `update_child_task` on non-Draft → MCP error.
|
||||||
|
- `delete_child_task` on non-Draft → MCP error.
|
||||||
|
- `finalize` called twice: first succeeds, second errors because token is invalidated.
|
||||||
|
- Cross-parent access: tool with `task_id` belonging to another parent's session → MCP error.
|
||||||
|
|
||||||
|
**SignalR endpoints (integration with Worker host):**
|
||||||
|
- Start → token generated, session directory + files created, `mcp.json` contains token.
|
||||||
|
- Start on already-`Planning` parent → error.
|
||||||
|
- Resume → no new token, reads `PlanningSessionId` from DB.
|
||||||
|
- Discard → drafts gone, directory removed, token NULL, parent back to Manual.
|
||||||
|
|
||||||
|
### 8.2 Manual (added to `docs/open.md` checklist)
|
||||||
|
|
||||||
|
- Windows Terminal spawn with real `wt.exe`.
|
||||||
|
- Real Claude CLI end-to-end session (requires `ANTHROPIC_API_KEY`).
|
||||||
|
- Avalonia hierarchy rendering (chevron, indentation, draft styling, badges).
|
||||||
|
- Session-ID capture from `~/.claude/projects/...` (timing-sensitive, platform-specific).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 9. Phasing
|
||||||
|
|
||||||
|
Work is delivered in **three sequential-then-parallel** plans. Plan A must merge before B and C can merge.
|
||||||
|
|
||||||
|
### 9.1 Plan A — Foundation
|
||||||
|
|
||||||
|
Schema migration, enum additions, repository methods, auto-status hook, delete-Restrict, regression test for queue filter. No UI-visible changes (other than delete-with-children now failing with a generic error until Plan C handles it).
|
||||||
|
|
||||||
|
Scope files (approximate):
|
||||||
|
- `src/ClaudeDo.Data/Models/TaskEntity.cs`
|
||||||
|
- `src/ClaudeDo.Data/Configuration/TaskEntityConfiguration.cs`
|
||||||
|
- `src/ClaudeDo.Data/Migrations/<new>_AddPlanningSupport.cs`
|
||||||
|
- `src/ClaudeDo.Data/Repositories/TaskRepository.cs` (+ `ITaskRepository`)
|
||||||
|
- `src/ClaudeDo.Worker/...` auto-status hook call-site updates.
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/...` new test classes.
|
||||||
|
|
||||||
|
### 9.2 Plan B — Worker MCP + SignalR + Launcher (starts after A merges)
|
||||||
|
|
||||||
|
MCP service with HTTP transport, token auth, six tools. New SignalR hub endpoints for Start/Resume/Discard/Finalize/GetPendingDraftCount. Session directory management. `IPlanningTerminalLauncher` implementation for `wt.exe`. Resolves the four unknowns from §5.8.
|
||||||
|
|
||||||
|
Scope files (approximate):
|
||||||
|
- `src/ClaudeDo.Worker/Planning/PlanningMcpService.cs` (new)
|
||||||
|
- `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs` (new)
|
||||||
|
- `src/ClaudeDo.Worker/Hub/WorkerHub.cs` (extend)
|
||||||
|
- `src/ClaudeDo.Worker/Program.cs` (DI + endpoint mapping)
|
||||||
|
- `src/ClaudeDo.App/` or `src/ClaudeDo.Ui/Services/` — `IPlanningTerminalLauncher` + `WindowsTerminalPlanningLauncher`.
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/Planning/...`
|
||||||
|
|
||||||
|
### 9.3 Plan C — UI (parallel to B after A merges)
|
||||||
|
|
||||||
|
Context menu entries, hierarchy rendering, draft styling, unfinished-session dialog, WorkerClient extensions, delete-with-children handling. During parallel development, mocks the WorkerClient against Plan B's interface contract.
|
||||||
|
|
||||||
|
Scope files (approximate):
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs`
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Islands/TaskRowViewModel.cs`
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/TasksIslandView.axaml`
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/TaskRowView.axaml`
|
||||||
|
- `src/ClaudeDo.Ui/Services/WorkerClient.cs`
|
||||||
|
- `src/ClaudeDo.Ui/Design/IslandStyles.axaml` (draft/badge styling)
|
||||||
|
- `src/ClaudeDo.Ui/Views/Dialogs/UnfinishedPlanningDialog.axaml` (new)
|
||||||
|
|
||||||
|
### 9.4 Integration points between B and C
|
||||||
|
|
||||||
|
Interface contract locked before parallel work begins:
|
||||||
|
- SignalR method names, parameters, return DTOs (listed in §6.6).
|
||||||
|
- `TaskUpdated` event payload unchanged; carries the task's new parent-id and status so the UI can re-bucket.
|
||||||
|
- Session directory path shape: `~/.todo-app/planning-sessions/<parentTaskId>/`.
|
||||||
|
- `mcp.json` and session-file formats are internal to Plan B; UI never reads them.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## 10. Out of scope (for now)
|
||||||
|
|
||||||
|
- Nested planning (children of children). Explicitly one level.
|
||||||
|
- Cross-list planning (parent in list A, children in list B).
|
||||||
|
- Multi-user collaboration on the same planning session.
|
||||||
|
- Session timeouts / auto-discard.
|
||||||
|
- Planning-session history / audit UI. Directory is kept on finalize but not surfaced.
|
||||||
|
- Re-planning a finalized parent (7c: no).
|
||||||
230
docs/superpowers/specs/2026-04-23-self-update-design.md
Normal file
230
docs/superpowers/specs/2026-04-23-self-update-design.md
Normal file
@@ -0,0 +1,230 @@
|
|||||||
|
# Self-Update for App and Installer — Design
|
||||||
|
|
||||||
|
**Date:** 2026-04-23
|
||||||
|
**Status:** Approved
|
||||||
|
|
||||||
|
## Goals
|
||||||
|
|
||||||
|
Give ClaudeDo two update paths:
|
||||||
|
|
||||||
|
- **A — App-side update check:** the Avalonia UI checks Gitea for a newer release on startup (and via a manual menu action) and surfaces a dismissible banner. Clicking **Update now** launches the locally installed installer in Update mode and closes the UI.
|
||||||
|
- **B — Installer self-update:** the WPF installer checks for a newer installer binary on launch and offers to replace itself before continuing. After replacement, it proceeds with its normal wizard.
|
||||||
|
|
||||||
|
Non-goals:
|
||||||
|
|
||||||
|
- No silent/background auto-apply of updates. The user always initiates the final update action.
|
||||||
|
- No periodic in-app polling (startup + manual only).
|
||||||
|
- No changes to the release pipeline — release assets (`ClaudeDo-<version>-win-x64.zip`, `ClaudeDo.Installer-<version>.exe`, `checksums.txt`) stay as they are.
|
||||||
|
|
||||||
|
## Architecture Overview
|
||||||
|
|
||||||
|
A new shared library, `ClaudeDo.Releases`, hosts the release-API client, version comparison, checksum verification, and installer self-update logic. Both `ClaudeDo.Installer` and `ClaudeDo.Ui` reference it. This removes the existing duplication between the installer's release plumbing and what the app needs, and keeps a single asset-matching / version-parsing code path.
|
||||||
|
|
||||||
|
```
|
||||||
|
ClaudeDo.Releases (new, netstandard2.0 or net8.0)
|
||||||
|
├── ReleaseClient.cs (moved from Installer/Core)
|
||||||
|
├── IReleaseClient.cs (moved)
|
||||||
|
├── ChecksumVerifier.cs (moved)
|
||||||
|
├── VersionComparer.cs (new)
|
||||||
|
└── SelfUpdater.cs (new — installer self-update mechanism)
|
||||||
|
|
||||||
|
ClaudeDo.Installer (WPF, consumes ClaudeDo.Releases)
|
||||||
|
├── App.xaml.cs (modified — SelfUpdater + --replace-self arg)
|
||||||
|
└── Core/InstallModeDetector.cs (modified — now uses VersionComparer)
|
||||||
|
|
||||||
|
ClaudeDo.Ui (Avalonia, consumes ClaudeDo.Releases)
|
||||||
|
├── Services/UpdateCheckService.cs (new)
|
||||||
|
├── Services/InstallerLocator.cs (new)
|
||||||
|
├── ViewModels/MainViewModel.cs (modified — banner + Help menu state)
|
||||||
|
└── Views/MainWindow.axaml (modified — banner + Help dropdown)
|
||||||
|
```
|
||||||
|
|
||||||
|
## Part A — App-Side Update Check
|
||||||
|
|
||||||
|
### `ClaudeDo.Ui/Services/UpdateCheckService.cs`
|
||||||
|
|
||||||
|
Responsibilities:
|
||||||
|
|
||||||
|
- Read the current app version from `Assembly.GetExecutingAssembly().GetName().Version`.
|
||||||
|
- Call `IReleaseClient.GetLatestReleaseAsync` to fetch the Gitea release.
|
||||||
|
- Use `VersionComparer` to decide whether the latest is newer.
|
||||||
|
- Expose observable properties: `IsUpdateAvailable`, `LatestVersion`, `CurrentVersion`, `IsChecking`, `LastCheckStatus` (`UpToDate | UpdateAvailable | CheckFailed | NeverChecked`).
|
||||||
|
- Expose a `CheckNowAsync` method for the manual Help menu action.
|
||||||
|
|
||||||
|
Lifecycle:
|
||||||
|
|
||||||
|
- Registered as a singleton in DI.
|
||||||
|
- Startup check is fired from `MainViewModel` once the main window is shown. It runs fire-and-forget on a background `Task`; UI never blocks on it.
|
||||||
|
- Manual check is awaited by its command and briefly shows a status message (see UI).
|
||||||
|
|
||||||
|
Error handling:
|
||||||
|
|
||||||
|
- Network / API errors → log to `~/.todo-app/logs/`, set `LastCheckStatus = CheckFailed`, do not surface a banner. Manual check shows a small inline status only.
|
||||||
|
|
||||||
|
### `ClaudeDo.Ui/Services/InstallerLocator.cs`
|
||||||
|
|
||||||
|
Responsibilities:
|
||||||
|
|
||||||
|
- Resolve the path to the installed `ClaudeDo.Installer.exe` so the UI can launch it.
|
||||||
|
|
||||||
|
Discovery strategy (first hit wins):
|
||||||
|
|
||||||
|
1. Walk up from `AppContext.BaseDirectory` looking for a sibling `install.json`. The installer is at `{installDir}/uninstaller/ClaudeDo.Installer.exe`.
|
||||||
|
2. Fall back to reading `HKLM\Software\Microsoft\Windows\CurrentVersion\Uninstall\ClaudeDo\InstallLocation` (written by the existing `WriteUninstallRegistryStep`).
|
||||||
|
|
||||||
|
If neither yields a valid path, the banner's **Update now** button is disabled with a tooltip explaining the installer could not be located.
|
||||||
|
|
||||||
|
### UI changes
|
||||||
|
|
||||||
|
**Banner** at the top of `MainView` (above content, below custom chrome):
|
||||||
|
|
||||||
|
- Visible when `UpdateCheckService.IsUpdateAvailable == true` and the user has not dismissed this session.
|
||||||
|
- Text: `Update available: v{CurrentVersion} → v{LatestVersion}`.
|
||||||
|
- Actions: `Update now` (primary), `Dismiss` (sets a transient `IsBannerDismissed` flag that resets on app restart — intentionally not persisted so the banner returns next launch if still relevant).
|
||||||
|
- Styled to match existing chrome/accent conventions (compact, dismissible, non-modal).
|
||||||
|
|
||||||
|
**Help dropdown** in the custom titlebar:
|
||||||
|
|
||||||
|
- New menu: `Help`.
|
||||||
|
- First item: `Check for updates` → binds to `MainViewModel.CheckForUpdatesCommand`, which calls `UpdateCheckService.CheckNowAsync`.
|
||||||
|
- When a check completes:
|
||||||
|
- `UpdateAvailable` → banner appears (no separate dialog).
|
||||||
|
- `UpToDate` → a brief inline status in the banner area: `You're up to date (v{CurrentVersion})`, auto-hides after ~3 seconds.
|
||||||
|
- `CheckFailed` → `Could not check for updates` inline message, auto-hides after ~3 seconds.
|
||||||
|
- Leaves room for future items (`About`, `Documentation`, etc.).
|
||||||
|
|
||||||
|
### Update action flow
|
||||||
|
|
||||||
|
1. User clicks **Update now** in the banner.
|
||||||
|
2. `MainViewModel` resolves the installer path via `InstallerLocator`.
|
||||||
|
3. UI spawns `ClaudeDo.Installer.exe` with no arguments. The installer's existing `InstallModeDetector` reads `install.json` alongside it, hits Gitea, and enters `Update` mode.
|
||||||
|
4. UI closes itself immediately after spawning the process.
|
||||||
|
5. The installer performs its standard update flow: `StopServiceStep` → `DownloadAndExtractStep` → `StartServiceStep`.
|
||||||
|
6. When the user clicks Finish the installer exits. The user re-launches the app via their existing shortcut.
|
||||||
|
|
||||||
|
No IPC between UI and installer is needed — the installer is already self-sufficient once launched against an existing install directory.
|
||||||
|
|
||||||
|
## Part B — Installer Self-Update
|
||||||
|
|
||||||
|
### `ClaudeDo.Releases/SelfUpdater.cs`
|
||||||
|
|
||||||
|
Runs from `ClaudeDo.Installer/App.xaml.cs` before any window is shown.
|
||||||
|
|
||||||
|
Flow:
|
||||||
|
|
||||||
|
1. **Handle `--replace-self` argument first.** If the installer was launched with `--replace-self "<old-path>"`:
|
||||||
|
- Wait up to 5 seconds for the old process to exit (poll for file lock release).
|
||||||
|
- Delete `<old-path>`.
|
||||||
|
- Copy own exe to `<old-path>`.
|
||||||
|
- Start a new process at `<old-path>` with no args, then exit the current (temp) process. This ensures the user's shortcut or Apps & Features entry now points at the updated binary.
|
||||||
|
- If any step fails, fall through to the normal wizard (the user still has a working installer, just in a temp location).
|
||||||
|
|
||||||
|
2. **Check for a newer installer.** If no `--replace-self` arg:
|
||||||
|
- Parse own assembly version.
|
||||||
|
- Fetch latest release.
|
||||||
|
- Find the installer asset matching `ClaudeDo.Installer-<version>.exe` (regex: `^ClaudeDo\.Installer-(?<version>[\d\.]+)\.exe$`).
|
||||||
|
- Compare via `VersionComparer`.
|
||||||
|
- If not newer, or if check fails, proceed to the normal wizard (existing Config-mode fallback behavior).
|
||||||
|
|
||||||
|
3. **Prompt if newer.** Show a small modal dialog (plain WPF `Window`, reusing the installer's titlebar/accent styles):
|
||||||
|
> *"A newer installer is available: v{latest}. Update before continuing?"*
|
||||||
|
> `[Update] [Continue anyway] [Cancel]`
|
||||||
|
|
||||||
|
- **Cancel** → `Application.Current.Shutdown(0)`.
|
||||||
|
- **Continue anyway** → proceed to normal wizard.
|
||||||
|
- **Update** → run relaunch sequence.
|
||||||
|
|
||||||
|
4. **Relaunch sequence:**
|
||||||
|
- Download to `%TEMP%\ClaudeDo.Installer-<version>.exe` (show a minimal inline progress UI; no separate window).
|
||||||
|
- Verify against `checksums.txt` from the release via `ChecksumVerifier`. On failure, show error with `[Continue with current installer]` action → proceed to wizard.
|
||||||
|
- `Process.Start` new exe with args `--replace-self "<current-exe-path>"`.
|
||||||
|
- Exit current process.
|
||||||
|
|
||||||
|
### Why `--replace-self` rather than a shell script
|
||||||
|
|
||||||
|
A child process holding a handle to the new exe is reliable cross-Windows-version. Relying on a `.bat` or `cmd /c` helper leaves a file that we would need to clean up, and behaves badly when the installer was launched from a mounted share or non-ASCII path. The `--replace-self` approach keeps everything in managed code and uses a single exe throughout.
|
||||||
|
|
||||||
|
### Edge case: running from `uninstaller/` copy
|
||||||
|
|
||||||
|
When the installer runs from `{installDir}/uninstaller/ClaudeDo.Installer.exe` (via the app's **Update now** or from Apps & Features), the self-update flow is identical. It is desirable for the uninstaller copy to be kept current — stale uninstaller binaries would otherwise drift behind and could have bugs the new app release expects fixed.
|
||||||
|
|
||||||
|
## Version Comparison (`VersionComparer`)
|
||||||
|
|
||||||
|
Centralizes the logic currently in `InstallModeDetector.IsNewer`:
|
||||||
|
|
||||||
|
- Parses both versions as `System.Version` after trimming a leading `v` / `V`.
|
||||||
|
- Returns `(bool isNewer, bool unparseable)`.
|
||||||
|
- Unparseable (e.g. `0.2.0-beta`) → treated as not newer; callers can surface a hint if desired.
|
||||||
|
|
||||||
|
Both `InstallModeDetector` (existing behavior) and `SelfUpdater` / `UpdateCheckService` (new callers) share this logic.
|
||||||
|
|
||||||
|
## Error Handling Summary
|
||||||
|
|
||||||
|
| Scenario | App behavior | Installer behavior |
|
||||||
|
|---|---|---|
|
||||||
|
| Gitea unreachable | Silent; log to file; no banner | Silent; skip self-update; proceed to wizard |
|
||||||
|
| JSON parse error | Same as unreachable | Same as unreachable |
|
||||||
|
| Version unparseable | No banner; log a hint | No prompt; proceed |
|
||||||
|
| Installer exe not found on disk | `Update now` button disabled with tooltip | N/A |
|
||||||
|
| Download fails | N/A (app delegates to installer) | Error dialog with `[Continue with current installer]` |
|
||||||
|
| Checksum mismatch | N/A | Error dialog with `[Continue with current installer]` |
|
||||||
|
| Relaunch fails | N/A | Error dialog; user keeps temp exe and current exe both |
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
**New test project: `tests/ClaudeDo.Releases.Tests`**
|
||||||
|
|
||||||
|
- `ReleaseClientTests` — move existing installer tests covering `GetLatestReleaseAsync` and `DownloadAsync`.
|
||||||
|
- `VersionComparerTests` — boundary cases (equal, newer, older, unparseable, mixed `v`-prefix).
|
||||||
|
- `SelfUpdaterTests`:
|
||||||
|
- Asset-name regex correctly isolates version from `ClaudeDo.Installer-0.3.0.exe` and ignores `ClaudeDo-0.3.0-win-x64.zip`.
|
||||||
|
- Decision logic given mocked `IReleaseClient` responses.
|
||||||
|
- `--replace-self` handler: given a temp dummy file, the handler waits, deletes, copies — verified with a mock filesystem / temp dir.
|
||||||
|
|
||||||
|
**Existing project: `tests/ClaudeDo.Installer.Tests`**
|
||||||
|
|
||||||
|
- `SelfUpdateIntegrationTest`: build the installer, invoke it with `--replace-self <dummy>` pointing at a temp file, assert the dummy is replaced by a copy of the test installer, and the process exits cleanly. Run only on Windows CI.
|
||||||
|
|
||||||
|
**App tests (`tests/ClaudeDo.Ui.Tests` — add if absent):**
|
||||||
|
|
||||||
|
- `UpdateCheckServiceTests` — stubbed `IReleaseClient`, assert state transitions for each status.
|
||||||
|
- `InstallerLocatorTests` — fake filesystem, verify walk-up and registry-fallback discovery.
|
||||||
|
|
||||||
|
**Manual verification** (add to `docs/open.md`):
|
||||||
|
|
||||||
|
1. Build `v0.2.x` installer and upload to a test Gitea release.
|
||||||
|
2. Tag `v0.3.0` with new installer asset.
|
||||||
|
3. Install `v0.2.x`, run the `v0.2.x` installer again — confirm self-update prompt appears and replaces the binary in place.
|
||||||
|
4. With `v0.2.x` installed and a v0.3.0 release published, launch the app — confirm banner appears, **Update now** launches installer, update completes, app relaunches at v0.3.0.
|
||||||
|
5. Pull the network during check in both places — confirm silent fallback, no user-visible errors.
|
||||||
|
|
||||||
|
## Files Summary
|
||||||
|
|
||||||
|
**New:**
|
||||||
|
|
||||||
|
- `src/ClaudeDo.Releases/ClaudeDo.Releases.csproj`
|
||||||
|
- `src/ClaudeDo.Releases/ReleaseClient.cs` (moved)
|
||||||
|
- `src/ClaudeDo.Releases/IReleaseClient.cs` (moved)
|
||||||
|
- `src/ClaudeDo.Releases/ChecksumVerifier.cs` (moved)
|
||||||
|
- `src/ClaudeDo.Releases/VersionComparer.cs` (new)
|
||||||
|
- `src/ClaudeDo.Releases/SelfUpdater.cs` (new)
|
||||||
|
- `src/ClaudeDo.Ui/Services/UpdateCheckService.cs`
|
||||||
|
- `src/ClaudeDo.Ui/Services/InstallerLocator.cs`
|
||||||
|
- `tests/ClaudeDo.Releases.Tests/ClaudeDo.Releases.Tests.csproj`
|
||||||
|
|
||||||
|
**Modified:**
|
||||||
|
|
||||||
|
- `src/ClaudeDo.Installer/App.xaml.cs` — self-update run + `--replace-self` handling before wizard.
|
||||||
|
- `src/ClaudeDo.Installer/Core/InstallModeDetector.cs` — use shared `VersionComparer`; drop now-moved types.
|
||||||
|
- `src/ClaudeDo.Installer/ClaudeDo.Installer.csproj` — reference `ClaudeDo.Releases`.
|
||||||
|
- `src/ClaudeDo.Ui/ClaudeDo.Ui.csproj` — reference `ClaudeDo.Releases`.
|
||||||
|
- `src/ClaudeDo.Ui/Views/MainWindow.axaml` — banner + Help menu dropdown.
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/MainViewModel.cs` — banner state, `CheckForUpdatesCommand`, wiring to `UpdateCheckService`.
|
||||||
|
- `src/ClaudeDo.App/Program.cs` (or existing DI composition root) — register `UpdateCheckService`, `InstallerLocator`, `IReleaseClient`, `HttpClient`.
|
||||||
|
- `ClaudeDo.slnx` — add new projects.
|
||||||
|
- `docs/open.md` — add manual verification checklist.
|
||||||
|
|
||||||
|
## Open Decisions Deferred to Implementation
|
||||||
|
|
||||||
|
- Exact Avalonia styling/layout of the banner is left to implementation to match the existing chrome polish pass from commit `3c420ac`.
|
||||||
|
- The Help dropdown control type (Avalonia `MenuItem` inside a `Menu`, or a custom flyout) is chosen during implementation based on what fits the current custom titlebar.
|
||||||
121
docs/superpowers/specs/2026-04-23-worker-log-footer-design.md
Normal file
121
docs/superpowers/specs/2026-04-23-worker-log-footer-design.md
Normal file
@@ -0,0 +1,121 @@
|
|||||||
|
# Worker Log Footer — Design
|
||||||
|
|
||||||
|
Date: 2026-04-23
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Surface important Worker lifecycle events (worktree created, Claude started, merged, etc.) in the UI footer as a single rotating, color-coded line. Gives the user ambient awareness of what the Worker just did without opening task details.
|
||||||
|
|
||||||
|
## Non-Goals
|
||||||
|
|
||||||
|
- No log history, drawer, or scrollback
|
||||||
|
- No filtering or user-configurable verbosity
|
||||||
|
- No persistence across UI restarts
|
||||||
|
- No replay of events missed while UI was disconnected
|
||||||
|
|
||||||
|
## UX
|
||||||
|
|
||||||
|
Footer (`MainWindow.axaml`, row 2) layout changes from `StackPanel` to `DockPanel`:
|
||||||
|
|
||||||
|
- **Docked left:** existing connection pill (ellipse + `ONLINE/OFFLINE/RECONNECTING` text). The static `· WORKER` label is removed; the rotating log line replaces its purpose.
|
||||||
|
- **Docked right:** rotating worker-log line.
|
||||||
|
|
||||||
|
Line format: `14:32 · <message>`, rendered in the mono font at size 10 (matches existing footer typography). `TextTrimming="CharacterEllipsis"` so long task titles don't push out the connection pill.
|
||||||
|
|
||||||
|
The line is hidden when no event has been received within the last 30 seconds. Each new event replaces the current text and resets the 30-second timer. Timestamp is local time, `HH:mm`.
|
||||||
|
|
||||||
|
### Color mapping
|
||||||
|
|
||||||
|
Level is rendered via a `WorkerLogLevelToBrushConverter` (mirrors existing `StatusColorConverter` pattern):
|
||||||
|
|
||||||
|
| Level | Brush / color | Events |
|
||||||
|
|-----------|------------------------|-----------------------------------------------------|
|
||||||
|
| `Info` | `TextDimBrush` (dim) | Created worktree, Started Claude, Committed changes |
|
||||||
|
| `Success` | `#4CAF50` green | Merged, Finished (done) |
|
||||||
|
| `Warn` | `#FFA726` amber | Discarded worktree, Reset |
|
||||||
|
| `Error` | `#EF5350` red | Finished (failed) |
|
||||||
|
|
||||||
|
## Event Catalog
|
||||||
|
|
||||||
|
Seven emit sites. Each is added alongside the existing `_logger.LogInformation(...)` call — no log-sink plumbing, no central event bus.
|
||||||
|
|
||||||
|
| Site | Level | Message |
|
||||||
|
|-------------------------------------------|-----------|-----------------------------------------|
|
||||||
|
| `WorktreeManager.CreateAsync` | `Info` | `Created worktree for "<title>"` |
|
||||||
|
| `WorktreeManager.DiscardAsync` | `Warn` | `Discarded worktree for "<title>"` |
|
||||||
|
| `TaskMergeService.MergeAsync` | `Success` | `Merged "<title>" into <target>` |
|
||||||
|
| `TaskResetService.ResetAsync` | `Warn` | `Reset "<title>"` |
|
||||||
|
| `TaskRunner` — Claude launch | `Info` | `Started Claude for "<title>"` |
|
||||||
|
| `TaskRunner` — auto-commit | `Info` | `Committed changes in "<title>"` |
|
||||||
|
| `TaskRunner` — task finished | `Success` / `Error` | `Finished "<title>" (<status>)` |
|
||||||
|
|
||||||
|
`<title>` is the task's display title; `<target>` is the merge target branch; `<status>` is `done` or `failed`.
|
||||||
|
|
||||||
|
## Architecture
|
||||||
|
|
||||||
|
### Shared contract (`ClaudeDo.Data`)
|
||||||
|
|
||||||
|
New enum:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
namespace ClaudeDo.Data.Models;
|
||||||
|
|
||||||
|
public enum WorkerLogLevel
|
||||||
|
{
|
||||||
|
Info,
|
||||||
|
Success,
|
||||||
|
Warn,
|
||||||
|
Error,
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
SignalR is configured to serialize enums as strings via `JsonStringEnumConverter` (added to the hub's JSON options in `Program.cs`). The UI client deserializes back to the same enum.
|
||||||
|
|
||||||
|
### Server side (`ClaudeDo.Worker`)
|
||||||
|
|
||||||
|
`HubBroadcaster` gets a new method:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public Task WorkerLog(string message, WorkerLogLevel level, DateTime timestampUtc) =>
|
||||||
|
_hub.Clients.All.SendAsync("WorkerLog", message, level, timestampUtc);
|
||||||
|
```
|
||||||
|
|
||||||
|
`HubBroadcaster` is already injected into `TaskRunner`. For `WorktreeManager`, `TaskMergeService`, and `TaskResetService`, add constructor injection where it isn't already present. Each emit site calls `_broadcaster.WorkerLog(...)` with `DateTime.UtcNow` next to the existing `_logger.LogInformation(...)`.
|
||||||
|
|
||||||
|
### Client side (`ClaudeDo.Ui`)
|
||||||
|
|
||||||
|
**`WorkerClient`** — register a `HubConnection.On<string, WorkerLogLevel, DateTime>("WorkerLog", ...)` handler and expose a `WorkerLogReceived` event with a small `WorkerLogEntry(string Message, WorkerLogLevel Level, DateTime TimestampUtc)` record.
|
||||||
|
|
||||||
|
**Footer VM** — `StatusBarViewModel` already exists; extend it (or introduce a small `FooterViewModel` if `StatusBarViewModel` turns out to be scoped elsewhere — confirm during implementation). Add:
|
||||||
|
|
||||||
|
- `[ObservableProperty] string? currentEventText`
|
||||||
|
- `[ObservableProperty] WorkerLogLevel currentEventLevel`
|
||||||
|
- `[ObservableProperty] bool isEventVisible`
|
||||||
|
- A `DispatcherTimer` with a 30-second interval. On each `WorkerLogReceived`:
|
||||||
|
1. Format `HH:mm · <message>` from the event's local time.
|
||||||
|
2. Set `CurrentEventText`, `CurrentEventLevel`, `IsEventVisible = true`.
|
||||||
|
3. Stop and restart the timer.
|
||||||
|
- On timer tick: `IsEventVisible = false`, `CurrentEventText = null`.
|
||||||
|
|
||||||
|
**XAML** — `MainWindow.axaml` footer `StackPanel` becomes a `DockPanel`. Existing ellipses + connection text dock left in a horizontal `StackPanel`. A new `TextBlock` docks right, bound to `CurrentEventText` with `Foreground="{Binding CurrentEventLevel, Converter={StaticResource WorkerLogLevelToBrush}}"`, `IsVisible="{Binding IsEventVisible}"`, and `TextTrimming="CharacterEllipsis"`. Same mono font / size 10 as the rest of the footer.
|
||||||
|
|
||||||
|
**Converter** — `WorkerLogLevelToBrushConverter` in `Converters/` returns a brush per enum value, resolving theme brushes via `Application.Current.Resources` for `Info` (to honor theme swaps) and hard-coding the success/warn/error hex values (those are already hard-coded in the current footer).
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
- Unit test `WorkerLogLevelToBrushConverter` with each enum value.
|
||||||
|
- Unit test the footer VM: receiving an event sets text/level/visibility and schedules a clear; a second event within 30s replaces and resets the timer; after 30s of silence the line hides.
|
||||||
|
- Manual smoke: run a task end-to-end and confirm each of the seven events surfaces with the expected color and copy.
|
||||||
|
|
||||||
|
## Edge Cases
|
||||||
|
|
||||||
|
- **UI disconnected during an event:** event is lost. Acceptable — reconnect resumes receiving new events.
|
||||||
|
- **Burst of events:** each replaces the previous; only the most recent is shown.
|
||||||
|
- **Long task title:** ellipsized by the TextBlock; connection pill on the left stays fully visible.
|
||||||
|
- **Clock skew between Worker and UI:** timestamp is formatted in UI's local time from the wire-format `DateTime` (sent as UTC). Minor skew is cosmetic; no correctness impact.
|
||||||
|
|
||||||
|
## Out of Scope / Future
|
||||||
|
|
||||||
|
- Click-to-expand history drawer
|
||||||
|
- Per-list or per-task event filtering
|
||||||
|
- Persisting the most recent N events across restarts
|
||||||
197
docs/superpowers/specs/2026-04-24-planning-merge-all-design.md
Normal file
197
docs/superpowers/specs/2026-04-24-planning-merge-all-design.md
Normal file
@@ -0,0 +1,197 @@
|
|||||||
|
# Planning Merge-All & Subtask Visibility — Design
|
||||||
|
|
||||||
|
**Date:** 2026-04-24
|
||||||
|
**Status:** Approved design, ready for implementation planning
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
Three concrete issues with the current Planning feature:
|
||||||
|
|
||||||
|
1. **Queued subtasks are not visible in the Queue List.** When a planning session finalizes, its subtasks transition to `Queued`, but the Queue List's hierarchy rules only show children when their Planning parent is expanded. A collapsed (or already-`Planned`) parent effectively hides the subtasks.
|
||||||
|
2. **Completed subtasks vanish from view.** Once a subtask becomes `Done`, the regroup logic moves it to the "Completed" bucket. Users expect subtasks to remain visible under their Planning parent until the Planning task itself is marked Done.
|
||||||
|
3. **No aggregated view or bulk merge.** Each subtask must be merged individually through its worktree. There is no way to see a combined diff of all changes produced by a Planning session, and no "merge everything" action.
|
||||||
|
|
||||||
|
## Goals
|
||||||
|
|
||||||
|
- Treat Planning subtasks as belonging to their Planning parent for visibility and lifecycle purposes.
|
||||||
|
- Provide a single aggregated diff view that shows all changes produced by a Planning session.
|
||||||
|
- Provide a single "Merge all" action that sequentially merges all subtasks, with a usable conflict-resolution flow.
|
||||||
|
- Auto-complete the Planning task when all merges succeed.
|
||||||
|
|
||||||
|
## Non-goals
|
||||||
|
|
||||||
|
- Building a full-featured in-app diff editor. Textual unified diff is acceptable for now; conflict *editing* happens in VS Code.
|
||||||
|
- Persisting Merge-all progress across worker restarts. Restart clears in-memory orchestration state; user re-starts Merge-all (already-merged subtasks are skipped because their worktrees are `Merged`).
|
||||||
|
- Modifying how individual subtasks are created, executed, or finalized.
|
||||||
|
|
||||||
|
## Design
|
||||||
|
|
||||||
|
### 1. Visibility model
|
||||||
|
|
||||||
|
Planning subtasks are exclusively children of their Planning parent until the Planning task transitions to `Done`. The Planning parent acts as a roll-up in the Queue List.
|
||||||
|
|
||||||
|
- Tasks with a non-null `ParentTaskId` are excluded from all virtual lists (`virtual:queued`, `virtual:running`, `CompletedItems`, etc.) as separate rows.
|
||||||
|
- A Planning/Planned task is included in `virtual:queued` if **any** child is `Queued`, and in `virtual:running` if any child is `Running`.
|
||||||
|
- Children are always attached under their parent in the task tree; expansion purely controls visual collapse.
|
||||||
|
- When Merge-all completes successfully, the Planning task is set to `Done` and the entire subtree moves to Completed together.
|
||||||
|
- Status badge on the Planning row summarizes children (e.g., `3/5 queued`, `2 running`, `1 failed`).
|
||||||
|
|
||||||
|
### 2. Planning detail panel
|
||||||
|
|
||||||
|
Extends the existing task detail view. New elements when the selected task is a Planning task:
|
||||||
|
|
||||||
|
- **Subtasks list.** Grouped by status badge (Queued / Running / Done / Failed). Each row preserves existing per-subtask actions (view logs, open worktree, individual merge).
|
||||||
|
- **Merge target dropdown.** Single target branch that applies to all subtasks in Merge-all. Defaults to the branch that was current when the Planning session started.
|
||||||
|
- **`[Review combined diff]` button.** Opens the Aggregated Diff Viewer. Enabled as soon as any subtask has produced a diff.
|
||||||
|
- **`[Merge all subtasks]` button.** Orchestrates sequential merge + auto-Done. Disabled until every subtask is `Done` and every worktree is `Active` or `Merged` (no `Discarded` / `Kept`). Tooltip explains why when disabled (e.g., "2 subtasks still running", "1 subtask failed — resolve first", "1 worktree was discarded").
|
||||||
|
- Existing per-subtask merge action remains available; Merge-all is additive.
|
||||||
|
|
||||||
|
### 3. Aggregated diff viewer
|
||||||
|
|
||||||
|
New Avalonia view `PlanningDiffView` + `PlanningDiffViewModel`, opened as a modal or dedicated tab.
|
||||||
|
|
||||||
|
**Default — grouped by subtask:**
|
||||||
|
- Left pane: subtask list in creation order with `title • +added −deleted • N files`.
|
||||||
|
- Right pane: selected subtask's diff. Reuse any existing diff-rendering control; if none exists, render unified diff text with basic syntax coloring (monospace, minimal decoration).
|
||||||
|
- Summary stats come from `WorktreeEntity.DiffStat`. Raw diff comes from `git diff <base>..<head>` executed in each subtask's worktree via `GitService`. Cached in memory per subtask until the subtask's HEAD moves.
|
||||||
|
|
||||||
|
**Toggle — "Preview combined diff":**
|
||||||
|
- Calls `PlanningAggregator.BuildIntegrationBranchAsync(planningTaskId, targetBranch, ct)`:
|
||||||
|
1. Create/reset branch `planning/<slug>-integration` off the current merge target.
|
||||||
|
2. Merge each subtask's branch sequentially with `--no-ff`.
|
||||||
|
3. On conflict during preview: abort the merge, reset the integration branch, surface a warning identifying which two subtasks conflict. Grouped view remains available.
|
||||||
|
4. On success: compute `git diff <merge-target>..planning/<slug>-integration` and render as a single flat unified diff.
|
||||||
|
- Toggle flips back to grouped mode.
|
||||||
|
|
||||||
|
**Integration-branch lifecycle:** scratch artifact, rebuilt on every preview (deleted + recreated). Cleaned up when the Planning task is marked `Done` or when the Planning session is discarded.
|
||||||
|
|
||||||
|
### 4. Merge-all orchestration
|
||||||
|
|
||||||
|
**Happy path (`PlanningMergeOrchestrator.StartAsync`):**
|
||||||
|
|
||||||
|
1. Pre-flight checks — fail fast with a clear message on any:
|
||||||
|
- Every subtask is `Done`.
|
||||||
|
- Every subtask's worktree is `Active` or `Merged` (no `Discarded` / `Kept`). `Merged` worktrees are allowed so that an interrupted Merge-all can be restarted.
|
||||||
|
- Repo working tree is clean.
|
||||||
|
- No mid-merge in progress in the target repo.
|
||||||
|
2. For each subtask in creation order, skip if its worktree is already `Merged` (idempotent restart). Otherwise call `TaskMergeService.MergeAsync` with `removeWorktree: true` and `leaveConflictsInTree: true`. Each success flips the worktree to `Merged`.
|
||||||
|
3. After the last successful merge:
|
||||||
|
- Set Planning task `Status = Done`.
|
||||||
|
- Call `PlanningAggregator.CleanupIntegrationBranchAsync` if the integration branch exists.
|
||||||
|
- Emit `PlanningCompleted` so the UI removes the row from the Queue List.
|
||||||
|
|
||||||
|
**Conflict path:**
|
||||||
|
|
||||||
|
1. `MergeAsync` with `leaveConflictsInTree: true` reports a conflict, leaves the repo in a mid-merge state, and returns the conflicted file paths (`git diff --name-only --diff-filter=U`).
|
||||||
|
2. Orchestrator halts the loop, stores the in-progress state (remaining subtasks, target branch, current subtask id) in memory, and emits `PlanningMergeConflict(planningTaskId, subtaskId, conflictedFiles)`.
|
||||||
|
3. The UI opens the **Conflict Resolution dialog** — see §5.
|
||||||
|
4. On `ContinueAsync`: calls `TaskMergeService.ContinueMergeAsync(subtaskId)` which stages the recorded files and runs `git commit --no-edit`. Flips worktree to `Merged`. Loop resumes with remaining subtasks.
|
||||||
|
5. On `AbortAsync`: calls `TaskMergeService.AbortMergeAsync(subtaskId)` which runs `git merge --abort`. Planning stays in `Planned`. Already-merged earlier subtasks remain `Merged`. Orchestration state cleared.
|
||||||
|
|
||||||
|
**Idempotent restart:** if the worker restarts mid Merge-all, in-memory state is lost. A fresh `StartAsync` re-runs pre-flight; already-`Merged` worktrees are skipped by the loop (their status gates them out). User experience: "I clicked Merge all again and it continued from where it left off."
|
||||||
|
|
||||||
|
### 5. Conflict Resolution dialog
|
||||||
|
|
||||||
|
Avalonia modal (`ConflictResolutionView` + `ConflictResolutionViewModel`).
|
||||||
|
|
||||||
|
- **Header:** `Conflicts in subtask: <title> merging into <target-branch>`.
|
||||||
|
- **File list:** full absolute paths of conflicted files.
|
||||||
|
- **`[Open all in VS Code]`** — for each file, spawn `code <absolute-path>` via `Process.Start`. If `code` is not on PATH, show an inline error row with the file list so the user can copy paths manually. No popup-on-popup.
|
||||||
|
- **`[I've resolved — continue]`** — calls `ContinuePlanningMerge(planningTaskId)` hub method, closes dialog. The orchestration loop continues with the remaining subtasks.
|
||||||
|
- **`[Abort this merge]`** — calls `AbortPlanningMerge(planningTaskId)` hub method, closes dialog. Planning stays `Planned`.
|
||||||
|
|
||||||
|
### 6. Data model
|
||||||
|
|
||||||
|
**No schema changes.**
|
||||||
|
- Conflicted files are queried from git on demand (`git diff --name-only --diff-filter=U`) while the merge is in progress.
|
||||||
|
- Integration branch name is derived from the Planning task slug: `planning/<slug>-integration`.
|
||||||
|
- Planning completion uses existing `TaskStatus.Done`.
|
||||||
|
|
||||||
|
### 7. Services
|
||||||
|
|
||||||
|
**New:**
|
||||||
|
|
||||||
|
- **`PlanningAggregator`** (`src/ClaudeDo.Worker/Planning/PlanningAggregator.cs`)
|
||||||
|
- `GetAggregatedDiffAsync(planningTaskId, ct)` — returns per-subtask diff entries.
|
||||||
|
- `BuildIntegrationBranchAsync(planningTaskId, targetBranch, ct)` — creates/resets the integration branch, merges subtasks sequentially, returns `(success, combinedDiff)` or `(failure, firstConflictSubtaskId, conflictedFiles)`. Always leaves the integration branch in a consistent state (aborts + resets on failure).
|
||||||
|
- `CleanupIntegrationBranchAsync(planningTaskId, ct)` — deletes the integration branch.
|
||||||
|
|
||||||
|
- **`PlanningMergeOrchestrator`** (singleton, `src/ClaudeDo.Worker/Planning/PlanningMergeOrchestrator.cs`)
|
||||||
|
- Owns in-memory state per planning task: `{ remainingSubtasks, targetBranch, currentSubtaskId }`.
|
||||||
|
- `StartAsync(planningTaskId, targetBranch)`, `ContinueAsync(planningTaskId)`, `AbortAsync(planningTaskId)`.
|
||||||
|
- Emits SignalR events: `PlanningMergeStarted`, `PlanningSubtaskMerged`, `PlanningMergeConflict`, `PlanningMergeAborted`, `PlanningCompleted`.
|
||||||
|
|
||||||
|
**Modified:**
|
||||||
|
|
||||||
|
- **`TaskMergeService`**
|
||||||
|
- `MergeAsync` gets a `leaveConflictsInTree: bool` parameter (default `false`). When `true`, on conflict records conflicted files on the returned result, does **not** call `git merge --abort`.
|
||||||
|
- New `ContinueMergeAsync(taskId, ct)` — stages the recorded conflicted files and runs `git commit --no-edit`, flips worktree to `Merged`.
|
||||||
|
- New `AbortMergeAsync(taskId, ct)` — runs `git merge --abort`, restores pre-merge state.
|
||||||
|
- Existing callers unaffected by the default.
|
||||||
|
|
||||||
|
- **`WorkerHub`** — new methods:
|
||||||
|
- `GetPlanningAggregate(planningTaskId)`
|
||||||
|
- `BuildPlanningIntegrationBranch(planningTaskId, targetBranch)`
|
||||||
|
- `MergeAllPlanning(planningTaskId, targetBranch)`
|
||||||
|
- `ContinuePlanningMerge(planningTaskId)`
|
||||||
|
- `AbortPlanningMerge(planningTaskId)`
|
||||||
|
|
||||||
|
- **`TasksIslandViewModel.Regroup`**
|
||||||
|
- Exclude tasks with `ParentTaskId != null` from virtual lists.
|
||||||
|
- Include Planning parents in `virtual:queued` / `virtual:running` based on children's statuses.
|
||||||
|
- Keep children attached to parent in the tree at all times until Planning is `Done`.
|
||||||
|
|
||||||
|
### 8. UI components (new)
|
||||||
|
|
||||||
|
- `PlanningDiffView` + `PlanningDiffViewModel` — aggregated diff viewer (§3).
|
||||||
|
- `ConflictResolutionView` + `ConflictResolutionViewModel` — conflict dialog (§5).
|
||||||
|
- Planning Detail section inside the existing task detail pane — subtask list + merge target dropdown + two buttons (§2).
|
||||||
|
|
||||||
|
## Error handling
|
||||||
|
|
||||||
|
- **Pre-flight failures** — surface as inline errors in the Planning detail panel. No merge work attempted.
|
||||||
|
- **Preview-build conflict** — keep grouped diff available; show a warning banner identifying the conflicting pair of subtasks.
|
||||||
|
- **Merge-all conflict** — Conflict Resolution dialog (§5). The failed subtask's worktree stays `Active`; prior successes stay `Merged`.
|
||||||
|
- **VS Code not on PATH** — inline error row in the Conflict dialog with copyable file paths.
|
||||||
|
- **Worker restart mid-merge** — in-memory state lost; restarting Merge-all is idempotent because merged worktrees are skipped by status gating.
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
Convention: xUnit integration tests with real SQLite and real git (`tests/ClaudeDo.Worker.Tests`).
|
||||||
|
|
||||||
|
**`PlanningAggregatorTests`** — real git fixture
|
||||||
|
- `GetAggregatedDiffAsync` returns one entry per subtask with correct stats.
|
||||||
|
- `BuildIntegrationBranchAsync` with non-conflicting subtasks — success, branch contains all changes.
|
||||||
|
- `BuildIntegrationBranchAsync` with conflicting subtasks — failure, branch reset (not mid-merge), correct subtask id and file list reported.
|
||||||
|
- Rebuild overwrites a stale integration branch.
|
||||||
|
- `CleanupIntegrationBranchAsync` removes the branch.
|
||||||
|
|
||||||
|
**`PlanningMergeOrchestratorTests`** — real git + real DB
|
||||||
|
- Happy path: all subtasks merge → worktrees `Merged`, Planning `Done`, `PlanningCompleted` emitted.
|
||||||
|
- Conflict path: first subtask conflicts → repo left in conflict state, `PlanningMergeConflict` emitted with correct file list, worktree stays `Active`, Planning stays `Planned`.
|
||||||
|
- `ContinueAsync` after conflict: resolution commits, loop proceeds, final state `Done`.
|
||||||
|
- `AbortAsync` after conflict: `merge --abort` restores clean state, earlier merged subtasks remain `Merged`, Planning stays `Planned`.
|
||||||
|
- Pre-flight rejection: running subtask, failed subtask, dirty repo — each returns the expected error with no side effects.
|
||||||
|
- Idempotent restart: partial merge + fresh `StartAsync` — already-`Merged` worktrees skipped.
|
||||||
|
|
||||||
|
**`TaskMergeServiceConflictTests`** (extending existing tests)
|
||||||
|
- `MergeAsync(leaveConflictsInTree: true)` on conflict: no `merge --abort`, returns conflicted files, worktree state unchanged.
|
||||||
|
- `ContinueMergeAsync`: completes in-progress merge, flips worktree to `Merged`.
|
||||||
|
- `AbortMergeAsync`: runs `merge --abort`, restores clean state.
|
||||||
|
|
||||||
|
**`TasksIslandRegroupTests`** — ViewModel unit tests, no DB
|
||||||
|
- Queued subtask with a Planning parent is NOT in `virtual:queued` as its own row.
|
||||||
|
- Planning parent with any Queued child IS in `virtual:queued`.
|
||||||
|
- Done subtask stays nested under Planning parent until Planning is `Done`.
|
||||||
|
- After Planning is marked `Done`, parent + children move to Completed together.
|
||||||
|
|
||||||
|
**Manual smoke test** (documented in PR description):
|
||||||
|
- End-to-end planning session in the app: create plan, finalize, let subtasks run.
|
||||||
|
- Open aggregated diff, toggle Preview combined.
|
||||||
|
- Merge-all happy path.
|
||||||
|
- Merge-all conflict path with VS Code dialog open/continue.
|
||||||
|
- Merge-all conflict path abort.
|
||||||
|
|
||||||
|
## Open questions
|
||||||
|
|
||||||
|
None at this stage. All decisions from the brainstorming session are captured above.
|
||||||
@@ -0,0 +1,95 @@
|
|||||||
|
# Planning UX Polish + Sequential Subtask Queue
|
||||||
|
|
||||||
|
**Status:** design
|
||||||
|
**Date:** 2026-04-24
|
||||||
|
**Scope:** three small UX changes + one feature — sequential execution of planning subtasks triggered from the context menu.
|
||||||
|
|
||||||
|
## Goals
|
||||||
|
|
||||||
|
1. Collapse the children of a finished planning-parent row in the task list by default.
|
||||||
|
2. Allow the user to collapse the Description section in the Details pane.
|
||||||
|
3. Halve the width of the GridSplitters between islands.
|
||||||
|
4. Let the user queue all subtasks of a planning parent so they run one after another, with a new `Waiting` status for pending siblings.
|
||||||
|
|
||||||
|
## 1. Auto-collapse done planning parents
|
||||||
|
|
||||||
|
**Rule for "done":** a planning parent is "done" when every one of its children has `Status == Done`.
|
||||||
|
|
||||||
|
**Changes:**
|
||||||
|
- `TaskRowViewModel`: add UI-only `[ObservableProperty] bool _areChildrenExpanded`. Default computed from status — `false` when the row is a done planning parent, else `true`. Not persisted.
|
||||||
|
- Add `[RelayCommand] void ToggleChildrenExpanded()`.
|
||||||
|
- `TasksIslandView.axaml` (or `TaskRowView.axaml`): chevron button on the planning-parent row, visible only when `IsPlanningParent && HasPlanningChildren`. Bound to the toggle command.
|
||||||
|
- `TasksIslandViewModel.Regroup()`: before adding child rows to `OpenItems`/`CompletedItems`, check each child's parent row in `Items`. If the parent's `AreChildrenExpanded == false`, skip the child.
|
||||||
|
- When a planning parent flips from "not done" → "done" in `OnWorkerTaskUpdated`, call `Regroup()` so the collapse takes effect.
|
||||||
|
|
||||||
|
No DB changes.
|
||||||
|
|
||||||
|
## 2. Collapsible description in Details pane
|
||||||
|
|
||||||
|
**Changes:**
|
||||||
|
- `DetailsIslandViewModel`: `[ObservableProperty] bool _isDescriptionExpanded = true` + `[RelayCommand] void ToggleDescriptionExpanded()`.
|
||||||
|
- `DetailsIslandView.axaml`: wrap the existing description `TextBox` in a `StackPanel`; add a thin header row with the label "Description" and a chevron button. Body's `IsVisible` binds to the flag.
|
||||||
|
- State is per ViewModel instance — reset to `true` whenever a different task is loaded.
|
||||||
|
|
||||||
|
No persistence.
|
||||||
|
|
||||||
|
## 3. Narrower GridSplitters
|
||||||
|
|
||||||
|
`MainWindow.axaml` lines 158 and 170: `Width="5"` → `Width="3"` on both `GridSplitter` elements.
|
||||||
|
|
||||||
|
That's the whole change.
|
||||||
|
|
||||||
|
## 4. Sequential subtask queue
|
||||||
|
|
||||||
|
### Data
|
||||||
|
|
||||||
|
- `ClaudeDo.Data/Models/TaskStatus.cs`: add a new enum value `Waiting` (lowercase serialized form `waiting`, matching existing convention).
|
||||||
|
- Verify status is stored as string (it should be based on existing patterns). If stored as int, ensure new value gets a stable numeric slot at the end of the enum to avoid breaking existing rows. **No EF migration** beyond what the enum emits automatically.
|
||||||
|
|
||||||
|
### Worker
|
||||||
|
|
||||||
|
- New SignalR hub method: `QueuePlanningSubtasksAsync(string parentTaskId) : Task`.
|
||||||
|
- Loads all children of the parent, ordered by `SortOrder`.
|
||||||
|
- Validates: parent must be a planning parent, children must currently all be in `Manual` or `Planned` (reject if any child is already Queued/Running/Done/Failed, surface a friendly error).
|
||||||
|
- First child → `Queued`. All other children → `Waiting`. Save.
|
||||||
|
- Emit `TaskUpdated` for each affected task.
|
||||||
|
- Chain progression — hook into the existing finish/complete path that already fires `TaskFinished`:
|
||||||
|
- On a child task finishing with status `Done` **and** its parent has waiting siblings: find the next sibling by `(ParentTaskId == parent.Id && Status == Waiting)` ordered by `SortOrder`, flip to `Queued`, emit `TaskUpdated`, and let the existing queue pickup loop pick it up.
|
||||||
|
- On `Failed`: do nothing. Remaining `Waiting` siblings stay waiting. (A toast for failed tasks will be added in a later spec.)
|
||||||
|
|
||||||
|
This logic lives in a new `PlanningChainCoordinator` service (or similar) in `ClaudeDo.Worker/Planning/`, registered as a singleton and wired into whatever already emits task-finished events.
|
||||||
|
|
||||||
|
### UI
|
||||||
|
|
||||||
|
- `TaskRowView` — add context menu entry **"Queue subtasks sequentially"**:
|
||||||
|
- `IsVisible` bound to `IsPlanningParent && HasPlanningChildren`.
|
||||||
|
- `IsEnabled` when all children are in `Manual` / `Planned` state (new property on `TaskRowViewModel`: `CanQueueSubtasksSequentially`).
|
||||||
|
- Calls `WorkerClient.QueuePlanningSubtasksAsync(Id)`.
|
||||||
|
- `TaskRowViewModel`:
|
||||||
|
- Add `IsWaiting => Status == TaskStatus.Waiting` and extend `StatusChipClass` switch to return a new class `"waiting"`.
|
||||||
|
- Add `CanQueueSubtasksSequentially` (computed; requires access to children).
|
||||||
|
- `StatusColorConverter` — add a muted color for `Waiting` (proposed: the existing `TextMuteBrush` or a faint cyan).
|
||||||
|
- Task list — planning parent continues to appear in virtual:queued because it has a `Queued` child (existing logic). **Extend** the virtual:queued match predicate in `TasksIslandViewModel.TaskMatchesList` so a task matches when `Status == Queued || Status == Waiting`. This ensures all sibling subtasks (the queued one + the waiting ones) render under the parent in that list.
|
||||||
|
|
||||||
|
### Client
|
||||||
|
|
||||||
|
- `IWorkerClient` / `WorkerClient`: add `QueuePlanningSubtasksAsync(string parentTaskId)` that calls the hub method.
|
||||||
|
|
||||||
|
## Out of scope
|
||||||
|
|
||||||
|
- Toast notifications on subtask failure (separate follow-up spec).
|
||||||
|
- Retrying a stopped chain from a failed task (user does it manually via existing actions).
|
||||||
|
- Persisting the collapse state of planning parents or the Description across sessions.
|
||||||
|
- Drag-to-reorder of waiting subtasks (execution order = `SortOrder` at the moment the chain starts).
|
||||||
|
|
||||||
|
## Validation plan
|
||||||
|
|
||||||
|
Manual:
|
||||||
|
- Plan a task with 3 subtasks. Context-menu → Queue subtasks sequentially. Confirm first = Queued, others = Waiting. Watch the first run to Done, confirm the second flips Queued → Running automatically.
|
||||||
|
- Force-fail subtask 2 (cancel or make it fail). Confirm subtask 3 stays Waiting; no further dispatch.
|
||||||
|
- Once all three are Done, confirm the planning parent auto-collapses in the list.
|
||||||
|
- Toggle the Description chevron in the Details pane on an arbitrary task.
|
||||||
|
- Eyeball the narrower GridSplitter — still resizable, still hittable.
|
||||||
|
|
||||||
|
Automated (minimal — only where cheap):
|
||||||
|
- Worker-level unit test for `PlanningChainCoordinator`: happy-path chain advance on Done; no advance on Failed; correct ordering by `SortOrder`.
|
||||||
172
docs/superpowers/specs/2026-04-24-planning-worktree-design.md
Normal file
172
docs/superpowers/specs/2026-04-24-planning-worktree-design.md
Normal file
@@ -0,0 +1,172 @@
|
|||||||
|
# Planning Session MCP via Ephemeral Worktree
|
||||||
|
|
||||||
|
**Date:** 2026-04-24
|
||||||
|
**Status:** Design approved, pending implementation plan
|
||||||
|
**Scope:** `ClaudeDo.Worker` — planning session launch, MCP config delivery
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
When a user starts a planning session, `claude` is spawned in the list's working directory via Windows Terminal and passed `--mcp-config <absolute-path>` pointing at a session-local `mcp.json`. In practice, the spawned `claude` session does **not** pick up the ClaudeDo MCP server: `mcp__claudedo__*` tools are not available, and no trust prompt is shown. The user has to fall back to the built-in `TaskCreate` tool, which writes nothing to ClaudeDo.
|
||||||
|
|
||||||
|
The `--mcp-config` flag is documented for headless (`-p`) invocations; in interactive TUI mode it appears to be either ignored or silently dropped on at least some CLI versions. The JSON payload itself is already correct (verified against Claude Code docs — `type: "http"` + `Authorization` header is the documented form).
|
||||||
|
|
||||||
|
The reliable path per Claude Code docs is project-root `.mcp.json` auto-discovery plus a one-time trust approval (or `enableAllProjectMcpServers: true`).
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Spawn planning sessions so that `mcp__claudedo__*` tools are available immediately, without modifying any file in the user's working directory and without requiring a trust prompt.
|
||||||
|
|
||||||
|
## Non-goals
|
||||||
|
|
||||||
|
- Installer-time MCP registration (rejected — loses per-session token isolation; pollutes every `claude` invocation on the machine).
|
||||||
|
- Changing how task execution (non-planning) spawns `claude`.
|
||||||
|
- Supporting planning on a working directory that is not a git repository.
|
||||||
|
|
||||||
|
## Approach: ephemeral planning worktree
|
||||||
|
|
||||||
|
Each planning session runs inside its own short-lived git worktree, created from `HEAD` of the list's working directory. The worktree is the isolated surface where we write `.mcp.json` and the settings override. The worktree is force-removed on `FinalizeAsync` / `DiscardAsync`.
|
||||||
|
|
||||||
|
### Files changed
|
||||||
|
|
||||||
|
- `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs`
|
||||||
|
- `src/ClaudeDo.Worker/Planning/PlanningSessionContext.cs` (extend to carry worktree path + branch name)
|
||||||
|
- `src/ClaudeDo.Worker/Planning/PlanningSessionFiles.cs` (may drop `McpConfigPath` if no longer used)
|
||||||
|
- `src/ClaudeDo.Worker/Planning/WindowsTerminalPlanningLauncher.cs`
|
||||||
|
- `src/ClaudeDo.Worker/Runner/WorktreeMaintenanceService.cs` (optional — defensive startup prune)
|
||||||
|
- DI registration in `src/ClaudeDo.Worker/Program.cs` (inject `GitService`, `WorkerConfig`, `IDbContextFactory<ClaudeDoDbContext>` into `PlanningSessionManager`)
|
||||||
|
|
||||||
|
### Data flow on `StartAsync`
|
||||||
|
|
||||||
|
1. Resolve `list.WorkingDir`; hard-error if `null`, not a directory, or not a git repo (`GitService.IsGitRepoAsync`).
|
||||||
|
2. Resolve `HEAD` via `GitService.RevParseHeadAsync`.
|
||||||
|
3. Resolve worktree strategy from `AppSettingsRepository.GetAsync` (same resolution as `WorktreeManager.CreateAsync`):
|
||||||
|
- `sibling` → `<parent-of-WorkingDir>\.claudedo-worktrees\planning\<taskId>`
|
||||||
|
- `central` → `<CentralWorktreeRoot>\planning\<taskId>`
|
||||||
|
Normalize with `Path.GetFullPath`.
|
||||||
|
4. Branch name: `claudedo/planning/<taskId-stripped-of-dashes>`.
|
||||||
|
5. `GitService.WorktreeAddAsync(list.WorkingDir, branchName, worktreePath, baseCommit, ct)`. On `"already exists"` failure, run the same self-heal pattern as `WorktreeManager.CreateAsync` (list worktrees for branch → force-remove stale → prune → delete branch → retry once).
|
||||||
|
6. Write into the worktree:
|
||||||
|
- `<worktreePath>\.mcp.json` — JSON with env-var expansion for the token (see below).
|
||||||
|
- `<worktreePath>\.claude\settings.local.json` — `{ "enableAllProjectMcpServers": true }` (create `.claude` dir if missing).
|
||||||
|
7. Write session artifacts in the session directory (unchanged from today): `system-prompt.md`, `initial-prompt.txt`. The session-local `mcp.json` is no longer written — drop that write.
|
||||||
|
8. Return `PlanningSessionStartContext` with `WorkingDir = worktreePath` and a new `WorktreePath` field (redundant with `WorkingDir` for now, but explicit for cleanup). Also carry `BranchName` so finalize/discard can delete it.
|
||||||
|
|
||||||
|
### MCP JSON payload
|
||||||
|
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"mcpServers": {
|
||||||
|
"claudedo": {
|
||||||
|
"type": "http",
|
||||||
|
"url": "http://127.0.0.1:47821/mcp",
|
||||||
|
"headers": {
|
||||||
|
"Authorization": "Bearer ${CLAUDEDO_PLANNING_TOKEN}"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
The token never lives on disk in literal form — `${CLAUDEDO_PLANNING_TOKEN}` is expanded by Claude Code at load time from the spawned process's environment.
|
||||||
|
|
||||||
|
### `.claude/settings.local.json` payload
|
||||||
|
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"enableAllProjectMcpServers": true
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Since the worktree is always empty of user customizations (fresh checkout), we write this file unconditionally. No merge / backup logic needed.
|
||||||
|
|
||||||
|
### Launcher changes (`WindowsTerminalPlanningLauncher`)
|
||||||
|
|
||||||
|
- `LaunchStartAsync`:
|
||||||
|
- Set `psi.Environment["CLAUDEDO_PLANNING_TOKEN"] = ctx.Token` (new field on `PlanningSessionStartContext`).
|
||||||
|
- `-d` now points at the worktree path (already handled by `ctx.WorkingDir` change).
|
||||||
|
- **Remove** `--mcp-config` and its path argument.
|
||||||
|
- Keep `--allowedTools mcp__claudedo__*,Read,Grep,Glob,WebFetch,WebSearch,Skill` — `enableAllProjectMcpServers` only handles trust, not per-tool pre-approval.
|
||||||
|
- Keep `--append-system-prompt-file` as the "single-value flag buffer" before the positional prompt (the existing arg-order concern is unchanged).
|
||||||
|
- `LaunchResumeAsync`:
|
||||||
|
- Same env-var setup.
|
||||||
|
- Same `-d <worktreePath>`.
|
||||||
|
- **Remove** `--mcp-config` (the worktree's `.mcp.json` is discovered automatically).
|
||||||
|
- Keep `--resume <ClaudeSessionId>`.
|
||||||
|
|
||||||
|
### Finalize / Discard
|
||||||
|
|
||||||
|
`PlanningSessionManager.FinalizeAsync` and `DiscardAsync` gain:
|
||||||
|
|
||||||
|
1. Look up the worktree path + branch name (deterministic from `taskId` → reuse the same resolution code as `StartAsync`).
|
||||||
|
2. `GitService.WorktreeRemoveAsync(list.WorkingDir, worktreePath, force: true, ct)` — `--force` because claude may have created scratch files.
|
||||||
|
3. `GitService.BranchDeleteAsync(list.WorkingDir, branchName, force: true, ct)`.
|
||||||
|
4. Delete the session dir as today.
|
||||||
|
|
||||||
|
All three steps are best-effort in `DiscardAsync` (log warnings, don't throw — the user explicitly asked to discard). `FinalizeAsync` should propagate failures, since a failed cleanup leaves resources we care about.
|
||||||
|
|
||||||
|
### Resume
|
||||||
|
|
||||||
|
Resume already looks up `list.WorkingDir` from the list; the worktree path is deterministic from `taskId`. `ResumeAsync` must:
|
||||||
|
|
||||||
|
1. Verify the worktree directory exists; if not, hard-error ("planning session was discarded or lost — cannot resume").
|
||||||
|
2. Return `PlanningSessionResumeContext` with `WorkingDir = worktreePath` and the token (re-read from session state — see Token persistence below).
|
||||||
|
|
||||||
|
### Token persistence
|
||||||
|
|
||||||
|
The token today is generated in `StartAsync` and embedded in `mcp.json` at creation time — never read again. With env-var expansion, the token must be available on **resume**. Options:
|
||||||
|
|
||||||
|
- **A) Persist token to session dir** (`<sessionDir>\token`) with `FileOptions.WriteAllBytes`, restrict file ACL to current user. Read on resume.
|
||||||
|
- **B) Store token hash in DB, raw token in memory only** — breaks across Worker restarts → no resume possible.
|
||||||
|
|
||||||
|
**Chosen: A.** Token file sits inside the existing session directory (`<PlanningSessionManager._rootDirectory>\<taskId>\token`), restricted to the current user via Windows ACLs (`File.SetAccessControl` with an explicit DACL granting `FullControl` to `WindowsIdentity.GetCurrent()` only). Cleaned up in `DiscardAsync`/`FinalizeAsync` with the rest of the session dir.
|
||||||
|
|
||||||
|
### Defensive startup cleanup
|
||||||
|
|
||||||
|
`WorktreeMaintenanceService` already prunes worktrees tracked in the DB. Planning worktrees are **not** in the DB (they're purely filesystem-backed, keyed by `taskId` via path convention). Add a lightweight pass:
|
||||||
|
|
||||||
|
- Enumerate directories matching `<root>\.claudedo-worktrees\planning\*` (for each strategy / central root we know about).
|
||||||
|
- For each, check whether a corresponding session dir exists under `~/.todo-app/sessions/<taskId>`.
|
||||||
|
- If no session dir: `git worktree remove --force` + `git branch -D claudedo/planning/<taskId-stripped>`.
|
||||||
|
|
||||||
|
This is a small addition; if scoped too large, defer to a follow-up and accept that a crashed Worker leaves orphaned worktrees until manual cleanup.
|
||||||
|
|
||||||
|
## Edge cases
|
||||||
|
|
||||||
|
| Case | Behavior |
|
||||||
|
|------|----------|
|
||||||
|
| `list.WorkingDir` not a git repo | Hard-error on `StartAsync`. Surface message in UI. |
|
||||||
|
| Worktree branch already exists from a prior crashed session | Self-heal: force-remove matching worktrees, prune, delete branch, retry once. (Same pattern as `WorktreeManager.CreateAsync`.) |
|
||||||
|
| User closes Windows Terminal without clicking Finalize/Discard | Session dir + worktree remain. `ResumeAsync` works. Startup cleanup handles abandoned sessions whose session dir the user manually deletes. |
|
||||||
|
| Claude creates/edits files in the planning worktree | Discarded with the worktree. No impact on user's real working dir. |
|
||||||
|
| User deletes the session dir out from under the Worker | `ResumeAsync` hard-errors. Startup cleanup GCs the orphaned worktree. |
|
||||||
|
| Two simultaneous planning sessions on the same task | Already prevented by task status transition (`Planning` is exclusive). No new consideration. |
|
||||||
|
| `HEAD` is on a detached commit | `git worktree add` handles this fine — base commit is explicit. |
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
Extend `tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs` (or a new file) with integration tests using the real-SQLite + real-git pattern the project already uses:
|
||||||
|
|
||||||
|
- **Start happy path:** worktree dir exists after `StartAsync`, contains `.mcp.json` with `${CLAUDEDO_PLANNING_TOKEN}` literal, contains `.claude/settings.local.json` with `enableAllProjectMcpServers: true`.
|
||||||
|
- **Finalize cleanup:** worktree dir is gone, branch is gone, session dir is gone.
|
||||||
|
- **Discard cleanup:** same as finalize.
|
||||||
|
- **Self-heal:** pre-create a stale branch `claudedo/planning/<id>`, then `StartAsync` must succeed.
|
||||||
|
- **Non-git working dir:** `StartAsync` throws a specific error type.
|
||||||
|
- **Resume after Worker restart:** seed session dir + token file, recreate `PlanningSessionManager`, `ResumeAsync` returns context pointing at the still-existing worktree.
|
||||||
|
|
||||||
|
Mock `IPlanningTerminalLauncher` (already an interface) so tests don't actually spawn `wt.exe`.
|
||||||
|
|
||||||
|
## Trade-offs and alternatives considered
|
||||||
|
|
||||||
|
1. **Write `.mcp.json` into the user's working dir with backup/restore.** Rejected — clobber risk, file-noise on crash, user's `.gitignore` may not cover it, exposes token alongside source even with env-var expansion (because expansion is on claude's side, the raw `${VAR}` string still lives in the user's repo).
|
||||||
|
2. **User-scope registration via installer** (`claude mcp add --scope user`). Rejected — requires a static secret baked into the Worker, loses per-session isolation, every `claude` session on the machine sees claudedo tools.
|
||||||
|
3. **Keep `--mcp-config` and debug why it's not honored.** Rejected — even if it works on the maintainer's machine, the behavior is undocumented for interactive TUI mode, and we'd need a fallback anyway. Fixing to the documented path eliminates the uncertainty.
|
||||||
|
|
||||||
|
## Open questions resolved
|
||||||
|
|
||||||
|
- **WorkingDir must be a git repo?** Yes — hard-error.
|
||||||
|
- **Worktree path strategy?** Follow the same `sibling`/`central` setting as task execution.
|
||||||
|
- **HEAD snapshot vs WIP?** HEAD snapshot is fine — planning proposes subtasks, doesn't edit files.
|
||||||
|
|
||||||
|
## Implementation sequencing
|
||||||
|
|
||||||
|
A separate implementation plan (via `superpowers:writing-plans`) will break this into test-first steps.
|
||||||
@@ -0,0 +1,174 @@
|
|||||||
|
# External MCP — CRUD Extensions
|
||||||
|
|
||||||
|
**Date:** 2026-04-25
|
||||||
|
**Status:** Approved
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Give a normal (non-planning) Claude CLI session full control over the ClaudeDo task inbox via the existing always-on `ExternalMcpService`. Primary use case: when a chat session produces scope-creep work, Claude can spin up a fully-formed task — title, description, tags (including the `agent` tag for auto-execution) — without leaving the session.
|
||||||
|
|
||||||
|
The work is purely additive: the `ExternalMcpService` endpoint is already wired, authenticated by the optional `X-ClaudeDo-Key` header, and exposes `ListTaskLists`, `ListTasks`, `GetTask`, `AddTask`, `UpdateTaskStatus`, `RunTaskNow`, `CancelTask`. Missing for "full CRUD" are tag handling, content updates, deletion, and tag discovery.
|
||||||
|
|
||||||
|
## Scope
|
||||||
|
|
||||||
|
| Tool | Status | Notes |
|
||||||
|
|---|---|---|
|
||||||
|
| `ListTaskLists` | exists | unchanged |
|
||||||
|
| `ListTasks` | exists | unchanged |
|
||||||
|
| `GetTask` | exists | unchanged |
|
||||||
|
| `AddTask` | extend | add optional `tags` parameter |
|
||||||
|
| `UpdateTaskStatus` | exists | unchanged (Manual ↔ Queued) |
|
||||||
|
| `RunTaskNow` | exists | unchanged |
|
||||||
|
| `CancelTask` | exists | unchanged |
|
||||||
|
| `UpdateTask` | new | patch title/description/commitType/tags |
|
||||||
|
| `DeleteTask` | new | delete a task (cascades) |
|
||||||
|
| `SetTaskTags` | new | replace the full tag set on a task |
|
||||||
|
| `ListTags` | new | enumerate all known tag names |
|
||||||
|
|
||||||
|
Out of scope:
|
||||||
|
- List CRUD (creating/renaming/deleting lists) — out of scope for this iteration; UI remains the source of truth for list management.
|
||||||
|
- ListConfig / agent settings overrides — handled by the UI, not surfaced via MCP here.
|
||||||
|
- Tag CRUD beyond auto-creation during `AddTask` / `UpdateTask` / `SetTaskTags`. There is no `DeleteTag` tool; tag rows live as long as some task references them.
|
||||||
|
|
||||||
|
## Authentication
|
||||||
|
|
||||||
|
No change. The endpoint continues to be gated by `ExternalMcpAuthMiddleware` — if `WorkerConfig.ExternalMcpApiKey` is set, callers must include `X-ClaudeDo-Key`; otherwise the loopback-only worker is open to local processes.
|
||||||
|
|
||||||
|
## Tool specifications
|
||||||
|
|
||||||
|
### `AddTask` (extended)
|
||||||
|
|
||||||
|
```
|
||||||
|
AddTask(
|
||||||
|
listId: string,
|
||||||
|
title: string,
|
||||||
|
description: string?,
|
||||||
|
createdBy: string,
|
||||||
|
queueImmediately: bool,
|
||||||
|
tags: string[]?,
|
||||||
|
cancellationToken)
|
||||||
|
-> TaskDto
|
||||||
|
```
|
||||||
|
|
||||||
|
Behavior:
|
||||||
|
- Existing behavior preserved. New `tags` parameter, when non-null, attaches the named tags to the new task.
|
||||||
|
- Tag names are matched case-insensitively against existing rows; missing tag rows are auto-created (mirrors `TaskRepository.CreateChildAsync`).
|
||||||
|
- Empty/whitespace tag names are skipped; duplicates are deduplicated.
|
||||||
|
- `tags` is the LAST parameter before `CancellationToken` so existing positional callers are unaffected (CancellationToken is bound by name in MCP runtime; defensive — see Migration).
|
||||||
|
|
||||||
|
### `UpdateTask` (new)
|
||||||
|
|
||||||
|
```
|
||||||
|
UpdateTask(
|
||||||
|
taskId: string,
|
||||||
|
title: string?,
|
||||||
|
description: string?,
|
||||||
|
commitType: string?,
|
||||||
|
tags: string[]?,
|
||||||
|
cancellationToken)
|
||||||
|
-> TaskDto
|
||||||
|
```
|
||||||
|
|
||||||
|
Behavior:
|
||||||
|
- Loads the task; throws `InvalidOperationException` if not found.
|
||||||
|
- **Refuses if status is `Running`** — protects in-flight worktrees and the streaming log.
|
||||||
|
- Does NOT change status (use `UpdateTaskStatus`) and does NOT change `createdBy`, `listId`, or `parentTaskId` (audit + structural fields, immutable here).
|
||||||
|
- For each non-null parameter, applies the update. Null means "leave unchanged".
|
||||||
|
- `tags` semantics: full replacement of the tag set (same as `SetTaskTags`). Auto-creates missing tag rows.
|
||||||
|
- Broadcasts `TaskUpdated` on the SignalR hub on success.
|
||||||
|
|
||||||
|
### `DeleteTask` (new)
|
||||||
|
|
||||||
|
```
|
||||||
|
DeleteTask(taskId: string, cancellationToken) -> void
|
||||||
|
```
|
||||||
|
|
||||||
|
Behavior:
|
||||||
|
- Loads the task; throws if not found.
|
||||||
|
- **Refuses if status is `Running`** — caller must `CancelTask` first.
|
||||||
|
- Calls `TaskRepository.DeleteAsync` (FK cascades remove `task_tags`, `worktrees`, `task_runs`, `subtasks`).
|
||||||
|
- Broadcasts `TaskUpdated(taskId)` so UIs drop the row.
|
||||||
|
|
||||||
|
### `SetTaskTags` (new)
|
||||||
|
|
||||||
|
```
|
||||||
|
SetTaskTags(taskId: string, tags: string[], cancellationToken) -> TaskDto
|
||||||
|
```
|
||||||
|
|
||||||
|
Behavior:
|
||||||
|
- Convenience wrapper for "I just want to (re)set tags". Equivalent to `UpdateTask(taskId, null, null, null, tags)`.
|
||||||
|
- Same validation: refuses if `Running`.
|
||||||
|
- Returns the updated `TaskDto` (with status; tags are not included in `TaskDto` today — see Open Decisions).
|
||||||
|
|
||||||
|
### `ListTags` (new)
|
||||||
|
|
||||||
|
```
|
||||||
|
ListTags(cancellationToken) -> { Id: long, Name: string }[]
|
||||||
|
```
|
||||||
|
|
||||||
|
Behavior:
|
||||||
|
- Returns every row in the `tags` table. No filter, no pagination — the table is small (seed values + user-defined).
|
||||||
|
- Lets Claude discover existing tag names (`agent`, `manual`, plus any user-defined) before tagging, avoiding duplicates that differ only by case/whitespace.
|
||||||
|
|
||||||
|
## Repository changes
|
||||||
|
|
||||||
|
`src/ClaudeDo.Data/Repositories/TaskRepository.cs`:
|
||||||
|
|
||||||
|
- Add `public Task SetTagsAsync(string taskId, IReadOnlyList<string> tagNames, CancellationToken ct = default)` — replaces the tag set, auto-creates missing rows. Implementation pattern matches the tag block already inside `CreateChildAsync` and the new `UpdateChildAsync` from the planning-MCP work; consider extracting a private helper `ApplyTagsAsync(TaskEntity, IReadOnlyList<string>, CancellationToken)` shared by both.
|
||||||
|
|
||||||
|
`src/ClaudeDo.Data/Repositories/TagRepository.cs`:
|
||||||
|
|
||||||
|
- Add `public Task<List<TagEntity>> GetAllAsync(CancellationToken ct = default)` if it does not already exist. (Matches `ListRepository.GetAllAsync` style.)
|
||||||
|
|
||||||
|
No new tables, no migrations.
|
||||||
|
|
||||||
|
## Service changes
|
||||||
|
|
||||||
|
`src/ClaudeDo.Worker/External/ExternalMcpService.cs`:
|
||||||
|
|
||||||
|
- Add `TagRepository` to the constructor (DI registration is already in place since the planning service uses it).
|
||||||
|
- Extend `AddTask` signature with `IReadOnlyList<string>? tags` and apply via the repository.
|
||||||
|
- Add `UpdateTask`, `DeleteTask`, `SetTaskTags`, `ListTags` methods, each annotated `[McpServerTool, Description("…")]`.
|
||||||
|
- Each new mutating tool calls `_broadcaster.TaskUpdated(taskId)` on success (matches existing pattern in this file).
|
||||||
|
|
||||||
|
DI: `ExternalMcpService` is already registered. If `TagRepository` is not already registered (it is — used by `ListRepository`), no change. If a constructor parameter is added, `Program.cs` does not need changes because services are scoped/transient.
|
||||||
|
|
||||||
|
## Error handling
|
||||||
|
|
||||||
|
All errors raised as `InvalidOperationException` with a human-readable message — matches the existing pattern in `ExternalMcpService` and `PlanningMcpService`. The MCP SDK serializes these to the JSON-RPC error channel; Claude sees the message text directly.
|
||||||
|
|
||||||
|
Specific cases:
|
||||||
|
- Task not found → `"Task {id} not found."`
|
||||||
|
- Running-task guard → `"Cannot {update|delete} a running task. Cancel it first."`
|
||||||
|
- Unknown status (in `UpdateTaskStatus`, unchanged) → `"Unknown status '{x}'."`
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
Add `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs` (or extend if it exists) with:
|
||||||
|
|
||||||
|
| Test | Asserts |
|
||||||
|
|---|---|
|
||||||
|
| `AddTask_WithTags_AttachesTags` | `tags` param creates and attaches tag rows |
|
||||||
|
| `AddTask_WithUnknownTag_AutoCreatesTagRow` | new tag name produces a row in `tags` table |
|
||||||
|
| `UpdateTask_PatchesNonNullFields` | only non-null fields change |
|
||||||
|
| `UpdateTask_OnRunning_Throws` | `InvalidOperationException` |
|
||||||
|
| `UpdateTask_BroadcastsTaskUpdated` | hub broadcast received |
|
||||||
|
| `UpdateTask_TagsReplaceFullSet` | passing tags=[…] replaces existing tags wholesale |
|
||||||
|
| `DeleteTask_RemovesTaskAndTagJoins` | task and `task_tags` rows gone |
|
||||||
|
| `DeleteTask_OnRunning_Throws` | `InvalidOperationException` |
|
||||||
|
| `SetTaskTags_ReplacesAndBroadcasts` | replacement semantics + broadcast |
|
||||||
|
| `ListTags_ReturnsSeedAndCustomTags` | `agent` + `manual` + any user-defined |
|
||||||
|
|
||||||
|
Existing test infrastructure (`DbFixture`, `FakeHubContext`) is reused. No new fakes required.
|
||||||
|
|
||||||
|
**Caveat:** the test assembly currently fails to compile on `main` because of pre-existing in-progress work on `PlanningChainCoordinator` (missing constructor argument in `WorkerHub`/`TaskRunner` test instantiations). Tests will pass only after that work lands; do not block this design on it.
|
||||||
|
|
||||||
|
## Open decisions (defaults chosen, easy to flip)
|
||||||
|
|
||||||
|
1. **`TaskDto` does not currently include tags.** For consistency, the spec keeps `TaskDto` as-is and ships a separate `ListTags` tool. If preferred, we could add `Tags: string[]` to `TaskDto` so every tool response includes them — small DB cost (one extra `SelectMany`), one struct field added. Default: leave `TaskDto` alone, defer.
|
||||||
|
2. **Per-tag `AddTaskTag` / `RemoveTaskTag` micro-tools.** Skipped — `SetTaskTags` covers the use case, and it's idempotent. Add later if granular ops are wanted.
|
||||||
|
3. **List CRUD via MCP.** Out of scope. UI owns lists.
|
||||||
|
|
||||||
|
## Migration / compatibility
|
||||||
|
|
||||||
|
`AddTask` gains an optional parameter. The MCP server SDK sends parameters by name in JSON-RPC `params`, so existing clients that omit `tags` continue to work without code changes. No version bump required.
|
||||||
@@ -0,0 +1,297 @@
|
|||||||
|
# Worker State & Queue Consolidation — Design
|
||||||
|
|
||||||
|
**Date:** 2026-04-27
|
||||||
|
**Status:** Approved (brainstorming)
|
||||||
|
**Scope:** `ClaudeDo.Worker` + `ClaudeDo.Data` (TaskEntity, TaskRepository), EF migration
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
The worker layer has accumulated structural problems that culminate in a concrete bug — the queue does not pick up tasks created by a planning session.
|
||||||
|
|
||||||
|
### Concrete bug
|
||||||
|
|
||||||
|
`TaskRepository.FinalizePlanningAsync(parentId, queueAgentTasks=true)` only flips a draft child to `Queued` if the child *or* its list carries the `agent` tag:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
var shouldQueue = queueAgentTasks && (childHasAgentTag || listHasAgentTag);
|
||||||
|
```
|
||||||
|
|
||||||
|
When neither carries the tag, the child silently becomes `Manual` — the queue ignores it. There is no UI feedback. Users observe "queue never picks up planning tasks".
|
||||||
|
|
||||||
|
### Underlying design issues
|
||||||
|
|
||||||
|
1. **Status enum mixes orthogonal concerns.** Today's `TaskStatus` carries 10 values: lifecycle (`Manual, Queued, Running, Done, Failed`), planning hierarchy (`Planning, Planned`), chain ordering (`Waiting`), and an unclear `Draft`. Every consumer has to know which subset applies in which context.
|
||||||
|
2. **Status writes are scattered.** TaskRunner, StaleTaskRecovery, PlanningChainCoordinator, FinalizePlanningAsync, TaskResetService, ExternalMcpService, and PlanningMcpService all mutate `Status` directly. Some go through `TaskRepository.Mark*Async` helpers, some do `task.Status = …` straight on the DbContext (PlanningChainCoordinator).
|
||||||
|
3. **Guards are duplicated.** `if (Status == Running) throw …` appears in at least four places (delete, retag, merge, reset).
|
||||||
|
4. **Two competing planning flows.** `FinalizePlanningAsync` (parallel queueing in Repo) and `PlanningChainCoordinator.QueueSubtasksSequentiallyAsync` (sequential chain) make incompatible assumptions about child status.
|
||||||
|
5. **`WakeQueue()` is manual.** Multiple callers must remember to invoke it after any DB mutation that creates a `Queued` task. `QueueSubtasksSequentiallyAsync` forgets to. The queue only picks up after a backstop tick.
|
||||||
|
6. **`Worker/Services/` is a grab-bag.** Queue, lifecycle, merge, worktree maintenance, agent files, and recovery sit side-by-side without domain boundaries.
|
||||||
|
|
||||||
|
## Goals
|
||||||
|
|
||||||
|
- One source of truth for status mutations: `TaskStateService`.
|
||||||
|
- Status enum reflects only lifecycle. Planning state and chain blocking are separate fields.
|
||||||
|
- Wake-queue side effects are automatic, not caller-driven.
|
||||||
|
- Planning finalization has exactly one path.
|
||||||
|
- `Worker/Services/` is split into domain folders.
|
||||||
|
|
||||||
|
## Non-Goals
|
||||||
|
|
||||||
|
- No change to UI status-rendering logic beyond adapting to renamed values.
|
||||||
|
- No change to SignalR/MCP wire formats beyond the necessary status-string updates.
|
||||||
|
- No change to git/worktree behavior.
|
||||||
|
|
||||||
|
## Design
|
||||||
|
|
||||||
|
### 1. Status model reform
|
||||||
|
|
||||||
|
Replace today's single `TaskStatus` with three orthogonal fields on `TaskEntity`.
|
||||||
|
|
||||||
|
#### `TaskStatus` (lifecycle only) — 6 values
|
||||||
|
|
||||||
|
| Value | Meaning |
|
||||||
|
|---|---|
|
||||||
|
| `Idle` | not in queue, not active. Replaces today's `Manual` and `Draft`. |
|
||||||
|
| `Queued` | waiting for queue pickup. |
|
||||||
|
| `Running` | currently executing. |
|
||||||
|
| `Done` | finished successfully. |
|
||||||
|
| `Failed` | finished with error. |
|
||||||
|
| `Cancelled` | aborted by user (today conflated with `Failed`). |
|
||||||
|
|
||||||
|
#### `PlanningPhase` (parent-only, new column) — 3 values
|
||||||
|
|
||||||
|
| Value | Meaning |
|
||||||
|
|---|---|
|
||||||
|
| `None` | no planning session. Default for all tasks. |
|
||||||
|
| `Active` | planning session is running. Replaces `Status=Planning`. |
|
||||||
|
| `Finalized` | plan is committed, children exist. Replaces `Status=Planned`. |
|
||||||
|
|
||||||
|
A parent task can now be `Status=Idle, PlanningPhase=Finalized` simultaneously, enabling re-runs of finalized plans without losing planning metadata.
|
||||||
|
|
||||||
|
#### `BlockedByTaskId` (nullable FK, new column) — replaces `Waiting`
|
||||||
|
|
||||||
|
- Today: `Status=Waiting` means "waiting on a predecessor in the chain".
|
||||||
|
- New: `Status=Queued` AND `BlockedByTaskId=<predecessor>`. Picker filters out any row with `BlockedByTaskId IS NOT NULL`.
|
||||||
|
- `ON DELETE SET NULL` — if predecessor is deleted, child becomes pickable.
|
||||||
|
|
||||||
|
### 2. `TaskStateService` (centralized state machine)
|
||||||
|
|
||||||
|
The only component that writes `Status`, `PlanningPhase`, `BlockedByTaskId`. All other code goes through it.
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public interface ITaskStateService
|
||||||
|
{
|
||||||
|
Task<TransitionResult> EnqueueAsync(string taskId, CancellationToken ct);
|
||||||
|
Task<TransitionResult> StartRunningAsync(string taskId, DateTime startedAt, CancellationToken ct);
|
||||||
|
Task<TransitionResult> CompleteAsync(string taskId, DateTime finishedAt, string? result, CancellationToken ct);
|
||||||
|
Task<TransitionResult> FailAsync(string taskId, DateTime finishedAt, string? error, CancellationToken ct);
|
||||||
|
Task<TransitionResult> CancelAsync(string taskId, DateTime finishedAt, CancellationToken ct);
|
||||||
|
Task<TransitionResult> ResetToIdleAsync(string taskId, CancellationToken ct);
|
||||||
|
|
||||||
|
Task<TransitionResult> StartPlanningAsync(string parentId, CancellationToken ct);
|
||||||
|
Task<TransitionResult> FinalizePlanningAsync(string parentId, CancellationToken ct);
|
||||||
|
|
||||||
|
Task<TransitionResult> BlockOnAsync(string taskId, string predecessorTaskId, CancellationToken ct);
|
||||||
|
Task<TransitionResult> UnblockAsync(string taskId, CancellationToken ct);
|
||||||
|
|
||||||
|
Task<int> RecoverStaleRunningAsync(string reason, CancellationToken ct);
|
||||||
|
}
|
||||||
|
|
||||||
|
public sealed record TransitionResult(bool Ok, string? Reason);
|
||||||
|
```
|
||||||
|
|
||||||
|
#### Allowed transitions
|
||||||
|
|
||||||
|
```
|
||||||
|
Idle → Queued | Running (RunNow)
|
||||||
|
Queued → Running | Cancelled | Idle (ResetToIdle)
|
||||||
|
Running → Done | Failed | Cancelled
|
||||||
|
Done → Idle (ResetToIdle, for re-run)
|
||||||
|
Failed → Idle | Queued (re-queue)
|
||||||
|
Cancelled → Idle | Queued
|
||||||
|
```
|
||||||
|
|
||||||
|
Anything else returns `TransitionResult(false, "invalid transition X→Y")`. No exceptions for invalid transitions — Result pattern keeps callers tolerant.
|
||||||
|
|
||||||
|
#### Invariants
|
||||||
|
|
||||||
|
1. **Atomic.** Each transition is a single `ExecuteUpdate` (or short tx) using `WHERE Status = <expected>` to be TOCTOU-free.
|
||||||
|
2. **Validated.** Source status is verified at the SQL level, not in C#.
|
||||||
|
3. **Side effects (after successful DB write):**
|
||||||
|
- On any `→ Queued`: `IQueueWaker.Wake()`.
|
||||||
|
- On any successful transition: `HubBroadcaster.TaskUpdated(taskId)`.
|
||||||
|
- On `Done`/`Failed`/`Cancelled` for a child task: `IPlanningChainCoordinator.OnChildFinishedAsync`, which calls `_state.UnblockAsync(nextChild)` and `TryCompleteParent` if applicable.
|
||||||
|
4. **No caller responsibility for side effects.** A caller only needs to invoke one method.
|
||||||
|
|
||||||
|
#### Caller migration
|
||||||
|
|
||||||
|
| Today | New |
|
||||||
|
|---|---|
|
||||||
|
| `TaskRunner.MarkRunningAsync` | `_state.StartRunningAsync` |
|
||||||
|
| `TaskRunner.HandleSuccess` (Mark + chain + parent) | `_state.CompleteAsync` (handles all) |
|
||||||
|
| `TaskRunner.HandleFailure` | `_state.FailAsync` |
|
||||||
|
| `StaleTaskRecovery.FlipAllRunningToFailedAsync` | `_state.RecoverStaleRunningAsync("worker restart")` |
|
||||||
|
| `PlanningChainCoordinator.QueueSubtasksSequentiallyAsync` (direct DbContext) | iterates children, calls `_state.EnqueueAsync` for first, `_state.BlockOnAsync` for rest |
|
||||||
|
| `TaskRepository.FinalizePlanningAsync` | **removed**; `PlanningSessionManager` orchestrates via state-service |
|
||||||
|
| `TaskResetService` (direct DbContext) | `_state.ResetToIdleAsync` (service only owns worktree-cleanup) |
|
||||||
|
|
||||||
|
`Mark*Async` repo helpers stay but become `internal` — used only by `TaskStateService`.
|
||||||
|
|
||||||
|
### 3. Queue dispatch & wake mechanics
|
||||||
|
|
||||||
|
Three classes, clear responsibilities.
|
||||||
|
|
||||||
|
#### `IQueueWaker`
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public interface IQueueWaker { void Wake(); }
|
||||||
|
```
|
||||||
|
|
||||||
|
- Singleton. Backed by today's `SemaphoreSlim`.
|
||||||
|
- Called automatically by `TaskStateService` after any `→ Queued` transition.
|
||||||
|
- Manual `WakeQueue()` calls in app code are removed (Hub `WakeQueue` SignalR endpoint stays for diagnostics but maps directly to `IQueueWaker.Wake`).
|
||||||
|
|
||||||
|
#### `IQueuePicker`
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public interface IQueuePicker
|
||||||
|
{
|
||||||
|
Task<TaskEntity?> ClaimNextAsync(DateTime now, CancellationToken ct);
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- The single place where queue selection happens.
|
||||||
|
- Filter (all required):
|
||||||
|
- `Status == Queued`
|
||||||
|
- `BlockedByTaskId IS NULL`
|
||||||
|
- `(ScheduledFor IS NULL OR ScheduledFor <= :now)`
|
||||||
|
- `EXISTS task_tags WHERE name='agent'` OR `EXISTS list_tags WHERE name='agent'`
|
||||||
|
- Order: `SortOrder ASC, CreatedAt ASC`.
|
||||||
|
- Atomic claim via `UPDATE … RETURNING` (matching today's pattern), flips `Queued → Running` and writes `StartedAt`.
|
||||||
|
- Picker is the sole caller of `Queued → Running` transition. `TaskStateService.StartRunningAsync` exists for the override slot path (RunNow / Continue).
|
||||||
|
|
||||||
|
#### `QueueService` (BackgroundService) — slimmer
|
||||||
|
|
||||||
|
- Wait on wake-signal or backstop timer.
|
||||||
|
- Call `_picker.ClaimNextAsync`.
|
||||||
|
- If task: occupy queue slot, run via `_runner.RunAsync`, in `ContinueWith` invoke `_waker.Wake()` for the next pickup.
|
||||||
|
- No DbContext. No status mutation. No DTO knowledge.
|
||||||
|
|
||||||
|
#### `OverrideSlotService` (new)
|
||||||
|
|
||||||
|
- Owns `RunNow` and `ContinueTask` (today both in `QueueService`).
|
||||||
|
- Holds the override slot state.
|
||||||
|
- Status mutations go through `TaskStateService.StartRunningAsync` (non-atomic claim — caller-driven, fine because override is user-initiated and serialized by slot lock).
|
||||||
|
|
||||||
|
### 4. Planning chain integration
|
||||||
|
|
||||||
|
Single flow, replaces both `FinalizePlanningAsync` (Repo) and `QueueSubtasksSequentiallyAsync` (Coordinator).
|
||||||
|
|
||||||
|
1. `PlanningSessionManager.StartAsync(parentId)` → `_state.StartPlanningAsync` → parent `PlanningPhase=Active`.
|
||||||
|
2. User edits children in MCP tool. Children are in `Status=Idle`.
|
||||||
|
3. `PlanningSessionManager.FinalizeAsync(parentId)`:
|
||||||
|
- `_state.FinalizePlanningAsync(parentId)` → parent `PlanningPhase=Finalized, Status=Idle`.
|
||||||
|
- `_chainCoordinator.SetupChainAsync(parentId)`:
|
||||||
|
- Attaches `agent` tag to all children (automatic — confirmed in brainstorming).
|
||||||
|
- `_state.EnqueueAsync(children[0])` → wake fires.
|
||||||
|
- `_state.BlockOnAsync(children[i], children[i-1])` for `i ≥ 1`.
|
||||||
|
4. When a child finishes, `TaskRunner.HandleSuccess` calls `_state.CompleteAsync(child)`. State-service internally invokes `_chainCoordinator.OnChildFinishedAsync`, which calls `_state.UnblockAsync(nextChild)` (wake fires). Predecessor block goes away because of `ON DELETE SET NULL`-style logic in `UnblockAsync`.
|
||||||
|
5. When all children are terminal: `_state` runs `TryCompleteParent` and sets parent `Done`/`Failed` based on aggregate.
|
||||||
|
|
||||||
|
`TaskRepository.FinalizePlanningAsync` is **deleted**. `QueueSubtasksSequentiallyAsync` is renamed to `SetupChainAsync` and made internal to the coordinator (called only from `PlanningSessionManager.FinalizeAsync`).
|
||||||
|
|
||||||
|
### 5. `Worker/Services/` reorganization
|
||||||
|
|
||||||
|
```
|
||||||
|
Worker/
|
||||||
|
State/
|
||||||
|
ITaskStateService.cs
|
||||||
|
TaskStateService.cs
|
||||||
|
TransitionResult.cs
|
||||||
|
Queue/
|
||||||
|
IQueueWaker.cs
|
||||||
|
IQueuePicker.cs
|
||||||
|
QueuePicker.cs
|
||||||
|
QueueService.cs (BackgroundService, slimmer)
|
||||||
|
OverrideSlotService.cs
|
||||||
|
QueueSlotState.cs
|
||||||
|
Lifecycle/
|
||||||
|
StaleTaskRecovery.cs
|
||||||
|
TaskResetService.cs
|
||||||
|
TaskMergeService.cs
|
||||||
|
Worktrees/
|
||||||
|
WorktreeMaintenanceService.cs
|
||||||
|
Agents/
|
||||||
|
AgentFileService.cs
|
||||||
|
DefaultAgentSeeder.cs
|
||||||
|
Runner/ (unchanged)
|
||||||
|
Planning/ (ChainCoordinator simplified)
|
||||||
|
External/ (unchanged)
|
||||||
|
Hub/ (unchanged)
|
||||||
|
```
|
||||||
|
|
||||||
|
`WorkerHub` calls fewer services — typically `_state.X` plus a domain service for non-status work (Merge, Worktree-Cleanup).
|
||||||
|
|
||||||
|
### 6. EF migration
|
||||||
|
|
||||||
|
```sql
|
||||||
|
ALTER TABLE tasks ADD COLUMN planning_phase INTEGER NOT NULL DEFAULT 0;
|
||||||
|
ALTER TABLE tasks ADD COLUMN blocked_by_task_id TEXT NULL REFERENCES tasks(id) ON DELETE SET NULL;
|
||||||
|
CREATE INDEX ix_tasks_blocked_by ON tasks(blocked_by_task_id);
|
||||||
|
|
||||||
|
UPDATE tasks SET status='idle' WHERE status='manual';
|
||||||
|
UPDATE tasks SET status='idle' WHERE status='draft';
|
||||||
|
UPDATE tasks SET status='idle', planning_phase=1 WHERE status='planning';
|
||||||
|
UPDATE tasks SET status='idle', planning_phase=2 WHERE status='planned';
|
||||||
|
```
|
||||||
|
|
||||||
|
`Waiting` migration uses a CTE with `LAG()` to derive `BlockedByTaskId` from `(parent_task_id, sort_order)`:
|
||||||
|
|
||||||
|
```sql
|
||||||
|
WITH ordered AS (
|
||||||
|
SELECT id,
|
||||||
|
LAG(id) OVER (PARTITION BY parent_task_id ORDER BY sort_order, created_at) AS prev_id
|
||||||
|
FROM tasks WHERE status='waiting'
|
||||||
|
)
|
||||||
|
UPDATE tasks SET status='queued',
|
||||||
|
blocked_by_task_id=(SELECT prev_id FROM ordered WHERE ordered.id=tasks.id)
|
||||||
|
WHERE id IN (SELECT id FROM ordered);
|
||||||
|
```
|
||||||
|
|
||||||
|
Migration runs at worker startup via the existing `MigrateAsync` flow.
|
||||||
|
|
||||||
|
`Down()` is best-effort (local-only app). Reverse mapping is lossy: `Cancelled` → `Failed`, `BlockedByTaskId` → `Waiting`, planning fields → folded back into status.
|
||||||
|
|
||||||
|
### 7. Test strategy
|
||||||
|
|
||||||
|
New test fixtures (xUnit, real SQLite, real git where needed):
|
||||||
|
|
||||||
|
1. **`TaskStateServiceTests`** — happy path + reject for every transition; mock `IQueueWaker`, `HubBroadcaster`, `IPlanningChainCoordinator` and verify side-effect invocations; concurrency test (two parallel `StartRunningAsync` → exactly one wins).
|
||||||
|
2. **`QueuePickerTests`** — filter logic (blocked, missing tag, future schedule, wrong status) and ordering (`sort_order, created_at`); two parallel pickers → exactly one claims a row.
|
||||||
|
3. **`PlanningChainCoordinatorTests`** — `SetupChainAsync` produces correct (`Queued`, `BlockedBy`) layout; `OnChildFinishedAsync` unblocks the next child; child failure leaves remaining blocked, parent transitions to `Failed` after `TryCompleteParent`.
|
||||||
|
4. **`PlanningEndToEndTests`** — regression for the original bug. `Active` parent + 3 drafts → `Finalize` → assert first child reaches `Running` within 200 ms with no manual `Wake`.
|
||||||
|
5. **Existing tests** — anything seeding `task.Status = TaskStatus.Manual` or similar gets updated to new enum values or routed through `_state`.
|
||||||
|
|
||||||
|
Coverage target: state machine + queue picker at ≥90% branch coverage. Existing coverage levels preserved elsewhere.
|
||||||
|
|
||||||
|
### 8. Implementation slices
|
||||||
|
|
||||||
|
Each slice is one PR with green tests before the next starts.
|
||||||
|
|
||||||
|
1. **Slice 1 — Status model + migration.** New enum values, new columns, EF migration. Existing code mapped to new values mechanically (no behavior change).
|
||||||
|
2. **Slice 2 — `TaskStateService`.** Service + interface + tests. Migrate TaskRunner, StaleTaskRecovery, ExternalMcp/PlanningMcp guards, TaskResetService. Mark `Mark*Async` repo helpers `internal`.
|
||||||
|
3. **Slice 3 — `IQueueWaker` + `IQueuePicker`.** Extract from QueueService and Repo. Remove all manual `WakeQueue()` calls in app code.
|
||||||
|
4. **Slice 4 — Planning flow consolidation.** Delete `FinalizePlanningAsync` from repo. `PlanningSessionManager.FinalizeAsync` orchestrates via state-service + ChainCoordinator. Rename `QueueSubtasksSequentiallyAsync` → `SetupChainAsync` (internal). E2E test green.
|
||||||
|
5. **Slice 5 — `OverrideSlotService` + folder reorg.** Extract RunNow / ContinueTask. Move files to new folder structure. Update DI registration.
|
||||||
|
6. **Slice 6 — Cleanup & docs.** Update `Worker/CLAUDE.md`, `docs/plan.md`. Remove dead helpers.
|
||||||
|
|
||||||
|
## Risks & Mitigations
|
||||||
|
|
||||||
|
- **EF migration on existing DBs.** Tested via integration tests that load a pre-migration fixture DB. `MigrateAsync` is already in production use, low risk.
|
||||||
|
- **State-service becomes a god-object.** Mitigated by keeping it narrow: only status/phase/blocked-by writes, no business logic. Worktree, merge, and runner concerns stay in their own services.
|
||||||
|
- **Two paths to `Running` (picker atomic, state-service for override).** Confirmed acceptable in brainstorming. Picker remains the only atomic-claim path; override slot is serialized by slot lock so non-atomic is safe.
|
||||||
|
- **Waiting-migration CTE.** SQLite supports `LAG()` since 3.25. .NET 8's bundled SQLite is well above. Tested in migration unit tests.
|
||||||
|
|
||||||
|
## Open Questions
|
||||||
|
|
||||||
|
None at design time. All knackpunkte resolved during brainstorming.
|
||||||
@@ -0,0 +1,272 @@
|
|||||||
|
# Tabbed Settings + Prime Claude — Design
|
||||||
|
|
||||||
|
**Date:** 2026-04-28
|
||||||
|
**Status:** Draft for review
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Two related UI changes:
|
||||||
|
|
||||||
|
1. Restructure the existing **Settings modal** from a single scrollable stack into a `TabControl` with focused tabs. Move the read-only "About" content out of Settings entirely, into a new modal accessible from the existing Help menu.
|
||||||
|
2. Add a new **Prime Claude** tab where the user defines date-bounded daily schedules. At each scheduled time, the worker fires a single non-interactive `claude -p "ping" --max-turns 1` call to start Claude's 5-hour usage window early — "priming" the day.
|
||||||
|
|
||||||
|
## Scope
|
||||||
|
|
||||||
|
### In scope
|
||||||
|
- Settings tabbed UI with 4 tabs: General, Worktrees, Files, Prime Claude.
|
||||||
|
- New About modal opened from `MainWindow` Help menu.
|
||||||
|
- New `PrimeSchedules` table, repository, EF migration.
|
||||||
|
- New `PrimeScheduler` background service (event-driven, no polling).
|
||||||
|
- New SignalR hub methods + client wiring.
|
||||||
|
- Footer notification on prime fire (success/failure) via `StatusBarView`.
|
||||||
|
- 30-minute catch-up window on app launch / wake.
|
||||||
|
- Tests: scheduler unit tests, tab VM tests.
|
||||||
|
|
||||||
|
### Out of scope
|
||||||
|
- Auto-start ClaudeDo at OS boot.
|
||||||
|
- Multiple pings per day per schedule.
|
||||||
|
- Per-schedule prompt customization (schema reserves the column for future use).
|
||||||
|
- Holiday / calendar integration.
|
||||||
|
- Toast notifications, sound, OS-level notifications.
|
||||||
|
|
||||||
|
## Settings tab layout
|
||||||
|
|
||||||
|
| Tab | Contents (existing sections, no field changes) |
|
||||||
|
|---|---|
|
||||||
|
| **General** | Claude Defaults: instructions, model, max turns, permission mode |
|
||||||
|
| **Worktrees** | Strategy, central root, auto-cleanup, Cleanup button, Force-remove confirm flow |
|
||||||
|
| **Files** | Agents (Restore default agents) + Prompts (System / Planning / Agent open-in-editor rows) |
|
||||||
|
| **Prime Claude** | New — schedule list + add button (see below) |
|
||||||
|
|
||||||
|
- Window stays 580×760, custom title bar preserved.
|
||||||
|
- Footer (Save / Cancel) preserved; Save iterates per-tab VMs.
|
||||||
|
- Status / validation strip stays above the footer.
|
||||||
|
- Tab strip uses the existing section-label style for headers (mono, 10pt, letter-spacing 1.4) so it visually matches the current aesthetic.
|
||||||
|
|
||||||
|
## About modal
|
||||||
|
|
||||||
|
New `AboutModalView` + `AboutModalViewModel`:
|
||||||
|
- Same 4 rows as today's About section: Version, Data folder, Logs folder, Worker config — each with an Open button.
|
||||||
|
- Compact dialog (~480×280), same chrome as `SettingsModalView`.
|
||||||
|
- Wired into `MainWindow` Help menu as a new `<MenuItem Header="About…">` next to "Check for updates".
|
||||||
|
- About content removed from `SettingsModalView` entirely (cleaner: not a setting).
|
||||||
|
|
||||||
|
## Prime Claude tab — UI
|
||||||
|
|
||||||
|
```
|
||||||
|
┌────────────────────────────────────────────────────────────────┐
|
||||||
|
│ Prime your Claude usage window each morning by firing a single │
|
||||||
|
│ non-interactive `ping` call at a chosen time. Only runs while │
|
||||||
|
│ ClaudeDo is open. If the app starts within 30 min of the target │
|
||||||
|
│ time, the ping fires immediately (catch-up window). │
|
||||||
|
├────────────────────────────────────────────────────────────────┤
|
||||||
|
│ ☑ May 5, 2026 → Jun 30, 2026 07:00 Mon–Fri last: today ✕│
|
||||||
|
│ ☐ Jul 1, 2026 → Jul 7, 2026 09:30 All days — ✕│
|
||||||
|
├────────────────────────────────────────────────────────────────┤
|
||||||
|
│ [+ Add schedule] │
|
||||||
|
└────────────────────────────────────────────────────────────────┘
|
||||||
|
```
|
||||||
|
|
||||||
|
Per-row controls:
|
||||||
|
- Enabled checkbox (`Enabled`)
|
||||||
|
- Start date picker (`StartDate`)
|
||||||
|
- End date picker (`EndDate`)
|
||||||
|
- Time-of-day field (`TimeOfDay`, 24h, e.g. `07:00`)
|
||||||
|
- Workdays-only checkbox (`WorkdaysOnly`)
|
||||||
|
- Last run label (`{LastRunAt:g}` or `—` if null)
|
||||||
|
- Delete button (✕, with inline confirm bar matching the Worktrees pattern)
|
||||||
|
|
||||||
|
`+ Add schedule` appends a new row pre-filled with: today, today + 30 days, `07:00`, `WorkdaysOnly = true`, `Enabled = true`.
|
||||||
|
|
||||||
|
Validation per row:
|
||||||
|
- `StartDate <= EndDate`
|
||||||
|
- `TimeOfDay` parses as `HH:mm`
|
||||||
|
- `EndDate >= today` (else mark row disabled-looking + tooltip "expired")
|
||||||
|
|
||||||
|
Persistence: rows save with the rest of the modal on **Save**. On Save, `PrimeClaudeTabViewModel` diffs in-memory rows against the loaded snapshot and emits one hub call per change: `UpsertPrimeSchedule` for new/edited rows, `DeletePrimeSchedule` for removed rows. Cancel discards in-memory edits. No per-row autosave.
|
||||||
|
|
||||||
|
## Data model
|
||||||
|
|
||||||
|
New EF Core entity `PrimeScheduleEntity` in `ClaudeDo.Data/Models/`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public class PrimeScheduleEntity
|
||||||
|
{
|
||||||
|
public Guid Id { get; set; }
|
||||||
|
public DateOnly StartDate { get; set; }
|
||||||
|
public DateOnly EndDate { get; set; }
|
||||||
|
public TimeSpan TimeOfDay { get; set; } // local clock
|
||||||
|
public bool WorkdaysOnly { get; set; }
|
||||||
|
public bool Enabled { get; set; }
|
||||||
|
public DateTimeOffset? LastRunAt { get; set; }
|
||||||
|
public string? PromptOverride { get; set; } // reserved, always null today
|
||||||
|
public DateTimeOffset CreatedAt { get; set; }
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- New `PrimeScheduleConfiguration : IEntityTypeConfiguration<PrimeScheduleEntity>` in `Configuration/`.
|
||||||
|
- New repository `PrimeScheduleRepository` matching the existing async + CancellationToken pattern. Methods: `ListAsync`, `GetAsync(id)`, `UpsertAsync(entity)`, `DeleteAsync(id)`, `UpdateLastRunAsync(id, when)`.
|
||||||
|
- EF migration `AddPrimeSchedules` (auto-named per existing migration history).
|
||||||
|
|
||||||
|
## Worker scheduler — `PrimeScheduler`
|
||||||
|
|
||||||
|
New folder `ClaudeDo.Worker/Prime/`. Class hierarchy:
|
||||||
|
|
||||||
|
- `PrimeScheduler : BackgroundService` — event-driven loop.
|
||||||
|
- `IPrimeRunner` / `PrimeRunner` — fires the actual `claude -p "ping" --max-turns 1` call. Injected so tests can fake it.
|
||||||
|
- `IPrimeClock` / `PrimeClock` — `DateTimeOffset Now { get; }`. Faked in tests.
|
||||||
|
- `PrimeSchedulerOptions` — `CatchUpWindow = TimeSpan.FromMinutes(30)`. Hardcoded today; typed for swappability.
|
||||||
|
|
||||||
|
### Loop
|
||||||
|
|
||||||
|
```text
|
||||||
|
while not cancelled:
|
||||||
|
next = ComputeNextDue(now) # null if no enabled schedules
|
||||||
|
if next is null:
|
||||||
|
await wait-on-signal # blocks until schedules change
|
||||||
|
continue
|
||||||
|
delay = max(0, next.At - now)
|
||||||
|
try:
|
||||||
|
await Task.Delay(delay, linkedToken) # cancellable by signal
|
||||||
|
catch OperationCanceledException:
|
||||||
|
continue # schedules changed → recompute
|
||||||
|
await Fire(next.Schedule)
|
||||||
|
```
|
||||||
|
|
||||||
|
`ComputeNextDue(now)`:
|
||||||
|
- For each enabled schedule:
|
||||||
|
- Determine the next eligible date `d >= today` within `[StartDate, EndDate]`, honoring `WorkdaysOnly`.
|
||||||
|
- Skip the day if `LastRunAt.LocalDate == today` (already fired today).
|
||||||
|
- Build `target = d.At(TimeOfDay)` in local time.
|
||||||
|
- Apply catch-up: if `target < now <= target + 30min` and not already fired today, target = `now` (fire immediately).
|
||||||
|
- If `target < now` (past catch-up window) and `d == today`, advance `d` to next eligible date.
|
||||||
|
- Return the schedule with the smallest `target`.
|
||||||
|
|
||||||
|
### Signal source
|
||||||
|
|
||||||
|
`IPrimeScheduleSignal` — a thin abstraction wrapping a `CancellationTokenSource` reset. The hub calls `Signal()` on:
|
||||||
|
- App start (initial recompute is implicit — service first-run computes immediately).
|
||||||
|
- After `UpsertPrimeSchedule` / `DeletePrimeSchedule`.
|
||||||
|
- After a successful fire (so the next-due is recomputed without polling).
|
||||||
|
|
||||||
|
### Fire
|
||||||
|
|
||||||
|
`PrimeRunner.FireAsync(schedule, ct)`:
|
||||||
|
1. Resolve `claude` executable via existing `ClaudeProcess` discovery.
|
||||||
|
2. Spawn with `cwd = Paths.AppDataRoot()`, args `["-p", "ping", "--max-turns", "1"]`. No worktree, no task entity, no list/tag side effects.
|
||||||
|
3. Capture stdout/stderr; success = exit 0 within a 60s timeout.
|
||||||
|
4. On finish: `await PrimeScheduleRepository.UpdateLastRunAsync(id, now)`, append a one-line summary to `~/.todo-app/logs/prime.log`, broadcast `PrimeFired(success, message, timestamp)` via `HubBroadcaster`.
|
||||||
|
|
||||||
|
Failure modes (network, auth, executable missing) → broadcast a failure message; `LastRunAt` still stamped so the day doesn't keep retrying.
|
||||||
|
|
||||||
|
## SignalR / IPC
|
||||||
|
|
||||||
|
### Hub methods (`WorkerHub`)
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Task<IReadOnlyList<PrimeScheduleDto>> ListPrimeSchedules();
|
||||||
|
Task<PrimeScheduleDto> UpsertPrimeSchedule(PrimeScheduleDto dto);
|
||||||
|
Task DeletePrimeSchedule(Guid id);
|
||||||
|
```
|
||||||
|
|
||||||
|
DTO mirrors entity minus `CreatedAt` (server-managed).
|
||||||
|
|
||||||
|
### Hub events (broadcast)
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
event PrimeFired(Guid scheduleId, bool success, string message, DateTimeOffset firedAt);
|
||||||
|
```
|
||||||
|
|
||||||
|
The `scheduleId` lets an open Settings modal update the matching row's `LastRunAt` without a full reload. No separate `PrimeSchedulesChanged` event — Settings is the only writer, so the modal's own VM state is authoritative until Save.
|
||||||
|
|
||||||
|
`WorkerClient` adds matching async methods + the event handler.
|
||||||
|
|
||||||
|
## UI wiring
|
||||||
|
|
||||||
|
### ViewModel split
|
||||||
|
|
||||||
|
`SettingsModalViewModel` stops holding field properties directly and becomes a coordinator:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public sealed partial class SettingsModalViewModel
|
||||||
|
{
|
||||||
|
public GeneralSettingsTabViewModel General { get; }
|
||||||
|
public WorktreesSettingsTabViewModel Worktrees { get; }
|
||||||
|
public FilesSettingsTabViewModel Files { get; }
|
||||||
|
public PrimeClaudeTabViewModel Prime { get; }
|
||||||
|
|
||||||
|
[RelayCommand] private async Task Save() { ... iterate tabs, call SaveAsync on each ... }
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
Each tab VM:
|
||||||
|
- Owns its observable properties.
|
||||||
|
- Has `Task LoadAsync()` and `Task SaveAsync()` (or returns a partial DTO the coordinator merges).
|
||||||
|
- Owns its own validation, surfaces `ValidationError`.
|
||||||
|
|
||||||
|
`PrimeClaudeTabViewModel`:
|
||||||
|
- `ObservableCollection<PrimeScheduleRowViewModel> Rows`
|
||||||
|
- `[RelayCommand] AddSchedule()` / `RemoveSchedule(id)`
|
||||||
|
- Subscribes to `WorkerClient.PrimeSchedulesChanged` / `PrimeFired` to keep rows fresh while modal is open.
|
||||||
|
|
||||||
|
### Footer notification
|
||||||
|
|
||||||
|
`StatusBarViewModel`:
|
||||||
|
- New `string? PrimeStatus` property.
|
||||||
|
- Subscribes to `WorkerClient.PrimeFired`.
|
||||||
|
- On event: set `PrimeStatus`, start a `DispatcherTimer` for 5s, clear on tick.
|
||||||
|
- `StatusBarView` gets a `TextBlock` bound to `PrimeStatus`, right-aligned, dim-foreground, only visible when non-empty.
|
||||||
|
|
||||||
|
Format: `"✓ Primed Claude at 07:01"` or `"⚠ Prime failed: <reason>"`.
|
||||||
|
|
||||||
|
### About wiring
|
||||||
|
|
||||||
|
- `MainWindowViewModel` adds `[RelayCommand] OpenAbout()` — opens `AboutModalView` via the existing dialog factory pattern.
|
||||||
|
- `MainWindow.axaml` Help menu gains `<MenuItem Header="About…" Command="{Binding OpenAboutCommand}"/>`.
|
||||||
|
|
||||||
|
## Tests
|
||||||
|
|
||||||
|
### `ClaudeDo.Worker.Tests/Prime/PrimeSchedulerTests.cs`
|
||||||
|
|
||||||
|
Real SQLite, fake `IPrimeClock`, fake `IPrimeRunner`. Cases:
|
||||||
|
- Fires once at exact target time.
|
||||||
|
- Fires immediately on startup if within catch-up window.
|
||||||
|
- Skips firing if past catch-up window (waits for next eligible day).
|
||||||
|
- Honors `WorkdaysOnly` (no fire on Sat/Sun).
|
||||||
|
- Honors date range (no fire before StartDate, none after EndDate).
|
||||||
|
- Idempotent: doesn't double-fire if `LastRunAt` is today.
|
||||||
|
- Recomputes on signal (upsert mid-wait).
|
||||||
|
- Disabling a schedule mid-wait recomputes.
|
||||||
|
|
||||||
|
### `ClaudeDo.Ui.Tests/ViewModels/PrimeClaudeTabViewModelTests.cs`
|
||||||
|
|
||||||
|
Cases:
|
||||||
|
- Add row appends with sensible defaults.
|
||||||
|
- Remove row removes from collection.
|
||||||
|
- Validation: StartDate > EndDate flags row as invalid.
|
||||||
|
- Save serializes all rows to repository in one batch.
|
||||||
|
- `PrimeFired` event updates the matching row's `LastRunAt`.
|
||||||
|
|
||||||
|
### `ClaudeDo.Ui.Tests/ViewModels/StatusBarViewModelTests.cs` (extend existing if present, else new)
|
||||||
|
|
||||||
|
- `PrimeFired` sets `PrimeStatus` and clears it after 5s (use a fake `IDispatcherTimer` or an injectable delay).
|
||||||
|
|
||||||
|
## Migration / rollout
|
||||||
|
|
||||||
|
- Single EF migration `AddPrimeSchedules`. Existing DBs upgrade on next launch via the existing migration runner (no manual step).
|
||||||
|
- No data backfill — table starts empty. Users add schedules manually via the new tab.
|
||||||
|
- Backwards compatibility for `AppSettingsEntity`: untouched.
|
||||||
|
|
||||||
|
## Risks & mitigations
|
||||||
|
|
||||||
|
| Risk | Mitigation |
|
||||||
|
|---|---|
|
||||||
|
| App is closed at scheduled time | 30 min catch-up on launch; explicit copy in tab explains the limitation. |
|
||||||
|
| Clock/timezone change while waiting | `Task.Delay` fires on monotonic time; recompute after each fire catches drift on next iteration. Acceptable for a 5h-window primer. |
|
||||||
|
| Claude CLI hangs | 60s timeout on the spawn; failure stamped + broadcast. |
|
||||||
|
| Multiple ClaudeDo instances on same machine | Out of scope (existing app already assumes single instance via fixed SignalR port). |
|
||||||
|
| User edits schedule while scheduler is mid-fire | Fire completes, then signal triggers recompute. No race — `UpdateLastRunAsync` is the last write. |
|
||||||
|
|
||||||
|
## Open questions
|
||||||
|
|
||||||
|
None at design time. Implementation may surface small details (e.g. exact Avalonia controls for date/time pickers — likely `CalendarDatePicker` + a `TextBox` masked to `HH:mm` since Avalonia 12 has no built-in TimePicker on all platforms).
|
||||||
@@ -0,0 +1,206 @@
|
|||||||
|
# Worktree Overview Modal — Design
|
||||||
|
|
||||||
|
**Status:** Approved
|
||||||
|
**Date:** 2026-05-19
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
Worktree management is becoming hard to oversee. The current UI only exposes per-task worktree actions (merge / keep / discard) from `TaskDetailView`, plus two global maintenance buttons (`CleanupFinishedWorktrees`, `ResetAllWorktrees`). There is no view that shows *all existing worktrees at a glance* with their state, age, branch, and diff stat. Stale or "phantom" worktrees (DB row but missing directory, or vice versa) have no targeted recovery path.
|
||||||
|
|
||||||
|
## Goals
|
||||||
|
|
||||||
|
- A modal that lists every worktree row from the DB, joined with task + list metadata.
|
||||||
|
- Two entry points: filtered to one list (List context menu), and global grouped by list (Help menu).
|
||||||
|
- Quick per-row actions hidden behind a right-click context menu.
|
||||||
|
- Targeted force-remove for stuck / phantom worktrees.
|
||||||
|
- Manual refresh only; no live SignalR subscription needed.
|
||||||
|
|
||||||
|
## Non-Goals
|
||||||
|
|
||||||
|
- No auto-refresh / live updates from SignalR events.
|
||||||
|
- No UI tests (the project has none for the Ui project).
|
||||||
|
- No changes to `WorktreeManager`, `TaskRunner`, or the existing per-worktree file-tree modal (`WorktreeModalView`) — it gets reused as the "Show diff" target.
|
||||||
|
|
||||||
|
## UI
|
||||||
|
|
||||||
|
### New view pair
|
||||||
|
|
||||||
|
`WorktreesOverviewModalView` + `WorktreesOverviewModalViewModel`, parallel to existing `WorktreeModalView` (which shows the *file tree inside one* worktree).
|
||||||
|
|
||||||
|
### Layout
|
||||||
|
|
||||||
|
```
|
||||||
|
┌─ Worktrees [List "Foo"] or Worktrees (all) ───────────────┐
|
||||||
|
│ [ Refresh ] [ Cleanup finished ] │
|
||||||
|
│ │
|
||||||
|
│ ▼ List Foo (global mode only) │
|
||||||
|
│ Title Branch State +/- Age │
|
||||||
|
│ Fix login bug claudedo/ab… Active +42-7 3h ago │
|
||||||
|
│ Add API … claudedo/cd… Merged +8 -0 1d ago │
|
||||||
|
│ ▼ List Bar │
|
||||||
|
│ … │
|
||||||
|
└──────────────────────────────────────────────────────────────┘
|
||||||
|
```
|
||||||
|
|
||||||
|
- `DataGrid` (or `ItemsControl` with Grid template) for rows.
|
||||||
|
- List-filtered mode: no group headers, just the table.
|
||||||
|
- Global mode: `Expander` per list with list name as header (default expanded).
|
||||||
|
- State as a colored badge — new `WorktreeStateColorConverter` analogous to `StatusColorConverter`:
|
||||||
|
- Active=Blue, Merged=Green, Discarded=Gray, Kept=Orange.
|
||||||
|
- Right-click on a row opens a `MenuFlyout` with all actions.
|
||||||
|
- Phantom rows (`PathExistsOnDisk == false`) get a small warning icon in the Path tooltip area.
|
||||||
|
|
||||||
|
### Default sort
|
||||||
|
|
||||||
|
State (Active first), then `CreatedAt` descending. Same inside each list group in global mode.
|
||||||
|
|
||||||
|
### Per-row context menu
|
||||||
|
|
||||||
|
| Item | Enabled when | Behavior |
|
||||||
|
|---|---|---|
|
||||||
|
| Show diff | always | Opens existing `WorktreeModalView` with `WorktreePath` set |
|
||||||
|
| Open in Explorer | `PathExistsOnDisk == true` | `Process.Start("explorer.exe", path)` |
|
||||||
|
| Jump to task | always | Closes modal, selects list + task in main window |
|
||||||
|
| Merge | `State == Active` | Calls existing `MergeTask` hub method |
|
||||||
|
| Discard | `State == Active` | `SetWorktreeState(taskId, Discarded)` |
|
||||||
|
| Keep | `State == Active` | `SetWorktreeState(taskId, Kept)` |
|
||||||
|
| Copy branch | always | Clipboard |
|
||||||
|
| Copy path | always | Clipboard |
|
||||||
|
| —————— | | (separator) |
|
||||||
|
| Force remove | `Task.Status != Running` | Confirmation dialog → `ForceRemoveWorktree(taskId)` (red label) |
|
||||||
|
|
||||||
|
### Bulk buttons (toolbar)
|
||||||
|
|
||||||
|
- **Refresh** — re-runs `GetWorktreesOverview`.
|
||||||
|
- **Cleanup finished** — `CleanupFinishedWorktrees(listId)`; in list-filtered mode acts on that list, in global mode on all.
|
||||||
|
|
||||||
|
### Entry points
|
||||||
|
|
||||||
|
- **List context menu** → "Worktrees anzeigen…" → opens modal in filtered mode (`listId` = the list).
|
||||||
|
- **Help menu** → "Worktrees" → opens modal in global mode (`listId = null`).
|
||||||
|
|
||||||
|
`MainWindowViewModel` gets `OpenWorktreesOverviewCommand(listId)` and `OpenWorktreesOverviewGlobalCommand()`, both using a DI `Func<WorktreesOverviewModalViewModel>` factory analogous to existing editor patterns.
|
||||||
|
|
||||||
|
## SignalR Contract
|
||||||
|
|
||||||
|
### New `WorkerHub` methods
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Task<IReadOnlyList<WorktreeOverviewDto>> GetWorktreesOverview(string? listId);
|
||||||
|
Task<bool> SetWorktreeState(string taskId, WorktreeState newState);
|
||||||
|
Task<ForceRemoveResultDto> ForceRemoveWorktree(string taskId);
|
||||||
|
```
|
||||||
|
|
||||||
|
`CleanupFinishedWorktrees` already exists — extend its signature to accept an optional `listId`:
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
Task<CleanupResult> CleanupFinishedWorktrees(string? listId); // was: ()
|
||||||
|
```
|
||||||
|
|
||||||
|
`MergeTask` is reused unchanged.
|
||||||
|
|
||||||
|
### DTOs
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public sealed record WorktreeOverviewDto(
|
||||||
|
string TaskId,
|
||||||
|
string TaskTitle,
|
||||||
|
TaskStatus TaskStatus,
|
||||||
|
string ListId,
|
||||||
|
string ListName,
|
||||||
|
string Path,
|
||||||
|
string BranchName,
|
||||||
|
WorktreeState State,
|
||||||
|
string? DiffStat,
|
||||||
|
DateTime CreatedAt,
|
||||||
|
bool PathExistsOnDisk);
|
||||||
|
|
||||||
|
public sealed record ForceRemoveResultDto(bool Removed, string? Reason);
|
||||||
|
```
|
||||||
|
|
||||||
|
### Broadcasts
|
||||||
|
|
||||||
|
After successful `SetWorktreeState` and `ForceRemoveWorktree`, fire `HubBroadcaster.WorktreeUpdated(taskId)` so `TaskDetailView` (if open) refreshes. `CleanupFinishedWorktrees` already broadcasts; keep behavior, optionally batch.
|
||||||
|
|
||||||
|
### `WorkerClient` (UI)
|
||||||
|
|
||||||
|
Add wrapper methods for the four new/changed hub calls.
|
||||||
|
|
||||||
|
## Backend Changes
|
||||||
|
|
||||||
|
### `WorktreeMaintenanceService`
|
||||||
|
|
||||||
|
```csharp
|
||||||
|
public sealed record ForceRemoveResult(bool Removed, string? Reason);
|
||||||
|
|
||||||
|
public Task<IReadOnlyList<WorktreeOverviewRow>> GetOverviewAsync(string? listId, CancellationToken ct);
|
||||||
|
public Task<CleanupResult> CleanupFinishedAsync(string? listId, CancellationToken ct); // signature extended
|
||||||
|
public Task<ForceRemoveResult> ForceRemoveAsync(string taskId, CancellationToken ct);
|
||||||
|
```
|
||||||
|
|
||||||
|
- `GetOverviewAsync` — joins `worktrees × tasks × lists` (`AsNoTracking`), maps to DTO including `PathExistsOnDisk = Directory.Exists(path)`.
|
||||||
|
- `CleanupFinishedAsync(listId)` — same join as today but also filters `t.ListId == listId` when not null.
|
||||||
|
- `ForceRemoveAsync` — refactors existing `TryRemoveAsync(row, force: true, …)` into a single-row entry point shared with `ResetAllAsync`. Refuses when the task is currently `Running`, returning `ForceRemoveResult(false, "task is currently running")`. Otherwise removes the worktree directory, prunes, deletes the branch, deletes the DB row.
|
||||||
|
|
||||||
|
### `WorktreeRepository`
|
||||||
|
|
||||||
|
`SetStateAsync(string taskId, WorktreeState newState, CancellationToken ct)` already documented in CLAUDE.md. If absent, add it; if present, just expose it via the hub.
|
||||||
|
|
||||||
|
### Unchanged
|
||||||
|
|
||||||
|
`WorktreeManager`, `TaskRunner`, `WorktreeModalView`, all existing merge / cleanup flows.
|
||||||
|
|
||||||
|
## Data Flow
|
||||||
|
|
||||||
|
1. User opens modal → `WorkerClient.GetWorktreesOverviewAsync(listId)` → bind rows.
|
||||||
|
2. Refresh button → same call.
|
||||||
|
3. Per-row action → corresponding hub call → on success, update the affected row locally (no full reload).
|
||||||
|
4. Bulk Cleanup → hub call → full reload.
|
||||||
|
|
||||||
|
## Force-Remove Semantics
|
||||||
|
|
||||||
|
| Initial state | Result |
|
||||||
|
|---|---|
|
||||||
|
| Active, task not Running | Worktree dir removed, branch deleted, DB row deleted. Task remains in current status (Done/Failed/Idle). |
|
||||||
|
| Active, task Running | Refused with reason "task is currently running". |
|
||||||
|
| Merged / Discarded / Kept | Same removal path. |
|
||||||
|
| Phantom (dir missing) | DB row deleted, branch best-effort deleted. |
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
New tests in `tests/ClaudeDo.Worker.Tests/Services/WorktreeMaintenanceServiceTests.cs` (real SQLite, real git):
|
||||||
|
|
||||||
|
1. `GetOverviewAsync_returns_all_when_listId_null`
|
||||||
|
2. `GetOverviewAsync_filters_by_listId`
|
||||||
|
3. `GetOverviewAsync_flags_PathExistsOnDisk_false_for_phantom_row`
|
||||||
|
4. `CleanupFinishedAsync_filters_by_listId`
|
||||||
|
5. `ForceRemoveAsync_removes_active_worktree` (happy path incl. branch delete)
|
||||||
|
6. `ForceRemoveAsync_blocked_when_task_running`
|
||||||
|
7. `ForceRemoveAsync_removes_phantom_row`
|
||||||
|
|
||||||
|
UI verification (manual):
|
||||||
|
|
||||||
|
- Open from list context menu → only that list's rows.
|
||||||
|
- Open from Help menu → all lists grouped, default expanded.
|
||||||
|
- Force-remove an Active worktree → row vanishes, DB row gone, branch deleted.
|
||||||
|
- Force-remove while task Running → toast / dialog with reason, row unchanged.
|
||||||
|
- Cleanup finished in filtered mode → only finished rows of the selected list disappear.
|
||||||
|
- "Show diff" reuses existing `WorktreeModalView`.
|
||||||
|
|
||||||
|
## Files Touched
|
||||||
|
|
||||||
|
**New:**
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Modals/WorktreesOverviewModalViewModel.cs`
|
||||||
|
- `src/ClaudeDo.Ui/Views/Modals/WorktreesOverviewModalView.axaml`
|
||||||
|
- `src/ClaudeDo.Ui/Views/Modals/WorktreesOverviewModalView.axaml.cs`
|
||||||
|
- `src/ClaudeDo.Ui/Converters/WorktreeStateColorConverter.cs`
|
||||||
|
- `src/ClaudeDo.Worker/Worktrees/WorktreeOverviewDto.cs` (or extend an existing DTOs file)
|
||||||
|
|
||||||
|
**Modified:**
|
||||||
|
- `src/ClaudeDo.Worker/Worktrees/WorktreeMaintenanceService.cs`
|
||||||
|
- `src/ClaudeDo.Worker/Hub/WorkerHub.cs`
|
||||||
|
- `src/ClaudeDo.Ui/Services/WorkerClient.cs`
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/MainWindowViewModel.cs`
|
||||||
|
- `src/ClaudeDo.Ui/Views/MainWindow.axaml` (Help menu entry, list context menu entry)
|
||||||
|
- `src/ClaudeDo.App/Program.cs` (DI registration of new VM)
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/Services/WorktreeMaintenanceServiceTests.cs`
|
||||||
@@ -0,0 +1,118 @@
|
|||||||
|
# Planning: Draft → Planned → Queue gate
|
||||||
|
|
||||||
|
**Date:** 2026-05-29
|
||||||
|
**Status:** Approved (design)
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
When a planning parent is finalized, `PlanningChainCoordinator.SetupChainAsync` immediately
|
||||||
|
enqueues the entire child chain (child[0] runs, successors wait blocked on their predecessor).
|
||||||
|
There is no review step: a user cannot hold finalized subtasks in a "ready but not running"
|
||||||
|
state, and the "DRAFT" label in the UI is only a derived side effect
|
||||||
|
(`TaskRowViewModel.IsDraft => IsChild && Status == Idle`) with no gate behind it — a draft
|
||||||
|
child already satisfies `CanSendToQueue` and can be queued directly.
|
||||||
|
|
||||||
|
We want an explicit lifecycle for planning children:
|
||||||
|
|
||||||
|
- **Draft** — child of a plan still being built (parent `PlanningPhase == Active`). Not queueable.
|
||||||
|
- **Planned** — child of a finalized plan (parent `PlanningPhase == Finalized`), still `Idle`. Queueable.
|
||||||
|
|
||||||
|
Finalizing a plan promotes its children Draft → Planned **without** queuing anything. The user
|
||||||
|
then explicitly sends the plan to the queue, which builds the sequential chain (today's behavior,
|
||||||
|
just user-triggered). The gate is enforced in both the UI and the server so no path (UI, MCP,
|
||||||
|
external agents) can queue or run a Draft child.
|
||||||
|
|
||||||
|
## Decisions
|
||||||
|
|
||||||
|
- **Q1 — Finalize semantics:** Finalize auto-marks children **Planned** (not Draft); nothing is
|
||||||
|
queued until the user explicitly sends to queue. Draft exists only while the plan is unfinalized.
|
||||||
|
- **Q2 — Queue granularity:** A single **parent-level** "Send plan to queue" action queues all
|
||||||
|
Planned children as a sequential chain (reuses `SetupChainAsync`). No per-child queueing.
|
||||||
|
- **Q3 — Enforcement:** UI **and** server. The gate is a server invariant in `TaskStateService`,
|
||||||
|
so MCP / external agents are bound by it too.
|
||||||
|
- **Data model — Approach 1 (derive, no schema change):** Draft/Planned is a pure function of the
|
||||||
|
parent's `PlanningPhase`. No new column, no migration, no parent/child drift.
|
||||||
|
|
||||||
|
## Core invariant
|
||||||
|
|
||||||
|
No schema change. A child task's stage is derived from its parent's `PlanningPhase`:
|
||||||
|
|
||||||
|
| Parent `PlanningPhase` | Child (`Status = Idle`) | Queueable? |
|
||||||
|
|---|---|---|
|
||||||
|
| `Active` (plan being built) | **DRAFT** | no |
|
||||||
|
| `Finalized` | **PLANNED** | yes |
|
||||||
|
|
||||||
|
**Server invariant:** a child task (`ParentTaskId != null`) may transition `Idle → Queued` or
|
||||||
|
`Idle → Running` **only if** its parent's `PlanningPhase == Finalized`. Standalone (non-child)
|
||||||
|
tasks are unaffected.
|
||||||
|
|
||||||
|
A failed/cancelled child returning to `Idle` while its parent is still `Finalized` is therefore
|
||||||
|
"Planned" again and re-queueable — desired.
|
||||||
|
|
||||||
|
## Components
|
||||||
|
|
||||||
|
### Worker / server
|
||||||
|
|
||||||
|
1. **`TaskStateService` transition guard** — the single enforcement point. When a child task is
|
||||||
|
about to enter `Queued` or `Running`, look up the parent's `PlanningPhase`; if it is not
|
||||||
|
`Finalized`, return a failed `TransitionResult` (no exception — consistent with the existing
|
||||||
|
no-throw transition pattern). This covers:
|
||||||
|
- UI single-task enqueue (`SetTaskStatus → Queued`)
|
||||||
|
- `RunNow` (`StartRunningAsync`, `Idle → Running`)
|
||||||
|
- the queue picker's `Queued → Running` claim (defense in depth; a Draft child can't reach
|
||||||
|
`Queued` in the first place)
|
||||||
|
- MCP `UpdateTaskStatus(Queued)` / `RunTaskNow`
|
||||||
|
|
||||||
|
2. **Finalize stops auto-queuing** — audit every `FinalizeAsync(taskId, queueAgentTasks, ct)`
|
||||||
|
call site and pass `queueAgentTasks: false`. Known callers to update: the UI finalize command
|
||||||
|
and the planning-MCP finalize tool. After this, `FinalizeAsync` only flips the parent to
|
||||||
|
`Finalized` (children become Planned); `SetupChainAsync` is no longer invoked from finalize.
|
||||||
|
|
||||||
|
3. **New queue action** — add `WorkerHub.QueuePlan(parentTaskId)` →
|
||||||
|
`PlanningChainCoordinator.SetupChainAsync(parentTaskId)`. Guarded so it only runs when the
|
||||||
|
parent is `Finalized`; otherwise returns a failure the UI surfaces. This is the user-triggered
|
||||||
|
replacement for the auto-chain.
|
||||||
|
|
||||||
|
### UI
|
||||||
|
|
||||||
|
4. **`TaskRowViewModel`**
|
||||||
|
- Add `ParentFinalized` (`bool`), set by `TasksIslandViewModel`.
|
||||||
|
- `IsDraft => IsChild && Status == Idle && !ParentFinalized`
|
||||||
|
- `IsPlanned => IsChild && Status == Idle && ParentFinalized`
|
||||||
|
- `CanSendToQueue` gains `&& (!IsChild || ParentFinalized)`
|
||||||
|
- Child badge renders `DRAFT` / `PLANNED` (drive off `IsDraft` / `IsPlanned`).
|
||||||
|
- Raise `PropertyChanged` for the new derived members from the relevant `On*Changed` hooks
|
||||||
|
(`OnStatusChanged`, `OnParentTaskIdChanged`, and a new `OnParentFinalizedChanged`).
|
||||||
|
|
||||||
|
5. **`TasksIslandViewModel`** — when building/refreshing rows, resolve each child's parent
|
||||||
|
`PlanningPhase` from the loaded task set and set `ParentFinalized`. If the parent is not in the
|
||||||
|
loaded set, default to `false` (Draft — the safe, non-queueable default).
|
||||||
|
|
||||||
|
6. **`DetailsIslandViewModel`**
|
||||||
|
- `CanEnqueue` for a selected child additionally requires the parent to be `Finalized`.
|
||||||
|
- Add a parent-level **"Send plan to queue"** command, enabled when the selected task is a
|
||||||
|
`Finalized` planning parent with at least one Planned (`Idle`) child and nothing already
|
||||||
|
queued/running; calls `QueuePlanAsync(parentId)`.
|
||||||
|
|
||||||
|
7. **`IWorkerClient` / `WorkerClient`** — add `QueuePlanAsync(string parentId)`. Update the test
|
||||||
|
fakes (UI + Worker test projects) to implement the new member.
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
- **Worker (`TaskStateService`):** child enqueue/run rejected when parent `Active`; allowed when
|
||||||
|
parent `Finalized`. Standalone task enqueue still allowed. Picker skips/ignores draft children.
|
||||||
|
- **Worker (finalize):** `FinalizeAsync(..., queueAgentTasks: false)` flips parent to `Finalized`
|
||||||
|
and queues nothing; children remain `Idle`.
|
||||||
|
- **Worker (`QueuePlan`):** on a `Finalized` parent, builds the sequential chain (child[0]
|
||||||
|
unblocked + queued, successors blocked on predecessor); on a non-`Finalized` parent, fails.
|
||||||
|
- **UI VM (`TaskRowViewModel`):** Draft vs Planned derivation and `CanSendToQueue` gating across
|
||||||
|
parent phases; badge text.
|
||||||
|
- **UI VM (`DetailsIslandViewModel`):** `CanEnqueue` gating for children; "Send plan to queue"
|
||||||
|
enablement.
|
||||||
|
|
||||||
|
## Out of scope
|
||||||
|
|
||||||
|
- Per-child manual promotion while a plan is still being built (Draft → Planned without
|
||||||
|
finalizing). Promotion happens only via finalize.
|
||||||
|
- Per-child independent queueing (Q2 = parent-level chain only).
|
||||||
|
- Any database schema / migration change.
|
||||||
@@ -0,0 +1,138 @@
|
|||||||
|
# Repo Import List Helper — Design
|
||||||
|
|
||||||
|
**Date:** 2026-05-29
|
||||||
|
**Status:** Approved (pending spec review)
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
Creating lists is one-at-a-time: click `+ New list`, then open List Settings to set the
|
||||||
|
working directory. Users with many repos under a few parent folders want to wire them all up
|
||||||
|
in one pass.
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
A "list helper" that scans one or more parent folders for git repos, presents them as a
|
||||||
|
checklist, and bulk-creates a list (with `WorkingDir` pre-filled) for each ticked repo.
|
||||||
|
|
||||||
|
## Entry Points
|
||||||
|
|
||||||
|
1. **Help menu** — the title-bar dropdown in `MainWindow.axaml` that contains `About…`,
|
||||||
|
`Worktrees…`, etc. Add a new `MenuItem` `Add repos as lists…` wired to a command on
|
||||||
|
`MainWindowViewModel`.
|
||||||
|
2. **Lists island** — a small folder icon button beside the existing `+ New list` button in
|
||||||
|
`ListsIslandView.axaml`, wired to a command on `ListsIslandViewModel`.
|
||||||
|
|
||||||
|
Both open the same modal.
|
||||||
|
|
||||||
|
## Components
|
||||||
|
|
||||||
|
### `RepoScanner` (new, `ClaudeDo.Ui/Services` or `ClaudeDo.Data`)
|
||||||
|
|
||||||
|
Pure filesystem helper, no git library. Given a parent folder path, enumerates immediate
|
||||||
|
subdirectories and returns those that contain a `.git` entry (directory or file). Kept
|
||||||
|
separate from the VM so it is unit-testable.
|
||||||
|
|
||||||
|
```
|
||||||
|
IReadOnlyList<RepoCandidate> Scan(string parentFolder)
|
||||||
|
record RepoCandidate(string Name, string FullPath)
|
||||||
|
```
|
||||||
|
|
||||||
|
- Skips the parent itself; only immediate children are considered (non-recursive).
|
||||||
|
- `.git` may be a directory (normal repo) or a file (worktree/submodule) — both count.
|
||||||
|
- Returns empty on missing/unreadable folder rather than throwing.
|
||||||
|
|
||||||
|
### `RepoImportModalViewModel` (new, `ClaudeDo.Ui/ViewModels/Modals`)
|
||||||
|
|
||||||
|
Follows the existing modal-VM pattern (`CloseAction`, resolved from DI).
|
||||||
|
|
||||||
|
Dependencies:
|
||||||
|
- `IDbContextFactory<ClaudeDoDbContext>` — load existing lists' `WorkingDir` values (for the
|
||||||
|
"already added" check) and create new `ListEntity` rows. Same dependency
|
||||||
|
`ListsIslandViewModel` already uses.
|
||||||
|
|
||||||
|
State:
|
||||||
|
- `ObservableCollection<RepoImportItemViewModel> Repos` — the combined checklist.
|
||||||
|
- A set of parent folder paths already scanned (to de-dupe re-adds).
|
||||||
|
- `CreateCount` — computed count of ticked-and-new rows (drives the confirm button label).
|
||||||
|
|
||||||
|
Commands:
|
||||||
|
- `AddFolderAsync` — invokes the folder picker (via view code-behind callback, see below),
|
||||||
|
scans each chosen folder with `RepoScanner`, appends new candidates. De-dupes by full path
|
||||||
|
(case-insensitive) against rows already present.
|
||||||
|
- `CreateAsync` — for each ticked, non-existing row, create a `ListEntity` via
|
||||||
|
`ListRepository.AddAsync` (Name = folder name, WorkingDir = full path,
|
||||||
|
DefaultCommitType = `CommitTypeRegistry.DefaultType`, fresh `Guid` id, `CreatedAt` = now).
|
||||||
|
Then `CloseAction()`.
|
||||||
|
- `Cancel` — `CloseAction()`.
|
||||||
|
|
||||||
|
On load, fetch all existing lists once and capture their `WorkingDir`s into a case-insensitive
|
||||||
|
set; each appended candidate whose path is in that set is marked `AlreadyAdded`.
|
||||||
|
|
||||||
|
### `RepoImportItemViewModel` (new)
|
||||||
|
|
||||||
|
- `Name`, `FullPath` (display).
|
||||||
|
- `AlreadyAdded` (bool) — true if a list already points at this path.
|
||||||
|
- `IsChecked` ([ObservableProperty]) — defaults `true` for new repos. For already-added rows it
|
||||||
|
is forced `true` and the checkbox is disabled.
|
||||||
|
- `CanToggle` => `!AlreadyAdded` (binds to checkbox `IsEnabled`).
|
||||||
|
|
||||||
|
### `RepoImportModalView` (new, `ClaudeDo.Ui/Views/Modals`)
|
||||||
|
|
||||||
|
A `Window` styled like the other modals (header bar, body, footer), shown via
|
||||||
|
`ShowDialog(owner)`.
|
||||||
|
|
||||||
|
- **Header:** title `ADD REPOS AS LISTS` + close button.
|
||||||
|
- **Top of body:** `Add folder…` button.
|
||||||
|
- **Body:** scrollable `ItemsControl` over `Repos`. Each row = `CheckBox` (IsChecked two-way,
|
||||||
|
IsEnabled = `CanToggle`) + repo name + dim full path + `(already added)` label when
|
||||||
|
`AlreadyAdded`.
|
||||||
|
- **Footer:** `Create {CreateCount} lists` button (disabled when `CreateCount == 0`) + `Cancel`.
|
||||||
|
- Folder picker lives in the code-behind (mirrors `ListSettingsModalView.BrowseClicked`):
|
||||||
|
`OpenFolderPickerAsync` with `AllowMultiple = true`, results handed to the VM's
|
||||||
|
`AddFolderAsync`.
|
||||||
|
|
||||||
|
## Data Flow
|
||||||
|
|
||||||
|
1. User opens the modal from either entry point → modal loads existing lists' `WorkingDir`s.
|
||||||
|
2. User clicks `Add folder…` → picks one or more parent folders → `RepoScanner` finds repos →
|
||||||
|
rows appended (de-duped), already-added rows shown ticked+disabled.
|
||||||
|
3. User adjusts ticks → clicks `Create N lists`.
|
||||||
|
4. VM creates one `ListEntity` per ticked-new row via `ListRepository`.
|
||||||
|
5. Modal closes → the **caller reloads the Lists island** so new lists appear:
|
||||||
|
- Lists-island entry point: `ListsIslandViewModel.LoadAsync()`.
|
||||||
|
- Help-menu entry point: `MainWindowViewModel` reloads its `Lists` (the
|
||||||
|
`ListsIslandViewModel` instance) after the modal closes.
|
||||||
|
|
||||||
|
## DI / Wiring
|
||||||
|
|
||||||
|
- Register `RepoImportModalViewModel` (transient) alongside other modal VMs.
|
||||||
|
- Register `RepoScanner` if implemented as an injected service; a static helper needs no
|
||||||
|
registration.
|
||||||
|
- `ListsIslandViewModel` gains `Func<RepoImportModalViewModel, Task>? ShowRepoImportModal` and
|
||||||
|
an `OpenRepoImportCommand`, wired in `ListsIslandView.axaml.cs` (mirrors
|
||||||
|
`ShowListSettingsModal`).
|
||||||
|
- `MainWindowViewModel` gains the same `Func` + an `OpenRepoImportCommand`, wired in
|
||||||
|
`MainWindow.axaml.cs`.
|
||||||
|
|
||||||
|
## Error Handling
|
||||||
|
|
||||||
|
- Unreadable / missing folders: `RepoScanner` returns empty, no crash.
|
||||||
|
- Re-adding a folder already scanned: de-duped by path, no duplicate rows.
|
||||||
|
- Two ticked repos sharing a folder name: both created (list names are not unique) — acceptable.
|
||||||
|
- List creation failure (rare): best-effort per the existing pattern; do not block remaining
|
||||||
|
creations.
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
- `RepoScanner` unit tests (the testable seam): a temp directory tree with a mix of git repos
|
||||||
|
(`.git` dir), a `.git`-file repo, plain folders, and an empty/missing parent. Assert only the
|
||||||
|
repo subfolders are returned and missing folders yield empty.
|
||||||
|
- VM-level "already added" logic and `CreateCount` can be exercised if a test seam is convenient,
|
||||||
|
but the filesystem scanner is the primary unit under test. UI wiring verified manually.
|
||||||
|
|
||||||
|
## Out of Scope (YAGNI)
|
||||||
|
|
||||||
|
- Recursive / deep scanning.
|
||||||
|
- Inline editing of the list name before creation.
|
||||||
|
- Setting model / system prompt / agent during import (tuned later per-list in List Settings).
|
||||||
|
- Picking repo folders directly (only parent-folder scan, per decision).
|
||||||
@@ -0,0 +1,165 @@
|
|||||||
|
# Worker per-user autostart (drop Windows service)
|
||||||
|
|
||||||
|
Status: approved 2026-05-29
|
||||||
|
Author: brainstorm session (mika kuns + Claude)
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
The worker runs as a Windows **service** registered under `LocalSystem`. The worker
|
||||||
|
shells out to the `claude` CLI, whose authentication is stored per-user
|
||||||
|
(`%USERPROFILE%\.claude`). Under `LocalSystem` the worker uses the system profile and
|
||||||
|
cannot see the user's Claude login, so task execution fails. The installer even exposes a
|
||||||
|
"Current User" service-account radio that the backend rejects (`RegisterServiceStep`
|
||||||
|
fails the install). Net effect: the only installable configuration cannot authenticate
|
||||||
|
Claude.
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Run the worker as the logged-in **user** so it inherits the user's Claude auth, starting
|
||||||
|
automatically at logon and staying alive in the background (independent of the desktop
|
||||||
|
app, so Prime/scheduled tasks fire when the UI is closed).
|
||||||
|
|
||||||
|
## Decisions (locked)
|
||||||
|
|
||||||
|
1. **Lifetime:** background from logon, always — independent of the UI.
|
||||||
|
2. **Mechanism:** per-user **logon Scheduled Task** (`schtasks`), run only when the user is
|
||||||
|
logged on (no stored password), hidden, with restart-on-failure.
|
||||||
|
3. **No console window:** worker becomes `WinExe`; add a **Serilog rolling file sink** so
|
||||||
|
worker diagnostics aren't lost.
|
||||||
|
4. **App ensures running:** "Restart Worker" becomes process-based; on app startup, if
|
||||||
|
SignalR doesn't connect within a few seconds, the app launches the worker.
|
||||||
|
5. **Auto-migrate:** the installer detects and removes the old `ClaudeDoWorker` service,
|
||||||
|
then registers the task. Uninstall removes the task + kills the worker process.
|
||||||
|
|
||||||
|
## Non-goals
|
||||||
|
|
||||||
|
- Cross-account elevation (admin elevates as a *different* account than the interactive
|
||||||
|
user). Single-user / user-is-admin is assumed; the task targets the interactive user.
|
||||||
|
- Running the worker when no user is logged on (that's the whole point — it must be a user
|
||||||
|
session for Claude auth).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Component changes
|
||||||
|
|
||||||
|
### ClaudeDo.Worker
|
||||||
|
|
||||||
|
- **`ClaudeDo.Worker.csproj`**: `<OutputType>WinExe</OutputType>`. Add packages
|
||||||
|
`Serilog.AspNetCore` and `Serilog.Sinks.File`.
|
||||||
|
- **`Program.cs`**:
|
||||||
|
- Remove `builder.Host.UseWindowsService(...)`.
|
||||||
|
- Configure Serilog file sink: path `<LogRoot>/worker-.log`, `rollingInterval: Day`,
|
||||||
|
`retainedFileCountLimit: 7`, shared write. `LogRoot` comes from `WorkerConfig`
|
||||||
|
(expand `~`). Wire via `builder.Host.UseSerilog(...)`.
|
||||||
|
- **Single-instance guard:** at startup create `new Mutex(true, @"Local\ClaudeDoWorker",
|
||||||
|
out var createdNew)`. If `!createdNew`, log "another worker instance is already
|
||||||
|
running" and exit 0. Hold the mutex for process lifetime. `Local\` namespace = per
|
||||||
|
user session, which is what we want.
|
||||||
|
- CLI preflight (`ClaudeCliPreflight`) behavior unchanged.
|
||||||
|
|
||||||
|
### ClaudeDo.Installer
|
||||||
|
|
||||||
|
- **New `Steps/RegisterAutostartStep.cs`** (`IInstallStep`, "Register Autostart"):
|
||||||
|
- Build a Task Scheduler **definition XML** (UTF-16) and register via
|
||||||
|
`schtasks /Create /TN "ClaudeDoWorker" /XML "<tmpfile>" /F`.
|
||||||
|
- XML shape:
|
||||||
|
- `Principals/Principal`: `UserId` = current interactive user
|
||||||
|
(`WindowsIdentity.GetCurrent().Name`), `LogonType=InteractiveToken`,
|
||||||
|
`RunLevel=LeastPrivilege`.
|
||||||
|
- `Triggers/LogonTrigger` with the same `UserId`.
|
||||||
|
- `Settings`: `Hidden=true`, `MultipleInstancesPolicy=IgnoreNew`,
|
||||||
|
`StartWhenAvailable=true`, `ExecutionTimeLimit=PT0S`,
|
||||||
|
`DisallowStartIfOnBatteries=false`, `StopIfGoingOnBatteries=false`,
|
||||||
|
`RestartOnFailure` with `Interval` (>= `PT1M`; Task Scheduler's minimum granularity
|
||||||
|
is one minute) and `Count=3`.
|
||||||
|
- `Actions/Exec/Command`: quoted path to `<installDir>/worker/ClaudeDo.Worker.exe`.
|
||||||
|
- The XML builder is a **pure function** (string in → XML string out) so it is unit
|
||||||
|
testable without admin.
|
||||||
|
- **`MigrateServiceStep`** (or folded into `RegisterAutostartStep` as a first phase):
|
||||||
|
detect the old service via `sc query ClaudeDoWorker`; if present, `sc stop` then
|
||||||
|
`sc delete` (poll for clearance like the old `RegisterServiceStep` did). No-op when the
|
||||||
|
service doesn't exist (fresh installs).
|
||||||
|
- **Rename `StopServiceStep` → `StopWorkerStep`, `StartServiceStep` → `StartWorkerStep`**,
|
||||||
|
reworked to be process/task based:
|
||||||
|
- Stop: `schtasks /End /TN ClaudeDoWorker` (ignore errors) + kill any
|
||||||
|
`ClaudeDo.Worker` process whose `MainModule.FileName` is under the install dir;
|
||||||
|
wait for exit. This unlocks `worker/` binaries before extract.
|
||||||
|
- Start: `schtasks /Run /TN ClaudeDoWorker` (preferred — launches as the task principal).
|
||||||
|
Used by fresh install (so the worker runs immediately rather than waiting for next
|
||||||
|
logon) and by Settings "restart".
|
||||||
|
- **`Pages/ServicePage/ServicePageViewModel.cs`**: remove `IsLocalSystem`/`IsCurrentUser`
|
||||||
|
radios and `ServiceAccount` usage. Keep SignalR port, Claude CLI path, "Start at logon"
|
||||||
|
toggle (`AutoStart`), restart delay (maps to task `RestartOnFailure/Interval`, clamped
|
||||||
|
to >= 1 min). Update `ServicePageView.xaml` accordingly. Remove `ServiceAccount` from
|
||||||
|
`InstallContext`.
|
||||||
|
- **`RegisterServiceStep.cs`**: deleted (replaced by `RegisterAutostartStep`).
|
||||||
|
- **Pipelines (`InstallPageViewModel`)**:
|
||||||
|
- Fresh: DownloadAndExtract → WriteConfig → InitDatabase → **RegisterAutostart** (incl.
|
||||||
|
migration no-op) → CreateShortcuts → WriteUninstallRegistry → WriteInstallManifest →
|
||||||
|
**StartWorker**.
|
||||||
|
- Update: **StopWorker** → DownloadAndExtract → **RegisterAutostart** (migrates old
|
||||||
|
service) → **StartWorker** → WriteInstallManifest → WriteUninstallRegistry.
|
||||||
|
- **DI (`App.xaml.cs`)**: register the renamed/new steps (concrete + `IInstallStep` where
|
||||||
|
needed, following the existing double-registration pattern).
|
||||||
|
- **`Core/UninstallRunner.cs`**: replace `sc delete ClaudeDoWorker` with
|
||||||
|
`schtasks /Delete /TN ClaudeDoWorker /F` and kill the worker process; also `sc delete`
|
||||||
|
the legacy service best-effort (in case an old service still lingers).
|
||||||
|
|
||||||
|
### ClaudeDo.Ui / ClaudeDo.App
|
||||||
|
|
||||||
|
- **New `Services/WorkerLocator.cs`**: resolve `<installDir>/worker/ClaudeDo.Worker.exe`
|
||||||
|
by walking up for `install.json` then registry `InstallLocation` (mirrors
|
||||||
|
`InstallerLocator`).
|
||||||
|
- **`ViewModels/IslandsShellViewModel.cs`**:
|
||||||
|
- `RestartWorkerService`: drop `System.ServiceProcess.ServiceController`. Kill worker
|
||||||
|
process(es) under the install dir, then `Process.Start(workerExe)`.
|
||||||
|
- **Ensure-running:** on startup, if the `WorkerClient` connection isn't established
|
||||||
|
within ~4s, launch the worker via `WorkerLocator` + `Process.Start`. Guarded so it
|
||||||
|
runs at most once per app session.
|
||||||
|
- Remove the `System.ServiceProcess` package reference / usings if no longer used.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## Data flow
|
||||||
|
|
||||||
|
- **Logon:** Task Scheduler starts `ClaudeDo.Worker.exe` in the user session → mutex
|
||||||
|
acquired → Serilog file logging → SignalR hub on `127.0.0.1:47821` → app connects.
|
||||||
|
- **App start with worker down:** app waits ~4s for SignalR; if absent, `Process.Start`
|
||||||
|
worker → mutex acquired → hub up → app connects.
|
||||||
|
- **Duplicate launch (task + app race):** second instance fails the mutex → logs → exits 0.
|
||||||
|
- **Restart Worker button:** kill worker proc → relaunch → mutex reacquired.
|
||||||
|
|
||||||
|
## Error handling
|
||||||
|
|
||||||
|
- `schtasks`/`sc` calls go through the existing `ProcessRunner`; non-zero exits surface as
|
||||||
|
`StepResult.Fail` with the captured output (except best-effort cleanup which is ignored).
|
||||||
|
- Worker single-instance: losing the mutex is a normal, non-error exit (code 0).
|
||||||
|
- App ensure-running: `Process.Start` failures are swallowed (the logon task is the primary
|
||||||
|
mechanism; the app launch is a convenience).
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
- **Unit (no admin required):**
|
||||||
|
- Task-definition XML builder: asserts UserId, LogonType, Hidden, RestartOnFailure
|
||||||
|
interval clamping, quoted command path.
|
||||||
|
- `WorkerLocator`: path resolution via temp `install.json`.
|
||||||
|
- Migration decision: given `sc query` output (exists / not-found), decide stop+delete vs
|
||||||
|
no-op — keep the decision pure, mock `ProcessRunner` output.
|
||||||
|
- Restart-delay → task interval clamping (`< 1 min` → `PT1M`).
|
||||||
|
- **Manual verification (post-build, on this machine):**
|
||||||
|
1. Update from installed `1.0.2-alpha`: old service is removed (`sc query ClaudeDoWorker`
|
||||||
|
→ not found), task exists (`schtasks /Query /TN ClaudeDoWorker`), worker process runs
|
||||||
|
as the user, app connects, no console window.
|
||||||
|
2. Worker log file appears at `~/.todo-app/logs/worker-<date>.log`.
|
||||||
|
3. Kill worker → click Restart Worker in app → reconnects.
|
||||||
|
4. Close app, confirm worker still running (Prime/queue alive); reopen app → connects.
|
||||||
|
5. Log off / log on → worker autostarts.
|
||||||
|
6. Uninstall → task gone, worker process gone, (data kept unless opted out).
|
||||||
|
|
||||||
|
## Risks
|
||||||
|
|
||||||
|
- **Task restart granularity is minutes**, not the old seconds-level service restart. The
|
||||||
|
worker's own long-running resilience + the app ensure-running cover short gaps; acceptable.
|
||||||
|
- **Elevated installer must target the interactive user.** Using
|
||||||
|
`WindowsIdentity.GetCurrent().Name` is correct when the user elevates themselves (the
|
||||||
|
assumed single-user case). Documented non-goal otherwise.
|
||||||
@@ -0,0 +1,125 @@
|
|||||||
|
# External MCP — UI Parity for Start & Observe
|
||||||
|
|
||||||
|
**Date:** 2026-05-30
|
||||||
|
**Status:** Approved (design)
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Expand the always-on **External MCP server** (`ExternalMcpService`, exposed on
|
||||||
|
`cfg.ExternalMcpPort` under `/mcp`) so an external Claude session can **start and
|
||||||
|
observe** ClaudeDo work sessions end-to-end, reaching parity with the desktop UI
|
||||||
|
for those two concerns.
|
||||||
|
|
||||||
|
The server's purpose is deliberately scoped: **help the user start sessions and
|
||||||
|
observe them.** It is *not* a git/worktree console — branch merging, worktree
|
||||||
|
resets, and multi-turn continuation are things Claude does *inside* a task, so
|
||||||
|
they stay out of the tool surface.
|
||||||
|
|
||||||
|
## Scope
|
||||||
|
|
||||||
|
### In scope
|
||||||
|
|
||||||
|
**START — set up and launch a session**
|
||||||
|
- *(existing)* `AddTask`, `UpdateTask`, `UpdateTaskStatus` (Idle/Queued), `RunTaskNow`, `CancelTask`, `DeleteTask`
|
||||||
|
- **List management** — create / rename / delete lists; set working dir + default commit type
|
||||||
|
- **List & task config** — per-list defaults and per-task overrides for `model`, `system_prompt`, `agent_path`
|
||||||
|
- **Agents (read-only)** — list agent files and refresh, so Claude can choose a valid `agent_path`
|
||||||
|
- **Reset failed task** — discard the failed worktree and reset the row to Idle (the retry path)
|
||||||
|
|
||||||
|
**OBSERVE**
|
||||||
|
- *(existing)* `ListTaskLists`, `ListTasks`, `GetTask`
|
||||||
|
- **Run history** — read `task_runs` for a task (session id, tokens, turns, result, structured output, error)
|
||||||
|
- **Logs** — fetch a task's (or run's) log output
|
||||||
|
- **App settings (read-only)** — read worker app settings
|
||||||
|
|
||||||
|
### Out of scope (explicitly excluded)
|
||||||
|
- **Tags** — already removed from the system (migration `20260519044715_RemoveTags`); only the stale doc reference in `src/ClaudeDo.Worker/CLAUDE.md` needs deleting.
|
||||||
|
- **Multi-turn continue** (`--resume`) — Claude's own concern inside a task.
|
||||||
|
- **Worktree ops** — merge, merge targets, cleanup-finished, reset-all, force-remove, set-state.
|
||||||
|
- **Start planning session** — not needed via MCP.
|
||||||
|
- **App settings writes** — risky (e.g. flips permission mode); read-only only.
|
||||||
|
- **Agent file create/edit/delete** — not part of "starting a session".
|
||||||
|
|
||||||
|
## Approach (chosen: A)
|
||||||
|
|
||||||
|
**Reuse existing worker services; split the growing tool surface into focused
|
||||||
|
`[McpServerToolType]` classes.** No business logic is duplicated — each new tool
|
||||||
|
injects the same service the SignalR hub already uses, so MCP behavior stays
|
||||||
|
identical to the UI.
|
||||||
|
|
||||||
|
Adding ~12 tools to the single `ExternalMcpService` would push it past 600 lines
|
||||||
|
across eight unrelated jobs. Instead, organize tools by category, mirroring the
|
||||||
|
existing `External/` + `Planning/` layout:
|
||||||
|
|
||||||
|
| Class (new, in `External/`) | Tools | Backing service |
|
||||||
|
|---|---|---|
|
||||||
|
| `ExternalMcpService` *(existing, unchanged scope)* | task CRUD + run/cancel/status | `TaskRepository`, `QueueService`, `ITaskStateService` |
|
||||||
|
| `ListMcpTools` | `CreateList`, `RenameList`, `DeleteList`, `SetListWorkingDir` (name/dir/commitType) | `ListRepository` |
|
||||||
|
| `ConfigMcpTools` | `GetListConfig`, `SetListConfig`, `SetTaskConfig` (model/system_prompt/agent_path) | `ListRepository`, `TaskRepository.UpdateAgentSettingsAsync` |
|
||||||
|
| `RunHistoryMcpTools` | `ListRuns`, `GetRun`, `GetTaskLog` | `TaskRunRepository`, log file read |
|
||||||
|
| `AgentMcpTools` | `ListAgents`, `RefreshAgents` | `AgentFileService.ScanAsync` |
|
||||||
|
| `LifecycleMcpTools` | `ResetFailedTask` | `TaskResetService.ResetAsync` |
|
||||||
|
| `AppSettingsMcpTools` | `GetAppSettings` | `AppSettingsRepository.GetAsync` |
|
||||||
|
|
||||||
|
(Exact class grouping may be tuned during planning, but each class stays small
|
||||||
|
and single-purpose.)
|
||||||
|
|
||||||
|
## Architecture & wiring
|
||||||
|
|
||||||
|
The external MCP server is a **separate `WebApplication`** built in
|
||||||
|
`Program.cs` (≈ lines 188–217) with its own DI container, distinct from the main
|
||||||
|
SignalR app. Shared singletons (`HubBroadcaster`, `QueueService`,
|
||||||
|
`ITaskStateService`, db factory, `WorkerConfig`) are injected by instance so both
|
||||||
|
apps act on the same runtime state.
|
||||||
|
|
||||||
|
Each new tool class must be:
|
||||||
|
1. Registered in the **external** builder (`externalBuilder.Services.AddScoped<…>()`),
|
||||||
|
alongside any newly required services (`TaskRunRepository`, `AgentFileService`,
|
||||||
|
`TaskResetService` + their dependencies).
|
||||||
|
2. Registered as tools via additional `.WithTools<T>()` calls on the external
|
||||||
|
`AddMcpServer()` chain.
|
||||||
|
|
||||||
|
No change to auth: the existing `ExternalMcpAuthMiddleware` (optional
|
||||||
|
`X-ClaudeDo-Key`, loopback-only otherwise) covers all tools uniformly. No
|
||||||
|
per-tool gating — the surface is read/observe + start, with the one borderline
|
||||||
|
write (`ResetFailedTask`) being a normal retry affordance.
|
||||||
|
|
||||||
|
## Data flow
|
||||||
|
|
||||||
|
- **Start:** Claude calls e.g. `CreateList` → `SetListConfig` → `AddTask(queueImmediately: true)`. Writes go through `ListRepository` / `TaskStateService`, which wake the queue and broadcast `ListUpdated` / `TaskUpdated` so the UI reflects changes live.
|
||||||
|
- **Observe:** Claude calls `ListTasks` / `GetTask` → `ListRuns` / `GetRun` → `GetTaskLog`. Pure reads from `TaskRepository` / `TaskRunRepository` and the log file at `TaskRunEntity.LogPath`.
|
||||||
|
- **Mutations broadcast** the same SignalR events the hub raises, keeping the desktop UI in sync.
|
||||||
|
|
||||||
|
## DTOs
|
||||||
|
|
||||||
|
- `RunDto` — projection of `TaskRunEntity`: `Id`, `RunNumber`, `SessionId`, `IsRetry`, `ResultMarkdown`, `StructuredOutputJson`, `ErrorMarkdown`, `ExitCode`, `TurnCount`, `TokensIn`, `TokensOut`, `StartedAt`, `FinishedAt`.
|
||||||
|
- `AgentDto` — from `AgentInfo` (`Name`, `Description`, `Path`).
|
||||||
|
- `ListConfigDto` — `Model`, `SystemPrompt`, `AgentPath` (reuse the shape already used by the hub).
|
||||||
|
- App-settings read reuses the existing `AppSettingsDto` shape (read-only subset is fine).
|
||||||
|
- Log fetch returns the file contents as a string (with a size cap / tail option decided in planning).
|
||||||
|
|
||||||
|
## Error handling
|
||||||
|
|
||||||
|
Follow the existing `ExternalMcpService` convention: throw
|
||||||
|
`InvalidOperationException` with a clear message for not-found / invalid-input /
|
||||||
|
illegal-state (e.g. "List {id} not found", "Cannot reset a non-failed task").
|
||||||
|
Reuse the guard patterns already present (required-field checks, status checks).
|
||||||
|
`ResetFailedTask` must refuse non-`Failed` tasks.
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
Extend `tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs` (and add
|
||||||
|
sibling test files per new tool class) using the existing real-SQLite + real-git
|
||||||
|
integration pattern:
|
||||||
|
- List CRUD round-trips; rename/delete propagate; delete blocked/handled sensibly.
|
||||||
|
- List + task config set/get round-trips; clearing all three fields removes list config (matches hub behavior).
|
||||||
|
- Run history reads return correct projections; `GetTaskLog` returns file contents and errors cleanly when no log exists.
|
||||||
|
- `ResetFailedTask` succeeds on a Failed task and refuses other statuses.
|
||||||
|
- Agent listing reflects files on disk after refresh.
|
||||||
|
- App-settings read returns current values.
|
||||||
|
|
||||||
|
## Doc cleanup (part of this work)
|
||||||
|
|
||||||
|
- `src/ClaudeDo.Worker/CLAUDE.md` — remove the stale `SetTaskTags` / `ListTags` /
|
||||||
|
"AddTask (with tags)" claim; replace the External MCP tool inventory with the
|
||||||
|
new surface.
|
||||||
96
docs/superpowers/specs/2026-05-30-ui-normalization-design.md
Normal file
96
docs/superpowers/specs/2026-05-30-ui-normalization-design.md
Normal file
@@ -0,0 +1,96 @@
|
|||||||
|
# UI Normalization & Single Source of Truth — Design
|
||||||
|
|
||||||
|
Date: 2026-05-30
|
||||||
|
Status: Approved
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Make working on the ClaudeDo UI simpler by establishing the design tokens as the single source of truth for **every** visual value, eliminating duplicated styles, and providing reusable helpers for the patterns that are currently copy-pasted across views. Accept minor visual shifts where current values don't match the token scale — consistency is the priority over pixel-preservation.
|
||||||
|
|
||||||
|
## Scope decisions (locked)
|
||||||
|
|
||||||
|
- **Lane C (full normalization)** — global defaults + shared helpers + tokenize every hardcoded font/spacing/radius/color.
|
||||||
|
- **Normalization strategy: B (snap to existing scale).** Stray values round to the nearest existing token; off-palette colors fold into the closest design brush. The token vocabulary stays small; the UI shifts slightly in places and is verified by human eyeball.
|
||||||
|
- Badge colors collapse to palette (option A): blue is dropped.
|
||||||
|
|
||||||
|
## 1. Global defaults — `src/ClaudeDo.App/App.axaml`
|
||||||
|
|
||||||
|
Add application-level default styles so unstyled controls inherit the intended look instead of falling back to FluentTheme's Segoe UI:
|
||||||
|
|
||||||
|
- Default `FontFamily` = `{DynamicResource SansFont}` (Inter Tight) for text-bearing controls (`TextBlock`, `TextBox`, `Button`, `ComboBox`, `CheckBox`, `NumericUpDown`, `TabItem`).
|
||||||
|
- Default `FontSize` baseline = `{StaticResource FontSizeBody}` (13) where a control has no more specific style.
|
||||||
|
- Controls that need mono (`MonoFont`) continue to opt in explicitly via their class/style.
|
||||||
|
|
||||||
|
This single change fixes the Settings modal font and every other bare-Segoe-UI label across the app.
|
||||||
|
|
||||||
|
## 2. Tokens = source of truth — `src/ClaudeDo.Ui/Design/Tokens.axaml`
|
||||||
|
|
||||||
|
### Fonts — snap to the existing scale
|
||||||
|
Existing tokens: Eyebrow=10, Mono=11, Micro=11, Body=13, TaskTitle=14, H3=18, H2=24, H1=32.
|
||||||
|
- `9 → 10` (FontSizeEyebrow)
|
||||||
|
- `12 → 13` (FontSizeBody)
|
||||||
|
- `16 → 18` (FontSizeH3)
|
||||||
|
- Every `FontSize="N"` literal across all views/styles becomes a `{StaticResource FontSize*}` reference. No new size tokens are added.
|
||||||
|
|
||||||
|
### Spacing / radius — snap to the existing scale
|
||||||
|
- Modal body padding `16` / `20 → 18` (SpaceXl); the vertical component `12` stays `SpaceMd`.
|
||||||
|
- Corner radius `4 → 6` (ButtonCornerRadius).
|
||||||
|
- Text inputs (TextBox) standardize on `InputCornerRadius` (8); the `6` currently on DetailsIslandView TextBoxes moves to 8.
|
||||||
|
|
||||||
|
### Colors — fold off-palette into the palette
|
||||||
|
Add semantic brushes where a recurring role genuinely needs one, but reuse existing palette brushes wherever possible:
|
||||||
|
|
||||||
|
- **Connection-status dots** (MainWindow): green `#4CAF50` → `StatusRunningBrush`; amber `#FFA726` → `StatusReviewBrush`; red `#EF5350` → `StatusErrorBrush`. Also applies to the `#EF5350` literals in WorktreesOverviewModal.
|
||||||
|
- **Planning/draft badges** (IslandStyles `DraftBadgeBrush`/`PlanningBadgeBrush`/`PlannedBadgeBrush`): re-point to palette — draft → `TextMuteBrush`, planning → `PeatBrush`, planned → `SageBrush`. Blue dropped.
|
||||||
|
- **Named-color literals:** `OrangeRed` / `Orange` → `BloodBrush`; `White` → `TextBrush` (or `DeepBrush` where it sits on an accent fill, e.g. primary button text).
|
||||||
|
- **Terminal background** `#FF080C0B` (terminal + task-live-tail) → `VoidBrush` (`#FF0A0E0C`).
|
||||||
|
- **Status alpha-tints:** the repeated `#1F<hue>` fills and `#4C<hue>` borders used by chips and agent-strips become named brushes defined once in Tokens (e.g. `RunningTintBrush` / `RunningTintBorderBrush`, and the same for review/error/queued), then referenced from IslandStyles. The `#26<hue>` worktree-badge tints and `#147C9166` agent-strip tints fold into the same named tint family (snap the alpha to one value per family).
|
||||||
|
- **Island hairline overlay** `#0DFFFFFF` → a named `HairlineOverlayBrush` token.
|
||||||
|
|
||||||
|
## 3. Shared helpers
|
||||||
|
|
||||||
|
### `src/ClaudeDo.Ui/Design/IslandStyles.axaml`
|
||||||
|
Promote the styles currently copy-pasted into modals into the shared stylesheet, then delete the per-modal copies:
|
||||||
|
- `Button.primary` — standardize on **one** definition: `AccentDimBrush` background + `AccentBrush` border + `TextBrush` foreground (matching the existing `Button.btn.primary` variant). Resolves the AccentBrush-vs-AccentDimBrush divergence.
|
||||||
|
- `Button.danger` — `BloodBrush` background + `TextBrush` foreground.
|
||||||
|
- `TextBlock.field-label` — FontSize Micro (11), `TextDimBrush`, bottom margin 4.
|
||||||
|
- `TextBlock.section-label` already exists in IslandStyles; remove the duplicate local copies.
|
||||||
|
|
||||||
|
### New control: `ModalShell` (`src/ClaudeDo.Ui/Views/Controls/ModalShell.axaml`)
|
||||||
|
A reusable `TemplatedControl` / `UserControl` providing the chrome every modal re-implements:
|
||||||
|
- Title bar: mono uppercase title (FontSize Mono, LetterSpacing 1.4), draggable region, ✕ close button (`icon-btn`).
|
||||||
|
- Outer border (SurfaceBrush bg, LineBrush border, ModalCornerRadius).
|
||||||
|
- Content slot for the body.
|
||||||
|
- Optional footer slot for action buttons (right-aligned).
|
||||||
|
- Exposes: `Title` (string), `Body` content, `Footer` content, and a `CloseCommand`.
|
||||||
|
|
||||||
|
The 8 modal windows (Settings, ListSettings, Merge, About, UnfinishedPlanning, RepoImport, Diff, PlanningDiff, ConflictResolution) migrate to wrap their content in `ModalShell` instead of re-declaring titlebar/border/footer grids. Window-level concerns (Width/Height, KeyBindings, WindowDecorations) stay on the `Window`; only the inner chrome is replaced.
|
||||||
|
|
||||||
|
## 4. Bug fixes (folded into the migration)
|
||||||
|
|
||||||
|
- `TaskRowView.axaml` schedule flyout: `BorderBrush="{DynamicResource BorderBrush}"` → `{DynamicResource LineBrush}` (the `BorderBrush` key does not exist in Tokens; current runtime resource-not-found).
|
||||||
|
- `DiffModalView.axaml`, `PlanningDiffView.axaml`, `ConflictResolutionView.axaml`: convert all `{StaticResource <token>}` references to `{DynamicResource <token>}` to match the rest of the app and survive theme changes. (Style-internal `Setter` references that must stay `StaticResource` for Avalonia reasons are left as-is; only token lookups in element attributes are converted.)
|
||||||
|
|
||||||
|
## 5. Verification
|
||||||
|
|
||||||
|
- `dotnet build` per project (`.slnx` requires .NET 9 — build individual csproj):
|
||||||
|
- `src/ClaudeDo.App/ClaudeDo.App.csproj` (pulls in Ui + Data)
|
||||||
|
- `src/ClaudeDo.Worker/ClaudeDo.Worker.csproj`
|
||||||
|
- A clean build confirms XAML compiles and all resource keys resolve (compiled bindings + StaticResource keys are validated at build time).
|
||||||
|
- Human visual pass: launch the app and walk each view/modal against a per-view checklist (provided with the plan), since lane B intentionally shifts some values. The eyeball is the regression check.
|
||||||
|
|
||||||
|
## Sequencing
|
||||||
|
|
||||||
|
1. Tokens.axaml: add new named brushes (tints, status, hairline), re-point badge brushes. (No behavior change yet.)
|
||||||
|
2. App.axaml: global font/size defaults.
|
||||||
|
3. IslandStyles.axaml: promote shared styles (primary/danger/field-label), replace internal hardcoded values with token refs.
|
||||||
|
4. Per-view migration: replace every hardcoded FontSize/spacing/radius/color with token refs; snap stray values.
|
||||||
|
5. ModalShell control + migrate the 8 modals.
|
||||||
|
6. Bug fixes (BorderBrush key, Static→Dynamic in the three views).
|
||||||
|
7. Build all projects; produce visual-check checklist.
|
||||||
|
|
||||||
|
## Out of scope
|
||||||
|
|
||||||
|
- No layout/structure redesign — only values and shared chrome.
|
||||||
|
- No new features.
|
||||||
|
- No changes to ViewModels or behavior (ModalShell migration is markup-only; existing `CancelCommand` etc. bind through unchanged).
|
||||||
@@ -0,0 +1,123 @@
|
|||||||
|
# Waiting for Review — Task State — Design
|
||||||
|
|
||||||
|
**Date:** 2026-06-01
|
||||||
|
**Status:** Approved (brainstorming)
|
||||||
|
**Scope:** `ClaudeDo.Data` (TaskEntity, EF config + migration), `ClaudeDo.Worker` (TaskStateService, TaskRunner, QueueService, WorkerHub, ExternalMcpService), `ClaudeDo.Ui` (StatusColorConverter, TaskRowViewModel, views), CLAUDE.md docs
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
A successful task run currently transitions straight to `Done` and is considered complete. There is no gate for a human (or another agent) to review the result before it is accepted. We want review to be a mandatory step: after a successful run a task waits for an explicit approval, and a reviewer can send it back with feedback for another turn.
|
||||||
|
|
||||||
|
## Goals
|
||||||
|
|
||||||
|
- Add a `WaitingForReview` lifecycle state that a task enters automatically after a **successful** run.
|
||||||
|
- Reviewer can **approve** (→ `Done`), **reject-and-re-run** (→ `Queued`, resuming the same Claude session with required feedback), **reject-and-park** (→ `Idle`), or **cancel** (→ `Cancelled`).
|
||||||
|
- Reject-and-re-run reuses the existing session-resume mechanism so the agent continues with full context.
|
||||||
|
- Both the desktop UI and the external MCP surface can perform review actions.
|
||||||
|
|
||||||
|
## Non-Goals
|
||||||
|
|
||||||
|
- No change to the failure path: a **failed** run still goes straight to `Failed`, never to `WaitingForReview`.
|
||||||
|
- No change to planning-phase finalization. A planning parent that generates child tasks keeps its current behavior and does **not** route through review. Only ordinary executable runs (`Running` → success) are affected.
|
||||||
|
- No change to worktree state flow (`Active | Merged | Discarded | Kept`).
|
||||||
|
- No change to the in-run auto-retry-on-failure behavior; only the *final* successful completion routes to review.
|
||||||
|
|
||||||
|
## Design
|
||||||
|
|
||||||
|
### 1. State machine
|
||||||
|
|
||||||
|
Changed/added transitions in **bold**:
|
||||||
|
|
||||||
|
| From | To | Trigger |
|
||||||
|
|---|---|---|
|
||||||
|
| Idle | Queued | enqueue (unchanged) |
|
||||||
|
| Queued | Running | queue picker claim (unchanged) |
|
||||||
|
| Running | **WaitingForReview** | **successful run (was → Done)** |
|
||||||
|
| Running | Failed | failed run (unchanged) |
|
||||||
|
| Running | Cancelled | cancel during run (unchanged) |
|
||||||
|
| **WaitingForReview** | **Done** | **approve** |
|
||||||
|
| **WaitingForReview** | **Queued** | **reject + required feedback → resume re-run** |
|
||||||
|
| **WaitingForReview** | **Idle** | **reject → park for manual edit** |
|
||||||
|
| **WaitingForReview** | **Cancelled** | **abandon an almost-done task** |
|
||||||
|
| Done \| Failed \| Cancelled | Idle | reset (unchanged) |
|
||||||
|
|
||||||
|
### 2. Data model
|
||||||
|
|
||||||
|
`ClaudeDo.Data`:
|
||||||
|
|
||||||
|
- `TaskStatus` enum (`Models/TaskEntity.cs`): add `WaitingForReview` after `Running`.
|
||||||
|
- EF string converter (`Configuration/TaskEntityConfiguration.cs`): map `WaitingForReview` ⇄ `"waiting_for_review"` (TEXT column, no schema constraint to change).
|
||||||
|
- New nullable column **`ReviewFeedback : string?`** on `TaskEntity`. Holds the reviewer's rejection comment until the re-run consumes it, then it is cleared. Persisted so it survives a worker restart and is visible to the UI.
|
||||||
|
- One EF migration: add the `review_feedback` column. No backfill — the new status value and column are only written going forward.
|
||||||
|
|
||||||
|
### 3. Worker — status transitions (`State/TaskStateService.cs`)
|
||||||
|
|
||||||
|
`TaskStateService` remains the sole owner of status writes. New/changed methods:
|
||||||
|
|
||||||
|
- `SubmitForReviewAsync(taskId)` — `Running` → `WaitingForReview`. Sets `FinishedAt` and `Result` exactly as `CompleteAsync` does today. Called by `TaskRunner` on success **instead of** `CompleteAsync`. (`CompleteAsync` is retained for the approve path.)
|
||||||
|
- `ApproveReviewAsync(taskId)` — `WaitingForReview` → `Done`.
|
||||||
|
- `RejectToQueueAsync(taskId, feedback)` — `WaitingForReview` → `Queued`. Rejects empty/whitespace feedback with a failed `TransitionResult`. Stores `feedback` in `ReviewFeedback`. Wakes the queue.
|
||||||
|
- `RejectToIdleAsync(taskId)` — `WaitingForReview` → `Idle`. Parks for manual editing; leaves `Result` intact, clears `ReviewFeedback`.
|
||||||
|
- `CancelAsync` — extend the allowed source states to include `WaitingForReview`.
|
||||||
|
|
||||||
|
Each transition broadcasts `TaskUpdated` as today. Invalid source states return a failed `TransitionResult` (no throw), matching existing convention.
|
||||||
|
|
||||||
|
### 4. Resume-aware re-run (`Queue/QueueService.cs`)
|
||||||
|
|
||||||
|
The queue picker still atomically claims a `Queued`, unblocked task (`UPDATE … SET status='running' … RETURNING *`). The `RETURNING` row already carries `ReviewFeedback`. After a successful claim, `QueueService` branches:
|
||||||
|
|
||||||
|
1. **`ReviewFeedback` set + latest run has a `SessionId`** → `TaskRunner.ContinueAsync(task, feedback)` — `--resume {sessionId}` with `feedback` as the next-turn prompt.
|
||||||
|
2. **`ReviewFeedback` set, no prior `SessionId`** (edge case) → `TaskRunner.RunAsync` with the feedback appended to the task prompt, so the comment is not lost.
|
||||||
|
3. **No `ReviewFeedback`** → normal `TaskRunner.RunAsync` (fresh session).
|
||||||
|
|
||||||
|
`ReviewFeedback` is cleared once consumed (single UPDATE), so a later re-run does not re-apply stale feedback.
|
||||||
|
|
||||||
|
### 5. External MCP surface (`External/ExternalMcpService.cs`)
|
||||||
|
|
||||||
|
- New tool **`review_task(taskId, decision, feedback?)`**, `decision ∈ {approve, reject_rerun, reject_park, cancel}`. `feedback` is required when `decision = reject_rerun` (validation error otherwise). Maps onto the `TaskStateService` methods in §3. This lets automation / other agents act as reviewers.
|
||||||
|
- `get_task_status_values` — add `WaitingForReview` with a description covering the four exit actions.
|
||||||
|
- `list_tasks` status-filter parsing and validation message — include `WaitingForReview`.
|
||||||
|
- `get_task` lifecycle description text — update to `Idle → Queued → Running → WaitingForReview → Done | Failed | Cancelled`.
|
||||||
|
- `update_task_status` stays restricted to `Idle` and `Queued`; all review decisions go through `review_task` (keeps the "set status freely" affordance and the review affordance distinct).
|
||||||
|
|
||||||
|
### 6. Worker hub (`Hub/WorkerHub.cs` + `Hub/HubBroadcaster.cs`)
|
||||||
|
|
||||||
|
New hub methods called by the UI, each delegating to `TaskStateService`:
|
||||||
|
|
||||||
|
- `ApproveReview(taskId)`
|
||||||
|
- `RejectReviewToQueue(taskId, feedback)`
|
||||||
|
- `RejectReviewToIdle(taskId)`
|
||||||
|
|
||||||
|
Cancel already exists. No new broadcast events — `TaskUpdated` covers it.
|
||||||
|
|
||||||
|
### 7. UI (`ClaudeDo.Ui`)
|
||||||
|
|
||||||
|
- `Converters/StatusColorConverter.cs`: add a `waiting_for_review` case. Snap to an existing color token from the scale; final visual pass is left to the user (per project convention — centralize/tokenize, user does the visual pass).
|
||||||
|
- `ViewModels/Islands/TaskRowViewModel.cs`: add `IsWaitingForReview` computed property and commands **Approve**, **RejectRerun**, **RejectPark**, **Cancel** (the last reuses the existing cancel command). Commands are enabled only when `Status == WaitingForReview`.
|
||||||
|
- Reject-Rerun opens a small flyout/dialog with a required multi-line feedback text box; on confirm it calls `RejectReviewToQueue(taskId, feedback)`.
|
||||||
|
- Wire the commands to the new SignalR client methods.
|
||||||
|
|
||||||
|
### 8. Docs
|
||||||
|
|
||||||
|
Update the status flow in:
|
||||||
|
|
||||||
|
- root `CLAUDE.md` — "Task status flow" line.
|
||||||
|
- `src/ClaudeDo.Data/CLAUDE.md` — TaskEntity status list.
|
||||||
|
- `src/ClaudeDo.Worker/CLAUDE.md` — status-model transition table.
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
`ClaudeDo.Worker.Tests` (real SQLite + real git, existing harness):
|
||||||
|
|
||||||
|
- `SubmitForReviewAsync`: a successful run lands in `WaitingForReview`, not `Done`.
|
||||||
|
- `ApproveReviewAsync`: `WaitingForReview` → `Done`.
|
||||||
|
- `RejectToQueueAsync`: empty feedback rejected; valid feedback stored in `ReviewFeedback` and status → `Queued`.
|
||||||
|
- `RejectToIdleAsync`: → `Idle`, `Result` preserved, `ReviewFeedback` cleared.
|
||||||
|
- `CancelAsync` from `WaitingForReview` → `Cancelled`.
|
||||||
|
- Invalid source states (e.g. approve from `Idle`) return a failed `TransitionResult`.
|
||||||
|
- Resume-aware re-run: a task with `ReviewFeedback` + a prior `SessionId`, when claimed, resumes the session with the feedback as the prompt and clears `ReviewFeedback`.
|
||||||
|
- `review_task` MCP tool: each decision maps to the correct transition; `reject_rerun` without feedback errors.
|
||||||
|
|
||||||
|
## Open questions
|
||||||
|
|
||||||
|
None outstanding. Planning-task exclusion (Non-Goals) is the one assumption to verify against the planning-finalization code path during implementation; if planning finalization shares `CompleteAsync`, route only the executable-run success site through `SubmitForReviewAsync`.
|
||||||
153
docs/superpowers/specs/2026-06-01-worker-lifecycle-design.md
Normal file
153
docs/superpowers/specs/2026-06-01-worker-lifecycle-design.md
Normal file
@@ -0,0 +1,153 @@
|
|||||||
|
# Worker Lifecycle Redesign
|
||||||
|
|
||||||
|
**Date:** 2026-06-01
|
||||||
|
**Status:** Approved (design)
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
The worker process has multiple competing owners, which collide in development and
|
||||||
|
muddy production behavior:
|
||||||
|
|
||||||
|
- The App auto-spawns its own worker on startup (`EnsureWorkerRunningAsync`,
|
||||||
|
`IslandsShellViewModel.cs:310`, called at line 224) ~4s after launch if it isn't
|
||||||
|
yet connected. In the IDE "Start Everything" multilaunch — which already runs the
|
||||||
|
worker via the `http` launch profile (`dotnet run`) — this produces a *second*
|
||||||
|
worker that fails to bind to `127.0.0.1:47821` and dies, surfacing a stray console
|
||||||
|
with a "failed to bind to address" error.
|
||||||
|
- Production autostart uses a per-user logon **Scheduled Task** (`RegisterAutostartStep`
|
||||||
|
+ `ScheduledTaskXml`), which the user wants to replace with a simpler Startup-folder
|
||||||
|
shortcut.
|
||||||
|
- When the App can't reach the worker, the only feedback is a silent "Offline" pill in
|
||||||
|
the footer — no guidance to the user.
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Establish a single owner for the worker lifecycle and make connection failures
|
||||||
|
actionable:
|
||||||
|
|
||||||
|
1. The worker is owned **externally** — a per-user **Startup-folder shortcut** in
|
||||||
|
production (replacing the Scheduled Task), or the IDE in development.
|
||||||
|
2. The App **only connects**; it never auto-spawns a worker.
|
||||||
|
3. When the App can't connect, it shows a one-time prompt offering **Start Worker**,
|
||||||
|
**Rerun Installer**, or **Dismiss**, plus a clickable Offline pill to reopen it.
|
||||||
|
|
||||||
|
## Non-Goals
|
||||||
|
|
||||||
|
- No change to the IDE dev setup. The "Start Everything" multilaunch keeps running the
|
||||||
|
worker via the `http` profile (console with live logs); the duplicate/bind-error
|
||||||
|
worker disappears purely because the App no longer auto-spawns. Rider run configs live
|
||||||
|
in `.idea/.../workspace.xml` (per-user, gitignored) and are out of scope.
|
||||||
|
- No change to the SignalR hub URL, port, reconnect policy, or the worker's
|
||||||
|
single-instance mutex.
|
||||||
|
|
||||||
|
## Design
|
||||||
|
|
||||||
|
### Component 1 — Installer: Scheduled Task → Startup-folder shortcut
|
||||||
|
|
||||||
|
**`RegisterAutostartStep`** (`src/ClaudeDo.Installer/Steps/RegisterAutostartStep.cs`)
|
||||||
|
- Replace the task-XML build + `schtasks /Create` with creation of a `.lnk` in the
|
||||||
|
per-user Startup folder (`Environment.SpecialFolder.Startup`) targeting
|
||||||
|
`{InstallDirectory}\worker\ClaudeDo.Worker.exe`. The worker is `WinExe`, so it launches
|
||||||
|
with no console window.
|
||||||
|
- **Migration:** keep the existing legacy Windows-service removal, and **add** removal of
|
||||||
|
the old scheduled task: `schtasks.exe /Delete /TN "ClaudeDoWorker" /F` (best-effort),
|
||||||
|
so existing installs migrate cleanly to the shortcut model.
|
||||||
|
|
||||||
|
**`StartWorkerStep`** (`src/ClaudeDo.Installer/Steps/StartWorkerStep.cs`)
|
||||||
|
- Replace `schtasks /Run /TN ClaudeDoWorker` with a direct
|
||||||
|
`Process.Start(new ProcessStartInfo(workerExe) { UseShellExecute = true })`.
|
||||||
|
|
||||||
|
**`StopWorkerStep`** (`src/ClaudeDo.Installer/Steps/StopWorkerStep.cs`)
|
||||||
|
- Drop the `schtasks /End` call. Keep the existing install-dir-scoped process kill, which
|
||||||
|
is the real stop mechanism.
|
||||||
|
|
||||||
|
**`UninstallRunner`** (`src/ClaudeDo.Installer/Core/UninstallRunner.cs`)
|
||||||
|
- Keep the existing `schtasks /Delete` and `sc delete` (migration/legacy cleanup).
|
||||||
|
- **Add** deletion of the Startup-folder `.lnk` alongside the existing Start Menu /
|
||||||
|
Desktop shortcut removal.
|
||||||
|
|
||||||
|
**Shared shortcut helper**
|
||||||
|
- Extract the `IShellLink` COM interop currently embedded in `CreateShortcutsStep` into a
|
||||||
|
shared `src/ClaudeDo.Installer/Core/ShortcutFactory.cs` (`CreateShortcut(path, target,
|
||||||
|
workingDir, description)`). Both `CreateShortcutsStep` and `RegisterAutostartStep` use it.
|
||||||
|
|
||||||
|
**Cleanup**
|
||||||
|
- Delete `src/ClaudeDo.Installer/Core/ScheduledTaskXml.cs` once unreferenced.
|
||||||
|
|
||||||
|
The autostart shortcut name and location: `ClaudeDo Worker.lnk` in
|
||||||
|
`Environment.SpecialFolder.Startup`, working directory `{InstallDirectory}\worker`.
|
||||||
|
|
||||||
|
### Component 2 — App: stop auto-spawning the worker
|
||||||
|
|
||||||
|
**`IslandsShellViewModel`** (`src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`)
|
||||||
|
- Remove the `_ = EnsureWorkerRunningAsync();` call (line 224) and the
|
||||||
|
`EnsureWorkerRunningAsync` method + its `_ensureRunningAttempted` flag.
|
||||||
|
- Keep the worker-launch logic (`RestartWorkerService`, which finds the worker exe via
|
||||||
|
`WorkerLocator` and starts it) — it becomes the backing action for the prompt's
|
||||||
|
**Start Worker** button. The existing `RestartWorkerAsync` command stays.
|
||||||
|
|
||||||
|
### Component 3 — App: connection-failure prompt
|
||||||
|
|
||||||
|
**New dialog** `WorkerConnectionModalViewModel`
|
||||||
|
(`src/ClaudeDo.Ui/ViewModels/Modals/WorkerConnectionModalViewModel.cs`) +
|
||||||
|
`WorkerConnectionModalView` (`src/ClaudeDo.Ui/Views/Modals/`).
|
||||||
|
- Buttons: **Start Worker**, **Rerun Installer**, **Dismiss**.
|
||||||
|
- Uses the established dialog pattern: a `Func<WorkerConnectionModalViewModel, Task>`
|
||||||
|
hook on `IslandsShellViewModel` set by `MainWindow` (mirroring `ShowAboutModal`), and
|
||||||
|
the dialog resolves a `TaskCompletionSource` on button press.
|
||||||
|
- **Start Worker** → `WorkerLocator.Find()` + `Process.Start` (reuse the
|
||||||
|
`RestartWorkerService` path). **Rerun Installer** → `InstallerLocator.Find()` + launch
|
||||||
|
+ `Environment.Exit(0)` (same pattern as the existing `UpdateNow` command).
|
||||||
|
**Dismiss** → close.
|
||||||
|
|
||||||
|
**Trigger logic** (in `IslandsShellViewModel`)
|
||||||
|
- A one-shot grace timer (~12s) started on construction/startup. When it elapses, if the
|
||||||
|
worker is still offline (`IsOffline` — not connected and not reconnecting) and the
|
||||||
|
prompt hasn't been shown yet (`_connectionPromptShown`), show the dialog once and set
|
||||||
|
the flag.
|
||||||
|
- If the worker connects before the grace elapses, the prompt is never shown.
|
||||||
|
|
||||||
|
**Clickable Offline pill** (`src/ClaudeDo.Ui/Views/MainWindow.axaml`)
|
||||||
|
- Turn the footer status pill into a button bound to a command that opens the same dialog
|
||||||
|
on demand (independent of the one-shot flag), so the user can reopen guidance anytime
|
||||||
|
while offline.
|
||||||
|
|
||||||
|
### Component 4 — Dev
|
||||||
|
|
||||||
|
No code change (see Non-Goals).
|
||||||
|
|
||||||
|
## Data Flow
|
||||||
|
|
||||||
|
```
|
||||||
|
Startup (production):
|
||||||
|
Windows logon -> Startup-folder .lnk -> ClaudeDo.Worker.exe (WinExe, mutex-guarded)
|
||||||
|
App launches -> WorkerClient connects to 127.0.0.1:47821
|
||||||
|
connected within grace -> Online pill, no prompt
|
||||||
|
still offline after ~12s -> WorkerConnectionModal (once)
|
||||||
|
|
||||||
|
User clicks Offline pill (anytime offline) -> WorkerConnectionModal
|
||||||
|
Start Worker -> Process.Start(worker exe)
|
||||||
|
Rerun Installer -> Process.Start(installer), Environment.Exit(0)
|
||||||
|
Dismiss -> close
|
||||||
|
```
|
||||||
|
|
||||||
|
## Error Handling
|
||||||
|
|
||||||
|
- Worker exe / installer not found (`Locator.Find()` returns null): the corresponding
|
||||||
|
dialog button is a no-op (consistent with existing `UpdateNow` behavior); the dialog
|
||||||
|
stays open so the user can pick another action.
|
||||||
|
- Startup-shortcut creation failure in the installer: surfaced as a failed install step
|
||||||
|
(`StepResult.Fail`), same as the current task-registration failure path.
|
||||||
|
- Legacy scheduled-task deletion is best-effort and never fails the install.
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
- **`Installer.Tests`**: `RegisterAutostartStep` creates the Startup `.lnk` at the
|
||||||
|
expected path with the correct target, and issues the legacy-task delete command.
|
||||||
|
`UninstallRunner` removes the Startup `.lnk`.
|
||||||
|
- **`Ui.Tests`**: prompt trigger logic — grace elapsed while offline shows the prompt
|
||||||
|
exactly once; a connection established before grace suppresses it; the clickable-pill
|
||||||
|
command opens the dialog regardless of the one-shot flag. (Abstract the dialog-show
|
||||||
|
hook so it can be asserted without real UI.)
|
||||||
|
- **Manual**: dialog buttons (Start Worker / Rerun Installer / Dismiss) and the clickable
|
||||||
|
Offline pill in a running App.
|
||||||
@@ -0,0 +1,116 @@
|
|||||||
|
# Prime: recurring weekday schedule
|
||||||
|
|
||||||
|
**Date:** 2026-06-02
|
||||||
|
**Status:** Approved
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
The Prime feature fires a single non-interactive "ping" prompt to warm up the
|
||||||
|
Claude usage window. Today a schedule is defined by a **date range**
|
||||||
|
(`StartDate`/`EndDate`) plus a `TimeOfDay` and a single `WorkdaysOnly` toggle.
|
||||||
|
This is awkward for the real use case: the user wants a *recurring* morning ping
|
||||||
|
on specific weekdays, not a bounded calendar window.
|
||||||
|
|
||||||
|
Desired behavior: pick the **days of the week** (e.g. Mon–Fri) and a **time**.
|
||||||
|
The schedule recurs forever. Whenever the worker is running and it is one of the
|
||||||
|
selected days, the ping fires at (or shortly after) the chosen time. Concretely:
|
||||||
|
the worker autostarts on login, detects it is an eligible day around the target
|
||||||
|
time, and fires the ping.
|
||||||
|
|
||||||
|
## Decisions
|
||||||
|
|
||||||
|
- **Catch-up window:** unchanged. Keep the existing 30-minute catch-up — if the
|
||||||
|
worker boots within 30 min after the target time, the ping fires immediately;
|
||||||
|
otherwise it waits for the next eligible day. (User chose "keep current 30 min".)
|
||||||
|
- **Day picker UI:** seven compact **toggle buttons** in one row (Mo Tu We Th Fr
|
||||||
|
Sa Su), highlighted when selected — not labeled checkboxes.
|
||||||
|
|
||||||
|
## Design
|
||||||
|
|
||||||
|
### 1. Data model
|
||||||
|
|
||||||
|
`PrimeScheduleEntity` (`ClaudeDo.Data/Models`):
|
||||||
|
|
||||||
|
- **Remove:** `StartDate`, `EndDate`, `WorkdaysOnly`
|
||||||
|
- **Add:** `Days` — a `[Flags] enum PrimeDays` (`Monday=1, Tuesday=2, Wednesday=4,
|
||||||
|
Thursday=8, Friday=16, Saturday=32, Sunday=64`), stored as a single
|
||||||
|
`days_of_week INTEGER` column.
|
||||||
|
- **Keep:** `TimeOfDay`, `Enabled`, `LastRunAt`, `PromptOverride`, `CreatedAt`.
|
||||||
|
|
||||||
|
Rationale for a bitmask over a CSV string or 7 bool columns: one column, trivial
|
||||||
|
EF mapping (int), and a clean eligibility check.
|
||||||
|
|
||||||
|
`PrimeScheduleEntityConfiguration`: drop the `start_date`/`end_date`/
|
||||||
|
`workdays_only` property mappings; map `Days` to `days_of_week` (int, required,
|
||||||
|
default 31 = Mon–Fri).
|
||||||
|
|
||||||
|
### 2. Scheduling logic — `NextDueCalculator`
|
||||||
|
|
||||||
|
- Drop all `StartDate`/`EndDate` gating (the `EndDate < today` early-out, the
|
||||||
|
`StartDate > today` clamps, and the bounds check in `IsEligibleDay`).
|
||||||
|
- `IsEligibleDay(s, d)` becomes: does `s.Days` contain the flag for
|
||||||
|
`d.DayOfWeek`? (Map `System.DayOfWeek` → `PrimeDays`.)
|
||||||
|
- The existing forward search (loops up to 8 days ahead) now simply walks to the
|
||||||
|
next selected weekday.
|
||||||
|
- `alreadyFiredToday` (compares `LastRunAt`'s local date to today) is unchanged.
|
||||||
|
- The 30-min catch-up (`FireImmediately`) is unchanged.
|
||||||
|
- A schedule with `Days == 0` (none selected) is never eligible. UI validation
|
||||||
|
prevents saving that state.
|
||||||
|
|
||||||
|
### 3. UI — `SettingsModalView.axaml` + `PrimeScheduleRowViewModel`
|
||||||
|
|
||||||
|
Row template changes:
|
||||||
|
- **Remove** the `ThemedDatePicker` (range) and the single "Mon–Fri" checkbox.
|
||||||
|
- **Add** a horizontal row of 7 `ToggleButton`s (Mo Tu We Th Fr Sa Su), styled
|
||||||
|
to highlight when checked, bound to seven bool properties on the row VM.
|
||||||
|
- Keep the enabled checkbox, the time `TextBox`, the last-run label, and the
|
||||||
|
remove button.
|
||||||
|
|
||||||
|
`PrimeScheduleRowViewModel`:
|
||||||
|
- Replace `StartDate`/`EndDate`/`WorkdaysOnly` with seven `[ObservableProperty]`
|
||||||
|
bools: `Monday`…`Sunday`.
|
||||||
|
- Constructor decomposes `dto.Days` into the seven bools.
|
||||||
|
- `ToDto()` composes the seven bools back into the `Days` int.
|
||||||
|
|
||||||
|
`PrimeClaudeTabViewModel`:
|
||||||
|
- `AddSchedule` default: Mon–Fri selected, time 07:00, enabled.
|
||||||
|
- `Validate`: replace the `StartDate > EndDate` check with "at least one day must
|
||||||
|
be selected"; keep the time-range (00:00–23:59) check.
|
||||||
|
|
||||||
|
Update the explainer `TextBlock` text to describe weekday recurrence (keep the
|
||||||
|
"fires immediately if started within 30 minutes of the target time" note).
|
||||||
|
|
||||||
|
### 4. Migration
|
||||||
|
|
||||||
|
New EF Core migration in `ClaudeDo.Data/Migrations`:
|
||||||
|
- Add `days_of_week INTEGER NOT NULL DEFAULT 31`.
|
||||||
|
- Backfill from existing rows: `workdays_only = 1` → `31` (Mon–Fri),
|
||||||
|
`workdays_only = 0` → `127` (all 7 days).
|
||||||
|
- Drop `start_date`, `end_date`, `workdays_only`.
|
||||||
|
- Update the model snapshot.
|
||||||
|
|
||||||
|
### 5. DTOs
|
||||||
|
|
||||||
|
Both copies of `PrimeScheduleDto` (Worker `ClaudeDo.Worker.Prime` and UI
|
||||||
|
`ClaudeDo.Ui.Services`) are passed over SignalR and must stay structurally
|
||||||
|
compatible. In both: remove `StartDate`, `EndDate`, `WorkdaysOnly`; add a single
|
||||||
|
`int Days` field (serializes cleanly as JSON; avoids sharing the enum across
|
||||||
|
projects). `PrimeScheduler.ToDto` maps `entity.Days` → `(int)`.
|
||||||
|
|
||||||
|
`PrimeScheduleRepository`: update `UpsertAsync` (copy `Days` instead of the three
|
||||||
|
removed fields) and `ListAsync` ordering (order by `TimeOfDay` instead of
|
||||||
|
`StartDate`).
|
||||||
|
|
||||||
|
### 6. Tests
|
||||||
|
|
||||||
|
- `NextDueCalculatorTests` — rewrite cases around weekday sets (e.g. Mon–Fri
|
||||||
|
skips weekend; single-day schedule; catch-up still fires; already-fired-today
|
||||||
|
skips to next eligible day).
|
||||||
|
- `PrimeSchedulerTests` — update fixture DTOs to the new shape.
|
||||||
|
- `PrimeScheduleRepositoryTests` — update entity construction and assertions.
|
||||||
|
- `PrimeClaudeTabViewModelTests` — update for the day-bool VM and new validation.
|
||||||
|
|
||||||
|
## Out of scope
|
||||||
|
|
||||||
|
- Per-schedule catch-up tuning (rejected; fixed 30 min).
|
||||||
|
- Multiple times per day, timezones, or holiday calendars.
|
||||||
182
docs/superpowers/specs/2026-06-03-daily-prep-design.md
Normal file
182
docs/superpowers/specs/2026-06-03-daily-prep-design.md
Normal file
@@ -0,0 +1,182 @@
|
|||||||
|
# Daily Prep ("Prime Claude") — Design
|
||||||
|
|
||||||
|
Date: 2026-06-03
|
||||||
|
|
||||||
|
## Overview
|
||||||
|
|
||||||
|
Turn the existing Prime Time warm-up into a **daily preparation** ("Tagesvorbereitung").
|
||||||
|
At a scheduled time (or on demand), Claude reads the open tasks, estimates effort,
|
||||||
|
and selects a focused subset into the MyDay list — capped so it never moves
|
||||||
|
everything in. Claude does the reasoning itself (agentic), via the already-registered
|
||||||
|
ClaudeDo MCP. This replaces the current `"ping"` behavior entirely.
|
||||||
|
|
||||||
|
A later phase will feed external tickets (Jira, possibly a second system) into the
|
||||||
|
same candidate pool; that is out of scope for this spec.
|
||||||
|
|
||||||
|
## Goals
|
||||||
|
|
||||||
|
- Scheduled and manual ("Tag vorbereiten" button) daily prep.
|
||||||
|
- Claude picks a subset of open tasks into MyDay, ordered so related tasks sit together.
|
||||||
|
- Effort-aware selection, hard-capped at `X` open MyDay tasks.
|
||||||
|
- Keep existing MyDay tasks across re-runs; only top up to `X`.
|
||||||
|
- Candidates limited to tasks in repos that are **not** excluded from the weekly report.
|
||||||
|
|
||||||
|
## Non-Goals
|
||||||
|
|
||||||
|
- External ticket integration (Jira etc.) — future phase.
|
||||||
|
- Group labels/headers in the MyDay view — grouping is ordering-only via `SortOrder`.
|
||||||
|
- A user-editable prep prompt — the prompt is fixed, parameterized.
|
||||||
|
|
||||||
|
## Key Decisions
|
||||||
|
|
||||||
|
| Topic | Decision |
|
||||||
|
| --- | --- |
|
||||||
|
| Who reasons | Agentic — Claude decides via MCP tools. |
|
||||||
|
| MyDay model | `TaskEntity.IsMyDay` flag (smart list `smart:my-day`). |
|
||||||
|
| Grouping | Ordering only via existing `SortOrder` (no new field, no migration for grouping). |
|
||||||
|
| Selection | Effort estimate, hard cap `X` tasks/day. |
|
||||||
|
| Candidates | `Status == Idle`, `BlockedByTaskId == null`, list `WorkingDir` not under `ReportExcludedPaths`. |
|
||||||
|
| Re-run | Keep existing MyDay tasks; top up to `X`. |
|
||||||
|
| Trigger | Existing Prime schedule **and** a manual button. |
|
||||||
|
| Ping | Removed — daily prep replaces it. |
|
||||||
|
| Prompt | Fixed, with injected parameters (`X`, today's date). |
|
||||||
|
| Tool access | Reuse the globally registered `claudedo` MCP — **no** separate `--mcp-config`. |
|
||||||
|
|
||||||
|
## Architecture
|
||||||
|
|
||||||
|
### 1. MCP tools (extend `ExternalMcpService`, port 47822)
|
||||||
|
|
||||||
|
The worker already exposes `ExternalMcpService` as the `claudedo` MCP server. Add two tools;
|
||||||
|
they automatically surface as `mcp__claudedo__get_daily_prep_candidates` and
|
||||||
|
`mcp__claudedo__set_my_day`.
|
||||||
|
|
||||||
|
- **`get_daily_prep_candidates()`** → JSON containing:
|
||||||
|
- `candidates[]`: open, non-blocked tasks in non-excluded repos, each with
|
||||||
|
`id, title, description, listName, isStarred, scheduledFor, age` (age derived from `CreatedAt`).
|
||||||
|
- `currentMyDay[]`: currently-`IsMyDay` open tasks (so Claude sees remaining capacity).
|
||||||
|
- Filter: `Status == Idle` AND `BlockedByTaskId == null` AND the task's list `WorkingDir`
|
||||||
|
does not start with any prefix in `AppSettings.ReportExcludedPaths`
|
||||||
|
(default `["C:\\Private"]`; case-insensitive prefix match, same semantics as the weekly report).
|
||||||
|
|
||||||
|
- **`set_my_day(taskId, isMyDay, sortOrder?)`** →
|
||||||
|
- Sets `IsMyDay` and (optionally) `SortOrder` on the task via `TaskRepository`.
|
||||||
|
- Broadcasts `TaskUpdated` via `HubBroadcaster` so the UI updates live.
|
||||||
|
- **Cap-guard:** when `isMyDay == true`, count current open (`Idle`) tasks with
|
||||||
|
`IsMyDay == true`. If `count >= X`, reject with an error message
|
||||||
|
("MyDay limit {X} reached"). `isMyDay == false` is always allowed.
|
||||||
|
`X = AppSettings.DailyPrepMaxTasks`. This guarantees the "never move everything in"
|
||||||
|
invariant server-side, independent of Claude's behavior.
|
||||||
|
|
||||||
|
### 2. `DailyPrepRunner` (replaces ping logic)
|
||||||
|
|
||||||
|
Rename `IPrimeRunner`/`PrimeRunner` → `IDailyPrepRunner`/`DailyPrepRunner` (the `"ping"`
|
||||||
|
concept is gone). It:
|
||||||
|
|
||||||
|
- Loads `AppSettings` (`X = DailyPrepMaxTasks`).
|
||||||
|
- Builds the fixed prompt with injected parameters (`X`, today's date).
|
||||||
|
- Invokes `claude -p --output-format stream-json --verbose` with:
|
||||||
|
- `--permission-mode` set so the headless run won't block on permission prompts,
|
||||||
|
- `--allowedTools mcp__claudedo__get_daily_prep_candidates mcp__claudedo__set_my_day`,
|
||||||
|
- `--max-turns 30` (constant), timeout 5 min (constant; larger than the old 60s ping).
|
||||||
|
- **No `--mcp-config`** — relies on the globally registered `claudedo` MCP (the worker runs
|
||||||
|
as the user via the per-user logon Scheduled Task, so the headless run inherits the
|
||||||
|
user-scope registration and its auth).
|
||||||
|
- Returns an outcome (e.g. number of tasks added) for broadcasting.
|
||||||
|
|
||||||
|
### 3. Scheduler
|
||||||
|
|
||||||
|
`PrimeScheduler` is unchanged in structure — it now calls `IDailyPrepRunner` instead of the
|
||||||
|
ping runner. `NextDueCalculator` and the schedule model are untouched.
|
||||||
|
|
||||||
|
### 4. Manual trigger
|
||||||
|
|
||||||
|
- Worker hub method `RunDailyPrepNow()` invokes the same `DailyPrepRunner`.
|
||||||
|
- UI button **"Tag vorbereiten"** in the MyDay list header.
|
||||||
|
- **Single-flight guard:** if a prep run is already in progress, the trigger reports
|
||||||
|
"already running" and does not start a parallel run (applies to both schedule and button).
|
||||||
|
|
||||||
|
### 5. Parameter config
|
||||||
|
|
||||||
|
- New field **`DailyPrepMaxTasks`** (int, default `5`) on `AppSettingsEntity`.
|
||||||
|
- Plumbing: EF config + migration, `AppSettingsRepository`, `WorkerHub` AppSettings DTO,
|
||||||
|
UI DTO mirror + `WorkerClient`, and a numeric editor in the Prime Claude settings tab.
|
||||||
|
- `ReportExcludedPaths` is reused as-is (already on `AppSettings`).
|
||||||
|
|
||||||
|
## Data Flow
|
||||||
|
|
||||||
|
1. Trigger (schedule due **or** button) → `DailyPrepRunner.RunAsync`.
|
||||||
|
2. Runner loads `AppSettings` (`X`), builds prompt, launches Claude.
|
||||||
|
3. Claude → `get_daily_prep_candidates` → DB query returns filtered candidates + current MyDay.
|
||||||
|
4. Claude estimates effort, tops up to **X total**, calls `set_my_day(id, true, sortOrder)`
|
||||||
|
for each chosen task (consecutive `sortOrder` for related tasks).
|
||||||
|
5. `ExternalMcpService` writes `IsMyDay`/`SortOrder`, broadcasts `TaskUpdated` → MyDay list
|
||||||
|
updates live.
|
||||||
|
6. Runner updates `LastRunAt`, broadcasts "prep done" (count added).
|
||||||
|
|
||||||
|
## Fixed Prompt (parameterized)
|
||||||
|
|
||||||
|
Content (parameters in `{}`):
|
||||||
|
|
||||||
|
> Du bereitest meinen Arbeitstag für **{today}** vor.
|
||||||
|
> 1. Rufe `get_daily_prep_candidates` auf.
|
||||||
|
> 2. Behalte bereits als MyDay markierte offene Tasks.
|
||||||
|
> 3. Fülle bis **maximal {X} offene Tasks gesamt** in MyDay auf — niemals mehr.
|
||||||
|
> 4. Schätze pro Task grob den Aufwand; wähle eine machbare Mischung (nicht nur Großbrocken).
|
||||||
|
> Priorisiere `isStarred`, fällige (`scheduledFor`) und ältere Tasks.
|
||||||
|
> 5. Lege thematisch verwandte Tasks durch aufeinanderfolgende `sortOrder`-Werte nebeneinander.
|
||||||
|
> 6. Setze die Auswahl via `set_my_day(id, true, sortOrder)`. Markiere nichts außerhalb der
|
||||||
|
> Kandidatenliste.
|
||||||
|
|
||||||
|
Injected parameters: `{today}` (date) and `{X}` (= `DailyPrepMaxTasks`).
|
||||||
|
|
||||||
|
## Error Handling
|
||||||
|
|
||||||
|
- No candidates → Claude marks nothing; runner reports "0 added".
|
||||||
|
- Claude run fails / times out → log + failure broadcast (existing scheduler event channel);
|
||||||
|
`LastRunAt` is set on attempt, as today, to avoid tight retry loops.
|
||||||
|
- `set_my_day` on an invalid/ineligible id → tool returns an error string; Claude adapts.
|
||||||
|
- Cap exceeded → tool returns an error; Claude stops adding.
|
||||||
|
- Concurrent trigger → single-flight guard reports "already running".
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
Real SQLite + real git (project convention).
|
||||||
|
|
||||||
|
- `get_daily_prep_candidates`: only `Idle`; blocked excluded; tasks in excluded repos
|
||||||
|
(`ReportExcludedPaths`) excluded; current MyDay tasks included.
|
||||||
|
- `set_my_day`: sets flag + `SortOrder`; broadcasts `TaskUpdated`; cap-guard rejects at limit;
|
||||||
|
unset always allowed.
|
||||||
|
- `DailyPrepRunner`: prompt contains `{X}` + date; args contain `--allowedTools` +
|
||||||
|
permission-mode + `--max-turns`; success/failure outcomes via an `IClaudeProcess` fake.
|
||||||
|
- Rename `IPrimeRunner` → `IDailyPrepRunner` requires syncing `PrimeScheduler` tests/fakes.
|
||||||
|
|
||||||
|
## Files to Create / Modify (high level)
|
||||||
|
|
||||||
|
**Data**
|
||||||
|
- `Models/AppSettingsEntity.cs` — add `DailyPrepMaxTasks`.
|
||||||
|
- `Configuration/AppSettingsEntityConfiguration.cs` — map new column.
|
||||||
|
- `Migrations/` — new migration for `daily_prep_max_tasks`.
|
||||||
|
- `Repositories/AppSettingsRepository.cs` — persist new field.
|
||||||
|
|
||||||
|
**Worker**
|
||||||
|
- `External/ExternalMcpService.cs` — add `get_daily_prep_candidates`, `set_my_day` (+ cap-guard).
|
||||||
|
- `Prime/PrimeRunner.cs` → `DailyPrepRunner.cs`; `Prime/Interfaces/IPrimeRunner.cs`
|
||||||
|
→ `IDailyPrepRunner.cs`; prompt builder + arg builder.
|
||||||
|
- `Prime/PrimeScheduler.cs` — depend on `IDailyPrepRunner`.
|
||||||
|
- `Hub/WorkerHub.cs` — AppSettings DTO field; `RunDailyPrepNow()`.
|
||||||
|
- `Program.cs` — DI registration update.
|
||||||
|
|
||||||
|
**UI**
|
||||||
|
- `Services/WorkerClient.cs` + AppSettings DTO mirror — new field; `RunDailyPrepNow` call.
|
||||||
|
- Prime Claude settings tab VM/view — numeric editor for `DailyPrepMaxTasks`.
|
||||||
|
- MyDay list header — "Tag vorbereiten" button + command (Lists/IslandsShell VM).
|
||||||
|
|
||||||
|
**Tests**
|
||||||
|
- `ClaudeDo.Worker.Tests` — MCP tools, runner, scheduler fakes.
|
||||||
|
- `ClaudeDo.Data.Tests` — AppSettings persistence (if covered there).
|
||||||
|
- `ClaudeDo.Ui.Tests` — settings VM / button wiring as applicable.
|
||||||
|
|
||||||
|
## Future Phase (out of scope)
|
||||||
|
|
||||||
|
External ticket sources (Jira, possibly a second system) feed into the candidate pool used by
|
||||||
|
`get_daily_prep_candidates`, behind a task-source abstraction. Designed separately.
|
||||||
151
docs/superpowers/specs/2026-06-03-daily-prep-live-view-design.md
Normal file
151
docs/superpowers/specs/2026-06-03-daily-prep-live-view-design.md
Normal file
@@ -0,0 +1,151 @@
|
|||||||
|
# Daily Prep — Live Output View + Clear Day — Design
|
||||||
|
|
||||||
|
Date: 2026-06-03
|
||||||
|
|
||||||
|
## Overview
|
||||||
|
|
||||||
|
Two follow-ups to the daily-prep ("Prime Claude") feature:
|
||||||
|
|
||||||
|
1. **Live output view.** While Claude prepares the day, there is no feedback. Add a
|
||||||
|
live, human-readable view of the prep run's output, shown as a new content mode in
|
||||||
|
the existing right-hand **Details island** (mirroring how Daily Notes works — a mode
|
||||||
|
swap, not a separate window/column).
|
||||||
|
2. **Clear Day button.** A MyDay-header button that clears the MyDay selection
|
||||||
|
immediately.
|
||||||
|
|
||||||
|
## Goals
|
||||||
|
|
||||||
|
- See the prep run's progress live, rendered with the same friendly terminal renderer
|
||||||
|
used for task runs (assistant text + tool calls like `set_my_day …`, not raw NDJSON).
|
||||||
|
- Both manual (button) and scheduled prep runs stream into the log.
|
||||||
|
- The manual button opens the prep view; a scheduled run fills the log silently and is
|
||||||
|
opened via a dedicated "Vorbereitungs-Log" button (the existing `PrimeStatus` footer
|
||||||
|
remains the hint that a run happened).
|
||||||
|
- A "Tag leeren" button clears all MyDay tasks (any status) with no confirmation.
|
||||||
|
|
||||||
|
## Non-Goals
|
||||||
|
|
||||||
|
- No new island/column and no popup/overlay — reuse the Details island as a mode swap.
|
||||||
|
- No persistence of prep output across app restarts (in-memory log only).
|
||||||
|
- No undo for Clear Day (re-runnable via "Tag vorbereiten").
|
||||||
|
|
||||||
|
## Key Decisions
|
||||||
|
|
||||||
|
| Topic | Decision |
|
||||||
|
| --- | --- |
|
||||||
|
| Rendering | Reuse the existing `SessionTerminalView` / `StreamLineFormatter` renderer. |
|
||||||
|
| Location | New `IsPrepMode` content panel inside the Details island (like `IsNotesMode`). |
|
||||||
|
| Lifecycle | Manual click opens the view (UI-local); `PrepStarted/PrepLine/PrepFinished` events fill the log regardless of current mode; scheduled runs do not auto-open. |
|
||||||
|
| Open after schedule | Dedicated "Vorbereitungs-Log" header button + existing `PrimeStatus` footer hint. |
|
||||||
|
| Clear Day scope | All MyDay tasks regardless of status. |
|
||||||
|
| Clear Day confirm | None — clear directly. |
|
||||||
|
|
||||||
|
## Architecture
|
||||||
|
|
||||||
|
### Feature A — Live prep output
|
||||||
|
|
||||||
|
**Worker**
|
||||||
|
- Extend `IPrimeBroadcaster` (`src/ClaudeDo.Worker/Prime/Interfaces/IPrimeBroadcaster.cs`)
|
||||||
|
with `PrepStartedAsync()`, `PrepLineAsync(string line)`, `PrepFinishedAsync(bool success)`.
|
||||||
|
- Implement in `HubBroadcaster` (`src/ClaudeDo.Worker/Hub/HubBroadcaster.cs`) sending
|
||||||
|
SignalR events `PrepStarted`, `PrepLine` (string), `PrepFinished` (bool).
|
||||||
|
- `PrimeRunner` (`src/ClaudeDo.Worker/Prime/PrimeRunner.cs`): inject `IPrimeBroadcaster`.
|
||||||
|
In `FireAsync`, after the single-flight gate is entered and a run will actually happen:
|
||||||
|
call `PrepStartedAsync()` before `RunAsync`; replace the discard lambda with
|
||||||
|
`async line => await _broadcaster.PrepLineAsync(line)`; call
|
||||||
|
`PrepFinishedAsync(result.IsSuccess)` after. The "already running" early-return path
|
||||||
|
emits nothing (no run occurs). Both scheduled and manual runs go through `FireAsync`,
|
||||||
|
so both stream.
|
||||||
|
|
||||||
|
**UI**
|
||||||
|
- `WorkerClient` (`src/ClaudeDo.Ui/Services/WorkerClient.cs`): register
|
||||||
|
`_hub.On<…>("PrepStarted"/"PrepLine"/"PrepFinished", …)` each via
|
||||||
|
`Dispatcher.UIThread.Post`, raising `PrepStartedEvent` / `PrepLineEvent(string)` /
|
||||||
|
`PrepFinishedEvent(bool)`. Declare these on `IWorkerClient`.
|
||||||
|
- `DetailsIslandViewModel`: add `IsPrepMode` (bool), `IsPrepRunning` (bool), a dedicated
|
||||||
|
`PrepLog` (`ObservableCollection<LogLineViewModel>`), and `ShowPrep()` (calls
|
||||||
|
`Bind(null)`, sets `IsNotesMode=false`, `IsPrepMode=true`). Subscribe to the three prep
|
||||||
|
events in the ctor (always active, independent of mode):
|
||||||
|
- `PrepStarted` → clear `PrepLog`, `IsPrepRunning=true`.
|
||||||
|
- `PrepLine` → format the line with the same `StreamLineFormatter` path used by the
|
||||||
|
stdout branch of `OnTaskMessage`, append a `LogLineViewModel` to `PrepLog`.
|
||||||
|
- `PrepFinished` → `IsPrepRunning=false` (optionally append a status line).
|
||||||
|
Mode exclusivity: the normal task-details panel becomes visible on
|
||||||
|
`!IsNotesMode && !IsPrepMode`; `ShowNotes()` also sets `IsPrepMode=false`; `Bind(task)`
|
||||||
|
resets both flags.
|
||||||
|
- `DetailsIslandView.axaml`: add a third `<Panel IsVisible="{Binding IsPrepMode}">` in the
|
||||||
|
body grid alongside the existing details/notes panels, rendering `PrepLog` in the
|
||||||
|
terminal style (reuse the `LogLineViewModel` item template used by `SessionTerminalView`).
|
||||||
|
|
||||||
|
**Wiring**
|
||||||
|
- `TasksIslandViewModel`: add a `PrepRequested` event (mirror `NotesRequested`).
|
||||||
|
`PrepareDayCommand` raises `PrepRequested` in addition to calling
|
||||||
|
`RunDailyPrepNowAsync()`. Add `ShowPrepLogCommand` that raises `PrepRequested`. Add the
|
||||||
|
"Vorbereitungs-Log" button to the MyDay header (`IsVisible="{Binding IsMyDayList}"`).
|
||||||
|
- `IslandsShellViewModel`: wire `Tasks.PrepRequested += () => Details.ShowPrep()`.
|
||||||
|
|
||||||
|
### Feature B — Clear Day
|
||||||
|
|
||||||
|
**Worker**
|
||||||
|
- `WorkerHub.ClearMyDay()` (`src/ClaudeDo.Worker/Hub/WorkerHub.cs`): query ids where
|
||||||
|
`IsMyDay == true`; `ExecuteUpdateAsync` setting `is_my_day = false`; broadcast
|
||||||
|
`TaskUpdated(id)` for each affected id (the UI reloads the current list on `TaskUpdated`).
|
||||||
|
|
||||||
|
**UI**
|
||||||
|
- `IWorkerClient.ClearMyDayAsync()` + `WorkerClient` impl invoking `"ClearMyDay"`.
|
||||||
|
- `TasksIslandViewModel.ClearDayCommand` calls `_worker.ClearMyDayAsync()` (no confirm).
|
||||||
|
Add the "Tag leeren" button to the MyDay header next to "Tag vorbereiten".
|
||||||
|
|
||||||
|
## Data Flow (live view)
|
||||||
|
|
||||||
|
1. Trigger (schedule or button) → `PrimeRunner.FireAsync`.
|
||||||
|
2. `PrepStartedAsync()` → SignalR `PrepStarted` → `WorkerClient.PrepStartedEvent` →
|
||||||
|
`DetailsIslandViewModel` clears `PrepLog`, sets `IsPrepRunning`.
|
||||||
|
3. Each Claude stdout line → `PrepLineAsync(line)` → `PrepLine` → formatted, appended to
|
||||||
|
`PrepLog` (visible if the user is in prep mode; filled silently otherwise).
|
||||||
|
4. Run ends → `PrepFinishedAsync(success)` → `PrepFinished` → `IsPrepRunning=false`.
|
||||||
|
5. Manual button click also raised `PrepRequested` → `Details.ShowPrep()` (view open).
|
||||||
|
After a scheduled run, the user clicks "Vorbereitungs-Log" to open it.
|
||||||
|
|
||||||
|
## Error Handling
|
||||||
|
|
||||||
|
- Prep run fails/times out → `PrepFinished(false)`; the existing `PrimeFired` footer
|
||||||
|
status still reports failure.
|
||||||
|
- "Already running" → no prep events emitted (no run happened); existing behavior intact.
|
||||||
|
- `ClearMyDay` with zero MyDay tasks → no-op, no broadcasts.
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
- Worker: `PrimeRunner` streams `PrepStarted` → N×`PrepLine` → `PrepFinished` (fake
|
||||||
|
`IClaudeProcess` invokes `onStdoutLine` with sample lines; fake `IPrimeBroadcaster`
|
||||||
|
records calls). `WorkerHub.ClearMyDay` clears all IsMyDay rows and broadcasts per id
|
||||||
|
(real SQLite, mirror existing hub tests).
|
||||||
|
- UI: `DetailsIslandViewModel` appends to `PrepLog` on `PrepLineEvent` and `ShowPrep()`
|
||||||
|
sets the mode flags (mutual exclusivity with notes); `TasksIslandViewModel.ClearDayCommand`
|
||||||
|
calls `ClearMyDayAsync` (stub worker client).
|
||||||
|
|
||||||
|
## Files (high level)
|
||||||
|
|
||||||
|
**Modify**
|
||||||
|
- `src/ClaudeDo.Worker/Prime/Interfaces/IPrimeBroadcaster.cs`
|
||||||
|
- `src/ClaudeDo.Worker/Hub/HubBroadcaster.cs`
|
||||||
|
- `src/ClaudeDo.Worker/Prime/PrimeRunner.cs`
|
||||||
|
- `src/ClaudeDo.Worker/Hub/WorkerHub.cs` (ClearMyDay)
|
||||||
|
- `src/ClaudeDo.Ui/Services/Interfaces/IWorkerClient.cs`
|
||||||
|
- `src/ClaudeDo.Ui/Services/WorkerClient.cs`
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Islands/DetailsIslandViewModel.cs`
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/DetailsIslandView.axaml`
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs`
|
||||||
|
- `src/ClaudeDo.Ui/Views/Islands/TasksIslandView.axaml`
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/IslandsShellViewModel.cs`
|
||||||
|
- `src/ClaudeDo.Localization/locales/en.json`, `de.json` (button labels)
|
||||||
|
|
||||||
|
**Test**
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/Prime/PrimeRunnerTests.cs`
|
||||||
|
- `tests/ClaudeDo.Worker.Tests/Hub/…` (ClearMyDay)
|
||||||
|
- `tests/ClaudeDo.Ui.Tests/…` (DetailsIslandViewModel prep events; TasksIslandViewModel ClearDay) + `StubWorkerClient`
|
||||||
|
|
||||||
|
## Known fragility
|
||||||
|
|
||||||
|
Changing `IWorkerClient` / `WorkerClient` / VM constructors breaks hand-rolled fakes
|
||||||
|
(`StubWorkerClient`, `FakeWorkerClient`) in both test projects — update all of them.
|
||||||
114
docs/superpowers/specs/2026-06-03-localization-design.md
Normal file
114
docs/superpowers/specs/2026-06-03-localization-design.md
Normal file
@@ -0,0 +1,114 @@
|
|||||||
|
# Localization (i18n) Support — Design
|
||||||
|
|
||||||
|
**Date:** 2026-06-03
|
||||||
|
**Status:** Approved (pending spec review)
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Add translation support to ClaudeDo. The user picks a language in the Settings modal and **all** UI text reflects it instantly (no restart). The WPF installer is localized the same way and gets its own language picker. Ship **English only** now, but the system is fully data-driven: adding a new language means dropping one JSON file into a folder — **no code changes, no rebuild**.
|
||||||
|
|
||||||
|
## Decisions (from brainstorming)
|
||||||
|
|
||||||
|
- **Languages:** English only at launch; extensible via translation files.
|
||||||
|
- **Switching:** Live / instant — all bound UI text updates the moment the language changes.
|
||||||
|
- **Storage:** Selected language stored in `~/.todo-app/ui.config.json` (the local UI config that also holds `DbPath`/`SignalRUrl`). Purely a UI concern — does **not** go through the worker/SignalR settings path.
|
||||||
|
- **Installer:** Defaults to existing config language (upgrade) → OS culture → English. Shows a language picker in the wizard, live-switches its own UI, and writes the chosen language into `ui.config.json` so the app launches matching the installer.
|
||||||
|
- **Locale files:** Loose `*.json` files in a `locales/` folder next to the running exe, scanned at startup to discover available languages.
|
||||||
|
- **Code sharing:** A shared `ClaudeDo.Localization` project holds the loading/lookup/language-list logic, referenced by `ClaudeDo.Ui`, `ClaudeDo.App`, and `ClaudeDo.Installer`. Each UI framework keeps its own thin markup-extension binding layer (Avalonia ≠ WPF).
|
||||||
|
|
||||||
|
## Architecture & Components
|
||||||
|
|
||||||
|
### New shared project: `ClaudeDo.Localization`
|
||||||
|
|
||||||
|
- **`LocaleStore`** — discovers and loads `*.json` files from the `locales/` folder next to the running exe. Parses each file's nested JSON, **flattens it into an internal `Dictionary<string,string>`** keyed by dot-path for O(1) lookup, and captures `metadata.code` / `metadata.name`. Exposes the list of available languages for the dropdowns.
|
||||||
|
- **`ILocalizer` / `Localizer`** — singleton holding the *active* language dictionary. Members:
|
||||||
|
- indexer `this[string key]` → translated string (with fallback),
|
||||||
|
- `string Get(string key, params object[] args)` → `string.Format` for parameterized strings,
|
||||||
|
- `void SetLanguage(string code)` → swaps the active dictionary and raises `PropertyChanged` for the indexer so **all live bindings refresh** (this is what enables instant switching),
|
||||||
|
- `AvailableLanguages` (list of `{ code, name }`), `CurrentCode`.
|
||||||
|
- **Fallback chain:** requested key in active language → same key in English → the key path string itself (a missing translation is visible, never a crash).
|
||||||
|
- **OS-culture resolution:** helper that maps the current OS UI culture to an available locale code, falling back to English.
|
||||||
|
|
||||||
|
### Per-framework binding layer (not shared)
|
||||||
|
|
||||||
|
- **Avalonia:** a `{loc:Tr Some.Key}` markup extension that binds to `Localizer[key]` (Source = the singleton `Localizer`, Path = `[key]`). Language change raises the indexer `PropertyChanged`, refreshing every binding.
|
||||||
|
- **WPF installer:** an equivalent markup extension doing the same against the installer's own `Localizer` instance.
|
||||||
|
|
||||||
|
Both consume the **same JSON files and the same `LocaleStore`/`Localizer` logic** from the shared project.
|
||||||
|
|
||||||
|
## Translation File Format
|
||||||
|
|
||||||
|
`locales/en.json` (and future `de.json`, `fr.json`, …) — nested, human-friendly hierarchy:
|
||||||
|
|
||||||
|
```json
|
||||||
|
{
|
||||||
|
"metadata": { "code": "en", "name": "English" },
|
||||||
|
"settings": {
|
||||||
|
"save": "Save",
|
||||||
|
"cancel": "Cancel",
|
||||||
|
"general": { "model": "Model", "maxParallel": "Max parallel executions" }
|
||||||
|
},
|
||||||
|
"tasks": {
|
||||||
|
"addPlaceholder": "Add a task…",
|
||||||
|
"overdue": "OVERDUE"
|
||||||
|
},
|
||||||
|
"worktrees": { "autoCleanupDays": "{0} days" }
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
- `metadata.code` is the language id stored in `ui.config.json` and matched to OS culture; `metadata.name` is the dropdown label.
|
||||||
|
- **Lookup by dot-path key** (`"settings.general.model"`). On-disk file stays grouped/nested; the runtime flattens it for fast lookup. Authors edit a clean hierarchy.
|
||||||
|
- **Parameters:** `{0}`, `{1}` placeholders resolved via `Get(key, args)`.
|
||||||
|
- **Encoding:** UTF-8 — non-ASCII languages work out of the box.
|
||||||
|
|
||||||
|
## Data Flow & Wiring
|
||||||
|
|
||||||
|
### App config
|
||||||
|
|
||||||
|
- Add `Language` (string, e.g. `"en"`) to `AppSettings` (`ClaudeDo.Ui/AppSettings.cs`) and to the installer mirror `InstallerAppSettings` (`ClaudeDo.Installer/Core/ConfigModels.cs`).
|
||||||
|
- Add a `Save()` method to `AppSettings` (today the UI only reads it).
|
||||||
|
|
||||||
|
### App startup (`ClaudeDo.App/Program.cs`)
|
||||||
|
|
||||||
|
1. `AppSettings.Load()` reads `Language` (missing/empty → resolve from OS culture, else `"en"`).
|
||||||
|
2. `LocaleStore` scans `locales/` next to the exe; `Localizer` is registered as a singleton and set to the configured language.
|
||||||
|
3. UI renders; every `{loc:Tr ...}` binding pulls from the active dictionary.
|
||||||
|
|
||||||
|
### Changing language in Settings (General tab)
|
||||||
|
|
||||||
|
- New "Language" dropdown bound to `Localizer.AvailableLanguages`; selection bound to current code.
|
||||||
|
- On change → `Localizer.SetLanguage(code)` (instant UI refresh) **and** `AppSettings.Language = code; AppSettings.Save()`. Local UI state only — not routed through worker/SignalR.
|
||||||
|
|
||||||
|
### Installer (`ClaudeDo.Installer`)
|
||||||
|
|
||||||
|
- On launch: default language = existing `ui.config.json` `Language` if present (upgrade), else OS culture, else English.
|
||||||
|
- Wizard gets a language dropdown (same `LocaleStore`, installer's own markup extension) → live-switches the installer UI.
|
||||||
|
- When writing `ui.config.json`, persists the chosen `Language` so the app launches matching the installer.
|
||||||
|
|
||||||
|
### Build wiring
|
||||||
|
|
||||||
|
- `locales/*.json` copied to output (`CopyToOutputDirectory`) for both App and Installer.
|
||||||
|
- Installer packages the `locales/` folder so it lands beside the installed exe.
|
||||||
|
|
||||||
|
## String-Extraction Scope
|
||||||
|
|
||||||
|
Mechanical but large; done screen-by-screen so each commit is reviewable, building one `en.json` as the single source of truth.
|
||||||
|
|
||||||
|
- **22 Avalonia `.axaml` views** — replace inline `Text="..."`, `Content="..."`, `PlaceholderText="..."`, and inline `ComboBoxItem` text with `{loc:Tr key}`.
|
||||||
|
- **ViewModel strings** — user-facing literals built in C# (e.g. `HeaderTitle`, `StatusPill`, status text, parameterized messages) resolve via injected `ILocalizer` (`localizer.Get(...)`). Log messages and non-user-facing strings stay as-is. **Live-switch note:** a VM string resolved once will not refresh on language change. For VM-built user-facing text, either (a) prefer resolving in XAML via `{loc:Tr}` where possible, or (b) have the VM subscribe to the `Localizer` change event and re-raise `PropertyChanged` (or re-resolve) for its localized properties. Decide per-property during extraction.
|
||||||
|
- **10 WPF installer files** — same treatment with the installer's markup extension; VM-driven headings (`Heading`, `NextButtonText`, etc.) go through `ILocalizer`.
|
||||||
|
- **Enum-ish display values** (model names, permission modes, weekday names) — translate the *display* text while keeping the underlying value/binding intact.
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
- `ClaudeDo.Localization` unit tests: load/flatten nested JSON, dot-path lookup, fallback chain (active→en→key), `{0}` formatting, OS-culture resolution.
|
||||||
|
- `LocaleStore` discovery test (folder scan → available languages).
|
||||||
|
- **Key-coverage test:** every locale file's flattened key set matches `en.json`; fails the build if `en.json` drifts from other locale files.
|
||||||
|
- Settings round-trip test: `SetLanguage` updates `Localizer` **and** persists to `ui.config.json`.
|
||||||
|
- Manual UI pass (user's visual review): confirm instant switching with a throwaway `de.json` stub during dev, then remove it.
|
||||||
|
|
||||||
|
## Out of Scope (YAGNI)
|
||||||
|
|
||||||
|
- Pluralization rules, RTL layout, per-string gender.
|
||||||
|
- Translating the German weekly-report **body** (generated content — stays as-is).
|
||||||
|
- Localizing log output and non-user-facing strings.
|
||||||
226
docs/superpowers/specs/2026-06-03-weekly-report-design.md
Normal file
226
docs/superpowers/specs/2026-06-03-weekly-report-design.md
Normal file
@@ -0,0 +1,226 @@
|
|||||||
|
# Weekly Report — Design
|
||||||
|
|
||||||
|
**Date:** 2026-06-03
|
||||||
|
**Status:** Approved (pending spec review)
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Generate a short, standup-focused report of what the user did over the past week,
|
||||||
|
for the Wednesday standup. The report is built from the user's Claude Code session
|
||||||
|
history across all repos, distilled and summarized by Claude. Personal repos under a
|
||||||
|
configurable excluded path (default `C:\Private`) are left out. The user can author
|
||||||
|
per-day bullet notes inside ClaudeDo (via the My Day list) that are folded into the
|
||||||
|
report.
|
||||||
|
|
||||||
|
## Decisions (from brainstorming)
|
||||||
|
|
||||||
|
- **Data source:** all Claude Code history in `~/.claude/projects/*/*.jsonl`, both manual
|
||||||
|
sessions and ClaudeDo-run tasks, grouped by repo.
|
||||||
|
- **Exclusion:** a configurable list of path prefixes (default `["C:\\Private"]`). Any
|
||||||
|
session whose `cwd` starts with an excluded prefix is dropped.
|
||||||
|
- **Summarization:** Claude CLI summarizes. The Worker distills the logs, then runs a
|
||||||
|
single one-shot `claude -p` call via the existing `ClaudeProcess` and returns the
|
||||||
|
result markdown. No worktree, no task row, no queue.
|
||||||
|
- **Period:** default "since last Wednesday → today", computed from a configurable
|
||||||
|
standup weekday. The range is adjustable in the modal.
|
||||||
|
- **Signal fed to Claude:** user prompts (intent), assistant closing summaries, and the
|
||||||
|
user's daily notes. No git-commit scanning.
|
||||||
|
- **Report shape:** German, grouped by day, first-person past-tense bullets, ~3-5
|
||||||
|
bullets/day with trivia merged/dropped, notes blended into one deduplicated list per
|
||||||
|
day. See the Report Prompt section.
|
||||||
|
- **Placement:** a "Weekly Report" overlay modal opened from the toolbar, rendering via
|
||||||
|
the existing `MarkdownView`.
|
||||||
|
- **Output:** view-only in-app (no export).
|
||||||
|
- **Notes UI:** authored in the My Day list via a pinned non-task "Notes" pseudo-row that
|
||||||
|
repurposes the Details island into a bullet-notes editor. Per-day bullets with a day
|
||||||
|
navigator (prev/next arrows + date picker + Today).
|
||||||
|
- **Report persistence:** generated reports are stored, keyed by exact date range, and
|
||||||
|
reused. Generation is button-driven (never automatic); a Regenerate button overwrites.
|
||||||
|
|
||||||
|
## Architecture Overview
|
||||||
|
|
||||||
|
```
|
||||||
|
UI (WeeklyReportModal, Details-island notes mode)
|
||||||
|
│ SignalR
|
||||||
|
▼
|
||||||
|
WorkerHub ── GetWeekReport / GenerateWeekReport / daily-notes CRUD
|
||||||
|
│
|
||||||
|
├── WeekReportService ──► ClaudeHistoryReader (scan ~/.claude/projects)
|
||||||
|
│ │ (distilled activity)
|
||||||
|
│ ├── DailyNoteRepository (notes in window)
|
||||||
|
│ ├── ClaudeProcess (one-shot summarize)
|
||||||
|
│ └── WeekReportRepository (store/reuse)
|
||||||
|
└── DailyNoteRepository (CRUD)
|
||||||
|
|
||||||
|
Data: DailyNoteEntity, WeekReportEntity + repositories + EF migration
|
||||||
|
AppSettingsEntity: ReportExcludedPaths, StandupWeekday
|
||||||
|
```
|
||||||
|
|
||||||
|
## Components
|
||||||
|
|
||||||
|
### 1. Data layer (`ClaudeDo.Data`)
|
||||||
|
|
||||||
|
**`DailyNoteEntity`** (table `daily_notes`)
|
||||||
|
- `Id` (GUID string, init-only PK)
|
||||||
|
- `Date` (date-only; the day the bullet belongs to)
|
||||||
|
- `Text` (string, the bullet content)
|
||||||
|
- `SortOrder` (int; ordering within a day)
|
||||||
|
- `CreatedAt` (DateTime)
|
||||||
|
|
||||||
|
**`DailyNoteRepository`** (async, CancellationToken, follows existing repo pattern)
|
||||||
|
- `ListByDayAsync(DateOnly day)` — bullets for one day, ordered by `SortOrder`.
|
||||||
|
- `ListBetweenAsync(DateOnly start, DateOnly end)` — bullets in a window (used by the report).
|
||||||
|
- `AddAsync(DateOnly day, string text)` — appends a bullet (assigns next `SortOrder`).
|
||||||
|
- `UpdateAsync(string id, string text)`
|
||||||
|
- `DeleteAsync(string id)`
|
||||||
|
|
||||||
|
**`WeekReportEntity`** (table `week_reports`)
|
||||||
|
- `Id` (GUID string, init-only PK)
|
||||||
|
- `StartDate`, `EndDate` (date-only; the report window — unique together)
|
||||||
|
- `Markdown` (string; the generated report)
|
||||||
|
- `GeneratedAt` (DateTime)
|
||||||
|
|
||||||
|
**`WeekReportRepository`**
|
||||||
|
- `GetByRangeAsync(DateOnly start, DateOnly end)` — stored report for an exact range, or null.
|
||||||
|
- `UpsertAsync(DateOnly start, DateOnly end, string markdown)` — insert or overwrite by range.
|
||||||
|
|
||||||
|
**`AppSettingsEntity`** — two new columns:
|
||||||
|
- `ReportExcludedPaths` (string, JSON array of path prefixes; default `["C:\\Private"]`)
|
||||||
|
- `StandupWeekday` (int, `DayOfWeek`; default `Wednesday` = 3)
|
||||||
|
|
||||||
|
**Migration** — one EF migration adds `daily_notes`, `week_reports`, and the two
|
||||||
|
`app_settings` columns. Entity configs in `Configuration/` (date-only and enum/JSON
|
||||||
|
conversion via `ValueConverter`, per existing convention).
|
||||||
|
|
||||||
|
### 2. Worker (`ClaudeDo.Worker`) — new `Report/` folder
|
||||||
|
|
||||||
|
**`ClaudeHistoryReader`** (raw → distilled)
|
||||||
|
- Input: date window + excluded path prefixes.
|
||||||
|
- Enumerates `~/.claude/projects/*/*.jsonl`.
|
||||||
|
- Parses each line as JSON; tolerant of malformed lines (skip, never throw).
|
||||||
|
- Drops a session entirely if its `cwd` starts with any excluded prefix
|
||||||
|
(case-insensitive, normalized separators).
|
||||||
|
- Keeps messages whose `timestamp` falls in `[start, end]`.
|
||||||
|
- Extracts, per repo (`cwd`) → per day:
|
||||||
|
- **user prompts**: `type == "user"` text content (string or `content[].text`).
|
||||||
|
Skip tool-result-only user turns and queue/attachment/hook noise.
|
||||||
|
- **assistant closing summaries**: the final assistant text block of each turn/session.
|
||||||
|
- Output: a structured model, e.g.
|
||||||
|
`IReadOnlyList<RepoActivity>` where `RepoActivity { RepoPath, Days: List<DayActivity{ Date, Prompts[], Summaries[] }> }`.
|
||||||
|
|
||||||
|
**`WeekReportService`** (distilled → stored summary)
|
||||||
|
- `GenerateAsync(start, end, ct)`:
|
||||||
|
1. Read settings (excluded paths, standup weekday).
|
||||||
|
2. `ClaudeHistoryReader` → distilled activity.
|
||||||
|
3. `DailyNoteRepository.ListBetweenAsync` → notes grouped by day.
|
||||||
|
4. Pivot the distilled activity (repo→day from the reader) into **day-major**
|
||||||
|
(day→repo) to match the day-grouped report, and build the prompt from the
|
||||||
|
template in the Report Prompt section. Empty window → produce a "no activity"
|
||||||
|
report without calling Claude.
|
||||||
|
5. Run `ClaudeProcess` once (`claude -p`, no worktree/agents; working dir = a neutral
|
||||||
|
dir). Read `RunResult.ResultMarkdown`.
|
||||||
|
6. `WeekReportRepository.UpsertAsync(start, end, markdown)`; return markdown.
|
||||||
|
7. On Claude failure, surface `RunResult.ErrorMarkdown` to the caller (do not store).
|
||||||
|
- `GetStoredAsync(start, end)` → `WeekReportRepository.GetByRangeAsync`.
|
||||||
|
|
||||||
|
Interfaces live in `Report/Interfaces/` per the area convention.
|
||||||
|
|
||||||
|
#### Report Prompt
|
||||||
|
|
||||||
|
`WeekReportService` assembles this prompt. Instructions are in English (more reliable
|
||||||
|
steering); the output is forced to German. `{...}` are filled at build time.
|
||||||
|
|
||||||
|
```
|
||||||
|
You are generating a concise weekly standup report for a software developer.
|
||||||
|
Summarize what they accomplished between {start:dd.MM.yyyy} and {end:dd.MM.yyyy}.
|
||||||
|
|
||||||
|
Rules:
|
||||||
|
- Write the ENTIRE report in German.
|
||||||
|
- Group by day. One "## {Wochentag}, {dd.MM.yyyy}" section per day that has
|
||||||
|
activity (German weekday names). Omit days with no activity entirely.
|
||||||
|
- Within each day: 3–5 first-person, past-tense bullets ("- Habe X umgesetzt",
|
||||||
|
"- Y behoben"). Merge related small work into one bullet.
|
||||||
|
- Drop trivia: typo fixes, pure exploration, false starts, tooling/log noise.
|
||||||
|
- Blend the developer's own notes and the derived activity into ONE deduplicated
|
||||||
|
bullet list per day. The developer's notes are authoritative — never omit or
|
||||||
|
contradict their substance.
|
||||||
|
- Name the project/repo when it adds clarity.
|
||||||
|
- Output ONLY the dated sections. No preamble, no intro, no closing remarks.
|
||||||
|
|
||||||
|
== Activity (from session history) ==
|
||||||
|
{day-major: for each day → for each repo → its prompts + closing summaries}
|
||||||
|
|
||||||
|
== Developer notes ==
|
||||||
|
{day-major: for each day → the bullets}
|
||||||
|
```
|
||||||
|
|
||||||
|
### 3. IPC (Hub + WorkerClient)
|
||||||
|
|
||||||
|
**`WorkerHub`** new methods:
|
||||||
|
- `GetWeekReport(string startIso, string endIso)` → stored markdown or null.
|
||||||
|
- `GenerateWeekReport(string startIso, string endIso)` → generates, stores, returns markdown.
|
||||||
|
- `GetDailyNotes(string dayIso)` → bullets for a day.
|
||||||
|
- `AddDailyNote(string dayIso, string text)` → created bullet.
|
||||||
|
- `UpdateDailyNote(string id, string text)`.
|
||||||
|
- `DeleteDailyNote(string id)`.
|
||||||
|
|
||||||
|
**`WorkerClient`** (UI) mirrors these, following the existing
|
||||||
|
`WorkerPrimeScheduleApi`/AppSettings method pattern.
|
||||||
|
|
||||||
|
### 4. UI (`ClaudeDo.Ui`)
|
||||||
|
|
||||||
|
**Weekly Report modal** (`WeeklyReportModalView` + `WeeklyReportModalViewModel`)
|
||||||
|
- Overlay modal in the `Modals/` pattern (like `WorktreesOverviewModalView`),
|
||||||
|
registered in `IslandsShellViewModel`, opened from a new toolbar button.
|
||||||
|
- Date range: two `ThemedDatePicker`s, default "since last Wednesday → today" computed
|
||||||
|
from `StandupWeekday`.
|
||||||
|
- On open and on range change: call `GetWeekReport`.
|
||||||
|
- Stored report exists → render markdown via `MarkdownView`, show `GeneratedAt`, show
|
||||||
|
a **Regenerate** button.
|
||||||
|
- None → empty state ("Not generated yet") + a **Generate** button.
|
||||||
|
- **Generate**/**Regenerate**: call `GenerateWeekReport` with a busy/spinner state;
|
||||||
|
render the returned markdown. Generation only ever runs from these buttons.
|
||||||
|
- View-only; no export.
|
||||||
|
|
||||||
|
**Notes in My Day**
|
||||||
|
- The My Day smart list (`smart:my-day`) pins a fixed, non-task "Notes" pseudo-row at
|
||||||
|
the top, recognized by the list/selection code (not a `TaskEntity`).
|
||||||
|
- Selecting it puts the **Details island** into **notes mode** (task fields hidden,
|
||||||
|
notes editor shown). The island hosts a dedicated `NotesEditorViewModel` + small view
|
||||||
|
rather than swelling `DetailsIslandViewModel` (already ~978 lines); the bullet logic
|
||||||
|
stays isolated and testable.
|
||||||
|
- **Day navigator** in the editor header: `<` / `>` arrows to step days, a
|
||||||
|
`ThemedDatePicker` to jump to any date, and a "Today" button. Defaults to today; the
|
||||||
|
pinned row's default day rolls over at midnight (no data lost — past days remain
|
||||||
|
reachable via the navigator).
|
||||||
|
- **Bullet editing** for the selected day: list of bullets with add / inline-edit /
|
||||||
|
delete / reorder (`SortOrder`). Each operation goes through the daily-notes hub CRUD.
|
||||||
|
|
||||||
|
### 5. Settings
|
||||||
|
|
||||||
|
- Add the excluded-path list and the standup weekday to the existing Settings modal,
|
||||||
|
persisted via the new `app_settings` columns and the existing
|
||||||
|
`GetAppSettings`/`UpdateAppSettings` path.
|
||||||
|
|
||||||
|
## Error Handling
|
||||||
|
|
||||||
|
- Malformed/unreadable JSONL lines are skipped, never fatal.
|
||||||
|
- Empty window → a "no activity" report, no Claude call.
|
||||||
|
- Claude call failure → error surfaced in the modal; nothing stored.
|
||||||
|
- Date ranges normalized to date-only; the stored report key is the exact (start, end).
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
- **`ClaudeHistoryReader`** (Worker tests, fixture `.jsonl`): date-window filtering,
|
||||||
|
excluded-prefix dropping (case/separator normalization), prompt/summary extraction,
|
||||||
|
malformed-line tolerance, repo/day grouping.
|
||||||
|
- **`WeekReportService`**: prompt-building from distilled activity + notes; empty-window
|
||||||
|
short-circuit; storage upsert; with a faked `ClaudeProcess`.
|
||||||
|
- **`DailyNoteRepository`** and **`WeekReportRepository`**: CRUD / upsert / range lookup
|
||||||
|
against real SQLite (matches existing test style).
|
||||||
|
|
||||||
|
## Out of Scope
|
||||||
|
|
||||||
|
- Report export (clipboard/file) — view-only for now.
|
||||||
|
- Git-commit scanning.
|
||||||
|
- Editing or summarizing full transcripts; only prompts + closing summaries are used.
|
||||||
@@ -0,0 +1,236 @@
|
|||||||
|
# Bundled Prompts Overhaul — Design
|
||||||
|
|
||||||
|
Date: 2026-06-04
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Replace ClaudeDo's bundled prompts with a clean, professional baseline and make
|
||||||
|
every prose prompt a user-editable file with a bundled default. Add a roadblock
|
||||||
|
protocol so an autonomous run can flag problems mid-task without aborting.
|
||||||
|
|
||||||
|
The execution-side defaults (`system.md`) ship as a moderate, **project-agnostic**
|
||||||
|
engineering baseline — ClaudeDo users run tasks against their *own* repos, so no
|
||||||
|
ClaudeDo-specific rules belong there. Everything is in English (tighter
|
||||||
|
tokenization, more reliable instruction-following); the only German output is the
|
||||||
|
weekly report, which a human reads.
|
||||||
|
|
||||||
|
## File layout
|
||||||
|
|
||||||
|
All prompts live under `~/.todo-app/prompts/` as editable files with bundled
|
||||||
|
defaults seeded by `PromptFiles.EnsureExists` (which never overwrites a file the
|
||||||
|
user already has). The `system` + `agent` prompts collapse into one `system.md`;
|
||||||
|
the old `agent`/manual distinction was removed when tags were retired.
|
||||||
|
|
||||||
|
| File | Replaces | Placeholders |
|
||||||
|
|---|---|---|
|
||||||
|
| `system.md` | system + agent (merged) | — |
|
||||||
|
| `planning-system.md` | planning system prompt | — |
|
||||||
|
| `planning-initial.md` | "analyze & break down" kickoff | `{title}`, `{description}` |
|
||||||
|
| `retry.md` | "try again and fix" prompt | — |
|
||||||
|
| `daily-prep.md` | daily-prep prompt | `{date}`, `{maxTasks}` |
|
||||||
|
| `weekly-report.md` | weekly-report instructions | `{start}`, `{end}` |
|
||||||
|
|
||||||
|
The task-execution prompt (title + description + `## Sub-Tasks` checkboxes) stays
|
||||||
|
assembled in code — it is data-shaped, not prose.
|
||||||
|
|
||||||
|
### Templating
|
||||||
|
|
||||||
|
`PromptFiles` gains `Render(PromptKind kind, IReadOnlyDictionary<string,string> values)`
|
||||||
|
that replaces **only** the known named tokens for that kind. Any other `{...}` in
|
||||||
|
the file (e.g. the literal `{Wochentag}` / `{dd.MM.yyyy}` in the German report
|
||||||
|
rules) passes through untouched. Daily-prep tool names are inlined as literals —
|
||||||
|
`--allowedTools` already carries the real names, and inlining keeps the file from
|
||||||
|
silently breaking if a user edits a placeholder.
|
||||||
|
|
||||||
|
### Migration
|
||||||
|
|
||||||
|
`EnsureExists` keeps its current semantics: it seeds a default only when the file
|
||||||
|
is missing, never overwriting user edits. The old `planning.md` and `agent.md`
|
||||||
|
become inert — `TaskRunner` stops reading `agent.md`, and the planning system
|
||||||
|
prompt now reads `planning-system.md`. Old files are harmless to leave or delete.
|
||||||
|
`PromptKind` changes: `Agent` is removed; `Planning` maps to `planning-system.md`;
|
||||||
|
new kinds `PlanningInitial`, `Retry`, `DailyPrep`, `WeeklyReport` are added.
|
||||||
|
|
||||||
|
## Roadblock protocol
|
||||||
|
|
||||||
|
An autonomous run has no human watching, so it must not silently stop or block on
|
||||||
|
a question. Instead the agent emits an inline marker whenever it hits a true
|
||||||
|
blocker, **any number of times**, and keeps working on whatever it still can.
|
||||||
|
|
||||||
|
- **Prompt side** (`system.md`): instruct the agent to write
|
||||||
|
`CLAUDEDO_BLOCKED: <one short sentence>` on its own line whenever something
|
||||||
|
genuinely prevents progress (missing credentials, contradictory requirements, a
|
||||||
|
destructive action it won't take unasked) — then continue with the rest of the
|
||||||
|
task. Reserved for true blockers, not routine decisions it can make itself.
|
||||||
|
- **Detection** (`StreamAnalyzer`): as `assistant` messages stream, scan their
|
||||||
|
text content for lines matching `^CLAUDEDO_BLOCKED:` and collect each reason
|
||||||
|
into an ordered list (`Blocks`). This is live and cumulative — multiple problems
|
||||||
|
across one run are all captured, not just the last.
|
||||||
|
- **Result wiring** (`StreamResult` → `RunResult` → run record): carry the
|
||||||
|
collected `Blocks`. Strip the marker lines from the displayed result text.
|
||||||
|
- **Routing**: a run that finishes with blocks still goes to `WaitingForReview`
|
||||||
|
(standalone tasks) — it is "done as far as the agent could get". The review card
|
||||||
|
shows a ⚠ roadblock hint listing the collected problems. The user answers them
|
||||||
|
via the existing reject-rerun feedback path, which resumes the session with the
|
||||||
|
answers as the next-turn prompt — so the agent continues with the problems
|
||||||
|
resolved rather than restarting.
|
||||||
|
|
||||||
|
## The prompts
|
||||||
|
|
||||||
|
### `system.md`
|
||||||
|
```markdown
|
||||||
|
# Working Agreement
|
||||||
|
|
||||||
|
You are completing one well-defined task autonomously in a git repository.
|
||||||
|
|
||||||
|
## Scope
|
||||||
|
- Do exactly what the task asks — no unrequested refactors, renames, dependency
|
||||||
|
changes, or "while I'm here" cleanup.
|
||||||
|
- If intent is ambiguous, state the assumption you're making and proceed with the
|
||||||
|
most reasonable reading. Stop only if you genuinely cannot move forward.
|
||||||
|
- Prefer three similar lines over a premature abstraction. Don't build for
|
||||||
|
hypothetical future needs.
|
||||||
|
|
||||||
|
## Working in the repo
|
||||||
|
- Read a file before editing it. Match the conventions already in this codebase —
|
||||||
|
they override generic defaults.
|
||||||
|
- Prefer editing existing files to creating new ones. Don't write comments that
|
||||||
|
just restate the code.
|
||||||
|
- Validate only at real boundaries (user input, external APIs).
|
||||||
|
|
||||||
|
## Finishing
|
||||||
|
- Before claiming done, verify: run the build and relevant tests, confirm they
|
||||||
|
pass, and report what you ran. If you couldn't verify something, say so plainly.
|
||||||
|
- Make focused commits using the repository's existing commit-message convention.
|
||||||
|
|
||||||
|
## Safety
|
||||||
|
- Never force-push, hard-reset, or delete branches/files beyond the task's scope
|
||||||
|
without being asked.
|
||||||
|
- Don't introduce injection/XSS/secret-leak issues. Never commit credentials.
|
||||||
|
|
||||||
|
## You are running unattended
|
||||||
|
You run autonomously with no human watching. There is no one to answer mid-task
|
||||||
|
questions, so never stop to ask — make the most reasonable decision, note the
|
||||||
|
assumption, and continue.
|
||||||
|
|
||||||
|
## When you are blocked
|
||||||
|
If something genuinely prevents you from completing part of the task (missing
|
||||||
|
credentials, contradictory requirements, a destructive action you won't take
|
||||||
|
unasked), do NOT silently give up. Write this marker on its own line, then keep
|
||||||
|
working on whatever else you can:
|
||||||
|
|
||||||
|
CLAUDEDO_BLOCKED: <one short sentence describing what blocked you>
|
||||||
|
|
||||||
|
Emit it as many times as needed — once per distinct blocker. Use it only for true
|
||||||
|
blockers, not for routine decisions you can make yourself.
|
||||||
|
```
|
||||||
|
|
||||||
|
> `system.md` also gains an **"Out-of-scope improvements"** section that tells the
|
||||||
|
> agent to file follow-up work via the `SuggestImprovement` tool. That section is
|
||||||
|
> defined in `2026-06-04-child-tasks-and-improvement-loop-design.md` and lands with
|
||||||
|
> that feature.
|
||||||
|
|
||||||
|
### `planning-system.md`
|
||||||
|
```markdown
|
||||||
|
You are the planning assistant for ClaudeDo. Your job is to break a task into
|
||||||
|
smaller, independently executable subtasks — the session ends by creating those
|
||||||
|
subtasks.
|
||||||
|
|
||||||
|
Start every session by invoking the `superpowers:brainstorming` skill (Skill
|
||||||
|
tool) and follow it end to end: clarifying questions one at a time, then 2–3
|
||||||
|
approaches with a recommendation, then a short design. Do not create any subtasks
|
||||||
|
until the user has approved the design.
|
||||||
|
|
||||||
|
You can ONLY shape this task's plan — you cannot edit files or touch other tasks.
|
||||||
|
The tools available to you are: CreateChildTask, ListChildTasks, UpdateChildTask,
|
||||||
|
DeleteChildTask, UpdatePlanningTask, and Finalize. Use nothing else.
|
||||||
|
|
||||||
|
Once the design is approved, create the child tasks with CreateChildTask, then
|
||||||
|
call Finalize. Keep each subtask concrete and self-contained with a clear
|
||||||
|
done-state, ordered so dependencies come first.
|
||||||
|
```
|
||||||
|
|
||||||
|
### `planning-initial.md`
|
||||||
|
```markdown
|
||||||
|
# Task to plan: {title}
|
||||||
|
|
||||||
|
{description}
|
||||||
|
```
|
||||||
|
|
||||||
|
### `retry.md`
|
||||||
|
```markdown
|
||||||
|
The task did not complete on the previous attempt — you may have run out of
|
||||||
|
turns, hit an error, or stopped before finishing.
|
||||||
|
|
||||||
|
Review the work already done in this session and the current state of the
|
||||||
|
repository, identify what is still incomplete or broken, and finish the task.
|
||||||
|
Don't restart from scratch or repeat a failed approach. Verify the result
|
||||||
|
(build + tests) before you stop.
|
||||||
|
```
|
||||||
|
Self-contained — no error injection. The runner appends the captured process
|
||||||
|
output **only when it is a genuine error** (i.e. not the generic
|
||||||
|
`"Claude exited with code N and no result."` fallback), since real session errors
|
||||||
|
are already in the resumed context.
|
||||||
|
|
||||||
|
### `daily-prep.md`
|
||||||
|
```markdown
|
||||||
|
You are preparing my workday for {date}.
|
||||||
|
|
||||||
|
1. Call mcp__claudedo__get_daily_prep_candidates.
|
||||||
|
2. Keep tasks already marked MyDay (currentMyDay) — never remove them.
|
||||||
|
3. Fill MyDay to at most {maxTasks} open tasks TOTAL (currentMyDay counts). Never exceed it.
|
||||||
|
4. Estimate each candidate's effort and pick a feasible mix — not only big items.
|
||||||
|
Prioritize isStarred, due (scheduledFor), and older tasks.
|
||||||
|
5. Place related tasks next to each other using consecutive sortOrder values.
|
||||||
|
6. Apply via mcp__claudedo__set_my_day(taskId, true, sortOrder). Never mark anything
|
||||||
|
outside the candidate list.
|
||||||
|
|
||||||
|
If there are no candidates, do nothing.
|
||||||
|
```
|
||||||
|
|
||||||
|
### `weekly-report.md`
|
||||||
|
```markdown
|
||||||
|
You are generating a concise weekly standup report for a software developer,
|
||||||
|
covering {start} to {end}.
|
||||||
|
|
||||||
|
Rules:
|
||||||
|
- Write the ENTIRE report in German.
|
||||||
|
- Group by day. One "## {Wochentag}, {dd.MM.yyyy}" section per day that has
|
||||||
|
activity (German weekday names). Omit days with no activity.
|
||||||
|
- Within each day: 3–5 first-person, past-tense bullets ("- Habe X umgesetzt",
|
||||||
|
"- Y behoben"). Merge related small work into one bullet.
|
||||||
|
- Drop trivia: typo fixes, pure exploration, false starts, tooling/log noise.
|
||||||
|
- Blend the developer's own notes and the derived activity into ONE deduplicated
|
||||||
|
bullet list per day. The notes are authoritative — never omit or contradict them.
|
||||||
|
- Name the project/repo when it adds clarity.
|
||||||
|
- Output ONLY the dated sections. No preamble, no intro, no closing remarks.
|
||||||
|
|
||||||
|
Two sections follow below: an activity log derived from Claude session history,
|
||||||
|
and the developer's own notes. Base the report on both; the notes are
|
||||||
|
authoritative where they conflict with the derived activity.
|
||||||
|
```
|
||||||
|
|
||||||
|
## Touch points
|
||||||
|
|
||||||
|
- `src/ClaudeDo.Data/PromptFiles.cs` — new `PromptKind` members, new defaults,
|
||||||
|
`Render` helper.
|
||||||
|
- `src/ClaudeDo.Worker/Runner/TaskRunner.cs` — stop reading `agent.md`; use
|
||||||
|
`retry.md`; conditional stderr append on retry; carry/route `Blocks`.
|
||||||
|
- `src/ClaudeDo.Worker/Runner/StreamAnalyzer.cs` — scan assistant text for
|
||||||
|
`CLAUDEDO_BLOCKED:` markers, collect `Blocks`, strip from result.
|
||||||
|
- `src/ClaudeDo.Worker/Runner/ClaudeProcess.cs` / `RunResult` — carry `Blocks`.
|
||||||
|
- `src/ClaudeDo.Worker/Planning/PlanningSessionManager.cs` — read
|
||||||
|
`planning-system.md` and `planning-initial.md` via `PromptFiles.Render`.
|
||||||
|
- `src/ClaudeDo.Worker/Prime/DailyPrepPrompt.cs` — read `daily-prep.md`.
|
||||||
|
- `src/ClaudeDo.Worker/Report/WeekReportPromptBuilder.cs` — read `weekly-report.md`.
|
||||||
|
- UI — review card shows the ⚠ roadblock hint with collected problems.
|
||||||
|
- `src/ClaudeDo.Ui/.../FilesSettingsTabViewModel.cs` — expose the new prompt files.
|
||||||
|
- Tests — `PromptFiles` render/seed; `StreamAnalyzer` marker collection; planning/
|
||||||
|
prep/report builders read from files.
|
||||||
|
|
||||||
|
## Out of scope
|
||||||
|
|
||||||
|
- The in-code task-execution assembly (title/description/subtasks) is unchanged.
|
||||||
|
- `ResultSchema` / `--output-schema` remains untouched.
|
||||||
|
- No change to commit-message templating.
|
||||||
|
```
|
||||||
@@ -0,0 +1,186 @@
|
|||||||
|
# Reusable Child Tasks + Agent Improvement Loop — Design
|
||||||
|
|
||||||
|
Date: 2026-06-04
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Let an executing task agent offload out-of-scope improvements it spots into
|
||||||
|
**child tasks** that run automatically, so ClaudeDo can drive a self-improvement
|
||||||
|
loop. Generalize the parent/child machinery that planning uses today into a
|
||||||
|
reusable subsystem not bound to planning.
|
||||||
|
|
||||||
|
Example: while implementing task X, Claude notices "this module should really be
|
||||||
|
refactored, but that's out of scope" — instead of scope-creeping, it calls a tool
|
||||||
|
that files the refactor as a child of X. The child runs on its own; once all of
|
||||||
|
X's children finish, X surfaces for review with its whole tree visible.
|
||||||
|
|
||||||
|
This builds on the bundled-prompts overhaul (`system.md` gains one instruction to
|
||||||
|
use the offload tool). It is otherwise independent.
|
||||||
|
|
||||||
|
## Lifecycle
|
||||||
|
|
||||||
|
A new task status `WaitingForChildren` is added.
|
||||||
|
|
||||||
|
```
|
||||||
|
Running → WaitingForReview standalone success, no children (existing)
|
||||||
|
Running → WaitingForChildren standalone success, ≥1 child (new)
|
||||||
|
Running → Done planning child success (existing)
|
||||||
|
WaitingForChildren → WaitingForReview all children terminal (new)
|
||||||
|
WaitingForChildren → Cancelled cancel (new)
|
||||||
|
```
|
||||||
|
|
||||||
|
- Improvement-children are created `Idle` **during** the parent's run and stay
|
||||||
|
unqueued until the parent's own run finishes — this avoids the parent and a
|
||||||
|
child working the same repo concurrently.
|
||||||
|
- When the parent's run succeeds and it has ≥1 non-terminal child, the parent goes
|
||||||
|
to `WaitingForChildren` and its children are enqueued (they then run under the
|
||||||
|
normal queue, governed by max-parallel — they are independent, not a forced
|
||||||
|
sequential chain like planning).
|
||||||
|
- Children run automatically and reach `Done` on success without their own review
|
||||||
|
gate (a per-child review would stall the loop). Each child still produces its
|
||||||
|
own worktree/commit; those worktrees are surfaced under the parent for merge.
|
||||||
|
- Children emit `CLAUDEDO_BLOCKED:` markers like any run (see the prompt-overhaul
|
||||||
|
spec). Each child's collected problems roll up onto the **parent's** review card,
|
||||||
|
so a parent in `WaitingForReview` shows "child N reported a problem" alongside
|
||||||
|
its own roadblocks.
|
||||||
|
|
||||||
|
## Worktree topology & merge
|
||||||
|
|
||||||
|
The correctness rule that makes this work:
|
||||||
|
|
||||||
|
- **Children base off the parent's worktree HEAD, not the list's base branch.**
|
||||||
|
The parent's code work lives only on `claudedo/{parentId}` until merged, so a
|
||||||
|
child refactoring code the parent just wrote must branch from the parent's HEAD
|
||||||
|
to see it. (Planning children base off the target branch because a planning
|
||||||
|
parent writes no code — improvement parents do, hence the difference.) The
|
||||||
|
per-run worktree setup takes the base commit from the parent task's recorded
|
||||||
|
worktree HEAD when `ParentTaskId` is set and the parent is a non-planning task.
|
||||||
|
- **Fan-out:** all children branch off the same parent HEAD and run independently
|
||||||
|
(parallel allowed). Parent-dependency is always satisfied; sibling overlaps
|
||||||
|
surface later as merge conflicts.
|
||||||
|
- **Merge reuses the planning orchestrator,** generalized into a shared
|
||||||
|
"tree merge": build an integration branch off the target, then sequentially
|
||||||
|
`merge --no-ff` the **parent's own branch** followed by each child branch,
|
||||||
|
pausing on conflict (continue / abort), exactly as `PlanningMergeOrchestrator`
|
||||||
|
/`PlanningAggregator` do today. Approving the parent triggers this one guided
|
||||||
|
flow, merging parent + all children in as few steps as possible. Because
|
||||||
|
children descend from the parent HEAD, the parent's commits are shared ancestors
|
||||||
|
and merge cleanly ahead of the children.
|
||||||
|
- The parent advances to `WaitingForReview` once **all** children are terminal —
|
||||||
|
counting `Done`, `Failed`, and `Cancelled`, so a failed child can't wedge the
|
||||||
|
parent forever. Failed/cancelled children are flagged on the review card.
|
||||||
|
|
||||||
|
Planning parents keep their existing behavior (parent → `Done` when its chain
|
||||||
|
finishes); they do not use `WaitingForChildren`.
|
||||||
|
|
||||||
|
## Consolidating the child subsystem
|
||||||
|
|
||||||
|
Today child handling is planning-coupled. Generalize:
|
||||||
|
|
||||||
|
- **`TaskRepository.CreateChildAsync`** — drop the `parent.PlanningPhase != None`
|
||||||
|
guard. A child can attach to any existing parent. (Planning callers are
|
||||||
|
unaffected; their parents have a planning phase.) The child sets
|
||||||
|
`ParentTaskId = parentId`; the caller decides `CreatedBy`.
|
||||||
|
- **Child-completion coordinator** — generalize planning's
|
||||||
|
`OnChildFinishedAsync` / `TryCompleteParentAsync` into a single component that,
|
||||||
|
on any child reaching a terminal state, checks the parent and applies a
|
||||||
|
**completion policy**:
|
||||||
|
- *planning parent* → finalize/Done (existing chain advancement stays in the
|
||||||
|
planning layer: unblock the next chained child).
|
||||||
|
- *improvement parent* (in `WaitingForChildren`, all children terminal) →
|
||||||
|
`WaitingForReview`.
|
||||||
|
- `TaskStateService` remains the sole writer of `Status` and owns the new
|
||||||
|
transitions (`SubmitForChildrenAsync`, the `WaitingForChildren → WaitingForReview`
|
||||||
|
advance).
|
||||||
|
|
||||||
|
## The offload tool
|
||||||
|
|
||||||
|
A narrow MCP tool exposed only to task runs (not the general external surface):
|
||||||
|
|
||||||
|
```
|
||||||
|
SuggestImprovement(title, description) → { childTaskId }
|
||||||
|
```
|
||||||
|
|
||||||
|
- The **server** stamps everything — the agent cannot choose the parent, the
|
||||||
|
status, or queue anything directly:
|
||||||
|
- `ParentTaskId = <calling task id>`
|
||||||
|
- `CreatedBy = <calling task id>` (unambiguous "agent-suggested improvement"
|
||||||
|
marker — distinct from `null` user/planning tasks and `"mcp"` external tasks)
|
||||||
|
- `Status = Idle`, same `ListId` as the parent.
|
||||||
|
- **One layer deep:** the tool rejects the call if the calling task already has a
|
||||||
|
`ParentTaskId` (a child cannot spawn children).
|
||||||
|
|
||||||
|
### Knowing the caller's identity
|
||||||
|
|
||||||
|
The always-on external `claudedo` MCP is shared and can't tell which task is
|
||||||
|
calling. So task runs get a **per-run MCP identity**, mirroring planning's
|
||||||
|
per-session token:
|
||||||
|
|
||||||
|
- `TaskRunner` mints a per-run token and writes a run-scoped `.mcp.json` (or
|
||||||
|
reuses the global server with a token header) so the offload tool resolves
|
||||||
|
token → calling task id server-side. A `TaskRunMcpContextAccessor` exposes the
|
||||||
|
current task id to the tool, the same way `PlanningMcpContextAccessor` does.
|
||||||
|
- This is the reliable path for both correct provenance and the one-layer-deep
|
||||||
|
guard — the id is never supplied by the model.
|
||||||
|
|
||||||
|
`system.md` gains a short instruction (from the prompt-overhaul spec):
|
||||||
|
|
||||||
|
```markdown
|
||||||
|
## Out-of-scope improvements
|
||||||
|
If you notice worthwhile work that is genuinely outside this task's scope
|
||||||
|
(a refactor, a follow-up, tech debt), do NOT do it here. File it with
|
||||||
|
SuggestImprovement(title, description) and stay focused on the task at hand.
|
||||||
|
```
|
||||||
|
|
||||||
|
## UI
|
||||||
|
|
||||||
|
- **Collapsible tree:** children group under their parent (by `ParentTaskId`).
|
||||||
|
Improvement-children are visually marked as agent-suggested (via
|
||||||
|
`CreatedBy == parentId`).
|
||||||
|
- **New status chip** for `WaitingForChildren` (e.g. amber "waiting on N
|
||||||
|
improvements") with its own color in `StatusColorConverter`.
|
||||||
|
- **Review card** for a parent in `WaitingForReview` lists child outcomes
|
||||||
|
(done/failed) and their rolled-up `CLAUDEDO_BLOCKED` problems, and drives the
|
||||||
|
shared tree-merge (parent + children) via the planning-style sequential flow
|
||||||
|
with conflict pause/continue/abort.
|
||||||
|
|
||||||
|
## Data / migration
|
||||||
|
|
||||||
|
- Add `WaitingForChildren` to the `TaskStatus` enum and its EF `ValueConverter`.
|
||||||
|
No new columns — `ParentTaskId` and `CreatedBy` already exist. No backfill
|
||||||
|
needed (no existing rows use the new value).
|
||||||
|
|
||||||
|
## Touch points
|
||||||
|
|
||||||
|
- `src/ClaudeDo.Data/Models/TaskStatus` (enum) + `TaskEntityConfiguration` — new value.
|
||||||
|
- `src/ClaudeDo.Data/Repositories/TaskRepository.cs` — generalize `CreateChildAsync`.
|
||||||
|
- `src/ClaudeDo.Worker/State/TaskStateService.cs` — `WaitingForChildren` transitions.
|
||||||
|
- `src/ClaudeDo.Worker/Runner/TaskRunner.cs` — route to `WaitingForChildren` when
|
||||||
|
children exist; enqueue children on parent finish; mint per-run MCP token.
|
||||||
|
- New: child-completion coordinator (generalized from planning) + the offload tool
|
||||||
|
(e.g. `TaskRunMcpService.SuggestImprovement`) + `TaskRunMcpContextAccessor` +
|
||||||
|
token auth (mirrors `PlanningTokenAuth`).
|
||||||
|
- `src/ClaudeDo.Worker/Planning/*` — refactor planning to consume the shared
|
||||||
|
child-completion coordinator and the shared tree-merge; keep chain-specific
|
||||||
|
advancement local. Generalize `PlanningMergeOrchestrator` / `PlanningAggregator`
|
||||||
|
into a reusable tree-merge that also folds in the parent's own branch.
|
||||||
|
- Worktree setup (`TaskRunner` / `WorktreeManager`) — base an improvement-child's
|
||||||
|
worktree on the parent task's recorded worktree HEAD instead of the list base.
|
||||||
|
- UI — tree grouping, `WaitingForChildren` chip/color, parent review card with
|
||||||
|
child outcomes + rolled-up roadblocks + the merge flow.
|
||||||
|
- Tests — offload tool stamps parent/createdBy + rejects nested calls;
|
||||||
|
parent → `WaitingForChildren` → `WaitingForReview` lifecycle; child worktree
|
||||||
|
bases off parent HEAD; tree-merge folds parent + children; planning regression
|
||||||
|
(still reaches Done).
|
||||||
|
|
||||||
|
## Open questions for review
|
||||||
|
|
||||||
|
1. **Failed child:** parent still advances to `WaitingForReview` with the failure
|
||||||
|
flagged (default), vs. parent → `Failed` if any child failed.
|
||||||
|
|
||||||
|
## Out of scope
|
||||||
|
|
||||||
|
- Multi-level nesting (only one layer deep by design).
|
||||||
|
- Per-list "disable improvement offload" toggle (could come later; the tool is
|
||||||
|
always available to top-level runs for now).
|
||||||
|
- Changes to how planning sets up its sequential chain.
|
||||||
@@ -0,0 +1,90 @@
|
|||||||
|
# Debug Logging & Frontend↔Backend Traceability — Design
|
||||||
|
|
||||||
|
**Date:** 2026-06-04
|
||||||
|
**Status:** Approved (pending spec review)
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Make debug logging rich enough to diagnose problems across the UI↔Worker boundary, while keeping the installed (production) build near-silent. Verbosity is decided by **build configuration, detected at runtime** — no runtime knob, no config field, no `#if DEBUG`:
|
||||||
|
|
||||||
|
- **Debug build** (Rider run button) → verbose, console + file.
|
||||||
|
- **Release build** (installed app) → minimal, file only.
|
||||||
|
|
||||||
|
## Decisions (from brainstorming)
|
||||||
|
|
||||||
|
1. **Mechanism:** runtime build-config detection via the entry assembly's `DebuggableAttribute` (JIT optimizer disabled ⇒ Debug build). A single `BuildConfig.IsDebug` helper drives ordinary `if` branching — no `#if DEBUG` directives. Rider's run button builds `Debug`; the installer ships `-c Release`.
|
||||||
|
2. **Scope:** Worker **and** App/Ui. The desktop side currently has no log sink at all — UI/IPC failures vanish today.
|
||||||
|
3. **Release behavior:** all three log `Warning`+ to file (not silent — capture crashes). Worker drops from its current `Information` to `Warning`.
|
||||||
|
4. **One shared log file** across both processes, unified timeline.
|
||||||
|
5. **Correlation:** TaskId-based (option A). Enrich log lines with `TaskId` when one is in scope. No changes to the SignalR contract (`IWorkerClient`/`WorkerHub` untouched → test fakes untouched).
|
||||||
|
|
||||||
|
## Verbosity matrix
|
||||||
|
|
||||||
|
| Process | Debug build | Release build |
|
||||||
|
|---|---|---|
|
||||||
|
| Worker | `Debug` level, console + shared file | `Warning` level, shared file |
|
||||||
|
| App/Ui | `Debug` level, console + shared file | `Warning` level, shared file |
|
||||||
|
|
||||||
|
## Shared log file
|
||||||
|
|
||||||
|
- Single daily-rolling file: `~/.todo-app/logs/claudedo-.log` (Serilog appends the date).
|
||||||
|
- `shared: true` on both processes' file sinks → Serilog coordinates multi-process writes via a global mutex.
|
||||||
|
- `retainedFileCountLimit: 2`.
|
||||||
|
- Each line is tagged with a `Process` property (`"worker"` / `"app"`) so the two sides are distinguishable in the interleaved timeline.
|
||||||
|
|
||||||
|
> The existing `worker-.log` is replaced by `claudedo-.log`. Task-run NDJSON (`{taskId}_run{n}.ndjson`) and `daily-prep.log` are **out of scope** — they are data streams, not diagnostic logs, and stay exactly as they are.
|
||||||
|
|
||||||
|
## Output template
|
||||||
|
|
||||||
|
```
|
||||||
|
[{Timestamp:HH:mm:ss.fff} {Level:u3}] {Process}/{SourceContext} [{TaskId}] {Message:lj}{NewLine}{Exception}
|
||||||
|
```
|
||||||
|
|
||||||
|
- `{Process}` — `worker` or `app`.
|
||||||
|
- `{SourceContext}` — the `ILogger<T>` category (the logging class), so you see *which* component spoke.
|
||||||
|
- `{TaskId}` — the correlation key, defaulted to `-` when no task is in scope (see enricher below).
|
||||||
|
|
||||||
|
## Traceability (TaskId correlation)
|
||||||
|
|
||||||
|
Use Serilog's `LogContext` (`.Enrich.FromLogContext()` on both processes) plus a small default enricher so `TaskId` is always present (renders `-` when absent — avoids the raw `{TaskId}` token leaking into output).
|
||||||
|
|
||||||
|
Push the property at the entry points where a task is in scope; all nested `ILogger<T>` calls inherit it automatically:
|
||||||
|
|
||||||
|
- **Worker:** wrap per-task execution in `TaskRunner` (the run/continue entry) with `using (LogContext.PushProperty("TaskId", task.Id))`. This covers the bulk of backend activity (runner, state transitions, worktree, planning) for free.
|
||||||
|
- **App/Ui:** push `TaskId` in `WorkerClient` task-targeted calls (e.g. RunNow / Cancel / Continue / review actions) so the UI side of a task action carries the same key.
|
||||||
|
|
||||||
|
Result: grep one `TaskId` in `claudedo-.log` and read the full UI→Worker→UI story in timestamp order.
|
||||||
|
|
||||||
|
This adds **no parameters** to the SignalR surface — correlation rides on the existing `taskId` arguments already present in those calls.
|
||||||
|
|
||||||
|
## Implementation surface
|
||||||
|
|
||||||
|
A single shared helper keeps the two processes' Serilog setup from drifting.
|
||||||
|
|
||||||
|
- **New project:** `ClaudeDo.Logging` — a small library both `ClaudeDo.App` and `ClaudeDo.Worker` reference (keeps `ClaudeDo.Data` free of any Serilog dependency). Contains:
|
||||||
|
- `BuildConfig.IsDebug` — checks the entry assembly's `DebuggableAttribute` (`IsJITOptimizerDisabled` ⇒ Debug build). Cached static.
|
||||||
|
- The output template and the default-TaskId enricher.
|
||||||
|
- `ConfigureLogger(LoggerConfiguration, processTag, logRoot)` — applies level/sink choices by branching on `BuildConfig.IsDebug` (Debug ⇒ `Debug` level + console + file; Release ⇒ `Warning` level + file only). Both processes call it so level/template/retention stay in sync.
|
||||||
|
- **Worker `Program.cs:34`:** replace the inline `UseSerilog` body with a call into the shared helper (`processTag = "worker"`).
|
||||||
|
- **App `Program.cs`:** add Serilog packages; build a logger via the shared helper (`Process = "app"`) and register it with `sc.AddLogging(b => b.AddSerilog(logger, dispose: true))`. App currently registers **no** logging at all, so this also makes `ILogger<T>` injection actually work UI-side. Remove/keep `.LogToTrace()` as appropriate (Avalonia internal trace, separate concern — leave it).
|
||||||
|
- **App shutdown:** flush/close the logger (`Log.CloseAndFlush()` or dispose via the container's existing `finally`).
|
||||||
|
|
||||||
|
### Packages to add (App project)
|
||||||
|
|
||||||
|
- `Serilog.Extensions.Logging` (bridge `ILogger` → Serilog)
|
||||||
|
- `Serilog.Sinks.File`
|
||||||
|
- `Serilog.Sinks.Console`
|
||||||
|
- (Worker already has Serilog + File sink; add `Serilog.Sinks.Console` for the Debug console output.)
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
- This is logging wiring; per project policy, no tests that spawn the real Claude CLI and no heavy test scaffolding for log output.
|
||||||
|
- Light verification: a unit-level check that the default enricher yields `-` when no `TaskId` is pushed, and (if practical) that `ConfigureLogger` wires the expected sinks. `BuildConfig.IsDebug` reflects the test assembly's own build config, so it can't be flipped within one run — assert each branch by passing the level/flag explicitly rather than relying on the ambient value, or verify the Release path and smoke-test Debug manually from Rider.
|
||||||
|
- Manual smoke test (documented, not automated): run from Rider, confirm console + `claudedo-.log` show `Debug` lines with `Process`/`SourceContext`; run a task and confirm both `app` and `worker` lines share the same `[TaskId]`.
|
||||||
|
|
||||||
|
## Out of scope
|
||||||
|
|
||||||
|
- Runtime/config log-level knob.
|
||||||
|
- Per-call correlation IDs for non-task flows (connect, config edits, prep) — TaskId-only for now; revisit if a non-task flow proves to be a black hole.
|
||||||
|
- Changes to task-run NDJSON capture or `daily-prep.log`.
|
||||||
|
- Any change to `IWorkerClient` / `WorkerHub` signatures.
|
||||||
@@ -0,0 +1,154 @@
|
|||||||
|
# Inherited settings display, per-task overrides, and Turns
|
||||||
|
|
||||||
|
**Date:** 2026-06-04
|
||||||
|
**Status:** Approved (design)
|
||||||
|
|
||||||
|
## Problem
|
||||||
|
|
||||||
|
Config inheritance is three-tier (Task → List → Global app settings). Today the UI
|
||||||
|
only signals inheritance with a placeholder sentinel (`(inherit)` for tasks,
|
||||||
|
`(default)` for lists) and, for tasks, a faint "Effective if inherited: {value}"
|
||||||
|
hint under Model and Agent. Two gaps:
|
||||||
|
|
||||||
|
1. You can't see the *actual resolved value* an inherited field will use, nor where
|
||||||
|
it comes from (List vs Global).
|
||||||
|
2. **Max turns** is global-only (`AppSettingsEntity.DefaultMaxTurns` = 100). It is not
|
||||||
|
overridable per list or per task, unlike Model / SystemPrompt / AgentPath.
|
||||||
|
|
||||||
|
## Goals
|
||||||
|
|
||||||
|
- Show the real inherited value in-place, muted, with a **source-aware marker**
|
||||||
|
(`inherited · List` vs `inherited · Global`). Picking a value turns it into an
|
||||||
|
override; a reset affordance clears it back to inherited.
|
||||||
|
- Add **Turns** (max turns) as an overridable field at both List and Task levels,
|
||||||
|
inheriting from the global default. Numeric box; empty = inherit.
|
||||||
|
- Keep SystemPrompt as-is (it is additive, not override) but show what gets prepended.
|
||||||
|
|
||||||
|
## Non-goals
|
||||||
|
|
||||||
|
- No change to SystemPrompt merge semantics (stays additive/concatenated).
|
||||||
|
- No new global settings; `DefaultMaxTurns` already exists.
|
||||||
|
- No change to PermissionMode handling.
|
||||||
|
|
||||||
|
## Inheritance semantics (reference)
|
||||||
|
|
||||||
|
Resolved in `TaskRunner.BuildRunConfig` (~line 388):
|
||||||
|
|
||||||
|
| Field | Semantics | Resolution |
|
||||||
|
|--------------|------------|--------------------------------------------------------|
|
||||||
|
| Model | override | `task.Model ?? listConfig?.Model ?? global.DefaultModel` |
|
||||||
|
| AgentPath | override | `task.AgentPath ?? listConfig?.AgentPath` (no global) |
|
||||||
|
| MaxTurns | override | **new:** `task.MaxTurns ?? listConfig?.MaxTurns ?? global.DefaultMaxTurns` |
|
||||||
|
| SystemPrompt | additive | merged: global + list + task + agent (unchanged) |
|
||||||
|
|
||||||
|
Lists inherit only from Global (no tier above them), so a list's inherited marker is
|
||||||
|
always `inherited · Global`.
|
||||||
|
|
||||||
|
## Design
|
||||||
|
|
||||||
|
### 1. Data layer
|
||||||
|
|
||||||
|
- `ListConfigEntity`: add `int? MaxTurns`.
|
||||||
|
- `TaskEntity`: add `int? MaxTurns` (nullable override).
|
||||||
|
- EF Core migration adding `max_turns` column to `list_config` and `tasks`
|
||||||
|
(nullable, no default — null = inherit).
|
||||||
|
- `TaskRunner` BuildRunConfig: `MaxTurns: task.MaxTurns ?? listConfig?.MaxTurns ?? global.DefaultMaxTurns`.
|
||||||
|
`ClaudeRunConfig.MaxTurns` and `ClaudeArgsBuilder` already accept/emit `--max-turns`
|
||||||
|
when `> 0` — no change needed there.
|
||||||
|
- `ListRepository.SetConfigAsync` (upsert) and `TaskRepository.UpdateAgentSettingsAsync`
|
||||||
|
extend to carry `maxTurns`.
|
||||||
|
|
||||||
|
### 2. DTOs / transport
|
||||||
|
|
||||||
|
Add `int? MaxTurns` to (Worker + Ui copies kept in sync):
|
||||||
|
|
||||||
|
- `UpdateListConfigDto`, `ListConfigDto` (WorkerHub.cs + WorkerClient.cs)
|
||||||
|
- `UpdateTaskAgentSettingsDto` (WorkerHub.cs + WorkerClient.cs)
|
||||||
|
- `TaskConfigDto` (ConfigMcpTools.cs)
|
||||||
|
|
||||||
|
`WorkerHub.UpdateListConfig` / `UpdateTaskAgentSettings` persist the new field via the
|
||||||
|
repositories above. MCP `SetListConfig` / `SetTaskConfig` gain an optional `maxTurns`
|
||||||
|
parameter to keep the agent-facing API at parity with the UI.
|
||||||
|
|
||||||
|
### 3. Resolution helper (Ui)
|
||||||
|
|
||||||
|
A small helper that, given `(taskValue, listValue, globalValue)`, returns
|
||||||
|
`(effectiveValue, source)` where `source ∈ { Override, List, Global }`. Drives the
|
||||||
|
marker text and muted/normal styling for Model, Agent, and Turns so the logic isn't
|
||||||
|
duplicated per field or per editor. Lives in the Ui layer beside its consumers.
|
||||||
|
|
||||||
|
### 4. UI rendering — inherited marker (source-aware)
|
||||||
|
|
||||||
|
For **Model**, **Agent**, **Turns** in both `ListSettingsModalView` and the
|
||||||
|
DetailsIsland "Agent settings (overrides)" expander:
|
||||||
|
|
||||||
|
- Remove the `(inherit)` / `(default)` sentinel *row* from the control's item source.
|
||||||
|
- When no override is set: control shows the **resolved value muted/greyed** (dropdown
|
||||||
|
shows e.g. "sonnet" dimmed; Turns box shows e.g. "100" as a muted placeholder), and a
|
||||||
|
small badge beside the field label reads `inherited · List` or `inherited · Global`.
|
||||||
|
- On picking a value / typing a number: it becomes an override — text returns to normal
|
||||||
|
color, the badge flips to `override` (or hides), and a small **"↺ reset to inherited"**
|
||||||
|
affordance appears that clears the value back to null.
|
||||||
|
- List modal: source is always Global → badge reads `inherited · Global`; reset clears
|
||||||
|
to the global default.
|
||||||
|
- Turns: numeric box, empty = inherit (muted resolved number as placeholder); a typed
|
||||||
|
number is the override.
|
||||||
|
|
||||||
|
**Rendering approach:** a small reusable `InheritedFieldHeader` control (label + badge +
|
||||||
|
reset button), fed by the resolution helper's `source`, wraps each field. Keeps the three
|
||||||
|
fields consistent and avoids per-field XAML duplication. Badge / muted styling uses
|
||||||
|
existing design tokens. Visual polish pass is the user's.
|
||||||
|
|
||||||
|
### 5. SystemPrompt (stays plain)
|
||||||
|
|
||||||
|
SystemPrompt keeps its plain multi-line text box (additive, not override). Below it, a
|
||||||
|
small **read-only, collapsed-by-default** hint shows the inherited prompts that will be
|
||||||
|
prepended (global + list), labeled e.g. "Prepended automatically:". No marker, no reset —
|
||||||
|
it never replaces, only appends.
|
||||||
|
|
||||||
|
### 6. Localization
|
||||||
|
|
||||||
|
New keys in `locales/en.json` + `locales/de.json` (parity enforced by Localization.Tests):
|
||||||
|
marker text (`inherited · List`, `inherited · Global`, `override`), reset affordance
|
||||||
|
label, Turns field label, and the SystemPrompt "prepended automatically" hint. Retire the
|
||||||
|
now-unused `vm.details.effectiveIfInherited` key (and its German counterpart) if nothing
|
||||||
|
else references it.
|
||||||
|
|
||||||
|
## Affected files (indicative)
|
||||||
|
|
||||||
|
- `src/ClaudeDo.Data/Models/ListConfigEntity.cs`, `TaskEntity.cs`
|
||||||
|
- `src/ClaudeDo.Data/Migrations/` (new migration)
|
||||||
|
- `src/ClaudeDo.Data/Repositories/ListRepository.cs`, `TaskRepository.cs`
|
||||||
|
- `src/ClaudeDo.Data/Configuration/` (column mapping for `max_turns`)
|
||||||
|
- `src/ClaudeDo.Worker/Runner/TaskRunner.cs`
|
||||||
|
- `src/ClaudeDo.Worker/Hub/WorkerHub.cs`
|
||||||
|
- `src/ClaudeDo.Worker/External/ConfigMcpTools.cs`
|
||||||
|
- `src/ClaudeDo.Ui/Services/WorkerClient.cs` (+ `Interfaces/IWorkerClient.cs`)
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Modals/ListSettingsModalViewModel.cs` + view
|
||||||
|
- `src/ClaudeDo.Ui/ViewModels/Islands/DetailsIslandViewModel.cs` + `DetailsIslandView.axaml`
|
||||||
|
- `src/ClaudeDo.Ui/Views/Controls/` (new `InheritedFieldHeader`)
|
||||||
|
- `src/ClaudeDo.Ui/` resolution helper
|
||||||
|
- `locales/en.json`, `locales/de.json`
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
- Data: migration applies; `MaxTurns` round-trips through `ListRepository.SetConfigAsync`
|
||||||
|
and `TaskRepository.UpdateAgentSettingsAsync`.
|
||||||
|
- Worker: `BuildRunConfig` resolves MaxTurns via task → list → global precedence
|
||||||
|
(unit test on the resolution). Existing `ClaudeArgsBuilder` `--max-turns` behavior
|
||||||
|
unchanged.
|
||||||
|
- Ui: resolution helper returns correct `(value, source)` for each of the
|
||||||
|
override / list / global cases across Model, Agent, Turns.
|
||||||
|
- Localization: en/de key parity (existing Localization.Tests).
|
||||||
|
- Test fakes: update hand-rolled `IWorkerClient` fakes in both test projects for the new
|
||||||
|
DTO fields (per known gotcha).
|
||||||
|
- Visual verification of the marker / muted styling: flagged for the user (cannot be
|
||||||
|
asserted programmatically).
|
||||||
|
|
||||||
|
## Open risks
|
||||||
|
|
||||||
|
- DTO/ctor changes ripple into hand-rolled test fakes in Worker.Tests and Ui.Tests —
|
||||||
|
must be updated in the same change.
|
||||||
|
- Removing the sentinel row from dropdowns changes selection binding; ensure null/empty
|
||||||
|
override state is represented without a sentinel item (e.g. dropdown `SelectedItem`
|
||||||
|
null when inherited).
|
||||||
@@ -9,6 +9,7 @@
|
|||||||
<ResourceDictionary>
|
<ResourceDictionary>
|
||||||
<ResourceDictionary.MergedDictionaries>
|
<ResourceDictionary.MergedDictionaries>
|
||||||
<ResourceInclude Source="avares://ClaudeDo.Ui/Design/Tokens.axaml" />
|
<ResourceInclude Source="avares://ClaudeDo.Ui/Design/Tokens.axaml" />
|
||||||
|
<ResourceInclude Source="avares://ClaudeDo.Ui/Views/Controls/ModalShell.axaml" />
|
||||||
</ResourceDictionary.MergedDictionaries>
|
</ResourceDictionary.MergedDictionaries>
|
||||||
|
|
||||||
<!-- Converters -->
|
<!-- Converters -->
|
||||||
@@ -18,6 +19,8 @@
|
|||||||
<converters:UpperCaseConverter x:Key="UpperCase"/>
|
<converters:UpperCaseConverter x:Key="UpperCase"/>
|
||||||
<converters:IconKeyConverter x:Key="IconKey"/>
|
<converters:IconKeyConverter x:Key="IconKey"/>
|
||||||
<converters:DotBrushConverter x:Key="DotBrush"/>
|
<converters:DotBrushConverter x:Key="DotBrush"/>
|
||||||
|
<converters:BoolToItalicConverter x:Key="BoolToItalic"/>
|
||||||
|
<converters:BoolToDraftOpacityConverter x:Key="BoolToDraftOpacity"/>
|
||||||
|
|
||||||
</ResourceDictionary>
|
</ResourceDictionary>
|
||||||
</Application.Resources>
|
</Application.Resources>
|
||||||
@@ -29,6 +32,13 @@
|
|||||||
<Application.Styles>
|
<Application.Styles>
|
||||||
<FluentTheme />
|
<FluentTheme />
|
||||||
<StyleInclude Source="avares://ClaudeDo.Ui/Design/IslandStyles.axaml" />
|
<StyleInclude Source="avares://ClaudeDo.Ui/Design/IslandStyles.axaml" />
|
||||||
|
<!-- Global defaults: every Window inherits Inter Tight + body size.
|
||||||
|
Controls that need mono opt in via their own class/style. -->
|
||||||
|
<Style Selector="Window">
|
||||||
|
<Setter Property="FontFamily" Value="{DynamicResource SansFont}" />
|
||||||
|
<Setter Property="FontSize" Value="{DynamicResource FontSizeBody}" />
|
||||||
|
<Setter Property="Foreground" Value="{DynamicResource TextBrush}" />
|
||||||
|
</Style>
|
||||||
<Style Selector="ListBoxItem:selected /template/ ContentPresenter">
|
<Style Selector="ListBoxItem:selected /template/ ContentPresenter">
|
||||||
<Setter Property="Background" Value="{DynamicResource AccentGlowBrush}"/>
|
<Setter Property="Background" Value="{DynamicResource AccentGlowBrush}"/>
|
||||||
</Style>
|
</Style>
|
||||||
|
|||||||
@@ -1,3 +1,4 @@
|
|||||||
|
using System;
|
||||||
using Avalonia;
|
using Avalonia;
|
||||||
using Avalonia.Controls.ApplicationLifetimes;
|
using Avalonia.Controls.ApplicationLifetimes;
|
||||||
using Avalonia.Markup.Xaml;
|
using Avalonia.Markup.Xaml;
|
||||||
@@ -10,7 +11,12 @@ namespace ClaudeDo.App;
|
|||||||
|
|
||||||
public partial class App : Application
|
public partial class App : Application
|
||||||
{
|
{
|
||||||
public static ServiceProvider Services { get; set; } = null!;
|
private readonly IServiceProvider? _services;
|
||||||
|
|
||||||
|
// Parameterless ctor is required by the XAML previewer / designer.
|
||||||
|
public App() { }
|
||||||
|
|
||||||
|
public App(IServiceProvider services) => _services = services;
|
||||||
|
|
||||||
public override void Initialize()
|
public override void Initialize()
|
||||||
{
|
{
|
||||||
@@ -21,14 +27,19 @@ public partial class App : Application
|
|||||||
{
|
{
|
||||||
if (ApplicationLifetime is IClassicDesktopStyleApplicationLifetime desktop)
|
if (ApplicationLifetime is IClassicDesktopStyleApplicationLifetime desktop)
|
||||||
{
|
{
|
||||||
|
var services = _services
|
||||||
|
?? throw new InvalidOperationException("App was constructed without a service provider.");
|
||||||
|
|
||||||
|
FocusClearing.Install();
|
||||||
|
|
||||||
desktop.MainWindow = new MainWindow
|
desktop.MainWindow = new MainWindow
|
||||||
{
|
{
|
||||||
DataContext = Services.GetRequiredService<IslandsShellViewModel>(),
|
DataContext = services.GetRequiredService<IslandsShellViewModel>(),
|
||||||
};
|
};
|
||||||
|
|
||||||
// Kick off the SignalR retry loop — reconnects indefinitely if the worker
|
// Kick off the SignalR retry loop — reconnects indefinitely if the worker
|
||||||
// is not up yet, or goes down and comes back.
|
// is not up yet, or goes down and comes back.
|
||||||
_ = Services.GetRequiredService<WorkerClient>().StartAsync();
|
_ = services.GetRequiredService<WorkerClient>().StartAsync();
|
||||||
}
|
}
|
||||||
|
|
||||||
base.OnFrameworkInitializationCompleted();
|
base.OnFrameworkInitializationCompleted();
|
||||||
|
|||||||
@@ -19,8 +19,8 @@ Desktop entry point for the ClaudeDo application. Configures DI, initializes the
|
|||||||
|
|
||||||
## DI Registration Pattern
|
## DI Registration Pattern
|
||||||
|
|
||||||
- **Singletons**: SqliteConnectionFactory, all Repositories, WorkerClient, MainWindowViewModel, TaskListViewModel, TaskDetailViewModel, StatusBarViewModel
|
- **Singletons**: `IDbContextFactory`, all Repositories, GitService, WorkerClient, `IReleaseClient`, `InstallerLocator` / `WorkerLocator`, the island VMs (`ListsIslandViewModel`, `TasksIslandViewModel`, `DetailsIslandViewModel`) and `IslandsShellViewModel` (the window's DataContext)
|
||||||
- **Transients**: TaskEditorViewModel, ListEditorViewModel (created per dialog)
|
- **Transients**: modal VMs (`SettingsModalViewModel`, `MergeModalViewModel`, `ListSettingsModalViewModel`, `RepoImportModalViewModel`, `WorktreeModalViewModel`, `WorktreesOverviewModalViewModel`, `PrimeClaudeTabViewModel`), several exposed as `Func<T>` factories for on-demand dialog creation
|
||||||
|
|
||||||
## Notes
|
## Notes
|
||||||
|
|
||||||
|
|||||||
@@ -24,9 +24,13 @@
|
|||||||
</PackageReference>
|
</PackageReference>
|
||||||
<PackageReference Include="CommunityToolkit.Mvvm" Version="8.4.1" />
|
<PackageReference Include="CommunityToolkit.Mvvm" Version="8.4.1" />
|
||||||
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.1" />
|
<PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.1" />
|
||||||
|
<PackageReference Include="Serilog.Extensions.Logging" Version="8.0.0" />
|
||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
|
|
||||||
<ItemGroup>
|
<ItemGroup>
|
||||||
<ProjectReference Include="..\ClaudeDo.Ui\ClaudeDo.Ui.csproj" />
|
<ProjectReference Include="..\ClaudeDo.Ui\ClaudeDo.Ui.csproj" />
|
||||||
|
<ProjectReference Include="..\ClaudeDo.Logging\ClaudeDo.Logging.csproj" />
|
||||||
|
<ProjectReference Include="..\ClaudeDo.Localization\ClaudeDo.Localization.csproj" />
|
||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
|
<Import Project="..\ClaudeDo.Localization\Locales.targets" />
|
||||||
</Project>
|
</Project>
|
||||||
|
|||||||
@@ -1,14 +1,26 @@
|
|||||||
using Avalonia;
|
using Avalonia;
|
||||||
using ClaudeDo.Data;
|
using ClaudeDo.Data;
|
||||||
using ClaudeDo.Data.Git;
|
using ClaudeDo.Data.Git;
|
||||||
|
using ClaudeDo.Localization;
|
||||||
|
using ClaudeDo.Releases;
|
||||||
using ClaudeDo.Ui;
|
using ClaudeDo.Ui;
|
||||||
|
using ClaudeDo.Ui.Localization;
|
||||||
using ClaudeDo.Ui.Services;
|
using ClaudeDo.Ui.Services;
|
||||||
|
using ClaudeDo.Ui.Services.Interfaces;
|
||||||
using ClaudeDo.Ui.ViewModels;
|
using ClaudeDo.Ui.ViewModels;
|
||||||
using ClaudeDo.Ui.ViewModels.Islands;
|
using ClaudeDo.Ui.ViewModels.Islands;
|
||||||
using ClaudeDo.Ui.ViewModels.Modals;
|
using ClaudeDo.Ui.ViewModels.Modals;
|
||||||
|
using ClaudeDo.Ui.ViewModels.Modals.Settings;
|
||||||
using Microsoft.EntityFrameworkCore;
|
using Microsoft.EntityFrameworkCore;
|
||||||
using Microsoft.Extensions.DependencyInjection;
|
using Microsoft.Extensions.DependencyInjection;
|
||||||
|
using Microsoft.Extensions.Logging;
|
||||||
|
using Serilog;
|
||||||
using System;
|
using System;
|
||||||
|
using System.Globalization;
|
||||||
|
using System.IO;
|
||||||
|
using System.Linq;
|
||||||
|
using System.Net.Http;
|
||||||
|
using System.Reflection;
|
||||||
using System.Runtime.InteropServices;
|
using System.Runtime.InteropServices;
|
||||||
|
|
||||||
namespace ClaudeDo.App;
|
namespace ClaudeDo.App;
|
||||||
@@ -25,7 +37,6 @@ sealed class Program
|
|||||||
SetCurrentProcessExplicitAppUserModelID("ClaudeDo.App");
|
SetCurrentProcessExplicitAppUserModelID("ClaudeDo.App");
|
||||||
|
|
||||||
var services = BuildServices();
|
var services = BuildServices();
|
||||||
App.Services = services;
|
|
||||||
|
|
||||||
using (var scope = services.CreateScope())
|
using (var scope = services.CreateScope())
|
||||||
{
|
{
|
||||||
@@ -35,7 +46,7 @@ sealed class Program
|
|||||||
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
BuildAvaloniaApp()
|
ConfigureAppBuilder(AppBuilder.Configure(() => new App(services)))
|
||||||
.StartWithClassicDesktopLifetime(args);
|
.StartWithClassicDesktopLifetime(args);
|
||||||
}
|
}
|
||||||
finally
|
finally
|
||||||
@@ -48,8 +59,12 @@ sealed class Program
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Parameterless entry point required by the XAML previewer / designer.
|
||||||
public static AppBuilder BuildAvaloniaApp()
|
public static AppBuilder BuildAvaloniaApp()
|
||||||
=> AppBuilder.Configure<App>()
|
=> ConfigureAppBuilder(AppBuilder.Configure<App>());
|
||||||
|
|
||||||
|
private static AppBuilder ConfigureAppBuilder(AppBuilder builder)
|
||||||
|
=> builder
|
||||||
.UsePlatformDetect()
|
.UsePlatformDetect()
|
||||||
#if DEBUG
|
#if DEBUG
|
||||||
.WithDeveloperTools()
|
.WithDeveloperTools()
|
||||||
@@ -64,8 +79,26 @@ sealed class Program
|
|||||||
|
|
||||||
var sc = new ServiceCollection();
|
var sc = new ServiceCollection();
|
||||||
|
|
||||||
|
var logRoot = Path.Combine(Path.GetDirectoryName(dbPath)!, "logs");
|
||||||
|
var serilogLogger = ClaudeDo.Logging.LoggingSetup
|
||||||
|
.Configure(new LoggerConfiguration(), "app", logRoot)
|
||||||
|
.CreateLogger();
|
||||||
|
sc.AddLogging(b => b.AddSerilog(serilogLogger, dispose: true));
|
||||||
|
|
||||||
// Infrastructure
|
// Infrastructure
|
||||||
sc.AddSingleton(settings);
|
sc.AddSingleton(settings);
|
||||||
|
var localesDir = Path.Combine(AppContext.BaseDirectory, "locales");
|
||||||
|
var localeStore = LocaleStore.Load(localesDir);
|
||||||
|
var initialLang = !string.IsNullOrWhiteSpace(settings.Language)
|
||||||
|
? settings.Language
|
||||||
|
: CultureResolver.Resolve(
|
||||||
|
CultureInfo.CurrentUICulture.Name,
|
||||||
|
localeStore.Available.Select(l => l.Code).ToArray(),
|
||||||
|
fallback: "en");
|
||||||
|
var localizer = new Localizer(localeStore, initialLang);
|
||||||
|
TrExtension.Localizer = localizer;
|
||||||
|
ClaudeDo.Ui.Localization.Loc.Current = localizer;
|
||||||
|
sc.AddSingleton<ILocalizer>(localizer);
|
||||||
sc.AddDbContextFactory<ClaudeDoDbContext>(opt =>
|
sc.AddDbContextFactory<ClaudeDoDbContext>(opt =>
|
||||||
opt.UseSqlite($"Data Source={dbPath}"));
|
opt.UseSqlite($"Data Source={dbPath}"));
|
||||||
sc.AddScoped<ClaudeDoDbContext>(sp =>
|
sc.AddScoped<ClaudeDoDbContext>(sp =>
|
||||||
@@ -73,13 +106,42 @@ sealed class Program
|
|||||||
|
|
||||||
// Services
|
// Services
|
||||||
sc.AddSingleton<GitService>();
|
sc.AddSingleton<GitService>();
|
||||||
sc.AddSingleton(sp => new WorkerClient(sp.GetRequiredService<AppSettings>().SignalRUrl));
|
sc.AddSingleton(sp => new WorkerClient(
|
||||||
|
sp.GetRequiredService<AppSettings>().SignalRUrl,
|
||||||
|
sp.GetRequiredService<ILogger<WorkerClient>>()));
|
||||||
|
sc.AddSingleton<IWorkerClient>(sp => sp.GetRequiredService<WorkerClient>());
|
||||||
|
|
||||||
|
// Release check + installer update
|
||||||
|
sc.AddSingleton<HttpClient>(_ => new HttpClient { Timeout = TimeSpan.FromSeconds(10) });
|
||||||
|
sc.AddSingleton<IReleaseClient>(sp => new ReleaseClient(sp.GetRequiredService<HttpClient>()));
|
||||||
|
sc.AddSingleton<InstallerLocator>();
|
||||||
|
sc.AddSingleton<WorkerLocator>();
|
||||||
|
sc.AddSingleton(sp =>
|
||||||
|
{
|
||||||
|
var releases = sp.GetRequiredService<IReleaseClient>();
|
||||||
|
var informational = Assembly.GetEntryAssembly()?
|
||||||
|
.GetCustomAttribute<AssemblyInformationalVersionAttribute>()?.InformationalVersion;
|
||||||
|
// Strip MinVer build metadata ("+sha") and any prerelease suffix for the update-compare.
|
||||||
|
var version = (informational ?? "0.0.0").Split('+')[0];
|
||||||
|
return new UpdateCheckService(releases, version);
|
||||||
|
});
|
||||||
|
|
||||||
// ViewModels
|
// ViewModels
|
||||||
sc.AddTransient<WorktreeModalViewModel>();
|
sc.AddTransient<WorktreeModalViewModel>();
|
||||||
|
sc.AddTransient<Func<WorktreeModalViewModel>>(sp => () => sp.GetRequiredService<WorktreeModalViewModel>());
|
||||||
|
sc.AddTransient<WorktreesOverviewModalViewModel>();
|
||||||
|
sc.AddTransient<Func<WorktreesOverviewModalViewModel>>(sp => () => sp.GetRequiredService<WorktreesOverviewModalViewModel>());
|
||||||
|
sc.AddSingleton<IPrimeScheduleApi, WorkerPrimeScheduleApi>();
|
||||||
|
sc.AddSingleton<INotesApi, WorkerNotesApi>();
|
||||||
|
sc.AddTransient<PrimeClaudeTabViewModel>();
|
||||||
sc.AddTransient<SettingsModalViewModel>();
|
sc.AddTransient<SettingsModalViewModel>();
|
||||||
sc.AddTransient<MergeModalViewModel>();
|
sc.AddTransient<MergeModalViewModel>();
|
||||||
|
sc.AddTransient<Func<MergeModalViewModel>>(sp => () => sp.GetRequiredService<MergeModalViewModel>());
|
||||||
sc.AddTransient<ListSettingsModalViewModel>();
|
sc.AddTransient<ListSettingsModalViewModel>();
|
||||||
|
sc.AddTransient<RepoImportModalViewModel>();
|
||||||
|
sc.AddTransient<Func<RepoImportModalViewModel>>(sp => () => sp.GetRequiredService<RepoImportModalViewModel>());
|
||||||
|
sc.AddTransient<WeeklyReportModalViewModel>();
|
||||||
|
sc.AddTransient<Func<WeeklyReportModalViewModel>>(sp => () => sp.GetRequiredService<WeeklyReportModalViewModel>());
|
||||||
|
|
||||||
// Islands shell VMs
|
// Islands shell VMs
|
||||||
sc.AddSingleton<ListsIslandViewModel>(sp =>
|
sc.AddSingleton<ListsIslandViewModel>(sp =>
|
||||||
@@ -95,7 +157,8 @@ sealed class Program
|
|||||||
new DetailsIslandViewModel(
|
new DetailsIslandViewModel(
|
||||||
sp.GetRequiredService<IDbContextFactory<ClaudeDoDbContext>>(),
|
sp.GetRequiredService<IDbContextFactory<ClaudeDoDbContext>>(),
|
||||||
sp.GetRequiredService<WorkerClient>(),
|
sp.GetRequiredService<WorkerClient>(),
|
||||||
sp));
|
sp,
|
||||||
|
sp.GetRequiredService<INotesApi>()));
|
||||||
sc.AddSingleton<IslandsShellViewModel>();
|
sc.AddSingleton<IslandsShellViewModel>();
|
||||||
|
|
||||||
return sc.BuildServiceProvider();
|
return sc.BuildServiceProvider();
|
||||||
|
|||||||
@@ -4,23 +4,27 @@ Shared data layer: models, repositories, SQLite infrastructure, and git operatio
|
|||||||
|
|
||||||
## Models
|
## Models
|
||||||
|
|
||||||
- **TaskEntity** — Id, ListId, Title, Description, Status (Manual|Queued|Running|Done|Failed), ScheduledFor, Result, LogPath, timestamps, CommitType, Model / SystemPrompt / AgentPath (nullable overrides), IsStarred, IsMyDay, Notes
|
- **TaskEntity** — Id, ListId, Title, Description, Status (`Idle|Queued|Running|WaitingForReview|Done|Failed|Cancelled`), PlanningPhase (`None|Active|Finalized` — parent-only), BlockedByTaskId (nullable FK to predecessor in a chain), ScheduledFor, Result, ReviewFeedback (nullable; reviewer's rejection comment, consumed and cleared by the runner on the next re-run), LogPath, timestamps, CommitType, Model / SystemPrompt / AgentPath / MaxTurns (nullable overrides), IsStarred, IsMyDay, Notes, ParentTaskId, PlanningSessionId, PlanningSessionToken, PlanningFinalizedAt, CreatedBy. Legacy values `Manual`/`Planning`/`Planned`/`Draft`/`Waiting` were retired; existing rows backfill automatically via the `RetireLegacyTaskStatus` migration.
|
||||||
- **ListEntity** — Id, Name, WorkingDir, DefaultCommitType, CreatedAt
|
- **ListEntity** — Id, Name, WorkingDir, DefaultCommitType, CreatedAt
|
||||||
- **ListConfigEntity** — ListId (PK, 1:1 with list), Model, SystemPrompt, AgentPath (all nullable)
|
- **ListConfigEntity** — ListId (PK, 1:1 with list), Model, SystemPrompt, AgentPath, MaxTurns (all nullable)
|
||||||
- **TagEntity** — Id (autoincrement), Name (unique)
|
|
||||||
- **WorktreeEntity** — TaskId (PK, 1:1 with task), Path, BranchName, BaseCommit, HeadCommit, DiffStat, State (Active|Merged|Discarded|Kept)
|
- **WorktreeEntity** — TaskId (PK, 1:1 with task), Path, BranchName, BaseCommit, HeadCommit, DiffStat, State (Active|Merged|Discarded|Kept)
|
||||||
- **TaskRunEntity** — per-run record (session_id, tokens, turns, result, structured output, exit code, log path)
|
- **TaskRunEntity** — per-run record (session_id, tokens, turns, result, structured output, exit code, log path)
|
||||||
|
- **PrimeScheduleEntity** — Id, Days (`[Flags] PrimeDays` weekday bitmask, stored as `days_of_week` int), TimeOfDay, Enabled, LastRunAt, PromptOverride, CreatedAt. Recurs on the selected weekdays; no date range.
|
||||||
|
- **DailyNoteEntity** — Id, Date (DateOnly), Text, SortOrder, CreatedAt → table `daily_notes`
|
||||||
|
- **WeekReportEntity** — Id, StartDate/EndDate (DateOnly), Markdown, GeneratedAt → table `week_reports`, unique index on (start_date, end_date)
|
||||||
|
- **AppSettingsEntity** also carries `ReportExcludedPaths` (string?, JSON array of excluded path prefixes, column `report_excluded_paths`), `StandupWeekday` (int DayOfWeek, default Wednesday, column `standup_weekday`), and `DailyPrepMaxTasks` (int, default 5, column `daily_prep_max_tasks` — hard cap on how many open tasks the daily-prep / "Prime Claude" feature may place in MyDay)
|
||||||
- **SubtaskEntity**, **AppSettingsEntity**, **AgentInfo** — existing helpers / settings / record for scanned agent files
|
- **SubtaskEntity**, **AppSettingsEntity**, **AgentInfo** — existing helpers / settings / record for scanned agent files
|
||||||
|
|
||||||
## Repositories
|
## Repositories
|
||||||
|
|
||||||
All repositories use EF Core LINQ queries via `ClaudeDoDbContext`. Exception: `TaskRepository.GetNextQueuedAgentTaskAsync` uses `FromSqlRaw` for atomic queue claim.
|
All repositories use EF Core LINQ queries via `ClaudeDoDbContext`. The atomic `Queued -> Running` claim lives in the Worker's `QueuePicker` (uses `FromSqlRaw`), not here.
|
||||||
|
|
||||||
- **TaskRepository** — CRUD, status transitions (`MarkRunningAsync`, `MarkDoneAsync`, `MarkFailedAsync`), `GetNextQueuedAgentTaskAsync` (queue polling), `GetEffectiveTagsAsync` (union of task + list tags), `FlipAllRunningToFailedAsync`, `UpdateAgentSettingsAsync` (model / system-prompt / agent-path overrides)
|
- **TaskRepository** — CRUD, planning helpers (`CreateChildAsync`, `SetPlanningStartedAsync`, `DiscardPlanningAsync`, `TryCompleteParentAsync`, `UpdateChildAsync`), `UpdateAgentSettingsAsync` (model / system-prompt / agent-path overrides). Status-mutation primitives `MarkRunningAsync` / `MarkDoneAsync` / `MarkFailedAsync` / `FlipAllRunningToFailedAsync` are `internal` and called only by `TaskStateService` in the worker. `CreateChildAsync` produces children with `Status=Idle, PlanningPhase=None`; once their parent's `PlanningPhase` becomes `Finalized`, the chain coordinator queues them.
|
||||||
- **ListRepository** — CRUD, tag junction management, `GetConfigAsync` / `SetConfigAsync` (upsert) / `DeleteConfigAsync` for `list_config`
|
- **ListRepository** — CRUD, `GetConfigAsync` / `SetConfigAsync` (upsert) / `DeleteConfigAsync` for `list_config`
|
||||||
- **TagRepository** — `GetOrCreateAsync` (idempotent)
|
|
||||||
- **WorktreeRepository** — CRUD, `UpdateHeadAsync`, `SetStateAsync`
|
- **WorktreeRepository** — CRUD, `UpdateHeadAsync`, `SetStateAsync`
|
||||||
- **TaskRunRepository**, **SubtaskRepository**, **AppSettingsRepository**
|
- **TaskRunRepository**, **SubtaskRepository**, **AppSettingsRepository**
|
||||||
|
- **DailyNoteRepository** — `ListByDayAsync`, `ListBetweenAsync`, `AddAsync`, `UpdateAsync`, `DeleteAsync`
|
||||||
|
- **WeekReportRepository** — `GetByRangeAsync`, `UpsertAsync`
|
||||||
|
|
||||||
## Infrastructure
|
## Infrastructure
|
||||||
|
|
||||||
@@ -35,7 +39,7 @@ All repositories use EF Core LINQ queries via `ClaudeDoDbContext`. Exception: `T
|
|||||||
|
|
||||||
## Schema
|
## Schema
|
||||||
|
|
||||||
Tables: `lists`, `tasks`, `tags`, `list_tags`, `task_tags`, `worktrees`, `list_config`, `task_runs`, `subtasks`, `app_settings`. Managed by EF Core migrations in the `Migrations/` folder. Seed data: tags "agent" and "manual".
|
Tables: `lists`, `tasks`, `worktrees`, `list_config`, `task_runs`, `subtasks`, `app_settings`, `prime_schedules`, `daily_notes`, `week_reports`. Managed by EF Core migrations in the `Migrations/` folder. The `tasks` table holds `status`, `planning_phase` (default `none`), and `blocked_by_task_id` (FK to `tasks.id`, `ON DELETE SET NULL`). Migration `WeeklyReport` added `daily_notes`, `week_reports`, and the two new `app_settings` columns. Migration `DailyPrepMaxTasks` added the `daily_prep_max_tasks` column to `app_settings` (no new tables).
|
||||||
|
|
||||||
## Conventions
|
## Conventions
|
||||||
|
|
||||||
|
|||||||
@@ -14,4 +14,9 @@
|
|||||||
</PackageReference>
|
</PackageReference>
|
||||||
</ItemGroup>
|
</ItemGroup>
|
||||||
|
|
||||||
|
<ItemGroup>
|
||||||
|
<InternalsVisibleTo Include="ClaudeDo.Worker" />
|
||||||
|
<InternalsVisibleTo Include="ClaudeDo.Worker.Tests" />
|
||||||
|
</ItemGroup>
|
||||||
|
|
||||||
</Project>
|
</Project>
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ using ClaudeDo.Data.Seeding;
|
|||||||
using Microsoft.EntityFrameworkCore;
|
using Microsoft.EntityFrameworkCore;
|
||||||
using Microsoft.EntityFrameworkCore.Infrastructure;
|
using Microsoft.EntityFrameworkCore.Infrastructure;
|
||||||
using Microsoft.EntityFrameworkCore.Storage;
|
using Microsoft.EntityFrameworkCore.Storage;
|
||||||
|
using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
|
||||||
|
|
||||||
namespace ClaudeDo.Data;
|
namespace ClaudeDo.Data;
|
||||||
|
|
||||||
@@ -12,16 +13,33 @@ public class ClaudeDoDbContext : DbContext
|
|||||||
|
|
||||||
public DbSet<TaskEntity> Tasks => Set<TaskEntity>();
|
public DbSet<TaskEntity> Tasks => Set<TaskEntity>();
|
||||||
public DbSet<ListEntity> Lists => Set<ListEntity>();
|
public DbSet<ListEntity> Lists => Set<ListEntity>();
|
||||||
public DbSet<TagEntity> Tags => Set<TagEntity>();
|
|
||||||
public DbSet<ListConfigEntity> ListConfigs => Set<ListConfigEntity>();
|
public DbSet<ListConfigEntity> ListConfigs => Set<ListConfigEntity>();
|
||||||
public DbSet<WorktreeEntity> Worktrees => Set<WorktreeEntity>();
|
public DbSet<WorktreeEntity> Worktrees => Set<WorktreeEntity>();
|
||||||
public DbSet<TaskRunEntity> TaskRuns => Set<TaskRunEntity>();
|
public DbSet<TaskRunEntity> TaskRuns => Set<TaskRunEntity>();
|
||||||
public DbSet<SubtaskEntity> Subtasks => Set<SubtaskEntity>();
|
public DbSet<SubtaskEntity> Subtasks => Set<SubtaskEntity>();
|
||||||
public DbSet<AppSettingsEntity> AppSettings => Set<AppSettingsEntity>();
|
public DbSet<AppSettingsEntity> AppSettings => Set<AppSettingsEntity>();
|
||||||
|
public DbSet<PrimeScheduleEntity> PrimeSchedules => Set<PrimeScheduleEntity>();
|
||||||
|
public DbSet<DailyNoteEntity> DailyNotes => Set<DailyNoteEntity>();
|
||||||
|
public DbSet<WeekReportEntity> WeekReports => Set<WeekReportEntity>();
|
||||||
|
|
||||||
|
private static readonly ValueConverter<DateTime, DateTime> UtcConverter =
|
||||||
|
new(v => v, v => DateTime.SpecifyKind(v, DateTimeKind.Utc));
|
||||||
|
|
||||||
|
private static readonly ValueConverter<DateTime?, DateTime?> UtcNullableConverter =
|
||||||
|
new(v => v, v => v.HasValue ? DateTime.SpecifyKind(v.Value, DateTimeKind.Utc) : null);
|
||||||
|
|
||||||
protected override void OnModelCreating(ModelBuilder modelBuilder)
|
protected override void OnModelCreating(ModelBuilder modelBuilder)
|
||||||
{
|
{
|
||||||
modelBuilder.ApplyConfigurationsFromAssembly(typeof(ClaudeDoDbContext).Assembly);
|
modelBuilder.ApplyConfigurationsFromAssembly(typeof(ClaudeDoDbContext).Assembly);
|
||||||
|
|
||||||
|
foreach (var entityType in modelBuilder.Model.GetEntityTypes())
|
||||||
|
foreach (var property in entityType.GetProperties())
|
||||||
|
{
|
||||||
|
if (property.ClrType == typeof(DateTime) && property.GetValueConverter() == null)
|
||||||
|
property.SetValueConverter(UtcConverter);
|
||||||
|
else if (property.ClrType == typeof(DateTime?) && property.GetValueConverter() == null)
|
||||||
|
property.SetValueConverter(UtcNullableConverter);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// <summary>
|
/// <summary>
|
||||||
@@ -45,6 +63,13 @@ public class ClaudeDoDbContext : DbContext
|
|||||||
walCmd.ExecuteNonQuery();
|
walCmd.ExecuteNonQuery();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Enable FK enforcement — SQLite defaults to OFF per connection.
|
||||||
|
using (var fkCmd = conn.CreateCommand())
|
||||||
|
{
|
||||||
|
fkCmd.CommandText = "PRAGMA foreign_keys=ON;";
|
||||||
|
fkCmd.ExecuteNonQuery();
|
||||||
|
}
|
||||||
|
|
||||||
// If the 'lists' table exists but __EFMigrationsHistory does not,
|
// If the 'lists' table exists but __EFMigrationsHistory does not,
|
||||||
// this is a pre-EF database. Baseline the InitialCreate migration.
|
// this is a pre-EF database. Baseline the InitialCreate migration.
|
||||||
using (var cmd = conn.CreateCommand())
|
using (var cmd = conn.CreateCommand())
|
||||||
|
|||||||
@@ -22,6 +22,9 @@ public class AppSettingsEntityConfiguration : IEntityTypeConfiguration<AppSettin
|
|||||||
builder.Property(s => s.DefaultPermissionMode)
|
builder.Property(s => s.DefaultPermissionMode)
|
||||||
.HasColumnName("default_permission_mode").IsRequired().HasDefaultValue("bypassPermissions");
|
.HasColumnName("default_permission_mode").IsRequired().HasDefaultValue("bypassPermissions");
|
||||||
|
|
||||||
|
builder.Property(s => s.MaxParallelExecutions)
|
||||||
|
.HasColumnName("max_parallel_executions").IsRequired().HasDefaultValue(1);
|
||||||
|
|
||||||
builder.Property(s => s.WorktreeStrategy)
|
builder.Property(s => s.WorktreeStrategy)
|
||||||
.HasColumnName("worktree_strategy").IsRequired().HasDefaultValue("sibling");
|
.HasColumnName("worktree_strategy").IsRequired().HasDefaultValue("sibling");
|
||||||
builder.Property(s => s.CentralWorktreeRoot)
|
builder.Property(s => s.CentralWorktreeRoot)
|
||||||
@@ -31,6 +34,16 @@ public class AppSettingsEntityConfiguration : IEntityTypeConfiguration<AppSettin
|
|||||||
builder.Property(s => s.WorktreeAutoCleanupDays)
|
builder.Property(s => s.WorktreeAutoCleanupDays)
|
||||||
.HasColumnName("worktree_auto_cleanup_days").IsRequired().HasDefaultValue(7);
|
.HasColumnName("worktree_auto_cleanup_days").IsRequired().HasDefaultValue(7);
|
||||||
|
|
||||||
|
builder.Property(s => s.RepoImportFolders)
|
||||||
|
.HasColumnName("repo_import_folders");
|
||||||
|
|
||||||
|
builder.Property(s => s.ReportExcludedPaths).HasColumnName("report_excluded_paths");
|
||||||
|
builder.Property(s => s.StandupWeekday).HasColumnName("standup_weekday")
|
||||||
|
.IsRequired().HasDefaultValue((int)DayOfWeek.Wednesday);
|
||||||
|
|
||||||
|
builder.Property(s => s.DailyPrepMaxTasks)
|
||||||
|
.HasColumnName("daily_prep_max_tasks").IsRequired().HasDefaultValue(5);
|
||||||
|
|
||||||
builder.HasData(new AppSettingsEntity { Id = AppSettingsEntity.SingletonId });
|
builder.HasData(new AppSettingsEntity { Id = AppSettingsEntity.SingletonId });
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,20 @@
|
|||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using Microsoft.EntityFrameworkCore.Metadata.Builders;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Configuration;
|
||||||
|
|
||||||
|
public class DailyNoteEntityConfiguration : IEntityTypeConfiguration<DailyNoteEntity>
|
||||||
|
{
|
||||||
|
public void Configure(EntityTypeBuilder<DailyNoteEntity> builder)
|
||||||
|
{
|
||||||
|
builder.ToTable("daily_notes");
|
||||||
|
builder.HasKey(n => n.Id);
|
||||||
|
builder.Property(n => n.Id).HasColumnName("id").ValueGeneratedNever();
|
||||||
|
builder.Property(n => n.Date).HasColumnName("note_date").IsRequired();
|
||||||
|
builder.Property(n => n.Text).HasColumnName("text").IsRequired();
|
||||||
|
builder.Property(n => n.SortOrder).HasColumnName("sort_order").IsRequired();
|
||||||
|
builder.Property(n => n.CreatedAt).HasColumnName("created_at").IsRequired();
|
||||||
|
builder.HasIndex(n => n.Date);
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -15,5 +15,6 @@ public class ListConfigEntityConfiguration : IEntityTypeConfiguration<ListConfig
|
|||||||
builder.Property(c => c.Model).HasColumnName("model");
|
builder.Property(c => c.Model).HasColumnName("model");
|
||||||
builder.Property(c => c.SystemPrompt).HasColumnName("system_prompt");
|
builder.Property(c => c.SystemPrompt).HasColumnName("system_prompt");
|
||||||
builder.Property(c => c.AgentPath).HasColumnName("agent_path");
|
builder.Property(c => c.AgentPath).HasColumnName("agent_path");
|
||||||
|
builder.Property(c => c.MaxTurns).HasColumnName("max_turns");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -16,21 +16,13 @@ public class ListEntityConfiguration : IEntityTypeConfiguration<ListEntity>
|
|||||||
builder.Property(l => l.CreatedAt).HasColumnName("created_at").IsRequired();
|
builder.Property(l => l.CreatedAt).HasColumnName("created_at").IsRequired();
|
||||||
builder.Property(l => l.WorkingDir).HasColumnName("working_dir");
|
builder.Property(l => l.WorkingDir).HasColumnName("working_dir");
|
||||||
builder.Property(l => l.DefaultCommitType).HasColumnName("default_commit_type").IsRequired().HasDefaultValue("chore");
|
builder.Property(l => l.DefaultCommitType).HasColumnName("default_commit_type").IsRequired().HasDefaultValue("chore");
|
||||||
|
builder.Property(l => l.SortOrder).HasColumnName("sort_order").IsRequired().HasDefaultValue(0);
|
||||||
|
|
||||||
|
builder.HasIndex(l => l.SortOrder).HasDatabaseName("idx_lists_sort");
|
||||||
|
|
||||||
builder.HasOne(l => l.Config)
|
builder.HasOne(l => l.Config)
|
||||||
.WithOne(c => c.List)
|
.WithOne(c => c.List)
|
||||||
.HasForeignKey<ListConfigEntity>(c => c.ListId)
|
.HasForeignKey<ListConfigEntity>(c => c.ListId)
|
||||||
.OnDelete(DeleteBehavior.Cascade);
|
.OnDelete(DeleteBehavior.Cascade);
|
||||||
|
|
||||||
builder.HasMany(l => l.Tags)
|
|
||||||
.WithMany(tag => tag.Lists)
|
|
||||||
.UsingEntity("list_tags",
|
|
||||||
l => l.HasOne(typeof(TagEntity)).WithMany().HasForeignKey("tag_id").OnDelete(DeleteBehavior.Cascade),
|
|
||||||
r => r.HasOne(typeof(ListEntity)).WithMany().HasForeignKey("list_id").OnDelete(DeleteBehavior.Cascade),
|
|
||||||
j =>
|
|
||||||
{
|
|
||||||
j.HasKey("list_id", "tag_id");
|
|
||||||
j.ToTable("list_tags");
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,24 @@
|
|||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using Microsoft.EntityFrameworkCore.Metadata.Builders;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Configuration;
|
||||||
|
|
||||||
|
public class PrimeScheduleEntityConfiguration : IEntityTypeConfiguration<PrimeScheduleEntity>
|
||||||
|
{
|
||||||
|
public void Configure(EntityTypeBuilder<PrimeScheduleEntity> builder)
|
||||||
|
{
|
||||||
|
builder.ToTable("prime_schedules");
|
||||||
|
|
||||||
|
builder.HasKey(s => s.Id);
|
||||||
|
builder.Property(s => s.Id).HasColumnName("id").ValueGeneratedNever();
|
||||||
|
|
||||||
|
builder.Property(s => s.Days).HasColumnName("days_of_week")
|
||||||
|
.IsRequired().HasDefaultValue(PrimeDays.Weekdays);
|
||||||
|
builder.Property(s => s.TimeOfDay).HasColumnName("time_of_day").IsRequired();
|
||||||
|
builder.Property(s => s.Enabled).HasColumnName("enabled").IsRequired().HasDefaultValue(true);
|
||||||
|
builder.Property(s => s.LastRunAt).HasColumnName("last_run_at");
|
||||||
|
builder.Property(s => s.PromptOverride).HasColumnName("prompt_override");
|
||||||
|
builder.Property(s => s.CreatedAt).HasColumnName("created_at").IsRequired();
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,22 +0,0 @@
|
|||||||
using ClaudeDo.Data.Models;
|
|
||||||
using Microsoft.EntityFrameworkCore;
|
|
||||||
using Microsoft.EntityFrameworkCore.Metadata.Builders;
|
|
||||||
|
|
||||||
namespace ClaudeDo.Data.Configuration;
|
|
||||||
|
|
||||||
public class TagEntityConfiguration : IEntityTypeConfiguration<TagEntity>
|
|
||||||
{
|
|
||||||
public void Configure(EntityTypeBuilder<TagEntity> builder)
|
|
||||||
{
|
|
||||||
builder.ToTable("tags");
|
|
||||||
|
|
||||||
builder.HasKey(t => t.Id);
|
|
||||||
builder.Property(t => t.Id).HasColumnName("id").ValueGeneratedOnAdd();
|
|
||||||
builder.Property(t => t.Name).HasColumnName("name").IsRequired();
|
|
||||||
builder.HasIndex(t => t.Name).IsUnique();
|
|
||||||
|
|
||||||
builder.HasData(
|
|
||||||
new TagEntity { Id = 1, Name = "agent" },
|
|
||||||
new TagEntity { Id = 2, Name = "manual" });
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -9,24 +9,57 @@ namespace ClaudeDo.Data.Configuration;
|
|||||||
public class TaskEntityConfiguration : IEntityTypeConfiguration<TaskEntity>
|
public class TaskEntityConfiguration : IEntityTypeConfiguration<TaskEntity>
|
||||||
{
|
{
|
||||||
private static string StatusToString(TaskStatus v)
|
private static string StatusToString(TaskStatus v)
|
||||||
=> v == TaskStatus.Manual ? "manual"
|
=> v switch
|
||||||
: v == TaskStatus.Queued ? "queued"
|
{
|
||||||
: v == TaskStatus.Running ? "running"
|
TaskStatus.Idle => "idle",
|
||||||
: v == TaskStatus.Done ? "done"
|
TaskStatus.Queued => "queued",
|
||||||
: v == TaskStatus.Failed ? "failed"
|
TaskStatus.Running => "running",
|
||||||
: throw new ArgumentOutOfRangeException(nameof(v));
|
TaskStatus.WaitingForReview => "waiting_for_review",
|
||||||
|
TaskStatus.WaitingForChildren => "waiting_for_children",
|
||||||
|
TaskStatus.Done => "done",
|
||||||
|
TaskStatus.Failed => "failed",
|
||||||
|
TaskStatus.Cancelled => "cancelled",
|
||||||
|
_ => throw new ArgumentOutOfRangeException(nameof(v)),
|
||||||
|
};
|
||||||
|
|
||||||
private static TaskStatus StatusFromString(string v)
|
private static TaskStatus StatusFromString(string v)
|
||||||
=> v == "manual" ? TaskStatus.Manual
|
=> v switch
|
||||||
: v == "queued" ? TaskStatus.Queued
|
{
|
||||||
: v == "running" ? TaskStatus.Running
|
"idle" => TaskStatus.Idle,
|
||||||
: v == "done" ? TaskStatus.Done
|
"queued" => TaskStatus.Queued,
|
||||||
: v == "failed" ? TaskStatus.Failed
|
"running" => TaskStatus.Running,
|
||||||
: throw new ArgumentOutOfRangeException(nameof(v));
|
"waiting_for_review" => TaskStatus.WaitingForReview,
|
||||||
|
"waiting_for_children" => TaskStatus.WaitingForChildren,
|
||||||
|
"done" => TaskStatus.Done,
|
||||||
|
"failed" => TaskStatus.Failed,
|
||||||
|
"cancelled" => TaskStatus.Cancelled,
|
||||||
|
_ => throw new ArgumentOutOfRangeException(nameof(v)),
|
||||||
|
};
|
||||||
|
|
||||||
private static readonly ValueConverter<TaskStatus, string> StatusConverter =
|
private static readonly ValueConverter<TaskStatus, string> StatusConverter =
|
||||||
new(v => StatusToString(v), v => StatusFromString(v));
|
new(v => StatusToString(v), v => StatusFromString(v));
|
||||||
|
|
||||||
|
private static string PhaseToString(PlanningPhase v)
|
||||||
|
=> v switch
|
||||||
|
{
|
||||||
|
PlanningPhase.None => "none",
|
||||||
|
PlanningPhase.Active => "active",
|
||||||
|
PlanningPhase.Finalized => "finalized",
|
||||||
|
_ => throw new ArgumentOutOfRangeException(nameof(v)),
|
||||||
|
};
|
||||||
|
|
||||||
|
private static PlanningPhase PhaseFromString(string v)
|
||||||
|
=> v switch
|
||||||
|
{
|
||||||
|
"none" => PlanningPhase.None,
|
||||||
|
"active" => PlanningPhase.Active,
|
||||||
|
"finalized" => PlanningPhase.Finalized,
|
||||||
|
_ => throw new ArgumentOutOfRangeException(nameof(v)),
|
||||||
|
};
|
||||||
|
|
||||||
|
private static readonly ValueConverter<PlanningPhase, string> PhaseConverter =
|
||||||
|
new(v => PhaseToString(v), v => PhaseFromString(v));
|
||||||
|
|
||||||
public void Configure(EntityTypeBuilder<TaskEntity> builder)
|
public void Configure(EntityTypeBuilder<TaskEntity> builder)
|
||||||
{
|
{
|
||||||
builder.ToTable("tasks");
|
builder.ToTable("tasks");
|
||||||
@@ -38,8 +71,13 @@ public class TaskEntityConfiguration : IEntityTypeConfiguration<TaskEntity>
|
|||||||
builder.Property(t => t.Description).HasColumnName("description");
|
builder.Property(t => t.Description).HasColumnName("description");
|
||||||
builder.Property(t => t.Status).HasColumnName("status").IsRequired()
|
builder.Property(t => t.Status).HasColumnName("status").IsRequired()
|
||||||
.HasConversion(StatusConverter);
|
.HasConversion(StatusConverter);
|
||||||
|
builder.Property(t => t.PlanningPhase).HasColumnName("planning_phase").IsRequired()
|
||||||
|
.HasConversion(PhaseConverter).HasDefaultValue(PlanningPhase.None);
|
||||||
|
builder.Property(t => t.BlockedByTaskId).HasColumnName("blocked_by_task_id");
|
||||||
builder.Property(t => t.ScheduledFor).HasColumnName("scheduled_for");
|
builder.Property(t => t.ScheduledFor).HasColumnName("scheduled_for");
|
||||||
builder.Property(t => t.Result).HasColumnName("result");
|
builder.Property(t => t.Result).HasColumnName("result");
|
||||||
|
builder.Property(t => t.ReviewFeedback).HasColumnName("review_feedback");
|
||||||
|
builder.Property(t => t.RoadblockCount).HasColumnName("roadblock_count").HasDefaultValue(0);
|
||||||
builder.Property(t => t.LogPath).HasColumnName("log_path");
|
builder.Property(t => t.LogPath).HasColumnName("log_path");
|
||||||
builder.Property(t => t.CreatedAt).HasColumnName("created_at").IsRequired();
|
builder.Property(t => t.CreatedAt).HasColumnName("created_at").IsRequired();
|
||||||
builder.Property(t => t.StartedAt).HasColumnName("started_at");
|
builder.Property(t => t.StartedAt).HasColumnName("started_at");
|
||||||
@@ -48,11 +86,30 @@ public class TaskEntityConfiguration : IEntityTypeConfiguration<TaskEntity>
|
|||||||
builder.Property(t => t.Model).HasColumnName("model");
|
builder.Property(t => t.Model).HasColumnName("model");
|
||||||
builder.Property(t => t.SystemPrompt).HasColumnName("system_prompt");
|
builder.Property(t => t.SystemPrompt).HasColumnName("system_prompt");
|
||||||
builder.Property(t => t.AgentPath).HasColumnName("agent_path");
|
builder.Property(t => t.AgentPath).HasColumnName("agent_path");
|
||||||
|
builder.Property(t => t.MaxTurns).HasColumnName("max_turns");
|
||||||
builder.Property(t => t.IsStarred).HasColumnName("is_starred").HasDefaultValue(false);
|
builder.Property(t => t.IsStarred).HasColumnName("is_starred").HasDefaultValue(false);
|
||||||
builder.Property(t => t.IsMyDay).HasColumnName("is_my_day").HasDefaultValue(false);
|
builder.Property(t => t.IsMyDay).HasColumnName("is_my_day").HasDefaultValue(false);
|
||||||
builder.Property(t => t.Notes).HasColumnName("notes");
|
builder.Property(t => t.Notes).HasColumnName("notes");
|
||||||
builder.Property(t => t.SortOrder).HasColumnName("sort_order").IsRequired().HasDefaultValue(0);
|
builder.Property(t => t.SortOrder).HasColumnName("sort_order").IsRequired().HasDefaultValue(0);
|
||||||
|
|
||||||
|
builder.Property(t => t.ParentTaskId).HasColumnName("parent_task_id");
|
||||||
|
builder.Property(t => t.PlanningSessionId).HasColumnName("planning_session_id");
|
||||||
|
builder.Property(t => t.PlanningSessionToken).HasColumnName("planning_session_token");
|
||||||
|
builder.Property(t => t.PlanningFinalizedAt).HasColumnName("planning_finalized_at");
|
||||||
|
|
||||||
|
builder.Property(t => t.CreatedBy).HasColumnName("created_by");
|
||||||
|
|
||||||
|
builder.HasOne(t => t.Parent)
|
||||||
|
.WithMany(t => t.Children)
|
||||||
|
.HasForeignKey(t => t.ParentTaskId)
|
||||||
|
.OnDelete(DeleteBehavior.Restrict);
|
||||||
|
|
||||||
|
// BlockedBy: predecessor in a sequential chain. SetNull on delete so child becomes pickable.
|
||||||
|
builder.HasOne<TaskEntity>()
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey(t => t.BlockedByTaskId)
|
||||||
|
.OnDelete(DeleteBehavior.SetNull);
|
||||||
|
|
||||||
builder.HasOne(t => t.List)
|
builder.HasOne(t => t.List)
|
||||||
.WithMany(l => l.Tasks)
|
.WithMany(l => l.Tasks)
|
||||||
.HasForeignKey(t => t.ListId)
|
.HasForeignKey(t => t.ListId)
|
||||||
@@ -62,19 +119,10 @@ public class TaskEntityConfiguration : IEntityTypeConfiguration<TaskEntity>
|
|||||||
.WithOne(w => w.Task)
|
.WithOne(w => w.Task)
|
||||||
.HasForeignKey<WorktreeEntity>(w => w.TaskId);
|
.HasForeignKey<WorktreeEntity>(w => w.TaskId);
|
||||||
|
|
||||||
builder.HasMany(t => t.Tags)
|
|
||||||
.WithMany(tag => tag.Tasks)
|
|
||||||
.UsingEntity("task_tags",
|
|
||||||
l => l.HasOne(typeof(TagEntity)).WithMany().HasForeignKey("tag_id").OnDelete(DeleteBehavior.Cascade),
|
|
||||||
r => r.HasOne(typeof(TaskEntity)).WithMany().HasForeignKey("task_id").OnDelete(DeleteBehavior.Cascade),
|
|
||||||
j =>
|
|
||||||
{
|
|
||||||
j.HasKey("task_id", "tag_id");
|
|
||||||
j.ToTable("task_tags");
|
|
||||||
});
|
|
||||||
|
|
||||||
builder.HasIndex(t => t.ListId).HasDatabaseName("idx_tasks_list_id");
|
builder.HasIndex(t => t.ListId).HasDatabaseName("idx_tasks_list_id");
|
||||||
builder.HasIndex(t => t.Status).HasDatabaseName("idx_tasks_status");
|
builder.HasIndex(t => t.Status).HasDatabaseName("idx_tasks_status");
|
||||||
builder.HasIndex(t => new { t.ListId, t.SortOrder }).HasDatabaseName("idx_tasks_list_sort");
|
builder.HasIndex(t => new { t.ListId, t.SortOrder }).HasDatabaseName("idx_tasks_list_sort");
|
||||||
|
builder.HasIndex(t => t.ParentTaskId).HasDatabaseName("idx_tasks_parent_task_id");
|
||||||
|
builder.HasIndex(t => t.BlockedByTaskId).HasDatabaseName("idx_tasks_blocked_by");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,20 @@
|
|||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using Microsoft.EntityFrameworkCore.Metadata.Builders;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Configuration;
|
||||||
|
|
||||||
|
public class WeekReportEntityConfiguration : IEntityTypeConfiguration<WeekReportEntity>
|
||||||
|
{
|
||||||
|
public void Configure(EntityTypeBuilder<WeekReportEntity> builder)
|
||||||
|
{
|
||||||
|
builder.ToTable("week_reports");
|
||||||
|
builder.HasKey(r => r.Id);
|
||||||
|
builder.Property(r => r.Id).HasColumnName("id").ValueGeneratedNever();
|
||||||
|
builder.Property(r => r.StartDate).HasColumnName("start_date").IsRequired();
|
||||||
|
builder.Property(r => r.EndDate).HasColumnName("end_date").IsRequired();
|
||||||
|
builder.Property(r => r.Markdown).HasColumnName("markdown").IsRequired();
|
||||||
|
builder.Property(r => r.GeneratedAt).HasColumnName("generated_at").IsRequired();
|
||||||
|
builder.HasIndex(r => new { r.StartDate, r.EndDate }).IsUnique();
|
||||||
|
}
|
||||||
|
}
|
||||||
14
src/ClaudeDo.Data/Filtering/Filters/ReviewFilter.cs
Normal file
14
src/ClaudeDo.Data/Filtering/Filters/ReviewFilter.cs
Normal file
@@ -0,0 +1,14 @@
|
|||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Filtering.Filters;
|
||||||
|
|
||||||
|
public sealed class ReviewFilter : ITaskListFilter
|
||||||
|
{
|
||||||
|
public string Id => "virtual:review";
|
||||||
|
public bool Matches(TaskEntity t) =>
|
||||||
|
t.Status == TaskStatus.Done &&
|
||||||
|
t.Worktree is { State: WorktreeState.Active };
|
||||||
|
public bool ShouldCount(TaskEntity t) => Matches(t);
|
||||||
|
public bool MatchesAsContext(TaskEntity t, IReadOnlyList<TaskEntity> all) => false;
|
||||||
|
}
|
||||||
16
src/ClaudeDo.Data/Filtering/Filters/SmartFlagFilter.cs
Normal file
16
src/ClaudeDo.Data/Filtering/Filters/SmartFlagFilter.cs
Normal file
@@ -0,0 +1,16 @@
|
|||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Filtering.Filters;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Filter for a smart list keyed off a boolean/nullable task flag
|
||||||
|
/// (My Day, Important, Planned). Counts only non-done matches.
|
||||||
|
/// </summary>
|
||||||
|
public sealed class SmartFlagFilter(string id, Func<TaskEntity, bool> flag) : ITaskListFilter
|
||||||
|
{
|
||||||
|
public string Id => id;
|
||||||
|
public bool Matches(TaskEntity t) => flag(t);
|
||||||
|
public bool ShouldCount(TaskEntity t) => flag(t) && t.Status != TaskStatus.Done;
|
||||||
|
public bool MatchesAsContext(TaskEntity t, IReadOnlyList<TaskEntity> all) => false;
|
||||||
|
}
|
||||||
18
src/ClaudeDo.Data/Filtering/Filters/StatusFilter.cs
Normal file
18
src/ClaudeDo.Data/Filtering/Filters/StatusFilter.cs
Normal file
@@ -0,0 +1,18 @@
|
|||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Filtering.Filters;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Virtual list filter matching tasks by a single status (Queued, Running).
|
||||||
|
/// Planning parents appear contextually when they host a matching child.
|
||||||
|
/// </summary>
|
||||||
|
public sealed class StatusFilter(string id, TaskStatus status) : ITaskListFilter
|
||||||
|
{
|
||||||
|
public string Id => id;
|
||||||
|
public bool Matches(TaskEntity t) => t.Status == status;
|
||||||
|
public bool ShouldCount(TaskEntity t) => t.Status == status;
|
||||||
|
public bool MatchesAsContext(TaskEntity t, IReadOnlyList<TaskEntity> all) =>
|
||||||
|
PlanningRules.IsPlanningParent(t) &&
|
||||||
|
PlanningRules.HasMatchingChild(t, all, c => c.Status == status);
|
||||||
|
}
|
||||||
24
src/ClaudeDo.Data/Filtering/Filters/UserListFilter.cs
Normal file
24
src/ClaudeDo.Data/Filtering/Filters/UserListFilter.cs
Normal file
@@ -0,0 +1,24 @@
|
|||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Filtering.Filters;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Filter for any user-defined list. Constructed on demand from the list id —
|
||||||
|
/// one instance per list.
|
||||||
|
/// </summary>
|
||||||
|
public sealed class UserListFilter : ITaskListFilter
|
||||||
|
{
|
||||||
|
private readonly string _listId;
|
||||||
|
|
||||||
|
public UserListFilter(string listId)
|
||||||
|
{
|
||||||
|
_listId = listId;
|
||||||
|
Id = $"user:{listId}";
|
||||||
|
}
|
||||||
|
|
||||||
|
public string Id { get; }
|
||||||
|
public bool Matches(TaskEntity t) => t.ListId == _listId;
|
||||||
|
public bool ShouldCount(TaskEntity t) => t.ListId == _listId && t.Status != TaskStatus.Done;
|
||||||
|
public bool MatchesAsContext(TaskEntity t, IReadOnlyList<TaskEntity> all) => false;
|
||||||
|
}
|
||||||
26
src/ClaudeDo.Data/Filtering/Interfaces/ITaskListFilter.cs
Normal file
26
src/ClaudeDo.Data/Filtering/Interfaces/ITaskListFilter.cs
Normal file
@@ -0,0 +1,26 @@
|
|||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Filtering;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Strategy that defines which tasks belong to a single list. One implementation
|
||||||
|
/// per list kind; consumers (counters, list loader) ask the registry for the
|
||||||
|
/// right strategy and never branch on the list id themselves.
|
||||||
|
/// </summary>
|
||||||
|
public interface ITaskListFilter
|
||||||
|
{
|
||||||
|
/// <summary>The list id this filter applies to (e.g. "virtual:queued", "user:abc").</summary>
|
||||||
|
string Id { get; }
|
||||||
|
|
||||||
|
/// <summary>True if <paramref name="t"/> is a primary citizen of this list — appears as a row.</summary>
|
||||||
|
bool Matches(TaskEntity t);
|
||||||
|
|
||||||
|
/// <summary>True if <paramref name="t"/> should be counted in this list's badge.</summary>
|
||||||
|
bool ShouldCount(TaskEntity t);
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// True if <paramref name="t"/> is shown as a contextual row (not a primary citizen,
|
||||||
|
/// but appears to host children that match). Default: nothing extra.
|
||||||
|
/// </summary>
|
||||||
|
bool MatchesAsContext(TaskEntity t, IReadOnlyList<TaskEntity> all) => false;
|
||||||
|
}
|
||||||
27
src/ClaudeDo.Data/Filtering/PlanningRules.cs
Normal file
27
src/ClaudeDo.Data/Filtering/PlanningRules.cs
Normal file
@@ -0,0 +1,27 @@
|
|||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Filtering;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Shared predicates that capture planning-hierarchy semantics. Any new rule
|
||||||
|
/// involving parents, children, or planning phases belongs here.
|
||||||
|
/// </summary>
|
||||||
|
public static class PlanningRules
|
||||||
|
{
|
||||||
|
public static bool IsPlanningParent(TaskEntity t) =>
|
||||||
|
t.PlanningPhase != PlanningPhase.None;
|
||||||
|
|
||||||
|
public static bool HasMatchingChild(
|
||||||
|
TaskEntity parent,
|
||||||
|
IReadOnlyList<TaskEntity> all,
|
||||||
|
Func<TaskEntity, bool> childPredicate)
|
||||||
|
{
|
||||||
|
for (var i = 0; i < all.Count; i++)
|
||||||
|
{
|
||||||
|
var c = all[i];
|
||||||
|
if (c.ParentTaskId == parent.Id && childPredicate(c))
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
39
src/ClaudeDo.Data/Filtering/TaskListFilterRegistry.cs
Normal file
39
src/ClaudeDo.Data/Filtering/TaskListFilterRegistry.cs
Normal file
@@ -0,0 +1,39 @@
|
|||||||
|
using ClaudeDo.Data.Filtering.Filters;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Filtering;
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Resolves a list id (e.g. "virtual:queued", "user:abc") to the filter that
|
||||||
|
/// owns its semantics. Smart and virtual filters are singletons; user-list
|
||||||
|
/// filters are constructed on demand from the id.
|
||||||
|
/// </summary>
|
||||||
|
public sealed class TaskListFilterRegistry
|
||||||
|
{
|
||||||
|
public const string UserListPrefix = "user:";
|
||||||
|
|
||||||
|
private static readonly IReadOnlyDictionary<string, ITaskListFilter> BuiltIn =
|
||||||
|
new Dictionary<string, ITaskListFilter>(StringComparer.Ordinal)
|
||||||
|
{
|
||||||
|
["smart:my-day"] = new SmartFlagFilter("smart:my-day", t => t.IsMyDay),
|
||||||
|
["smart:important"] = new SmartFlagFilter("smart:important", t => t.IsStarred),
|
||||||
|
["smart:planned"] = new SmartFlagFilter("smart:planned", t => t.ScheduledFor != null),
|
||||||
|
["virtual:queued"] = new StatusFilter("virtual:queued", TaskStatus.Queued),
|
||||||
|
["virtual:running"] = new StatusFilter("virtual:running", TaskStatus.Running),
|
||||||
|
["virtual:review"] = new ReviewFilter(),
|
||||||
|
};
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Resolve a filter for a list id, or null if the id is unknown.
|
||||||
|
/// </summary>
|
||||||
|
public ITaskListFilter? Resolve(string listId)
|
||||||
|
{
|
||||||
|
if (BuiltIn.TryGetValue(listId, out var f)) return f;
|
||||||
|
if (listId.StartsWith(UserListPrefix, StringComparison.Ordinal))
|
||||||
|
{
|
||||||
|
var inner = listId[UserListPrefix.Length..];
|
||||||
|
return string.IsNullOrEmpty(inner) ? null : new UserListFilter(inner);
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -35,6 +35,15 @@ public sealed class GitService
|
|||||||
return stdout;
|
return stdout;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public async Task<string> GetCommittedFilesAsync(string worktreePath, string baseCommit, CancellationToken ct = default)
|
||||||
|
{
|
||||||
|
var (exitCode, stdout, stderr) = await RunGitAsync(worktreePath,
|
||||||
|
["diff", "--name-status", $"{baseCommit}..HEAD"], ct);
|
||||||
|
if (exitCode != 0)
|
||||||
|
throw new InvalidOperationException($"git diff --name-status failed (exit {exitCode}): {stderr}");
|
||||||
|
return stdout;
|
||||||
|
}
|
||||||
|
|
||||||
public async Task<bool> HasChangesAsync(string worktreePath, CancellationToken ct = default)
|
public async Task<bool> HasChangesAsync(string worktreePath, CancellationToken ct = default)
|
||||||
{
|
{
|
||||||
var (exitCode, stdout, stderr) = await RunGitAsync(worktreePath, ["status", "--porcelain"], ct);
|
var (exitCode, stdout, stderr) = await RunGitAsync(worktreePath, ["status", "--porcelain"], ct);
|
||||||
@@ -97,6 +106,15 @@ public sealed class GitService
|
|||||||
return stdout.Trim();
|
return stdout.Trim();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
public async Task<string> GetFileDiffAsync(string worktreePath, string? baseCommit, string relativePath, CancellationToken ct = default)
|
||||||
|
{
|
||||||
|
string[] args = string.IsNullOrEmpty(baseCommit)
|
||||||
|
? ["diff", "--", relativePath]
|
||||||
|
: ["diff", $"{baseCommit}..HEAD", "--", relativePath];
|
||||||
|
var (_, stdout, _) = await RunGitAsync(worktreePath, args, ct);
|
||||||
|
return stdout;
|
||||||
|
}
|
||||||
|
|
||||||
public async Task WorktreeRemoveAsync(string repoDir, string worktreePath, bool force = false, CancellationToken ct = default)
|
public async Task WorktreeRemoveAsync(string repoDir, string worktreePath, bool force = false, CancellationToken ct = default)
|
||||||
{
|
{
|
||||||
var args = new List<string> { "worktree", "remove" };
|
var args = new List<string> { "worktree", "remove" };
|
||||||
|
|||||||
482
src/ClaudeDo.Data/Migrations/20260416064948_InitialCreate.Designer.cs
generated
Normal file
482
src/ClaudeDo.Data/Migrations/20260416064948_InitialCreate.Designer.cs
generated
Normal file
@@ -0,0 +1,482 @@
|
|||||||
|
// <auto-generated />
|
||||||
|
using System;
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using Microsoft.EntityFrameworkCore.Infrastructure;
|
||||||
|
using Microsoft.EntityFrameworkCore.Migrations;
|
||||||
|
using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
|
||||||
|
|
||||||
|
#nullable disable
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Migrations
|
||||||
|
{
|
||||||
|
[DbContext(typeof(ClaudeDoDbContext))]
|
||||||
|
[Migration("20260416064948_InitialCreate")]
|
||||||
|
partial class InitialCreate
|
||||||
|
{
|
||||||
|
/// <inheritdoc />
|
||||||
|
protected override void BuildTargetModel(ModelBuilder modelBuilder)
|
||||||
|
{
|
||||||
|
#pragma warning disable 612, 618
|
||||||
|
modelBuilder.HasAnnotation("ProductVersion", "8.0.11");
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListConfigEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("ListId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("list_id");
|
||||||
|
|
||||||
|
b.Property<string>("AgentPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("agent_path");
|
||||||
|
|
||||||
|
b.Property<string>("Model")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("model");
|
||||||
|
|
||||||
|
b.Property<string>("SystemPrompt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("system_prompt");
|
||||||
|
|
||||||
|
b.HasKey("ListId");
|
||||||
|
|
||||||
|
b.ToTable("list_config", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultCommitType")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("chore")
|
||||||
|
.HasColumnName("default_commit_type");
|
||||||
|
|
||||||
|
b.Property<string>("Name")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("name");
|
||||||
|
|
||||||
|
b.Property<string>("WorkingDir")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("working_dir");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.ToTable("lists", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.SubtaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<bool>("Completed")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("completed");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<int>("OrderNum")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("order_num");
|
||||||
|
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<string>("Title")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("title");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("TaskId")
|
||||||
|
.HasDatabaseName("idx_subtasks_task_id");
|
||||||
|
|
||||||
|
b.ToTable("subtasks", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TagEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<long>("Id")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("Name")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("name");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("Name")
|
||||||
|
.IsUnique();
|
||||||
|
|
||||||
|
b.ToTable("tags", (string)null);
|
||||||
|
|
||||||
|
b.HasData(
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 1L,
|
||||||
|
Name = "agent"
|
||||||
|
},
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 2L,
|
||||||
|
Name = "manual"
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("AgentPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("agent_path");
|
||||||
|
|
||||||
|
b.Property<string>("CommitType")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("chore")
|
||||||
|
.HasColumnName("commit_type");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("Description")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("description");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("FinishedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("finished_at");
|
||||||
|
|
||||||
|
b.Property<string>("ListId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("list_id");
|
||||||
|
|
||||||
|
b.Property<string>("LogPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("log_path");
|
||||||
|
|
||||||
|
b.Property<string>("Model")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("model");
|
||||||
|
|
||||||
|
b.Property<string>("Result")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("result");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("ScheduledFor")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("scheduled_for");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("StartedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("started_at");
|
||||||
|
|
||||||
|
b.Property<string>("Status")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("status");
|
||||||
|
|
||||||
|
b.Property<string>("SystemPrompt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("system_prompt");
|
||||||
|
|
||||||
|
b.Property<string>("Title")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("title");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("ListId")
|
||||||
|
.HasDatabaseName("idx_tasks_list_id");
|
||||||
|
|
||||||
|
b.HasIndex("Status")
|
||||||
|
.HasDatabaseName("idx_tasks_status");
|
||||||
|
|
||||||
|
b.ToTable("tasks", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskRunEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("ErrorMarkdown")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("error_markdown");
|
||||||
|
|
||||||
|
b.Property<int?>("ExitCode")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("exit_code");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("FinishedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("finished_at");
|
||||||
|
|
||||||
|
b.Property<bool>("IsRetry")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_retry");
|
||||||
|
|
||||||
|
b.Property<string>("LogPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("log_path");
|
||||||
|
|
||||||
|
b.Property<string>("Prompt")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("prompt");
|
||||||
|
|
||||||
|
b.Property<string>("ResultMarkdown")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("result_markdown");
|
||||||
|
|
||||||
|
b.Property<int>("RunNumber")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("run_number");
|
||||||
|
|
||||||
|
b.Property<string>("SessionId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("session_id");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("StartedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("started_at");
|
||||||
|
|
||||||
|
b.Property<string>("StructuredOutputJson")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("structured_output");
|
||||||
|
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<int?>("TokensIn")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("tokens_in");
|
||||||
|
|
||||||
|
b.Property<int?>("TokensOut")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("tokens_out");
|
||||||
|
|
||||||
|
b.Property<int?>("TurnCount")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("turn_count");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("TaskId")
|
||||||
|
.HasDatabaseName("idx_task_runs_task_id");
|
||||||
|
|
||||||
|
b.ToTable("task_runs", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.WorktreeEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<string>("BaseCommit")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("base_commit");
|
||||||
|
|
||||||
|
b.Property<string>("BranchName")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("branch_name");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("DiffStat")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("diff_stat");
|
||||||
|
|
||||||
|
b.Property<string>("HeadCommit")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("head_commit");
|
||||||
|
|
||||||
|
b.Property<string>("Path")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("path");
|
||||||
|
|
||||||
|
b.Property<string>("State")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("active")
|
||||||
|
.HasColumnName("state");
|
||||||
|
|
||||||
|
b.HasKey("TaskId");
|
||||||
|
|
||||||
|
b.ToTable("worktrees", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("list_tags", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("list_id")
|
||||||
|
.HasColumnType("TEXT");
|
||||||
|
|
||||||
|
b.Property<long>("tag_id")
|
||||||
|
.HasColumnType("INTEGER");
|
||||||
|
|
||||||
|
b.HasKey("list_id", "tag_id");
|
||||||
|
|
||||||
|
b.HasIndex("tag_id");
|
||||||
|
|
||||||
|
b.ToTable("list_tags", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("task_tags", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("task_id")
|
||||||
|
.HasColumnType("TEXT");
|
||||||
|
|
||||||
|
b.Property<long>("tag_id")
|
||||||
|
.HasColumnType("INTEGER");
|
||||||
|
|
||||||
|
b.HasKey("task_id", "tag_id");
|
||||||
|
|
||||||
|
b.HasIndex("tag_id");
|
||||||
|
|
||||||
|
b.ToTable("task_tags", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListConfigEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", "List")
|
||||||
|
.WithOne("Config")
|
||||||
|
.HasForeignKey("ClaudeDo.Data.Models.ListConfigEntity", "ListId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("List");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.SubtaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithMany("Subtasks")
|
||||||
|
.HasForeignKey("TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", "List")
|
||||||
|
.WithMany("Tasks")
|
||||||
|
.HasForeignKey("ListId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("List");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskRunEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithMany("Runs")
|
||||||
|
.HasForeignKey("TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.WorktreeEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithOne("Worktree")
|
||||||
|
.HasForeignKey("ClaudeDo.Data.Models.WorktreeEntity", "TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("list_tags", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("list_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TagEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("tag_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("task_tags", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TagEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("tag_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("task_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListEntity", b =>
|
||||||
|
{
|
||||||
|
b.Navigation("Config");
|
||||||
|
|
||||||
|
b.Navigation("Tasks");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Navigation("Runs");
|
||||||
|
|
||||||
|
b.Navigation("Subtasks");
|
||||||
|
|
||||||
|
b.Navigation("Worktree");
|
||||||
|
});
|
||||||
|
#pragma warning restore 612, 618
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
498
src/ClaudeDo.Data/Migrations/20260420075929_AddTaskFlagsAndNotes.Designer.cs
generated
Normal file
498
src/ClaudeDo.Data/Migrations/20260420075929_AddTaskFlagsAndNotes.Designer.cs
generated
Normal file
@@ -0,0 +1,498 @@
|
|||||||
|
// <auto-generated />
|
||||||
|
using System;
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using Microsoft.EntityFrameworkCore.Infrastructure;
|
||||||
|
using Microsoft.EntityFrameworkCore.Migrations;
|
||||||
|
using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
|
||||||
|
|
||||||
|
#nullable disable
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Migrations
|
||||||
|
{
|
||||||
|
[DbContext(typeof(ClaudeDoDbContext))]
|
||||||
|
[Migration("20260420075929_AddTaskFlagsAndNotes")]
|
||||||
|
partial class AddTaskFlagsAndNotes
|
||||||
|
{
|
||||||
|
/// <inheritdoc />
|
||||||
|
protected override void BuildTargetModel(ModelBuilder modelBuilder)
|
||||||
|
{
|
||||||
|
#pragma warning disable 612, 618
|
||||||
|
modelBuilder.HasAnnotation("ProductVersion", "8.0.11");
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListConfigEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("ListId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("list_id");
|
||||||
|
|
||||||
|
b.Property<string>("AgentPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("agent_path");
|
||||||
|
|
||||||
|
b.Property<string>("Model")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("model");
|
||||||
|
|
||||||
|
b.Property<string>("SystemPrompt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("system_prompt");
|
||||||
|
|
||||||
|
b.HasKey("ListId");
|
||||||
|
|
||||||
|
b.ToTable("list_config", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultCommitType")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("chore")
|
||||||
|
.HasColumnName("default_commit_type");
|
||||||
|
|
||||||
|
b.Property<string>("Name")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("name");
|
||||||
|
|
||||||
|
b.Property<string>("WorkingDir")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("working_dir");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.ToTable("lists", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.SubtaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<bool>("Completed")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("completed");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<int>("OrderNum")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("order_num");
|
||||||
|
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<string>("Title")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("title");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("TaskId")
|
||||||
|
.HasDatabaseName("idx_subtasks_task_id");
|
||||||
|
|
||||||
|
b.ToTable("subtasks", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TagEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<long>("Id")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("Name")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("name");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("Name")
|
||||||
|
.IsUnique();
|
||||||
|
|
||||||
|
b.ToTable("tags", (string)null);
|
||||||
|
|
||||||
|
b.HasData(
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 1L,
|
||||||
|
Name = "agent"
|
||||||
|
},
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 2L,
|
||||||
|
Name = "manual"
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("AgentPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("agent_path");
|
||||||
|
|
||||||
|
b.Property<string>("CommitType")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("chore")
|
||||||
|
.HasColumnName("commit_type");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("Description")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("description");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("FinishedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("finished_at");
|
||||||
|
|
||||||
|
b.Property<bool>("IsMyDay")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_my_day");
|
||||||
|
|
||||||
|
b.Property<bool>("IsStarred")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_starred");
|
||||||
|
|
||||||
|
b.Property<string>("ListId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("list_id");
|
||||||
|
|
||||||
|
b.Property<string>("LogPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("log_path");
|
||||||
|
|
||||||
|
b.Property<string>("Model")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("model");
|
||||||
|
|
||||||
|
b.Property<string>("Notes")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("notes");
|
||||||
|
|
||||||
|
b.Property<string>("Result")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("result");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("ScheduledFor")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("scheduled_for");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("StartedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("started_at");
|
||||||
|
|
||||||
|
b.Property<string>("Status")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("status");
|
||||||
|
|
||||||
|
b.Property<string>("SystemPrompt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("system_prompt");
|
||||||
|
|
||||||
|
b.Property<string>("Title")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("title");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("ListId")
|
||||||
|
.HasDatabaseName("idx_tasks_list_id");
|
||||||
|
|
||||||
|
b.HasIndex("Status")
|
||||||
|
.HasDatabaseName("idx_tasks_status");
|
||||||
|
|
||||||
|
b.ToTable("tasks", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskRunEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("ErrorMarkdown")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("error_markdown");
|
||||||
|
|
||||||
|
b.Property<int?>("ExitCode")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("exit_code");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("FinishedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("finished_at");
|
||||||
|
|
||||||
|
b.Property<bool>("IsRetry")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_retry");
|
||||||
|
|
||||||
|
b.Property<string>("LogPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("log_path");
|
||||||
|
|
||||||
|
b.Property<string>("Prompt")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("prompt");
|
||||||
|
|
||||||
|
b.Property<string>("ResultMarkdown")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("result_markdown");
|
||||||
|
|
||||||
|
b.Property<int>("RunNumber")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("run_number");
|
||||||
|
|
||||||
|
b.Property<string>("SessionId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("session_id");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("StartedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("started_at");
|
||||||
|
|
||||||
|
b.Property<string>("StructuredOutputJson")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("structured_output");
|
||||||
|
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<int?>("TokensIn")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("tokens_in");
|
||||||
|
|
||||||
|
b.Property<int?>("TokensOut")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("tokens_out");
|
||||||
|
|
||||||
|
b.Property<int?>("TurnCount")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("turn_count");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("TaskId")
|
||||||
|
.HasDatabaseName("idx_task_runs_task_id");
|
||||||
|
|
||||||
|
b.ToTable("task_runs", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.WorktreeEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<string>("BaseCommit")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("base_commit");
|
||||||
|
|
||||||
|
b.Property<string>("BranchName")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("branch_name");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("DiffStat")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("diff_stat");
|
||||||
|
|
||||||
|
b.Property<string>("HeadCommit")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("head_commit");
|
||||||
|
|
||||||
|
b.Property<string>("Path")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("path");
|
||||||
|
|
||||||
|
b.Property<string>("State")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("active")
|
||||||
|
.HasColumnName("state");
|
||||||
|
|
||||||
|
b.HasKey("TaskId");
|
||||||
|
|
||||||
|
b.ToTable("worktrees", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("list_tags", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("list_id")
|
||||||
|
.HasColumnType("TEXT");
|
||||||
|
|
||||||
|
b.Property<long>("tag_id")
|
||||||
|
.HasColumnType("INTEGER");
|
||||||
|
|
||||||
|
b.HasKey("list_id", "tag_id");
|
||||||
|
|
||||||
|
b.HasIndex("tag_id");
|
||||||
|
|
||||||
|
b.ToTable("list_tags", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("task_tags", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("task_id")
|
||||||
|
.HasColumnType("TEXT");
|
||||||
|
|
||||||
|
b.Property<long>("tag_id")
|
||||||
|
.HasColumnType("INTEGER");
|
||||||
|
|
||||||
|
b.HasKey("task_id", "tag_id");
|
||||||
|
|
||||||
|
b.HasIndex("tag_id");
|
||||||
|
|
||||||
|
b.ToTable("task_tags", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListConfigEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", "List")
|
||||||
|
.WithOne("Config")
|
||||||
|
.HasForeignKey("ClaudeDo.Data.Models.ListConfigEntity", "ListId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("List");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.SubtaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithMany("Subtasks")
|
||||||
|
.HasForeignKey("TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", "List")
|
||||||
|
.WithMany("Tasks")
|
||||||
|
.HasForeignKey("ListId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("List");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskRunEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithMany("Runs")
|
||||||
|
.HasForeignKey("TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.WorktreeEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithOne("Worktree")
|
||||||
|
.HasForeignKey("ClaudeDo.Data.Models.WorktreeEntity", "TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("list_tags", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("list_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TagEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("tag_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("task_tags", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TagEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("tag_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("task_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListEntity", b =>
|
||||||
|
{
|
||||||
|
b.Navigation("Config");
|
||||||
|
|
||||||
|
b.Navigation("Tasks");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Navigation("Runs");
|
||||||
|
|
||||||
|
b.Navigation("Subtasks");
|
||||||
|
|
||||||
|
b.Navigation("Worktree");
|
||||||
|
});
|
||||||
|
#pragma warning restore 612, 618
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,4 +1,4 @@
|
|||||||
using Microsoft.EntityFrameworkCore.Migrations;
|
using Microsoft.EntityFrameworkCore.Migrations;
|
||||||
|
|
||||||
#nullable disable
|
#nullable disable
|
||||||
|
|
||||||
|
|||||||
572
src/ClaudeDo.Data/Migrations/20260421113614_AddAppSettings.Designer.cs
generated
Normal file
572
src/ClaudeDo.Data/Migrations/20260421113614_AddAppSettings.Designer.cs
generated
Normal file
@@ -0,0 +1,572 @@
|
|||||||
|
// <auto-generated />
|
||||||
|
using System;
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using Microsoft.EntityFrameworkCore.Infrastructure;
|
||||||
|
using Microsoft.EntityFrameworkCore.Migrations;
|
||||||
|
using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
|
||||||
|
|
||||||
|
#nullable disable
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Migrations
|
||||||
|
{
|
||||||
|
[DbContext(typeof(ClaudeDoDbContext))]
|
||||||
|
[Migration("20260421113614_AddAppSettings")]
|
||||||
|
partial class AddAppSettings
|
||||||
|
{
|
||||||
|
/// <inheritdoc />
|
||||||
|
protected override void BuildTargetModel(ModelBuilder modelBuilder)
|
||||||
|
{
|
||||||
|
#pragma warning disable 612, 618
|
||||||
|
modelBuilder.HasAnnotation("ProductVersion", "8.0.11");
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.AppSettingsEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<int>("Id")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("CentralWorktreeRoot")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("central_worktree_root");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultClaudeInstructions")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("")
|
||||||
|
.HasColumnName("default_claude_instructions");
|
||||||
|
|
||||||
|
b.Property<int>("DefaultMaxTurns")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(30)
|
||||||
|
.HasColumnName("default_max_turns");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultModel")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("sonnet")
|
||||||
|
.HasColumnName("default_model");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultPermissionMode")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("bypassPermissions")
|
||||||
|
.HasColumnName("default_permission_mode");
|
||||||
|
|
||||||
|
b.Property<int>("WorktreeAutoCleanupDays")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(7)
|
||||||
|
.HasColumnName("worktree_auto_cleanup_days");
|
||||||
|
|
||||||
|
b.Property<bool>("WorktreeAutoCleanupEnabled")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("worktree_auto_cleanup_enabled");
|
||||||
|
|
||||||
|
b.Property<string>("WorktreeStrategy")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("sibling")
|
||||||
|
.HasColumnName("worktree_strategy");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.ToTable("app_settings", (string)null);
|
||||||
|
|
||||||
|
b.HasData(
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 1,
|
||||||
|
DefaultClaudeInstructions = "",
|
||||||
|
DefaultMaxTurns = 30,
|
||||||
|
DefaultModel = "sonnet",
|
||||||
|
DefaultPermissionMode = "bypassPermissions",
|
||||||
|
WorktreeAutoCleanupDays = 7,
|
||||||
|
WorktreeAutoCleanupEnabled = false,
|
||||||
|
WorktreeStrategy = "sibling"
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListConfigEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("ListId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("list_id");
|
||||||
|
|
||||||
|
b.Property<string>("AgentPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("agent_path");
|
||||||
|
|
||||||
|
b.Property<string>("Model")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("model");
|
||||||
|
|
||||||
|
b.Property<string>("SystemPrompt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("system_prompt");
|
||||||
|
|
||||||
|
b.HasKey("ListId");
|
||||||
|
|
||||||
|
b.ToTable("list_config", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultCommitType")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("chore")
|
||||||
|
.HasColumnName("default_commit_type");
|
||||||
|
|
||||||
|
b.Property<string>("Name")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("name");
|
||||||
|
|
||||||
|
b.Property<string>("WorkingDir")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("working_dir");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.ToTable("lists", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.SubtaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<bool>("Completed")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("completed");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<int>("OrderNum")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("order_num");
|
||||||
|
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<string>("Title")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("title");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("TaskId")
|
||||||
|
.HasDatabaseName("idx_subtasks_task_id");
|
||||||
|
|
||||||
|
b.ToTable("subtasks", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TagEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<long>("Id")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("Name")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("name");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("Name")
|
||||||
|
.IsUnique();
|
||||||
|
|
||||||
|
b.ToTable("tags", (string)null);
|
||||||
|
|
||||||
|
b.HasData(
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 1L,
|
||||||
|
Name = "agent"
|
||||||
|
},
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 2L,
|
||||||
|
Name = "manual"
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("AgentPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("agent_path");
|
||||||
|
|
||||||
|
b.Property<string>("CommitType")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("chore")
|
||||||
|
.HasColumnName("commit_type");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("Description")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("description");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("FinishedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("finished_at");
|
||||||
|
|
||||||
|
b.Property<bool>("IsMyDay")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_my_day");
|
||||||
|
|
||||||
|
b.Property<bool>("IsStarred")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_starred");
|
||||||
|
|
||||||
|
b.Property<string>("ListId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("list_id");
|
||||||
|
|
||||||
|
b.Property<string>("LogPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("log_path");
|
||||||
|
|
||||||
|
b.Property<string>("Model")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("model");
|
||||||
|
|
||||||
|
b.Property<string>("Notes")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("notes");
|
||||||
|
|
||||||
|
b.Property<string>("Result")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("result");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("ScheduledFor")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("scheduled_for");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("StartedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("started_at");
|
||||||
|
|
||||||
|
b.Property<string>("Status")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("status");
|
||||||
|
|
||||||
|
b.Property<string>("SystemPrompt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("system_prompt");
|
||||||
|
|
||||||
|
b.Property<string>("Title")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("title");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("ListId")
|
||||||
|
.HasDatabaseName("idx_tasks_list_id");
|
||||||
|
|
||||||
|
b.HasIndex("Status")
|
||||||
|
.HasDatabaseName("idx_tasks_status");
|
||||||
|
|
||||||
|
b.ToTable("tasks", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskRunEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("ErrorMarkdown")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("error_markdown");
|
||||||
|
|
||||||
|
b.Property<int?>("ExitCode")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("exit_code");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("FinishedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("finished_at");
|
||||||
|
|
||||||
|
b.Property<bool>("IsRetry")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_retry");
|
||||||
|
|
||||||
|
b.Property<string>("LogPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("log_path");
|
||||||
|
|
||||||
|
b.Property<string>("Prompt")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("prompt");
|
||||||
|
|
||||||
|
b.Property<string>("ResultMarkdown")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("result_markdown");
|
||||||
|
|
||||||
|
b.Property<int>("RunNumber")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("run_number");
|
||||||
|
|
||||||
|
b.Property<string>("SessionId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("session_id");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("StartedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("started_at");
|
||||||
|
|
||||||
|
b.Property<string>("StructuredOutputJson")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("structured_output");
|
||||||
|
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<int?>("TokensIn")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("tokens_in");
|
||||||
|
|
||||||
|
b.Property<int?>("TokensOut")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("tokens_out");
|
||||||
|
|
||||||
|
b.Property<int?>("TurnCount")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("turn_count");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("TaskId")
|
||||||
|
.HasDatabaseName("idx_task_runs_task_id");
|
||||||
|
|
||||||
|
b.ToTable("task_runs", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.WorktreeEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<string>("BaseCommit")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("base_commit");
|
||||||
|
|
||||||
|
b.Property<string>("BranchName")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("branch_name");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("DiffStat")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("diff_stat");
|
||||||
|
|
||||||
|
b.Property<string>("HeadCommit")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("head_commit");
|
||||||
|
|
||||||
|
b.Property<string>("Path")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("path");
|
||||||
|
|
||||||
|
b.Property<string>("State")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("active")
|
||||||
|
.HasColumnName("state");
|
||||||
|
|
||||||
|
b.HasKey("TaskId");
|
||||||
|
|
||||||
|
b.ToTable("worktrees", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("list_tags", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("list_id")
|
||||||
|
.HasColumnType("TEXT");
|
||||||
|
|
||||||
|
b.Property<long>("tag_id")
|
||||||
|
.HasColumnType("INTEGER");
|
||||||
|
|
||||||
|
b.HasKey("list_id", "tag_id");
|
||||||
|
|
||||||
|
b.HasIndex("tag_id");
|
||||||
|
|
||||||
|
b.ToTable("list_tags", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("task_tags", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("task_id")
|
||||||
|
.HasColumnType("TEXT");
|
||||||
|
|
||||||
|
b.Property<long>("tag_id")
|
||||||
|
.HasColumnType("INTEGER");
|
||||||
|
|
||||||
|
b.HasKey("task_id", "tag_id");
|
||||||
|
|
||||||
|
b.HasIndex("tag_id");
|
||||||
|
|
||||||
|
b.ToTable("task_tags", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListConfigEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", "List")
|
||||||
|
.WithOne("Config")
|
||||||
|
.HasForeignKey("ClaudeDo.Data.Models.ListConfigEntity", "ListId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("List");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.SubtaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithMany("Subtasks")
|
||||||
|
.HasForeignKey("TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", "List")
|
||||||
|
.WithMany("Tasks")
|
||||||
|
.HasForeignKey("ListId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("List");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskRunEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithMany("Runs")
|
||||||
|
.HasForeignKey("TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.WorktreeEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithOne("Worktree")
|
||||||
|
.HasForeignKey("ClaudeDo.Data.Models.WorktreeEntity", "TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("list_tags", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("list_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TagEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("tag_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("task_tags", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TagEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("tag_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("task_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListEntity", b =>
|
||||||
|
{
|
||||||
|
b.Navigation("Config");
|
||||||
|
|
||||||
|
b.Navigation("Tasks");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Navigation("Runs");
|
||||||
|
|
||||||
|
b.Navigation("Subtasks");
|
||||||
|
|
||||||
|
b.Navigation("Worktree");
|
||||||
|
});
|
||||||
|
#pragma warning restore 612, 618
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
581
src/ClaudeDo.Data/Migrations/20260422120000_AddTaskSortOrder.Designer.cs
generated
Normal file
581
src/ClaudeDo.Data/Migrations/20260422120000_AddTaskSortOrder.Designer.cs
generated
Normal file
@@ -0,0 +1,581 @@
|
|||||||
|
// <auto-generated />
|
||||||
|
using System;
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using Microsoft.EntityFrameworkCore.Infrastructure;
|
||||||
|
using Microsoft.EntityFrameworkCore.Migrations;
|
||||||
|
using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
|
||||||
|
|
||||||
|
#nullable disable
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Migrations
|
||||||
|
{
|
||||||
|
[DbContext(typeof(ClaudeDoDbContext))]
|
||||||
|
[Migration("20260422120000_AddTaskSortOrder")]
|
||||||
|
partial class AddTaskSortOrder
|
||||||
|
{
|
||||||
|
/// <inheritdoc />
|
||||||
|
protected override void BuildTargetModel(ModelBuilder modelBuilder)
|
||||||
|
{
|
||||||
|
#pragma warning disable 612, 618
|
||||||
|
modelBuilder.HasAnnotation("ProductVersion", "8.0.11");
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.AppSettingsEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<int>("Id")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("CentralWorktreeRoot")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("central_worktree_root");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultClaudeInstructions")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("")
|
||||||
|
.HasColumnName("default_claude_instructions");
|
||||||
|
|
||||||
|
b.Property<int>("DefaultMaxTurns")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(30)
|
||||||
|
.HasColumnName("default_max_turns");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultModel")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("sonnet")
|
||||||
|
.HasColumnName("default_model");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultPermissionMode")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("bypassPermissions")
|
||||||
|
.HasColumnName("default_permission_mode");
|
||||||
|
|
||||||
|
b.Property<int>("WorktreeAutoCleanupDays")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(7)
|
||||||
|
.HasColumnName("worktree_auto_cleanup_days");
|
||||||
|
|
||||||
|
b.Property<bool>("WorktreeAutoCleanupEnabled")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("worktree_auto_cleanup_enabled");
|
||||||
|
|
||||||
|
b.Property<string>("WorktreeStrategy")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("sibling")
|
||||||
|
.HasColumnName("worktree_strategy");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.ToTable("app_settings", (string)null);
|
||||||
|
|
||||||
|
b.HasData(
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 1,
|
||||||
|
DefaultClaudeInstructions = "",
|
||||||
|
DefaultMaxTurns = 30,
|
||||||
|
DefaultModel = "sonnet",
|
||||||
|
DefaultPermissionMode = "bypassPermissions",
|
||||||
|
WorktreeAutoCleanupDays = 7,
|
||||||
|
WorktreeAutoCleanupEnabled = false,
|
||||||
|
WorktreeStrategy = "sibling"
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListConfigEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("ListId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("list_id");
|
||||||
|
|
||||||
|
b.Property<string>("AgentPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("agent_path");
|
||||||
|
|
||||||
|
b.Property<string>("Model")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("model");
|
||||||
|
|
||||||
|
b.Property<string>("SystemPrompt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("system_prompt");
|
||||||
|
|
||||||
|
b.HasKey("ListId");
|
||||||
|
|
||||||
|
b.ToTable("list_config", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultCommitType")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("chore")
|
||||||
|
.HasColumnName("default_commit_type");
|
||||||
|
|
||||||
|
b.Property<string>("Name")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("name");
|
||||||
|
|
||||||
|
b.Property<string>("WorkingDir")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("working_dir");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.ToTable("lists", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.SubtaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<bool>("Completed")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("completed");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<int>("OrderNum")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("order_num");
|
||||||
|
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<string>("Title")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("title");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("TaskId")
|
||||||
|
.HasDatabaseName("idx_subtasks_task_id");
|
||||||
|
|
||||||
|
b.ToTable("subtasks", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TagEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<long>("Id")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("Name")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("name");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("Name")
|
||||||
|
.IsUnique();
|
||||||
|
|
||||||
|
b.ToTable("tags", (string)null);
|
||||||
|
|
||||||
|
b.HasData(
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 1L,
|
||||||
|
Name = "agent"
|
||||||
|
},
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 2L,
|
||||||
|
Name = "manual"
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("AgentPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("agent_path");
|
||||||
|
|
||||||
|
b.Property<string>("CommitType")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("chore")
|
||||||
|
.HasColumnName("commit_type");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("Description")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("description");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("FinishedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("finished_at");
|
||||||
|
|
||||||
|
b.Property<bool>("IsMyDay")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_my_day");
|
||||||
|
|
||||||
|
b.Property<bool>("IsStarred")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_starred");
|
||||||
|
|
||||||
|
b.Property<string>("ListId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("list_id");
|
||||||
|
|
||||||
|
b.Property<string>("LogPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("log_path");
|
||||||
|
|
||||||
|
b.Property<string>("Model")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("model");
|
||||||
|
|
||||||
|
b.Property<string>("Notes")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("notes");
|
||||||
|
|
||||||
|
b.Property<string>("Result")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("result");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("ScheduledFor")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("scheduled_for");
|
||||||
|
|
||||||
|
b.Property<int>("SortOrder")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(0)
|
||||||
|
.HasColumnName("sort_order");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("StartedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("started_at");
|
||||||
|
|
||||||
|
b.Property<string>("Status")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("status");
|
||||||
|
|
||||||
|
b.Property<string>("SystemPrompt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("system_prompt");
|
||||||
|
|
||||||
|
b.Property<string>("Title")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("title");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("ListId")
|
||||||
|
.HasDatabaseName("idx_tasks_list_id");
|
||||||
|
|
||||||
|
b.HasIndex("Status")
|
||||||
|
.HasDatabaseName("idx_tasks_status");
|
||||||
|
|
||||||
|
b.HasIndex("ListId", "SortOrder")
|
||||||
|
.HasDatabaseName("idx_tasks_list_sort");
|
||||||
|
|
||||||
|
b.ToTable("tasks", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskRunEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("ErrorMarkdown")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("error_markdown");
|
||||||
|
|
||||||
|
b.Property<int?>("ExitCode")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("exit_code");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("FinishedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("finished_at");
|
||||||
|
|
||||||
|
b.Property<bool>("IsRetry")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_retry");
|
||||||
|
|
||||||
|
b.Property<string>("LogPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("log_path");
|
||||||
|
|
||||||
|
b.Property<string>("Prompt")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("prompt");
|
||||||
|
|
||||||
|
b.Property<string>("ResultMarkdown")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("result_markdown");
|
||||||
|
|
||||||
|
b.Property<int>("RunNumber")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("run_number");
|
||||||
|
|
||||||
|
b.Property<string>("SessionId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("session_id");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("StartedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("started_at");
|
||||||
|
|
||||||
|
b.Property<string>("StructuredOutputJson")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("structured_output");
|
||||||
|
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<int?>("TokensIn")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("tokens_in");
|
||||||
|
|
||||||
|
b.Property<int?>("TokensOut")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("tokens_out");
|
||||||
|
|
||||||
|
b.Property<int?>("TurnCount")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("turn_count");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("TaskId")
|
||||||
|
.HasDatabaseName("idx_task_runs_task_id");
|
||||||
|
|
||||||
|
b.ToTable("task_runs", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.WorktreeEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<string>("BaseCommit")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("base_commit");
|
||||||
|
|
||||||
|
b.Property<string>("BranchName")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("branch_name");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("DiffStat")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("diff_stat");
|
||||||
|
|
||||||
|
b.Property<string>("HeadCommit")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("head_commit");
|
||||||
|
|
||||||
|
b.Property<string>("Path")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("path");
|
||||||
|
|
||||||
|
b.Property<string>("State")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("active")
|
||||||
|
.HasColumnName("state");
|
||||||
|
|
||||||
|
b.HasKey("TaskId");
|
||||||
|
|
||||||
|
b.ToTable("worktrees", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("list_tags", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("list_id")
|
||||||
|
.HasColumnType("TEXT");
|
||||||
|
|
||||||
|
b.Property<long>("tag_id")
|
||||||
|
.HasColumnType("INTEGER");
|
||||||
|
|
||||||
|
b.HasKey("list_id", "tag_id");
|
||||||
|
|
||||||
|
b.HasIndex("tag_id");
|
||||||
|
|
||||||
|
b.ToTable("list_tags", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("task_tags", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("task_id")
|
||||||
|
.HasColumnType("TEXT");
|
||||||
|
|
||||||
|
b.Property<long>("tag_id")
|
||||||
|
.HasColumnType("INTEGER");
|
||||||
|
|
||||||
|
b.HasKey("task_id", "tag_id");
|
||||||
|
|
||||||
|
b.HasIndex("tag_id");
|
||||||
|
|
||||||
|
b.ToTable("task_tags", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListConfigEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", "List")
|
||||||
|
.WithOne("Config")
|
||||||
|
.HasForeignKey("ClaudeDo.Data.Models.ListConfigEntity", "ListId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("List");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.SubtaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithMany("Subtasks")
|
||||||
|
.HasForeignKey("TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", "List")
|
||||||
|
.WithMany("Tasks")
|
||||||
|
.HasForeignKey("ListId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("List");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskRunEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithMany("Runs")
|
||||||
|
.HasForeignKey("TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.WorktreeEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithOne("Worktree")
|
||||||
|
.HasForeignKey("ClaudeDo.Data.Models.WorktreeEntity", "TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("list_tags", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("list_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TagEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("tag_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("task_tags", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TagEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("tag_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("task_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListEntity", b =>
|
||||||
|
{
|
||||||
|
b.Navigation("Config");
|
||||||
|
|
||||||
|
b.Navigation("Tasks");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Navigation("Runs");
|
||||||
|
|
||||||
|
b.Navigation("Subtasks");
|
||||||
|
|
||||||
|
b.Navigation("Worktree");
|
||||||
|
});
|
||||||
|
#pragma warning restore 612, 618
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
609
src/ClaudeDo.Data/Migrations/20260423154708_AddPlanningSupport.Designer.cs
generated
Normal file
609
src/ClaudeDo.Data/Migrations/20260423154708_AddPlanningSupport.Designer.cs
generated
Normal file
@@ -0,0 +1,609 @@
|
|||||||
|
// <auto-generated />
|
||||||
|
using System;
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using Microsoft.EntityFrameworkCore.Infrastructure;
|
||||||
|
using Microsoft.EntityFrameworkCore.Migrations;
|
||||||
|
using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
|
||||||
|
|
||||||
|
#nullable disable
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Migrations
|
||||||
|
{
|
||||||
|
[DbContext(typeof(ClaudeDoDbContext))]
|
||||||
|
[Migration("20260423154708_AddPlanningSupport")]
|
||||||
|
partial class AddPlanningSupport
|
||||||
|
{
|
||||||
|
/// <inheritdoc />
|
||||||
|
protected override void BuildTargetModel(ModelBuilder modelBuilder)
|
||||||
|
{
|
||||||
|
#pragma warning disable 612, 618
|
||||||
|
modelBuilder.HasAnnotation("ProductVersion", "8.0.11");
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.AppSettingsEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<int>("Id")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("CentralWorktreeRoot")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("central_worktree_root");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultClaudeInstructions")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("")
|
||||||
|
.HasColumnName("default_claude_instructions");
|
||||||
|
|
||||||
|
b.Property<int>("DefaultMaxTurns")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(30)
|
||||||
|
.HasColumnName("default_max_turns");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultModel")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("sonnet")
|
||||||
|
.HasColumnName("default_model");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultPermissionMode")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("bypassPermissions")
|
||||||
|
.HasColumnName("default_permission_mode");
|
||||||
|
|
||||||
|
b.Property<int>("WorktreeAutoCleanupDays")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(7)
|
||||||
|
.HasColumnName("worktree_auto_cleanup_days");
|
||||||
|
|
||||||
|
b.Property<bool>("WorktreeAutoCleanupEnabled")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("worktree_auto_cleanup_enabled");
|
||||||
|
|
||||||
|
b.Property<string>("WorktreeStrategy")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("sibling")
|
||||||
|
.HasColumnName("worktree_strategy");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.ToTable("app_settings", (string)null);
|
||||||
|
|
||||||
|
b.HasData(
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 1,
|
||||||
|
DefaultClaudeInstructions = "",
|
||||||
|
DefaultMaxTurns = 30,
|
||||||
|
DefaultModel = "sonnet",
|
||||||
|
DefaultPermissionMode = "bypassPermissions",
|
||||||
|
WorktreeAutoCleanupDays = 7,
|
||||||
|
WorktreeAutoCleanupEnabled = false,
|
||||||
|
WorktreeStrategy = "sibling"
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListConfigEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("ListId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("list_id");
|
||||||
|
|
||||||
|
b.Property<string>("AgentPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("agent_path");
|
||||||
|
|
||||||
|
b.Property<string>("Model")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("model");
|
||||||
|
|
||||||
|
b.Property<string>("SystemPrompt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("system_prompt");
|
||||||
|
|
||||||
|
b.HasKey("ListId");
|
||||||
|
|
||||||
|
b.ToTable("list_config", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("DefaultCommitType")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("chore")
|
||||||
|
.HasColumnName("default_commit_type");
|
||||||
|
|
||||||
|
b.Property<string>("Name")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("name");
|
||||||
|
|
||||||
|
b.Property<string>("WorkingDir")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("working_dir");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.ToTable("lists", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.SubtaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<bool>("Completed")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("completed");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<int>("OrderNum")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("order_num");
|
||||||
|
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<string>("Title")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("title");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("TaskId")
|
||||||
|
.HasDatabaseName("idx_subtasks_task_id");
|
||||||
|
|
||||||
|
b.ToTable("subtasks", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TagEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<long>("Id")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("Name")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("name");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("Name")
|
||||||
|
.IsUnique();
|
||||||
|
|
||||||
|
b.ToTable("tags", (string)null);
|
||||||
|
|
||||||
|
b.HasData(
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 1L,
|
||||||
|
Name = "agent"
|
||||||
|
},
|
||||||
|
new
|
||||||
|
{
|
||||||
|
Id = 2L,
|
||||||
|
Name = "manual"
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("AgentPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("agent_path");
|
||||||
|
|
||||||
|
b.Property<string>("CommitType")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("chore")
|
||||||
|
.HasColumnName("commit_type");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("Description")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("description");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("FinishedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("finished_at");
|
||||||
|
|
||||||
|
b.Property<bool>("IsMyDay")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_my_day");
|
||||||
|
|
||||||
|
b.Property<bool>("IsStarred")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_starred");
|
||||||
|
|
||||||
|
b.Property<string>("ListId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("list_id");
|
||||||
|
|
||||||
|
b.Property<string>("LogPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("log_path");
|
||||||
|
|
||||||
|
b.Property<string>("Model")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("model");
|
||||||
|
|
||||||
|
b.Property<string>("Notes")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("notes");
|
||||||
|
|
||||||
|
b.Property<string>("ParentTaskId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("parent_task_id");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("PlanningFinalizedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("planning_finalized_at");
|
||||||
|
|
||||||
|
b.Property<string>("PlanningSessionId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("planning_session_id");
|
||||||
|
|
||||||
|
b.Property<string>("PlanningSessionToken")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("planning_session_token");
|
||||||
|
|
||||||
|
b.Property<string>("Result")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("result");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("ScheduledFor")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("scheduled_for");
|
||||||
|
|
||||||
|
b.Property<int>("SortOrder")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(0)
|
||||||
|
.HasColumnName("sort_order");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("StartedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("started_at");
|
||||||
|
|
||||||
|
b.Property<string>("Status")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("status");
|
||||||
|
|
||||||
|
b.Property<string>("SystemPrompt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("system_prompt");
|
||||||
|
|
||||||
|
b.Property<string>("Title")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("title");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("ListId")
|
||||||
|
.HasDatabaseName("idx_tasks_list_id");
|
||||||
|
|
||||||
|
b.HasIndex("ParentTaskId")
|
||||||
|
.HasDatabaseName("idx_tasks_parent_task_id");
|
||||||
|
|
||||||
|
b.HasIndex("Status")
|
||||||
|
.HasDatabaseName("idx_tasks_status");
|
||||||
|
|
||||||
|
b.HasIndex("ListId", "SortOrder")
|
||||||
|
.HasDatabaseName("idx_tasks_list_sort");
|
||||||
|
|
||||||
|
b.ToTable("tasks", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskRunEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("Id")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("id");
|
||||||
|
|
||||||
|
b.Property<string>("ErrorMarkdown")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("error_markdown");
|
||||||
|
|
||||||
|
b.Property<int?>("ExitCode")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("exit_code");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("FinishedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("finished_at");
|
||||||
|
|
||||||
|
b.Property<bool>("IsRetry")
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasDefaultValue(false)
|
||||||
|
.HasColumnName("is_retry");
|
||||||
|
|
||||||
|
b.Property<string>("LogPath")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("log_path");
|
||||||
|
|
||||||
|
b.Property<string>("Prompt")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("prompt");
|
||||||
|
|
||||||
|
b.Property<string>("ResultMarkdown")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("result_markdown");
|
||||||
|
|
||||||
|
b.Property<int>("RunNumber")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("run_number");
|
||||||
|
|
||||||
|
b.Property<string>("SessionId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("session_id");
|
||||||
|
|
||||||
|
b.Property<DateTime?>("StartedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("started_at");
|
||||||
|
|
||||||
|
b.Property<string>("StructuredOutputJson")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("structured_output");
|
||||||
|
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<int?>("TokensIn")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("tokens_in");
|
||||||
|
|
||||||
|
b.Property<int?>("TokensOut")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("tokens_out");
|
||||||
|
|
||||||
|
b.Property<int?>("TurnCount")
|
||||||
|
.HasColumnType("INTEGER")
|
||||||
|
.HasColumnName("turn_count");
|
||||||
|
|
||||||
|
b.HasKey("Id");
|
||||||
|
|
||||||
|
b.HasIndex("TaskId")
|
||||||
|
.HasDatabaseName("idx_task_runs_task_id");
|
||||||
|
|
||||||
|
b.ToTable("task_runs", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.WorktreeEntity", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("TaskId")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("task_id");
|
||||||
|
|
||||||
|
b.Property<string>("BaseCommit")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("base_commit");
|
||||||
|
|
||||||
|
b.Property<string>("BranchName")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("branch_name");
|
||||||
|
|
||||||
|
b.Property<DateTime>("CreatedAt")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("created_at");
|
||||||
|
|
||||||
|
b.Property<string>("DiffStat")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("diff_stat");
|
||||||
|
|
||||||
|
b.Property<string>("HeadCommit")
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("head_commit");
|
||||||
|
|
||||||
|
b.Property<string>("Path")
|
||||||
|
.IsRequired()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasColumnName("path");
|
||||||
|
|
||||||
|
b.Property<string>("State")
|
||||||
|
.IsRequired()
|
||||||
|
.ValueGeneratedOnAdd()
|
||||||
|
.HasColumnType("TEXT")
|
||||||
|
.HasDefaultValue("active")
|
||||||
|
.HasColumnName("state");
|
||||||
|
|
||||||
|
b.HasKey("TaskId");
|
||||||
|
|
||||||
|
b.ToTable("worktrees", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("list_tags", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("list_id")
|
||||||
|
.HasColumnType("TEXT");
|
||||||
|
|
||||||
|
b.Property<long>("tag_id")
|
||||||
|
.HasColumnType("INTEGER");
|
||||||
|
|
||||||
|
b.HasKey("list_id", "tag_id");
|
||||||
|
|
||||||
|
b.HasIndex("tag_id");
|
||||||
|
|
||||||
|
b.ToTable("list_tags", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("task_tags", b =>
|
||||||
|
{
|
||||||
|
b.Property<string>("task_id")
|
||||||
|
.HasColumnType("TEXT");
|
||||||
|
|
||||||
|
b.Property<long>("tag_id")
|
||||||
|
.HasColumnType("INTEGER");
|
||||||
|
|
||||||
|
b.HasKey("task_id", "tag_id");
|
||||||
|
|
||||||
|
b.HasIndex("tag_id");
|
||||||
|
|
||||||
|
b.ToTable("task_tags", (string)null);
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListConfigEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", "List")
|
||||||
|
.WithOne("Config")
|
||||||
|
.HasForeignKey("ClaudeDo.Data.Models.ListConfigEntity", "ListId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("List");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.SubtaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithMany("Subtasks")
|
||||||
|
.HasForeignKey("TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", "List")
|
||||||
|
.WithMany("Tasks")
|
||||||
|
.HasForeignKey("ListId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Parent")
|
||||||
|
.WithMany("Children")
|
||||||
|
.HasForeignKey("ParentTaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Restrict);
|
||||||
|
|
||||||
|
b.Navigation("List");
|
||||||
|
|
||||||
|
b.Navigation("Parent");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskRunEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithMany("Runs")
|
||||||
|
.HasForeignKey("TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.WorktreeEntity", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", "Task")
|
||||||
|
.WithOne("Worktree")
|
||||||
|
.HasForeignKey("ClaudeDo.Data.Models.WorktreeEntity", "TaskId")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.Navigation("Task");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("list_tags", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.ListEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("list_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TagEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("tag_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("task_tags", b =>
|
||||||
|
{
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TagEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("tag_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
|
||||||
|
b.HasOne("ClaudeDo.Data.Models.TaskEntity", null)
|
||||||
|
.WithMany()
|
||||||
|
.HasForeignKey("task_id")
|
||||||
|
.OnDelete(DeleteBehavior.Cascade)
|
||||||
|
.IsRequired();
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.ListEntity", b =>
|
||||||
|
{
|
||||||
|
b.Navigation("Config");
|
||||||
|
|
||||||
|
b.Navigation("Tasks");
|
||||||
|
});
|
||||||
|
|
||||||
|
modelBuilder.Entity("ClaudeDo.Data.Models.TaskEntity", b =>
|
||||||
|
{
|
||||||
|
b.Navigation("Children");
|
||||||
|
|
||||||
|
b.Navigation("Runs");
|
||||||
|
|
||||||
|
b.Navigation("Subtasks");
|
||||||
|
|
||||||
|
b.Navigation("Worktree");
|
||||||
|
});
|
||||||
|
#pragma warning restore 612, 618
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user