Compare commits
5
Commits
4dc4fe27e3
...
v2.6.0
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
63d8b5c28d | ||
|
|
ab56644ddc | ||
|
|
71050e2634 | ||
|
|
ef7645c6b1 | ||
|
|
92ce7a4a77 |
@@ -1,5 +1,26 @@
|
|||||||
# Changelog
|
# Changelog
|
||||||
|
|
||||||
|
## v2.5.0 — 2026-07-29
|
||||||
|
|
||||||
|
### Features
|
||||||
|
|
||||||
|
- move a task to another list via drag & drop (92ce7a4)
|
||||||
|
- sidebar shows queued+running, no auto-monitor seeding (44cdad3)
|
||||||
|
- expose maxParallelExecutions in get_app_settings (e653677)
|
||||||
|
- accent color presets in Settings → General (149e2ad)
|
||||||
|
- allow Done via update_task_status with worktree guard (d569313)
|
||||||
|
- add Let Claude handle it broom button to tasks header (7d6cb2b)
|
||||||
|
|
||||||
|
### Fixes
|
||||||
|
|
||||||
|
- stop swallowing mutating hub call failures (b5464fc)
|
||||||
|
- pin LogRingBuffer clock in Does_not_throw_when_detached (58f8b11)
|
||||||
|
- propagate HubException from ApproveReviewAsync so blocked merges surface errors (e1807fd)
|
||||||
|
|
||||||
|
### Documentation
|
||||||
|
|
||||||
|
- update for v2.4.0 (3fbbd7a)
|
||||||
|
|
||||||
## v2.4.0 — 2026-07-27
|
## v2.4.0 — 2026-07-27
|
||||||
|
|
||||||
### Features
|
### Features
|
||||||
|
|||||||
@@ -84,6 +84,60 @@ public sealed class TaskRepository
|
|||||||
public Task<List<TaskEntity>> GetByListAsync(string listId, CancellationToken ct = default)
|
public Task<List<TaskEntity>> GetByListAsync(string listId, CancellationToken ct = default)
|
||||||
=> GetByListIdAsync(listId, ct);
|
=> GetByListIdAsync(listId, ct);
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Returns the ids of every descendant of <paramref name="taskId"/> (children, grandchildren, ...),
|
||||||
|
/// walking the ParentTaskId chain breadth-first. Does not include the task itself.
|
||||||
|
/// </summary>
|
||||||
|
public async Task<List<string>> GetDescendantIdsAsync(string taskId, CancellationToken ct = default)
|
||||||
|
{
|
||||||
|
var result = new List<string>();
|
||||||
|
// Guards against a corrupt parent chain (a self-parent or a cycle would loop forever).
|
||||||
|
var seen = new HashSet<string>(StringComparer.Ordinal) { taskId };
|
||||||
|
var frontier = new List<string> { taskId };
|
||||||
|
while (frontier.Count > 0)
|
||||||
|
{
|
||||||
|
var children = await _context.Tasks.AsNoTracking()
|
||||||
|
.Where(t => t.ParentTaskId != null && frontier.Contains(t.ParentTaskId))
|
||||||
|
.Select(t => t.Id)
|
||||||
|
.ToListAsync(ct);
|
||||||
|
var fresh = children.Where(seen.Add).ToList();
|
||||||
|
if (fresh.Count == 0) break;
|
||||||
|
result.AddRange(fresh);
|
||||||
|
frontier = fresh;
|
||||||
|
}
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Moves a task (and every descendant, so a child never ends up in a different list than its
|
||||||
|
/// parent) to <paramref name="targetListId"/>, appending it at the end of the target list's
|
||||||
|
/// order. ListId is init-only, so the move goes through ExecuteUpdate rather than a tracked
|
||||||
|
/// entity mutation.
|
||||||
|
/// </summary>
|
||||||
|
public async Task MoveToListAsync(string taskId, string targetListId, CancellationToken ct = default)
|
||||||
|
{
|
||||||
|
var exists = await _context.Tasks.AsNoTracking().AnyAsync(t => t.Id == taskId, ct);
|
||||||
|
if (!exists)
|
||||||
|
throw new InvalidOperationException($"Task {taskId} not found.");
|
||||||
|
|
||||||
|
var descendantIds = await GetDescendantIdsAsync(taskId, ct);
|
||||||
|
var movedIds = new List<string> { taskId };
|
||||||
|
movedIds.AddRange(descendantIds);
|
||||||
|
|
||||||
|
var maxSort = await _context.Tasks
|
||||||
|
.Where(t => t.ListId == targetListId)
|
||||||
|
.Select(t => (int?)t.SortOrder)
|
||||||
|
.MaxAsync(ct);
|
||||||
|
|
||||||
|
await _context.Tasks
|
||||||
|
.Where(t => movedIds.Contains(t.Id))
|
||||||
|
.ExecuteUpdateAsync(s => s.SetProperty(t => t.ListId, targetListId), ct);
|
||||||
|
|
||||||
|
await _context.Tasks
|
||||||
|
.Where(t => t.Id == taskId)
|
||||||
|
.ExecuteUpdateAsync(s => s.SetProperty(t => t.SortOrder, (maxSort ?? -1) + 1), ct);
|
||||||
|
}
|
||||||
|
|
||||||
public async Task<List<TaskEntity>> GetByCreatorAsync(string createdBy, CancellationToken ct = default)
|
public async Task<List<TaskEntity>> GetByCreatorAsync(string createdBy, CancellationToken ct = default)
|
||||||
{
|
{
|
||||||
return await _context.Tasks
|
return await _context.Tasks
|
||||||
|
|||||||
@@ -27,6 +27,13 @@ public partial class App : Application
|
|||||||
{
|
{
|
||||||
base.OnStartup(e);
|
base.OnStartup(e);
|
||||||
|
|
||||||
|
// The app relaunches us via ShellExecute without an explicit working directory, so we
|
||||||
|
// inherit its CWD — which the Start Menu shortcut sets to <InstallDir>\app. A process's
|
||||||
|
// current directory is locked by the OS, so we would block DownloadAndExtractStep's
|
||||||
|
// Directory.Move of app\ against ourselves (fails on every attempt, reboot included).
|
||||||
|
// Step out of the install tree before anything else touches it.
|
||||||
|
try { Environment.CurrentDirectory = Path.GetTempPath(); } catch { /* best effort */ }
|
||||||
|
|
||||||
// --- Initialize localizer as early as possible so all windows can use {loc:Tr} ---
|
// --- Initialize localizer as early as possible so all windows can use {loc:Tr} ---
|
||||||
var localesDir = Path.Combine(AppContext.BaseDirectory, "locales");
|
var localesDir = Path.Combine(AppContext.BaseDirectory, "locales");
|
||||||
var localeStore = LocaleStore.Load(localesDir);
|
var localeStore = LocaleStore.Load(localesDir);
|
||||||
@@ -124,7 +131,7 @@ public partial class App : Application
|
|||||||
// Steps — execution order matters for the FreshInstall pipeline (IEnumerable<IInstallStep>).
|
// Steps — execution order matters for the FreshInstall pipeline (IEnumerable<IInstallStep>).
|
||||||
// Double-registered as both IInstallStep and concrete type so the Update pipeline
|
// Double-registered as both IInstallStep and concrete type so the Update pipeline
|
||||||
// can pull them out individually via GetRequiredService<T>().
|
// can pull them out individually via GetRequiredService<T>().
|
||||||
sc.AddSingleton<DownloadAndExtractStep>();
|
sc.AddSingleton(sp => new DownloadAndExtractStep(sp.GetRequiredService<IReleaseClient>()));
|
||||||
sc.AddSingleton<IInstallStep>(sp => sp.GetRequiredService<DownloadAndExtractStep>());
|
sc.AddSingleton<IInstallStep>(sp => sp.GetRequiredService<DownloadAndExtractStep>());
|
||||||
sc.AddSingleton<IInstallStep, WriteConfigStep>();
|
sc.AddSingleton<IInstallStep, WriteConfigStep>();
|
||||||
sc.AddSingleton<IInstallStep, InitDatabaseStep>();
|
sc.AddSingleton<IInstallStep, InitDatabaseStep>();
|
||||||
|
|||||||
@@ -82,6 +82,12 @@ Non-fatal if `claude` CLI is missing or too old (prints the manual command). Ser
|
|||||||
|
|
||||||
No new service or scheduled task is created. Rationale: the worker must run in the user's interactive session so Claude CLI auth works.
|
No new service or scheduled task is created. Rationale: the worker must run in the user's interactive session so Claude CLI auth works.
|
||||||
|
|
||||||
|
**`DownloadAndExtractStep`** — fetches `checksums.txt` first and only touches the install dir after the zip verifies. The zip is cached in `%TEMP%\ClaudeDo-download-cache` (ctor takes an override for tests) and reused on a retry when its SHA-256 still matches, so a failed attempt doesn't cost another full download; it is dropped after a successful install, a bad download is deleted immediately, and zips of other versions are pruned. `app\`/`worker\` are stashed to `*.bak` before extraction and restored if extraction fails.
|
||||||
|
|
||||||
|
### Gotcha: the installer must never run from inside the install dir
|
||||||
|
|
||||||
|
`App.OnStartup` sets `Environment.CurrentDirectory` to `%TEMP%`, and the UI passes an explicit `WorkingDirectory` when it relaunches us. A process's current directory is locked by Windows: inheriting the app's CWD (`<InstallDir>\app`, from the Start Menu shortcut's "start in") made the installer block its own `app` → `app.bak` rename, so every update failed with "Could not replace the existing files" — unaffected by retries or a reboot. Keep both guards.
|
||||||
|
|
||||||
## `InstallContext` Defaults
|
## `InstallContext` Defaults
|
||||||
|
|
||||||
| Property | Default |
|
| Property | Default |
|
||||||
|
|||||||
@@ -9,10 +9,14 @@ namespace ClaudeDo.Installer.Steps;
|
|||||||
public sealed class DownloadAndExtractStep : IInstallStep
|
public sealed class DownloadAndExtractStep : IInstallStep
|
||||||
{
|
{
|
||||||
private readonly IReleaseClient _releases;
|
private readonly IReleaseClient _releases;
|
||||||
|
private readonly string _cacheDir;
|
||||||
|
|
||||||
public DownloadAndExtractStep(IReleaseClient releases)
|
public DownloadAndExtractStep(IReleaseClient releases, string? cacheDirectory = null)
|
||||||
{
|
{
|
||||||
_releases = releases;
|
_releases = releases;
|
||||||
|
// Downloads survive a failed attempt so a retry doesn't pull ~100 MB again.
|
||||||
|
// %TEMP% because Storage Sense ages the cache out on its own.
|
||||||
|
_cacheDir = cacheDirectory ?? Path.Combine(Path.GetTempPath(), "ClaudeDo-download-cache");
|
||||||
}
|
}
|
||||||
|
|
||||||
public string Name => "Download and Extract";
|
public string Name => "Download and Extract";
|
||||||
@@ -38,38 +42,50 @@ public sealed class DownloadAndExtractStep : IInstallStep
|
|||||||
if (checksumAsset is null)
|
if (checksumAsset is null)
|
||||||
return StepResult.Fail("checksums.txt not found in release metadata.");
|
return StepResult.Fail("checksums.txt not found in release metadata.");
|
||||||
|
|
||||||
var scratchDir = Path.Combine(Path.GetTempPath(), "ClaudeDo-install-" + Guid.NewGuid().ToString("N"));
|
Directory.CreateDirectory(_cacheDir);
|
||||||
Directory.CreateDirectory(scratchDir);
|
var zipPath = Path.Combine(_cacheDir, zipAsset.Name);
|
||||||
|
var checksumPath = Path.Combine(_cacheDir, "checksums.txt");
|
||||||
|
PruneCacheExcept(zipAsset.Name);
|
||||||
|
|
||||||
try
|
|
||||||
{
|
{
|
||||||
var zipPath = Path.Combine(scratchDir, zipAsset.Name);
|
|
||||||
var checksumPath = Path.Combine(scratchDir, "checksums.txt");
|
|
||||||
|
|
||||||
var totalMb = zipAsset.Size / (1024 * 1024);
|
|
||||||
progress.Report($"Downloading {zipAsset.Name} ({totalMb} MB)...");
|
|
||||||
long lastReportedMb = -1;
|
|
||||||
await _releases.DownloadAsync(zipAsset.BrowserDownloadUrl, zipPath,
|
|
||||||
new Progress<long>(b =>
|
|
||||||
{
|
|
||||||
var mb = b / (1024 * 1024);
|
|
||||||
if (mb == lastReportedMb) return;
|
|
||||||
lastReportedMb = mb;
|
|
||||||
// Leading "\r" tells the UI to overwrite the previous line instead of appending.
|
|
||||||
progress.Report($"\r {mb} / {totalMb} MB downloaded");
|
|
||||||
}),
|
|
||||||
ct);
|
|
||||||
|
|
||||||
progress.Report("Downloading checksums...");
|
progress.Report("Downloading checksums...");
|
||||||
await _releases.DownloadAsync(checksumAsset.BrowserDownloadUrl, checksumPath,
|
await _releases.DownloadAsync(checksumAsset.BrowserDownloadUrl, checksumPath,
|
||||||
new Progress<long>(_ => { }), ct);
|
new Progress<long>(_ => { }), ct);
|
||||||
|
|
||||||
progress.Report("Verifying checksum...");
|
|
||||||
var map = ChecksumVerifier.ParseChecksumsFile(await File.ReadAllTextAsync(checksumPath, ct));
|
var map = ChecksumVerifier.ParseChecksumsFile(await File.ReadAllTextAsync(checksumPath, ct));
|
||||||
if (!map.TryGetValue(zipAsset.Name, out var expectedHash))
|
if (!map.TryGetValue(zipAsset.Name, out var expectedHash))
|
||||||
return StepResult.Fail($"No checksum entry for {zipAsset.Name} in checksums.txt.");
|
return StepResult.Fail($"No checksum entry for {zipAsset.Name} in checksums.txt.");
|
||||||
if (!ChecksumVerifier.Verify(zipPath, expectedHash))
|
|
||||||
return StepResult.Fail("Checksum mismatch — the downloaded zip may be corrupt or tampered with.");
|
// An earlier attempt may have failed after the download (locked files, bad
|
||||||
|
// extraction). Reuse that zip when it still verifies rather than re-downloading.
|
||||||
|
if (File.Exists(zipPath) && ChecksumVerifier.Verify(zipPath, expectedHash))
|
||||||
|
{
|
||||||
|
progress.Report($"Reusing the already downloaded {zipAsset.Name}.");
|
||||||
|
}
|
||||||
|
else
|
||||||
|
{
|
||||||
|
var totalMb = zipAsset.Size / (1024 * 1024);
|
||||||
|
progress.Report($"Downloading {zipAsset.Name} ({totalMb} MB)...");
|
||||||
|
long lastReportedMb = -1;
|
||||||
|
await _releases.DownloadAsync(zipAsset.BrowserDownloadUrl, zipPath,
|
||||||
|
new Progress<long>(b =>
|
||||||
|
{
|
||||||
|
var mb = b / (1024 * 1024);
|
||||||
|
if (mb == lastReportedMb) return;
|
||||||
|
lastReportedMb = mb;
|
||||||
|
// Leading "\r" tells the UI to overwrite the previous line instead of appending.
|
||||||
|
progress.Report($"\r {mb} / {totalMb} MB downloaded");
|
||||||
|
}),
|
||||||
|
ct);
|
||||||
|
|
||||||
|
progress.Report("Verifying checksum...");
|
||||||
|
if (!ChecksumVerifier.Verify(zipPath, expectedHash))
|
||||||
|
{
|
||||||
|
// Never keep a bad download around — it would be re-verified forever.
|
||||||
|
TryDelete(zipPath);
|
||||||
|
return StepResult.Fail("Checksum mismatch — the downloaded zip may be corrupt or tampered with.");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Only after verification do we touch the install directory.
|
// Only after verification do we touch the install directory.
|
||||||
progress.Report("Stashing previous app/worker binaries...");
|
progress.Report("Stashing previous app/worker binaries...");
|
||||||
@@ -78,20 +94,31 @@ public sealed class DownloadAndExtractStep : IInstallStep
|
|||||||
var appBak = appDest + ".bak";
|
var appBak = appDest + ".bak";
|
||||||
var workerBak = workerDest + ".bak";
|
var workerBak = workerDest + ".bak";
|
||||||
|
|
||||||
|
var stashedApp = false;
|
||||||
|
var failedPath = ctx.InstallDirectory;
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
|
failedPath = appBak;
|
||||||
if (Directory.Exists(appBak)) DeleteWithRetry(appBak);
|
if (Directory.Exists(appBak)) DeleteWithRetry(appBak);
|
||||||
|
failedPath = workerBak;
|
||||||
if (Directory.Exists(workerBak)) DeleteWithRetry(workerBak);
|
if (Directory.Exists(workerBak)) DeleteWithRetry(workerBak);
|
||||||
if (Directory.Exists(appDest)) MoveWithRetry(appDest, appBak);
|
failedPath = appDest;
|
||||||
|
if (Directory.Exists(appDest)) { MoveWithRetry(appDest, appBak); stashedApp = true; }
|
||||||
|
failedPath = workerDest;
|
||||||
if (Directory.Exists(workerDest)) MoveWithRetry(workerDest, workerBak);
|
if (Directory.Exists(workerDest)) MoveWithRetry(workerDest, workerBak);
|
||||||
}
|
}
|
||||||
catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
|
catch (Exception ex) when (ex is IOException or UnauthorizedAccessException)
|
||||||
{
|
{
|
||||||
|
// Undo a half-done stash: a leftover app.bak would be deleted as a stale
|
||||||
|
// stash on the next attempt — that copy is the only one we still have.
|
||||||
|
if (stashedApp && !Directory.Exists(appDest) && Directory.Exists(appBak))
|
||||||
|
try { MoveWithRetry(appBak, appDest); } catch { /* best effort */ }
|
||||||
|
|
||||||
// A just-stopped app/worker (or an Explorer/terminal window sitting in
|
// A just-stopped app/worker (or an Explorer/terminal window sitting in
|
||||||
// the install dir) still held a handle. Surface an actionable message
|
// the install dir) still held a handle. Surface an actionable message
|
||||||
// instead of the raw "process cannot access the file" error.
|
// instead of the raw "process cannot access the file" error.
|
||||||
return StepResult.Fail(
|
return StepResult.Fail(
|
||||||
"Could not replace the existing app/worker files — they are still in use. " +
|
$"Could not replace '{failedPath}' — it is still in use. " +
|
||||||
"Make sure ClaudeDo is fully closed (app and worker) and no Explorer or " +
|
"Make sure ClaudeDo is fully closed (app and worker) and no Explorer or " +
|
||||||
$"terminal window is open inside the install folder, then run the update again. Details: {ex.Message}");
|
$"terminal window is open inside the install folder, then run the update again. Details: {ex.Message}");
|
||||||
}
|
}
|
||||||
@@ -117,13 +144,32 @@ public sealed class DownloadAndExtractStep : IInstallStep
|
|||||||
if (Directory.Exists(appBak)) DeleteWithRetry(appBak);
|
if (Directory.Exists(appBak)) DeleteWithRetry(appBak);
|
||||||
if (Directory.Exists(workerBak)) DeleteWithRetry(workerBak);
|
if (Directory.Exists(workerBak)) DeleteWithRetry(workerBak);
|
||||||
|
|
||||||
|
// Installed — the cached zip has served its purpose.
|
||||||
|
TryDelete(zipPath);
|
||||||
|
TryDelete(checksumPath);
|
||||||
|
|
||||||
ctx.InstalledVersion = release.TagName.TrimStart('v', 'V');
|
ctx.InstalledVersion = release.TagName.TrimStart('v', 'V');
|
||||||
return StepResult.Ok();
|
return StepResult.Ok();
|
||||||
}
|
}
|
||||||
finally
|
}
|
||||||
|
|
||||||
|
// Zips from earlier attempts on other versions would pile up otherwise.
|
||||||
|
private void PruneCacheExcept(string keepFileName)
|
||||||
|
{
|
||||||
|
try
|
||||||
{
|
{
|
||||||
try { Directory.Delete(scratchDir, recursive: true); } catch { /* best effort */ }
|
foreach (var file in Directory.EnumerateFiles(_cacheDir, "*.zip"))
|
||||||
|
{
|
||||||
|
if (!string.Equals(Path.GetFileName(file), keepFileName, StringComparison.OrdinalIgnoreCase))
|
||||||
|
TryDelete(file);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
catch { /* best effort */ }
|
||||||
|
}
|
||||||
|
|
||||||
|
private static void TryDelete(string file)
|
||||||
|
{
|
||||||
|
try { File.Delete(file); } catch { /* best effort */ }
|
||||||
}
|
}
|
||||||
|
|
||||||
private static void MoveWithRetry(string source, string dest)
|
private static void MoveWithRetry(string source, string dest)
|
||||||
|
|||||||
@@ -542,7 +542,7 @@
|
|||||||
"taskStatus": { "idle": "Leerlauf", "queued": "In Warteschlange", "running": "Läuft", "waitingForReview": "Wartet auf Prüfung", "waitingForChildren": "Wartet auf Teilaufgaben", "done": "Fertig", "failed": "Fehlgeschlagen", "cancelled": "Abgebrochen", "parked": "Geparkt", "interactive": "Interaktiv" },
|
"taskStatus": { "idle": "Leerlauf", "queued": "In Warteschlange", "running": "Läuft", "waitingForReview": "Wartet auf Prüfung", "waitingForChildren": "Wartet auf Teilaufgaben", "done": "Fertig", "failed": "Fehlgeschlagen", "cancelled": "Abgebrochen", "parked": "Geparkt", "interactive": "Interaktiv" },
|
||||||
"planningBadge": { "active": "PLANUNG", "finalized": "GEPLANT" },
|
"planningBadge": { "active": "PLANUNG", "finalized": "GEPLANT" },
|
||||||
"taskRow": { "createdPrefix": "Erstellt {0}", "stepsText": "{0}/{1} Schritte" },
|
"taskRow": { "createdPrefix": "Erstellt {0}", "stepsText": "{0}/{1} Schritte" },
|
||||||
"tasksIsland": { "completedHeader": "ABGESCHLOSSEN", "completedHeaderCount": "ABGESCHLOSSEN · {0}", "planningOpenFailed": "Planungssitzung konnte nicht geöffnet werden: {0}", "planningResumeFailed": "Planungssitzung konnte nicht fortgesetzt werden: {0}", "pickUpInTerminalFailed": "Im Terminal fortsetzen fehlgeschlagen: {0}", "approveFailed": "Genehmigen & Mergen fehlgeschlagen: {0}" },
|
"tasksIsland": { "completedHeader": "ABGESCHLOSSEN", "completedHeaderCount": "ABGESCHLOSSEN · {0}", "planningOpenFailed": "Planungssitzung konnte nicht geöffnet werden: {0}", "planningResumeFailed": "Planungssitzung konnte nicht fortgesetzt werden: {0}", "pickUpInTerminalFailed": "Im Terminal fortsetzen fehlgeschlagen: {0}", "approveFailed": "Genehmigen & Mergen fehlgeschlagen: {0}", "moveRunningRejected": "Ein laufender Task kann nicht in eine andere Liste verschoben werden.", "moveWorktreeRejected": "Verschieben nicht möglich — dieser Task hat einen aktiven Worktree, der auf sein aktuelles Repo zeigt.", "moveRepoConfirm": "Unterschiedliche Repos — {0} → {1}. Task trotzdem verschieben?", "moveConfirmUnavailable": "Verschieben nicht möglich — der Bestätigungsdialog ist nicht verfügbar." },
|
||||||
"diff": { "loadFailed": "Diff konnte nicht geladen werden: {0}", "noChanges": "Keine Änderungen anzuzeigen.", "unavailable": "Diff nicht mehr verfügbar — Commit-Bereich unvollständig." },
|
"diff": { "loadFailed": "Diff konnte nicht geladen werden: {0}", "noChanges": "Keine Änderungen anzuzeigen.", "unavailable": "Diff nicht mehr verfügbar — Commit-Bereich unvollständig." },
|
||||||
"planningDiff": { "hubError": "Kombinierte Vorschau konnte nicht erstellt werden (Hub-Fehler).", "conflict": "Kombinierte Vorschau nicht möglich: Teilaufgabe {0} steht im Konflikt mit einer früheren Teilaufgabe ({1} Dateien).", "buildFailed": "Kombinierte Vorschau konnte nicht erstellt werden: {0}" },
|
"planningDiff": { "hubError": "Kombinierte Vorschau konnte nicht erstellt werden (Hub-Fehler).", "conflict": "Kombinierte Vorschau nicht möglich: Teilaufgabe {0} steht im Konflikt mit einer früheren Teilaufgabe ({1} Dateien).", "buildFailed": "Kombinierte Vorschau konnte nicht erstellt werden: {0}" },
|
||||||
"merge": { "commitMessage": "Merge-Aufgabe: {0}", "workerOfflineBranches": "Worker offline — Branches können nicht aufgelistet werden.", "loadBranchesFailed": "Branches konnten nicht geladen werden: {0}", "merged": "Zusammengeführt.", "conflict": "Merge-Konflikt — Ziel-Branch wiederhergestellt. Manuell oder über Fortsetzen lösen, dann erneut versuchen.", "blocked": "Blockiert: {0}", "unknownStatus": "Unbekannter Status: {0}", "mergeFailed": "Merge fehlgeschlagen: {0}" },
|
"merge": { "commitMessage": "Merge-Aufgabe: {0}", "workerOfflineBranches": "Worker offline — Branches können nicht aufgelistet werden.", "loadBranchesFailed": "Branches konnten nicht geladen werden: {0}", "merged": "Zusammengeführt.", "conflict": "Merge-Konflikt — Ziel-Branch wiederhergestellt. Manuell oder über Fortsetzen lösen, dann erneut versuchen.", "blocked": "Blockiert: {0}", "unknownStatus": "Unbekannter Status: {0}", "mergeFailed": "Merge fehlgeschlagen: {0}" },
|
||||||
|
|||||||
@@ -542,7 +542,7 @@
|
|||||||
"taskStatus": { "idle": "Idle", "queued": "Queued", "running": "Running", "waitingForReview": "Waiting for Review", "waitingForChildren": "Waiting for Subtasks", "done": "Done", "failed": "Failed", "cancelled": "Cancelled", "parked": "Parked", "interactive": "Interactive" },
|
"taskStatus": { "idle": "Idle", "queued": "Queued", "running": "Running", "waitingForReview": "Waiting for Review", "waitingForChildren": "Waiting for Subtasks", "done": "Done", "failed": "Failed", "cancelled": "Cancelled", "parked": "Parked", "interactive": "Interactive" },
|
||||||
"planningBadge": { "active": "PLANNING", "finalized": "PLANNED" },
|
"planningBadge": { "active": "PLANNING", "finalized": "PLANNED" },
|
||||||
"taskRow": { "createdPrefix": "Created {0}", "stepsText": "{0}/{1} steps" },
|
"taskRow": { "createdPrefix": "Created {0}", "stepsText": "{0}/{1} steps" },
|
||||||
"tasksIsland": { "completedHeader": "COMPLETED", "completedHeaderCount": "COMPLETED · {0}", "planningOpenFailed": "Couldn't open planning session: {0}", "planningResumeFailed": "Couldn't resume planning session: {0}", "pickUpInTerminalFailed": "Pick up in terminal failed: {0}", "approveFailed": "Approve & merge failed: {0}" },
|
"tasksIsland": { "completedHeader": "COMPLETED", "completedHeaderCount": "COMPLETED · {0}", "planningOpenFailed": "Couldn't open planning session: {0}", "planningResumeFailed": "Couldn't resume planning session: {0}", "pickUpInTerminalFailed": "Pick up in terminal failed: {0}", "approveFailed": "Approve & merge failed: {0}", "moveRunningRejected": "Can't move a running task to another list.", "moveWorktreeRejected": "Can't move — this task has an active worktree pointing at its current repo.", "moveRepoConfirm": "Different repos — {0} → {1}. Move the task anyway?", "moveConfirmUnavailable": "Can't move — the confirmation dialog isn't available." },
|
||||||
"diff": { "loadFailed": "Failed to load diff: {0}", "noChanges": "No changes to show.", "unavailable": "Diff no longer available — commit range incomplete." },
|
"diff": { "loadFailed": "Failed to load diff: {0}", "noChanges": "No changes to show.", "unavailable": "Diff no longer available — commit range incomplete." },
|
||||||
"planningDiff": { "hubError": "Could not build combined preview (hub error).", "conflict": "Cannot build combined preview: subtask {0} conflicts with an earlier subtask ({1} files).", "buildFailed": "Could not build combined preview: {0}" },
|
"planningDiff": { "hubError": "Could not build combined preview (hub error).", "conflict": "Cannot build combined preview: subtask {0} conflicts with an earlier subtask ({1} files).", "buildFailed": "Could not build combined preview: {0}" },
|
||||||
"merge": { "commitMessage": "Merge task: {0}", "workerOfflineBranches": "Worker offline — cannot list branches.", "loadBranchesFailed": "Failed to load branches: {0}", "merged": "Merged.", "conflict": "Merge conflict — target branch restored. Resolve manually or via Continue, then retry.", "blocked": "Blocked: {0}", "unknownStatus": "Unknown status: {0}", "mergeFailed": "Merge failed: {0}" },
|
"merge": { "commitMessage": "Merge task: {0}", "workerOfflineBranches": "Worker offline — cannot list branches.", "loadBranchesFailed": "Failed to load branches: {0}", "merged": "Merged.", "conflict": "Merge conflict — target branch restored. Resolve manually or via Continue, then retry.", "blocked": "Blocked: {0}", "unknownStatus": "Unknown status: {0}", "mergeFailed": "Merge failed: {0}" },
|
||||||
|
|||||||
@@ -693,6 +693,10 @@
|
|||||||
<Setter Property="CornerRadius" Value="8" />
|
<Setter Property="CornerRadius" Value="8" />
|
||||||
<Setter Property="Cursor" Value="Hand" />
|
<Setter Property="Cursor" Value="Hand" />
|
||||||
<Setter Property="Background" Value="Transparent" />
|
<Setter Property="Background" Value="Transparent" />
|
||||||
|
<!-- Reserved so the task-drop highlight below only swaps the brush — a thickness that changes
|
||||||
|
on hover would nudge the row's content while dragging over it. -->
|
||||||
|
<Setter Property="BorderThickness" Value="1.5" />
|
||||||
|
<Setter Property="BorderBrush" Value="Transparent" />
|
||||||
</Style>
|
</Style>
|
||||||
<Style Selector="Border.list-item:pointerover">
|
<Style Selector="Border.list-item:pointerover">
|
||||||
<Setter Property="Background" Value="{StaticResource Surface2Brush}" />
|
<Setter Property="Background" Value="{StaticResource Surface2Brush}" />
|
||||||
@@ -700,6 +704,11 @@
|
|||||||
<Style Selector="Border.list-item.active">
|
<Style Selector="Border.list-item.active">
|
||||||
<Setter Property="Background" Value="{StaticResource AccentSoftBrush}" />
|
<Setter Property="Background" Value="{StaticResource AccentSoftBrush}" />
|
||||||
</Style>
|
</Style>
|
||||||
|
<!-- Highlighted while a dragged task hovers over this row as a move target. -->
|
||||||
|
<Style Selector="Border.list-item.drop-target">
|
||||||
|
<Setter Property="Background" Value="{StaticResource AccentSoftBrush}" />
|
||||||
|
<Setter Property="BorderBrush" Value="{StaticResource AccentBrush}" />
|
||||||
|
</Style>
|
||||||
<!-- Active item text / icon colors -->
|
<!-- Active item text / icon colors -->
|
||||||
<Style Selector="Border.list-item.active TextBlock.list-label">
|
<Style Selector="Border.list-item.active TextBlock.list-label">
|
||||||
<Setter Property="Foreground" Value="{StaticResource TextBrush}" />
|
<Setter Property="Foreground" Value="{StaticResource TextBrush}" />
|
||||||
|
|||||||
@@ -16,6 +16,9 @@ public sealed partial class ListNavItemViewModel : ViewModelBase
|
|||||||
[ObservableProperty] private bool _isManual;
|
[ObservableProperty] private bool _isManual;
|
||||||
[ObservableProperty] private bool _dropHintAbove;
|
[ObservableProperty] private bool _dropHintAbove;
|
||||||
[ObservableProperty] private bool _dropHintBelow;
|
[ObservableProperty] private bool _dropHintBelow;
|
||||||
|
// Set while a dragged task hovers over this row as a move target — distinct from
|
||||||
|
// DropHintAbove/Below, which mark an insertion point for list reordering.
|
||||||
|
[ObservableProperty] private bool _isTaskDropTarget;
|
||||||
public string? IconKey { get; init; }
|
public string? IconKey { get; init; }
|
||||||
public string? DotColorKey { get; init; }
|
public string? DotColorKey { get; init; }
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -231,6 +231,12 @@ public sealed partial class TasksIslandViewModel : ViewModelBase, IDisposable
|
|||||||
_loadCts = new CancellationTokenSource();
|
_loadCts = new CancellationTokenSource();
|
||||||
var ct = _loadCts.Token;
|
var ct = _loadCts.Token;
|
||||||
|
|
||||||
|
// Items is rebuilt from scratch below, so a selection carried over from the previous list
|
||||||
|
// would leave the detail pane bound to a task the visible list no longer contains. Only a
|
||||||
|
// *different* list drops it — a reload of the same list (worker refresh, reconnect) keeps
|
||||||
|
// the selection so a live update never yanks the detail pane away.
|
||||||
|
var listChanged = !string.Equals(_currentList?.Id, list?.Id, StringComparison.Ordinal);
|
||||||
|
|
||||||
if (_currentList is not null)
|
if (_currentList is not null)
|
||||||
_currentList.PropertyChanged -= OnCurrentListPropertyChanged;
|
_currentList.PropertyChanged -= OnCurrentListPropertyChanged;
|
||||||
_currentList = list;
|
_currentList = list;
|
||||||
@@ -246,6 +252,7 @@ public sealed partial class TasksIslandViewModel : ViewModelBase, IDisposable
|
|||||||
HasCompleted = false;
|
HasCompleted = false;
|
||||||
ShowOpenLabel = false;
|
ShowOpenLabel = false;
|
||||||
ShowNotesRow = false;
|
ShowNotesRow = false;
|
||||||
|
if (listChanged) SelectedTask = null;
|
||||||
if (list is null) { IsLetClaudeVisible = false; LoadTask = Task.CompletedTask; return; }
|
if (list is null) { IsLetClaudeVisible = false; LoadTask = Task.CompletedTask; return; }
|
||||||
|
|
||||||
HeaderTitle = list.Name;
|
HeaderTitle = list.Name;
|
||||||
@@ -471,6 +478,11 @@ public sealed partial class TasksIslandViewModel : ViewModelBase, IDisposable
|
|||||||
}
|
}
|
||||||
|
|
||||||
public bool CanReorder => _currentList?.Kind == ListKind.User;
|
public bool CanReorder => _currentList?.Kind == ListKind.User;
|
||||||
|
public string? CurrentListId => _currentList?.Id;
|
||||||
|
|
||||||
|
/// <summary>Set by the shell (mirrors <see cref="ListsIslandViewModel.Dialogs"/>) so a
|
||||||
|
/// cross-repo move can confirm via the shared modal seam.</summary>
|
||||||
|
public IDialogService? Dialogs { get; set; }
|
||||||
|
|
||||||
public void ClearDropHints()
|
public void ClearDropHints()
|
||||||
{
|
{
|
||||||
@@ -573,6 +585,76 @@ public sealed partial class TasksIslandViewModel : ViewModelBase, IDisposable
|
|||||||
return null;
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// Drag-drop move: reassigns a task (and every descendant) to <paramref name="targetList"/>.
|
||||||
|
/// No-op for anything that isn't a user list the task doesn't already sit in.
|
||||||
|
/// Rejects running tasks and tasks (or descendants) holding an Active/Kept worktree — the
|
||||||
|
/// worktree would keep pointing at the source repo. A move across repos without a worktree
|
||||||
|
/// is allowed but asks for confirmation first.
|
||||||
|
/// </summary>
|
||||||
|
public async Task MoveTaskToListAsync(TaskRowViewModel row, ListNavItemViewModel targetList)
|
||||||
|
{
|
||||||
|
if (targetList.Kind != ListKind.User) return;
|
||||||
|
var targetListId = targetList.Id.StartsWith("user:", StringComparison.Ordinal)
|
||||||
|
? targetList.Id["user:".Length..]
|
||||||
|
: targetList.Id;
|
||||||
|
|
||||||
|
await using var db = await _dbFactory.CreateDbContextAsync();
|
||||||
|
|
||||||
|
// The row's own list, not _currentList — the task island also shows smart/virtual lists,
|
||||||
|
// whose rows come from many lists and which carry no working dir of their own. Dropping a
|
||||||
|
// task on the list it already sits in is a silent no-op.
|
||||||
|
var sourceListId = await db.Tasks.AsNoTracking()
|
||||||
|
.Where(t => t.Id == row.Id).Select(t => t.ListId).FirstOrDefaultAsync();
|
||||||
|
if (sourceListId is null || sourceListId == targetListId) return;
|
||||||
|
|
||||||
|
if (row.IsRunning)
|
||||||
|
{
|
||||||
|
ErrorReported?.Invoke(Loc.T("vm.tasksIsland.moveRunningRejected"));
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
var repo = new TaskRepository(db);
|
||||||
|
|
||||||
|
var descendantIds = await repo.GetDescendantIdsAsync(row.Id);
|
||||||
|
var ownIds = new List<string> { row.Id };
|
||||||
|
ownIds.AddRange(descendantIds);
|
||||||
|
var hasBlockingWorktree = await db.Worktrees.AsNoTracking()
|
||||||
|
.Where(w => ownIds.Contains(w.TaskId)
|
||||||
|
&& (w.State == ClaudeDo.Data.Models.WorktreeState.Active
|
||||||
|
|| w.State == ClaudeDo.Data.Models.WorktreeState.Kept))
|
||||||
|
.AnyAsync();
|
||||||
|
if (hasBlockingWorktree)
|
||||||
|
{
|
||||||
|
ErrorReported?.Invoke(Loc.T("vm.tasksIsland.moveWorktreeRejected"));
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
var sourceDir = await db.Lists.AsNoTracking()
|
||||||
|
.Where(l => l.Id == sourceListId).Select(l => l.WorkingDir).FirstOrDefaultAsync();
|
||||||
|
var targetDir = targetList.WorkingDir;
|
||||||
|
var repoChanges = !string.Equals(sourceDir, targetDir, StringComparison.OrdinalIgnoreCase);
|
||||||
|
if (repoChanges)
|
||||||
|
{
|
||||||
|
if (Dialogs is null)
|
||||||
|
{
|
||||||
|
ErrorReported?.Invoke(Loc.T("vm.tasksIsland.moveConfirmUnavailable"));
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
var ok = await Dialogs.ConfirmAsync(Loc.T("vm.tasksIsland.moveRepoConfirm",
|
||||||
|
string.IsNullOrWhiteSpace(sourceDir) ? "—" : sourceDir,
|
||||||
|
string.IsNullOrWhiteSpace(targetDir) ? "—" : targetDir));
|
||||||
|
if (!ok) return;
|
||||||
|
}
|
||||||
|
|
||||||
|
await repo.MoveToListAsync(row.Id, targetListId);
|
||||||
|
|
||||||
|
Items.Remove(row);
|
||||||
|
Regroup();
|
||||||
|
UpdateSubtitle();
|
||||||
|
TasksChanged?.Invoke(this, EventArgs.Empty);
|
||||||
|
}
|
||||||
|
|
||||||
[RelayCommand]
|
[RelayCommand]
|
||||||
private async Task ToggleDoneAsync(TaskRowViewModel row)
|
private async Task ToggleDoneAsync(TaskRowViewModel row)
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -56,6 +56,7 @@ public sealed partial class IslandsShellViewModel : ViewModelBase, IDisposable
|
|||||||
{
|
{
|
||||||
_dialogs = value;
|
_dialogs = value;
|
||||||
if (Lists is not null) Lists.Dialogs = value;
|
if (Lists is not null) Lists.Dialogs = value;
|
||||||
|
if (Tasks is not null) Tasks.Dialogs = value;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -495,7 +496,13 @@ public sealed partial class IslandsShellViewModel : ViewModelBase, IDisposable
|
|||||||
|
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
System.Diagnostics.Process.Start(new System.Diagnostics.ProcessStartInfo(path) { UseShellExecute = true });
|
// WorkingDirectory must NOT stay empty: the child would inherit ours (<InstallDir>\app)
|
||||||
|
// and its locked current directory blocks the installer's own app\ rename.
|
||||||
|
System.Diagnostics.Process.Start(new System.Diagnostics.ProcessStartInfo(path)
|
||||||
|
{
|
||||||
|
UseShellExecute = true,
|
||||||
|
WorkingDirectory = System.IO.Path.GetTempPath(),
|
||||||
|
});
|
||||||
Environment.Exit(0);
|
Environment.Exit(0);
|
||||||
}
|
}
|
||||||
catch
|
catch
|
||||||
|
|||||||
@@ -1,5 +1,6 @@
|
|||||||
using System;
|
using System;
|
||||||
using System.Diagnostics;
|
using System.Diagnostics;
|
||||||
|
using System.IO;
|
||||||
using ClaudeDo.Ui.Services;
|
using ClaudeDo.Ui.Services;
|
||||||
using CommunityToolkit.Mvvm.Input;
|
using CommunityToolkit.Mvvm.Input;
|
||||||
|
|
||||||
@@ -37,7 +38,13 @@ public sealed partial class WorkerConnectionModalViewModel : ViewModelBase
|
|||||||
if (path is null) return;
|
if (path is null) return;
|
||||||
try
|
try
|
||||||
{
|
{
|
||||||
Process.Start(new ProcessStartInfo(path) { UseShellExecute = true });
|
// See IslandsShellViewModel.UpdateNow: an inherited CWD inside the install dir
|
||||||
|
// makes the installer block its own app\ rename.
|
||||||
|
Process.Start(new ProcessStartInfo(path)
|
||||||
|
{
|
||||||
|
UseShellExecute = true,
|
||||||
|
WorkingDirectory = Path.GetTempPath(),
|
||||||
|
});
|
||||||
Environment.Exit(0);
|
Environment.Exit(0);
|
||||||
}
|
}
|
||||||
catch { /* nothing useful to show */ }
|
catch { /* nothing useful to show */ }
|
||||||
|
|||||||
@@ -116,6 +116,7 @@
|
|||||||
IsVisible="{Binding DropHintAbove}"/>
|
IsVisible="{Binding DropHintAbove}"/>
|
||||||
|
|
||||||
<Border Grid.Row="1" Classes="list-item" Classes.active="{Binding IsActive}"
|
<Border Grid.Row="1" Classes="list-item" Classes.active="{Binding IsActive}"
|
||||||
|
Classes.drop-target="{Binding IsTaskDropTarget}"
|
||||||
Tapped="OnItemTapped"
|
Tapped="OnItemTapped"
|
||||||
DragDrop.AllowDrop="True"
|
DragDrop.AllowDrop="True"
|
||||||
DragDrop.DragOver="OnListDragOver"
|
DragDrop.DragOver="OnListDragOver"
|
||||||
|
|||||||
@@ -31,6 +31,9 @@ public partial class TasksIslandView : UserControl
|
|||||||
private bool _dragArmed;
|
private bool _dragArmed;
|
||||||
private bool _dragging;
|
private bool _dragging;
|
||||||
|
|
||||||
|
// The list row (in the Lists island) currently highlighted as a drop target while dragging.
|
||||||
|
private ListNavItemViewModel? _hintedList;
|
||||||
|
|
||||||
public TasksIslandView()
|
public TasksIslandView()
|
||||||
{
|
{
|
||||||
InitializeComponent();
|
InitializeComponent();
|
||||||
@@ -170,6 +173,7 @@ public partial class TasksIslandView : UserControl
|
|||||||
{
|
{
|
||||||
_drag.MoveTo(this.PointToScreen(e.GetPosition(this)));
|
_drag.MoveTo(this.PointToScreen(e.GetPosition(this)));
|
||||||
UpdateReorderHint(e, topLevel);
|
UpdateReorderHint(e, topLevel);
|
||||||
|
UpdateListDropHint(e, topLevel);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -205,7 +209,17 @@ public partial class TasksIslandView : UserControl
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
// 2) Released over another row in the same user list → reorder.
|
// 2) Released over another user list in the Lists island → move the task there.
|
||||||
|
if (DataContext is TasksIslandViewModel vmMove
|
||||||
|
&& ListItemUnder(e, topLevel) is { } targetList
|
||||||
|
&& targetList.Kind == ListKind.User
|
||||||
|
&& targetList.Id != vmMove.CurrentListId)
|
||||||
|
{
|
||||||
|
await vmMove.MoveTaskToListAsync(row, targetList);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
// 3) Released over another row in the same user list → reorder.
|
||||||
if (DataContext is TasksIslandViewModel vm && vm.CanReorder)
|
if (DataContext is TasksIslandViewModel vm && vm.CanReorder)
|
||||||
{
|
{
|
||||||
var targetButton = RowButtonAt(e, topLevel);
|
var targetButton = RowButtonAt(e, topLevel);
|
||||||
@@ -218,7 +232,7 @@ public partial class TasksIslandView : UserControl
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// 3) Anywhere else → cancel; EndDrag already restored the source row.
|
// 4) Anywhere else → cancel; EndDrag already restored the source row.
|
||||||
}
|
}
|
||||||
|
|
||||||
private void OnPointerCaptureLost(object? sender, PointerCaptureLostEventArgs e)
|
private void OnPointerCaptureLost(object? sender, PointerCaptureLostEventArgs e)
|
||||||
@@ -229,6 +243,7 @@ public partial class TasksIslandView : UserControl
|
|||||||
if (!_dragArmed && !_dragging) return;
|
if (!_dragArmed && !_dragging) return;
|
||||||
if (_pressRow is not null) _pressRow.IsDragging = false;
|
if (_pressRow is not null) _pressRow.IsDragging = false;
|
||||||
if (DataContext is TasksIslandViewModel vm) vm.ClearDropHints();
|
if (DataContext is TasksIslandViewModel vm) vm.ClearDropHints();
|
||||||
|
ClearListDropHint();
|
||||||
_drag.End();
|
_drag.End();
|
||||||
ResetPressState();
|
ResetPressState();
|
||||||
}
|
}
|
||||||
@@ -237,6 +252,7 @@ public partial class TasksIslandView : UserControl
|
|||||||
{
|
{
|
||||||
if (_pressRow is not null) _pressRow.IsDragging = false;
|
if (_pressRow is not null) _pressRow.IsDragging = false;
|
||||||
if (DataContext is TasksIslandViewModel vm) vm.ClearDropHints();
|
if (DataContext is TasksIslandViewModel vm) vm.ClearDropHints();
|
||||||
|
ClearListDropHint();
|
||||||
_drag.End();
|
_drag.End();
|
||||||
if (_dragging) e.Pointer.Capture(null);
|
if (_dragging) e.Pointer.Capture(null);
|
||||||
ResetPressState();
|
ResetPressState();
|
||||||
@@ -295,6 +311,44 @@ public partial class TasksIslandView : UserControl
|
|||||||
return button?.DataContext is TaskRowViewModel ? button : null;
|
return button?.DataContext is TaskRowViewModel ? button : null;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// The list-row Border under the cursor (Lists island), found the same way as RowButtonAt but
|
||||||
|
// walking up to a Border with the "list-item" style class (mirrors ListsIslandView's own
|
||||||
|
// FindListItemBorder) — the task drag has the pointer captured here, so a DragEventArgs never
|
||||||
|
// reaches the Lists island's own DragDrop.DragOver/Drop handlers.
|
||||||
|
private static ListNavItemViewModel? ListItemUnder(PointerEventArgs e, TopLevel topLevel)
|
||||||
|
{
|
||||||
|
var pt = e.GetPosition((Visual)topLevel);
|
||||||
|
Visual? v = topLevel.InputHitTest(pt) as Visual;
|
||||||
|
while (v is not null)
|
||||||
|
{
|
||||||
|
if (v is Border b && b.Classes.Contains("list-item"))
|
||||||
|
return b.DataContext as ListNavItemViewModel;
|
||||||
|
v = v.GetVisualParent();
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Live drop-hint while dragging over a candidate target list row.
|
||||||
|
private void UpdateListDropHint(PointerEventArgs e, TopLevel topLevel)
|
||||||
|
{
|
||||||
|
if (DataContext is not TasksIslandViewModel vm) { ClearListDropHint(); return; }
|
||||||
|
|
||||||
|
var target = ListItemUnder(e, topLevel);
|
||||||
|
if (target is null || target.Kind != ListKind.User || target.Id == vm.CurrentListId)
|
||||||
|
target = null;
|
||||||
|
|
||||||
|
if (ReferenceEquals(_hintedList, target)) return;
|
||||||
|
if (_hintedList is not null) _hintedList.IsTaskDropTarget = false;
|
||||||
|
_hintedList = target;
|
||||||
|
if (_hintedList is not null) _hintedList.IsTaskDropTarget = true;
|
||||||
|
}
|
||||||
|
|
||||||
|
private void ClearListDropHint()
|
||||||
|
{
|
||||||
|
if (_hintedList is not null) _hintedList.IsTaskDropTarget = false;
|
||||||
|
_hintedList = null;
|
||||||
|
}
|
||||||
|
|
||||||
// The Mission Control view model whose window contains the release point, if any.
|
// The Mission Control view model whose window contains the release point, if any.
|
||||||
private static MissionControlViewModel? MissionControlUnder(PixelPoint screen)
|
private static MissionControlViewModel? MissionControlUnder(PixelPoint screen)
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -0,0 +1,143 @@
|
|||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Data.Tests;
|
||||||
|
|
||||||
|
public sealed class MoveToListTests : IDisposable
|
||||||
|
{
|
||||||
|
private readonly string _dbPath;
|
||||||
|
private readonly ClaudeDoDbContext _ctx;
|
||||||
|
|
||||||
|
public MoveToListTests()
|
||||||
|
{
|
||||||
|
_dbPath = Path.Combine(Path.GetTempPath(), $"claudedo_movelist_{Guid.NewGuid():N}.db");
|
||||||
|
var options = new DbContextOptionsBuilder<ClaudeDoDbContext>()
|
||||||
|
.UseSqlite($"Data Source={_dbPath}")
|
||||||
|
.Options;
|
||||||
|
_ctx = new ClaudeDoDbContext(options);
|
||||||
|
_ctx.Database.EnsureCreated();
|
||||||
|
}
|
||||||
|
|
||||||
|
public void Dispose()
|
||||||
|
{
|
||||||
|
_ctx.Dispose();
|
||||||
|
try { File.Delete(_dbPath); } catch { }
|
||||||
|
try { File.Delete(_dbPath + "-wal"); } catch { }
|
||||||
|
try { File.Delete(_dbPath + "-shm"); } catch { }
|
||||||
|
}
|
||||||
|
|
||||||
|
private async Task SeedListsAsync(params string[] ids)
|
||||||
|
{
|
||||||
|
foreach (var id in ids)
|
||||||
|
_ctx.Lists.Add(new ListEntity { Id = id, Name = id, CreatedAt = DateTime.UtcNow });
|
||||||
|
await _ctx.SaveChangesAsync();
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task MoveToList_changes_ListId_and_appends_at_end_of_target()
|
||||||
|
{
|
||||||
|
await SeedListsAsync("source", "target");
|
||||||
|
_ctx.Tasks.Add(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = "t1", ListId = "source", Title = "Task", CreatedAt = DateTime.UtcNow, SortOrder = 0,
|
||||||
|
});
|
||||||
|
// Existing tasks already in the target list, so we can assert the moved task lands after them.
|
||||||
|
_ctx.Tasks.Add(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = "existing1", ListId = "target", Title = "Existing 1", CreatedAt = DateTime.UtcNow, SortOrder = 0,
|
||||||
|
});
|
||||||
|
_ctx.Tasks.Add(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = "existing2", ListId = "target", Title = "Existing 2", CreatedAt = DateTime.UtcNow, SortOrder = 1,
|
||||||
|
});
|
||||||
|
await _ctx.SaveChangesAsync();
|
||||||
|
_ctx.ChangeTracker.Clear();
|
||||||
|
|
||||||
|
await new TaskRepository(_ctx).MoveToListAsync("t1", "target");
|
||||||
|
|
||||||
|
var moved = await _ctx.Tasks.AsNoTracking().FirstAsync(t => t.Id == "t1");
|
||||||
|
Assert.Equal("target", moved.ListId);
|
||||||
|
Assert.Equal(2, moved.SortOrder);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task MoveToList_moves_all_descendants_recursively()
|
||||||
|
{
|
||||||
|
await SeedListsAsync("source", "target");
|
||||||
|
_ctx.Tasks.Add(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = "parent", ListId = "source", Title = "Parent", CreatedAt = DateTime.UtcNow, SortOrder = 0,
|
||||||
|
});
|
||||||
|
_ctx.Tasks.Add(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = "child", ListId = "source", Title = "Child", CreatedAt = DateTime.UtcNow,
|
||||||
|
SortOrder = 1, ParentTaskId = "parent",
|
||||||
|
});
|
||||||
|
_ctx.Tasks.Add(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = "grandchild", ListId = "source", Title = "Grandchild", CreatedAt = DateTime.UtcNow,
|
||||||
|
SortOrder = 2, ParentTaskId = "child",
|
||||||
|
});
|
||||||
|
await _ctx.SaveChangesAsync();
|
||||||
|
_ctx.ChangeTracker.Clear();
|
||||||
|
|
||||||
|
await new TaskRepository(_ctx).MoveToListAsync("parent", "target");
|
||||||
|
|
||||||
|
var all = await _ctx.Tasks.AsNoTracking()
|
||||||
|
.Where(t => t.Id == "parent" || t.Id == "child" || t.Id == "grandchild")
|
||||||
|
.ToListAsync();
|
||||||
|
|
||||||
|
Assert.All(all, t => Assert.Equal("target", t.ListId));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task MoveToList_first_task_in_empty_target_gets_SortOrder_zero()
|
||||||
|
{
|
||||||
|
await SeedListsAsync("source", "target");
|
||||||
|
_ctx.Tasks.Add(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = "t1", ListId = "source", Title = "Task", CreatedAt = DateTime.UtcNow, SortOrder = 3,
|
||||||
|
});
|
||||||
|
await _ctx.SaveChangesAsync();
|
||||||
|
_ctx.ChangeTracker.Clear();
|
||||||
|
|
||||||
|
await new TaskRepository(_ctx).MoveToListAsync("t1", "target");
|
||||||
|
|
||||||
|
var moved = await _ctx.Tasks.AsNoTracking().FirstAsync(t => t.Id == "t1");
|
||||||
|
Assert.Equal("target", moved.ListId);
|
||||||
|
Assert.Equal(0, moved.SortOrder);
|
||||||
|
}
|
||||||
|
|
||||||
|
// A corrupt parent chain must not hang the descendant walk.
|
||||||
|
[Fact(Timeout = 15000)]
|
||||||
|
public async Task MoveToList_survives_a_self_parenting_task()
|
||||||
|
{
|
||||||
|
await SeedListsAsync("source", "target");
|
||||||
|
_ctx.Tasks.Add(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = "t1", ListId = "source", Title = "Task", CreatedAt = DateTime.UtcNow, SortOrder = 0,
|
||||||
|
});
|
||||||
|
await _ctx.SaveChangesAsync();
|
||||||
|
// Set the cycle after insert — the FK tolerates it, the walk must too.
|
||||||
|
await _ctx.Tasks.Where(t => t.Id == "t1")
|
||||||
|
.ExecuteUpdateAsync(s => s.SetProperty(t => t.ParentTaskId, "t1"));
|
||||||
|
_ctx.ChangeTracker.Clear();
|
||||||
|
|
||||||
|
await new TaskRepository(_ctx).MoveToListAsync("t1", "target");
|
||||||
|
|
||||||
|
var moved = await _ctx.Tasks.AsNoTracking().FirstAsync(t => t.Id == "t1");
|
||||||
|
Assert.Equal("target", moved.ListId);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task MoveToList_throws_when_task_missing()
|
||||||
|
{
|
||||||
|
await SeedListsAsync("source", "target");
|
||||||
|
|
||||||
|
await Assert.ThrowsAsync<InvalidOperationException>(() =>
|
||||||
|
new TaskRepository(_ctx).MoveToListAsync("nope", "target"));
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -10,6 +10,7 @@ public sealed class DownloadAndExtractStepTests : IDisposable
|
|||||||
{
|
{
|
||||||
private readonly string _tempDir;
|
private readonly string _tempDir;
|
||||||
private readonly string _installDir;
|
private readonly string _installDir;
|
||||||
|
private readonly string _cacheDir;
|
||||||
|
|
||||||
public DownloadAndExtractStepTests()
|
public DownloadAndExtractStepTests()
|
||||||
{
|
{
|
||||||
@@ -17,6 +18,7 @@ public sealed class DownloadAndExtractStepTests : IDisposable
|
|||||||
Directory.CreateDirectory(_tempDir);
|
Directory.CreateDirectory(_tempDir);
|
||||||
_installDir = Path.Combine(_tempDir, "install");
|
_installDir = Path.Combine(_tempDir, "install");
|
||||||
Directory.CreateDirectory(_installDir);
|
Directory.CreateDirectory(_installDir);
|
||||||
|
_cacheDir = Path.Combine(_tempDir, "cache");
|
||||||
}
|
}
|
||||||
|
|
||||||
public void Dispose()
|
public void Dispose()
|
||||||
@@ -28,6 +30,7 @@ public sealed class DownloadAndExtractStepTests : IDisposable
|
|||||||
{
|
{
|
||||||
private readonly Dictionary<string, string> _urlToSourceFile;
|
private readonly Dictionary<string, string> _urlToSourceFile;
|
||||||
public GiteaRelease? Release { get; set; }
|
public GiteaRelease? Release { get; set; }
|
||||||
|
public List<string> DownloadedUrls { get; } = new();
|
||||||
|
|
||||||
public FileCopyReleaseClient(Dictionary<string, string> urlToSourceFile)
|
public FileCopyReleaseClient(Dictionary<string, string> urlToSourceFile)
|
||||||
=> _urlToSourceFile = urlToSourceFile;
|
=> _urlToSourceFile = urlToSourceFile;
|
||||||
@@ -36,12 +39,45 @@ public sealed class DownloadAndExtractStepTests : IDisposable
|
|||||||
|
|
||||||
public Task DownloadAsync(string url, string destPath, IProgress<long> progress, CancellationToken ct)
|
public Task DownloadAsync(string url, string destPath, IProgress<long> progress, CancellationToken ct)
|
||||||
{
|
{
|
||||||
|
DownloadedUrls.Add(url);
|
||||||
File.Copy(_urlToSourceFile[url], destPath, overwrite: true);
|
File.Copy(_urlToSourceFile[url], destPath, overwrite: true);
|
||||||
progress.Report(new FileInfo(destPath).Length);
|
progress.Report(new FileInfo(destPath).Length);
|
||||||
return Task.CompletedTask;
|
return Task.CompletedTask;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Builds a valid release zip + checksums.txt and a client that serves both.
|
||||||
|
private (FileCopyReleaseClient Client, string ZipName) SetUpRelease()
|
||||||
|
{
|
||||||
|
var zipPath = Path.Combine(_tempDir, "release.zip");
|
||||||
|
using (var fs = File.Create(zipPath))
|
||||||
|
using (var zip = new ZipArchive(fs, ZipArchiveMode.Create))
|
||||||
|
{
|
||||||
|
var a = zip.CreateEntry("app/a.txt");
|
||||||
|
using (var w = new StreamWriter(a.Open())) w.Write("hello-app");
|
||||||
|
var b = zip.CreateEntry("worker/b.txt");
|
||||||
|
using (var w = new StreamWriter(b.Open())) w.Write("hello-worker");
|
||||||
|
}
|
||||||
|
|
||||||
|
const string zipName = "ClaudeDo-0.1.0-win-x64.zip";
|
||||||
|
var checksumsPath = Path.Combine(_tempDir, "checksums.txt");
|
||||||
|
File.WriteAllText(checksumsPath, $"{ChecksumVerifier.ComputeSha256(zipPath)} {zipName}\n");
|
||||||
|
|
||||||
|
var release = new GiteaRelease("v0.1.0", "v0.1.0", new[]
|
||||||
|
{
|
||||||
|
new ReleaseAsset(zipName, "fake://zip", new FileInfo(zipPath).Length),
|
||||||
|
new ReleaseAsset("checksums.txt", "fake://checksums", new FileInfo(checksumsPath).Length),
|
||||||
|
});
|
||||||
|
|
||||||
|
var client = new FileCopyReleaseClient(new()
|
||||||
|
{
|
||||||
|
["fake://zip"] = zipPath,
|
||||||
|
["fake://checksums"] = checksumsPath,
|
||||||
|
}) { Release = release };
|
||||||
|
|
||||||
|
return (client, zipName);
|
||||||
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
public async Task Extracts_Zip_Into_InstallDir_App_And_Worker()
|
public async Task Extracts_Zip_Into_InstallDir_App_And_Worker()
|
||||||
{
|
{
|
||||||
@@ -71,7 +107,7 @@ public sealed class DownloadAndExtractStepTests : IDisposable
|
|||||||
["fake://checksums"] = checksumsPath,
|
["fake://checksums"] = checksumsPath,
|
||||||
}) { Release = release };
|
}) { Release = release };
|
||||||
|
|
||||||
var step = new DownloadAndExtractStep(client);
|
var step = new DownloadAndExtractStep(client, _cacheDir);
|
||||||
var ctx = new InstallContext { InstallDirectory = _installDir };
|
var ctx = new InstallContext { InstallDirectory = _installDir };
|
||||||
|
|
||||||
var result = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
var result = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
||||||
@@ -110,7 +146,7 @@ public sealed class DownloadAndExtractStepTests : IDisposable
|
|||||||
["fake://checksums"] = checksumsPath,
|
["fake://checksums"] = checksumsPath,
|
||||||
}) { Release = release };
|
}) { Release = release };
|
||||||
|
|
||||||
var step = new DownloadAndExtractStep(client);
|
var step = new DownloadAndExtractStep(client, _cacheDir);
|
||||||
var ctx = new InstallContext { InstallDirectory = _installDir };
|
var ctx = new InstallContext { InstallDirectory = _installDir };
|
||||||
|
|
||||||
var result = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
var result = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
||||||
@@ -126,7 +162,7 @@ public sealed class DownloadAndExtractStepTests : IDisposable
|
|||||||
{
|
{
|
||||||
var release = new GiteaRelease("v0.1.0", "v0.1.0", Array.Empty<ReleaseAsset>());
|
var release = new GiteaRelease("v0.1.0", "v0.1.0", Array.Empty<ReleaseAsset>());
|
||||||
var client = new FileCopyReleaseClient(new()) { Release = release };
|
var client = new FileCopyReleaseClient(new()) { Release = release };
|
||||||
var step = new DownloadAndExtractStep(client);
|
var step = new DownloadAndExtractStep(client, _cacheDir);
|
||||||
var ctx = new InstallContext { InstallDirectory = _installDir };
|
var ctx = new InstallContext { InstallDirectory = _installDir };
|
||||||
|
|
||||||
var result = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
var result = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
||||||
@@ -135,11 +171,92 @@ public sealed class DownloadAndExtractStepTests : IDisposable
|
|||||||
Assert.Contains("not found", result.ErrorMessage!, StringComparison.OrdinalIgnoreCase);
|
Assert.Contains("not found", result.ErrorMessage!, StringComparison.OrdinalIgnoreCase);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Reuses_Cached_Zip_Instead_Of_Downloading_It_Again()
|
||||||
|
{
|
||||||
|
var (client, zipName) = SetUpRelease();
|
||||||
|
Directory.CreateDirectory(_cacheDir);
|
||||||
|
// A previous run left a fully downloaded, still-valid zip behind.
|
||||||
|
File.Copy(Path.Combine(_tempDir, "release.zip"), Path.Combine(_cacheDir, zipName));
|
||||||
|
|
||||||
|
var step = new DownloadAndExtractStep(client, _cacheDir);
|
||||||
|
var ctx = new InstallContext { InstallDirectory = _installDir };
|
||||||
|
|
||||||
|
var result = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.True(result.Success, result.ErrorMessage);
|
||||||
|
Assert.DoesNotContain("fake://zip", client.DownloadedUrls);
|
||||||
|
Assert.Equal("hello-app", File.ReadAllText(Path.Combine(_installDir, "app", "a.txt")));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Redownloads_When_Cached_Zip_Is_Corrupt()
|
||||||
|
{
|
||||||
|
var (client, zipName) = SetUpRelease();
|
||||||
|
Directory.CreateDirectory(_cacheDir);
|
||||||
|
// A cancelled/aborted download left a truncated file behind.
|
||||||
|
File.WriteAllText(Path.Combine(_cacheDir, zipName), "not-a-zip");
|
||||||
|
|
||||||
|
var step = new DownloadAndExtractStep(client, _cacheDir);
|
||||||
|
var ctx = new InstallContext { InstallDirectory = _installDir };
|
||||||
|
|
||||||
|
var result = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.True(result.Success, result.ErrorMessage);
|
||||||
|
Assert.Contains("fake://zip", client.DownloadedUrls);
|
||||||
|
Assert.Equal("hello-app", File.ReadAllText(Path.Combine(_installDir, "app", "a.txt")));
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Keeps_Zip_Cached_When_The_Install_Fails_And_Drops_It_On_Success()
|
||||||
|
{
|
||||||
|
var (client, zipName) = SetUpRelease();
|
||||||
|
var cachedZip = Path.Combine(_cacheDir, zipName);
|
||||||
|
|
||||||
|
// Make extraction fail: a *file* named "app" blocks the app/ entry's directory.
|
||||||
|
var blocker = Path.Combine(_installDir, "app");
|
||||||
|
File.WriteAllText(blocker, "blocked");
|
||||||
|
|
||||||
|
var step = new DownloadAndExtractStep(client, _cacheDir);
|
||||||
|
var ctx = new InstallContext { InstallDirectory = _installDir };
|
||||||
|
|
||||||
|
var failed = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
||||||
|
Assert.False(failed.Success);
|
||||||
|
Assert.True(File.Exists(cachedZip), "a failed install must keep the download cached");
|
||||||
|
|
||||||
|
// Retry after clearing the blocker: no second download, and the cache is dropped.
|
||||||
|
File.Delete(blocker);
|
||||||
|
client.DownloadedUrls.Clear();
|
||||||
|
|
||||||
|
var ok = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.True(ok.Success, ok.ErrorMessage);
|
||||||
|
Assert.DoesNotContain("fake://zip", client.DownloadedUrls);
|
||||||
|
Assert.False(File.Exists(cachedZip), "a successful install must not leave the zip behind");
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Prunes_Cached_Zips_From_Other_Versions()
|
||||||
|
{
|
||||||
|
var (client, _) = SetUpRelease();
|
||||||
|
Directory.CreateDirectory(_cacheDir);
|
||||||
|
var stale = Path.Combine(_cacheDir, "ClaudeDo-0.0.9-win-x64.zip");
|
||||||
|
File.WriteAllText(stale, "old release");
|
||||||
|
|
||||||
|
var step = new DownloadAndExtractStep(client, _cacheDir);
|
||||||
|
var ctx = new InstallContext { InstallDirectory = _installDir };
|
||||||
|
|
||||||
|
var result = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
||||||
|
|
||||||
|
Assert.True(result.Success, result.ErrorMessage);
|
||||||
|
Assert.False(File.Exists(stale));
|
||||||
|
}
|
||||||
|
|
||||||
[Fact]
|
[Fact]
|
||||||
public async Task Fails_When_ReleaseClient_Returns_Null()
|
public async Task Fails_When_ReleaseClient_Returns_Null()
|
||||||
{
|
{
|
||||||
var client = new FileCopyReleaseClient(new()) { Release = null };
|
var client = new FileCopyReleaseClient(new()) { Release = null };
|
||||||
var step = new DownloadAndExtractStep(client);
|
var step = new DownloadAndExtractStep(client, _cacheDir);
|
||||||
var ctx = new InstallContext { InstallDirectory = _installDir };
|
var ctx = new InstallContext { InstallDirectory = _installDir };
|
||||||
|
|
||||||
var result = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
var result = await step.ExecuteAsync(ctx, new Progress<string>(_ => { }), CancellationToken.None);
|
||||||
|
|||||||
@@ -0,0 +1,112 @@
|
|||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Ui.ViewModels.Islands;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Tests.ViewModels;
|
||||||
|
|
||||||
|
// Switching lists must drop the previous list's selection; reloading the SAME list (worker
|
||||||
|
// refresh / reconnect) must keep it, so a live update never yanks the detail pane away.
|
||||||
|
public class TasksIslandListSwitchSelectionTests : IDisposable
|
||||||
|
{
|
||||||
|
private readonly string _dbPath;
|
||||||
|
|
||||||
|
public TasksIslandListSwitchSelectionTests()
|
||||||
|
{
|
||||||
|
_dbPath = Path.Combine(Path.GetTempPath(), $"claudedo_ui_listswitch_{Guid.NewGuid():N}.db");
|
||||||
|
using var ctx = NewContext();
|
||||||
|
ctx.Database.EnsureCreated();
|
||||||
|
}
|
||||||
|
|
||||||
|
public void Dispose()
|
||||||
|
{
|
||||||
|
try { File.Delete(_dbPath); } catch { }
|
||||||
|
try { File.Delete(_dbPath + "-wal"); } catch { }
|
||||||
|
try { File.Delete(_dbPath + "-shm"); } catch { }
|
||||||
|
}
|
||||||
|
|
||||||
|
private ClaudeDoDbContext NewContext()
|
||||||
|
{
|
||||||
|
var opts = new DbContextOptionsBuilder<ClaudeDoDbContext>()
|
||||||
|
.UseSqlite($"Data Source={_dbPath}")
|
||||||
|
.Options;
|
||||||
|
return new ClaudeDoDbContext(opts);
|
||||||
|
}
|
||||||
|
|
||||||
|
private sealed class TestDbFactory : IDbContextFactory<ClaudeDoDbContext>
|
||||||
|
{
|
||||||
|
private readonly Func<ClaudeDoDbContext> _create;
|
||||||
|
public TestDbFactory(Func<ClaudeDoDbContext> create) => _create = create;
|
||||||
|
public ClaudeDoDbContext CreateDbContext() => _create();
|
||||||
|
}
|
||||||
|
|
||||||
|
private async Task SeedTwoListsAsync()
|
||||||
|
{
|
||||||
|
await using var db = NewContext();
|
||||||
|
db.Lists.Add(new ListEntity { Id = "L1", Name = "Work", CreatedAt = DateTime.UtcNow });
|
||||||
|
db.Lists.Add(new ListEntity { Id = "L2", Name = "Home", CreatedAt = DateTime.UtcNow });
|
||||||
|
db.Tasks.Add(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = "T1", ListId = "L1", Title = "Task one",
|
||||||
|
Status = TaskStatus.Idle, CreatedAt = DateTime.UtcNow, SortOrder = 0,
|
||||||
|
});
|
||||||
|
db.Tasks.Add(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = "T2", ListId = "L2", Title = "Task two",
|
||||||
|
Status = TaskStatus.Idle, CreatedAt = DateTime.UtcNow, SortOrder = 0,
|
||||||
|
});
|
||||||
|
await db.SaveChangesAsync();
|
||||||
|
}
|
||||||
|
|
||||||
|
private static ListNavItemViewModel Nav(string listId, string name) =>
|
||||||
|
new() { Id = $"user:{listId}", Name = name, Kind = ListKind.User };
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task LoadForList_OtherList_ClearsSelectedTask_AndRaisesSelectionChanged()
|
||||||
|
{
|
||||||
|
await SeedTwoListsAsync();
|
||||||
|
var vm = new TasksIslandViewModel(new TestDbFactory(NewContext), worker: null);
|
||||||
|
|
||||||
|
vm.LoadForList(Nav("L1", "Work"));
|
||||||
|
Assert.True(await vm.SelectByIdAsync("T1"));
|
||||||
|
|
||||||
|
var selectionChanges = 0;
|
||||||
|
vm.SelectionChanged += (_, _) => selectionChanges++;
|
||||||
|
|
||||||
|
vm.LoadForList(Nav("L2", "Home"));
|
||||||
|
if (vm.LoadTask is { } load) await load;
|
||||||
|
|
||||||
|
Assert.Null(vm.SelectedTask);
|
||||||
|
Assert.Equal(1, selectionChanges);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task LoadForList_NullList_ClearsSelectedTask()
|
||||||
|
{
|
||||||
|
await SeedTwoListsAsync();
|
||||||
|
var vm = new TasksIslandViewModel(new TestDbFactory(NewContext), worker: null);
|
||||||
|
|
||||||
|
vm.LoadForList(Nav("L1", "Work"));
|
||||||
|
Assert.True(await vm.SelectByIdAsync("T1"));
|
||||||
|
|
||||||
|
vm.LoadForList(null);
|
||||||
|
|
||||||
|
Assert.Null(vm.SelectedTask);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task LoadForList_SameList_KeepsSelectedTask()
|
||||||
|
{
|
||||||
|
await SeedTwoListsAsync();
|
||||||
|
var vm = new TasksIslandViewModel(new TestDbFactory(NewContext), worker: null);
|
||||||
|
|
||||||
|
vm.LoadForList(Nav("L1", "Work"));
|
||||||
|
Assert.True(await vm.SelectByIdAsync("T1"));
|
||||||
|
|
||||||
|
vm.LoadForList(Nav("L1", "Work"));
|
||||||
|
if (vm.LoadTask is { } load) await load;
|
||||||
|
|
||||||
|
Assert.Equal("T1", vm.SelectedTask?.Id);
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,346 @@
|
|||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Ui.Services;
|
||||||
|
using ClaudeDo.Ui.ViewModels;
|
||||||
|
using ClaudeDo.Ui.ViewModels.Conflicts;
|
||||||
|
using ClaudeDo.Ui.ViewModels.Islands;
|
||||||
|
using ClaudeDo.Ui.ViewModels.Modals;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Tests.ViewModels;
|
||||||
|
|
||||||
|
public class TasksIslandMoveToListTests : IDisposable
|
||||||
|
{
|
||||||
|
private readonly string _dbPath;
|
||||||
|
|
||||||
|
public TasksIslandMoveToListTests()
|
||||||
|
{
|
||||||
|
_dbPath = Path.Combine(Path.GetTempPath(), $"claudedo_movetolist_{Guid.NewGuid():N}.db");
|
||||||
|
using var ctx = NewContext();
|
||||||
|
ctx.Database.EnsureCreated();
|
||||||
|
}
|
||||||
|
|
||||||
|
public void Dispose()
|
||||||
|
{
|
||||||
|
try { File.Delete(_dbPath); } catch { }
|
||||||
|
try { File.Delete(_dbPath + "-wal"); } catch { }
|
||||||
|
try { File.Delete(_dbPath + "-shm"); } catch { }
|
||||||
|
}
|
||||||
|
|
||||||
|
private ClaudeDoDbContext NewContext()
|
||||||
|
{
|
||||||
|
var opts = new DbContextOptionsBuilder<ClaudeDoDbContext>()
|
||||||
|
.UseSqlite($"Data Source={_dbPath}")
|
||||||
|
.Options;
|
||||||
|
return new ClaudeDoDbContext(opts);
|
||||||
|
}
|
||||||
|
|
||||||
|
private sealed class TestDbFactory : IDbContextFactory<ClaudeDoDbContext>
|
||||||
|
{
|
||||||
|
private readonly Func<ClaudeDoDbContext> _create;
|
||||||
|
public TestDbFactory(Func<ClaudeDoDbContext> create) => _create = create;
|
||||||
|
public ClaudeDoDbContext CreateDbContext() => _create();
|
||||||
|
}
|
||||||
|
|
||||||
|
private sealed class FakeDialogService : IDialogService
|
||||||
|
{
|
||||||
|
public bool ConfirmResult;
|
||||||
|
public int ConfirmCalls;
|
||||||
|
public string? LastMessage;
|
||||||
|
|
||||||
|
public Task<bool> ConfirmAsync(string message)
|
||||||
|
{
|
||||||
|
ConfirmCalls++;
|
||||||
|
LastMessage = message;
|
||||||
|
return Task.FromResult(ConfirmResult);
|
||||||
|
}
|
||||||
|
|
||||||
|
public Task ShowAboutAsync(AboutModalViewModel vm) => throw new NotImplementedException();
|
||||||
|
public Task ShowWeeklyReportAsync(WeeklyReportModalViewModel vm) => throw new NotImplementedException();
|
||||||
|
public Task ShowSettingsAsync(SettingsModalViewModel vm) => throw new NotImplementedException();
|
||||||
|
public Task ShowListSettingsAsync(ListSettingsModalViewModel vm) => throw new NotImplementedException();
|
||||||
|
public Task ShowRepoImportAsync(RepoImportModalViewModel vm) => throw new NotImplementedException();
|
||||||
|
public Task ShowWorktreesOverviewAsync(WorktreesOverviewModalViewModel vm) => throw new NotImplementedException();
|
||||||
|
public Task<IReadOnlyList<string>?> ShowMergeHelperSelectionAsync(MergeHelperSelectionModalViewModel vm) => throw new NotImplementedException();
|
||||||
|
public Task ShowWorkerConnectionAsync(WorkerConnectionModalViewModel vm) => throw new NotImplementedException();
|
||||||
|
public Task ShowConflictResolverAsync(ConflictResolverViewModel vm) => throw new NotImplementedException();
|
||||||
|
public Task ShowLogVisualizerAsync(LogVisualizerViewModel vm) => throw new NotImplementedException();
|
||||||
|
public Task ShowErrorAsync(string message) => Task.CompletedTask;
|
||||||
|
public void ShowMissionControl(MissionControlViewModel vm) => throw new NotImplementedException();
|
||||||
|
public void ShowDetachedMonitor(TaskMonitorViewModel monitor, Action onClosed) => throw new NotImplementedException();
|
||||||
|
}
|
||||||
|
|
||||||
|
private TasksIslandViewModel BuildViewModel() => new(new TestDbFactory(NewContext), worker: null);
|
||||||
|
|
||||||
|
private async Task SeedListsAsync(string? sourceDir = null, string? targetDir = null)
|
||||||
|
{
|
||||||
|
await using var db = NewContext();
|
||||||
|
db.Lists.Add(new ListEntity { Id = "source", Name = "Source", CreatedAt = DateTime.UtcNow, WorkingDir = sourceDir });
|
||||||
|
db.Lists.Add(new ListEntity { Id = "target", Name = "Target", CreatedAt = DateTime.UtcNow, WorkingDir = targetDir });
|
||||||
|
await db.SaveChangesAsync();
|
||||||
|
}
|
||||||
|
|
||||||
|
private async Task SeedTaskAsync(string id, TaskStatus status, string listId = "source", string? parentTaskId = null)
|
||||||
|
{
|
||||||
|
await using var db = NewContext();
|
||||||
|
db.Tasks.Add(new TaskEntity
|
||||||
|
{
|
||||||
|
Id = id, ListId = listId, Title = id, CreatedAt = DateTime.UtcNow,
|
||||||
|
Status = status, ParentTaskId = parentTaskId, SortOrder = 0,
|
||||||
|
});
|
||||||
|
await db.SaveChangesAsync();
|
||||||
|
}
|
||||||
|
|
||||||
|
private async Task SeedWorktreeAsync(string taskId, WorktreeState state)
|
||||||
|
{
|
||||||
|
await using var db = NewContext();
|
||||||
|
db.Worktrees.Add(new WorktreeEntity
|
||||||
|
{
|
||||||
|
TaskId = taskId, Path = $"C:/wt/{taskId}", BranchName = $"task/{taskId}",
|
||||||
|
BaseCommit = "abc123", State = state, CreatedAt = DateTime.UtcNow,
|
||||||
|
});
|
||||||
|
await db.SaveChangesAsync();
|
||||||
|
}
|
||||||
|
|
||||||
|
private static ListNavItemViewModel SourceList(string? workingDir = null) =>
|
||||||
|
new() { Id = "user:source", Kind = ListKind.User, Name = "Source", WorkingDir = workingDir };
|
||||||
|
|
||||||
|
private static ListNavItemViewModel TargetList(string? workingDir = null) =>
|
||||||
|
new() { Id = "user:target", Kind = ListKind.User, Name = "Target", WorkingDir = workingDir };
|
||||||
|
|
||||||
|
private static async Task LoadAndWaitAsync(TasksIslandViewModel vm, ListNavItemViewModel list)
|
||||||
|
{
|
||||||
|
vm.LoadForList(list);
|
||||||
|
var deadline = DateTime.UtcNow.AddSeconds(5);
|
||||||
|
while (DateTime.UtcNow < deadline)
|
||||||
|
{
|
||||||
|
await Task.Delay(25);
|
||||||
|
if (vm.Items.Count > 0) break;
|
||||||
|
}
|
||||||
|
await Task.Delay(50);
|
||||||
|
}
|
||||||
|
|
||||||
|
private async Task<TaskEntity> GetTaskAsync(string id)
|
||||||
|
{
|
||||||
|
await using var db = NewContext();
|
||||||
|
return await db.Tasks.AsNoTracking().FirstAsync(t => t.Id == id);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Move_RunningTask_IsRejected_AndReportsError()
|
||||||
|
{
|
||||||
|
await SeedListsAsync();
|
||||||
|
await SeedTaskAsync("t1", TaskStatus.Running);
|
||||||
|
|
||||||
|
var vm = BuildViewModel();
|
||||||
|
await LoadAndWaitAsync(vm, SourceList());
|
||||||
|
string? error = null;
|
||||||
|
vm.ErrorReported += msg => error = msg;
|
||||||
|
|
||||||
|
var row = vm.Items.First(r => r.Id == "t1");
|
||||||
|
await vm.MoveTaskToListAsync(row, TargetList());
|
||||||
|
|
||||||
|
Assert.NotNull(error);
|
||||||
|
var entity = await GetTaskAsync("t1");
|
||||||
|
Assert.Equal("source", entity.ListId);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Move_TaskWithActiveWorktree_IsRejected_AndReportsError_EvenSameRepo()
|
||||||
|
{
|
||||||
|
var dir = "C:/repo";
|
||||||
|
await SeedListsAsync(dir, dir);
|
||||||
|
await SeedTaskAsync("t1", TaskStatus.Idle);
|
||||||
|
await SeedWorktreeAsync("t1", WorktreeState.Active);
|
||||||
|
|
||||||
|
var vm = BuildViewModel();
|
||||||
|
await LoadAndWaitAsync(vm, SourceList(dir));
|
||||||
|
string? error = null;
|
||||||
|
vm.ErrorReported += msg => error = msg;
|
||||||
|
|
||||||
|
var row = vm.Items.First(r => r.Id == "t1");
|
||||||
|
await vm.MoveTaskToListAsync(row, TargetList(dir));
|
||||||
|
|
||||||
|
Assert.NotNull(error);
|
||||||
|
var entity = await GetTaskAsync("t1");
|
||||||
|
Assert.Equal("source", entity.ListId);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Move_DescendantWithKeptWorktree_IsRejected()
|
||||||
|
{
|
||||||
|
await SeedListsAsync();
|
||||||
|
await SeedTaskAsync("parent", TaskStatus.Idle);
|
||||||
|
await SeedTaskAsync("child", TaskStatus.Idle, parentTaskId: "parent");
|
||||||
|
await SeedWorktreeAsync("child", WorktreeState.Kept);
|
||||||
|
|
||||||
|
var vm = BuildViewModel();
|
||||||
|
await LoadAndWaitAsync(vm, SourceList());
|
||||||
|
string? error = null;
|
||||||
|
vm.ErrorReported += msg => error = msg;
|
||||||
|
|
||||||
|
var row = vm.Items.First(r => r.Id == "parent");
|
||||||
|
await vm.MoveTaskToListAsync(row, TargetList());
|
||||||
|
|
||||||
|
Assert.NotNull(error);
|
||||||
|
var entity = await GetTaskAsync("parent");
|
||||||
|
Assert.Equal("source", entity.ListId);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Move_SameWorkingDir_MovesWithoutConfirmDialog()
|
||||||
|
{
|
||||||
|
var dir = "C:/repo";
|
||||||
|
await SeedListsAsync(dir, dir);
|
||||||
|
await SeedTaskAsync("t1", TaskStatus.Idle);
|
||||||
|
|
||||||
|
var vm = BuildViewModel();
|
||||||
|
await LoadAndWaitAsync(vm, SourceList(dir));
|
||||||
|
var dialogs = new FakeDialogService();
|
||||||
|
vm.Dialogs = dialogs;
|
||||||
|
|
||||||
|
var row = vm.Items.First(r => r.Id == "t1");
|
||||||
|
await vm.MoveTaskToListAsync(row, TargetList(dir));
|
||||||
|
|
||||||
|
Assert.Equal(0, dialogs.ConfirmCalls);
|
||||||
|
var entity = await GetTaskAsync("t1");
|
||||||
|
Assert.Equal("target", entity.ListId);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Move_BothWithoutWorkingDir_MovesWithoutConfirmDialog()
|
||||||
|
{
|
||||||
|
await SeedListsAsync();
|
||||||
|
await SeedTaskAsync("t1", TaskStatus.Idle);
|
||||||
|
|
||||||
|
var vm = BuildViewModel();
|
||||||
|
await LoadAndWaitAsync(vm, SourceList());
|
||||||
|
var dialogs = new FakeDialogService();
|
||||||
|
vm.Dialogs = dialogs;
|
||||||
|
|
||||||
|
var row = vm.Items.First(r => r.Id == "t1");
|
||||||
|
await vm.MoveTaskToListAsync(row, TargetList());
|
||||||
|
|
||||||
|
Assert.Equal(0, dialogs.ConfirmCalls);
|
||||||
|
var entity = await GetTaskAsync("t1");
|
||||||
|
Assert.Equal("target", entity.ListId);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Move_DifferentWorkingDir_AsksConfirmation_MovesOnConfirm()
|
||||||
|
{
|
||||||
|
await SeedListsAsync("C:/repoA", "C:/repoB");
|
||||||
|
await SeedTaskAsync("t1", TaskStatus.Idle);
|
||||||
|
|
||||||
|
var vm = BuildViewModel();
|
||||||
|
await LoadAndWaitAsync(vm, SourceList("C:/repoA"));
|
||||||
|
var dialogs = new FakeDialogService { ConfirmResult = true };
|
||||||
|
vm.Dialogs = dialogs;
|
||||||
|
|
||||||
|
var row = vm.Items.First(r => r.Id == "t1");
|
||||||
|
await vm.MoveTaskToListAsync(row, TargetList("C:/repoB"));
|
||||||
|
|
||||||
|
Assert.Equal(1, dialogs.ConfirmCalls);
|
||||||
|
var entity = await GetTaskAsync("t1");
|
||||||
|
Assert.Equal("target", entity.ListId);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Move_DifferentWorkingDir_CancelledConfirmation_DoesNotMove()
|
||||||
|
{
|
||||||
|
await SeedListsAsync("C:/repoA", "C:/repoB");
|
||||||
|
await SeedTaskAsync("t1", TaskStatus.Idle);
|
||||||
|
|
||||||
|
var vm = BuildViewModel();
|
||||||
|
await LoadAndWaitAsync(vm, SourceList("C:/repoA"));
|
||||||
|
var dialogs = new FakeDialogService { ConfirmResult = false };
|
||||||
|
vm.Dialogs = dialogs;
|
||||||
|
|
||||||
|
var row = vm.Items.First(r => r.Id == "t1");
|
||||||
|
await vm.MoveTaskToListAsync(row, TargetList("C:/repoB"));
|
||||||
|
|
||||||
|
Assert.Equal(1, dialogs.ConfirmCalls);
|
||||||
|
var entity = await GetTaskAsync("t1");
|
||||||
|
Assert.Equal("source", entity.ListId);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Move_TargetIsCurrentList_IsNoOp()
|
||||||
|
{
|
||||||
|
await SeedListsAsync();
|
||||||
|
await SeedTaskAsync("t1", TaskStatus.Idle);
|
||||||
|
|
||||||
|
var vm = BuildViewModel();
|
||||||
|
await LoadAndWaitAsync(vm, SourceList());
|
||||||
|
var dialogs = new FakeDialogService();
|
||||||
|
vm.Dialogs = dialogs;
|
||||||
|
|
||||||
|
var row = vm.Items.First(r => r.Id == "t1");
|
||||||
|
await vm.MoveTaskToListAsync(row, SourceList());
|
||||||
|
|
||||||
|
Assert.Equal(0, dialogs.ConfirmCalls);
|
||||||
|
var entity = await GetTaskAsync("t1");
|
||||||
|
Assert.Equal("source", entity.ListId);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Move_DifferentWorkingDir_ConfirmMessageNamesBothRepos()
|
||||||
|
{
|
||||||
|
await SeedListsAsync("C:/repoA", "C:/repoB");
|
||||||
|
await SeedTaskAsync("t1", TaskStatus.Idle);
|
||||||
|
|
||||||
|
var vm = BuildViewModel();
|
||||||
|
await LoadAndWaitAsync(vm, SourceList("C:/repoA"));
|
||||||
|
var dialogs = new FakeDialogService { ConfirmResult = false };
|
||||||
|
vm.Dialogs = dialogs;
|
||||||
|
|
||||||
|
var row = vm.Items.First(r => r.Id == "t1");
|
||||||
|
await vm.MoveTaskToListAsync(row, TargetList("C:/repoB"));
|
||||||
|
|
||||||
|
Assert.NotNull(dialogs.LastMessage);
|
||||||
|
Assert.Contains("C:/repoA", dialogs.LastMessage);
|
||||||
|
Assert.Contains("C:/repoB", dialogs.LastMessage);
|
||||||
|
}
|
||||||
|
|
||||||
|
// The source repo comes from the task's own list, not from the island's current list — those
|
||||||
|
// differ whenever a smart/virtual list is shown, and a wrong source dir would ask (or skip
|
||||||
|
// asking) for confirmation at the wrong times.
|
||||||
|
[Fact]
|
||||||
|
public async Task Move_SourceRepoIsReadFromTaskOwnList_NotCurrentList()
|
||||||
|
{
|
||||||
|
await SeedListsAsync("C:/repoA", "C:/repoA");
|
||||||
|
await SeedTaskAsync("t1", TaskStatus.Idle);
|
||||||
|
|
||||||
|
var vm = BuildViewModel();
|
||||||
|
// Island shows a virtual list carrying no working dir of its own.
|
||||||
|
await LoadAndWaitAsync(vm, SourceList(workingDir: null));
|
||||||
|
var dialogs = new FakeDialogService { ConfirmResult = true };
|
||||||
|
vm.Dialogs = dialogs;
|
||||||
|
|
||||||
|
var row = vm.Items.First(r => r.Id == "t1");
|
||||||
|
await vm.MoveTaskToListAsync(row, TargetList("C:/repoA"));
|
||||||
|
|
||||||
|
// Both lists really are the same repo, so no confirmation should have been needed.
|
||||||
|
Assert.Equal(0, dialogs.ConfirmCalls);
|
||||||
|
var entity = await GetTaskAsync("t1");
|
||||||
|
Assert.Equal("target", entity.ListId);
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task Move_TargetIsSmartList_IsNoOp()
|
||||||
|
{
|
||||||
|
await SeedListsAsync();
|
||||||
|
await SeedTaskAsync("t1", TaskStatus.Idle);
|
||||||
|
|
||||||
|
var vm = BuildViewModel();
|
||||||
|
await LoadAndWaitAsync(vm, SourceList());
|
||||||
|
|
||||||
|
var row = vm.Items.First(r => r.Id == "t1");
|
||||||
|
var smart = new ListNavItemViewModel { Id = "smart:my-day", Kind = ListKind.Smart, Name = "My Day" };
|
||||||
|
await vm.MoveTaskToListAsync(row, smart);
|
||||||
|
|
||||||
|
var entity = await GetTaskAsync("t1");
|
||||||
|
Assert.Equal("source", entity.ListId);
|
||||||
|
}
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user