feat(prime): branch PrimeRunner on the schedule action kind

This commit is contained in:
mika kuns
2026-08-25 08:44:04 +02:00
parent 71d2972a97
commit cf6a6b6208
5 changed files with 219 additions and 12 deletions
@@ -1,3 +1,4 @@
using ClaudeDo.Data.Models;
using ClaudeDo.Worker.Prime;
using ClaudeDo.Worker.Runner;
using ClaudeDo.Worker.Tests.Infrastructure;
@@ -22,6 +23,9 @@ public class PrimeRunnerTests : IDisposable
private readonly string[] _emitLines;
private readonly string? _result;
public IReadOnlyList<string>? LastArguments { get; private set; }
public string? LastPrompt { get; private set; }
public FakeClaudeProcess(TimeSpan delay = default, int exitCode = 0, string[]? emitLines = null, string? result = null)
{
_delay = delay;
@@ -37,6 +41,9 @@ public class PrimeRunnerTests : IDisposable
Func<string, Task> onStdoutLine,
CancellationToken ct)
{
LastArguments = arguments;
LastPrompt = prompt;
if (_delay > TimeSpan.Zero)
await Task.Delay(_delay, ct);
@@ -72,7 +79,10 @@ public class PrimeRunnerTests : IDisposable
broadcaster);
private static PrimeScheduleDto DefaultSchedule() =>
new(Guid.Empty, 0, TimeSpan.Zero, true, null, null);
new(Guid.Empty, 0, TimeSpan.Zero, true, null, null, PrimeActionKind.FillMyDay);
private static PrimeScheduleDto Schedule(PrimeActionKind kind, string? promptOverride = null) =>
new(Guid.Empty, 0, TimeSpan.Zero, true, null, promptOverride, kind);
[Fact]
public async Task FireAsync_returns_success_when_claude_exits_zero()
@@ -114,7 +124,7 @@ public class PrimeRunnerTests : IDisposable
var broadcaster = new RecordingPrimeBroadcaster();
var claude = new FakeClaudeProcess(emitLines: ["{\"a\":1}", "{\"b\":2}"], exitCode: 0, result: "ok");
var runner = NewRunner(claude, broadcaster);
var schedule = new PrimeScheduleDto(Guid.Empty, 0, TimeSpan.Zero, true, null, null);
var schedule = DefaultSchedule();
var outcome = await runner.FireAsync(schedule, CancellationToken.None);
@@ -133,7 +143,7 @@ public class PrimeRunnerTests : IDisposable
var claude = new FakeClaudeProcess(emitLines: new[] { "lineA", "lineB" }, exitCode: 0, result: "ok");
var runner = NewRunner(claude, new RecordingPrimeBroadcaster());
await runner.FireAsync(new PrimeScheduleDto(Guid.Empty, 0, TimeSpan.Zero, true, null, null), CancellationToken.None);
await runner.FireAsync(DefaultSchedule(), CancellationToken.None);
var contents = await File.ReadAllTextAsync(path);
Assert.Contains("lineA", contents);
@@ -142,9 +152,105 @@ public class PrimeRunnerTests : IDisposable
// Truncation: a second run with different lines replaces the file.
var claude2 = new FakeClaudeProcess(emitLines: new[] { "lineC" }, exitCode: 0, result: "ok");
var runner2 = NewRunner(claude2, new RecordingPrimeBroadcaster());
await runner2.FireAsync(new PrimeScheduleDto(Guid.Empty, 0, TimeSpan.Zero, true, null, null), CancellationToken.None);
await runner2.FireAsync(DefaultSchedule(), CancellationToken.None);
var after = await File.ReadAllTextAsync(path);
Assert.DoesNotContain("lineA", after);
Assert.Contains("lineC", after);
}
[Fact]
public async Task Ping_runs_a_single_turn_with_no_mcp_servers()
{
var claude = new FakeClaudeProcess(exitCode: 0, result: "ok");
var runner = NewRunner(claude, new RecordingPrimeBroadcaster());
var outcome = await runner.FireAsync(Schedule(PrimeActionKind.Ping), CancellationToken.None);
Assert.True(outcome.Success);
Assert.Contains("--strict-mcp-config", claude.LastArguments!);
var turnsIndex = claude.LastArguments!.ToList().IndexOf("--max-turns");
Assert.Equal("1", claude.LastArguments[turnsIndex + 1]);
Assert.DoesNotContain(DailyPrepPrompt.SetMyDayTool, claude.LastArguments);
}
[Fact]
public async Task Ping_writes_no_prep_log_and_raises_no_prep_events()
{
var path = DailyPrepPrompt.LogPath();
Directory.CreateDirectory(Path.GetDirectoryName(path)!);
await File.WriteAllTextAsync(path, "previous fill-my-day run");
var broadcaster = new RecordingPrimeBroadcaster();
var claude = new FakeClaudeProcess(emitLines: ["ping-line"], exitCode: 0, result: "ok");
var runner = NewRunner(claude, broadcaster);
await runner.FireAsync(Schedule(PrimeActionKind.Ping), CancellationToken.None);
Assert.Equal("previous fill-my-day run", await File.ReadAllTextAsync(path));
Assert.Equal(0, broadcaster.StartedCount);
Assert.Empty(broadcaster.Lines);
Assert.Empty(broadcaster.FinishedResults);
}
[Fact]
public async Task Custom_sends_the_prompt_override_verbatim_with_claudedo_mcp_only()
{
var claude = new FakeClaudeProcess(exitCode: 0, result: "ok");
var runner = NewRunner(claude, new RecordingPrimeBroadcaster());
var outcome = await runner.FireAsync(
Schedule(PrimeActionKind.Custom, "Queue the three oldest idle tasks."),
CancellationToken.None);
Assert.True(outcome.Success);
Assert.Equal("Queue the three oldest idle tasks.", claude.LastPrompt);
Assert.Contains("--allowedTools", claude.LastArguments!);
Assert.Contains("mcp__claudedo", claude.LastArguments!);
Assert.DoesNotContain("--strict-mcp-config", claude.LastArguments!);
}
[Fact]
public async Task Custom_writes_no_prep_log_and_raises_no_prep_events()
{
var path = DailyPrepPrompt.LogPath();
Directory.CreateDirectory(Path.GetDirectoryName(path)!);
await File.WriteAllTextAsync(path, "previous fill-my-day run");
var broadcaster = new RecordingPrimeBroadcaster();
var claude = new FakeClaudeProcess(emitLines: ["custom-line"], exitCode: 0, result: "ok");
var runner = NewRunner(claude, broadcaster);
await runner.FireAsync(Schedule(PrimeActionKind.Custom, "do a thing"), CancellationToken.None);
Assert.Equal("previous fill-my-day run", await File.ReadAllTextAsync(path));
Assert.Equal(0, broadcaster.StartedCount);
Assert.Empty(broadcaster.FinishedResults);
}
[Fact]
public async Task FillMyDay_still_appends_the_prompt_override()
{
var claude = new FakeClaudeProcess(exitCode: 0, result: "ok");
var runner = NewRunner(claude, new RecordingPrimeBroadcaster());
await runner.FireAsync(
Schedule(PrimeActionKind.FillMyDay, "Prefer the LogX tasks."),
CancellationToken.None);
Assert.Contains("Prefer the LogX tasks.", claude.LastPrompt);
Assert.Contains(DailyPrepPrompt.SetMyDayTool, claude.LastArguments!);
}
[Fact]
public async Task Gate_is_shared_across_kinds()
{
var runner = NewRunner(claudeDelay: TimeSpan.FromSeconds(2));
var first = runner.FireAsync(Schedule(PrimeActionKind.Ping), CancellationToken.None);
var second = await runner.FireAsync(Schedule(PrimeActionKind.FillMyDay), CancellationToken.None);
Assert.False(second.Success);
Assert.Contains("already running", second.Message, StringComparison.OrdinalIgnoreCase);
await first;
}
}