releases/ClaudeDo
2
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 39 Wiki Activity

feat(claude-do): depends_on als Menge statt Einzelfeld

Browse Source 
Ein Task kann jetzt auf beliebig viele Vorgaenger warten. Die Einzelspalte
tasks.depends_on_task_id wird durch die Beziehungstabelle task_dependencies
ersetzt (Composite-PK, beide FKs ON DELETE CASCADE -- das reproduziert das
alte ON DELETE SET NULL: geloeschter Vorgaenger = Kante weg = Task wieder
pickbar). BlockedByTaskId bleibt unberuehrt.

- Migration AddTaskDependencies kopiert jede bestehende depends_on_task_id
  verlustfrei in die Tabelle, bevor die Spalte fallengelassen wird
- QueuePicker gatet per doppelt negiertem NOT EXISTS: kein Task mit 0 Kanten
  wird blockiert, alle Kanten muessen done sein, eine Kante auf einen
  verschwundenen Task blockiert weiter
- SetDependsOnAsync ersetzt die ganze Menge; Zykluspruefung ist jetzt eine
  BFS ueber den Graphen, faengt also auch A->B->C->A
- blockedReason nennt alle offenen Vorgaenger (External/TaskBlocking, von
  ExternalMcpService und TaskWaitMcpTools gemeinsam genutzt)
- add_task/update_task nehmen dependsOnTaskIds; die alte Skalarform bleibt
  als Ein-Element-Menge inkl. ""-Clear-Sentinel gueltig
- UI: Fan-in-Zeile bleibt flach und listet alle Vorgaenger im After-Label,
  die lineare Kette rendert unveraendert
This commit is contained in:
Mika Kuns
2026-09-02 15:08:05 +02:00
parent 84d955dfc7
commit c25732cff8
31 changed files with 1893 additions and 206 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ClaudeDo.Worker.Tests/External/BatchMcpToolsTests.cs
Vendored
+1 -2
View File
@@ -408,8 +408,7 @@ public sealed class BatchMcpToolsTests : IDisposable
var listId = await SeedListAsync();
var predecessor = await SeedTaskAsync(listId, "predecessor", TaskStatus.Idle);
var task = await SeedTaskAsync(listId, "blocked", TaskStatus.Queued);
task.DependsOnTaskId = predecessor.Id;
await _tasks.UpdateAsync(task);
await _ctx.SeedDependsOnAsync(task.Id, predecessor.Id);
var sut = BuildSut();
var results = await sut.BatchGetTasks(new[] { task.Id }, cancellationToken: CancellationToken.None);
tests/ClaudeDo.Worker.Tests/External/ExternalMcpServiceTests.cs
Vendored
+101 -15
View File
@@ -118,6 +118,10 @@ public sealed class ExternalMcpServiceTests : IDisposable
return id;
}
// The dependency set has no defined order, and the ids are random GUIDs -- sort both sides.
private static List<string> Sorted(params string[] ids) => ids.OrderBy(x => x).ToList();
private static List<string> Sorted(IEnumerable<string> ids) => ids.OrderBy(x => x).ToList();
private async Task<TaskEntity> SeedTaskAsync(
string listId, string title = "t", TaskStatus status = TaskStatus.Idle, string? parentId = null)
{
@@ -444,8 +448,7 @@ public sealed class ExternalMcpServiceTests : IDisposable
var listId = await SeedListAsync();
var predecessor = await SeedTaskAsync(listId, status: TaskStatus.Idle);
var task = await SeedTaskAsync(listId, status: TaskStatus.Queued);
task.DependsOnTaskId = predecessor.Id;
await _tasks.UpdateAsync(task, CancellationToken.None);
await _ctx.SeedDependsOnAsync(task.Id, predecessor.Id);
var sut = BuildSut(CreateQueue());
var dto = await sut.GetTask(task.Id, CancellationToken.None);
@@ -460,8 +463,7 @@ public sealed class ExternalMcpServiceTests : IDisposable
var listId = await SeedListAsync();
var predecessor = await SeedTaskAsync(listId, status: TaskStatus.Done);
var task = await SeedTaskAsync(listId, status: TaskStatus.Queued);
task.DependsOnTaskId = predecessor.Id;
await _tasks.UpdateAsync(task, CancellationToken.None);
await _ctx.SeedDependsOnAsync(task.Id, predecessor.Id);
var sut = BuildSut(CreateQueue());
var dto = await sut.GetTask(task.Id, CancellationToken.None);
@@ -478,8 +480,7 @@ public sealed class ExternalMcpServiceTests : IDisposable
var listId = await SeedListAsync();
var predecessor = await SeedTaskAsync(listId, status: TaskStatus.Idle);
var task = await SeedTaskAsync(listId, status: TaskStatus.Idle);
task.DependsOnTaskId = predecessor.Id;
await _tasks.UpdateAsync(task, CancellationToken.None);
await _ctx.SeedDependsOnAsync(task.Id, predecessor.Id);
var sut = BuildSut(CreateQueue());
var dto = await sut.GetTask(task.Id, CancellationToken.None);
@@ -493,8 +494,7 @@ public sealed class ExternalMcpServiceTests : IDisposable
var listId = await SeedListAsync();
var predecessor = await SeedTaskAsync(listId, "predecessor", TaskStatus.Idle);
var blocked = await SeedTaskAsync(listId, "blocked", TaskStatus.Queued);
blocked.DependsOnTaskId = predecessor.Id;
await _tasks.UpdateAsync(blocked, CancellationToken.None);
await _ctx.SeedDependsOnAsync(blocked.Id, predecessor.Id);
var unblocked = await SeedTaskAsync(listId, "unblocked", TaskStatus.Queued);
var sut = BuildSut(CreateQueue());
@@ -513,8 +513,7 @@ public sealed class ExternalMcpServiceTests : IDisposable
var listId = await SeedListAsync();
var predecessor = await SeedTaskAsync(listId, "predecessor", TaskStatus.Idle);
var blocked = await SeedTaskAsync(listId, "blocked", TaskStatus.Queued);
blocked.DependsOnTaskId = predecessor.Id;
await _tasks.UpdateAsync(blocked, CancellationToken.None);
await _ctx.SeedDependsOnAsync(blocked.Id, predecessor.Id);
var sut = BuildSut(CreateQueue());
var result = await sut.ListTasks(listId, includeDescription: true, cancellationToken: CancellationToken.None);
@@ -555,10 +554,10 @@ public sealed class ExternalMcpServiceTests : IDisposable
var dto = await sut.UpdateTask(task.Id, dependsOnTaskId: predecessor.Id, cancellationToken: CancellationToken.None);
Assert.Equal(predecessor.Id, dto.DependsOnTaskId);
Assert.Equal([predecessor.Id], dto.DependsOnTaskIds);
Assert.True(dto.Blocked);
var loaded = await _tasks.GetByIdAsync(task.Id);
Assert.Equal(predecessor.Id, loaded!.DependsOnTaskId);
Assert.Equal([predecessor.Id], loaded!.DependsOnTaskIds);
}
[Fact]
@@ -572,7 +571,7 @@ public sealed class ExternalMcpServiceTests : IDisposable
var dto = await sut.UpdateTask(task.Id, dependsOnTaskId: "", cancellationToken: CancellationToken.None);
Assert.Null(dto.DependsOnTaskId);
Assert.Empty(dto.DependsOnTaskIds!);
Assert.False(dto.Blocked);
}
@@ -589,6 +588,75 @@ public sealed class ExternalMcpServiceTests : IDisposable
sut.UpdateTask(a.Id, dependsOnTaskId: b.Id, cancellationToken: CancellationToken.None));
}
[Fact]
public async Task UpdateTask_WithDependsOnTaskIds_SetsSeveralPredecessors()
{
var listId = await SeedListAsync();
var a = await SeedTaskAsync(listId, "a", TaskStatus.Idle);
var b = await SeedTaskAsync(listId, "b", TaskStatus.Idle);
var task = await SeedTaskAsync(listId, status: TaskStatus.Queued);
var sut = BuildSut(CreateQueue());
var dto = await sut.UpdateTask(
task.Id, dependsOnTaskIds: [a.Id, b.Id], cancellationToken: CancellationToken.None);
Assert.Equal(Sorted(a.Id, b.Id), Sorted(dto.DependsOnTaskIds!));
Assert.True(dto.Blocked);
// Naming only the first predecessor would send a caller off to unblock the wrong task.
Assert.Contains(a.Id, dto.BlockedReason);
Assert.Contains(b.Id, dto.BlockedReason);
}
[Fact]
public async Task UpdateTask_WithEmptyDependsOnTaskIds_ClearsTheWholeSet()
{
var listId = await SeedListAsync();
var a = await SeedTaskAsync(listId, "a", TaskStatus.Idle);
var b = await SeedTaskAsync(listId, "b", TaskStatus.Idle);
var task = await SeedTaskAsync(listId, status: TaskStatus.Queued);
var sut = BuildSut(CreateQueue());
await sut.UpdateTask(task.Id, dependsOnTaskIds: [a.Id, b.Id], cancellationToken: CancellationToken.None);
var dto = await sut.UpdateTask(task.Id, dependsOnTaskIds: [], cancellationToken: CancellationToken.None);
Assert.Empty(dto.DependsOnTaskIds!);
Assert.False(dto.Blocked);
}
[Fact]
public async Task UpdateTask_LegacyScalarDependsOnTaskId_StillReplacesTheWholeSet()
{
// Back-compat: existing callers and prompts only know the scalar form. It has to keep
// behaving as "this is the one predecessor", not append to whatever is already there.
var listId = await SeedListAsync();
var a = await SeedTaskAsync(listId, "a", TaskStatus.Idle);
var b = await SeedTaskAsync(listId, "b", TaskStatus.Idle);
var task = await SeedTaskAsync(listId, status: TaskStatus.Queued);
var sut = BuildSut(CreateQueue());
await sut.UpdateTask(task.Id, dependsOnTaskIds: [a.Id, b.Id], cancellationToken: CancellationToken.None);
var dto = await sut.UpdateTask(task.Id, dependsOnTaskId: a.Id, cancellationToken: CancellationToken.None);
Assert.Equal([a.Id], dto.DependsOnTaskIds);
}
[Fact]
public async Task UpdateTask_WithCyclicDependsOnTaskIds_Throws()
{
var listId = await SeedListAsync();
var a = await SeedTaskAsync(listId, "a", TaskStatus.Idle);
var b = await SeedTaskAsync(listId, "b", TaskStatus.Idle);
var c = await SeedTaskAsync(listId, "c", TaskStatus.Idle);
var innocent = await SeedTaskAsync(listId, "innocent", TaskStatus.Idle);
var sut = BuildSut(CreateQueue());
await sut.UpdateTask(b.Id, dependsOnTaskId: a.Id, cancellationToken: CancellationToken.None);
await sut.UpdateTask(c.Id, dependsOnTaskId: b.Id, cancellationToken: CancellationToken.None);
// a -> {innocent, c} closes a -> c -> b -> a over three edges.
await Assert.ThrowsAsync<InvalidOperationException>(() =>
sut.UpdateTask(a.Id, dependsOnTaskIds: [innocent.Id, c.Id], cancellationToken: CancellationToken.None));
}
[Fact]
public async Task ReviewTask_Approve_SetsDone()
{
@@ -1488,11 +1556,29 @@ public sealed class ExternalMcpServiceTests : IDisposable
var dto = await sut.AddTask(
listId, "t", dependsOnTaskId: predecessor.Id, queueImmediately: true, cancellationToken: CancellationToken.None);
Assert.Equal(predecessor.Id, dto.Task.DependsOnTaskId);
Assert.Equal([predecessor.Id], dto.Task.DependsOnTaskIds);
Assert.True(dto.Task.Blocked);
Assert.Contains(predecessor.Id, dto.Task.BlockedReason);
var loaded = await _tasks.GetByIdAsync(dto.Task.Id);
Assert.Equal(predecessor.Id, loaded!.DependsOnTaskId);
Assert.Equal([predecessor.Id], loaded!.DependsOnTaskIds);
}
[Fact]
public async Task AddTask_WithDependsOnTaskIds_PersistsEveryLink()
{
var listId = await SeedListAsync();
var a = await SeedTaskAsync(listId, "a", TaskStatus.Idle);
var b = await SeedTaskAsync(listId, "b", TaskStatus.Done);
var sut = NewService();
var dto = await sut.AddTask(
listId, "t", dependsOnTaskIds: [a.Id, b.Id], queueImmediately: true,
cancellationToken: CancellationToken.None);
Assert.Equal(Sorted(a.Id, b.Id), Sorted(dto.Task.DependsOnTaskIds!));
Assert.True(dto.Task.Blocked);
var loaded = await _tasks.GetByIdAsync(dto.Task.Id);
Assert.Equal(Sorted(a.Id, b.Id), Sorted(loaded!.DependsOnTaskIds));
}
[Fact]
tests/ClaudeDo.Worker.Tests/External/TaskWaitMcpToolsTests.cs
Vendored
+2 -4
View File
@@ -220,8 +220,7 @@ public sealed class TaskWaitMcpToolsTests : IDisposable
{
var dependency = await SeedTaskAsync(TaskStatus.Idle);
var task = await SeedTaskAsync(TaskStatus.Queued);
task.DependsOnTaskId = dependency.Id;
await _tasks.UpdateAsync(task);
await _ctx.SeedDependsOnAsync(task.Id, dependency.Id);
var sut = BuildSut();
var sw = Stopwatch.StartNew();
@@ -240,8 +239,7 @@ public sealed class TaskWaitMcpToolsTests : IDisposable
{
var dependency = await SeedTaskAsync(TaskStatus.Done);
var task = await SeedTaskAsync(TaskStatus.Queued);
task.DependsOnTaskId = dependency.Id;
await _tasks.UpdateAsync(task);
await _ctx.SeedDependsOnAsync(task.Id, dependency.Id);
var sut = BuildSut();
var sw = Stopwatch.StartNew();