releases/ClaudeDo
2
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 25 Wiki Activity

fix(ui): block delete on interactive-session tasks, clear ghost selection

Browse Source 
Delete (row context menu + detail header) now gates on HasInteractiveSession
the same way SendToQueue already does, so an open ConPTY session's claude
process can't be orphaned by deleting its task out from under it.

Row removal (in-UI delete and the delta-refresh path for externally deleted
tasks) now clears SelectedTask via SelectFrom(null, "row-removed") when the
removed row was selected, so the detail pane no longer keeps showing a
deleted task with live buttons.
This commit is contained in:
Mika Kuns
2026-08-26 15:46:40 +02:00
parent bce0c9d897
commit c1ab042d0a
6 changed files with 159 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ClaudeDo.Ui/ViewModels/Islands/TasksIslandViewModel.cs
+12 -3
View File
@@ -311,20 +311,28 @@ public sealed partial class TasksIslandViewModel : ViewModelBase, IDisposable
}
var existing = Items.FirstOrDefault(r => r.Id == taskId);
var removed = false;
if (entity is null)
{
if (existing is not null) Items.Remove(existing);
if (existing is not null) { Items.Remove(existing); removed = true; }
}
else
{
var matches = TaskMatchesList(entity, list);
if (existing is not null && matches) existing.UpdateFromEntity(entity);
else if (existing is not null) Items.Remove(existing);
else if (existing is not null) { Items.Remove(existing); removed = true; }
else if (matches) { LoadForList(list); return; }
else return;
}
// The row is gone from Items but SelectedTask (and the bound detail pane) would still
// point at it — happens when a task is deleted externally (MCP/another session) while
// selected here, since that path never runs SelectFrom(null, ...) like the in-UI delete
// does.
if (removed && SelectedTask == existing)
SelectFrom(null, "row-removed");
// Keep the parent's HasQueuedSubtasks flag in sync when a child's status flips.
if (entity is not null && !string.IsNullOrEmpty(entity.ParentTaskId))
{
@@ -1191,7 +1199,7 @@ public sealed partial class TasksIslandViewModel : ViewModelBase, IDisposable
[RelayCommand]
private async Task DeleteTaskAsync(TaskRowViewModel? row)
{
if (row is null || _worker is null) return;
if (row is null || row.HasInteractiveSession || _worker is null) return;
if (ConfirmAsync is not null)
{
var ok = await ConfirmAsync(Loc.T("vm.tasksIsland.deleteTaskConfirm", row.Title));
@@ -1216,6 +1224,7 @@ public sealed partial class TasksIslandViewModel : ViewModelBase, IDisposable
}
Items.Remove(row);
if (SelectedTask == row) SelectFrom(null, "row-removed");
Regroup();
UpdateSubtitle();
TasksChanged?.Invoke(this, EventArgs.Empty);