releases/ClaudeDo
2
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 12 Wiki Activity

refactor(worker): single parent-advance path for planning + improvement

Browse Source 
Collapse TryCompleteParentAsync (planning -> Done) and
TryAdvanceImprovementParentAsync (improvement -> WaitingForReview) into one
TryAdvanceParentAsync that surfaces any WaitingForChildren parent for review
once all children are terminal. Planning parents no longer auto-complete.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
mika kuns
2026-06-09 11:14:43 +02:00
parent 8f49ebb248
commit b3a2daf40d
6 changed files with 41 additions and 258 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
tests/ClaudeDo.Worker.Tests/WaitingForChildrenLifecycleTests.cs
View File

@@ -126,4 +126,38 @@ public sealed class WaitingForChildrenLifecycleTests : IDisposable
var result = await _built.State.EnqueueAsync("kid", default);
Assert.False(result.Ok);
}
[Fact]
public async Task SequentialChildren_parent_only_advances_after_both_are_terminal()
{
// Arrange: parent WaitingForChildren, child1 Done, child2 blocked by child1 (Running)
using (var ctx = _db.CreateContext())
{
ctx.Lists.Add(new ListEntity { Id = "l1", Name = "L", CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent",
Status = TaskStatus.WaitingForChildren, CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "c1", ListId = "l1", Title = "Child1",
Status = TaskStatus.Running, ParentTaskId = "par", CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "c2", ListId = "l1", Title = "Child2",
Status = TaskStatus.Running, ParentTaskId = "par", BlockedByTaskId = "c1",
CreatedAt = DateTime.UtcNow });
await ctx.SaveChangesAsync();
}
// Act: complete child1 — parent must stay WaitingForChildren because child2 is still running
await _built.State.CompleteAsync("c1", DateTime.UtcNow, "c1 ok", default);
using (var ctx = _db.CreateContext())
{
var par = await new TaskRepository(ctx).GetByIdAsync("par");
Assert.Equal(TaskStatus.WaitingForChildren, par!.Status);
}
// Act: complete child2 — now all children are terminal; parent must advance
await _built.State.CompleteAsync("c2", DateTime.UtcNow, "c2 ok", default);
using (var ctx = _db.CreateContext())
{
var par = await new TaskRepository(ctx).GetByIdAsync("par");
Assert.Equal(TaskStatus.WaitingForReview, par!.Status);
}
}
}