releases/ClaudeDo
2
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 24 Wiki Activity

feat(data): add task numbers schema, allocator, and backfill migration

Browse Source 
TaskEntity.Number is a global, monotonically increasing, never-reused
integer (displayed as #123), allocated from AppSettingsEntity.NextTaskNumber
via a single UPDATE...RETURNING statement rather than MAX(number)+1, which
would reissue a deleted task's number. Both insert paths (TaskRepository.
AddAsync and CreateChildAsync) route through the new TaskNumberAllocator,
with a bounded retry on a unique-index collision. One migration adds the
columns, backfills existing rows in creation order, and creates the unique
index afterwards. Data-layer only; MCP/UI wiring is later slices.
This commit is contained in:
mika kuns
2026-08-11 10:49:06 +02:00
parent 31a9e87b56
commit 9e46c96b24
25 changed files with 1416 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ClaudeDo.Worker.Tests/WaitingForChildrenLifecycleTests.cs
+17 -14
View File
@@ -13,6 +13,7 @@ public sealed class WaitingForChildrenLifecycleTests : IDisposable
private readonly DbFixture _db = new();
private readonly TestDbContextFactory _factory;
private readonly TaskStateServiceBuilder.Built _built;
private int _numberSeed;
public WaitingForChildrenLifecycleTests()
{
@@ -25,7 +26,7 @@ public sealed class WaitingForChildrenLifecycleTests : IDisposable
{
using var ctx = _db.CreateContext();
ctx.Lists.Add(new ListEntity { Id = "l1", Name = "L", CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "p1", ListId = "l1", Title = "Parent",
ctx.Tasks.Add(new TaskEntity { Id = "p1", ListId = "l1", Title = "Parent", Number = ++_numberSeed,
Status = TaskStatus.Running, CreatedAt = DateTime.UtcNow });
await ctx.SaveChangesAsync();
return "p1";
@@ -58,11 +59,11 @@ public sealed class WaitingForChildrenLifecycleTests : IDisposable
using var ctx = _db.CreateContext();
if (!ctx.Lists.Any())
ctx.Lists.Add(new ListEntity { Id = "l1", Name = "L", CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent",
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent", Number = ++_numberSeed,
Status = Enum.Parse<TaskStatus>(parentStatus), Result = "parent ran", CreatedAt = DateTime.UtcNow });
int i = 0;
foreach (var cs in childStatuses)
ctx.Tasks.Add(new TaskEntity { Id = $"c{i++}", ListId = "l1", Title = "Child",
ctx.Tasks.Add(new TaskEntity { Id = $"c{i++}", ListId = "l1", Title = "Child", Number = ++_numberSeed,
Status = cs, ParentTaskId = "par", CreatedAt = DateTime.UtcNow });
await ctx.SaveChangesAsync();
}
@@ -103,9 +104,9 @@ public sealed class WaitingForChildrenLifecycleTests : IDisposable
using var ctx = _db.CreateContext();
if (!ctx.Lists.Any())
ctx.Lists.Add(new ListEntity { Id = "l1", Name = "L", CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent",
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent", Number = ++_numberSeed,
Status = TaskStatus.WaitingForChildren, PlanningPhase = parentPhase, CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "kid", ListId = "l1", Title = "Child",
ctx.Tasks.Add(new TaskEntity { Id = "kid", ListId = "l1", Title = "Child", Number = ++_numberSeed,
Status = TaskStatus.Idle, ParentTaskId = "par", CreatedAt = DateTime.UtcNow });
await ctx.SaveChangesAsync();
}
@@ -135,11 +136,11 @@ public sealed class WaitingForChildrenLifecycleTests : IDisposable
using (var ctx = _db.CreateContext())
{
ctx.Lists.Add(new ListEntity { Id = "l1", Name = "L", CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent",
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent", Number = ++_numberSeed,
Status = TaskStatus.WaitingForChildren, CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "c1", ListId = "l1", Title = "Child1",
ctx.Tasks.Add(new TaskEntity { Id = "c1", ListId = "l1", Title = "Child1", Number = ++_numberSeed,
Status = TaskStatus.Running, ParentTaskId = "par", CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "c2", ListId = "l1", Title = "Child2",
ctx.Tasks.Add(new TaskEntity { Id = "c2", ListId = "l1", Title = "Child2", Number = ++_numberSeed,
Status = TaskStatus.Running, ParentTaskId = "par", BlockedByTaskId = "c1",
CreatedAt = DateTime.UtcNow });
await ctx.SaveChangesAsync();
@@ -168,7 +169,7 @@ public sealed class WaitingForChildrenLifecycleTests : IDisposable
using (var ctx = _db.CreateContext())
{
ctx.Lists.Add(new ListEntity { Id = "l1", Name = "L", CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent",
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent", Number = ++_numberSeed,
Status = TaskStatus.WaitingForChildren, CreatedAt = DateTime.UtcNow });
await ctx.SaveChangesAsync();
}
@@ -189,11 +190,11 @@ public sealed class WaitingForChildrenLifecycleTests : IDisposable
using (var ctx = _db.CreateContext())
{
ctx.Lists.Add(new ListEntity { Id = "l1", Name = "L", CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent",
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent", Number = ++_numberSeed,
Status = TaskStatus.WaitingForChildren, CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "c_running", ListId = "l1", Title = "Running child",
ctx.Tasks.Add(new TaskEntity { Id = "c_running", ListId = "l1", Title = "Running child", Number = ++_numberSeed,
Status = TaskStatus.Running, ParentTaskId = "par", CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "c_queued", ListId = "l1", Title = "Queued child",
ctx.Tasks.Add(new TaskEntity { Id = "c_queued", ListId = "l1", Title = "Queued child", Number = ++_numberSeed,
Status = TaskStatus.Queued, ParentTaskId = "par", BlockedByTaskId = "c_running",
CreatedAt = DateTime.UtcNow });
await ctx.SaveChangesAsync();
@@ -220,9 +221,9 @@ public sealed class WaitingForChildrenLifecycleTests : IDisposable
using (var ctx = _db.CreateContext())
{
ctx.Lists.Add(new ListEntity { Id = "l1", Name = "L", CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent",
ctx.Tasks.Add(new TaskEntity { Id = "par", ListId = "l1", Title = "Parent", Number = ++_numberSeed,
Status = TaskStatus.WaitingForChildren, CreatedAt = DateTime.UtcNow });
ctx.Tasks.Add(new TaskEntity { Id = "c_running", ListId = "l1", Title = "Running child",
ctx.Tasks.Add(new TaskEntity { Id = "c_running", ListId = "l1", Title = "Running child", Number = ++_numberSeed,
Status = TaskStatus.Running, ParentTaskId = "par", CreatedAt = DateTime.UtcNow });
await ctx.SaveChangesAsync();
}
@@ -261,6 +262,7 @@ public sealed class WaitingForChildrenLifecycleTests : IDisposable
Id = id,
ListId = "l1",
Title = "Parent",
Number = ++_numberSeed,
Status = TaskStatus.Idle,
PlanningPhase = PlanningPhase.Active,
CreatedAt = DateTime.UtcNow,
@@ -277,6 +279,7 @@ public sealed class WaitingForChildrenLifecycleTests : IDisposable
Id = childId,
ListId = "l1",
Title = "Child",
Number = ++_numberSeed,
Status = status,
ParentTaskId = parentId,
CreatedAt = DateTime.UtcNow,