releases/ClaudeDo
2
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 39 Wiki Activity

fix(worker): add failureReason field to batch_get_tasks

Browse Source 
The tool description claimed Failed tasks carry failureReason, but the field
was missing from BatchTaskDetailDto and rejected when requested in `fields`.
Add failureReason to the DTO, KnownDetailFields, and BuildDetail so list
handlers and other callers can read failure reasons without per-task get_task
calls. Tested: 31 BatchMcpToolsTests pass, including two new cases for
failureReason retrieval on Failed and Idle tasks.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
Mika Kuns
2026-09-02 12:20:02 +02:00
co-authored by Claude Haiku 4.5
parent 56bc1651a8
commit 912201770f
2 changed files with 37 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ClaudeDo.Worker.Tests/External/BatchMcpToolsTests.cs
Vendored
+34
View File
@@ -623,4 +623,38 @@ public sealed class BatchMcpToolsTests : IDisposable
Assert.Equal(2, progress.Reports.Count);
Assert.Equal(2, progress.Reports[1].Total);
}
[Fact]
public async Task BatchGetTasks_FailedTaskWithFailureReason_ReturnsReasonWhenRequested()
{
var listId = await SeedListAsync();
var task = await SeedTaskAsync(listId, "failed", TaskStatus.Failed);
task.FailureReason = "max-turns-exceeded";
await _tasks.UpdateAsync(task);
var sut = BuildSut();
var results = await sut.BatchGetTasks(
new[] { task.Id }, includeDescription: true, fields: new[] { "failureReason" },
cancellationToken: CancellationToken.None);
var found = results.Single(r => r.Id == task.Id).TaskFull!;
Assert.Equal("max-turns-exceeded", found.FailureReason);
Assert.Null(found.Description);
Assert.Null(found.Status);
}
[Fact]
public async Task BatchGetTasks_IdleTaskWithoutFailureReason_ReturnsNullWhenRequested()
{
var listId = await SeedListAsync();
var task = await SeedTaskAsync(listId, "idle", TaskStatus.Idle);
var sut = BuildSut();
var results = await sut.BatchGetTasks(
new[] { task.Id }, includeDescription: true, fields: new[] { "failureReason" },
cancellationToken: CancellationToken.None);
var found = results.Single(r => r.Id == task.Id).TaskFull!;
Assert.Null(found.FailureReason);
}
}