chore(claude-do): merge feat(ui): Erststart-Banner und Textkette Repo→Task→Queue→Rev

ClaudeDo-Task: 60ad0392-ef5e-4204-9445-415788ccd45b
This commit is contained in:
mika kuns
2026-08-21 15:54:21 +02:00
6 changed files with 244 additions and 13 deletions
+6 -3
View File
@@ -221,8 +221,8 @@
"rerun": "Erneut ausführen", "rerun": "Erneut ausführen",
"refineTip": "Aufgabe mit Claude verfeinern", "refineTip": "Aufgabe mit Claude verfeinern",
"refiningTip": "Claude verfeinert diese Aufgabe…", "refiningTip": "Claude verfeinert diese Aufgabe…",
"emptyHint": "Noch keine Aufgaben. Oben eine hinzufügen oder in die Warteschlange einreihen, wenn du bereit bist.", "emptyHint": "Noch keine Aufgaben. Lege eine an und wähle per Rechtsklick „In Warteschlange einreihen" Claude bearbeitet sie in einem eigenen Worktree.",
"emptyHintNoWorkingDir": "Verknüpfe ein Repo in den Listeneinstellungen, um Warteschlange, „Claude machen lassen" und die Schnell-Sitzung zu aktivieren." "emptyHintNoWorkingDir": "Diese Liste hat kein Repo in den Listeneinstellungen verknüpfen, um die Warteschlange zu aktivieren."
}, },
"lists": { "lists": {
"heading": "Listen", "heading": "Listen",
@@ -237,7 +237,9 @@
"contextOpenFindings": "Findings-Ordner öffnen", "contextOpenFindings": "Findings-Ordner öffnen",
"contextSettings": "Einstellungen", "contextSettings": "Einstellungen",
"newList": "Neue Liste", "newList": "Neue Liste",
"addReposTip": "Repos als Listen hinzufügen" "addReposTip": "Repos als Listen hinzufügen",
"noRepoBannerText": "Noch kein Repo verknüpft. ClaudeDo führt Tasks in einem Git-Repo aus.",
"noRepoBannerButton": "Repo importieren"
}, },
"details": { "details": {
"deleteTaskTip": "Aufgabe löschen", "deleteTaskTip": "Aufgabe löschen",
@@ -309,6 +311,7 @@
"reviewContinueTip": "Dieses Feedback senden und die Aufgabe erneut ausführen", "reviewContinueTip": "Dieses Feedback senden und die Aufgabe erneut ausführen",
"reviewResetTip": "Alle Änderungen verwerfen und die Aufgabe auf Leerlauf zurücksetzen", "reviewResetTip": "Alle Änderungen verwerfen und die Aufgabe auf Leerlauf zurücksetzen",
"mergeDrainHint": "Merge zieht Subtasks ein Abbrechen entsperrt sich danach", "mergeDrainHint": "Merge zieht Subtasks ein Abbrechen entsperrt sich danach",
"approveMergesUnitHint": "Approve mergt das gleich in den Zielbranch danach folgt kein separater Merge-Schritt.",
"continueNoSessionTip": "Setzt den letzten Lauf fort benötigt eine vorherige Session", "continueNoSessionTip": "Setzt den letzten Lauf fort benötigt eine vorherige Session",
"resetAndRetryInteractiveTip": "Interaktive Sitzung ist offen erst schließen", "resetAndRetryInteractiveTip": "Interaktive Sitzung ist offen erst schließen",
"reviewFeedbackPlaceholder": "Feedback für nächsten Lauf" "reviewFeedbackPlaceholder": "Feedback für nächsten Lauf"
+6 -3
View File
@@ -221,8 +221,8 @@
"rerun": "Re-run", "rerun": "Re-run",
"refineTip": "Refine this task with Claude", "refineTip": "Refine this task with Claude",
"refiningTip": "Claude is refining this task…", "refiningTip": "Claude is refining this task…",
"emptyHint": "No tasks yet. Add one above, or send it to the queue once you're ready.", "emptyHint": "No tasks yet. Add one, then right-click it and choose \"Send to queue\" — Claude works it in its own worktree.",
"emptyHintNoWorkingDir": "Link a repo in List Settings to enable the queue, Let Claude handle it, and Quick session." "emptyHintNoWorkingDir": "This list has no repo yet — link one in List Settings to enable the queue."
}, },
"lists": { "lists": {
"heading": "Lists", "heading": "Lists",
@@ -237,7 +237,9 @@
"contextOpenFindings": "Open findings folder", "contextOpenFindings": "Open findings folder",
"contextSettings": "Settings…", "contextSettings": "Settings…",
"newList": "New list", "newList": "New list",
"addReposTip": "Add repos as lists" "addReposTip": "Add repos as lists",
"noRepoBannerText": "No repo linked yet. ClaudeDo runs tasks in a git repo.",
"noRepoBannerButton": "Import repo"
}, },
"details": { "details": {
"deleteTaskTip": "Delete task", "deleteTaskTip": "Delete task",
@@ -310,6 +312,7 @@
"reviewResetTip": "Discard all changes and reset the task to Idle", "reviewResetTip": "Discard all changes and reset the task to Idle",
"reviewFeedbackPlaceholder": "Feedback for next run", "reviewFeedbackPlaceholder": "Feedback for next run",
"mergeDrainHint": "Merge is draining subtasks — Cancel unlocks once it finishes", "mergeDrainHint": "Merge is draining subtasks — Cancel unlocks once it finishes",
"approveMergesUnitHint": "Approve also merges this into the target branch right away — there's no separate merge step after it.",
"continueNoSessionTip": "Resumes the last run — needs a previous session to continue", "continueNoSessionTip": "Resumes the last run — needs a previous session to continue",
"resetAndRetryInteractiveTip": "Interactive session is open — close it first" "resetAndRetryInteractiveTip": "Interactive session is open — close it first"
}, },
@@ -186,6 +186,14 @@ public sealed partial class ListsIslandViewModel : ViewModelBase, IDisposable
[ObservableProperty] private string _searchText = ""; [ObservableProperty] private string _searchText = "";
[ObservableProperty] private ListNavItemViewModel? _selectedList; [ObservableProperty] private ListNavItemViewModel? _selectedList;
/// <summary>True whenever no User list has a linked <c>WorkingDir</c> — drives the no-repo
/// banner. Smart/Virtual lists never count. Recomputed after every load and every
/// list CRUD / list-settings save; never persisted, no dismiss state.</summary>
[ObservableProperty] private bool _hasNoLinkedRepo = true;
private void RecomputeHasNoLinkedRepo() =>
HasNoLinkedRepo = UserLists.All(r => string.IsNullOrWhiteSpace(r.WorkingDir));
public string UserName { get; } = Environment.UserName; public string UserName { get; } = Environment.UserName;
public string MachineName { get; } = Environment.MachineName; public string MachineName { get; } = Environment.MachineName;
public string MachineNameLocal => Loc.T("vm.lists.localSuffix", MachineName); public string MachineNameLocal => Loc.T("vm.lists.localSuffix", MachineName);
@@ -291,6 +299,7 @@ public sealed partial class ListsIslandViewModel : ViewModelBase, IDisposable
} }
finally { OperationTiming.Shared.Record("db", "ListsIsland.LoadAsync", sw.Elapsed, ok); } finally { OperationTiming.Shared.Record("db", "ListsIsland.LoadAsync", sw.Elapsed, ok); }
RecomputeHasNoLinkedRepo();
await RefreshCountsAsync(ct); await RefreshCountsAsync(ct);
SelectedList = Items.FirstOrDefault(); SelectedList = Items.FirstOrDefault();
} }
@@ -372,6 +381,7 @@ public sealed partial class ListsIslandViewModel : ViewModelBase, IDisposable
Items.Add(item); Items.Add(item);
UserLists.Add(item); UserLists.Add(item);
SelectedList = item; SelectedList = item;
RecomputeHasNoLinkedRepo();
if (Dialogs is not null && _services is not null) if (Dialogs is not null && _services is not null)
{ {
@@ -474,6 +484,7 @@ public sealed partial class ListsIslandViewModel : ViewModelBase, IDisposable
row.DefaultCommitType = entity.DefaultCommitType; row.DefaultCommitType = entity.DefaultCommitType;
row.IsManual = entity.IsManual; row.IsManual = entity.IsManual;
row.FindingsTracked = entity.FindingsTracked; row.FindingsTracked = entity.FindingsTracked;
RecomputeHasNoLinkedRepo();
} }
catch { /* best-effort refresh */ } catch { /* best-effort refresh */ }
} }
@@ -505,5 +516,6 @@ public sealed partial class ListsIslandViewModel : ViewModelBase, IDisposable
UserLists.Insert(insertAt, item); UserLists.Insert(insertAt, item);
Items.Insert(SmartLists.Count + insertAt, item); Items.Insert(SmartLists.Count + insertAt, item);
RecomputeHasNoLinkedRepo();
} }
} }
@@ -371,13 +371,16 @@
IsVisible="{Binding Merge.ShowMergeSection}" /> IsVisible="{Binding Merge.ShowMergeSection}" />
<!-- Gate: you must open the diff before Approve & Merge unlocks. --> <!-- Gate: you must open the diff before Approve & Merge unlocks. -->
<StackPanel Orientation="Horizontal" Spacing="6" <StackPanel Spacing="2" IsVisible="{Binding ShowReviewDiffHint}">
IsVisible="{Binding ShowReviewDiffHint}"> <StackPanel Orientation="Horizontal" Spacing="6">
<PathIcon Data="{StaticResource Icon.ArrowOut}" Width="11" Height="11" <PathIcon Data="{StaticResource Icon.ArrowOut}" Width="11" Height="11"
Foreground="{DynamicResource AmberBrush}" VerticalAlignment="Center" /> Foreground="{DynamicResource AmberBrush}" VerticalAlignment="Center" />
<TextBlock Classes="meta" VerticalAlignment="Center" <TextBlock Classes="meta" VerticalAlignment="Center"
Foreground="{DynamicResource AmberBrush}" Foreground="{DynamicResource AmberBrush}"
Text="Open the diff to enable merge" /> Text="Open the diff to enable merge" />
</StackPanel>
<TextBlock Classes="meta" Margin="17,0,0,0"
Text="{loc:Tr session.approveMergesUnitHint}" />
</StackPanel> </StackPanel>
<!-- Gate: a unit merge is draining this task's subtasks, so Cancel is locked <!-- Gate: a unit merge is draining this task's subtasks, so Cancel is locked
@@ -30,6 +30,24 @@
</StackPanel> </StackPanel>
</Border> </Border>
<!-- ── No-repo banner — visible until any User list has a linked working dir; no
dismiss, no persisted state, comes back if the last repo link is removed. ── -->
<Border DockPanel.Dock="Top"
IsVisible="{Binding HasNoLinkedRepo}"
Margin="12,0,12,12"
Background="{DynamicResource DeepBrush}"
BorderBrush="{DynamicResource LineBrush}"
BorderThickness="1"
CornerRadius="6"
Padding="14,10">
<StackPanel Spacing="8">
<TextBlock Classes="body" Text="{loc:Tr lists.noRepoBannerText}" TextWrapping="Wrap"/>
<Button Classes="btn" HorizontalAlignment="Right"
Content="{loc:Tr lists.noRepoBannerButton}"
Command="{Binding OpenRepoImportCommand}"/>
</StackPanel>
</Border>
<!-- ── Footer ── --> <!-- ── Footer ── -->
<Border DockPanel.Dock="Bottom" <Border DockPanel.Dock="Bottom"
BorderBrush="{DynamicResource LineBrush}" BorderThickness="0,1,0,0" BorderBrush="{DynamicResource LineBrush}" BorderThickness="0,1,0,0"
@@ -0,0 +1,192 @@
using ClaudeDo.Data;
using ClaudeDo.Data.Models;
using ClaudeDo.Localization;
using ClaudeDo.Ui.Localization;
using ClaudeDo.Ui.Services;
using ClaudeDo.Ui.ViewModels.Islands;
using Microsoft.EntityFrameworkCore;
namespace ClaudeDo.Ui.Tests.ViewModels;
// UX-Struktur Paket C, C1: HasNoLinkedRepo drives the no-repo banner in ListsIslandView — true
// whenever no User list has a WorkingDir, recomputed after list load and after list CRUD /
// list-settings save (never persisted, no dismiss).
public class ListsIslandHasNoLinkedRepoTests : IDisposable
{
private readonly string _dbPath;
public ListsIslandHasNoLinkedRepoTests()
{
_dbPath = Path.Combine(Path.GetTempPath(), $"claudedo_lists_norepo_test_{Guid.NewGuid():N}.db");
using var ctx = NewContext();
ctx.Database.EnsureCreated();
var dir = AppContext.BaseDirectory;
while (dir is not null && !Directory.Exists(Path.Combine(dir, "src", "ClaudeDo.Localization", "locales")))
dir = Path.GetDirectoryName(dir);
Loc.Current = new Localizer(
LocaleStore.Load(Path.Combine(dir!, "src", "ClaudeDo.Localization", "locales")), "en");
}
public void Dispose()
{
try { File.Delete(_dbPath); } catch { }
try { File.Delete(_dbPath + "-wal"); } catch { }
try { File.Delete(_dbPath + "-shm"); } catch { }
}
private ClaudeDoDbContext NewContext()
{
var opts = new DbContextOptionsBuilder<ClaudeDoDbContext>()
.UseSqlite($"Data Source={_dbPath}")
.Options;
return new ClaudeDoDbContext(opts);
}
private sealed class TestDbFactory : IDbContextFactory<ClaudeDoDbContext>
{
private readonly Func<ClaudeDoDbContext> _create;
public TestDbFactory(Func<ClaudeDoDbContext> create) => _create = create;
public ClaudeDoDbContext CreateDbContext() => _create();
}
private sealed class FakeWorker : StubWorkerClient
{
public override bool IsConnected => true;
}
private async Task<ListEntity> SeedListAsync(string id, string name, string? workingDir = null)
{
await using var db = NewContext();
var entity = new ListEntity { Id = id, Name = name, WorkingDir = workingDir, CreatedAt = DateTime.UtcNow };
db.Lists.Add(entity);
await db.SaveChangesAsync();
return entity;
}
[Fact]
public async Task NoLists_HasNoLinkedRepo_IsTrue()
{
var vm = new ListsIslandViewModel(new TestDbFactory(NewContext));
await vm.LoadAsync();
Assert.True(vm.HasNoLinkedRepo);
}
[Fact]
public async Task OnlyNonUserSeedLists_HasNoLinkedRepo_IsTrue()
{
// "My Day"/"Important"/"Planned" are excluded from UserLists by name — they must not
// count as a linked repo even if (hypothetically) one had a WorkingDir.
await SeedListAsync("seed-my-day", "My Day", workingDir: @"C:\some\repo");
var vm = new ListsIslandViewModel(new TestDbFactory(NewContext));
await vm.LoadAsync();
Assert.Empty(vm.UserLists);
Assert.True(vm.HasNoLinkedRepo);
}
[Fact]
public async Task UserListWithoutWorkingDir_HasNoLinkedRepo_IsTrue()
{
await SeedListAsync("no-dir", "No Dir");
var vm = new ListsIslandViewModel(new TestDbFactory(NewContext));
await vm.LoadAsync();
Assert.True(vm.HasNoLinkedRepo);
}
[Fact]
public async Task UserListWithWorkingDir_HasNoLinkedRepo_IsFalse()
{
await SeedListAsync("has-dir", "Has Dir", workingDir: @"C:\some\repo");
var vm = new ListsIslandViewModel(new TestDbFactory(NewContext));
await vm.LoadAsync();
Assert.False(vm.HasNoLinkedRepo);
}
[Fact]
public async Task CreateListAsync_OnEmptyBoard_KeepsHasNoLinkedRepoTrue()
{
var vm = new ListsIslandViewModel(new TestDbFactory(NewContext));
await vm.LoadAsync();
Assert.True(vm.HasNoLinkedRepo);
// No Dialogs/service provider wired — CreateListAsync must still recompute the flag from
// the newly-added (working-dir-less) row, not leave it stale.
await vm.CreateListCommand.ExecuteAsync(null);
Assert.True(vm.HasNoLinkedRepo);
}
[Fact]
public async Task DeletingTheOnlyLinkedRepoList_ThenReloading_RecomputesToTrue()
{
var entity = await SeedListAsync("has-dir", "Has Dir", workingDir: @"C:\some\repo");
var vm = new ListsIslandViewModel(new TestDbFactory(NewContext));
await vm.LoadAsync();
Assert.False(vm.HasNoLinkedRepo);
// List Settings' delete path removes the DB row, then the caller reloads (see
// OpenListSettingsAsync/CreateListAsync: `if (vm.Deleted) await LoadAsync();`).
await using (var db = NewContext())
{
db.Lists.Remove(db.Lists.Find(entity.Id)!);
await db.SaveChangesAsync();
}
await vm.LoadAsync();
Assert.True(vm.HasNoLinkedRepo);
}
[Fact]
public async Task ListSettingsSave_LinkingWorkingDir_RecomputesToFalse()
{
var entity = await SeedListAsync("no-dir-yet", "No Dir Yet");
var worker = new FakeWorker();
var vm = new ListsIslandViewModel(new TestDbFactory(NewContext), worker: worker);
await vm.LoadAsync();
Assert.True(vm.HasNoLinkedRepo);
// Simulate a List Settings save linking a working dir — the worker broadcasts the same
// ListUpdated event a real save triggers, driving RefreshRowAsync.
await using (var db = NewContext())
{
var row = await db.Lists.FindAsync(entity.Id);
row!.WorkingDir = @"C:\some\repo";
await db.SaveChangesAsync();
}
worker.RaiseListUpdated(entity.Id);
await Task.Delay(100);
Assert.False(vm.HasNoLinkedRepo);
}
[Fact]
public async Task ListSettingsSave_RemovingLastWorkingDir_RecomputesToTrue()
{
var entity = await SeedListAsync("has-dir", "Has Dir", workingDir: @"C:\some\repo");
var worker = new FakeWorker();
var vm = new ListsIslandViewModel(new TestDbFactory(NewContext), worker: worker);
await vm.LoadAsync();
Assert.False(vm.HasNoLinkedRepo);
await using (var db = NewContext())
{
var row = await db.Lists.FindAsync(entity.Id);
row!.WorkingDir = null;
await db.SaveChangesAsync();
}
worker.RaiseListUpdated(entity.Id);
await Task.Delay(100);
Assert.True(vm.HasNoLinkedRepo);
}
}