releases/ClaudeDo
2
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 24 Wiki Activity

fix(releases): don't drop the prerelease marker when comparing versions

Browse Source 
A MinVer dev build on main computes a prerelease of its own guessed next
version (e.g. 2.9.1-alpha.0.14 after tag v2.9.0), which already sorts
above the last tag by numeric core, so the update banner correctly
stays quiet there. But the reduction to a bare numeric core meant a
genuine new release landing at exactly that guessed version (v2.9.1
real) compared equal to the still-running prerelease and the banner
never fired. A prerelease now only loses to a real release of the same
core, not to another prerelease of the same core.

Verified against the live repo: latest published tag is v2.9.0; a
Release build of this worktree (14 commits ahead) reports
AssemblyInformationalVersion 2.9.1-alpha.0.14+<sha>.
This commit is contained in:
mika kuns
2026-08-10 14:27:23 +02:00
parent 6a2a19cc9e
commit 84715665c2
3 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ClaudeDo.Releases.Tests/VersionComparerTests.cs
+9
View File
@@ -17,6 +17,15 @@ public class VersionComparerTests
[InlineData("v1.0.2-alpha+1c764dae", "1.0.0", true, false)] // v-prefix + prerelease + build metadata combined
[InlineData("1.0.2-alpha+abc", "1.0.2-alpha", false, false)] // same core -> not newer
[InlineData("1.2.0-rc1", "1.2.0", false, false)] // prerelease of an already-installed release
// A dev build sitting on main computes a MinVer prerelease of its own guessed next
// version, ahead of the last tag by core -> no banner (real-world repro: latest
// published tag v2.9.0, worktree 14 commits ahead builds "2.9.1-alpha.0.14+sha").
[InlineData("2.9.0", "2.9.1-alpha.0.14", false, false)]
// A genuine new release lands at exactly the version a running dev build had
// already guessed -> the release must still win over the still-running prerelease.
[InlineData("1.4.1", "1.4.1-alpha.0.12", true, false)]
// An installed real release exactly matching the latest tag stays "up to date".
[InlineData("1.4.1", "1.4.1", false, false)]
public void Compare_ParseableVersions(string latest, string current, bool expectedNewer, bool expectedUnparseable)
{
var result = VersionComparer.Compare(latest, current);