refactor: delete unreachable members and redundant package refs

Eight public members had no caller anywhere in src: GitService.GetFileDiffAsync,
SubtaskRepository.DeleteByTaskIdAsync, TaskRepository.GetByListAsync (a
backwards-compat alias for GetByListIdAsync) and .GetByCreatorAsync,
WorktreeRepository.GetByStatesAsync, TaskMonitorViewModel.SetPendingQuestion
(a duplicate of the live-event lambda), PrimeClaudeTabViewModel.ApplyFiredEvent,
and StreamLineFormatter.FormatFile. TaskAttachmentRepository.DeleteAllForTaskAsync
was reachable only from its own test; the ON DELETE CASCADE on task_attachments
already covers it. Tests for the deleted members go with them.

Dropped two package refs the platform already provides: EntityFrameworkCore.Design
in Worker (the design-time factory and the migrations live in Data, which has its
own ref) and System.IO.FileSystem.AccessControl in Installer.Tests (net8.0-windows
ships the ACL APIs in the shared framework).
This commit is contained in:
mika kuns
2026-08-26 10:11:46 +02:00
parent a1d74ab45d
commit 81994aadca
13 changed files with 3 additions and 130 deletions
@@ -86,19 +86,6 @@ public sealed class TaskAttachmentRepositoryTests : IDisposable
Assert.Null(result);
}
[Fact]
public async Task DeleteAllForTask_clears_all_rows_for_task()
{
await _repo.AddAsync(MakeAttachment("a.txt"));
await _repo.AddAsync(MakeAttachment("b.txt"));
await _repo.AddAsync(MakeAttachment("c.txt"));
await _repo.DeleteAllForTaskAsync(TaskId);
var list = await _repo.ListByTaskIdAsync(TaskId);
Assert.Empty(list);
}
[Fact]
public async Task ListByTaskId_ordered_by_created_at()
{