refactor: delete unreachable members and redundant package refs

Eight public members had no caller anywhere in src: GitService.GetFileDiffAsync,
SubtaskRepository.DeleteByTaskIdAsync, TaskRepository.GetByListAsync (a
backwards-compat alias for GetByListIdAsync) and .GetByCreatorAsync,
WorktreeRepository.GetByStatesAsync, TaskMonitorViewModel.SetPendingQuestion
(a duplicate of the live-event lambda), PrimeClaudeTabViewModel.ApplyFiredEvent,
and StreamLineFormatter.FormatFile. TaskAttachmentRepository.DeleteAllForTaskAsync
was reachable only from its own test; the ON DELETE CASCADE on task_attachments
already covers it. Tests for the deleted members go with them.

Dropped two package refs the platform already provides: EntityFrameworkCore.Design
in Worker (the design-time factory and the migrations live in Data, which has its
own ref) and System.IO.FileSystem.AccessControl in Installer.Tests (net8.0-windows
ships the ACL APIs in the shared framework).

src/ClaudeDo.Data/CLAUDE.md

@@ -53,7 +53,7 @@ Worker's `QueuePicker` (`FromSqlRaw`), **not** here.
 - **TaskRepository** — CRUD, planning helpers (`CreateChildAsync`, `SetPlanningStartedAsync`, `DiscardPlanningAsync`, `UpdateChildAsync`), `UpdateAgentSettingsAsync`. ⚠️ Status-mutation primitives (`MarkRunningAsync`/`MarkDoneAsync`/`MarkFailedAsync`/`FlipAllRunningToFailedAsync`) are **`internal`** — only the Worker's `TaskStateService` may call them. `CreateChildAsync` produces children with `Status=Idle, PlanningPhase=None`. **Task-number allocation:** `AddAsync` (line 20) and `CreateChildAsync` (line 276) are the two sole task-creation paths; both call `TaskNumberAllocator.AddWithNumberAsync` to allocate a number atomically during the same transaction as the insert. Every other creation path (UI, MCP `add_task`, `batch_add_tasks`, Online Inbox sync, merge-helper handler tasks, planning children) routes through one of these two.
 - **ListRepository** — CRUD, `GetConfigAsync`/`SetConfigAsync` (upsert)/`DeleteConfigAsync` for `list_config`
 - **WorktreeRepository** — CRUD, `UpdateHeadAsync`, `SetStateAsync`, `SetMergedAsync` (atomically sets State=Merged **and** stamps MergeCommit in one update — the only writer of MergeCommit)
-- **TaskAttachmentRepository** — `AddAsync`, `UpdateAsync`, `GetAsync(taskId, fileName)`, `ListByTaskIdAsync`, `DeleteAsync(taskId, fileName)`, `DeleteAllForTaskAsync`
+- **TaskAttachmentRepository** — `AddAsync`, `UpdateAsync`, `GetAsync(taskId, fileName)`, `ListByTaskIdAsync`, `DeleteAsync(taskId, fileName)`. Bulk delete-per-task is the `ON DELETE CASCADE` on `task_attachments`, not a repository method.
 - **DailyNoteRepository**, **WeekReportRepository**, **TaskRunRepository**, **SubtaskRepository**, **AppSettingsRepository**
 
 `TaskRepository.DeleteAsync` and `ListRepository.DeleteAsync` also delete the on-disk attachment
@@ -74,7 +74,7 @@ dir(s) via an optional `AttachmentStore` ctor param (defaults to the production
 - Worktrees: add (**serialized** to avoid a commondir race), remove, prune, list paths for branch
 - Branches: current, list local, checkout, delete
 - Staging/commit: status porcelain, add-all, add-path, commit via stdin
-- Diffs: working tree, branch vs base, commit range `base..head` (shows a merged task's diff after the worktree is gone), per-file, diff-stat, committed files, has-changes
+- Diffs: working tree, branch vs base, commit range `base..head` (shows a merged task's diff after the worktree is gone), diff-stat, committed files, has-changes
 - Merge: ff-only, no-ff, abort, mid-merge detection (`MERGE_HEAD`), conflicted files
 - Revert: `RevertMergeCommitAsync` (`git revert --no-edit -m 1 <sha>`), `RevertAbortAsync`, `IsMidRevertAsync` (`REVERT_HEAD`, mirrors `IsMidMergeAsync`)
 - `PreviewMergeAsync` (non-destructive check via `git merge-tree --write-tree`), `CountChangedFilesAsync`, rev-parse, is-git-repo

src/ClaudeDo.Data/Git/GitService.cs

@@ -215,15 +215,6 @@ public sealed class GitService
         args.AddRange(paths);
     }
 
-    public async Task<string> GetFileDiffAsync(string worktreePath, string? baseCommit, string relativePath, CancellationToken ct = default)
-    {
-        string[] args = string.IsNullOrEmpty(baseCommit)
-            ? ["diff", "--", relativePath]
-            : ["diff", $"{baseCommit}..HEAD", "--", relativePath];
-        var (_, stdout, _) = await RunGitAsync(worktreePath, args, ct);
-        return stdout;
-    }
-
     public async Task WorktreeRemoveAsync(string repoDir, string worktreePath, bool force = false, CancellationToken ct = default)
     {
         var args = new List<string> { "worktree", "remove" };

src/ClaudeDo.Data/Repositories/SubtaskRepository.cs

@@ -33,9 +33,4 @@ public sealed class SubtaskRepository
     {
         await _context.Subtasks.Where(s => s.Id == subtaskId).ExecuteDeleteAsync(ct);
     }
-
-    public async Task DeleteByTaskIdAsync(string taskId, CancellationToken ct = default)
-    {
-        await _context.Subtasks.Where(s => s.TaskId == taskId).ExecuteDeleteAsync(ct);
-    }
 }

src/ClaudeDo.Data/Repositories/TaskAttachmentRepository.cs

@@ -42,10 +42,4 @@ public sealed class TaskAttachmentRepository
             .ExecuteDeleteAsync(ct);
     }
 
-    public async Task DeleteAllForTaskAsync(string taskId, CancellationToken ct = default)
-    {
-        await _context.TaskAttachments
-            .Where(a => a.TaskId == taskId)
-            .ExecuteDeleteAsync(ct);
-    }
 }

src/ClaudeDo.Data/Repositories/TaskRepository.cs

@@ -84,10 +84,6 @@ public sealed class TaskRepository
         await _context.SaveChangesAsync(ct);
     }
 
-    // Kept for backwards-compatibility with callers using the old name.
-    public Task<List<TaskEntity>> GetByListAsync(string listId, CancellationToken ct = default)
-        => GetByListIdAsync(listId, ct);
-
     /// <summary>
     /// Returns the ids of every descendant of <paramref name="taskId"/> (children, grandchildren, ...),
     /// walking the ParentTaskId chain breadth-first. Does not include the task itself.
@@ -142,15 +138,6 @@ public sealed class TaskRepository
             .ExecuteUpdateAsync(s => s.SetProperty(t => t.SortOrder, (maxSort ?? -1) + 1), ct);
     }
 
-    public async Task<List<TaskEntity>> GetByCreatorAsync(string createdBy, CancellationToken ct = default)
-    {
-        return await _context.Tasks
-            .AsNoTracking()
-            .Where(t => t.CreatedBy == createdBy)
-            .OrderByDescending(t => t.CreatedAt)
-            .ToListAsync(ct);
-    }
-
     /// <summary>
     /// Returns all tasks that qualify as "real" Idle backlog items for online mirroring:
     /// Status==Idle, no parent, PlanningPhase==None, not blocked.

src/ClaudeDo.Data/Repositories/WorktreeRepository.cs

@@ -65,12 +65,4 @@ public sealed class WorktreeRepository
     {
         return await _context.Worktrees.AsNoTracking().ToListAsync(ct);
     }
-
-    public async Task<List<WorktreeEntity>> GetByStatesAsync(
-        IReadOnlyCollection<WorktreeState> states, CancellationToken ct = default)
-    {
-        return await _context.Worktrees.AsNoTracking()
-            .Where(w => states.Contains(w.State))
-            .ToListAsync(ct);
-    }
 }