chore(claude-do): RepoImportFolders auf den WorkerHub-Pfad umziehen (Ui schrei
## Befund (am Code verifiziert 2026-08-06) `AppSettingsEntity.RepoImportFolders` (`src/ClaudeDo.Data/Models/AppSettingsEntity.cs:26`, JSON-Array als TEXT) ist **nicht** Teil des `AppSettingsDto` in `src/ClaudeDo.Worker/Hub/WorkerHub.cs:32-49` und wird weder von `GetAppSettings` (~:375-393) noch von `UpdateAppSettings` (~:396-424) transportiert. Stattdessen liest und schreibt die Ui das Feld dire ClaudeDo-Task: 64fbe15d-ae7e-4d81-b8c1-045baa7e3c87
This commit is contained in:
@@ -79,6 +79,8 @@ public abstract class StubWorkerClient : IWorkerClient
|
||||
public virtual Task RefreshAgentsAsync() => Task.CompletedTask;
|
||||
public virtual Task<SeedResultDto?> RestoreDefaultAgentsAsync() => Task.FromResult<SeedResultDto?>(null);
|
||||
public virtual Task<ListConfigDto?> GetListConfigAsync(string listId) => Task.FromResult<ListConfigDto?>(null);
|
||||
public virtual Task<List<string>> GetRepoImportFoldersAsync() => Task.FromResult(new List<string>());
|
||||
public virtual Task SetRepoImportFoldersAsync(List<string> folders) => Task.CompletedTask;
|
||||
public virtual Task UpdateTaskAgentSettingsAsync(UpdateTaskAgentSettingsDto dto) => Task.CompletedTask;
|
||||
public virtual Task<List<SessionSkillDto>> GetSessionSkillsAsync() => Task.FromResult(new List<SessionSkillDto>());
|
||||
public virtual Task<List<string>> InstallSessionSkillAsync(string url) => Task.FromResult(new List<string>());
|
||||
|
||||
@@ -0,0 +1,114 @@
|
||||
using ClaudeDo.Data;
|
||||
using ClaudeDo.Ui.ViewModels.Modals;
|
||||
using Microsoft.EntityFrameworkCore;
|
||||
|
||||
namespace ClaudeDo.Ui.Tests.ViewModels;
|
||||
|
||||
public sealed class RepoImportModalViewModelTests : IDisposable
|
||||
{
|
||||
private readonly string _dbPath;
|
||||
|
||||
public RepoImportModalViewModelTests()
|
||||
{
|
||||
_dbPath = Path.Combine(Path.GetTempPath(), $"claudedo_repoimport_{Guid.NewGuid():N}.db");
|
||||
using var ctx = NewContext();
|
||||
ctx.Database.EnsureCreated();
|
||||
}
|
||||
|
||||
public void Dispose()
|
||||
{
|
||||
try { File.Delete(_dbPath); } catch { }
|
||||
try { File.Delete(_dbPath + "-wal"); } catch { }
|
||||
try { File.Delete(_dbPath + "-shm"); } catch { }
|
||||
}
|
||||
|
||||
private ClaudeDoDbContext NewContext()
|
||||
{
|
||||
var opts = new DbContextOptionsBuilder<ClaudeDoDbContext>()
|
||||
.UseSqlite($"Data Source={_dbPath}")
|
||||
.Options;
|
||||
return new ClaudeDoDbContext(opts);
|
||||
}
|
||||
|
||||
private sealed class TestDbFactory : IDbContextFactory<ClaudeDoDbContext>
|
||||
{
|
||||
private readonly Func<ClaudeDoDbContext> _create;
|
||||
public TestDbFactory(Func<ClaudeDoDbContext> create) => _create = create;
|
||||
public ClaudeDoDbContext CreateDbContext() => _create();
|
||||
}
|
||||
|
||||
private sealed class FakeWorkerClient : StubWorkerClient
|
||||
{
|
||||
public List<string> Folders = new();
|
||||
public Exception? ThrowOnGet;
|
||||
public Exception? ThrowOnSet;
|
||||
public List<string>? LastSaved;
|
||||
|
||||
public override Task<List<string>> GetRepoImportFoldersAsync()
|
||||
=> ThrowOnGet is not null ? throw ThrowOnGet : Task.FromResult(Folders);
|
||||
|
||||
public override Task SetRepoImportFoldersAsync(List<string> folders)
|
||||
{
|
||||
LastSaved = folders;
|
||||
if (ThrowOnSet is not null) throw ThrowOnSet;
|
||||
return Task.CompletedTask;
|
||||
}
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task LoadAsync_Success_PopulatesFoldersWithoutReportingError()
|
||||
{
|
||||
var worker = new FakeWorkerClient { Folders = new List<string> { @"C:\src" } };
|
||||
var vm = new RepoImportModalViewModel(new TestDbFactory(NewContext), worker);
|
||||
string? reportedError = null;
|
||||
vm.ErrorReported += msg => reportedError = msg;
|
||||
|
||||
await vm.LoadAsync();
|
||||
|
||||
Assert.True(vm.HasFolders);
|
||||
Assert.Null(reportedError);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task LoadAsync_HubFailure_ReportsErrorInsteadOfSilentEmptyList()
|
||||
{
|
||||
var worker = new FakeWorkerClient { ThrowOnGet = new InvalidOperationException("worker offline") };
|
||||
var vm = new RepoImportModalViewModel(new TestDbFactory(NewContext), worker);
|
||||
string? reportedError = null;
|
||||
vm.ErrorReported += msg => reportedError = msg;
|
||||
|
||||
await vm.LoadAsync();
|
||||
|
||||
Assert.False(vm.HasFolders);
|
||||
Assert.NotNull(reportedError);
|
||||
Assert.Contains("worker offline", reportedError);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task AddFoldersAsync_SavesThroughWorkerClient()
|
||||
{
|
||||
var worker = new FakeWorkerClient();
|
||||
var vm = new RepoImportModalViewModel(new TestDbFactory(NewContext), worker);
|
||||
await vm.LoadAsync();
|
||||
|
||||
await vm.AddFoldersAsync(new[] { @"C:\src\new-folder" });
|
||||
|
||||
Assert.NotNull(worker.LastSaved);
|
||||
Assert.Contains(@"C:\src\new-folder", worker.LastSaved!);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task AddFoldersAsync_SaveFailure_ReportsError()
|
||||
{
|
||||
var worker = new FakeWorkerClient { ThrowOnSet = new InvalidOperationException("write failed") };
|
||||
var vm = new RepoImportModalViewModel(new TestDbFactory(NewContext), worker);
|
||||
await vm.LoadAsync();
|
||||
string? reportedError = null;
|
||||
vm.ErrorReported += msg => reportedError = msg;
|
||||
|
||||
await vm.AddFoldersAsync(new[] { @"C:\src\new-folder" });
|
||||
|
||||
Assert.NotNull(reportedError);
|
||||
Assert.Contains("write failed", reportedError);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,73 @@
|
||||
using ClaudeDo.Data.Models;
|
||||
using ClaudeDo.Data.Repositories;
|
||||
using ClaudeDo.Worker.Hub;
|
||||
using ClaudeDo.Worker.Tests.Infrastructure;
|
||||
using Xunit;
|
||||
|
||||
namespace ClaudeDo.Worker.Tests.Hub;
|
||||
|
||||
public sealed class RepoImportFoldersHubTests : IDisposable
|
||||
{
|
||||
private readonly DbFixture _db = new();
|
||||
|
||||
public void Dispose() => _db.Dispose();
|
||||
|
||||
private WorkerHub CreateHub()
|
||||
{
|
||||
var broadcaster = new HubBroadcaster(new CapturingHubContext());
|
||||
var hub = new WorkerHub(
|
||||
null!, null!, null!, null!, broadcaster, _db.CreateFactory(),
|
||||
null!, null!, null!, null!, null!, null!, null!, null!, null!, null!, null!, null!, null!,
|
||||
null!, new ClaudeDo.Worker.Online.OnlineInboxConfig(), new ClaudeDo.Worker.Online.OnlineTokenStore(),
|
||||
new ClaudeDo.Worker.Runner.PendingQuestionRegistry(), null!);
|
||||
hub.Clients = new FakeHubCallerClients(new RecordingClientProxy());
|
||||
hub.Context = new FakeHubCallerContext();
|
||||
return hub;
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task GetRepoImportFolders_NoRow_ReturnsEmptyList()
|
||||
{
|
||||
var hub = CreateHub();
|
||||
|
||||
var folders = await hub.GetRepoImportFolders();
|
||||
|
||||
Assert.Empty(folders);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task SetRepoImportFolders_then_GetRepoImportFolders_RoundTrips()
|
||||
{
|
||||
var hub = CreateHub();
|
||||
|
||||
await hub.SetRepoImportFolders(new List<string> { @"C:\src\repo-a", @"C:\src\repo-b" });
|
||||
var folders = await hub.GetRepoImportFolders();
|
||||
|
||||
Assert.Equal(new List<string> { @"C:\src\repo-a", @"C:\src\repo-b" }, folders);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task SetRepoImportFolders_PersistsSameJsonShapeAsRepository()
|
||||
{
|
||||
var hub = CreateHub();
|
||||
|
||||
await hub.SetRepoImportFolders(new List<string> { @"C:\src\repo-a" });
|
||||
|
||||
using var ctx = _db.CreateContext();
|
||||
var viaRepository = await new AppSettingsRepository(ctx).GetRepoImportFoldersAsync();
|
||||
Assert.Equal(new List<string> { @"C:\src\repo-a" }, viaRepository);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task SetRepoImportFolders_DoesNotClearOtherAppSettings()
|
||||
{
|
||||
var hub = CreateHub();
|
||||
var before = await hub.GetAppSettings();
|
||||
|
||||
await hub.SetRepoImportFolders(new List<string> { @"C:\src\repo-a" });
|
||||
var after = await hub.GetAppSettings();
|
||||
|
||||
Assert.Equal(before.DefaultModel, after.DefaultModel);
|
||||
Assert.Equal(before.DefaultMaxTurns, after.DefaultMaxTurns);
|
||||
}
|
||||
}
|
||||
@@ -51,6 +51,8 @@ sealed class FakeWorkerClient : IWorkerClient
|
||||
public Task RefreshAgentsAsync() => Task.CompletedTask;
|
||||
public Task<SeedResultDto?> RestoreDefaultAgentsAsync() => Task.FromResult<SeedResultDto?>(null);
|
||||
public Task<ListConfigDto?> GetListConfigAsync(string listId) => Task.FromResult<ListConfigDto?>(null);
|
||||
public Task<List<string>> GetRepoImportFoldersAsync() => Task.FromResult(new List<string>());
|
||||
public Task SetRepoImportFoldersAsync(List<string> folders) => Task.CompletedTask;
|
||||
public Task UpdateTaskAgentSettingsAsync(UpdateTaskAgentSettingsDto dto) => Task.CompletedTask;
|
||||
public Task<List<SessionSkillDto>> GetSessionSkillsAsync() => Task.FromResult(new List<SessionSkillDto>());
|
||||
public Task<List<string>> InstallSessionSkillAsync(string url) => Task.FromResult(new List<string>());
|
||||
|
||||
Reference in New Issue
Block a user