releases/ClaudeDo
2
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases 3 Wiki Activity

fix(ui): address code review findings

Browse Source 
- Fix event handler leak in TaskDetailView.OnDataContextChanged
  (unsubscribe from previous ViewModel before subscribing to new one)
- Move FormatFile call off UI thread with Task.Run to prevent freeze
  on large log files

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Mika Kuns
2026-04-14 16:47:46 +02:00
parent f8be2c178b
commit 7363e48496
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/ClaudeDo.Ui/ViewModels/TaskDetailViewModel.cs
View File

@@ -90,7 +90,7 @@ public partial class TaskDetailViewModel : ViewModelBase
&& File.Exists(task.LogPath)) && File.Exists(task.LogPath))
{ {
_formatter = new StreamLineFormatter(); _formatter = new StreamLineFormatter();
LiveText = _formatter.FormatFile(task.LogPath); LiveText = await Task.Run(() => _formatter.FormatFile(task.LogPath));
} }
StatusText = task.Status.ToString().ToLowerInvariant(); StatusText = task.Status.ToString().ToLowerInvariant();
StatusChoice = task.Status.ToString(); StatusChoice = task.Status.ToString();

11
src/ClaudeDo.Ui/Views/TaskDetailView.axaml.cs
View File

@@ -33,13 +33,16 @@ public partial class TaskDetailView : UserControl
this.FindControl<TextBox>("TitleBox")?.Focus(); this.FindControl<TextBox>("TitleBox")?.Focus();
} }
private TaskDetailViewModel? _previousVm;
protected override void OnDataContextChanged(EventArgs e) protected override void OnDataContextChanged(EventArgs e)
{ {
base.OnDataContextChanged(e); base.OnDataContextChanged(e);
if (DataContext is TaskDetailViewModel vm) if (_previousVm is not null)
{ _previousVm.PropertyChanged -= OnViewModelPropertyChanged;
vm.PropertyChanged += OnViewModelPropertyChanged; _previousVm = DataContext as TaskDetailViewModel;
} if (_previousVm is not null)
_previousVm.PropertyChanged += OnViewModelPropertyChanged;
} }
private void OnViewModelPropertyChanged(object? sender, PropertyChangedEventArgs e) private void OnViewModelPropertyChanged(object? sender, PropertyChangedEventArgs e)