fix(ui): stop clipping the last log line in scrollable output
Avalonia 12 leaves ScrollViewer.Padding out of the scroll Extent, so at maximum offset the content still overhangs the viewport by the padding height — the last lines were cut off and unreachable even after ScrollToEnd(). Move the inset onto the content (Margin on the inner ItemsControl/StackPanel) and leave the ScrollViewer padding-free. Affects the work console Output/Git/Session tabs, the reusable session terminal (task + prep log) and the log visualizer.
This commit is contained in:
@@ -269,11 +269,13 @@
|
||||
Command="{Binding RejectReviewCommand}" />
|
||||
</Grid>
|
||||
|
||||
<!-- Inset lives on the content, NOT on the ScrollViewer: Avalonia 12 leaves
|
||||
ScrollViewer.Padding out of the Extent, so at max scroll the last lines
|
||||
sit below the viewport and stay unreachable. -->
|
||||
<ScrollViewer Name="LogScroll"
|
||||
VerticalScrollBarVisibility="Visible"
|
||||
AllowAutoHide="False"
|
||||
Padding="12,8,12,4">
|
||||
<ItemsControl ItemsSource="{Binding Log}">
|
||||
AllowAutoHide="False">
|
||||
<ItemsControl ItemsSource="{Binding Log}" Margin="12,8,12,4">
|
||||
<ItemsControl.ItemTemplate>
|
||||
<DataTemplate DataType="vm:LogLineViewModel">
|
||||
<Grid ColumnDefinitions="60,*" Margin="0,1">
|
||||
@@ -293,8 +295,8 @@
|
||||
</DockPanel>
|
||||
|
||||
<!-- Git: the review + merge cockpit -->
|
||||
<ScrollViewer IsVisible="{Binding IsGitTab}" Padding="14,10">
|
||||
<StackPanel Spacing="14">
|
||||
<ScrollViewer IsVisible="{Binding IsGitTab}">
|
||||
<StackPanel Spacing="14" Margin="14,10">
|
||||
|
||||
<!-- Merge controls — shown whenever there's a worktree / unit to merge.
|
||||
Header reads REVIEW while a decision is pending, otherwise MERGE. -->
|
||||
@@ -393,8 +395,8 @@
|
||||
</ScrollViewer>
|
||||
|
||||
<!-- Session: subtask outcomes (review lives in Output, merge in Git) -->
|
||||
<ScrollViewer IsVisible="{Binding IsSessionTab}" Padding="14,10">
|
||||
<StackPanel Spacing="14">
|
||||
<ScrollViewer IsVisible="{Binding IsSessionTab}">
|
||||
<StackPanel Spacing="14" Margin="14,10">
|
||||
|
||||
<!-- Attention band: a child failed, was cancelled, still needs its own
|
||||
review, or reported roadblocks. The parent stays waiting until resolved. -->
|
||||
|
||||
@@ -51,11 +51,12 @@
|
||||
</Grid>
|
||||
|
||||
<!-- ── Log output ── -->
|
||||
<!-- Inset on the content, not on the ScrollViewer — Avalonia 12 excludes
|
||||
ScrollViewer.Padding from the Extent, which clips the last log lines. -->
|
||||
<ScrollViewer Name="LogScroll"
|
||||
VerticalScrollBarVisibility="Visible"
|
||||
AllowAutoHide="False"
|
||||
Padding="10,8,10,12">
|
||||
<ItemsControl ItemsSource="{Binding #Root.Entries}">
|
||||
AllowAutoHide="False">
|
||||
<ItemsControl ItemsSource="{Binding #Root.Entries}" Margin="10,8,10,12">
|
||||
<ItemsControl.ItemTemplate>
|
||||
<DataTemplate DataType="vm:LogLineViewModel">
|
||||
<Grid ColumnDefinitions="60,*" Margin="0,1">
|
||||
|
||||
Reference in New Issue
Block a user