feat(installer): add SystemCheckPage with blocking-error gating
Adds a new wizard page (positioned right after Welcome, FreshInstall only) that auto-runs EnvironmentCheckService on entry and shows one row per check with status icon, localized title/message, and hint+help-link on failure/unknown. A "Recheck" button re-runs it, guarded against re-entrancy. IInstallerPage gets a BlocksNavigation default member; WizardViewModel's Next button now binds to CanGoNext, which the current page can veto (used here while a check run is in flight or a blocking Error+Failed result is present — Warnings and Unknown results never block). The summary line names the blocking checks so a disabled Next is self-explanatory. Wires up DI for the check pipeline (IProcessRunner, IPortOwnerResolver, per-run ClaudeCliLookup) and adds the checks.* / installer.systemCheck.* locale keys in en.json + de.json. Visual appearance is NOT verified — needs a manual pass in the running installer.
This commit is contained in:
@@ -0,0 +1,43 @@
|
||||
using ClaudeDo.Installer.Core;
|
||||
using ClaudeDo.Installer.Pages.PathsPage;
|
||||
using ClaudeDo.Installer.Pages.ServicePage;
|
||||
using ClaudeDo.Installer.Pages.SystemCheckPage;
|
||||
using ClaudeDo.Installer.Pages.UiSettingsPage;
|
||||
using ClaudeDo.Installer.Pages.WelcomePage;
|
||||
|
||||
namespace ClaudeDo.Installer.Tests;
|
||||
|
||||
public class PageResolverTests
|
||||
{
|
||||
[Fact]
|
||||
public void SystemCheckPage_is_in_the_wizard_directly_after_welcome()
|
||||
{
|
||||
var context = new InstallContext();
|
||||
var pages = new IInstallerPage[]
|
||||
{
|
||||
new WelcomePageViewModel(context),
|
||||
new SystemCheckPageViewModel(context, () => throw new InvalidOperationException()),
|
||||
new PathsPageViewModel(context),
|
||||
new ServicePageViewModel(context),
|
||||
new UiSettingsPageViewModel(context),
|
||||
};
|
||||
|
||||
var resolver = new PageResolver(pages);
|
||||
var wizardPages = resolver.WizardPages;
|
||||
|
||||
var welcomeIndex = wizardPages.ToList().FindIndex(p => p is WelcomePageViewModel);
|
||||
var systemCheckIndex = wizardPages.ToList().FindIndex(p => p is SystemCheckPageViewModel);
|
||||
|
||||
Assert.NotEqual(-1, welcomeIndex);
|
||||
Assert.Equal(welcomeIndex + 1, systemCheckIndex);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SystemCheckPage_is_not_shown_in_settings()
|
||||
{
|
||||
var context = new InstallContext();
|
||||
var page = new SystemCheckPageViewModel(context, () => throw new InvalidOperationException());
|
||||
|
||||
Assert.False(page.ShowInSettings);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user