releases/ClaudeDo
2
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 12 Wiki Activity

refactor(config): consolidate permission modes into PermissionModeRegistry

Browse Source 
Also fixes WorkerHub.UpdateAppSettings falling back to "bypassPermissions"
when AppSettingsEntity and the runtime default are "auto". The fallback
now matches the entity default.
This commit is contained in:
mika kuns
2026-05-19 08:59:16 +02:00
parent a62ef240d1
commit 5308ba3136
3 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/ClaudeDo.Data/Models/PermissionModeRegistry.cs Normal file
View File

@@ -0,0 +1,11 @@
namespace ClaudeDo.Data.Models;
public static class PermissionModeRegistry
{
public static readonly IReadOnlyList<string> Modes = new[]
{
"auto", "bypassPermissions", "acceptEdits", "plan", "default",
};
public const string DefaultMode = "auto";
}

5
src/ClaudeDo.Ui/ViewModels/Modals/Settings/GeneralSettingsTabViewModel.cs
View File

@@ -8,11 +8,10 @@ public sealed partial class GeneralSettingsTabViewModel : ViewModelBase
[ObservableProperty] private string _defaultClaudeInstructions = ""; [ObservableProperty] private string _defaultClaudeInstructions = "";
[ObservableProperty] private string _defaultModel = ModelRegistry.DefaultAlias; [ObservableProperty] private string _defaultModel = ModelRegistry.DefaultAlias;
[ObservableProperty] private int _defaultMaxTurns = 100; [ObservableProperty] private int _defaultMaxTurns = 100;
[ObservableProperty] private string _defaultPermissionMode = "auto"; [ObservableProperty] private string _defaultPermissionMode = PermissionModeRegistry.DefaultMode;
public IReadOnlyList<string> Models { get; } = ModelRegistry.Aliases; public IReadOnlyList<string> Models { get; } = ModelRegistry.Aliases;
public IReadOnlyList<string> PermissionModes { get; } = new[] public IReadOnlyList<string> PermissionModes { get; } = PermissionModeRegistry.Modes;
{ "auto", "bypassPermissions", "acceptEdits", "plan", "default" };
public string? Validate() public string? Validate()
{ {

2
src/ClaudeDo.Worker/Hub/WorkerHub.cs
View File

@@ -212,7 +212,7 @@ public sealed class WorkerHub : Microsoft.AspNetCore.SignalR.Hub
DefaultClaudeInstructions = dto.DefaultClaudeInstructions ?? "", DefaultClaudeInstructions = dto.DefaultClaudeInstructions ?? "",
DefaultModel = dto.DefaultModel ?? ModelRegistry.DefaultAlias, DefaultModel = dto.DefaultModel ?? ModelRegistry.DefaultAlias,
DefaultMaxTurns = dto.DefaultMaxTurns, DefaultMaxTurns = dto.DefaultMaxTurns,
DefaultPermissionMode = dto.DefaultPermissionMode ?? "bypassPermissions", DefaultPermissionMode = dto.DefaultPermissionMode ?? PermissionModeRegistry.DefaultMode,
WorktreeStrategy = dto.WorktreeStrategy ?? "sibling", WorktreeStrategy = dto.WorktreeStrategy ?? "sibling",
CentralWorktreeRoot = dto.CentralWorktreeRoot, CentralWorktreeRoot = dto.CentralWorktreeRoot,
WorktreeAutoCleanupEnabled = dto.WorktreeAutoCleanupEnabled, WorktreeAutoCleanupEnabled = dto.WorktreeAutoCleanupEnabled,