feat(ui): route single-task merge conflicts into a resolution seam
This commit is contained in:
@@ -398,6 +398,10 @@ public sealed partial class DetailsIslandViewModel : ViewModelBase
|
|||||||
// Set by the view so DeleteTaskCommand can show an error message
|
// Set by the view so DeleteTaskCommand can show an error message
|
||||||
public Func<string, System.Threading.Tasks.Task>? ShowErrorAsync { get; set; }
|
public Func<string, System.Threading.Tasks.Task>? ShowErrorAsync { get; set; }
|
||||||
|
|
||||||
|
// Invoked when a single-task merge/approve hits a conflict. Wired by the
|
||||||
|
// integrator to Layer C's conflict resolver. Args: (taskId, targetBranch).
|
||||||
|
public Func<string, string, System.Threading.Tasks.Task>? RequestConflictResolution { get; set; }
|
||||||
|
|
||||||
private static string StatusToStateKey(ClaudeDo.Data.Models.TaskStatus status) => status switch
|
private static string StatusToStateKey(ClaudeDo.Data.Models.TaskStatus status) => status switch
|
||||||
{
|
{
|
||||||
ClaudeDo.Data.Models.TaskStatus.Queued => "queued",
|
ClaudeDo.Data.Models.TaskStatus.Queued => "queued",
|
||||||
@@ -1174,11 +1178,18 @@ public sealed partial class DetailsIslandViewModel : ViewModelBase
|
|||||||
{
|
{
|
||||||
var result = await _worker.MergeTaskAsync(Task.Id, SelectedMergeTarget ?? "", false, "Merge task");
|
var result = await _worker.MergeTaskAsync(Task.Id, SelectedMergeTarget ?? "", false, "Merge task");
|
||||||
if (result.Status == "conflict")
|
if (result.Status == "conflict")
|
||||||
|
{
|
||||||
|
if (RequestConflictResolution is not null)
|
||||||
|
{
|
||||||
|
await RequestConflictResolution(Task.Id, SelectedMergeTarget ?? "");
|
||||||
|
}
|
||||||
|
else
|
||||||
{
|
{
|
||||||
var (text, _, _) = MergePreviewPresenter.Describe(
|
var (text, _, _) = MergePreviewPresenter.Describe(
|
||||||
new MergePreviewDto("conflict", result.ConflictFiles, 0));
|
new MergePreviewDto("conflict", result.ConflictFiles, 0));
|
||||||
MergePreviewText = text; MergeIsClean = false; MergeIsConflict = true;
|
MergePreviewText = text; MergeIsClean = false; MergeIsConflict = true;
|
||||||
}
|
}
|
||||||
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
await RefreshMergePreviewAsync();
|
await RefreshMergePreviewAsync();
|
||||||
@@ -1457,12 +1468,19 @@ public sealed partial class DetailsIslandViewModel : ViewModelBase
|
|||||||
{
|
{
|
||||||
var result = await _worker.ApproveReviewAsync(Task.Id, SelectedMergeTarget ?? "");
|
var result = await _worker.ApproveReviewAsync(Task.Id, SelectedMergeTarget ?? "");
|
||||||
if (result?.Status == "conflict")
|
if (result?.Status == "conflict")
|
||||||
|
{
|
||||||
|
if (RequestConflictResolution is not null)
|
||||||
|
{
|
||||||
|
await RequestConflictResolution(Task.Id, SelectedMergeTarget ?? "");
|
||||||
|
}
|
||||||
|
else
|
||||||
{
|
{
|
||||||
var (text, _, _) = MergePreviewPresenter.Describe(
|
var (text, _, _) = MergePreviewPresenter.Describe(
|
||||||
new MergePreviewDto("conflict", result.ConflictFiles, 0));
|
new MergePreviewDto("conflict", result.ConflictFiles, 0));
|
||||||
MergePreviewText = text; MergeIsClean = false; MergeIsConflict = true;
|
MergePreviewText = text; MergeIsClean = false; MergeIsConflict = true;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
}
|
||||||
catch { /* stale review action; broadcast reconciles */ }
|
catch { /* stale review action; broadcast reconciles */ }
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,96 @@
|
|||||||
|
using System.Collections.ObjectModel;
|
||||||
|
using ClaudeDo.Data;
|
||||||
|
using ClaudeDo.Data.Models;
|
||||||
|
using ClaudeDo.Data.Repositories;
|
||||||
|
using ClaudeDo.Ui.Services;
|
||||||
|
using ClaudeDo.Ui.ViewModels.Islands;
|
||||||
|
using Microsoft.EntityFrameworkCore;
|
||||||
|
using TaskStatus = ClaudeDo.Data.Models.TaskStatus;
|
||||||
|
|
||||||
|
namespace ClaudeDo.Ui.Tests.ViewModels;
|
||||||
|
|
||||||
|
public class DetailsIslandConflictSeamTests : IDisposable
|
||||||
|
{
|
||||||
|
private readonly string _dbPath;
|
||||||
|
|
||||||
|
public DetailsIslandConflictSeamTests()
|
||||||
|
{
|
||||||
|
_dbPath = Path.Combine(Path.GetTempPath(), $"claudedo_conflict_seam_test_{Guid.NewGuid():N}.db");
|
||||||
|
using var ctx = NewContext();
|
||||||
|
ctx.Database.EnsureCreated();
|
||||||
|
}
|
||||||
|
|
||||||
|
public void Dispose()
|
||||||
|
{
|
||||||
|
try { File.Delete(_dbPath); } catch { }
|
||||||
|
try { File.Delete(_dbPath + "-wal"); } catch { }
|
||||||
|
try { File.Delete(_dbPath + "-shm"); } catch { }
|
||||||
|
}
|
||||||
|
|
||||||
|
private ClaudeDoDbContext NewContext()
|
||||||
|
{
|
||||||
|
var opts = new DbContextOptionsBuilder<ClaudeDoDbContext>()
|
||||||
|
.UseSqlite($"Data Source={_dbPath}")
|
||||||
|
.Options;
|
||||||
|
return new ClaudeDoDbContext(opts);
|
||||||
|
}
|
||||||
|
|
||||||
|
private sealed class TestDbFactory : IDbContextFactory<ClaudeDoDbContext>
|
||||||
|
{
|
||||||
|
private readonly Func<ClaudeDoDbContext> _create;
|
||||||
|
public TestDbFactory(Func<ClaudeDoDbContext> create) => _create = create;
|
||||||
|
public ClaudeDoDbContext CreateDbContext() => _create();
|
||||||
|
}
|
||||||
|
|
||||||
|
private sealed class NullServiceProvider : IServiceProvider
|
||||||
|
{
|
||||||
|
public object? GetService(Type serviceType) => null;
|
||||||
|
}
|
||||||
|
|
||||||
|
private sealed class StubNotesApi : ClaudeDo.Ui.Services.Interfaces.INotesApi
|
||||||
|
{
|
||||||
|
public Task<List<ClaudeDo.Ui.Services.DailyNoteDto>> ListAsync(DateOnly day) =>
|
||||||
|
Task.FromResult(new List<ClaudeDo.Ui.Services.DailyNoteDto>());
|
||||||
|
public Task<ClaudeDo.Ui.Services.DailyNoteDto?> AddAsync(DateOnly day, string text) =>
|
||||||
|
Task.FromResult<ClaudeDo.Ui.Services.DailyNoteDto?>(null);
|
||||||
|
public Task UpdateAsync(string id, string text) => Task.CompletedTask;
|
||||||
|
public Task DeleteAsync(string id) => Task.CompletedTask;
|
||||||
|
}
|
||||||
|
|
||||||
|
private sealed class ConflictApproveWorkerClient : StubWorkerClient
|
||||||
|
{
|
||||||
|
public override bool IsConnected => true;
|
||||||
|
public override Task<MergeResultDto?> ApproveReviewAsync(string taskId, string targetBranch) =>
|
||||||
|
Task.FromResult<MergeResultDto?>(new MergeResultDto("conflict", new[] { "a.cs" }, null));
|
||||||
|
}
|
||||||
|
|
||||||
|
private DetailsIslandViewModel BuildVm(StubWorkerClient worker)
|
||||||
|
{
|
||||||
|
var factory = new TestDbFactory(NewContext);
|
||||||
|
return new DetailsIslandViewModel(factory, worker, new NullServiceProvider(), new StubNotesApi());
|
||||||
|
}
|
||||||
|
|
||||||
|
[Fact]
|
||||||
|
public async Task ApproveReview_OnConflict_InvokesConflictResolutionSeam()
|
||||||
|
{
|
||||||
|
const string taskId = "task-conflict-1";
|
||||||
|
|
||||||
|
var vm = BuildVm(new ConflictApproveWorkerClient());
|
||||||
|
vm.Bind(new TaskRowViewModel { Id = taskId, Status = TaskStatus.WaitingForReview });
|
||||||
|
vm.SelectedMergeTarget = "main";
|
||||||
|
|
||||||
|
string? capturedTaskId = null;
|
||||||
|
string? capturedTarget = null;
|
||||||
|
vm.RequestConflictResolution = (tid, target) =>
|
||||||
|
{
|
||||||
|
capturedTaskId = tid;
|
||||||
|
capturedTarget = target;
|
||||||
|
return Task.CompletedTask;
|
||||||
|
};
|
||||||
|
|
||||||
|
await vm.ApproveReviewCommand.ExecuteAsync(null);
|
||||||
|
|
||||||
|
Assert.Equal(taskId, capturedTaskId);
|
||||||
|
Assert.Equal("main", capturedTarget);
|
||||||
|
}
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user