releases/ClaudeDo
2
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 24 Wiki Activity

Merge branch 'claudedo/0733742e0da8407d8e2be1bc5886bf9b'

Browse Source
This commit is contained in:
mika kuns
2026-08-06 11:40:47 +02:00
parent 03c4ed4607 af16830060
commit 4a60c2bfa8
3 changed files with 107 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ClaudeDo.Worker.Tests/External/TaskWaitMcpToolsTests.cs
Vendored
+81 -5
View File
@@ -46,7 +46,7 @@ public sealed class TaskWaitMcpToolsTests : IDisposable
var sut = BuildSut();
var sw = Stopwatch.StartNew();
var result = await sut.WaitForTaskChange([task.Id], timeoutSeconds: 30, CancellationToken.None);
var result = await sut.WaitForTaskChange([task.Id], timeoutSeconds: 30, cancellationToken: CancellationToken.None);
sw.Stop();
Assert.False(result.TimedOut);
@@ -61,7 +61,7 @@ public sealed class TaskWaitMcpToolsTests : IDisposable
var sut = BuildSut();
var sw = Stopwatch.StartNew();
var result = await sut.WaitForTaskChange(["missing-id"], timeoutSeconds: 30, CancellationToken.None);
var result = await sut.WaitForTaskChange(["missing-id"], timeoutSeconds: 30, cancellationToken: CancellationToken.None);
sw.Stop();
Assert.False(result.TimedOut);
@@ -76,7 +76,7 @@ public sealed class TaskWaitMcpToolsTests : IDisposable
var sut = BuildSut();
var sw = Stopwatch.StartNew();
var waitTask = sut.WaitForTaskChange([task.Id], timeoutSeconds: 10, CancellationToken.None);
var waitTask = sut.WaitForTaskChange([task.Id], timeoutSeconds: 10, cancellationToken: CancellationToken.None);
await Task.Delay(150);
// Simulate the status change a broadcast would announce, via a separate context
@@ -104,7 +104,7 @@ public sealed class TaskWaitMcpToolsTests : IDisposable
var sut = BuildSut();
var sw = Stopwatch.StartNew();
var result = await sut.WaitForTaskChange([task.Id], timeoutSeconds: 1, CancellationToken.None);
var result = await sut.WaitForTaskChange([task.Id], timeoutSeconds: 1, cancellationToken: CancellationToken.None);
sw.Stop();
Assert.True(result.TimedOut);
@@ -117,7 +117,83 @@ public sealed class TaskWaitMcpToolsTests : IDisposable
{
var sut = BuildSut();
await Assert.ThrowsAsync<ArgumentException>(() =>
sut.WaitForTaskChange([], timeoutSeconds: 5, CancellationToken.None));
sut.WaitForTaskChange([], timeoutSeconds: 5, cancellationToken: CancellationToken.None));
}
[Fact]
public async Task WaitForTaskChange_WaitingForChildren_DefaultBehavior_ReturnsImmediately()
{
var task = await SeedTaskAsync(TaskStatus.WaitingForChildren);
var sut = BuildSut();
var sw = Stopwatch.StartNew();
var result = await sut.WaitForTaskChange([task.Id], timeoutSeconds: 30, cancellationToken: CancellationToken.None);
sw.Stop();
Assert.False(result.TimedOut);
Assert.Equal("WaitingForChildren", Assert.Single(result.Changed).Status);
Assert.True(sw.Elapsed < TimeSpan.FromSeconds(2), $"took {sw.Elapsed}");
}
[Fact]
public async Task WaitForTaskChange_TreatWaitingForChildrenAsBusy_DoesNotReturnImmediately_TimesOut()
{
var task = await SeedTaskAsync(TaskStatus.WaitingForChildren);
var sut = BuildSut();
var sw = Stopwatch.StartNew();
var result = await sut.WaitForTaskChange(
[task.Id], timeoutSeconds: 1, treatWaitingForChildrenAsBusy: true, cancellationToken: CancellationToken.None);
sw.Stop();
Assert.True(result.TimedOut);
Assert.Empty(result.Changed);
Assert.True(sw.Elapsed >= TimeSpan.FromMilliseconds(900), $"took {sw.Elapsed}");
}
[Fact]
public async Task WaitForTaskChange_TreatWaitingForChildrenAsBusy_ReturnsWhenParentReachesWaitingForReview()
{
var task = await SeedTaskAsync(TaskStatus.WaitingForChildren);
var sut = BuildSut();
var sw = Stopwatch.StartNew();
var waitTask = sut.WaitForTaskChange(
[task.Id], timeoutSeconds: 30, treatWaitingForChildrenAsBusy: true, cancellationToken: CancellationToken.None);
await Task.Delay(150);
await using (var writeCtx = _db.CreateContext())
{
var writeRepo = new TaskRepository(writeCtx);
var loaded = await writeRepo.GetByIdAsync(task.Id);
loaded!.Status = TaskStatus.WaitingForReview;
await writeRepo.UpdateAsync(loaded);
}
var result = await waitTask;
sw.Stop();
// Bound is generous (well under timeoutSeconds) purely to prove this didn't just
// coincidentally land on the timeout path -- correctness is already covered by
// Assert.False(result.TimedOut) above; this is not a performance assertion.
Assert.False(result.TimedOut);
Assert.Equal("WaitingForReview", Assert.Single(result.Changed).Status);
Assert.True(sw.Elapsed < TimeSpan.FromSeconds(25), $"took {sw.Elapsed}");
}
[Fact]
public async Task WaitForTaskChange_TreatWaitingForChildrenAsBusy_UnknownId_StillReturnsImmediatelyAsNotFound()
{
var sut = BuildSut();
var sw = Stopwatch.StartNew();
var result = await sut.WaitForTaskChange(
["missing-id"], timeoutSeconds: 30, treatWaitingForChildrenAsBusy: true, cancellationToken: CancellationToken.None);
sw.Stop();
Assert.False(result.TimedOut);
Assert.Equal("NotFound", Assert.Single(result.Changed).Status);
Assert.True(sw.Elapsed < TimeSpan.FromSeconds(2), $"took {sw.Elapsed}");
}
[Fact]