From 9f90e75a857235f506396ccc32f2a81480d0f50f Mon Sep 17 00:00:00 2001
From: Mika Kuns <mika.kuns@fb-tuning.de>
Date: Wed, 2 Sep 2026 12:17:00 +0200
Subject: [PATCH] refactor(tests): share StubWorkerClient between Ui.Tests and
 Worker.Tests

Worker.Tests carried its own hand-rolled FakeWorkerClient implementing the
whole IWorkerClient surface, duplicating StubWorkerClient in Ui.Tests. Every
hub-signature change had to be applied twice. Link StubWorkerClient.cs into
Worker.Tests via a csproj Compile Include and subclass it there; add
SetTaskStatusCalls tracking to the shared stub (the one behavior Worker.Tests
needed that Ui.Tests didn't have).
---
 tests/ClaudeDo.Ui.Tests/StubWorkerClient.cs   |   7 +-
 .../ClaudeDo.Worker.Tests.csproj              |   4 +
 .../UiVm/TasksIslandViewModelPlanningTests.cs | 184 +-----------------
 3 files changed, 12 insertions(+), 183 deletions(-)

diff --git a/tests/ClaudeDo.Ui.Tests/StubWorkerClient.cs b/tests/ClaudeDo.Ui.Tests/StubWorkerClient.cs
index d9a05bec..5e7a2e35 100644
--- a/tests/ClaudeDo.Ui.Tests/StubWorkerClient.cs
+++ b/tests/ClaudeDo.Ui.Tests/StubWorkerClient.cs
@@ -98,7 +98,12 @@ public abstract class StubWorkerClient : IWorkerClient
     public virtual Task<List<string>> InstallSessionSkillAsync(string url) => Task.FromResult(new List<string>());
     public virtual Task UpdateSessionSkillAsync(string sourceUrl) => Task.CompletedTask;
     public virtual Task RemoveSessionSkillAsync(string sourceUrl) => Task.CompletedTask;
-    public virtual Task<BaseDirtyWarningDto?> SetTaskStatusAsync(string taskId, TaskStatus status) => Task.FromResult<BaseDirtyWarningDto?>(null);
+    public List<(string TaskId, TaskStatus Status)> SetTaskStatusCalls { get; } = new();
+    public virtual Task<BaseDirtyWarningDto?> SetTaskStatusAsync(string taskId, TaskStatus status)
+    {
+        SetTaskStatusCalls.Add((taskId, status));
+        return Task.FromResult<BaseDirtyWarningDto?>(null);
+    }
     public virtual Task SetTaskDoneAsync(string taskId) => Task.CompletedTask;
     public virtual Task UnsetTaskDoneAsync(string taskId) => Task.CompletedTask;
     public virtual Task DequeueTaskAsync(string taskId) => Task.CompletedTask;
diff --git a/tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj b/tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj
index c7d07e4d..87d78bf4 100644
--- a/tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj
+++ b/tests/ClaudeDo.Worker.Tests/ClaudeDo.Worker.Tests.csproj
@@ -22,6 +22,10 @@
     <Using Include="ClaudeDo.Data.Wire" />
   </ItemGroup>
 
+  <ItemGroup>
+    <Compile Include="..\ClaudeDo.Ui.Tests\StubWorkerClient.cs" Link="TestDoubles\StubWorkerClient.cs" />
+  </ItemGroup>
+
   <ItemGroup>
     <ProjectReference Include="..\..\src\ClaudeDo.Worker\ClaudeDo.Worker.csproj" />
     <ProjectReference Include="..\..\src\ClaudeDo.Data\ClaudeDo.Data.csproj" />
diff --git a/tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs b/tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs
index 2956b686..fc4e597d 100644
--- a/tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs
+++ b/tests/ClaudeDo.Worker.Tests/UiVm/TasksIslandViewModelPlanningTests.cs
@@ -2,6 +2,7 @@ using ClaudeDo.Data;
 using ClaudeDo.Data.Models;
 using ClaudeDo.Data.Repositories;
 using ClaudeDo.Ui.Services;
+using ClaudeDo.Ui.Tests;
 using ClaudeDo.Ui.ViewModels.Islands;
 using ClaudeDo.Worker.Tests.Infrastructure;
 using CommunityToolkit.Mvvm.Input;
@@ -13,188 +14,7 @@ namespace ClaudeDo.Worker.Tests.UiVm;
 
 // ── Fake worker client ────────────────────────────────────────────────────────
 
-sealed class FakeWorkerClient : IWorkerClient
-{
-    public int StartPlanningCalls { get; private set; }
-    public int ResumePlanningCalls { get; private set; }
-    public int DiscardPlanningCalls { get; private set; }
-    public int FinalizePlanningCalls { get; private set; }
-    public int WakeQueueCalls { get; private set; }
-    public List<(string TaskId, TaskStatus Status)> SetTaskStatusCalls { get; } = new();
-
-    public bool IsConnected => false;
-    public bool IsReconnecting => false;
-    public string? LastApproveTarget => null;
-#pragma warning disable CS0067 // events required by IWorkerClient but not exercised by this fake
-    public event System.ComponentModel.PropertyChangedEventHandler? PropertyChanged;
-    public event Action<string, string, DateTime>? TaskStartedEvent;
-    public event Action<string, string, string, DateTime>? TaskFinishedEvent;
-    public event Action<string>? TaskUpdatedEvent;
-    public event Action? ConnectionRestoredEvent;
-    public event Action<string>? WorktreeUpdatedEvent;
-    public event Action<string>? ListUpdatedEvent;
-    public event Action<string, string>? TaskMessageEvent;
-    public event Action<WorkerLogEntry>? WorkerLogReceivedEvent;
-    public event Action<string, string, string>? TaskQuestionAskedEvent;
-    public event Action<string, string>? TaskQuestionResolvedEvent;
-    public event Action<string, IReadOnlyList<string>, string>? HandoffRequestedEvent;
-    public void RaiseTaskUpdated(string taskId) => TaskUpdatedEvent?.Invoke(taskId);
-    public void RaiseWorktreeUpdated(string taskId) => WorktreeUpdatedEvent?.Invoke(taskId);
-    public void RaiseTaskMessage(string taskId, string line) => TaskMessageEvent?.Invoke(taskId, line);
-    public void RaiseOperationProgress(string opKey, string phase, int current, int total) => OperationProgressEvent?.Invoke(opKey, phase, current, total);
-
-    public Task RunNowAsync(string taskId) => Task.CompletedTask;
-    public Task ContinueTaskAsync(string taskId, string followUpPrompt) => Task.CompletedTask;
-    public Task AnswerTaskQuestionAsync(string taskId, string questionId, string answer) => Task.CompletedTask;
-    public Task<PendingQuestionDto?> GetPendingQuestionAsync(string taskId) => Task.FromResult<PendingQuestionDto?>(null);
-    public Task ResetTaskAsync(string taskId) => Task.CompletedTask;
-    public Task CancelTaskAsync(string taskId) => Task.CompletedTask;
-    public Task<(bool Ok, string? Error)> DeleteTaskAsync(string taskId) => Task.FromResult<(bool, string?)>((true, null));
-    public Task<List<AgentInfo>> GetAgentsAsync() => Task.FromResult(new List<AgentInfo>());
-    public Task RefreshAgentsAsync() => Task.CompletedTask;
-    public Task<SeedResultDto?> RestoreDefaultAgentsAsync() => Task.FromResult<SeedResultDto?>(null);
-    public Task<ListConfigDto?> GetListConfigAsync(string listId) => Task.FromResult<ListConfigDto?>(null);
-    public Task<List<string>> GetRepoImportFoldersAsync() => Task.FromResult(new List<string>());
-    public Task SetRepoImportFoldersAsync(List<string> folders) => Task.CompletedTask;
-    public Task UpdateTaskAgentSettingsAsync(UpdateTaskAgentSettingsDto dto) => Task.CompletedTask;
-    public Task<List<SessionSkillDto>> GetSessionSkillsAsync() => Task.FromResult(new List<SessionSkillDto>());
-    public Task<List<string>> InstallSessionSkillAsync(string url) => Task.FromResult(new List<string>());
-    public Task UpdateSessionSkillAsync(string sourceUrl) => Task.CompletedTask;
-    public Task RemoveSessionSkillAsync(string sourceUrl) => Task.CompletedTask;
-    public Task<BaseDirtyWarningDto?> SetTaskStatusAsync(string taskId, TaskStatus status)
-    {
-        SetTaskStatusCalls.Add((taskId, status));
-        return Task.FromResult<BaseDirtyWarningDto?>(null);
-    }
-    public Task SetTaskDoneAsync(string taskId) => Task.CompletedTask;
-    public Task UnsetTaskDoneAsync(string taskId) => Task.CompletedTask;
-    public Task DequeueTaskAsync(string taskId) => Task.CompletedTask;
-    public Task<MergeResultDto?> ApproveReviewAsync(string taskId, string targetBranch) => Task.FromResult<MergeResultDto?>(null);
-    public Task<MergePreviewDto?> PreviewMergeAsync(string taskId, string targetBranch) => Task.FromResult<MergePreviewDto?>(null);
-    public Task<MergeResultDto> MergeTaskAsync(string taskId, string targetBranch, bool removeWorktree, string commitMessage) => Task.FromResult(new MergeResultDto("merged", System.Array.Empty<string>(), null));
-    public Task<MergeResultDto> StartConflictMergeAsync(string taskId, string targetBranch) => Task.FromResult(new MergeResultDto("conflict", System.Array.Empty<string>(), null));
-    public Task<MergeConflictDocumentsDto> GetMergeConflictDocumentsAsync(string taskId) => Task.FromResult(new MergeConflictDocumentsDto(taskId, System.Array.Empty<ConflictDocumentDto>()));
-    public Task WriteConflictResolutionAsync(string taskId, string path, string resolvedContent) => Task.CompletedTask;
-    public Task<MergeResultDto> ContinueConflictMergeAsync(string taskId) => Task.FromResult(new MergeResultDto("merged", System.Array.Empty<string>(), null));
-    public Task AbortConflictMergeAsync(string taskId) => Task.CompletedTask;
-    public Task RejectReviewToQueueAsync(string taskId, string feedback) => Task.CompletedTask;
-    public Task RejectReviewToIdleAsync(string taskId) => Task.CompletedTask;
-    public Task CancelReviewAsync(string taskId) => Task.CompletedTask;
-    public Task WakeQueueAsync() { WakeQueueCalls++; return Task.CompletedTask; }
-    public Task StartPlanningSessionAsync(string taskId, CancellationToken ct = default) { StartPlanningCalls++; return Task.CompletedTask; }
-    public Task SubmitTaskForReviewAsync(string taskId, CancellationToken ct = default) => Task.CompletedTask;
-    public Task<LaunchSpec> GetInteractiveLaunchSpecAsync(string taskId, CancellationToken ct = default)
-        => Task.FromResult(new LaunchSpec(".", "claude", Array.Empty<string>(), new Dictionary<string, string>()));
-    public Task<LaunchSpec> GetMergeHelperLaunchSpecAsync(IReadOnlyList<string> taskIds, string listId, string handlerTaskId, CancellationToken ct = default)
-        => Task.FromResult(new LaunchSpec(".", "claude", Array.Empty<string>(), new Dictionary<string, string>()));
-    public Task<string> CreateMergeHelperTaskAsync(
-        IReadOnlyList<string> taskIds, string listId, string title, string descriptionHeader, CancellationToken ct = default)
-        => Task.FromResult(Guid.NewGuid().ToString());
-    public Task<LaunchSpec> GetMergeHelperHandoffLaunchSpecAsync(
-        string taskId, IReadOnlyList<string> survivingTaskIds, string nextPhase, CancellationToken ct = default)
-        => Task.FromResult(new LaunchSpec(".", "claude", Array.Empty<string>(), new Dictionary<string, string>()));
-    public Task<LaunchSpec> GetAdHocLaunchSpecAsync(string directory, CancellationToken ct = default)
-        => Task.FromResult(new LaunchSpec(directory, "claude", Array.Empty<string>(), new Dictionary<string, string>()));
-    public int PlanningStartSpecCalls { get; private set; }
-    public int PlanningResumeSpecCalls { get; private set; }
-    public Task<LaunchSpec> GetPlanningStartLaunchSpecAsync(string taskId, CancellationToken ct = default)
-    { PlanningStartSpecCalls++; return Task.FromResult(new LaunchSpec(".", "claude", Array.Empty<string>(), new Dictionary<string, string>())); }
-    public Task<LaunchSpec> GetPlanningResumeLaunchSpecAsync(string taskId, CancellationToken ct = default)
-    { PlanningResumeSpecCalls++; return Task.FromResult(new LaunchSpec(".", "claude", Array.Empty<string>(), new Dictionary<string, string>())); }
-    public Task QueuePlanningSubtasksAsync(string parentTaskId, CancellationToken ct = default) => Task.CompletedTask;
-    public Task ResumePlanningSessionAsync(string taskId, CancellationToken ct = default) { ResumePlanningCalls++; return Task.CompletedTask; }
-    public Task<DiscardPlanningOutcome> DiscardPlanningSessionAsync(string taskId, bool dequeueQueuedChildren = false, CancellationToken ct = default)
-    {
-        DiscardPlanningCalls++;
-        return Task.FromResult(new DiscardPlanningOutcome(DiscardPlanningResult.Discarded, 0, 0));
-    }
-    public Task FinalizePlanningSessionAsync(string taskId, bool queueAgentTasks = true, CancellationToken ct = default) { FinalizePlanningCalls++; return Task.CompletedTask; }
-    public Task<int> GetPendingDraftCountAsync(string taskId, CancellationToken ct = default) => Task.FromResult(0);
-    public Task<IReadOnlyList<WorkerLogEntry>> GetRecentLogsAsync() => Task.FromResult<IReadOnlyList<WorkerLogEntry>>(System.Array.Empty<WorkerLogEntry>());
-
-    public event Action? NotesUpdatedEvent;
-    public event Action? PrepStartedEvent;
-    public event Action<string>? PrepLineEvent;
-    public event Action<bool>? PrepFinishedEvent;
-    public event Action<string>? RefineStartedEvent;
-    public event Action<string, bool, string?>? RefineFinishedEvent;
-    public event Action<string, string, int, int>? OperationProgressEvent;
-    public event Action<string, string, int>? MergeProgressEvent;
-    public event Action<string, string>? PlanningMergeStartedEvent;
-    public event Action<string, string>? PlanningSubtaskMergedEvent;
-    public event Action<string, string, IReadOnlyList<string>, bool>? PlanningMergeConflictEvent;
-    public event Action<string, string?>? PlanningMergeAbortedEvent;
-    public event Action<string>? PlanningCompletedEvent;
-    public event Action<PrimeFiredEvent>? PrimeFired;
-    public event Action<UsageSnapshotDto>? UsageUpdatedEvent;
-#pragma warning restore CS0067
-
-    public Task<MergeTargetsDto?> GetMergeTargetsAsync(string taskId) => Task.FromResult<MergeTargetsDto?>(null);
-    public Task<IReadOnlyList<SubtaskDiffDto>> GetPlanningAggregateAsync(string planningTaskId) => Task.FromResult<IReadOnlyList<SubtaskDiffDto>>(Array.Empty<SubtaskDiffDto>());
-    public Task<CombinedDiffResultDto?> BuildPlanningIntegrationBranchAsync(string planningTaskId, string targetBranch) => Task.FromResult<CombinedDiffResultDto?>(null);
-    public Task ContinuePlanningMergeAsync(string planningTaskId) => Task.CompletedTask;
-    public Task AbortPlanningMergeAsync(string planningTaskId) => Task.CompletedTask;
-    public Task<IReadOnlyList<PlanningMergeConflictStateDto>> GetActiveExternalPlanningMergeConflictsAsync()
-        => Task.FromResult<IReadOnlyList<PlanningMergeConflictStateDto>>(Array.Empty<PlanningMergeConflictStateDto>());
-
-    public Task<AppSettingsDto?> GetAppSettingsAsync() => Task.FromResult<AppSettingsDto?>(null);
-    public Task UpdateAppSettingsAsync(AppSettingsDto dto) => Task.CompletedTask;
-    public Task<List<PrimeScheduleDto>> GetPrimeSchedulesAsync() => Task.FromResult(new List<PrimeScheduleDto>());
-    public Task<PrimeScheduleDto?> UpsertPrimeScheduleAsync(PrimeScheduleDto dto) => Task.FromResult<PrimeScheduleDto?>(null);
-    public Task DeletePrimeScheduleAsync(Guid id) => Task.CompletedTask;
-    public Task UpdateListAsync(UpdateListDto dto) => Task.CompletedTask;
-    public Task UpdateListConfigAsync(UpdateListConfigDto dto) => Task.CompletedTask;
-    public Task<WorktreeCleanupDto?> CleanupFinishedWorktreesAsync(string? listId = null) => Task.FromResult<WorktreeCleanupDto?>(null);
-    public Task<WorktreeResetDto?> ResetAllWorktreesAsync() => Task.FromResult<WorktreeResetDto?>(null);
-    public Task<List<WorktreeOverviewDto>> GetWorktreesOverviewAsync(string? listId) => Task.FromResult(new List<WorktreeOverviewDto>());
-    public Task<(bool Ok, string? Error)> SetWorktreeStateAsync(string taskId, WorktreeState newState) => Task.FromResult((true, (string?)null));
-    public Task<ForceRemoveResultDto?> ForceRemoveWorktreeAsync(string taskId) => Task.FromResult<ForceRemoveResultDto?>(null);
-    public Task<string?> GetWeekReportAsync(DateOnly start, DateOnly end) => Task.FromResult<string?>(null);
-    public Task<string> GenerateWeekReportAsync(DateOnly start, DateOnly end) => Task.FromResult("");
-    public Task<bool> RunDailyPrepNowAsync() => Task.FromResult(false);
-    public Task ClearMyDayAsync() => Task.CompletedTask;
-    public Task<List<DailyNoteDto>> GetDailyNotesAsync(DateOnly day) => Task.FromResult(new List<DailyNoteDto>());
-    public Task<List<DailyNoteDto>> GetDailyNotesBetweenAsync(DateOnly start, DateOnly end) => Task.FromResult(new List<DailyNoteDto>());
-    public Task<DailyNoteDto?> AddDailyNoteAsync(DateOnly day, string text) => Task.FromResult<DailyNoteDto?>(null);
-    public Task UpdateDailyNoteAsync(string id, string text) => Task.CompletedTask;
-    public Task DeleteDailyNoteAsync(string id) => Task.CompletedTask;
-    public Task<string> GetLastPrepLogAsync() => Task.FromResult(string.Empty);
-    public Task RefineTaskAsync(string taskId) => Task.CompletedTask;
-    public Task<ClaudeBinDto?> GetClaudeBinAsync() => Task.FromResult<ClaudeBinDto?>(null);
-    public Task<ClaudeBinDto?> SetClaudeBinAsync(string? value) => Task.FromResult<ClaudeBinDto?>(null);
-    public Task<OnlineInboxStateDto?> GetOnlineInboxStateAsync() => Task.FromResult<OnlineInboxStateDto?>(null);
-    public Task SetOnlineInboxConfigAsync(OnlineInboxConfigInputDto input) => Task.CompletedTask;
-    public Task SetOnlineInboxAuthAsync(string refreshToken) => Task.CompletedTask;
-    public Task ClearOnlineInboxAuthAsync() => Task.CompletedTask;
-    public IReadOnlyList<ActiveTaskDto> GetActiveTasks() => System.Array.Empty<ActiveTaskDto>();
-
-    public Task<UsageSnapshotDto?> GetUsageSnapshotAsync() => Task.FromResult<UsageSnapshotDto?>(null);
-    public Task<UsageSnapshotDto?> RefreshUsageAsync() => Task.FromResult<UsageSnapshotDto?>(null);
-    public Task<IReadOnlyList<ModelUsageRowDto>> GetModelUsageAsync(DateOnly from, DateOnly to)
-        => Task.FromResult<IReadOnlyList<ModelUsageRowDto>>(System.Array.Empty<ModelUsageRowDto>());
-    public Task<IReadOnlyList<TaskUsageRowDto>> GetTaskUsageAsync(DateOnly from, DateOnly to)
-        => Task.FromResult<IReadOnlyList<TaskUsageRowDto>>(System.Array.Empty<TaskUsageRowDto>());
-
-    public Task<TokenTrackerStatusDto?> GetTokenTrackerStatusAsync() =>
-        Task.FromResult<TokenTrackerStatusDto?>(new TokenTrackerStatusDto(
-            Installed: false, Version: null, NodeOk: true, NodeVersion: "v22.0.0",
-            LastFetchedUtc: null, LastError: null, FormatVersion: null, SessionCount: 0));
-
-    public Task<TokenTrackerStatusDto?> RefreshTokenTrackerAsync() => GetTokenTrackerStatusAsync();
-
-    public Task<TokenTrackerStatusDto?> InstallTokenTrackerAsync() => GetTokenTrackerStatusAsync();
-
-    public Task<TokenTrackerDashboardDto?> OpenTokenTrackerDashboardAsync() =>
-        Task.FromResult<TokenTrackerDashboardDto?>(new TokenTrackerDashboardDto(false, null, "not configured"));
-
-    public Task<TicketSettingsDto?> GetTicketSettingsAsync() => Task.FromResult<TicketSettingsDto?>(null);
-    public Task SetTicketApiBaseUrlAsync(string? baseUrl) => Task.CompletedTask;
-    public Task SetTicketTokenAsync(string token) => Task.CompletedTask;
-    public Task ClearTicketTokenAsync() => Task.CompletedTask;
-    public Task<TicketConnectionDto?> TestTicketConnectionAsync() => Task.FromResult<TicketConnectionDto?>(null);
-    public Task<List<TicketProjectDto>> GetTicketProjectsAsync() => Task.FromResult(new List<TicketProjectDto>());
-    public Task<TicketImportResultDto> ImportTicketsAsync(string listId) => Task.FromResult(new TicketImportResultDto(0, 0));
-}
+sealed class FakeWorkerClient : StubWorkerClient;
 
 // ── Helper to build VM with pre-seeded Items ──────────────────────────────────