releases/ClaudeDo
2
0
Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 24 Wiki Activity

fix(installer): skip rewriting the autostart shortcut when already current

Browse Source 
RegisterAutostartStep rewrote the Startup .lnk on every install/update/repair
even when it already pointed at the right worker exe. AutostartShortcut.Install
now reads the existing shortcut's target via ShortcutFactory.TryGetTarget and
skips the rewrite when it matches, reporting the skip in progress output.
Legacy service/scheduled-task cleanup stays unconditional (migration safety net).
This commit is contained in:
mika kuns
2026-08-06 11:08:15 +02:00
parent cfd2936c25
commit 445242cd7d
5 changed files with 90 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/ClaudeDo.Installer.Tests/AutostartShortcutTests.cs
+46 -1
View File
@@ -22,13 +22,58 @@ public class AutostartShortcutTests
var workerExe = Path.Combine(workerDir, "ClaudeDo.Worker.exe");
File.WriteAllText(workerExe, "");
AutostartShortcut.Install(startup, workerExe);
var created = AutostartShortcut.Install(startup, workerExe);
Assert.True(created);
Assert.True(File.Exists(Path.Combine(startup, AutostartShortcut.FileName)));
}
finally { Directory.Delete(startup, true); Directory.Delete(workerDir, true); }
}
[Fact]
public void Install_is_noop_when_shortcut_already_targets_same_exe()
{
var startup = TempDir();
var workerDir = TempDir();
try
{
var workerExe = Path.Combine(workerDir, "ClaudeDo.Worker.exe");
File.WriteAllText(workerExe, "");
AutostartShortcut.Install(startup, workerExe);
var writtenAt = File.GetLastWriteTimeUtc(Path.Combine(startup, AutostartShortcut.FileName));
var createdAgain = AutostartShortcut.Install(startup, workerExe);
Assert.False(createdAgain);
Assert.Equal(writtenAt, File.GetLastWriteTimeUtc(Path.Combine(startup, AutostartShortcut.FileName)));
}
finally { Directory.Delete(startup, true); Directory.Delete(workerDir, true); }
}
[Fact]
public void Install_rewrites_shortcut_when_target_changed()
{
var startup = TempDir();
var workerDir = TempDir();
try
{
var oldExe = Path.Combine(workerDir, "old", "ClaudeDo.Worker.exe");
Directory.CreateDirectory(Path.GetDirectoryName(oldExe)!);
File.WriteAllText(oldExe, "");
AutostartShortcut.Install(startup, oldExe);
var newExe = Path.Combine(workerDir, "new", "ClaudeDo.Worker.exe");
Directory.CreateDirectory(Path.GetDirectoryName(newExe)!);
File.WriteAllText(newExe, "");
var created = AutostartShortcut.Install(startup, newExe);
Assert.True(created);
Assert.Equal(newExe, ShortcutFactory.TryGetTarget(Path.Combine(startup, AutostartShortcut.FileName)));
}
finally { Directory.Delete(startup, true); Directory.Delete(workerDir, true); }
}
[Fact]
public void Remove_deletes_existing_lnk()
{